)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"872317b4e5c56e9e8cae06aa2c8b46b617293203","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alyson Rosa \u003calyson.rodrigues.rosa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-17 10:51:57 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Manila HNAS driver managing twice a share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila HNAS driver splits the path to manage a share by \u0027:\u0027, so when"},{"line_number":10,"context_line":"passing a path with two colons the last part is ignored, it causes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_7e5d4346","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":45},"updated":"2016-08-17 17:42:10.000000000","message":"if you submit another patch, please fix to \n\"managing a share twice\"","commit_id":"d51efc7da01c131d965964c815afe85e404335e9"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3cce5cd78add33bfd983e132d0bf699d0be3219f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"manila manage --name test2 --share-type hds ubuntu@hnas#Hitachi nfs"},{"line_number":19,"context_line":"172.24.49.26:/shares/f5b21612-9841-42c8-bec4-ca32ba70a9ae:1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also, it breaks if the path is passed with a ip in ipv6 format. Changing"},{"line_number":22,"context_line":"the split to search for \u0027:/\u0027 allows ipv6 to be used and prevents a share to"},{"line_number":23,"context_line":"be managed twice."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3ac371cc_e992f1f4","line":21,"range":{"start_line":21,"start_character":43,"end_line":21,"end_character":44},"updated":"2016-08-18 11:17:56.000000000","message":"an","commit_id":"51f119432c78e5ac863be91627da8b67d1c0e127"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3cce5cd78add33bfd983e132d0bf699d0be3219f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"172.24.49.26:/shares/f5b21612-9841-42c8-bec4-ca32ba70a9ae:1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also, it breaks if the path is passed with a ip in ipv6 format. Changing"},{"line_number":22,"context_line":"the split to search for \u0027:/\u0027 allows ipv6 to be used and prevents a share to"},{"line_number":23,"context_line":"be managed twice."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ie97f749d7093db69a757db7c04041f6f649c7ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3ac371cc_e9a95125","line":22,"updated":"2016-08-18 11:17:56.000000000","message":"this line is too long.","commit_id":"51f119432c78e5ac863be91627da8b67d1c0e127"}],"manila/share/drivers/hitachi/hds_hnas.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"17feb2548f1ae89d4073c6dd5cbcca73cb1f5ff6","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            old_path_info \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027)"},{"line_number":471,"context_line":"            old_path \u003d old_path_info[1].split(\u0027/\u0027)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            if len(old_path) \u003d\u003d 3 and len(old_path_info) \u003d\u003d 2:"},{"line_number":474,"context_line":"                evs_ip \u003d old_path_info[0]"},{"line_number":475,"context_line":"                hnas_share_id \u003d old_path[2]"},{"line_number":476,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_ac36b2e4","line":473,"range":{"start_line":473,"start_character":12,"end_line":473,"end_character":62},"updated":"2016-08-16 20:11:11.000000000","message":"This breaks ipv6 support.","commit_id":"4f23aed90e0a64adf765a88be452a8aeb2e79b93"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"30fe3d4a3b5f3337738d4ec47c250cb4ee43ae76","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            old_path_info \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027)"},{"line_number":471,"context_line":"            old_path \u003d old_path_info[1].split(\u0027/\u0027)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            if len(old_path) \u003d\u003d 3 and len(old_path_info) \u003d\u003d 2:"},{"line_number":474,"context_line":"                evs_ip \u003d old_path_info[0]"},{"line_number":475,"context_line":"                hnas_share_id \u003d old_path[2]"},{"line_number":476,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_63c78764","line":473,"range":{"start_line":473,"start_character":12,"end_line":473,"end_character":62},"in_reply_to":"3ac371cc_ac36b2e4","updated":"2016-08-17 11:11:35.000000000","message":"Actually, what breaks ipv6 is the split in line 470, changing it in next ps.","commit_id":"4f23aed90e0a64adf765a88be452a8aeb2e79b93"}],"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9454d6772d638a82a81e991bbea0532e209398a","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        self._check_protocol(share[\u0027id\u0027], share[\u0027share_proto\u0027])"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if share[\u0027share_proto\u0027].lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":478,"context_line":"            # 10.0.0.1:/shares/example"},{"line_number":479,"context_line":"            LOG.info(_LI(\"Share %(shr_path)s will be managed with ID \""},{"line_number":480,"context_line":"                         \"%(shr_id)s.\"),"},{"line_number":481,"context_line":"                     {\u0027shr_path\u0027: share[\u0027export_locations\u0027][0][\u0027path\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_24002caa","line":478,"range":{"start_line":478,"start_character":24,"end_line":478,"end_character":30},"updated":"2016-08-29 03:13:23.000000000","message":"Just a question. Does you need to check the \u0027shares\u0027 in \u002710.0.0.1:/shares/example\u0027? Because this path is up to user. Is it the same share between \"10.0.0.1:/shares1/example\" and \"10.0.0.1:/shares2/example\"?","commit_id":"edec2494a3cf3253e5202d6e00c604f5c2c6efcb"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c448af657e5f3f292815e7be9fec4a30c3f6f4f6","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        self._check_protocol(share[\u0027id\u0027], share[\u0027share_proto\u0027])"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if share[\u0027share_proto\u0027].lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":478,"context_line":"            # 10.0.0.1:/shares/example"},{"line_number":479,"context_line":"            LOG.info(_LI(\"Share %(shr_path)s will be managed with ID \""},{"line_number":480,"context_line":"                         \"%(shr_id)s.\"),"},{"line_number":481,"context_line":"                     {\u0027shr_path\u0027: share[\u0027export_locations\u0027][0][\u0027path\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_b1efee85","line":478,"range":{"start_line":478,"start_character":24,"end_line":478,"end_character":30},"in_reply_to":"fa7ab95a_24002caa","updated":"2016-08-29 17:49:45.000000000","message":"No, \"10.0.0.1:/shares1/example\" is not the same to \"10.0.0.1:/shares/example\". In this case, manage will fail anyway when checking the export in ensure_share, but I\u0027m adding a verification for it here and giving the proper error msg. Thanks for mentioning it Zhongjun :)","commit_id":"edec2494a3cf3253e5202d6e00c604f5c2c6efcb"}],"manila/tests/share/drivers/hitachi/test_hds_hnas.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3cce5cd78add33bfd983e132d0bf699d0be3219f","unresolved":false,"context_lines":[{"line_number":583,"context_line":"    def test_manage_existing_ipv6(self):"},{"line_number":584,"context_line":"        share \u003d share_nfs.copy()"},{"line_number":585,"context_line":"        share[\u0027export_locations\u0027] \u003d ["},{"line_number":586,"context_line":"            {\u0027path\u0027: \u0027fdca:f995:220a:480:1:1:2e:1:/shares/\u0027 + share[\u0027id\u0027]}]"},{"line_number":587,"context_line":"        expected_out \u003d {\u0027size\u0027: share[\u0027size\u0027],"},{"line_number":588,"context_line":"                        \u0027export_locations\u0027:"},{"line_number":589,"context_line":"                            [share[\u0027export_locations\u0027][0][\u0027path\u0027]]}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_d4bea8ac","line":586,"range":{"start_line":586,"start_character":22,"end_line":586,"end_character":49},"updated":"2016-08-18 11:17:56.000000000","message":"the ipv6 should be wrapped by [], like [fdca:f995:220a:480:1:1:2e:1]","commit_id":"51f119432c78e5ac863be91627da8b67d1c0e127"}],"releasenotes/notes/fix-managing-twice-hnas-4956a7653d27e320.yaml":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3088c7c2d5b61b69090f3aca53f5f2082f94bda4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---                                                                                "},{"line_number":2,"context_line":"fixes:                                                                             "},{"line_number":3,"context_line":"  - Fixed Hitachi HNAS driver allowing a share to be managed twice through"},{"line_number":4,"context_line":"    a malformed export location parameter."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_692aec2d","line":2,"range":{"start_line":1,"start_character":3,"end_line":2,"end_character":82},"updated":"2016-08-16 19:51:34.000000000","message":"lots and lots of trailing spaces","commit_id":"73949007191b24f8ebccafd9a8c896de6f29371c"}]}
