)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"e06e41ce5cd9bafa532a8303365dc489ec4dc728","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding a cleanup to method create_from_snapshot in case of a failure."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Also, raising the correct exception on backend layer in case of a failure"},{"line_number":12,"context_line":"when exporting shares."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I86d2c3c5ff5a790868f8362e065df1eb2be8a3ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_14504031","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":73},"updated":"2016-08-18 11:26:17.000000000","message":"please reduce line size (max 72chars)","commit_id":"91685cdb108e8861ff24fa27dd2c75f939c2b28a"}],"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3c7c53f8fb3bec9fc70e72b4b97f51682939de63","unresolved":false,"context_lines":[{"line_number":821,"context_line":"            else:"},{"line_number":822,"context_line":"                self.hnas.cifs_share_add(share[\u0027id\u0027])"},{"line_number":823,"context_line":"                uri \u003d r\u0027\\\\%s\\%s\u0027 % (self.hnas_evs_ip, share[\u0027id\u0027])"},{"line_number":824,"context_line":"            return uri"},{"line_number":825,"context_line":"        except exception.HNASBackendException as e:"},{"line_number":826,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":827,"context_line":"                self.hnas.vvol_delete(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_394bf188","line":824,"updated":"2016-08-29 07:46:58.000000000","message":"suggest moving this line after exception handler.","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1685df6aff7725b6c778f31ba3d52add95e45c9f","unresolved":false,"context_lines":[{"line_number":826,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":827,"context_line":"                self.hnas.vvol_delete(share[\u0027id\u0027])"},{"line_number":828,"context_line":"                msg \u003d six.text_type(e)"},{"line_number":829,"context_line":"                LOG.exception(msg)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def _check_protocol(self, share_id, protocol):"},{"line_number":832,"context_line":"        if protocol.lower() not in (\u0027nfs\u0027, \u0027cifs\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_64ba8970","line":829,"range":{"start_line":829,"start_character":20,"end_line":829,"end_character":29},"updated":"2016-09-09 10:05:26.000000000","message":"LOG.exception does attach trace automatically, you do not need to provide here translated to str exception.\nSo, it means, you can call LOG.exception only when trace exists and should only provide some human-friendly message in it keeping in mind that trace will be automatically attached.","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3c7c53f8fb3bec9fc70e72b4b97f51682939de63","unresolved":false,"context_lines":[{"line_number":826,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":827,"context_line":"                self.hnas.vvol_delete(share[\u0027id\u0027])"},{"line_number":828,"context_line":"                msg \u003d six.text_type(e)"},{"line_number":829,"context_line":"                LOG.exception(msg)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def _check_protocol(self, share_id, protocol):"},{"line_number":832,"context_line":"        if protocol.lower() not in (\u0027nfs\u0027, \u0027cifs\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_5999951e","line":829,"updated":"2016-08-29 07:46:58.000000000","message":"suggest log first, then try vvol_delete","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a6cb0908dd5abf6cc0be9f4799056a65e983f529","unresolved":false,"context_lines":[{"line_number":824,"context_line":"            return uri"},{"line_number":825,"context_line":"        except exception.HNASBackendException as e:"},{"line_number":826,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":827,"context_line":"                msg \u003d _(\u0027Failed to create share %(share_id)s from snapshot \u0027"},{"line_number":828,"context_line":"                        \u0027%(snap)s. Reason: %(e)s\u0027)"},{"line_number":829,"context_line":"                LOG.error(msg % {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":830,"context_line":"                                 \u0027snap\u0027: snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_37f01afd","line":827,"range":{"start_line":827,"start_character":22,"end_line":827,"end_character":24},"updated":"2016-09-13 11:25:30.000000000","message":"Shouldn\u0027t this be _LE()?  And if you use LOG.exception, it\u0027s not necessary to include the exception in the error message.","commit_id":"d2417d66d6eccdd8b081d3b515f7808d5dd1b5ad"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0de914d791f86a210b4ca7d645133d23f578ed15","unresolved":false,"context_lines":[{"line_number":824,"context_line":"            return uri"},{"line_number":825,"context_line":"        except exception.HNASBackendException as e:"},{"line_number":826,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":827,"context_line":"                msg \u003d _(\u0027Failed to create share %(share_id)s from snapshot \u0027"},{"line_number":828,"context_line":"                        \u0027%(snap)s. Reason: %(e)s\u0027)"},{"line_number":829,"context_line":"                LOG.error(msg % {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":830,"context_line":"                                 \u0027snap\u0027: snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_76f37673","line":827,"range":{"start_line":827,"start_character":22,"end_line":827,"end_character":24},"in_reply_to":"9a89bdaa_37f01afd","updated":"2016-09-13 14:40:14.000000000","message":"Clinton is right.\n\nShould be:\n\n\"\"\"\nexcept exception.HNASBackendException as e:\n    with excutils.save_and_reraise_exception():\n        msg \u003d _LE(\u0027Failed to create share %(share_id)s from snapshot %(snap_id)s\u0027)\n        LOG.exception(msg, {\u0027share_id\u0027: share[\u0027id\u0027], \u0027snap_id\u0027: snapshot[\u0027id\u0027])\n        self.hnas.vvol_delete(share[\u0027id\u0027])\n\"\"\"","commit_id":"d2417d66d6eccdd8b081d3b515f7808d5dd1b5ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd44a5514e20859c28c3e82a9ae95e2a2d1b75a8","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            return uri"},{"line_number":826,"context_line":"        except exception.HNASBackendException:"},{"line_number":827,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":828,"context_line":"                msg \u003d _LE(\u0027Failed to create share %(share_id)s from snapshot \u0027"},{"line_number":829,"context_line":"                          \u0027%(snap)s.\u0027)"},{"line_number":830,"context_line":"                LOG.exception(msg, {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":831,"context_line":"                                    \u0027snap\u0027: snapshot[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_736078cf","line":828,"range":{"start_line":828,"start_character":22,"end_line":828,"end_character":25},"updated":"2016-09-14 12:52:20.000000000","message":"according to the other comments, this should not be _LE, should be _()","commit_id":"f54d9636df0ff6b9173f029677af8f26008b4155"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"0a0935dbb7e229ac151a550cd6c82054d766e7c9","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            return uri"},{"line_number":826,"context_line":"        except exception.HNASBackendException:"},{"line_number":827,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":828,"context_line":"                msg \u003d _LE(\u0027Failed to create share %(share_id)s from snapshot \u0027"},{"line_number":829,"context_line":"                          \u0027%(snap)s.\u0027)"},{"line_number":830,"context_line":"                LOG.exception(msg, {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":831,"context_line":"                                    \u0027snap\u0027: snapshot[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_f6aab6d3","line":828,"range":{"start_line":828,"start_character":22,"end_line":828,"end_character":25},"in_reply_to":"7a8ec9b2_736078cf","updated":"2016-09-14 13:04:45.000000000","message":"-1\n\n_LE() is correct here, because the message is only going to the log.\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"f54d9636df0ff6b9173f029677af8f26008b4155"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"079449a14f33691800c1eb239c48a071438a5024","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            return uri"},{"line_number":826,"context_line":"        except exception.HNASBackendException:"},{"line_number":827,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":828,"context_line":"                msg \u003d _LE(\u0027Failed to create share %(share_id)s from snapshot \u0027"},{"line_number":829,"context_line":"                          \u0027%(snap)s.\u0027)"},{"line_number":830,"context_line":"                LOG.exception(msg, {\u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":831,"context_line":"                                    \u0027snap\u0027: snapshot[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_561b6a1b","line":828,"range":{"start_line":828,"start_character":22,"end_line":828,"end_character":25},"in_reply_to":"7a8ec9b2_f6aab6d3","updated":"2016-09-14 13:06:28.000000000","message":"oh I understand now, because it is not raising the exception. Thanks Clinton!","commit_id":"f54d9636df0ff6b9173f029677af8f26008b4155"}],"manila/share/drivers/hitachi/hnas/ssh.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1685df6aff7725b6c778f31ba3d52add95e45c9f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._execute(command)"},{"line_number":72,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":73,"context_line":"            msg \u003d six.text_type(e)"},{"line_number":74,"context_line":"            LOG.exception(msg)"},{"line_number":75,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def nfs_export_del(self, share_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_244ec196","line":74,"range":{"start_line":73,"start_character":12,"end_line":74,"end_character":30},"updated":"2016-09-09 10:05:26.000000000","message":"Same as in https://review.openstack.org/#/c/356087/5/manila/share/drivers/hitachi/hnas/driver.py","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1685df6aff7725b6c778f31ba3d52add95e45c9f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self._execute(command)"},{"line_number":97,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":98,"context_line":"            msg \u003d six.text_type(e)"},{"line_number":99,"context_line":"            LOG.exception(msg)"},{"line_number":100,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def cifs_share_del(self, share_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_6448c988","line":99,"range":{"start_line":98,"start_character":12,"end_line":99,"end_character":30},"updated":"2016-09-09 10:05:26.000000000","message":"Same as in https://review.openstack.org/#/c/356087/5/manila/share/drivers/hitachi/hnas/driver.py","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"aec510c590ee3cd8bff2548b77c7a902dc1612a6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._execute(command)"},{"line_number":72,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":73,"context_line":"            msg \u003d _(\"Could not create nfs export %(nfs)s. Reason: %(e)s\")"},{"line_number":74,"context_line":"            LOG.exception(msg % {\u0027nfs\u0027: share_id, \u0027e\u0027: six.text_type(e)})"},{"line_number":75,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_dad22934","line":73,"range":{"start_line":73,"start_character":38,"end_line":73,"end_character":41},"updated":"2016-09-09 20:18:53.000000000","message":"uppercase","commit_id":"2bfb9d22089111294b8cb28b9f7d1c7f8da2100a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"aec510c590ee3cd8bff2548b77c7a902dc1612a6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self._execute(command)"},{"line_number":97,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":98,"context_line":"            msg \u003d _(\"Could not create cifs share %(cifs)s. Reason: %(e)s\")"},{"line_number":99,"context_line":"            LOG.exception(msg % {\u0027cifs\u0027: share_id, \u0027e\u0027: six.text_type(e)})"},{"line_number":100,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_ba1565e6","line":98,"range":{"start_line":98,"start_character":38,"end_line":98,"end_character":42},"updated":"2016-09-09 20:18:53.000000000","message":"uppercase","commit_id":"2bfb9d22089111294b8cb28b9f7d1c7f8da2100a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6f800011eec0d02ce77991d30316e8c5db176600","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._execute(command)"},{"line_number":72,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":73,"context_line":"            msg \u003d _(\"Could not create NFS export %(nfs)s. Reason: %(e)s\")"},{"line_number":74,"context_line":"            LOG.exception(msg % {\u0027nfs\u0027: share_id, \u0027e\u0027: six.text_type(e)})"},{"line_number":75,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def nfs_export_del(self, share_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_691dcf65","line":74,"range":{"start_line":73,"start_character":12,"end_line":74,"end_character":73},"updated":"2016-09-10 16:51:11.000000000","message":"with LOG.exception you don\u0027t pass in the exception trace itself (here: e), directly or indirectly.  So just have msg \u003d_(\"Could not create NFS export ... without the \u0027Reason: ...\u0027 part.\n\nExample: https://github.com/openstack/manila/blob/master/manila/share/manager.py#L780","commit_id":"0c26360fcc3b41c596d0aaade281e74b9f22ae8b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6f800011eec0d02ce77991d30316e8c5db176600","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self._execute(command)"},{"line_number":97,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":98,"context_line":"            msg \u003d _(\"Could not create CIFS share %(cifs)s. Reason: %(e)s\")"},{"line_number":99,"context_line":"            LOG.exception(msg % {\u0027cifs\u0027: share_id, \u0027e\u0027: six.text_type(e)})"},{"line_number":100,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def cifs_share_del(self, share_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_89185377","line":99,"range":{"start_line":98,"start_character":11,"end_line":99,"end_character":74},"updated":"2016-09-10 16:51:11.000000000","message":"ditto","commit_id":"0c26360fcc3b41c596d0aaade281e74b9f22ae8b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3d0b92ce9515e529f93c478ea9f46f4f9d504c6e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._execute(command)"},{"line_number":72,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":73,"context_line":"            msg \u003d (_(\"Could not create NFS export %s.\") % share_id)"},{"line_number":74,"context_line":"            LOG.exception(msg)"},{"line_number":75,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_0e724e11","line":73,"range":{"start_line":73,"start_character":18,"end_line":73,"end_character":67},"updated":"2016-09-12 16:49:13.000000000","message":"redundant parenthesis","commit_id":"d2417d66d6eccdd8b081d3b515f7808d5dd1b5ad"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3d0b92ce9515e529f93c478ea9f46f4f9d504c6e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self._execute(command)"},{"line_number":97,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":98,"context_line":"            msg \u003d (_(\"Could not create CIFS share %s.\") % share_id)"},{"line_number":99,"context_line":"            LOG.exception(msg)"},{"line_number":100,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_2e61d239","line":98,"range":{"start_line":98,"start_character":18,"end_line":98,"end_character":67},"updated":"2016-09-12 16:49:13.000000000","message":"same as above","commit_id":"d2417d66d6eccdd8b081d3b515f7808d5dd1b5ad"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a8cd0ba17e00d383db3de6e60a1a84ad798935e8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._execute(command)"},{"line_number":72,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":73,"context_line":"            msg \u003d _(\"Could not create NFS export %s.\") % share_id"},{"line_number":74,"context_line":"            LOG.exception(msg)"},{"line_number":75,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_e05f6873","line":73,"range":{"start_line":73,"start_character":18,"end_line":73,"end_character":19},"updated":"2016-09-14 03:13:24.000000000","message":"as Clinton said, here should be _LE","commit_id":"f54d9636df0ff6b9173f029677af8f26008b4155"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a534c7664f358eac603c14fe0aa0db72f092196c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._execute(command)"},{"line_number":72,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":73,"context_line":"            msg \u003d _(\"Could not create NFS export %s.\") % share_id"},{"line_number":74,"context_line":"            LOG.exception(msg)"},{"line_number":75,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_d125d2c2","line":73,"range":{"start_line":73,"start_character":18,"end_line":73,"end_character":19},"in_reply_to":"7a8ec9b2_e05f6873","updated":"2016-09-14 10:10:37.000000000","message":"-1  This is passed to an exception, so _() is correct.","commit_id":"f54d9636df0ff6b9173f029677af8f26008b4155"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a8cd0ba17e00d383db3de6e60a1a84ad798935e8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self._execute(command)"},{"line_number":97,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":98,"context_line":"            msg \u003d _(\"Could not create CIFS share %s.\") % share_id"},{"line_number":99,"context_line":"            LOG.exception(msg)"},{"line_number":100,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_405f3c72","line":98,"range":{"start_line":98,"start_character":18,"end_line":98,"end_character":19},"updated":"2016-09-14 03:13:24.000000000","message":"ditto","commit_id":"f54d9636df0ff6b9173f029677af8f26008b4155"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a534c7664f358eac603c14fe0aa0db72f092196c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self._execute(command)"},{"line_number":97,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":98,"context_line":"            msg \u003d _(\"Could not create CIFS share %s.\") % share_id"},{"line_number":99,"context_line":"            LOG.exception(msg)"},{"line_number":100,"context_line":"            raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_b1404658","line":98,"range":{"start_line":98,"start_character":18,"end_line":98,"end_character":19},"in_reply_to":"7a8ec9b2_405f3c72","updated":"2016-09-14 10:10:37.000000000","message":"-1","commit_id":"f54d9636df0ff6b9173f029677af8f26008b4155"}],"manila/tests/share/drivers/hitachi/hnas/test_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1685df6aff7725b6c778f31ba3d52add95e45c9f","unresolved":false,"context_lines":[{"line_number":705,"context_line":"    def test_create_share_from_snapshot_cleanup(self):"},{"line_number":706,"context_line":"        self.mock_object(driver.HitachiHNASDriver, \"_check_fs_mounted\","},{"line_number":707,"context_line":"                         mock.Mock())"},{"line_number":708,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"vvol_create\", mock.Mock())"},{"line_number":709,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"quota_add\", mock.Mock())"},{"line_number":710,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"tree_clone\", mock.Mock())"},{"line_number":711,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"vvol_delete\", mock.Mock())"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_2435e1f6","line":708,"range":{"start_line":708,"start_character":60,"end_line":708,"end_character":71},"updated":"2016-09-09 10:05:26.000000000","message":"Redundant, same for others except last one, that differs from default value.","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1685df6aff7725b6c778f31ba3d52add95e45c9f","unresolved":false,"context_lines":[{"line_number":715,"context_line":""},{"line_number":716,"context_line":"        self.assertRaises(exception.HNASBackendException,"},{"line_number":717,"context_line":"                          self._driver.create_share_from_snapshot,"},{"line_number":718,"context_line":"                          \u0027context\u0027, share_nfs, snapshot_nfs)"},{"line_number":719,"context_line":"        ssh.HNASSSHBackend.vvol_delete.assert_called_once_with("},{"line_number":720,"context_line":"            snapshot_nfs[\u0027share_id\u0027])"},{"line_number":721,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_c42ef5a4","line":718,"updated":"2016-09-09 10:05:26.000000000","message":"Please, separate func call with empty lines.","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1685df6aff7725b6c778f31ba3d52add95e45c9f","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        self.assertRaises(exception.HNASBackendException,"},{"line_number":717,"context_line":"                          self._driver.create_share_from_snapshot,"},{"line_number":718,"context_line":"                          \u0027context\u0027, share_nfs, snapshot_nfs)"},{"line_number":719,"context_line":"        ssh.HNASSSHBackend.vvol_delete.assert_called_once_with("},{"line_number":720,"context_line":"            snapshot_nfs[\u0027share_id\u0027])"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def test__check_fs_mounted(self):"},{"line_number":723,"context_line":"        self._driver._check_fs_mounted()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_fffd4009","line":720,"range":{"start_line":719,"start_character":8,"end_line":720,"end_character":37},"updated":"2016-09-09 10:05:26.000000000","message":"Why only one mocked object has assertion of call?","commit_id":"3be9dba609a41c2df8e6404e3e6858e297718cde"}],"releasenotes/notes/add-cleanup-create-from-snap-hnas-0e0431f1fc861a4e.yaml":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9d20783a568268e4aafdc9ffbaeec7c2bd303c26","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Hitachi HNAS driver now clean up data in backend when create"},{"line_number":4,"context_line":"    from snapshot fails."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ac371cc_0a8051bf","line":3,"range":{"start_line":3,"start_character":28,"end_line":3,"end_character":33},"updated":"2016-08-17 16:34:10.000000000","message":"cleans.\n\nSuggestion: Fixed Hitachi HNAS driver not cleaning up data in backend when failing to create a share from snapshot.","commit_id":"9a18d29c3d08d3f62f4651eb0ba4ca3e9016c72f"}]}
