)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: Goutham Pacha Ravi \u003cgouthamr@netapp.com\u003e"},{"line_number":28,"context_line":"Implements: blueprint add-create-share-from-snapshot-extra-spec"},{"line_number":29,"context_line":"Depends-On: Ic32a8a17b1b6a773de6dcf7792d9b37f6aed4a3c"},{"line_number":30,"context_line":"Change-Id: Ib0ad5fbfdf6297665c208149b08c8d21b3c232be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1a6eadb0_5e615738","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":53},"updated":"2016-12-21 12:49:29.000000000","message":"Please, remove it if you upload new patch set.","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: Goutham Pacha Ravi \u003cgouthamr@netapp.com\u003e"},{"line_number":28,"context_line":"Implements: blueprint add-create-share-from-snapshot-extra-spec"},{"line_number":29,"context_line":"Depends-On: Ic32a8a17b1b6a773de6dcf7792d9b37f6aed4a3c"},{"line_number":30,"context_line":"Change-Id: Ib0ad5fbfdf6297665c208149b08c8d21b3c232be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1a6eadb0_144a5b26","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":53},"in_reply_to":"1a6eadb0_5e615738","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":78,"context_line":"iniset $TEMPEST_CONFIG share run_replication_tests $RUN_MANILA_REPLICATION_TESTS"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Capability \"create_share_from_snapshot_support\""},{"line_number":81,"context_line":"CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT\u003d${CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:-True}"},{"line_number":82,"context_line":"iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support $CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":85,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_29e4990b","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":121},"updated":"2016-12-02 18:30:10.000000000","message":"Why do you need it when you redefine it below for each specific driver?","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"iniset $TEMPEST_CONFIG share run_replication_tests $RUN_MANILA_REPLICATION_TESTS"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Capability \"create_share_from_snapshot_support\""},{"line_number":81,"context_line":"CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT\u003d${CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:-True}"},{"line_number":82,"context_line":"iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support $CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":85,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_e42ed8a3","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":121},"in_reply_to":"3a71b18c_29e4990b","updated":"2016-12-06 15:35:37.000000000","message":"This would benefit third party drivers overriding this option. For the first party drivers however, It\u0027s only explicit to redefine it...","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afa85e76fdff2b17112cb5649d9955151429e9fb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"iniset $TEMPEST_CONFIG share run_replication_tests $RUN_MANILA_REPLICATION_TESTS"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Capability \"create_share_from_snapshot_support\""},{"line_number":81,"context_line":"CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT\u003d${CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:-True}"},{"line_number":82,"context_line":"iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support $CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":85,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_d9c30c56","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":121},"in_reply_to":"3a71b18c_868933cd","updated":"2016-12-08 18:16:30.000000000","message":"I source this file in the NetApp CI, i don\u0027t see how this is a problem as opposed to all the RUN_MANILA_x_TESTS above this. Which specific line are you asking me to remove?","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5886a46bdbf29f623d63e2d5fb4a0733711b5083","unresolved":false,"context_lines":[{"line_number":78,"context_line":"iniset $TEMPEST_CONFIG share run_replication_tests $RUN_MANILA_REPLICATION_TESTS"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Capability \"create_share_from_snapshot_support\""},{"line_number":81,"context_line":"CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT\u003d${CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:-True}"},{"line_number":82,"context_line":"iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support $CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":85,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_868933cd","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":121},"in_reply_to":"3a71b18c_e42ed8a3","updated":"2016-12-08 18:06:53.000000000","message":"Third-party drivers do not use THIS file. It is useless.","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    iniset $TEMPEST_CONFIG share run_shrink_tests False"},{"line_number":164,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027nfs\u0027"},{"line_number":165,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"},{"line_number":166,"context_line":"    if ! grep $USERNAME_FOR_USER_RULES \"/etc/passwd\"; then"},{"line_number":167,"context_line":"        sudo useradd $USERNAME_FOR_USER_RULES"},{"line_number":168,"context_line":"    fi"},{"line_number":169,"context_line":"    (echo $PASSWORD_FOR_SAMBA_USER; echo $PASSWORD_FOR_SAMBA_USER) | sudo smbpasswd -s -a $USERNAME_FOR_USER_RULES"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_69ee91ed","line":166,"updated":"2016-12-02 18:30:10.000000000","message":"iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    iniset $TEMPEST_CONFIG share run_shrink_tests False"},{"line_number":164,"context_line":"    iniset $TEMPEST_CONFIG share enable_ip_rules_for_protocols \u0027nfs\u0027"},{"line_number":165,"context_line":"    iniset $TEMPEST_CONFIG share enable_user_rules_for_protocols \u0027cifs\u0027"},{"line_number":166,"context_line":"    if ! grep $USERNAME_FOR_USER_RULES \"/etc/passwd\"; then"},{"line_number":167,"context_line":"        sudo useradd $USERNAME_FOR_USER_RULES"},{"line_number":168,"context_line":"    fi"},{"line_number":169,"context_line":"    (echo $PASSWORD_FOR_SAMBA_USER; echo $PASSWORD_FOR_SAMBA_USER) | sudo smbpasswd -s -a $USERNAME_FOR_USER_RULES"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_8759a637","line":166,"in_reply_to":"3a71b18c_69ee91ed","updated":"2016-12-06 15:35:37.000000000","message":"Done","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_tests True"},{"line_number":271,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests True"},{"line_number":272,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests True"},{"line_number":273,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":274,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled False"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_09dfdd69","line":273,"range":{"start_line":273,"start_character":4,"end_line":273,"end_character":83},"updated":"2016-12-02 18:30:10.000000000","message":"It is already set on line 214","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_tests True"},{"line_number":271,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests True"},{"line_number":272,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests True"},{"line_number":273,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":274,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled False"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_c7ad5eea","line":273,"range":{"start_line":273,"start_character":4,"end_line":273,"end_character":83},"in_reply_to":"3a71b18c_09dfdd69","updated":"2016-12-06 15:35:37.000000000","message":"You mean 82?","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5886a46bdbf29f623d63e2d5fb4a0733711b5083","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_tests True"},{"line_number":271,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests True"},{"line_number":272,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests True"},{"line_number":273,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":274,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled False"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_e67ca7b7","line":273,"range":{"start_line":273,"start_character":4,"end_line":273,"end_character":83},"in_reply_to":"3a71b18c_c7ad5eea","updated":"2016-12-08 18:06:53.000000000","message":"No, exactly on line 214. THIS block of code is executed only with dummy driver that has already defined this option.","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afa85e76fdff2b17112cb5649d9955151429e9fb","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_tests True"},{"line_number":271,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests True"},{"line_number":272,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests True"},{"line_number":273,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":274,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled False"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_79a3d89e","line":273,"range":{"start_line":273,"start_character":4,"end_line":273,"end_character":83},"in_reply_to":"3a71b18c_e67ca7b7","updated":"2016-12-08 18:16:30.000000000","message":"oh. i get it now. Will remove","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    # DHSS\u003dFalse backends."},{"line_number":279,"context_line":"    source $BASE/new/devstack/openrc admin demo"},{"line_number":280,"context_line":"    manila type-key default set driver_handles_share_servers\u003dFalse"},{"line_number":281,"context_line":"    manila type-key default set snapshot_support\u003dTrue"},{"line_number":282,"context_line":"    manila type-key default set create_share_from_snapshot_support\u003dTrue"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    echo \"Running tempest manila test suites for DHSS\u003dFalse mode\""},{"line_number":285,"context_line":"    sudo -H -u jenkins tox -eall-plugin $MANILA_TESTS -- --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_695211df","line":282,"range":{"start_line":281,"start_character":4,"end_line":282,"end_character":71},"updated":"2016-12-02 18:30:10.000000000","message":"It is useless here. It is SECOND run of tempest. So, tempest would fail on first run if such change was required. Should be removed here. May be added before first tempest run.","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    # DHSS\u003dFalse backends."},{"line_number":279,"context_line":"    source $BASE/new/devstack/openrc admin demo"},{"line_number":280,"context_line":"    manila type-key default set driver_handles_share_servers\u003dFalse"},{"line_number":281,"context_line":"    manila type-key default set snapshot_support\u003dTrue"},{"line_number":282,"context_line":"    manila type-key default set create_share_from_snapshot_support\u003dTrue"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    echo \"Running tempest manila test suites for DHSS\u003dFalse mode\""},{"line_number":285,"context_line":"    sudo -H -u jenkins tox -eall-plugin $MANILA_TESTS -- --concurrency\u003d$MANILA_TEMPEST_CONCURRENCY"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3a71b18c_47ef8e1d","line":282,"range":{"start_line":281,"start_character":4,"end_line":282,"end_character":71},"in_reply_to":"3a71b18c_695211df","updated":"2016-12-06 15:35:37.000000000","message":"Done","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"99f2d037053af885dc458cbf6c0ab31a1629b5b9","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share create_networks_when_multitenancy_enabled False"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    # Set the default share type extra-specs to run snapshot tests"},{"line_number":224,"context_line":"    manila type-key default set snapshot_support\u003dTrue"},{"line_number":225,"context_line":"    manila type-key default set create_share_from_snapshot_support\u003dTrue"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":228,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3a71b18c_4ad6aa4f","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":71},"updated":"2016-12-06 19:58:40.000000000","message":"Aren\u0027t you setting this in pre-test-hook?  Why set it here,\nand why just for the dummy driver?\n\nI\u0027m likely missing something ...","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"764faf0ef727b2dd22e51cfd54d6ca265f156d62","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share create_networks_when_multitenancy_enabled False"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    # Set the default share type extra-specs to run snapshot tests"},{"line_number":224,"context_line":"    manila type-key default set snapshot_support\u003dTrue"},{"line_number":225,"context_line":"    manila type-key default set create_share_from_snapshot_support\u003dTrue"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":228,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3a71b18c_79b0388c","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":71},"in_reply_to":"3a71b18c_196104a9","updated":"2016-12-08 19:14:03.000000000","message":"Done","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf23170e10c04f910b7a962dc16ade9356aa324e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share create_networks_when_multitenancy_enabled False"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    # Set the default share type extra-specs to run snapshot tests"},{"line_number":224,"context_line":"    manila type-key default set snapshot_support\u003dTrue"},{"line_number":225,"context_line":"    manila type-key default set create_share_from_snapshot_support\u003dTrue"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":228,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3a71b18c_b95570c7","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":71},"in_reply_to":"3a71b18c_4ad6aa4f","updated":"2016-12-08 18:14:32.000000000","message":"Yes, Tom is completely right. It is duplication and should be removed.","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0361d3bc65ba9b80aa41460473146ed64d1444ce","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    iniset $TEMPEST_CONFIG share create_networks_when_multitenancy_enabled False"},{"line_number":221,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    # Set the default share type extra-specs to run snapshot tests"},{"line_number":224,"context_line":"    manila type-key default set snapshot_support\u003dTrue"},{"line_number":225,"context_line":"    manila type-key default set create_share_from_snapshot_support\u003dTrue"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":228,"context_line":"    MANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3a71b18c_196104a9","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":71},"in_reply_to":"3a71b18c_4ad6aa4f","updated":"2016-12-08 18:16:40.000000000","message":"not necessary, will remove.","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf23170e10c04f910b7a962dc16ade9356aa324e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_tests True"},{"line_number":277,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests True"},{"line_number":278,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests True"},{"line_number":279,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":280,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled False"},{"line_number":281,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3a71b18c_f93608b3","line":279,"range":{"start_line":279,"start_character":4,"end_line":279,"end_character":83},"updated":"2016-12-08 18:14:32.000000000","message":"Again. It is duplication of line 215 (214 from PS21). Should be removed.","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"764faf0ef727b2dd22e51cfd54d6ca265f156d62","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_tests True"},{"line_number":277,"context_line":"    iniset $TEMPEST_CONFIG share run_manage_unmanage_snapshot_tests True"},{"line_number":278,"context_line":"    iniset $TEMPEST_CONFIG share run_replication_tests True"},{"line_number":279,"context_line":"    iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support True"},{"line_number":280,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled False"},{"line_number":281,"context_line":"    iniset $TEMPEST_CONFIG share backend_replication_type \u0027readable\u0027"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3a71b18c_b9aad017","line":279,"range":{"start_line":279,"start_character":4,"end_line":279,"end_character":83},"in_reply_to":"3a71b18c_f93608b3","updated":"2016-12-08 19:14:03.000000000","message":"Done","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c1a6bec00f4e1bfc4c42400ca2e7042a4eee487f","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Capability \"create_share_from_snapshot_support\""},{"line_number":81,"context_line":"CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT\u003d${CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:-True}"},{"line_number":82,"context_line":"iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support $CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":85,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":28,"id":"1a6eadb0_1a55461c","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":121},"updated":"2016-12-15 12:14:30.000000000","message":"you could do this after the driver conditions instead of doing it twice","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5303c1a66e9d3062bbc4639722f8f240ce162c0b","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Capability \"create_share_from_snapshot_support\""},{"line_number":81,"context_line":"CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT\u003d${CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:-True}"},{"line_number":82,"context_line":"iniset $TEMPEST_CONFIG share capability_create_share_from_snapshot_support $CAPABILITY_CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":85,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":28,"id":"1a6eadb0_601bf280","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":121},"in_reply_to":"1a6eadb0_1a55461c","updated":"2016-12-20 20:54:19.000000000","message":"Several of us have considered this, and we don\u0027t understand the comment.  I was following an established pattern, such as seen on line 78 with \u0027run_replication_tests\u0027.  The alternative would be for an \"else\" block at the end of the drivers section, but that seems like an otherwise unrelated change.","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"}],"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"ae2a21bcd874fba772b4401fb97afac43dc3e28c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"save_configuration \"MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL\" \"${MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL:\u003d5}\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"MANILA_SERVICE_IMAGE_ENABLED\u003d${MANILA_SERVICE_IMAGE_ENABLED:-False}"},{"line_number":89,"context_line":"DEFAULT_EXTRA_SPECS\u003d\"\u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue\u0027\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"generic\" ]]; then"},{"line_number":92,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"}],"source_content_type":"text/x-sh","patch_set":28,"id":"1a6eadb0_36ae5b98","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":85},"updated":"2016-12-15 19:53:48.000000000","message":"You shouldn\u0027t hardcode this. You need to overwrite if not previously exported.","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c1a6bec00f4e1bfc4c42400ca2e7042a4eee487f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"save_configuration \"MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL\" \"${MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL:\u003d5}\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"MANILA_SERVICE_IMAGE_ENABLED\u003d${MANILA_SERVICE_IMAGE_ENABLED:-False}"},{"line_number":89,"context_line":"DEFAULT_EXTRA_SPECS\u003d\"\u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue\u0027\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"generic\" ]]; then"},{"line_number":92,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"}],"source_content_type":"text/x-sh","patch_set":28,"id":"1a6eadb0_9d24f0af","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":85},"updated":"2016-12-15 12:14:30.000000000","message":"can do this after driver conditions instead of having it redefined","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5303c1a66e9d3062bbc4639722f8f240ce162c0b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"save_configuration \"MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL\" \"${MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL:\u003d5}\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"MANILA_SERVICE_IMAGE_ENABLED\u003d${MANILA_SERVICE_IMAGE_ENABLED:-False}"},{"line_number":89,"context_line":"DEFAULT_EXTRA_SPECS\u003d\"\u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue\u0027\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"generic\" ]]; then"},{"line_number":92,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"}],"source_content_type":"text/x-sh","patch_set":28,"id":"1a6eadb0_eb6363db","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":85},"in_reply_to":"1a6eadb0_36ae5b98","updated":"2016-12-20 20:54:19.000000000","message":"Agreed, fixed.","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5303c1a66e9d3062bbc4639722f8f240ce162c0b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"save_configuration \"MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL\" \"${MANILA_SHARE_MIGRATION_PERIOD_TASK_INTERVAL:\u003d5}\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"MANILA_SERVICE_IMAGE_ENABLED\u003d${MANILA_SERVICE_IMAGE_ENABLED:-False}"},{"line_number":89,"context_line":"DEFAULT_EXTRA_SPECS\u003d\"\u0027snapshot_support\u003dTrue create_share_from_snapshot_support\u003dTrue\u0027\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"generic\" ]]; then"},{"line_number":92,"context_line":"    MANILA_SERVICE_IMAGE_ENABLED\u003dTrue"}],"source_content_type":"text/x-sh","patch_set":28,"id":"1a6eadb0_8ba58f05","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":85},"in_reply_to":"1a6eadb0_9d24f0af","updated":"2016-12-20 20:54:19.000000000","message":"As before, we don\u0027t understand this.  In this file, I set the variable, override it for just one driver, and save the config only once.","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"}],"doc/source/devref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"99f2d037053af885dc458cbf6c0ab31a1629b5b9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"More information: :ref:`capabilities_and_extra_specs`"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+"},{"line_number":197,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | dedupe | compression | thin_provisioning | thick_provisioning | qos | create share from snapshot |"},{"line_number":198,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":199,"context_line":"|               ZFSonLinux               |     \\-    |      M     |   M    |      M      |         M         |          \\-        | \\-  |              M             |"},{"line_number":200,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3a71b18c_d3e1922b","line":197,"range":{"start_line":197,"start_character":138,"end_line":197,"end_character":164},"updated":"2016-12-06 19:58:40.000000000","message":"Is there a reason that there is no \u0027snapshot support\u0027 column here?","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf23170e10c04f910b7a962dc16ade9356aa324e","unresolved":false,"context_lines":[{"line_number":194,"context_line":"More information: :ref:`capabilities_and_extra_specs`"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+"},{"line_number":197,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | dedupe | compression | thin_provisioning | thick_provisioning | qos | create share from snapshot |"},{"line_number":198,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":199,"context_line":"|               ZFSonLinux               |     \\-    |      M     |   M    |      M      |         M         |          \\-        | \\-  |              M             |"},{"line_number":200,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3a71b18c_19b904cc","line":197,"range":{"start_line":197,"start_character":138,"end_line":197,"end_character":164},"in_reply_to":"3a71b18c_d3e1922b","updated":"2016-12-08 18:14:32.000000000","message":"Excellent question. It should be added too if new one is added.","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0361d3bc65ba9b80aa41460473146ed64d1444ce","unresolved":false,"context_lines":[{"line_number":194,"context_line":"More information: :ref:`capabilities_and_extra_specs`"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+"},{"line_number":197,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | dedupe | compression | thin_provisioning | thick_provisioning | qos | create share from snapshot |"},{"line_number":198,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":199,"context_line":"|               ZFSonLinux               |     \\-    |      M     |   M    |      M      |         M         |          \\-        | \\-  |              M             |"},{"line_number":200,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3a71b18c_390fa0e2","line":197,"range":{"start_line":197,"start_character":138,"end_line":197,"end_character":164},"in_reply_to":"3a71b18c_d3e1922b","updated":"2016-12-08 18:16:40.000000000","message":"needs to be added: https://bugs.launchpad.net/manila/+bug/1506863","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c1a6bec00f4e1bfc4c42400ca2e7042a4eee487f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            Updated reset_task_state API to accept \u0027None\u0027 value."},{"line_number":81,"context_line":"    * 2.23 - Added share_type to filter results of scheduler-stats/pools API."},{"line_number":82,"context_line":"    * 2.24 - Added create_share_from_snapshot_support extra spec, which was"},{"line_number":83,"context_line":"             previously inferred from the \u0027snapshot_support\u0027 extra spec."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"\"\"\""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_9db870e7","line":83,"range":{"start_line":83,"start_character":51,"end_line":83,"end_character":72},"updated":"2016-12-15 12:14:30.000000000","message":"please state that the snapshot_support has also made optional","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5303c1a66e9d3062bbc4639722f8f240ce162c0b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            Updated reset_task_state API to accept \u0027None\u0027 value."},{"line_number":81,"context_line":"    * 2.23 - Added share_type to filter results of scheduler-stats/pools API."},{"line_number":82,"context_line":"    * 2.24 - Added create_share_from_snapshot_support extra spec, which was"},{"line_number":83,"context_line":"             previously inferred from the \u0027snapshot_support\u0027 extra spec."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"\"\"\""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_c0f926ca","line":83,"range":{"start_line":83,"start_character":51,"end_line":83,"end_character":72},"in_reply_to":"1a6eadb0_9db870e7","updated":"2016-12-20 20:54:19.000000000","message":"Done","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"}],"manila/api/v1/share_types_extra_specs.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"8d27398bba46ef5beeea79e0a151e59b79697e4d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                share_types.is_valid_optional_extra_spec(k, v) in (None, True))"},{"line_number":64,"context_line":"            return (valid_extra_spec_key"},{"line_number":65,"context_line":"                    and valid_type"},{"line_number":66,"context_line":"                    and valid_required_extra_spec"},{"line_number":67,"context_line":"                    and valid_optional_extra_spec)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        for k, v in extra_specs.items():"},{"line_number":70,"context_line":"            if is_valid_string(k) and isinstance(v, dict):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_cf5548fa","line":67,"range":{"start_line":66,"start_character":20,"end_line":67,"end_character":49},"updated":"2016-11-04 06:24:49.000000000","message":"here means that a extra spec must be both required and optional, is it right?","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"273c275020e10f88cb6917cf2bc480fc7a53f930","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                share_types.is_valid_optional_extra_spec(k, v) in (None, True))"},{"line_number":64,"context_line":"            return (valid_extra_spec_key"},{"line_number":65,"context_line":"                    and valid_type"},{"line_number":66,"context_line":"                    and valid_required_extra_spec"},{"line_number":67,"context_line":"                    and valid_optional_extra_spec)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        for k, v in extra_specs.items():"},{"line_number":70,"context_line":"            if is_valid_string(k) and isinstance(v, dict):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_c005f914","line":67,"range":{"start_line":66,"start_character":20,"end_line":67,"end_character":49},"in_reply_to":"ba5da102_cf5548fa","updated":"2016-11-04 19:32:18.000000000","message":"Nope, that\u0027s not right.","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"8d27398bba46ef5beeea79e0a151e59b79697e4d","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            # Verify that share can be created from a snapshot"},{"line_number":268,"context_line":"            if (check_create_share_from_snapshot_support and"},{"line_number":269,"context_line":"                    not parent_share[\u0027create_share_from_snapshot_support\u0027]):"},{"line_number":270,"context_line":"                msg \u003d _(\"Share cannot be created from snapshot \u0027%s\u0027, because \""},{"line_number":271,"context_line":"                        \"share back end does not support it.\") % snapshot_id"},{"line_number":272,"context_line":"                LOG.error(msg)"},{"line_number":273,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_6fb35c4d","line":270,"range":{"start_line":270,"start_character":22,"end_line":270,"end_character":23},"updated":"2016-11-04 06:24:49.000000000","message":"_LE","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"273c275020e10f88cb6917cf2bc480fc7a53f930","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            # Verify that share can be created from a snapshot"},{"line_number":268,"context_line":"            if (check_create_share_from_snapshot_support and"},{"line_number":269,"context_line":"                    not parent_share[\u0027create_share_from_snapshot_support\u0027]):"},{"line_number":270,"context_line":"                msg \u003d _(\"Share cannot be created from snapshot \u0027%s\u0027, because \""},{"line_number":271,"context_line":"                        \"share back end does not support it.\") % snapshot_id"},{"line_number":272,"context_line":"                LOG.error(msg)"},{"line_number":273,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_9b3d32be","line":270,"range":{"start_line":270,"start_character":22,"end_line":270,"end_character":23},"in_reply_to":"ba5da102_6fb35c4d","updated":"2016-11-04 19:32:18.000000000","message":"Nope.  The message is used for a log method *and* an exception.\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"8d27398bba46ef5beeea79e0a151e59b79697e4d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            if (check_create_share_from_snapshot_support and"},{"line_number":269,"context_line":"                    not parent_share[\u0027create_share_from_snapshot_support\u0027]):"},{"line_number":270,"context_line":"                msg \u003d _(\"Share cannot be created from snapshot \u0027%s\u0027, because \""},{"line_number":271,"context_line":"                        \"share back end does not support it.\") % snapshot_id"},{"line_number":272,"context_line":"                LOG.error(msg)"},{"line_number":273,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_efa68c0d","line":271,"range":{"start_line":271,"start_character":25,"end_line":271,"end_character":39},"updated":"2016-11-04 06:24:49.000000000","message":"shouldn\u0027t here be the source snapshot share not support is?","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"273c275020e10f88cb6917cf2bc480fc7a53f930","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            if (check_create_share_from_snapshot_support and"},{"line_number":269,"context_line":"                    not parent_share[\u0027create_share_from_snapshot_support\u0027]):"},{"line_number":270,"context_line":"                msg \u003d _(\"Share cannot be created from snapshot \u0027%s\u0027, because \""},{"line_number":271,"context_line":"                        \"share back end does not support it.\") % snapshot_id"},{"line_number":272,"context_line":"                LOG.error(msg)"},{"line_number":273,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_9bab72d6","line":271,"range":{"start_line":271,"start_character":25,"end_line":271,"end_character":39},"in_reply_to":"ba5da102_efa68c0d","updated":"2016-11-04 19:32:18.000000000","message":"I don\u0027t understand the question, but I think the error message is fine as-is.","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                msg \u003d _(\"Share cannot be created from snapshot \u0027%s\u0027, because \""},{"line_number":271,"context_line":"                        \"share back end does not support it.\") % snapshot_id"},{"line_number":272,"context_line":"                LOG.error(msg)"},{"line_number":273,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if share_network_id:"},{"line_number":276,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_9e0f6f38","line":273,"range":{"start_line":273,"start_character":26,"end_line":273,"end_character":40},"updated":"2016-12-21 12:49:29.000000000","message":"It should not be \"Bad request\", it should be \"405 Method Not Allowed\"","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77c7bef644b4dc72526d4bce1f585038fbbb45ab","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                msg \u003d _(\"Share cannot be created from snapshot \u0027%s\u0027, because \""},{"line_number":271,"context_line":"                        \"share back end does not support it.\") % snapshot_id"},{"line_number":272,"context_line":"                LOG.error(msg)"},{"line_number":273,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if share_network_id:"},{"line_number":276,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_01fbffc1","line":273,"range":{"start_line":273,"start_character":26,"end_line":273,"end_character":40},"in_reply_to":"1a6eadb0_9e0f6f38","updated":"2016-12-21 13:41:08.000000000","message":"No, We allow the POST method on the /shares resource. We only disallow creating new shares from an existing snapshot that is incapable of this action. If anything, this can be a 409 Conflict. \n\nAlso, If using 405, we\u0027d need to return a list of acceptable verbs in the Accept header, which, would include POST.","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"}],"manila/common/constants.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9fabb8c5fa583e544bd46b9c5af3611d38333dd1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    DRIVER_HANDLES_SHARE_SERVERS \u003d \"driver_handles_share_servers\""},{"line_number":158,"context_line":"    SNAPSHOT_SUPPORT \u003d \"snapshot_support\""},{"line_number":159,"context_line":"    REPLICATION_TYPE_SPEC \u003d \"replication_type\""},{"line_number":160,"context_line":"    CREATE_SHARE_FROM_SNAPSHOT_SUPPORT \u003d \"create_share_from_snapshot_support\""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # Extra specs containers"},{"line_number":163,"context_line":"    REQUIRED \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_b14ae5aa","line":160,"range":{"start_line":160,"start_character":68,"end_line":160,"end_character":77},"updated":"2016-08-19 04:58:44.000000000","message":"I get that _support suffix matches snapshot_support style (so I like that), but more recently we rejected the _support suffix for thin_provisioning, dedupe, etc. because _support is redundant. csfs True|False is sufficient. Thoughts?","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"68a3fc2a232c1ed0a74312c1190a6113febabcf5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    DRIVER_HANDLES_SHARE_SERVERS \u003d \"driver_handles_share_servers\""},{"line_number":158,"context_line":"    SNAPSHOT_SUPPORT \u003d \"snapshot_support\""},{"line_number":159,"context_line":"    REPLICATION_TYPE_SPEC \u003d \"replication_type\""},{"line_number":160,"context_line":"    CREATE_SHARE_FROM_SNAPSHOT_SUPPORT \u003d \"create_share_from_snapshot_support\""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # Extra specs containers"},{"line_number":163,"context_line":"    REQUIRED \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_dbcb491d","line":160,"range":{"start_line":160,"start_character":68,"end_line":160,"end_character":77},"in_reply_to":"3ac371cc_b14ae5aa","updated":"2016-08-19 14:25:19.000000000","message":"There\u0027s a difference between extra specs that are visible to users and extra specs that are admin only.\n\nUltimately I\u0027d like to split these things, but that\u0027s a new feature, so in the short run a simple new public extra spec that follows the name convention is probably best.","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    CREATE_SHARE_FROM_SNAPSHOT_SUPPORT \u003d \"create_share_from_snapshot_support\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Extra specs containers"},{"line_number":166,"context_line":"    REQUIRED \u003d (DRIVER_HANDLES_SHARE_SERVERS,)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    OPTIONAL \u003d ("},{"line_number":169,"context_line":"        SNAPSHOT_SUPPORT,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_691a1170","line":166,"range":{"start_line":166,"start_character":4,"end_line":166,"end_character":46},"updated":"2016-12-02 18:30:10.000000000","message":"Redundant 3 line update.","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    CREATE_SHARE_FROM_SNAPSHOT_SUPPORT \u003d \"create_share_from_snapshot_support\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Extra specs containers"},{"line_number":166,"context_line":"    REQUIRED \u003d (DRIVER_HANDLES_SHARE_SERVERS,)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    OPTIONAL \u003d ("},{"line_number":169,"context_line":"        SNAPSHOT_SUPPORT,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_e775fa31","line":166,"range":{"start_line":166,"start_character":4,"end_line":166,"end_character":46},"in_reply_to":"3a71b18c_691a1170","updated":"2016-12-06 15:35:37.000000000","message":"Done","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"}],"manila/db/migrations/alembic/versions/38e632621e5a_change_volume_type_to_share_type.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"9efc44c1bd5a9631d0e76fbfabf8f7db04e24b07","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_e5d99b58","line":118,"updated":"2016-08-17 20:30:09.000000000","message":"This looks very dangerous -- you can\u0027t change old migrations.","commit_id":"f43446084f3d1faa3a87c91d72bf6d38a989ddf7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"93de0c2fc0935131086850dc60558f840154ba89","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_95f7c58b","line":118,"in_reply_to":"3ac371cc_c0c28d33","updated":"2016-11-14 12:17:25.000000000","message":"Could not reproduce bug.\n\nApplied latest PS17 on existing cloud that was at latest DB state, reverted back changes from this file. Performed \"up\" migration (only one new DB migration file), then \"down\" and \"up\" again - everything went just \"ok\".","commit_id":"f43446084f3d1faa3a87c91d72bf6d38a989ddf7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dae68b2384410270faebe804159eb3175050020","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_c0c28d33","line":118,"in_reply_to":"3ac371cc_e5d99b58","updated":"2016-08-17 21:01:16.000000000","message":"Hmm, don\u0027t think so.. here\u0027s how this would have worked.. \n\nThis path breaks during a database downgrade.. not an upgrade. I\u0027m not sure why no one ever reported it before, maybe manila users don\u0027t run downgrades in the wild when they have data (and they shouldn\u0027t). \n\nSo, think of how this happens:\n\n\u003d\u003dWithout this fix\u003d\u003d\n\nUpgrade:\n\nWe treat the column in our volume_type_extra_specs table through ORM as an Integer column, even though it is a boolean, but that\u0027s a perfectly valid ORM call, see line (127) and results from strutils for that method in [2]\n\nDowngrade:\n \n i. You have no data - you\u0027re golden. \n ii. You have data; and the data is integer, you\u0027re SOL.. because the downgrade will blow up with the traceback listed in [1] \n     tl;dr: ValueError: int_to_boolean only accepts None, 0 or 1\n\n\n\u003d\u003dWith this fix\u003d\u003d\n\nUpgrade:\n\nWe treat the column in our volume_type_extra_specs table through ORM as a Bool, and that\u0027s what it is. So we\u0027re good.\n\n Downgrade:\n\n i. You have no data - you\u0027re golden\n ii. You have data; and the data is integer - No worries, we fixed our migration to handle this correctly. So, downgrade away.\n\n\n\u003d\u003d WHY is this fix needed with this patch \u003d\u003d\n\nSee https://review.openstack.org/#/c/356682/1/manila/tests/db/migrations/alembic/migrations_data_checks.py \n\nThe migration data check inserts multiple extra specs into the table, they will all fail with [1] if this wasn\u0027t fixed during the database migrations that test_walk_versions executes.. \n\n\n[1] \n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n      File \"manila/tests/utils.py\", line 53, in _wrapper\n        return f(self, *args, **kwargs)\n      File \"manila/tests/db/migrations/alembic/test_migration.py\", line 158, in test_walk_versions\n        downgrade\u003dself.downgrade)\n      File \"manila/tests/db/migrations/alembic/test_migration.py\", line 88, in _walk_versions\n        downgraded \u003d self._migrate_down(version)\n      File \"manila/tests/db/migrations/alembic/test_migration.py\", line 95, in _migrate_down\n        self.migration_api.downgrade(version.down_revision)\n      File \"manila/db/migrations/alembic/migration.py\", line 60, in downgrade\n        return alembic.command.downgrade(_alembic_config(), revision or \u0027base\u0027)\n      File \"/opt/stack/manila/.tox/py27/local/lib/python2.7/site-packages/alembic/command.py\", line 202, in downgrade\n        script.run_env()\n      File \"/opt/stack/manila/.tox/py27/local/lib/python2.7/site-packages/alembic/script/base.py\", line 407, in run_env\n        util.load_python_file(self.dir, \u0027env.py\u0027)\n      File \"/opt/stack/manila/.tox/py27/local/lib/python2.7/site-packages/alembic/util/pyfiles.py\", line 93, in load_python_file\n        module \u003d load_module_py(module_id, path)\n      File \"/opt/stack/manila/.tox/py27/local/lib/python2.7/site-packages/alembic/util/compat.py\", line 79, in load_module_py\n        mod \u003d imp.load_source(module_id, path, fp)\n      File \"/opt/stack/manila/manila/db/migrations/alembic/env.py\", line 41, in \u003cmodule\u003e\n        run_migrations_online()\n      File \"/opt/stack/manila/manila/db/migrations/alembic/env.py\", line 36, in run_migrations_online\n        context.run_migrations()  # pylint: disable\u003dE1101\n      File \"\u003cstring\u003e\", line 8, in run_migrations\n      File \"/opt/stack/manila/.tox/py27/local/lib/python2.7/site-packages/alembic/runtime/environment.py\", line 797, in run_migrations\n        self.get_context().run_migrations(**kw)\n      File \"/opt/stack/manila/.tox/py27/local/lib/python2.7/site-packages/alembic/runtime/migration.py\", line 312, in run_migrations\n        step.migration_fn(**kw)\n      File \"/opt/stack/manila/manila/db/migrations/alembic/versions/38e632621e5a_change_volume_type_to_share_type.py\", line 91, in downgrade\n        _copy_records(destination_table\u003dvt_es, up_migration\u003dFalse)\n      File \"/opt/stack/manila/manila/db/migrations/alembic/versions/38e632621e5a_change_volume_type_to_share_type.py\", line 130, in _copy_records\n    deleted \u003d strutils.bool_from_string(es.deleted)\n    ValueError: int_to_boolean only accepts None, 0 or 1\n\n\n[2] Behavior of int_from_bool_as_string\n\u003e\u003e\u003e from oslo_utils import strutils\n\u003e\u003e\u003e strutils.int_from_bool_as_string(1)\n1\n\u003e\u003e\u003e strutils.int_from_bool_as_string(0)\n0\n\u003e\u003e\u003e strutils.int_from_bool_as_string(True)\n1\n\u003e\u003e\u003e strutils.int_from_bool_as_string(\u0027True\u0027)\n1\n\u003e\u003e\u003e strutils.int_from_bool_as_string(False)\n0\n\u003e\u003e\u003e strutils.int_from_bool_as_string(\u0027False\u0027)\n0","commit_id":"f43446084f3d1faa3a87c91d72bf6d38a989ddf7"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9fabb8c5fa583e544bd46b9c5af3611d38333dd1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_9101a93c","line":118,"updated":"2016-08-19 04:58:44.000000000","message":"why is this change part of this patch?","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f42d6619e4a60a4fe7e5d79bb245d6d5be70fdf6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_30eee58b","line":118,"in_reply_to":"1ac06dbe_70ca1da3","updated":"2016-08-19 20:59:12.000000000","message":"+1 Worth splitting this out and adding a migration data check test for this in N4.","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"5aa721c724bfd9dff993ca8dfd53d64544c51f77","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_70ca1da3","line":118,"in_reply_to":"3ac371cc_42fda16d","updated":"2016-08-19 20:47:55.000000000","message":"Still seems like this is a bug-fix that should be done separately before this or some other similar patch needs it.","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"3a40ee556da4f089c57753cad51f894c85186217","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_42fda16d","line":118,"in_reply_to":"3ac371cc_9101a93c","updated":"2016-08-19 07:49:53.000000000","message":"Did you checkout the discussion between Ben and Goutham in PS1? Without this fix the tests for DB migration introduced by this patch would fail.","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"900f65f1a9facf7daad3826662c59c4dd079a7a2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_43f892c3","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"updated":"2016-11-10 08:26:41.000000000","message":"We need also have in mind that postgres can cast from Int to Bool. I saw your comment on patchset 1 but does it really work with postgres?\nChanging a existing migration can be very tricky..\n\nPlease see:\nhttps://review.openstack.org/#/c/383577/","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7e1b7b730ee265f193ed4e79b6fde3b47bc40f6e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_1e6cb707","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"in_reply_to":"9a629dbe_1e0e77e5","updated":"2016-11-14 11:35:32.000000000","message":"Why this file is changed at all? It is not compatible with cases when we upgrade from cloud where old variant of this DB migration was applied and only new ones like the one you \"added\" [1] will run.\n\nDo you see any real issues leaving it as is? I don\u0027t right now, that is why I ask for not changing this.\n\nhttps://review.openstack.org/#/c/356682/16/manila/db/migrations/alembic/versions/3e7d62517afa_add_create_share_from_snapshot_support.py","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f46915425710cd75aade7b8e44022d2f0a703027","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_727247af","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"in_reply_to":"9a629dbe_1e6cb707","updated":"2016-11-14 11:38:21.000000000","message":"Why would old clouds run this migration? We\u0027re fixing a case where walking the versions is impossible without hitting this bug. We need to walk these versions for the tests we added for the migration introduced in this file.","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"80c0cc83502bcb35db4defba06330abb9ced7b5a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_f273b713","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"in_reply_to":"9a629dbe_3208cf91","updated":"2016-11-14 11:51:36.000000000","message":"Also, \"existing clouds\" are the main audience for DB migration scripts. Not developers, that install everything from scratch.","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"806d20a6eed07eb28b9a42f4743e5ba0f87a15b2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_1e0e77e5","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"in_reply_to":"9a629dbe_43f892c3","updated":"2016-11-14 11:25:03.000000000","message":"Marc: The test test_walk_versions is doing this with postgres... I did test it with mysql, but the migration tests in the CI are run with postgres and mysql... I re-read my comment on PS 1, i still think this is valid. What do you suspect can go wrong? I want to read a Boolean as a Boolean, without expecting the database engine to perform the cast for me.","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"76ed79d1dc0287b561c35c537015e0bee2762725","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_3208cf91","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"in_reply_to":"9a629dbe_5240e307","updated":"2016-11-14 11:49:44.000000000","message":"Which \"this\" bug?","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e3844f3bdfe33abe3170a3b012de84ca43d49e25","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_5240e307","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"in_reply_to":"9a629dbe_727247af","updated":"2016-11-14 11:41:13.000000000","message":"https://review.openstack.org/#/c/356682/1/manila/db/migrations/alembic/versions/38e632621e5a_change_volume_type_to_share_type.py","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"807e70e37aa3cc866b5cf8b267d617bcb4aa8009","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_32f28f70","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":39},"in_reply_to":"9a629dbe_f273b713","updated":"2016-11-14 11:53:08.000000000","message":"In other words, your new migration will just fail on such environments that are main audience.","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9b394d8a7864de378684c1a18681def61e5926c2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_02b1a08f","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":73},"updated":"2016-11-15 18:08:26.000000000","message":"I confirm that it is bug. It should be exactly as you propose to be. BUT, please, file bug for it and fix it separately.\n\nIt worked before, because there is no migration unit tests for it. So, your new unit test is the first one that creates and deletes extra specs.\n\nSo, what I expect to see:\nFirst commit:\n- bugfix + db unit test\nSecond commit:\n- implementation of the feature to implement here.","commit_id":"6fe600068e589ba393c91dbe2c66c5490cf0a2b5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8a7582688407dcd7b7efa6882ebcc7b6cff548e7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":116,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":117,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":118,"context_line":"        sa.Column(\u0027deleted\u0027, sa.Boolean if up_migration else sa.Integer),"},{"line_number":119,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":120,"context_line":"        sa.Column(data_from[0] + \u0027_type_id\u0027, sa.String(length\u003d36)),"},{"line_number":121,"context_line":"        sa.Column(data_from[1] + \u0027key\u0027, sa.String(length\u003d255)),"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_440bc17d","line":118,"range":{"start_line":118,"start_character":29,"end_line":118,"end_character":73},"in_reply_to":"7a77a97e_02b1a08f","updated":"2016-11-21 16:58:29.000000000","message":"Done","commit_id":"6fe600068e589ba393c91dbe2c66c5490cf0a2b5"}],"manila/db/migrations/alembic/versions/3e7d62517afa_add_create_share_from_snapshot_support.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"8d27398bba46ef5beeea79e0a151e59b79697e4d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    # Get list of share type IDs that don\u0027t already have the new required"},{"line_number":66,"context_line":"    # create_share_from_snapshot_support extra spec defined."},{"line_number":67,"context_line":"    existing_extra_specs \u003d session.query(extra_specs_table).\\"},{"line_number":68,"context_line":"        filter(extra_specs_table.c.spec_key \u003d\u003d"},{"line_number":69,"context_line":"               constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT).\\"},{"line_number":70,"context_line":"        filter(extra_specs_table.c.deleted \u003d\u003d 0).\\"},{"line_number":71,"context_line":"        all()"},{"line_number":72,"context_line":"    excluded_st_ids \u003d [es.share_type_id for es in existing_extra_specs]"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_0f8ca0d8","line":70,"range":{"start_line":68,"start_character":8,"end_line":70,"end_character":50},"updated":"2016-11-04 06:24:49.000000000","message":"maybe better that first filter by deleted and then by spec_key?","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"273c275020e10f88cb6917cf2bc480fc7a53f930","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    # Get list of share type IDs that don\u0027t already have the new required"},{"line_number":66,"context_line":"    # create_share_from_snapshot_support extra spec defined."},{"line_number":67,"context_line":"    existing_extra_specs \u003d session.query(extra_specs_table).\\"},{"line_number":68,"context_line":"        filter(extra_specs_table.c.spec_key \u003d\u003d"},{"line_number":69,"context_line":"               constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT).\\"},{"line_number":70,"context_line":"        filter(extra_specs_table.c.deleted \u003d\u003d 0).\\"},{"line_number":71,"context_line":"        all()"},{"line_number":72,"context_line":"    excluded_st_ids \u003d [es.share_type_id for es in existing_extra_specs]"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_7bdcde74","line":70,"range":{"start_line":68,"start_character":8,"end_line":70,"end_character":50},"in_reply_to":"ba5da102_0f8ca0d8","updated":"2016-11-04 19:32:18.000000000","message":"The extra specs table is tied to share types, which are admin-defined, so it isn\u0027t going to be a large table.  I\u0027m skeptical the order really matters here.  Does anyone else feel differently?","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"8d27398bba46ef5beeea79e0a151e59b79697e4d","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # Get the value of snapshot_support for each extant share type"},{"line_number":85,"context_line":"        snapshot_support_extra_spec \u003d session.query(extra_specs_table).\\"},{"line_number":86,"context_line":"            filter(extra_specs_table.c.spec_key \u003d\u003d"},{"line_number":87,"context_line":"                   constants.ExtraSpecs.SNAPSHOT_SUPPORT).\\"},{"line_number":88,"context_line":"            filter(extra_specs_table.c.share_type_id \u003d\u003d share_type.id).\\"},{"line_number":89,"context_line":"            first()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        spec_value \u003d (snapshot_support_extra_spec.spec_value if"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_8fbef062","line":88,"range":{"start_line":86,"start_character":12,"end_line":88,"end_character":72},"updated":"2016-11-04 06:24:49.000000000","message":"ditto, maybe switch the filter sequence better?","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"273c275020e10f88cb6917cf2bc480fc7a53f930","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # Get the value of snapshot_support for each extant share type"},{"line_number":85,"context_line":"        snapshot_support_extra_spec \u003d session.query(extra_specs_table).\\"},{"line_number":86,"context_line":"            filter(extra_specs_table.c.spec_key \u003d\u003d"},{"line_number":87,"context_line":"                   constants.ExtraSpecs.SNAPSHOT_SUPPORT).\\"},{"line_number":88,"context_line":"            filter(extra_specs_table.c.share_type_id \u003d\u003d share_type.id).\\"},{"line_number":89,"context_line":"            first()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        spec_value \u003d (snapshot_support_extra_spec.spec_value if"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_dbe32a32","line":88,"range":{"start_line":86,"start_character":12,"end_line":88,"end_character":72},"in_reply_to":"ba5da102_8fbef062","updated":"2016-11-04 19:32:18.000000000","message":"same","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Clinton Knight.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_a9595737","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":58},"updated":"2016-12-21 12:49:29.000000000","message":"Are you sure about 2015?","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Clinton Knight.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_a1696bfb","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":58},"in_reply_to":"1a6eadb0_a1324ba5","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77c7bef644b4dc72526d4bce1f585038fbbb45ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Clinton Knight.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_a1324ba5","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":58},"in_reply_to":"1a6eadb0_a9595737","updated":"2016-12-21 13:41:08.000000000","message":"lol","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # Get list of share type IDs that don\u0027t already have the new required"},{"line_number":66,"context_line":"    # create_share_from_snapshot_support extra spec defined."},{"line_number":67,"context_line":"    existing_extra_specs \u003d session.query(extra_specs_table).\\"},{"line_number":68,"context_line":"        filter(extra_specs_table.c.spec_key \u003d\u003d"},{"line_number":69,"context_line":"               constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT).\\"},{"line_number":70,"context_line":"        filter(extra_specs_table.c.deleted \u003d\u003d 0).\\"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_a97077a5","line":67,"range":{"start_line":67,"start_character":60,"end_line":67,"end_character":61},"updated":"2016-12-21 12:49:29.000000000","message":"Please, do not use backslashes. Use carry-over starting with func arguments.","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # Get list of share type IDs that don\u0027t already have the new required"},{"line_number":66,"context_line":"    # create_share_from_snapshot_support extra spec defined."},{"line_number":67,"context_line":"    existing_extra_specs \u003d session.query(extra_specs_table).\\"},{"line_number":68,"context_line":"        filter(extra_specs_table.c.spec_key \u003d\u003d"},{"line_number":69,"context_line":"               constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT).\\"},{"line_number":70,"context_line":"        filter(extra_specs_table.c.deleted \u003d\u003d 0).\\"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_41041717","line":67,"range":{"start_line":67,"start_character":60,"end_line":67,"end_character":61},"in_reply_to":"1a6eadb0_a97077a5","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":146,"context_line":"              constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT).\\"},{"line_number":147,"context_line":"        where(extra_specs.c.deleted \u003d\u003d 0).values("},{"line_number":148,"context_line":"            deleted\u003dextra_specs.c.id,"},{"line_number":149,"context_line":"            deleted_at\u003dtimeutils.utcnow())"},{"line_number":150,"context_line":"    connection.execute(update)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    op.drop_column(\u0027shares\u0027, \u0027create_share_from_snapshot_support\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_29b46733","line":149,"range":{"start_line":149,"start_character":23,"end_line":149,"end_character":41},"updated":"2016-12-21 12:49:29.000000000","message":"Maybe it is better to calculate \"deleted_at\" only once?","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":146,"context_line":"              constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT).\\"},{"line_number":147,"context_line":"        where(extra_specs.c.deleted \u003d\u003d 0).values("},{"line_number":148,"context_line":"            deleted\u003dextra_specs.c.id,"},{"line_number":149,"context_line":"            deleted_at\u003dtimeutils.utcnow())"},{"line_number":150,"context_line":"    connection.execute(update)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    op.drop_column(\u0027shares\u0027, \u0027create_share_from_snapshot_support\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_7438efa0","line":149,"range":{"start_line":149,"start_character":23,"end_line":149,"end_character":41},"in_reply_to":"1a6eadb0_29b46733","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"}],"manila/share/api.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e7e27f4ce88a6da1c5613ea00c3bc1cf2c4f2600","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            if share_type:"},{"line_number":278,"context_line":"                snapshot_support \u003d share_types.parse_boolean_extra_spec("},{"line_number":279,"context_line":"                    constants.ExtraSpecs.SNAPSHOT_SUPPORT,"},{"line_number":280,"context_line":"                    share_type.get(\u0027extra_specs\u0027, {}).get("},{"line_number":281,"context_line":"                        constants.ExtraSpecs.SNAPSHOT_SUPPORT,"},{"line_number":282,"context_line":"                        snapshot_support_default))"}],"source_content_type":"text/x-python","patch_set":31,"id":"da4df55a_8b04b37e","line":279,"range":{"start_line":279,"start_character":20,"end_line":279,"end_character":57},"updated":"2016-12-23 12:56:46.000000000","message":"very small nit if you upload another patch: create a var snapshot_support_key and use it here to be more consistent","commit_id":"0d6db3588c212a7d121bb5d95ea0a82b034490a1"}],"manila/share/driver.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f71650f95635fa6fd0d65c51962371925ef54df1","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        return self._snapshots_are_supported"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @property"},{"line_number":791,"context_line":"    def create_share_from_snapshot_support(self):"},{"line_number":792,"context_line":"        \"\"\"Calculate default value for create_share_from_snapshot_support.\"\"\""},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        if not hasattr(self, \u0027_create_share_from_snapshot_is_supported\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_6d1c2d6b","line":791,"range":{"start_line":791,"start_character":7,"end_line":791,"end_character":43},"updated":"2016-08-18 18:10:23.000000000","message":"This sounds like the name of a method rather than a property.  How about \u0027has_create_share_from_snapshot_support\u0027 or \u0027create_share_from_snapshot_is_supported\u0027?","commit_id":"f61e26879e5a81f7bbb12cd37d827fa6735e25ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a35814454d4b21d404eff9e096a417afeefabe5","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        return self._snapshots_are_supported"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @property"},{"line_number":791,"context_line":"    def create_share_from_snapshot_support(self):"},{"line_number":792,"context_line":"        \"\"\"Calculate default value for create_share_from_snapshot_support.\"\"\""},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        if not hasattr(self, \u0027_create_share_from_snapshot_is_supported\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_44f7838c","line":791,"range":{"start_line":791,"start_character":7,"end_line":791,"end_character":43},"in_reply_to":"3ac371cc_6d1c2d6b","updated":"2016-08-18 20:40:18.000000000","message":"Done","commit_id":"f61e26879e5a81f7bbb12cd37d827fa6735e25ff"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9fabb8c5fa583e544bd46b9c5af3611d38333dd1","unresolved":false,"context_lines":[{"line_number":790,"context_line":"    @property"},{"line_number":791,"context_line":"    def creating_shares_from_snapshots_is_supported(self):"},{"line_number":792,"context_line":"        \"\"\"Calculate default value for create_share_from_snapshot_support.\"\"\""},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        if not hasattr(self, \u0027_creating_shares_from_snapshots_is_supported\u0027):"},{"line_number":795,"context_line":"            methods \u003d (\u0027create_share_from_snapshot\u0027, )"},{"line_number":796,"context_line":"            self._creating_shares_from_snapshots_is_supported \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_3116f555","line":793,"updated":"2016-08-19 04:58:44.000000000","message":"if not snapshots_are_supported() return False  # because you can\u0027t create shares from snapshots if you don\u0027t have snapshots.","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"3a40ee556da4f089c57753cad51f894c85186217","unresolved":false,"context_lines":[{"line_number":790,"context_line":"    @property"},{"line_number":791,"context_line":"    def creating_shares_from_snapshots_is_supported(self):"},{"line_number":792,"context_line":"        \"\"\"Calculate default value for create_share_from_snapshot_support.\"\"\""},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        if not hasattr(self, \u0027_creating_shares_from_snapshots_is_supported\u0027):"},{"line_number":795,"context_line":"            methods \u003d (\u0027create_share_from_snapshot\u0027, )"},{"line_number":796,"context_line":"            self._creating_shares_from_snapshots_is_supported \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_0b5585c5","line":793,"in_reply_to":"3ac371cc_3116f555","updated":"2016-08-19 07:49:53.000000000","message":"+1","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":925,"context_line":"            self._creating_shares_from_snapshots_is_supported \u003d ("},{"line_number":926,"context_line":"                self._has_redefined_driver_methods(methods))"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"        return self._creating_shares_from_snapshots_is_supported"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":931,"context_line":"        \"\"\"Retrieve stats info from share group."}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_266f6693","line":928,"range":{"start_line":928,"start_character":8,"end_line":928,"end_character":64},"updated":"2016-12-02 18:30:10.000000000","message":"return (\n    self._creating_shares_from_snapshots_is_supported and\n    self.snapshots_are_supported\n)","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":925,"context_line":"            self._creating_shares_from_snapshots_is_supported \u003d ("},{"line_number":926,"context_line":"                self._has_redefined_driver_methods(methods))"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"        return self._creating_shares_from_snapshots_is_supported"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":931,"context_line":"        \"\"\"Retrieve stats info from share group."}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_87b286e3","line":928,"range":{"start_line":928,"start_character":8,"end_line":928,"end_character":64},"in_reply_to":"3a71b18c_266f6693","updated":"2016-12-06 15:35:37.000000000","message":"Done","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"900f65f1a9facf7daad3826662c59c4dd079a7a2","unresolved":false,"context_lines":[{"line_number":2158,"context_line":"        if not cg_id:"},{"line_number":2159,"context_line":"            msg \u003d _(\u0027Could not start consistency group snapshot %s.\u0027)"},{"line_number":2160,"context_line":"            raise exception.NetAppException(msg % snapshot_name)"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"        self._commit_cg_snapshot(cg_id)"},{"line_number":2163,"context_line":""},{"line_number":2164,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_876ab7ec","line":2161,"updated":"2016-11-10 08:26:41.000000000","message":"Not related to the change","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"7668c9b7c999b45f5be4ef733df1cb0e9a4e953e","unresolved":false,"context_lines":[{"line_number":2158,"context_line":"        if not cg_id:"},{"line_number":2159,"context_line":"            msg \u003d _(\u0027Could not start consistency group snapshot %s.\u0027)"},{"line_number":2160,"context_line":"            raise exception.NetAppException(msg % snapshot_name)"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"        self._commit_cg_snapshot(cg_id)"},{"line_number":2163,"context_line":""},{"line_number":2164,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_ac480dce","line":2161,"in_reply_to":"9a629dbe_876ab7ec","updated":"2016-11-14 11:43:01.000000000","message":"Fixed, thanks.","commit_id":"11b44b4996d6f8252373f6a39094f2c826a103de"}],"manila/share/share_types.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"9efc44c1bd5a9631d0e76fbfabf8f7db04e24b07","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if (constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":46,"context_line":"            not in list(extra_specs)):"},{"line_number":47,"context_line":"        extra_specs["},{"line_number":48,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT] \u003d \u0027True\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        get_valid_required_extra_specs(extra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_4556afce","line":48,"updated":"2016-08-17 20:30:09.000000000","message":"This should default to the value of snapshot support rather than always true.","commit_id":"f43446084f3d1faa3a87c91d72bf6d38a989ddf7"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a525285b0bcda0b16477eacf9fb8890e602f5c11","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if (constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT"},{"line_number":46,"context_line":"            not in list(extra_specs)):"},{"line_number":47,"context_line":"        extra_specs["},{"line_number":48,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT] \u003d \u0027True\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        get_valid_required_extra_specs(extra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_7758af56","line":48,"in_reply_to":"3ac371cc_4556afce","updated":"2016-08-18 03:33:13.000000000","message":"I agree, fixed.","commit_id":"f43446084f3d1faa3a87c91d72bf6d38a989ddf7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"8d27398bba46ef5beeea79e0a151e59b79697e4d","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if key \u003d\u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT:"},{"line_number":270,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":271,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:"},{"line_number":272,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":273,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_0a99eec3","line":270,"range":{"start_line":270,"start_character":24,"end_line":270,"end_character":73},"updated":"2016-11-04 06:24:49.000000000","message":"why not directly use bool_from_string(value, default\u003dFalse)?","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"273c275020e10f88cb6917cf2bc480fc7a53f930","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if key \u003d\u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT:"},{"line_number":270,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":271,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:"},{"line_number":272,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":273,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_3b57c6cb","line":270,"range":{"start_line":270,"start_character":24,"end_line":270,"end_character":73},"in_reply_to":"ba5da102_0a99eec3","updated":"2016-11-04 19:32:18.000000000","message":"This is a validation method, so the goal here is to ensure the extra spec is a valid boolean value, not to set it to a default value.","commit_id":"03937d3544842c110c2c14a13f26624737d49db8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if key \u003d\u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT:"},{"line_number":270,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":271,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:"},{"line_number":272,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":273,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_46f382d6","line":270,"range":{"start_line":270,"start_character":41,"end_line":270,"end_character":46},"updated":"2016-12-02 18:30:10.000000000","message":"What if value equals to \"\u003cis\u003e True\"?","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05614159fa46cb118b0da9eaf7a1d9b55da5014a","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if key \u003d\u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT:"},{"line_number":270,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":271,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT:"},{"line_number":272,"context_line":"        return strutils.bool_from_string(value, default\u003dNone) is not None"},{"line_number":273,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_2dd6f34e","line":270,"range":{"start_line":270,"start_character":41,"end_line":270,"end_character":46},"in_reply_to":"3a71b18c_46f382d6","updated":"2016-12-06 16:06:07.000000000","message":"Looks like a bug in the current implementation of is_valid_required_extra_spec as well.. I\u0027ll fix this one..\n\nhttps://bugs.launchpad.net/manila/+bug/1647781","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c1a6bec00f4e1bfc4c42400ca2e7042a4eee487f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    for key in present_optional_extra_spec_keys:"},{"line_number":292,"context_line":"        value \u003d extra_specs.get(key, \u0027\u0027)"},{"line_number":293,"context_line":"        if not is_valid_optional_extra_spec(key, value):"},{"line_number":294,"context_line":"            msg \u003d _(\"Value of optional extra_spec %s is not valid\") % key"},{"line_number":295,"context_line":"            raise exception.InvalidExtraSpec(reason\u003dmsg)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        optional_extra_specs[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_3043da43","line":294,"range":{"start_line":294,"start_character":64,"end_line":294,"end_character":65},"updated":"2016-12-15 12:14:30.000000000","message":"period","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5303c1a66e9d3062bbc4639722f8f240ce162c0b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    for key in present_optional_extra_spec_keys:"},{"line_number":292,"context_line":"        value \u003d extra_specs.get(key, \u0027\u0027)"},{"line_number":293,"context_line":"        if not is_valid_optional_extra_spec(key, value):"},{"line_number":294,"context_line":"            msg \u003d _(\"Value of optional extra_spec %s is not valid\") % key"},{"line_number":295,"context_line":"            raise exception.InvalidExtraSpec(reason\u003dmsg)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        optional_extra_specs[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_40827653","line":294,"range":{"start_line":294,"start_character":64,"end_line":294,"end_character":65},"in_reply_to":"1a6eadb0_3043da43","updated":"2016-12-20 20:54:19.000000000","message":"Done","commit_id":"92ac9608c92bb1d5f69b9291c5e1ef72a64d7e2b"}],"manila/test.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        self.assertEqual(conv_and_sort(objs1), conv_and_sort(objs2))"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _microversion_ge(self, left, right):"},{"line_number":357,"context_line":"        return (api_version.APIVersionRequest(left) \u003e\u003d"},{"line_number":358,"context_line":"                api_version.APIVersionRequest(right))"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_c9fa13bd","line":356,"range":{"start_line":356,"start_character":8,"end_line":356,"end_character":24},"updated":"2016-12-21 12:49:29.000000000","message":"Why it has \"private\" prefix?","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        self.assertEqual(conv_and_sort(objs1), conv_and_sort(objs2))"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _microversion_ge(self, left, right):"},{"line_number":357,"context_line":"        return (api_version.APIVersionRequest(left) \u003e\u003d"},{"line_number":358,"context_line":"                api_version.APIVersionRequest(right))"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_d4ad439c","line":356,"range":{"start_line":356,"start_character":8,"end_line":356,"end_character":24},"in_reply_to":"1a6eadb0_c9fa13bd","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"}],"manila/tests/api/v1/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            \"description\": \"Share Test Desc\","},{"line_number":218,"context_line":"            \"share_proto\": \"fakeproto\","},{"line_number":219,"context_line":"            \"availability_zone\": \"zone1:host1\","},{"line_number":220,"context_line":"            \"share_network_id\": \"fakenetid\","},{"line_number":221,"context_line":"        }"},{"line_number":222,"context_line":"        create_mock \u003d mock.Mock(return_value\u003dstubs.stub_share(\u00271\u0027,"},{"line_number":223,"context_line":"                                display_name\u003dshr[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_641e8671","line":220,"range":{"start_line":220,"start_character":43,"end_line":220,"end_character":44},"updated":"2016-12-21 12:49:29.000000000","message":"this","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            \"description\": \"Share Test Desc\","},{"line_number":218,"context_line":"            \"share_proto\": \"fakeproto\","},{"line_number":219,"context_line":"            \"availability_zone\": \"zone1:host1\","},{"line_number":220,"context_line":"            \"share_network_id\": \"fakenetid\","},{"line_number":221,"context_line":"        }"},{"line_number":222,"context_line":"        create_mock \u003d mock.Mock(return_value\u003dstubs.stub_share(\u00271\u0027,"},{"line_number":223,"context_line":"                                display_name\u003dshr[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_549a136f","line":220,"range":{"start_line":220,"start_character":43,"end_line":220,"end_character":44},"in_reply_to":"1a6eadb0_641e8671","updated":"2016-12-21 14:48:43.000000000","message":"sigh. okay","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            \"share_proto\": \"fakeproto\","},{"line_number":356,"context_line":"            \"availability_zone\": \"zone1:host1\","},{"line_number":357,"context_line":"            \"snapshot_id\": 333,"},{"line_number":358,"context_line":"            \"share_network_id\": 1234,"},{"line_number":359,"context_line":"        }"},{"line_number":360,"context_line":"        body \u003d {\"share\": shr}"},{"line_number":361,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_e40a9625","line":358,"range":{"start_line":358,"start_character":36,"end_line":358,"end_character":37},"updated":"2016-12-21 12:49:29.000000000","message":"And this are redundant changes.","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            \"share_proto\": \"fakeproto\","},{"line_number":356,"context_line":"            \"availability_zone\": \"zone1:host1\","},{"line_number":357,"context_line":"            \"snapshot_id\": 333,"},{"line_number":358,"context_line":"            \"share_network_id\": 1234,"},{"line_number":359,"context_line":"        }"},{"line_number":360,"context_line":"        body \u003d {\"share\": shr}"},{"line_number":361,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_f47ddf1c","line":358,"range":{"start_line":358,"start_character":36,"end_line":358,"end_character":37},"in_reply_to":"1a6eadb0_e40a9625","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                          req,"},{"line_number":365,"context_line":"                          body)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    @ddt.data(\"1.0\", \"2.0\")"},{"line_number":368,"context_line":"    def test_share_create_from_snapshot_not_supported(self, microversion):"},{"line_number":369,"context_line":"        # This create operation should work, because the 1.0 API doesn\u0027t check"},{"line_number":370,"context_line":"        # create_share_from_snapshot_support."}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_4f00c301","line":367,"range":{"start_line":367,"start_character":26,"end_line":367,"end_character":27},"updated":"2016-12-21 12:49:29.000000000","message":"2.23?","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                          req,"},{"line_number":365,"context_line":"                          body)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    @ddt.data(\"1.0\", \"2.0\")"},{"line_number":368,"context_line":"    def test_share_create_from_snapshot_not_supported(self, microversion):"},{"line_number":369,"context_line":"        # This create operation should work, because the 1.0 API doesn\u0027t check"},{"line_number":370,"context_line":"        # create_share_from_snapshot_support."}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_f2dc0fe6","line":367,"range":{"start_line":367,"start_character":26,"end_line":367,"end_character":27},"in_reply_to":"1a6eadb0_4f00c301","updated":"2016-12-21 14:48:43.000000000","message":"2.0 is an equivalent of 1.0. From 2.1+, if you have snapshot_support\u003dTrue and create_share_from_snapshot_support\u003dFalse, you cannot create shares from snapshots. \n\nIn the database upgrade step, we copy the value of create_share_from_snapshot_support from snapshot_support - this preserves prior behavior.","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":128,"context_line":"        \u0027display_name\u0027: \u0027fake_share\u0027,"},{"line_number":129,"context_line":"        \u0027display_description\u0027: \u0027my fake share\u0027,"},{"line_number":130,"context_line":"        \u0027snapshot_id\u0027: \u0027fake snapshot id\u0027,"},{"line_number":131,"context_line":"        \u0027share_proto\u0027: \u0027nfs\u0027,"},{"line_number":132,"context_line":"        \u0027is_public\u0027: \u00271\u0027,"},{"line_number":133,"context_line":"        \u0027size\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_2f46274f","line":130,"range":{"start_line":130,"start_character":24,"end_line":130,"end_character":42},"updated":"2016-12-21 12:49:29.000000000","message":"why this one is not generated?","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":128,"context_line":"        \u0027display_name\u0027: \u0027fake_share\u0027,"},{"line_number":129,"context_line":"        \u0027display_description\u0027: \u0027my fake share\u0027,"},{"line_number":130,"context_line":"        \u0027snapshot_id\u0027: \u0027fake snapshot id\u0027,"},{"line_number":131,"context_line":"        \u0027share_proto\u0027: \u0027nfs\u0027,"},{"line_number":132,"context_line":"        \u0027is_public\u0027: \u00271\u0027,"},{"line_number":133,"context_line":"        \u0027size\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_14d09bf5","line":130,"range":{"start_line":130,"start_character":24,"end_line":130,"end_character":42},"in_reply_to":"1a6eadb0_2f46274f","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"                {"},{"line_number":1195,"context_line":"                    \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1196,"context_line":"                    \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":1197,"context_line":"                    \u0027name\u0027: \u0027share-type-1\u0027,"},{"line_number":1198,"context_line":"                    \u0027is_public\u0027: False,"},{"line_number":1199,"context_line":"                },"},{"line_number":1200,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_cfde936c","line":1197,"range":{"start_line":1197,"start_character":20,"end_line":1197,"end_character":43},"updated":"2016-12-21 12:49:29.000000000","message":"\u0027name\u0027: \u0027share-type-%d\u0027 % i,","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                    \u0027name\u0027: \u0027share-type-1\u0027,"},{"line_number":1198,"context_line":"                    \u0027is_public\u0027: False,"},{"line_number":1199,"context_line":"                },"},{"line_number":1200,"context_line":"                {"},{"line_number":1201,"context_line":"                    \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1202,"context_line":"                    \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":1203,"context_line":"                    \u0027name\u0027: \u0027share-type-2\u0027,"},{"line_number":1204,"context_line":"                    \u0027is_public\u0027: True,"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"                },"},{"line_number":1207,"context_line":"            ]"},{"line_number":1208,"context_line":"            snapshot_support \u003d (\u00270\u0027, \u00271\u0027)"},{"line_number":1209,"context_line":"            dhss \u003d (\u0027True\u0027, \u0027False\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_2f8b8769","line":1206,"range":{"start_line":1200,"start_character":16,"end_line":1206,"end_character":18},"updated":"2016-12-21 12:49:29.000000000","message":"for i in (1, 2)","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77c7bef644b4dc72526d4bce1f585038fbbb45ab","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                    \u0027name\u0027: \u0027share-type-1\u0027,"},{"line_number":1198,"context_line":"                    \u0027is_public\u0027: False,"},{"line_number":1199,"context_line":"                },"},{"line_number":1200,"context_line":"                {"},{"line_number":1201,"context_line":"                    \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1202,"context_line":"                    \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":1203,"context_line":"                    \u0027name\u0027: \u0027share-type-2\u0027,"},{"line_number":1204,"context_line":"                    \u0027is_public\u0027: True,"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"                },"},{"line_number":1207,"context_line":"            ]"},{"line_number":1208,"context_line":"            snapshot_support \u003d (\u00270\u0027, \u00271\u0027)"},{"line_number":1209,"context_line":"            dhss \u003d (\u0027True\u0027, \u0027False\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_41d97721","line":1206,"range":{"start_line":1200,"start_character":16,"end_line":1206,"end_character":18},"in_reply_to":"1a6eadb0_2f8b8769","updated":"2016-12-21 13:41:08.000000000","message":"Don\u0027t see value in doing that and foregoing the is_public attribute being different.","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"            extra_specs_in_db \u003d ("},{"line_number":1276,"context_line":"                engine.execute(extra_specs_table.select().where("},{"line_number":1277,"context_line":"                    extra_specs_table.c.deleted \u003d\u003d 0)).fetchall())"},{"line_number":1278,"context_line":"            self.test_case.assertTrue("},{"line_number":1279,"context_line":"                len(self.extra_specs) \u003c\u003d len(extra_specs_in_db))"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"            # New Extra spec for share types must match snapshot support"},{"line_number":1282,"context_line":"            for share_type_id in share_type_ids:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_ef498f32","line":1279,"range":{"start_line":1278,"start_character":12,"end_line":1279,"end_character":64},"updated":"2016-12-21 12:49:29.000000000","message":"assertLess? assertGreater?","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"            extra_specs_in_db \u003d ("},{"line_number":1276,"context_line":"                engine.execute(extra_specs_table.select().where("},{"line_number":1277,"context_line":"                    extra_specs_table.c.deleted \u003d\u003d 0)).fetchall())"},{"line_number":1278,"context_line":"            self.test_case.assertTrue("},{"line_number":1279,"context_line":"                len(self.extra_specs) \u003c\u003d len(extra_specs_in_db))"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"            # New Extra spec for share types must match snapshot support"},{"line_number":1282,"context_line":"            for share_type_id in share_type_ids:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_d4a1c347","line":1279,"range":{"start_line":1278,"start_character":12,"end_line":1279,"end_character":64},"in_reply_to":"1a6eadb0_ef498f32","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff311930e4c6f2a01184ff2ec9670e89f3f65409","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"            extra_specs_in_db \u003d ("},{"line_number":1323,"context_line":"                engine.execute(extra_specs_table.select().where("},{"line_number":1324,"context_line":"                    extra_specs_table.c.deleted \u003d\u003d 0)).fetchall())"},{"line_number":1325,"context_line":"            self.test_case.assertTrue("},{"line_number":1326,"context_line":"                len(self.extra_specs) \u003c\u003d len(extra_specs_in_db))"},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"            # Share types must not have create share from snapshot extra spec"},{"line_number":1329,"context_line":"            for share_type_id in share_type_ids:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_6f0bbfd6","line":1326,"range":{"start_line":1325,"start_character":12,"end_line":1326,"end_character":64},"updated":"2016-12-21 12:49:29.000000000","message":"ditto","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e48fe3aa5c29a9e9d2fac0397864c1aac78c8560","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"            extra_specs_in_db \u003d ("},{"line_number":1323,"context_line":"                engine.execute(extra_specs_table.select().where("},{"line_number":1324,"context_line":"                    extra_specs_table.c.deleted \u003d\u003d 0)).fetchall())"},{"line_number":1325,"context_line":"            self.test_case.assertTrue("},{"line_number":1326,"context_line":"                len(self.extra_specs) \u003c\u003d len(extra_specs_in_db))"},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"            # Share types must not have create share from snapshot extra spec"},{"line_number":1329,"context_line":"            for share_type_id in share_type_ids:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_14889bc4","line":1326,"range":{"start_line":1325,"start_character":12,"end_line":1326,"end_character":64},"in_reply_to":"1a6eadb0_6f0bbfd6","updated":"2016-12-21 14:48:43.000000000","message":"Done","commit_id":"7b92cdef6aa1cf37ba47ae532ca299db8471a7cd"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"3a40ee556da4f089c57753cad51f894c85186217","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                     \"for setting up custom share type. Defaults to value of \""},{"line_number":102,"context_line":"                     \"other config option \u0027run_snapshot_tests\u0027.\"),"},{"line_number":103,"context_line":"    cfg.BoolOpt(\"capability_create_share_from_snapshot_support\","},{"line_number":104,"context_line":"                default\u003dTrue,"},{"line_number":105,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":106,"context_line":"                     \"capability called \u0027create_share_from_snapshot_support\u0027 \""},{"line_number":107,"context_line":"                     \"and will be used for setting up custom share type. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_ae78bf2c","line":104,"updated":"2016-08-19 07:49:53.000000000","message":"Default to \u0027capability_snapshot_support\u0027 or maybe later to \u0027run_create_share_from_snapshot_tests\u0027 once that option is introduced? Do this in manila_tempest_tests/plugin.py?","commit_id":"8e3cc34efd90aa00ad1edeefb81857100b725ced"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                     \"for setting up custom share type. Defaults to value of \""},{"line_number":98,"context_line":"                     \"other config option \u0027run_snapshot_tests\u0027.\"),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\"capability_create_share_from_snapshot_support\","},{"line_number":100,"context_line":"                default\u003dTrue,"},{"line_number":101,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":102,"context_line":"                     \"capability called \u0027create_share_from_snapshot_support\u0027 \""},{"line_number":103,"context_line":"                     \"and will be used for setting up custom share type. \""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_a32a887c","line":100,"range":{"start_line":100,"start_character":16,"end_line":100,"end_character":29},"updated":"2016-12-02 18:30:10.000000000","message":"Why not defaulting to value of \"run_snapshot_tests\" as \"capability_snapshot_support\" does?","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                     \"for setting up custom share type. Defaults to value of \""},{"line_number":98,"context_line":"                     \"other config option \u0027run_snapshot_tests\u0027.\"),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\"capability_create_share_from_snapshot_support\","},{"line_number":100,"context_line":"                default\u003dTrue,"},{"line_number":101,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end \""},{"line_number":102,"context_line":"                     \"capability called \u0027create_share_from_snapshot_support\u0027 \""},{"line_number":103,"context_line":"                     \"and will be used for setting up custom share type. \""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_f28a1663","line":100,"range":{"start_line":100,"start_character":16,"end_line":100,"end_character":29},"in_reply_to":"3a71b18c_a32a887c","updated":"2016-12-06 15:35:37.000000000","message":"Done","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"}],"manila_tempest_tests/tests/api/admin/test_share_types_extra_specs.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertNotIn(\u0027key1\u0027, get)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":121,"context_line":"    @ddt.data(\u00272.23\u0027, LATEST_MICROVERSION)"},{"line_number":122,"context_line":"    def test_delete_snapshot_support_extra_spec(self, version):"},{"line_number":123,"context_line":"        self.skip_if_microversion_not_supported(version)"},{"line_number":124,"context_line":"        # Delete one extra spec for share type"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_e3e1e0ff","line":121,"range":{"start_line":121,"start_character":14,"end_line":121,"end_character":41},"updated":"2016-12-02 18:30:10.000000000","message":"Please, rewrite to following to avoid duplication:\n\n\"\"\"\n\n*set((\u00272.23\u0027, LATEST_MICROVERSION))\n\n\"\"\"","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertNotIn(\u0027key1\u0027, get)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":121,"context_line":"    @ddt.data(\u00272.23\u0027, LATEST_MICROVERSION)"},{"line_number":122,"context_line":"    def test_delete_snapshot_support_extra_spec(self, version):"},{"line_number":123,"context_line":"        self.skip_if_microversion_not_supported(version)"},{"line_number":124,"context_line":"        # Delete one extra spec for share type"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_f24856b5","line":121,"range":{"start_line":121,"start_character":14,"end_line":121,"end_character":41},"in_reply_to":"3a71b18c_e3e1e0ff","updated":"2016-12-06 15:35:37.000000000","message":"Oh yeah, nice!","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"}],"manila_tempest_tests/tests/api/admin/test_shares_actions.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                filters[\u0027share_network_id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":256,"context_line":"    @testtools.skipUnless("},{"line_number":257,"context_line":"        CONF.share.capability_create_share_from_snapshot_support,"},{"line_number":258,"context_line":"        \"Create share from snapshot tests are disabled.\")"},{"line_number":259,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":260,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_4379b4f5","line":258,"range":{"start_line":256,"start_character":4,"end_line":258,"end_character":57},"updated":"2016-12-02 18:30:10.000000000","message":"It should be additional decorator. One may want just to skip snapshot tests with \"run_snapshot_tests\" option.","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc937e2cf68bb271310e6f7212d345d21bdd93bd","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                filters[\u0027share_network_id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":256,"context_line":"    @testtools.skipUnless("},{"line_number":257,"context_line":"        CONF.share.capability_create_share_from_snapshot_support,"},{"line_number":258,"context_line":"        \"Create share from snapshot tests are disabled.\")"},{"line_number":259,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":260,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_920f2236","line":258,"range":{"start_line":256,"start_character":4,"end_line":258,"end_character":57},"in_reply_to":"3a71b18c_4379b4f5","updated":"2016-12-06 15:35:37.000000000","message":"Hmmm.. if run_snapshot_tests is false, why would they set this capability to True?","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5886a46bdbf29f623d63e2d5fb4a0733711b5083","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                filters[\u0027share_network_id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":256,"context_line":"    @testtools.skipUnless("},{"line_number":257,"context_line":"        CONF.share.capability_create_share_from_snapshot_support,"},{"line_number":258,"context_line":"        \"Create share from snapshot tests are disabled.\")"},{"line_number":259,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":260,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_b9b9f030","line":258,"range":{"start_line":256,"start_character":4,"end_line":258,"end_character":57},"in_reply_to":"3a71b18c_920f2236","updated":"2016-12-08 18:06:53.000000000","message":"It is capability for picking up host it is not directly related to \"running snapshot tests\". So, again, it should have both decorators.","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf23170e10c04f910b7a962dc16ade9356aa324e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                filters[\u0027share_network_id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":256,"context_line":"    @testtools.skipUnless("},{"line_number":257,"context_line":"        CONF.share.capability_create_share_from_snapshot_support,"},{"line_number":258,"context_line":"        \"Create share from snapshot tests are disabled.\")"},{"line_number":259,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":260,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a71b18c_797cb820","line":258,"range":{"start_line":256,"start_character":4,"end_line":258,"end_character":57},"updated":"2016-12-08 18:14:32.000000000","message":"https://review.openstack.org/#/c/356682/21/manila_tempest_tests/tests/api/admin/test_shares_actions.py@256","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"764faf0ef727b2dd22e51cfd54d6ca265f156d62","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                filters[\u0027share_network_id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":256,"context_line":"    @testtools.skipUnless("},{"line_number":257,"context_line":"        CONF.share.capability_create_share_from_snapshot_support,"},{"line_number":258,"context_line":"        \"Create share from snapshot tests are disabled.\")"},{"line_number":259,"context_line":"    def test_list_shares_with_detail_filter_by_snapshot_id(self):"},{"line_number":260,"context_line":"        filters \u003d {\u0027snapshot_id\u0027: self.snap[\u0027id\u0027]}"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a71b18c_b92f30a0","line":258,"range":{"start_line":256,"start_character":4,"end_line":258,"end_character":57},"in_reply_to":"3a71b18c_797cb820","updated":"2016-12-08 19:14:03.000000000","message":"Done","commit_id":"f51ad99c72601957daa7c7624bc1962ad5008fc4"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b567481dc1be6946b3bac4d75e691f5fc918dd71","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        return share_type"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    @staticmethod"},{"line_number":730,"context_line":"    def add_extra_specs_to_dict(extra_specs\u003dNone):"},{"line_number":731,"context_line":"        \"\"\"Add any required extra-specs to share type dictionary\"\"\""},{"line_number":732,"context_line":"        dhss \u003d six.text_type(CONF.share.multitenancy_enabled)"},{"line_number":733,"context_line":"        snapshot_support \u003d six.text_type("}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_4331b404","line":730,"range":{"start_line":730,"start_character":8,"end_line":730,"end_character":31},"updated":"2016-12-02 18:30:10.000000000","message":"Rename of this func is unnecessary in scope of this commit. It is huge without this. So, would be really good to separate that to another commit.","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3253da308afede4db2e0330bb391e029e021bd3b","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        return share_type"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    @staticmethod"},{"line_number":730,"context_line":"    def add_extra_specs_to_dict(extra_specs\u003dNone):"},{"line_number":731,"context_line":"        \"\"\"Add any required extra-specs to share type dictionary\"\"\""},{"line_number":732,"context_line":"        dhss \u003d six.text_type(CONF.share.multitenancy_enabled)"},{"line_number":733,"context_line":"        snapshot_support \u003d six.text_type("}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_048e74cf","line":730,"range":{"start_line":730,"start_character":8,"end_line":730,"end_character":31},"in_reply_to":"3a71b18c_4331b404","updated":"2016-12-06 14:53:56.000000000","message":"? Splitting it makes no sense to me.. When snapshot support was added, we didn\u0027t have to update the method name [1]. However, since we\u0027re making snapshot_support optional, retaining the name would only confuse developers. \n\n[1] https://review.openstack.org/#/c/211222/19/contrib/tempest/tempest/api/share/base.py","commit_id":"9fe64f99732edb0a054de4ff7e2a49b3d9a480b8"}]}
