)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d6a61e7369addb8cdd6ee828e9a10e3b61b99850","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VNX: Use job for NFS share creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consolidates file system creation"},{"line_number":10,"context_line":"and share creation in one rest call."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I513ec9d4bd54e9c741caed4e94e115b0fe44dd0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_242ca101","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":44},"updated":"2016-08-29 09:25:08.000000000","message":"consolidates NFS file system creation","commit_id":"5cb1f27fb2cab648cf89a4000c0393aa980b28f1"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"2c2aaef8092e07affd69320d9e05200eac390956","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VNX: Use job for NFS share creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consolidates file system creation"},{"line_number":10,"context_line":"and share creation in one rest call."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I513ec9d4bd54e9c741caed4e94e115b0fe44dd0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_46388d3d","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":44},"in_reply_to":"fa7ab95a_242ca101","updated":"2016-08-30 03:06:05.000000000","message":"Done","commit_id":"5cb1f27fb2cab648cf89a4000c0393aa980b28f1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8d4bc7c6abbdb45ce494b188422801189bdb0579","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unity: Use job for NFS share creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consolidates NFS file system creation"},{"line_number":10,"context_line":"and share creation in one rest call."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I513ec9d4bd54e9c741caed4e94e115b0fe44dd0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa7ab95a_29eb0eb2","line":10,"updated":"2016-08-31 03:50:46.000000000","message":"Can you open a bug to keep track of this change?","commit_id":"fba6889599ddd35e8f12c683d780aed610c2b5f5"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"5c92ccf87f0030427e644559902d8ce02a187789","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unity: Use job for NFS share creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consolidates NFS file system creation"},{"line_number":10,"context_line":"and share creation in one rest call."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I513ec9d4bd54e9c741caed4e94e115b0fe44dd0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa7ab95a_eba66852","line":10,"in_reply_to":"fa7ab95a_29eb0eb2","updated":"2016-08-31 10:44:14.000000000","message":"Done","commit_id":"fba6889599ddd35e8f12c683d780aed610c2b5f5"}],"manila/share/drivers/emc/plugins/unity/client.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9cdb5b209aa1c36b5ecf8900e1e884718794f194","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :param nas_server: nas server for file system creation"},{"line_number":79,"context_line":"        :param share_name: file system and share name"},{"line_number":80,"context_line":"        :param size: file system size"},{"line_number":81,"context_line":"        :return: nfs share object"},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        pool.create_nfs_share("},{"line_number":84,"context_line":"            nas_server, share_name, size)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_04e96814","line":81,"updated":"2016-08-29 03:06:47.000000000","message":"Look like this method doesn\u0027t return anything. remove.","commit_id":"ac387d456638aad0aee22a4e3577131f7d0285e6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8d4bc7c6abbdb45ce494b188422801189bdb0579","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            return self.get_share(share_name, \u0027NFS\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @staticmethod"},{"line_number":73,"context_line":"    def create_nfs_share_batch(pool, nas_server, share_name,"},{"line_number":74,"context_line":"                               size):"},{"line_number":75,"context_line":"        \"\"\"Create filesystem and share from pool/NAS server."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_09348a48","line":73,"updated":"2016-08-31 03:50:46.000000000","message":"The name \"create_nfs_share_batch\" sounds like you are creating multiple shares in one call, but you are actually just creating one share.  How about renaming this to \"create_nfs_share_and_filesystem\"?","commit_id":"fba6889599ddd35e8f12c683d780aed610c2b5f5"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"5c92ccf87f0030427e644559902d8ce02a187789","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            return self.get_share(share_name, \u0027NFS\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @staticmethod"},{"line_number":73,"context_line":"    def create_nfs_share_batch(pool, nas_server, share_name,"},{"line_number":74,"context_line":"                               size):"},{"line_number":75,"context_line":"        \"\"\"Create filesystem and share from pool/NAS server."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_ab8540ae","line":73,"in_reply_to":"fa7ab95a_09348a48","updated":"2016-08-31 10:44:14.000000000","message":"Done","commit_id":"fba6889599ddd35e8f12c683d780aed610c2b5f5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4230e00ba71df37a2fa78cb8098d33749e51f2c1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        :param share_name: file system and share name"},{"line_number":80,"context_line":"        :param size: file system size"},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        pool.create_nfs_share("},{"line_number":83,"context_line":"            nas_server, share_name, size)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_share(self, name, share_proto):"},{"line_number":86,"context_line":"        # Validate the share protocol"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_cb2ecf41","line":83,"range":{"start_line":82,"start_character":8,"end_line":83,"end_character":41},"updated":"2016-09-01 02:06:17.000000000","message":"nit: this could be one line","commit_id":"9edb93df7efe9d9c026c768cbe8acdecc6d674e8"}],"manila/share/drivers/emc/plugins/unity/connection.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0cec2406f3313fa65f4ca2f5cff423220f41ec0f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            locations \u003d self._get_cifs_location("},{"line_number":131,"context_line":"                nas_server.file_interface, share_name)"},{"line_number":132,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":133,"context_line":"            self.client.create_nfs_share_batch("},{"line_number":134,"context_line":"                pool, nas_server, share_name, size)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"            locations \u003d self._get_nfs_location("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_e185a4ad","line":133,"range":{"start_line":133,"start_character":17,"end_line":133,"end_character":47},"updated":"2016-08-31 11:57:01.000000000","message":"create_nfs_filesystem_and_share","commit_id":"c91cde996baed5bc9da06e52d901d72a67c4e613"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"74913f9b17d79902cafffc19231a39968d309e5c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            locations \u003d self._get_cifs_location("},{"line_number":131,"context_line":"                nas_server.file_interface, share_name)"},{"line_number":132,"context_line":"        elif share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":133,"context_line":"            self.client.create_nfs_share_batch("},{"line_number":134,"context_line":"                pool, nas_server, share_name, size)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"            locations \u003d self._get_nfs_location("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_48cbcc1e","line":133,"range":{"start_line":133,"start_character":17,"end_line":133,"end_character":47},"in_reply_to":"fa7ab95a_e185a4ad","updated":"2016-08-31 13:47:53.000000000","message":"Thanks Tom for finding my fault\n\nReally appreciate!","commit_id":"c91cde996baed5bc9da06e52d901d72a67c4e613"}],"manila/tests/share/drivers/emc/plugins/unity/mocked_unity.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d6a61e7369addb8cdd6ee828e9a10e3b61b99850","unresolved":false,"context_lines":[{"line_number":817,"context_line":"  nfs_share:"},{"line_number":818,"context_line":"    _properties:"},{"line_number":819,"context_line":"      name: \u0027716100cc-e0b4-416b-ac27-d38dd019330d\u0027"},{"line_number":820,"context_line":"      size: 151081080"},{"line_number":821,"context_line":"test_get_share_with_invalid_proto:"},{"line_number":822,"context_line":"  share:"},{"line_number":823,"context_line":"    _properties:"},{"line_number":824,"context_line":"      \u003c\u003c: *share_base_prop"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_2464a120","line":821,"range":{"start_line":820,"start_character":0,"end_line":821,"end_character":34},"updated":"2016-08-29 09:25:08.000000000","message":"blank line between these two?","commit_id":"5cb1f27fb2cab648cf89a4000c0393aa980b28f1"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"2c2aaef8092e07affd69320d9e05200eac390956","unresolved":false,"context_lines":[{"line_number":817,"context_line":"  nfs_share:"},{"line_number":818,"context_line":"    _properties:"},{"line_number":819,"context_line":"      name: \u0027716100cc-e0b4-416b-ac27-d38dd019330d\u0027"},{"line_number":820,"context_line":"      size: 151081080"},{"line_number":821,"context_line":"test_get_share_with_invalid_proto:"},{"line_number":822,"context_line":"  share:"},{"line_number":823,"context_line":"    _properties:"},{"line_number":824,"context_line":"      \u003c\u003c: *share_base_prop"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_26fc6971","line":821,"range":{"start_line":820,"start_character":0,"end_line":821,"end_character":34},"in_reply_to":"fa7ab95a_2464a120","updated":"2016-08-30 03:06:05.000000000","message":"Done","commit_id":"5cb1f27fb2cab648cf89a4000c0393aa980b28f1"}],"manila/tests/share/drivers/emc/plugins/unity/test_client.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d6a61e7369addb8cdd6ee828e9a10e3b61b99850","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_create_nfs_share__existed_expt(self, client, mocked_input):"},{"line_number":35,"context_line":"        resource \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":36,"context_line":"        share \u003d mocked_input[\u0027nfs_share\u0027]"},{"line_number":37,"context_line":"        new_share \u003d client.create_nfs_share("},{"line_number":38,"context_line":"            resource, share.name)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertEqual(share.name, new_share.name)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_5fded23f","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":33},"updated":"2016-08-29 09:25:08.000000000","message":"This doesn\u0027t seem to be a part of the change described by the commit message.","commit_id":"5cb1f27fb2cab648cf89a4000c0393aa980b28f1"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"2c2aaef8092e07affd69320d9e05200eac390956","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def test_create_nfs_share__existed_expt(self, client, mocked_input):"},{"line_number":35,"context_line":"        resource \u003d mocked_input[\u0027filesystem\u0027]"},{"line_number":36,"context_line":"        share \u003d mocked_input[\u0027nfs_share\u0027]"},{"line_number":37,"context_line":"        new_share \u003d client.create_nfs_share("},{"line_number":38,"context_line":"            resource, share.name)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertEqual(share.name, new_share.name)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_46ea4dad","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":33},"in_reply_to":"fa7ab95a_5fded23f","updated":"2016-08-30 03:06:05.000000000","message":"reverted this change","commit_id":"5cb1f27fb2cab648cf89a4000c0393aa980b28f1"}]}