)]}'
{"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"080e85f22899d6a4b912f5bfebbb512e786f22c9","unresolved":false,"context_lines":[{"line_number":3090,"context_line":"    def test_setup_server_success(self):"},{"line_number":3091,"context_line":"        backend_details \u003d self.driver.setup_server("},{"line_number":3092,"context_line":"            self.fake_network_info,"},{"line_number":3093,"context_line":"            metadata\u003dconstants.SETUP_SERVER_METADATA)"},{"line_number":3094,"context_line":"        fake_share_server \u003d {"},{"line_number":3095,"context_line":"            \u0027backend_details\u0027: backend_details"},{"line_number":3096,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_4ff7de58","line":3093,"range":{"start_line":3093,"start_character":21,"end_line":3093,"end_character":52},"updated":"2016-09-13 02:49:03.000000000","message":"Hi Jay Mehta, Thanks for mention this should pass kwarg metadata. How about define a constant(SETUP_SERVER_METADATA) in test_huawei_nas.py or just use \u0027None\u0027, because the SETUP_SERVER_METADATA only used for unit test, not used for huawei driver code.","commit_id":"ec7c11ab1ef8e36cbf82dfcd6ba780fa534cb7eb"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"038947237cb981d68274347b535c2b0cfd266cc0","unresolved":false,"context_lines":[{"line_number":3090,"context_line":"    def test_setup_server_success(self):"},{"line_number":3091,"context_line":"        backend_details \u003d self.driver.setup_server("},{"line_number":3092,"context_line":"            self.fake_network_info,"},{"line_number":3093,"context_line":"            metadata\u003dconstants.SETUP_SERVER_METADATA)"},{"line_number":3094,"context_line":"        fake_share_server \u003d {"},{"line_number":3095,"context_line":"            \u0027backend_details\u0027: backend_details"},{"line_number":3096,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_6f250bc1","line":3093,"range":{"start_line":3093,"start_character":21,"end_line":3093,"end_character":52},"in_reply_to":"9a89bdaa_4ff7de58","updated":"2016-09-14 01:31:57.000000000","message":"Thanks for pointing out that constants file is used only for driver code and not for unit test. Patch set 3 addresses this change and correctly calls setup_server() in unit test.","commit_id":"ec7c11ab1ef8e36cbf82dfcd6ba780fa534cb7eb"}]}