)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"22698dc395cf23ffa653e94e1b5a2f88d261766c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve Share Migration tempest tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Improve coverage by adding tests that validate the share-type"},{"line_number":10,"context_line":"change while also changing the driver mode. These tests are"},{"line_number":11,"context_line":"expected to run only in dummy driver\u0027s CI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1620800"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a89bdaa_24c81822","line":11,"range":{"start_line":10,"start_character":44,"end_line":11,"end_character":42},"updated":"2016-09-12 15:59:40.000000000","message":"I think this sentence should be removed. You have added tempest tests, that can work using any backend and it does not matter that lots of them could just not support that feature.","commit_id":"a7bfd7355dfe79177b427f3627a354ebeceb707f"}],"manila_tempest_tests/tests/api/admin/test_migration.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"577af49e321cfba6baa0c34d4560a8af9929a700","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        # If currently configured is DHSS\u003dFalse,"},{"line_number":126,"context_line":"        # then we need it for DHSS\u003dTrue"},{"line_number":127,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":128,"context_line":"            new_share_network_id \u003d self.create_share_network("},{"line_number":129,"context_line":"                name\u003d\"share_network_for_migration\")[\u0027id\u0027]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # If currently configured is DHSS\u003dTrue,"},{"line_number":132,"context_line":"        # then we must pass None for DHSS\u003dFalse"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_09a0f6a4","line":129,"range":{"start_line":128,"start_character":12,"end_line":129,"end_character":57},"updated":"2016-09-09 09:47:52.000000000","message":"You should not code tests thinking it will run only on dummy driver. For the moment, it will work only if neutron data is not used. You should consider here option \"create_networks_when_multitenancy_enabled\".","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3269507713b7eebdfb0a8ba1785f7e507d0a50b7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        # If currently configured is DHSS\u003dFalse,"},{"line_number":126,"context_line":"        # then we need it for DHSS\u003dTrue"},{"line_number":127,"context_line":"        if not CONF.share.multitenancy_enabled:"},{"line_number":128,"context_line":"            new_share_network_id \u003d self.create_share_network("},{"line_number":129,"context_line":"                name\u003d\"share_network_for_migration\")[\u0027id\u0027]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # If currently configured is DHSS\u003dTrue,"},{"line_number":132,"context_line":"        # then we must pass None for DHSS\u003dFalse"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_5862b8ae","line":129,"range":{"start_line":128,"start_character":12,"end_line":129,"end_character":57},"in_reply_to":"9a89bdaa_09a0f6a4","updated":"2016-09-09 14:25:29.000000000","message":"good point. other driver will require real share networks","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"577af49e321cfba6baa0c34d4560a8af9929a700","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        if opposite:"},{"line_number":263,"context_line":"            if not dest_pool:"},{"line_number":264,"context_line":"                raise self.skipException("},{"line_number":265,"context_line":"                    \"To run driver mode change tests it is required pools \""},{"line_number":266,"context_line":"                    \"running different driver modes.\")"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            self.assertIsNotNone(dest_pool)"},{"line_number":269,"context_line":"            self.assertIsNotNone(dest_pool.get(\u0027name\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_29f21a70","line":266,"range":{"start_line":265,"start_character":21,"end_line":266,"end_character":52},"updated":"2016-09-09 09:47:52.000000000","message":"I got the idea of this message after some meditation on it. I guess you wanted to say something more obvious like following:\n\n\"\"\"\nSkipped, because test requires two backends with different driver modes enabled - DHSS\u003dTrue and DHSS\u003dFalse.\n\"\"\"","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3269507713b7eebdfb0a8ba1785f7e507d0a50b7","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        if opposite:"},{"line_number":263,"context_line":"            if not dest_pool:"},{"line_number":264,"context_line":"                raise self.skipException("},{"line_number":265,"context_line":"                    \"To run driver mode change tests it is required pools \""},{"line_number":266,"context_line":"                    \"running different driver modes.\")"},{"line_number":267,"context_line":"        else:"},{"line_number":268,"context_line":"            self.assertIsNotNone(dest_pool)"},{"line_number":269,"context_line":"            self.assertIsNotNone(dest_pool.get(\u0027name\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_a4d007f9","line":266,"range":{"start_line":265,"start_character":21,"end_line":266,"end_character":52},"in_reply_to":"9a89bdaa_29f21a70","updated":"2016-09-09 14:25:29.000000000","message":"Done","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4038f39c38d3ec5a47cafe70e84357f60b5dde96","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                               \u0027access_type\u0027: rule[\u0027access_type\u0027]}"},{"line_number":321,"context_line":"                              for rule in rules]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"            filtered_rules \u003d sorted(filtered_rules,"},{"line_number":324,"context_line":"                                    key\u003dlambda x: x[\u0027access_to\u0027])"},{"line_number":325,"context_line":"            expected_rules \u003d sorted(expected_rules,"},{"line_number":326,"context_line":"                                    key\u003dlambda x: x[\u0027access_to\u0027])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            i \u003d 0"},{"line_number":329,"context_line":"            while i \u003c len(expected_rules):"},{"line_number":330,"context_line":"                self.assertDictMatch(expected_rules[i], filtered_rules[i])"},{"line_number":331,"context_line":"                i +\u003d 1"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            self.shares_v2_client.delete_share(share[\u0027id\u0027])"},{"line_number":334,"context_line":"            self.shares_v2_client.wait_for_resource_deletion("}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_5b4cdb9d","line":331,"range":{"start_line":323,"start_character":12,"end_line":331,"end_character":22},"updated":"2016-09-13 14:30:53.000000000","message":"\"\"\"\nfor r in expected_rules:\n    self.assertIn(r, filtered_rules)\nself.assertEqual(len(expected_rules), len(filtered_rules))\n\"\"\"\n?","commit_id":"f7d2f680107eccdb594242577d51cfef3a53c9d8"}],"manila_tempest_tests/tests/api/admin/test_migration_negative.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"6533dbc8be4524e3af103290afdb2c5a79ae42c7","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    @base.skip_if_microversion_lt(\"2.22\")"},{"line_number":218,"context_line":"    def test_migrate_share_opposite_type_share_network_invalid(self):"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        extra_specs \u003d utils.get_configured_extra_specs()"},{"line_number":221,"context_line":"        extra_specs[\u0027driver_handles_share_servers\u0027] \u003d ("},{"line_number":222,"context_line":"            not CONF.share.multitenancy_enabled)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        new_type_opposite \u003d self.create_share_type("},{"line_number":225,"context_line":"            name\u003ddata_utils.rand_name(\u0027share_type_migration_negative\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_8e23bea6","line":222,"range":{"start_line":220,"start_character":8,"end_line":222,"end_character":48},"updated":"2016-09-07 03:36:09.000000000","message":"can be replaced by utils.get_configured_extra_specs(\u0027opposite_driver_modes\u0027)","commit_id":"95c7d68ab8f5a5cef5cb5f125a469f384ee582fd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d6fb4fd36b44559945c7b7f6c4f84f261cf51756","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    @base.skip_if_microversion_lt(\"2.22\")"},{"line_number":218,"context_line":"    def test_migrate_share_opposite_type_share_network_invalid(self):"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        extra_specs \u003d utils.get_configured_extra_specs()"},{"line_number":221,"context_line":"        extra_specs[\u0027driver_handles_share_servers\u0027] \u003d ("},{"line_number":222,"context_line":"            not CONF.share.multitenancy_enabled)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        new_type_opposite \u003d self.create_share_type("},{"line_number":225,"context_line":"            name\u003ddata_utils.rand_name(\u0027share_type_migration_negative\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_e0e35cd7","line":222,"range":{"start_line":220,"start_character":8,"end_line":222,"end_character":48},"in_reply_to":"9a89bdaa_8e23bea6","updated":"2016-09-07 13:22:14.000000000","message":"good call. I was trying to do both tests here independently of the configuration setting, but it did not work.","commit_id":"95c7d68ab8f5a5cef5cb5f125a469f384ee582fd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"577af49e321cfba6baa0c34d4560a8af9929a700","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            new_share_network \u003d self.create_share_network("},{"line_number":230,"context_line":"                neutron_net_id\u003d\u0027fake_net_id\u0027,"},{"line_number":231,"context_line":"                neutron_subnet_id\u003d\u0027fake_subnet_id\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"            self.assertRaises("},{"line_number":234,"context_line":"                lib_exc.BadRequest, self.shares_v2_client.migrate_share,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_8ee6cc14","line":231,"range":{"start_line":229,"start_character":12,"end_line":231,"end_character":51},"updated":"2016-09-09 09:47:52.000000000","message":"It should consider config option called \"create_networks_when_multitenancy_enabled\". Because we have use case when share network stays empty.","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3269507713b7eebdfb0a8ba1785f7e507d0a50b7","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            new_share_network \u003d self.create_share_network("},{"line_number":230,"context_line":"                neutron_net_id\u003d\u0027fake_net_id\u0027,"},{"line_number":231,"context_line":"                neutron_subnet_id\u003d\u0027fake_subnet_id\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"            self.assertRaises("},{"line_number":234,"context_line":"                lib_exc.BadRequest, self.shares_v2_client.migrate_share,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_075295dd","line":231,"range":{"start_line":229,"start_character":12,"end_line":231,"end_character":51},"in_reply_to":"9a89bdaa_8ee6cc14","updated":"2016-09-09 14:25:29.000000000","message":"this should not go past API. Regardless of it is valid or not, if it is consumed by API, test fails.","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"577af49e321cfba6baa0c34d4560a8af9929a700","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                neutron_net_id\u003d\u0027fake_net_id\u0027,"},{"line_number":231,"context_line":"                neutron_subnet_id\u003d\u0027fake_subnet_id\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"            self.assertRaises("},{"line_number":234,"context_line":"                lib_exc.BadRequest, self.shares_v2_client.migrate_share,"},{"line_number":235,"context_line":"                self.share[\u0027id\u0027], self.dest_pool,"},{"line_number":236,"context_line":"                new_share_type_id\u003dnew_type_opposite[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":237,"context_line":"                new_share_network_id\u003dnew_share_network[\u0027id\u0027])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"            self.assertRaises("},{"line_number":242,"context_line":"                lib_exc.BadRequest, self.shares_v2_client.migrate_share,"},{"line_number":243,"context_line":"                self.share[\u0027id\u0027], self.dest_pool,"},{"line_number":244,"context_line":"                new_share_type_id\u003dnew_type_opposite[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":245,"context_line":"                new_share_network_id\u003dNone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_6eb428d1","line":245,"range":{"start_line":233,"start_character":12,"end_line":245,"end_character":42},"updated":"2016-09-09 09:47:52.000000000","message":"It is copy-paste. You could just reuse some var called \"share_network_Id\" that could either have value or be None.","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3269507713b7eebdfb0a8ba1785f7e507d0a50b7","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                neutron_net_id\u003d\u0027fake_net_id\u0027,"},{"line_number":231,"context_line":"                neutron_subnet_id\u003d\u0027fake_subnet_id\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"            self.assertRaises("},{"line_number":234,"context_line":"                lib_exc.BadRequest, self.shares_v2_client.migrate_share,"},{"line_number":235,"context_line":"                self.share[\u0027id\u0027], self.dest_pool,"},{"line_number":236,"context_line":"                new_share_type_id\u003dnew_type_opposite[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":237,"context_line":"                new_share_network_id\u003dnew_share_network[\u0027id\u0027])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"            self.assertRaises("},{"line_number":242,"context_line":"                lib_exc.BadRequest, self.shares_v2_client.migrate_share,"},{"line_number":243,"context_line":"                self.share[\u0027id\u0027], self.dest_pool,"},{"line_number":244,"context_line":"                new_share_type_id\u003dnew_type_opposite[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":245,"context_line":"                new_share_network_id\u003dNone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_47d49d46","line":245,"range":{"start_line":233,"start_character":12,"end_line":245,"end_character":42},"in_reply_to":"9a89bdaa_6eb428d1","updated":"2016-09-09 14:25:29.000000000","message":"Done","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"}],"manila_tempest_tests/utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"577af49e321cfba6baa0c34d4560a8af9929a700","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    return selected_pool"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def get_configured_extra_specs(variation\u003dNone):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    extra_specs \u003d {\u0027storage_protocol\u0027: CONF.share.capability_storage_protocol}"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_49b59e7c","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":47},"updated":"2016-09-09 09:47:52.000000000","message":"You propose people to read source code always instead of human-friendly docstring?","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3269507713b7eebdfb0a8ba1785f7e507d0a50b7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    return selected_pool"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def get_configured_extra_specs(variation\u003dNone):"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    extra_specs \u003d {\u0027storage_protocol\u0027: CONF.share.capability_storage_protocol}"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_84a3034f","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":47},"in_reply_to":"9a89bdaa_49b59e7c","updated":"2016-09-09 14:25:29.000000000","message":"Done","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"577af49e321cfba6baa0c34d4560a8af9929a700","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    else:"},{"line_number":137,"context_line":"        extra_specs[\u0027driver_handles_share_servers\u0027] \u003d ("},{"line_number":138,"context_line":"            CONF.share.multitenancy_enabled)"},{"line_number":139,"context_line":"        extra_specs[\u0027snapshot_support\u0027] \u003d six.text_type("},{"line_number":140,"context_line":"            CONF.share.capability_snapshot_support)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    return extra_specs"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_44082529","line":140,"range":{"start_line":138,"start_character":12,"end_line":140,"end_character":50},"updated":"2016-09-09 09:47:52.000000000","message":"\"multitenancy_enabled\" and \"capability_snapshot_support\" are both boolean opts. Why do you transform one of them to string? Why only one?","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3269507713b7eebdfb0a8ba1785f7e507d0a50b7","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    else:"},{"line_number":137,"context_line":"        extra_specs[\u0027driver_handles_share_servers\u0027] \u003d ("},{"line_number":138,"context_line":"            CONF.share.multitenancy_enabled)"},{"line_number":139,"context_line":"        extra_specs[\u0027snapshot_support\u0027] \u003d six.text_type("},{"line_number":140,"context_line":"            CONF.share.capability_snapshot_support)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    return extra_specs"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_04f9b34d","line":140,"range":{"start_line":138,"start_character":12,"end_line":140,"end_character":50},"in_reply_to":"9a89bdaa_44082529","updated":"2016-09-09 14:25:29.000000000","message":"Done","commit_id":"50fc64bff9a82b52d970dea158ce86e783949067"}]}
