)]}'
{"manila/share/drivers/helpers.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"1c224802cafc8a669c87082267728a7492c63f82","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        else:"},{"line_number":513,"context_line":"            return \u0027read list\u0027"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _set_valid_users(self, server, users, share_name, access_level):"},{"line_number":516,"context_line":"        value \u003d \"\\\"\" + \u0027 \u0027.join(users) + \"\\\"\""},{"line_number":517,"context_line":"        if value \u003d\u003d \"\\\"\\\"\":"},{"line_number":518,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_2bfa8d75","line":515,"updated":"2016-09-07 11:38:29.000000000","message":"I think it would be better to check is users is empty before constructing the value, instead of of checking afterwards if value is \"\".","commit_id":"3d95bfddf268338b0e689b10842563f0ff324a04"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"91b6db82fed118232ca143892f2264c7130c14f0","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        else:"},{"line_number":513,"context_line":"            return \u0027read list\u0027"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _set_valid_users(self, server, users, share_name, access_level):"},{"line_number":516,"context_line":"        value \u003d \"\\\"\" + \u0027 \u0027.join(users) + \"\\\"\""},{"line_number":517,"context_line":"        if value \u003d\u003d \"\\\"\\\"\":"},{"line_number":518,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_4e535f6b","line":515,"in_reply_to":"9a89bdaa_2bfa8d75","updated":"2016-09-07 11:51:07.000000000","message":"Yeah, that has occurred to me right after I\u0027ve uploaded this version.","commit_id":"3d95bfddf268338b0e689b10842563f0ff324a04"}],"manila/tests/share/drivers/test_helpers.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7ded06303fc2e72198de1894468f52b5aaa53a0e","unresolved":false,"context_lines":[{"line_number":622,"context_line":"    def test__set_valid_users_users_there(self):"},{"line_number":623,"context_line":"        self._helper._ssh_exec \u003d mock.Mock()"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        self._helper._set_valid_users(\u0027fake-server\u0027, [\u0027joost\u0027], \u0027fake-share\u0027,"},{"line_number":626,"context_line":"                                      \u0027ro\u0027)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        self._helper._ssh_exec.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_1c15df9a","line":625,"range":{"start_line":625,"start_character":53,"end_line":625,"end_character":62},"updated":"2016-09-08 07:10:01.000000000","message":"suggest also testing the case that there\u0027re multiple users.","commit_id":"6cdcda375c0e0043981ef604bd4ca8a6b09e5ec0"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c456d9d03c4b2cd7f42fd0e6a570404f9ae39050","unresolved":false,"context_lines":[{"line_number":622,"context_line":"    def test__set_valid_users_users_there(self):"},{"line_number":623,"context_line":"        self._helper._ssh_exec \u003d mock.Mock()"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        self._helper._set_valid_users(\u0027fake-server\u0027, [\u0027joost\u0027], \u0027fake-share\u0027,"},{"line_number":626,"context_line":"                                      \u0027ro\u0027)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        self._helper._ssh_exec.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_6231e159","line":625,"range":{"start_line":625,"start_character":53,"end_line":625,"end_character":62},"in_reply_to":"9a89bdaa_1c15df9a","updated":"2016-09-08 09:25:07.000000000","message":"Yes, this is a great idea, but let me point out that it is not exactly the part which causes problems. Or which could cause problems since it will fail with many users only if there were a bug in python standard library implementation.","commit_id":"6cdcda375c0e0043981ef604bd4ca8a6b09e5ec0"}]}