)]}'
{"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled True"},{"line_number":212,"context_line":"    iniset $TEMPEST_CONFIG share create_networks_when_multitenancy_enabled False"},{"line_number":213,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":214,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":215,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":216,"context_line":"    RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":217,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"}],"source_content_type":"text/x-sh","patch_set":19,"id":"7a8ec9b2_90edef27","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":41},"updated":"2016-09-20 10:21:40.000000000","message":"You also may want to apply code from line 151 here:\n\n\"\"\"\nMANILA_TESTS\u003d\"(^manila_tempest_tests.tests.api)(?\u003d.*\\[.*\\bbackend\\b.*\\])\"\n\"\"\"\nFilter for running only backend-related tempest tests.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    iniset $TEMPEST_CONFIG share multitenancy_enabled True"},{"line_number":212,"context_line":"    iniset $TEMPEST_CONFIG share create_networks_when_multitenancy_enabled False"},{"line_number":213,"context_line":"    iniset $TEMPEST_CONFIG share multi_backend True"},{"line_number":214,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":215,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":216,"context_line":"    RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":217,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"}],"source_content_type":"text/x-sh","patch_set":19,"id":"7a8ec9b2_261a2118","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":41},"in_reply_to":"7a8ec9b2_90edef27","updated":"2016-09-20 11:11:19.000000000","message":"Done, however this looks somewhat unrelated.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"}],"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    echo \"MANILA_ZFSONLINUX_USE_SSH\u003dTrue\" \u003e\u003e $localrc_path"},{"line_number":146,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":147,"context_line":"    echo \"SHARE_DRIVER\u003dmanila.share.drivers.container.driver.ContainerShareDriver\" \u003e\u003e $localrc_path"},{"line_number":148,"context_line":"    echo \"SHARE_BACKING_FILE_SIZE\u003d64000M\" \u003e\u003e $localrc_path"},{"line_number":149,"context_line":"    echo \"MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS\u003d\u0027snapshot_support\u003dfalse\u0027\" \u003e\u003e $localrc_path"},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"7a8ec9b2_707303b5","line":148,"range":{"start_line":148,"start_character":34,"end_line":148,"end_character":36},"updated":"2016-09-20 10:21:40.000000000","message":"It is likely that CI VM will not have such capacity.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    echo \"MANILA_ZFSONLINUX_USE_SSH\u003dTrue\" \u003e\u003e $localrc_path"},{"line_number":146,"context_line":"elif [[ \"$DRIVER\" \u003d\u003d \"container\" ]]; then"},{"line_number":147,"context_line":"    echo \"SHARE_DRIVER\u003dmanila.share.drivers.container.driver.ContainerShareDriver\" \u003e\u003e $localrc_path"},{"line_number":148,"context_line":"    echo \"SHARE_BACKING_FILE_SIZE\u003d64000M\" \u003e\u003e $localrc_path"},{"line_number":149,"context_line":"    echo \"MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS\u003d\u0027snapshot_support\u003dfalse\u0027\" \u003e\u003e $localrc_path"},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"7a8ec9b2_46c1ed2d","line":148,"range":{"start_line":148,"start_character":34,"end_line":148,"end_character":36},"in_reply_to":"7a8ec9b2_707303b5","updated":"2016-09-20 11:11:19.000000000","message":"Well, since the tests pass on the gate I tend to believe that it has such capacity.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"}],"manila/share/drivers/container/driver.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c274d8a6dc28500723a0a862329652b75660107d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            server_id,"},{"line_number":145,"context_line":"            [\"umount\", \"/shares/%s\" % share.share_id]"},{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":"        # (aovchinnikov): bug 1621784 manifests itself here as well as in"},{"line_number":148,"context_line":"        # storage helper."},{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            self.container.execute("}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_3198011c","line":147,"range":{"start_line":147,"start_character":26,"end_line":147,"end_character":37},"updated":"2016-09-18 02:24:40.000000000","message":"Why add bug 1621784 in bug 1613676 patch?","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            server_id,"},{"line_number":145,"context_line":"            [\"umount\", \"/shares/%s\" % share.share_id]"},{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":"        # (aovchinnikov): bug 1621784 manifests itself here as well as in"},{"line_number":148,"context_line":"        # storage helper."},{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            self.container.execute("}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_ff6e46fe","line":147,"range":{"start_line":147,"start_character":26,"end_line":147,"end_character":37},"in_reply_to":"7a8ec9b2_3198011c","updated":"2016-09-19 10:30:11.000000000","message":"Because apparently it affects this method. I am not fixing that bug in this change, but in order not to forget to fix things I am leaving a memo. When that bug is fixed the try block won\u0027t be needed here.","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"db81e63beae3ece19f145605ee6bc960c575baae","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                server_id,"},{"line_number":152,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":153,"context_line":"            )"},{"line_number":154,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":155,"context_line":"            LOG.warning(_LW(\"Failed to umount %(share)s in \""},{"line_number":156,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":157,"context_line":"                                                     \"cont\": server_id})"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_d4cc2b8b","line":154,"updated":"2016-09-18 02:47:09.000000000","message":"can you add a comment here explaining why ignore this exception?","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                server_id,"},{"line_number":152,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":153,"context_line":"            )"},{"line_number":154,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":155,"context_line":"            LOG.warning(_LW(\"Failed to umount %(share)s in \""},{"line_number":156,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":157,"context_line":"                                                     \"cont\": server_id})"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_1f613205","line":154,"in_reply_to":"7a8ec9b2_d4cc2b8b","updated":"2016-09-19 10:30:11.000000000","message":"Ok.","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c274d8a6dc28500723a0a862329652b75660107d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":153,"context_line":"            )"},{"line_number":154,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":155,"context_line":"            LOG.warning(_LW(\"Failed to umount %(share)s in \""},{"line_number":156,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":157,"context_line":"                                                     \"cont\": server_id})"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_747b577b","line":155,"range":{"start_line":155,"start_character":12,"end_line":155,"end_character":60},"updated":"2016-09-18 02:24:40.000000000","message":"Please add unit test, thanks.","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c274d8a6dc28500723a0a862329652b75660107d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":153,"context_line":"            )"},{"line_number":154,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":155,"context_line":"            LOG.warning(_LW(\"Failed to umount %(share)s in \""},{"line_number":156,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":157,"context_line":"                                                     \"cont\": server_id})"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_313481fa","line":155,"range":{"start_line":155,"start_character":38,"end_line":155,"end_character":46},"updated":"2016-09-18 02:24:40.000000000","message":"umount or delete(rm)? because we run umount command in code line 144?","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":153,"context_line":"            )"},{"line_number":154,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":155,"context_line":"            LOG.warning(_LW(\"Failed to umount %(share)s in \""},{"line_number":156,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":157,"context_line":"                                                     \"cont\": server_id})"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_7f007602","line":155,"range":{"start_line":155,"start_character":38,"end_line":155,"end_character":46},"in_reply_to":"7a8ec9b2_313481fa","updated":"2016-09-19 10:30:11.000000000","message":"Yes, rm auxiliary folder, thank you.","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":153,"context_line":"            )"},{"line_number":154,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":155,"context_line":"            LOG.warning(_LW(\"Failed to umount %(share)s in \""},{"line_number":156,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":157,"context_line":"                                                     \"cont\": server_id})"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_e2078915","line":155,"range":{"start_line":155,"start_character":12,"end_line":155,"end_character":60},"in_reply_to":"7a8ec9b2_747b577b","updated":"2016-09-19 10:30:11.000000000","message":"Ok.","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"db81e63beae3ece19f145605ee6bc960c575baae","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                    self._execute(\"ovs-vsctl\", \"--\", \"del-port\","},{"line_number":273,"context_line":"                                  self.configuration.container_ovs_bridge_name,"},{"line_number":274,"context_line":"                                  veth, run_as_root\u003dTrue)"},{"line_number":275,"context_line":"                except exception.ProcessExecutionError:"},{"line_number":276,"context_line":"                    continue"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def _get_veth_state(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_34a46fb8","line":275,"updated":"2016-09-18 02:47:09.000000000","message":"add a warning log here?","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                    self._execute(\"ovs-vsctl\", \"--\", \"del-port\","},{"line_number":273,"context_line":"                                  self.configuration.container_ovs_bridge_name,"},{"line_number":274,"context_line":"                                  veth, run_as_root\u003dTrue)"},{"line_number":275,"context_line":"                except exception.ProcessExecutionError:"},{"line_number":276,"context_line":"                    continue"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def _get_veth_state(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_0259d534","line":275,"in_reply_to":"7a8ec9b2_34a46fb8","updated":"2016-09-19 10:30:11.000000000","message":"Ok, sounds like a good idea.","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                server_id,"},{"line_number":155,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":156,"context_line":"            )"},{"line_number":157,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":158,"context_line":"            LOG.warning(_LW(\"Failed to remove /shares/%(share)s directory in \""},{"line_number":159,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":160,"context_line":"                                                     \"cont\": server_id})"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.storage.remove_storage(share)"},{"line_number":163,"context_line":"        LOG.debug(\"Deletion of share %s is completed!\", share.share_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_d013f70b","line":160,"range":{"start_line":157,"start_character":8,"end_line":160,"end_character":72},"updated":"2016-09-20 10:21:40.000000000","message":"Need to add traceback to warning message.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                server_id,"},{"line_number":155,"context_line":"                [\"rm\", \"-fR\", \"/shares/%s\" % share.share_id]"},{"line_number":156,"context_line":"            )"},{"line_number":157,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":158,"context_line":"            LOG.warning(_LW(\"Failed to remove /shares/%(share)s directory in \""},{"line_number":159,"context_line":"                            \"container %(cont)s.\"), {\"share\": share.share_id,"},{"line_number":160,"context_line":"                                                     \"cont\": server_id})"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.storage.remove_storage(share)"},{"line_number":163,"context_line":"        LOG.debug(\"Deletion of share %s is completed!\", share.share_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_c6d5fdb9","line":160,"range":{"start_line":157,"start_character":8,"end_line":160,"end_character":72},"in_reply_to":"7a8ec9b2_d013f70b","updated":"2016-09-20 11:11:19.000000000","message":"It is not really helpful unless one plans to debug lvm jamming issue. Even then it is not really helpful. I\u0027ll add it in the next ps, but in the worst case it will produce lots of clutter in logs without making what\u0027s going on any clearer.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    self._execute(\"ovs-vsctl\", \"--\", \"del-port\","},{"line_number":276,"context_line":"                                  self.configuration.container_ovs_bridge_name,"},{"line_number":277,"context_line":"                                  veth, run_as_root\u003dTrue)"},{"line_number":278,"context_line":"                except exception.ProcessExecutionError:"},{"line_number":279,"context_line":"                    LOG.warning(_LW(\"Failed to delete port %s: port \""},{"line_number":280,"context_line":"                                    \"vanished.\"), veth)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _get_veth_state(self):"},{"line_number":283,"context_line":"        result \u003d self._execute(\"brctl\", \"show\","}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_5000c7aa","line":280,"range":{"start_line":278,"start_character":16,"end_line":280,"end_character":55},"updated":"2016-09-20 10:21:40.000000000","message":"ditto","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    self._execute(\"ovs-vsctl\", \"--\", \"del-port\","},{"line_number":276,"context_line":"                                  self.configuration.container_ovs_bridge_name,"},{"line_number":277,"context_line":"                                  veth, run_as_root\u003dTrue)"},{"line_number":278,"context_line":"                except exception.ProcessExecutionError:"},{"line_number":279,"context_line":"                    LOG.warning(_LW(\"Failed to delete port %s: port \""},{"line_number":280,"context_line":"                                    \"vanished.\"), veth)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _get_veth_state(self):"},{"line_number":283,"context_line":"        result \u003d self._execute(\"brctl\", \"show\","}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_065b6555","line":280,"range":{"start_line":278,"start_character":16,"end_line":280,"end_character":55},"in_reply_to":"7a8ec9b2_5000c7aa","updated":"2016-09-20 11:11:19.000000000","message":"Done","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7ea7147f9b10d39b17cc761072c02ace46c52c89","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"},{"line_number":133,"context_line":"        return location"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @utils.synchronized(\u0027container_driver_delete_share_lock\u0027)"},{"line_number":136,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":137,"context_line":"        LOG.debug(\"Deleting share %(share)s on server \u0027%(server)s\u0027.\" %"},{"line_number":138,"context_line":"                  {\"server\": share_server[\"id\"],"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_05ffbf67","line":135,"range":{"start_line":135,"start_character":24,"end_line":135,"end_character":61},"updated":"2016-09-23 13:25:08.000000000","message":"Why do you use lock among all shares?","commit_id":"0bf0706c3ed890648107a4cd042de6c41bf1ad64"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7e091bb6a6f2969670abd1b06a0ddf55d2289236","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"},{"line_number":133,"context_line":"        return location"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @utils.synchronized(\u0027container_driver_delete_share_lock\u0027)"},{"line_number":136,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":137,"context_line":"        LOG.debug(\"Deleting share %(share)s on server \u0027%(server)s\u0027.\" %"},{"line_number":138,"context_line":"                  {\"server\": share_server[\"id\"],"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_b1328c0e","line":135,"range":{"start_line":135,"start_character":24,"end_line":135,"end_character":61},"in_reply_to":"5a8bc5a2_05ffbf67","updated":"2016-09-26 11:04:23.000000000","message":"So, either this lock should be \"external\u003dTrue\" or be single-share related.","commit_id":"0bf0706c3ed890648107a4cd042de6c41bf1ad64"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"aa555ec1c1ff78f514fb2fb2b4909df1e12cd7a6","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"},{"line_number":133,"context_line":"        return location"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @utils.synchronized(\u0027container_driver_delete_share_lock\u0027)"},{"line_number":136,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":137,"context_line":"        LOG.debug(\"Deleting share %(share)s on server \u0027%(server)s\u0027.\" %"},{"line_number":138,"context_line":"                  {\"server\": share_server[\"id\"],"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_f496c23c","line":135,"range":{"start_line":135,"start_character":24,"end_line":135,"end_character":61},"in_reply_to":"5a8bc5a2_b1328c0e","updated":"2016-09-26 11:19:54.000000000","message":"Got your point, thank you.","commit_id":"0bf0706c3ed890648107a4cd042de6c41bf1ad64"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"82071f85bbff49305579c278a03939211303d851","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        location \u003d self._get_helper(share).create_share(server_id)"},{"line_number":133,"context_line":"        return location"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @utils.synchronized(\u0027container_driver_delete_share_lock\u0027, external\u003dTrue)"},{"line_number":136,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":137,"context_line":"        LOG.debug(\"Deleting share %(share)s on server \u0027%(server)s\u0027.\" %"},{"line_number":138,"context_line":"                  {\"server\": share_server[\"id\"],"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a8bc5a2_fa14e44d","line":135,"range":{"start_line":135,"start_character":25,"end_line":135,"end_character":59},"updated":"2016-09-26 13:14:27.000000000","message":"this","commit_id":"67a22037c5ddcff636ec4c744c6843d98d5c0432"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"82071f85bbff49305579c278a03939211303d851","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        LOG.debug(\"Now container %(id)s should be accessible from network \""},{"line_number":256,"context_line":"                  \"%(subnet)s by address %(ip)s.\" % msg_helper)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @utils.synchronized(\"container-driver-teardown-lock\", external\u003dTrue)"},{"line_number":259,"context_line":"    def _teardown_server(self, *args, **kwargs):"},{"line_number":260,"context_line":"        server_id \u003d self._get_container_name(kwargs[\"server_details\"][\"id\"])"},{"line_number":261,"context_line":"        self.container.stop_container(server_id)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a8bc5a2_3a0bac2b","line":258,"range":{"start_line":258,"start_character":25,"end_line":258,"end_character":55},"updated":"2016-09-26 13:14:27.000000000","message":"and this locks have inconsistent naming.","commit_id":"67a22037c5ddcff636ec4c744c6843d98d5c0432"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"c11f097ac2d6b5c589615b891e73f7cede8cbe49","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        LOG.debug(\"Now container %(id)s should be accessible from network \""},{"line_number":256,"context_line":"                  \"%(subnet)s by address %(ip)s.\" % msg_helper)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @utils.synchronized(\"container-driver-teardown-lock\", external\u003dTrue)"},{"line_number":259,"context_line":"    def _teardown_server(self, *args, **kwargs):"},{"line_number":260,"context_line":"        server_id \u003d self._get_container_name(kwargs[\"server_details\"][\"id\"])"},{"line_number":261,"context_line":"        self.container.stop_container(server_id)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a8bc5a2_3d4ac626","line":258,"range":{"start_line":258,"start_character":25,"end_line":258,"end_character":55},"in_reply_to":"5a8bc5a2_3a0bac2b","updated":"2016-09-26 13:17:09.000000000","message":"That\u0027s so true.","commit_id":"67a22037c5ddcff636ec4c744c6843d98d5c0432"}],"manila/share/drivers/container/storage_helper.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c274d8a6dc28500723a0a862329652b75660107d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            self._execute(\"umount\", to_remove, run_as_root\u003dTrue)"},{"line_number":89,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":90,"context_line":"            LOG.warning(_LW(\"Failed to umount helper directory %s.\"),"},{"line_number":91,"context_line":"                        to_remove)"},{"line_number":92,"context_line":"        # (aovchinnikov): bug 1621784 manifests itself in jamming logical"},{"line_number":93,"context_line":"        # volumes, so try removing once and issue warning until it is fixed."},{"line_number":94,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_b4995fc6","line":91,"range":{"start_line":90,"start_character":11,"end_line":91,"end_character":34},"updated":"2016-09-18 02:24:40.000000000","message":"Please add unit test, thanks.","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            self._execute(\"umount\", to_remove, run_as_root\u003dTrue)"},{"line_number":89,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":90,"context_line":"            LOG.warning(_LW(\"Failed to umount helper directory %s.\"),"},{"line_number":91,"context_line":"                        to_remove)"},{"line_number":92,"context_line":"        # (aovchinnikov): bug 1621784 manifests itself in jamming logical"},{"line_number":93,"context_line":"        # volumes, so try removing once and issue warning until it is fixed."},{"line_number":94,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_423f5db3","line":91,"range":{"start_line":90,"start_character":11,"end_line":91,"end_character":34},"in_reply_to":"7a8ec9b2_b4995fc6","updated":"2016-09-19 10:30:11.000000000","message":"Done","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"db81e63beae3ece19f145605ee6bc960c575baae","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self._execute(\"lvremove\", \"-f\", \"--autobackup\", \"n\","},{"line_number":96,"context_line":"                          to_remove, run_as_root\u003dTrue)"},{"line_number":97,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":98,"context_line":"            LOG.warning(_LW(\"Failed to remove logical volume %s.\") % to_remove)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":101,"context_line":"        lv_device \u003d self._get_lv_device(share)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_748197fa","line":98,"range":{"start_line":98,"start_character":67,"end_line":98,"end_character":68},"updated":"2016-09-18 02:47:09.000000000","message":",","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c274d8a6dc28500723a0a862329652b75660107d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self._execute(\"lvremove\", \"-f\", \"--autobackup\", \"n\","},{"line_number":96,"context_line":"                          to_remove, run_as_root\u003dTrue)"},{"line_number":97,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":98,"context_line":"            LOG.warning(_LW(\"Failed to remove logical volume %s.\") % to_remove)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":101,"context_line":"        lv_device \u003d self._get_lv_device(share)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_d4942b8c","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":79},"updated":"2016-09-18 02:24:40.000000000","message":"above","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self._execute(\"lvremove\", \"-f\", \"--autobackup\", \"n\","},{"line_number":96,"context_line":"                          to_remove, run_as_root\u003dTrue)"},{"line_number":97,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":98,"context_line":"            LOG.warning(_LW(\"Failed to remove logical volume %s.\") % to_remove)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":101,"context_line":"        lv_device \u003d self._get_lv_device(share)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_c279ad94","line":98,"range":{"start_line":98,"start_character":67,"end_line":98,"end_character":68},"in_reply_to":"7a8ec9b2_748197fa","updated":"2016-09-19 10:30:11.000000000","message":"Done","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"7d0d34af6b24ba3907a4e3274184452851d126d7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self._execute(\"lvremove\", \"-f\", \"--autobackup\", \"n\","},{"line_number":96,"context_line":"                          to_remove, run_as_root\u003dTrue)"},{"line_number":97,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":98,"context_line":"            LOG.warning(_LW(\"Failed to remove logical volume %s.\") % to_remove)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":101,"context_line":"        lv_device \u003d self._get_lv_device(share)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_8245e543","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":79},"in_reply_to":"7a8ec9b2_d4942b8c","updated":"2016-09-19 10:30:11.000000000","message":"Done","commit_id":"d8ef710b52d57d318b485180c07d310b15af2f89"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"66542bf67c76c4af89dc0dd36d9ed32d1f0be89e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._execute(\"mkfs.ext4\", self._get_lv_device(share),"},{"line_number":82,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @utils.synchronized(\u0027container_driver_remove_storage_lock\u0027)"},{"line_number":85,"context_line":"    def remove_storage(self, share):"},{"line_number":86,"context_line":"        to_remove \u003d self._get_lv_device(share)"},{"line_number":87,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_199e9c07","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":63},"updated":"2016-09-20 09:37:15.000000000","message":"Do we need this lock given that (I think) this method is only called once from within delete_share() and that whole method is protected by a synchronization lock?","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._execute(\"mkfs.ext4\", self._get_lv_device(share),"},{"line_number":82,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @utils.synchronized(\u0027container_driver_remove_storage_lock\u0027)"},{"line_number":85,"context_line":"    def remove_storage(self, share):"},{"line_number":86,"context_line":"        to_remove \u003d self._get_lv_device(share)"},{"line_number":87,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_f0cd5387","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":63},"in_reply_to":"7a8ec9b2_199e9c07","updated":"2016-09-20 10:21:40.000000000","message":"+1","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._execute(\"mkfs.ext4\", self._get_lv_device(share),"},{"line_number":82,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @utils.synchronized(\u0027container_driver_remove_storage_lock\u0027)"},{"line_number":85,"context_line":"    def remove_storage(self, share):"},{"line_number":86,"context_line":"        to_remove \u003d self._get_lv_device(share)"},{"line_number":87,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_861cd578","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":63},"in_reply_to":"7a8ec9b2_199e9c07","updated":"2016-09-20 11:11:19.000000000","message":"You are right, this looks redundant. I\u0027ll remove it.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            self._execute(\"umount\", to_remove, run_as_root\u003dTrue)"},{"line_number":89,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":90,"context_line":"            LOG.warning(_LW(\"Failed to umount helper directory %s.\"),"},{"line_number":91,"context_line":"                        to_remove)"},{"line_number":92,"context_line":"        # (aovchinnikov): bug 1621784 manifests itself in jamming logical"},{"line_number":93,"context_line":"        # volumes, so try removing once and issue warning until it is fixed."},{"line_number":94,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_5073674d","line":91,"range":{"start_line":90,"start_character":12,"end_line":91,"end_character":34},"updated":"2016-09-20 10:21:40.000000000","message":"The same as in https://review.openstack.org/#/c/366740/19/manila/share/drivers/container/driver.py\nNee to add traceback to message.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            self._execute(\"umount\", to_remove, run_as_root\u003dTrue)"},{"line_number":89,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":90,"context_line":"            LOG.warning(_LW(\"Failed to umount helper directory %s.\"),"},{"line_number":91,"context_line":"                        to_remove)"},{"line_number":92,"context_line":"        # (aovchinnikov): bug 1621784 manifests itself in jamming logical"},{"line_number":93,"context_line":"        # volumes, so try removing once and issue warning until it is fixed."},{"line_number":94,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_e60bd929","line":91,"range":{"start_line":90,"start_character":12,"end_line":91,"end_character":34},"in_reply_to":"7a8ec9b2_5073674d","updated":"2016-09-20 11:11:19.000000000","message":"Done","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            self._execute(\"lvremove\", \"-f\", \"--autobackup\", \"n\","},{"line_number":96,"context_line":"                          to_remove, run_as_root\u003dTrue)"},{"line_number":97,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":98,"context_line":"            LOG.warning(_LW(\"Failed to remove logical volume %s.\") % to_remove)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":101,"context_line":"        lv_device \u003d self._get_lv_device(share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_50aa8771","line":98,"range":{"start_line":97,"start_character":8,"end_line":98,"end_character":79},"updated":"2016-09-20 10:21:40.000000000","message":"ditto","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            self._execute(\"lvremove\", \"-f\", \"--autobackup\", \"n\","},{"line_number":96,"context_line":"                          to_remove, run_as_root\u003dTrue)"},{"line_number":97,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":98,"context_line":"            LOG.warning(_LW(\"Failed to remove logical volume %s.\") % to_remove)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":101,"context_line":"        lv_device \u003d self._get_lv_device(share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_4603ad0f","line":98,"range":{"start_line":97,"start_character":8,"end_line":98,"end_character":79},"in_reply_to":"7a8ec9b2_50aa8771","updated":"2016-09-20 11:11:19.000000000","message":"Done","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"}],"manila/tests/share/drivers/container/test_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"},{"line_number":142,"context_line":"        self._driver.container.execute \u003d fake_execute"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_501d27bc","line":139,"range":{"start_line":139,"start_character":7,"end_line":139,"end_character":40},"updated":"2016-09-20 10:21:40.000000000","message":"You mock in permanently here. It is completely unacceptable to do this.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1d7daf8853a89120bb6172241407590a0828a58c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"},{"line_number":142,"context_line":"        self._driver.container.execute \u003d fake_execute"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_964b2459","line":139,"range":{"start_line":139,"start_character":7,"end_line":139,"end_character":40},"in_reply_to":"7a8ec9b2_016fcf92","updated":"2016-09-20 11:25:23.000000000","message":"Permanent mock on \"shared\" object causes unexpected races. Such mock is acceptable only on local thing. For example, if you replace line 147 here with \"driver.LOG.warning.assert_called_once_with(mock.ANY)\" and do the same in other places, you will get failures.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"},{"line_number":142,"context_line":"        self._driver.container.execute \u003d fake_execute"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_016fcf92","line":139,"range":{"start_line":139,"start_character":7,"end_line":139,"end_character":40},"in_reply_to":"7a8ec9b2_501d27bc","updated":"2016-09-20 11:11:19.000000000","message":"Yes, but this is a logger, ins\u0027t it? There is no problem in unshadowing it back, and I\u0027ll do that in the next ps, but I fail to see why it is completely unacceptable in this particular case.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"092be1d532b2a077bc92e1247d134871a80640fa","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"},{"line_number":142,"context_line":"        self._driver.container.execute \u003d fake_execute"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_56b0bc8b","line":139,"range":{"start_line":139,"start_character":7,"end_line":139,"end_character":40},"in_reply_to":"7a8ec9b2_964b2459","updated":"2016-09-20 11:36:51.000000000","message":"Now this makes perfect sense. Thank you!","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                return 0"},{"line_number":264,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":265,"context_line":"        self._driver._execute \u003d fake_ovs_execute"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self._driver._teardown_server("}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_10239f06","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":40},"updated":"2016-09-20 10:21:40.000000000","message":"You mock in permanently here. It is completely unacceptable to do this.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                return 0"},{"line_number":264,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":265,"context_line":"        self._driver._execute \u003d fake_ovs_execute"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self._driver._teardown_server("}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_c1eb27af","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":40},"in_reply_to":"7a8ec9b2_10239f06","updated":"2016-09-20 11:11:19.000000000","message":"ditto","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a012d4652c99e8d2f719c76dcdb876615be8901e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        setattr(self._driver.configuration.local_conf,"},{"line_number":209,"context_line":"                \u0027network_api_class\u0027,"},{"line_number":210,"context_line":"                \u0027manila.share.drivers.container.driver.ContainerShareDriver\u0027)"},{"line_number":211,"context_line":"        warning_backup \u003d driver.LOG.warning"},{"line_number":212,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        self._driver.check_for_setup_error()"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_f928db87","line":211,"updated":"2016-09-20 11:40:18.000000000","message":"perhaps \u0027with mock.patch\u0027 statement could be leveraged here.","commit_id":"e260144e9baf2423fd8196e65415655961a7c684"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"96205a8022850d76584fd34aa3d5d8656680ea76","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        setattr(self._driver.configuration.local_conf,"},{"line_number":209,"context_line":"                \u0027network_api_class\u0027,"},{"line_number":210,"context_line":"                \u0027manila.share.drivers.container.driver.ContainerShareDriver\u0027)"},{"line_number":211,"context_line":"        warning_backup \u003d driver.LOG.warning"},{"line_number":212,"context_line":"        driver.LOG.warning \u003d mock.Mock()"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        self._driver.check_for_setup_error()"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a8ec9b2_df8e9f26","line":211,"in_reply_to":"7a8ec9b2_f928db87","updated":"2016-09-20 12:16:59.000000000","message":"Yes, but that is less fun.","commit_id":"e260144e9baf2423fd8196e65415655961a7c684"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b30f4fd679d2b8c4bdd2796def6c61a543e6d0f9","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def test_delete_share_rm_fails(self):"},{"line_number":135,"context_line":"        def fake_execute(*args):"},{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_85d84481","line":137,"range":{"start_line":137,"start_character":22,"end_line":137,"end_character":55},"updated":"2016-09-20 12:41:33.000000000","message":"You can remove lines 135-137","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8dfe2d0edea16f4ba20d4e27bff54dde3dd43889","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def test_delete_share_rm_fails(self):"},{"line_number":135,"context_line":"        def fake_execute(*args):"},{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_20859b58","line":137,"range":{"start_line":137,"start_character":22,"end_line":137,"end_character":55},"in_reply_to":"7a8ec9b2_85d84481","updated":"2016-09-20 14:38:46.000000000","message":"I have huge plans on those lines, so I\u0027ll probably keep them around.","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b30f4fd679d2b8c4bdd2796def6c61a543e6d0f9","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        def fake_execute(*args):"},{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_856da49b","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":28},"updated":"2016-09-20 12:41:33.000000000","message":"It is redundant to define it only for single call.\nSo, either make assertion on it or use inline definition.","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8dfe2d0edea16f4ba20d4e27bff54dde3dd43889","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        def fake_execute(*args):"},{"line_number":136,"context_line":"            if \u0027rm\u0027 in args[1]:"},{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        helper \u003d mock.Mock()"},{"line_number":139,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_a0352bdc","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":28},"in_reply_to":"7a8ec9b2_856da49b","updated":"2016-09-20 14:38:46.000000000","message":"Done","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b30f4fd679d2b8c4bdd2796def6c61a543e6d0f9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"},{"line_number":142,"context_line":"        self._driver.container.execute \u003d fake_execute"},{"line_number":143,"context_line":"        self.mock_object(self._driver.storage, \u0027remove_storage\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self._driver.delete_share(self._context, self.share, {\u0027id\u0027: \u0027fake\u0027})"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_45447c1a","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":53},"updated":"2016-09-20 12:41:33.000000000","message":"And do here following:\n\n\"\"\"\nself.mock_object(\n    self._driver.container, \u0027execute\u0027,\n    mock.Mock(side_effect\u003dexception.ProcessExecutionError(\u0027FAKE\u0027))\n)\n\"\"\"","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8dfe2d0edea16f4ba20d4e27bff54dde3dd43889","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":140,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":141,"context_line":"                         mock.Mock(return_value\u003dhelper))"},{"line_number":142,"context_line":"        self._driver.container.execute \u003d fake_execute"},{"line_number":143,"context_line":"        self.mock_object(self._driver.storage, \u0027remove_storage\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self._driver.delete_share(self._context, self.share, {\u0027id\u0027: \u0027fake\u0027})"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_9d07bc1c","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":53},"in_reply_to":"7a8ec9b2_45447c1a","updated":"2016-09-20 14:38:46.000000000","message":"Yes, right, except that it must do nothing first, then fail. So it must exhibit a side effect only when called with rm.","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b30f4fd679d2b8c4bdd2796def6c61a543e6d0f9","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        self.assertEqual(expected_arguments.sort(), actual_arguments.sort())"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def test__teardown_server_veth_disappeared_mysteriously(self):"},{"line_number":255,"context_line":"        def fake_ovs_execute(*args, **kwargs):"},{"line_number":256,"context_line":"            if len(args) \u003d\u003d 3:"},{"line_number":257,"context_line":"                return [\u0027veth0000000\u0027]"},{"line_number":258,"context_line":"            elif len(args) \u003d\u003d 4:"},{"line_number":259,"context_line":"                return (\u0027fake:manila_b5afb5c1_6011_43c4_8a37_29820e6951a7\u0027, \u0027\u0027)"},{"line_number":260,"context_line":"            if \u0027del-port\u0027 in args:"},{"line_number":261,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                return 0"},{"line_number":264,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":265,"context_line":"        self._driver._execute \u003d fake_ovs_execute"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_e52588ae","line":263,"range":{"start_line":255,"start_character":8,"end_line":263,"end_character":24},"updated":"2016-09-20 12:41:33.000000000","message":"All these conditions are redundant because you run only one case always. So, you need either to use ddt here that provides data for all condition cases or remove current dead code from this func.","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8dfe2d0edea16f4ba20d4e27bff54dde3dd43889","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        self.assertEqual(expected_arguments.sort(), actual_arguments.sort())"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def test__teardown_server_veth_disappeared_mysteriously(self):"},{"line_number":255,"context_line":"        def fake_ovs_execute(*args, **kwargs):"},{"line_number":256,"context_line":"            if len(args) \u003d\u003d 3:"},{"line_number":257,"context_line":"                return [\u0027veth0000000\u0027]"},{"line_number":258,"context_line":"            elif len(args) \u003d\u003d 4:"},{"line_number":259,"context_line":"                return (\u0027fake:manila_b5afb5c1_6011_43c4_8a37_29820e6951a7\u0027, \u0027\u0027)"},{"line_number":260,"context_line":"            if \u0027del-port\u0027 in args:"},{"line_number":261,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                return 0"},{"line_number":264,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":265,"context_line":"        self._driver._execute \u003d fake_ovs_execute"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_ccdb501a","line":263,"range":{"start_line":255,"start_character":8,"end_line":263,"end_character":24},"in_reply_to":"7a8ec9b2_e52588ae","updated":"2016-09-20 14:38:46.000000000","message":"It is not dead, it is just really really tired. Actually all these branches are used because I test the very last try...except block on _teardown_server and there must be some way to get there. I don\u0027t see how ddt could make this clearer, but I\u0027ll look into that.","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b30f4fd679d2b8c4bdd2796def6c61a543e6d0f9","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                return 0"},{"line_number":264,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":265,"context_line":"        self._driver._execute \u003d fake_ovs_execute"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self._driver._teardown_server("},{"line_number":268,"context_line":"            server_details\u003d{\"id\": \"b5afb5c1-6011-43c4-8a37-29820e6951a7\"})"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_e573c8b2","line":265,"range":{"start_line":265,"start_character":8,"end_line":265,"end_character":48},"updated":"2016-09-20 12:41:33.000000000","message":"Please, use mock here to be able to make assertion further.","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8dfe2d0edea16f4ba20d4e27bff54dde3dd43889","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                return 0"},{"line_number":264,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":265,"context_line":"        self._driver._execute \u003d fake_ovs_execute"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self._driver._teardown_server("},{"line_number":268,"context_line":"            server_details\u003d{\"id\": \"b5afb5c1-6011-43c4-8a37-29820e6951a7\"})"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_0c1298b4","line":265,"range":{"start_line":265,"start_character":8,"end_line":265,"end_character":48},"in_reply_to":"7a8ec9b2_e573c8b2","updated":"2016-09-20 14:38:46.000000000","message":"Ok, I see what you mean (if you mean that mock helps with cleanup).","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0db2a5bd50d637e3c7ec1ae03d7d090eff4a701a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":139,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":140,"context_line":"                         mock.Mock(return_value\u003dmock.Mock()))"},{"line_number":141,"context_line":"        self.mock_object(self._driver.container, \"execute\", fake_execute)"},{"line_number":142,"context_line":"        self.mock_object(self._driver.storage, \u0027remove_storage\u0027)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_65224303","line":140,"range":{"start_line":140,"start_character":25,"end_line":140,"end_character":60},"updated":"2016-09-23 13:25:55.000000000","message":"It is redundant.","commit_id":"0bf0706c3ed890648107a4cd042de6c41bf1ad64"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"aa555ec1c1ff78f514fb2fb2b4909df1e12cd7a6","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":138,"context_line":"        self.mock_object(driver.LOG, \"warning\")"},{"line_number":139,"context_line":"        self.mock_object(self._driver, \"_get_helper\","},{"line_number":140,"context_line":"                         mock.Mock(return_value\u003dmock.Mock()))"},{"line_number":141,"context_line":"        self.mock_object(self._driver.container, \"execute\", fake_execute)"},{"line_number":142,"context_line":"        self.mock_object(self._driver.storage, \u0027remove_storage\u0027)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_74ef12e9","line":140,"range":{"start_line":140,"start_character":25,"end_line":140,"end_character":60},"in_reply_to":"5a8bc5a2_65224303","updated":"2016-09-26 11:19:54.000000000","message":"Done","commit_id":"0bf0706c3ed890648107a4cd042de6c41bf1ad64"}],"manila/tests/share/drivers/container/test_storage_helper.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            if \u0027umount\u0027 in args:"},{"line_number":103,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        storage_helper.LOG.warning \u003d mock.Mock()"},{"line_number":106,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.LVMHelper.remove_storage(self.share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_b082ebc6","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":48},"updated":"2016-09-20 10:21:40.000000000","message":"You mock in permanently here. It is completely unacceptable to do this.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            if \u0027umount\u0027 in args:"},{"line_number":103,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        storage_helper.LOG.warning \u003d mock.Mock()"},{"line_number":106,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.LVMHelper.remove_storage(self.share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_61033377","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":48},"in_reply_to":"7a8ec9b2_b082ebc6","updated":"2016-09-20 11:11:19.000000000","message":"ditto","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff24292e23af4bebf891a230e1affa3130d4837a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            if \u0027lvremove\u0027 in args:"},{"line_number":115,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        storage_helper.LOG.warning \u003d mock.Mock()"},{"line_number":118,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.LVMHelper.remove_storage(self.share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_f06c7338","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":48},"updated":"2016-09-20 10:21:40.000000000","message":"You mock in permanently here. It is completely unacceptable to do this.","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"9b179c75577b77423777f8c798d378efd490f308","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            if \u0027lvremove\u0027 in args:"},{"line_number":115,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        storage_helper.LOG.warning \u003d mock.Mock()"},{"line_number":118,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.LVMHelper.remove_storage(self.share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_c102476f","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":48},"in_reply_to":"7a8ec9b2_f06c7338","updated":"2016-09-20 11:11:19.000000000","message":"ditto","commit_id":"a5223ef1acf6f5ad9b30f733292aee3b35d378cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b30f4fd679d2b8c4bdd2796def6c61a543e6d0f9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(expected_arguments, actual_arguments)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_remove_storage_umount_failed(self):"},{"line_number":101,"context_line":"        def fake_execute(*args, **kwargs):"},{"line_number":102,"context_line":"            if \u0027umount\u0027 in args:"},{"line_number":103,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.mock_object(storage_helper.LOG, \"warning\")"},{"line_number":106,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.LVMHelper.remove_storage(self.share)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_25269068","line":106,"range":{"start_line":101,"start_character":8,"end_line":106,"end_character":46},"updated":"2016-09-20 12:41:33.000000000","message":"Same as in https://review.openstack.org/#/c/366740/21/manila/tests/share/drivers/container/test_driver.py","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8dfe2d0edea16f4ba20d4e27bff54dde3dd43889","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(expected_arguments, actual_arguments)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_remove_storage_umount_failed(self):"},{"line_number":101,"context_line":"        def fake_execute(*args, **kwargs):"},{"line_number":102,"context_line":"            if \u0027umount\u0027 in args:"},{"line_number":103,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.mock_object(storage_helper.LOG, \"warning\")"},{"line_number":106,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        self.LVMHelper.remove_storage(self.share)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_6c86bcdc","line":106,"range":{"start_line":101,"start_character":8,"end_line":106,"end_character":46},"in_reply_to":"7a8ec9b2_25269068","updated":"2016-09-20 14:38:46.000000000","message":"ditto","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b30f4fd679d2b8c4bdd2796def6c61a543e6d0f9","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertTrue(storage_helper.LOG.warning.called)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_remove_storage_lvremove_failed(self):"},{"line_number":113,"context_line":"        def fake_execute(*args, **kwargs):"},{"line_number":114,"context_line":"            if \u0027lvremove\u0027 in args:"},{"line_number":115,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        self.mock_object(storage_helper.LOG, \"warning\")"},{"line_number":118,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.LVMHelper.remove_storage(self.share)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_6520984a","line":118,"range":{"start_line":113,"start_character":8,"end_line":118,"end_character":46},"updated":"2016-09-20 12:41:33.000000000","message":"ditto","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"8dfe2d0edea16f4ba20d4e27bff54dde3dd43889","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.assertTrue(storage_helper.LOG.warning.called)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_remove_storage_lvremove_failed(self):"},{"line_number":113,"context_line":"        def fake_execute(*args, **kwargs):"},{"line_number":114,"context_line":"            if \u0027lvremove\u0027 in args:"},{"line_number":115,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        self.mock_object(storage_helper.LOG, \"warning\")"},{"line_number":118,"context_line":"        self.LVMHelper._execute \u003d fake_execute"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.LVMHelper.remove_storage(self.share)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_ac68c422","line":118,"range":{"start_line":113,"start_character":8,"end_line":118,"end_character":46},"in_reply_to":"7a8ec9b2_6520984a","updated":"2016-09-20 14:38:46.000000000","message":"ditto","commit_id":"100d238965de749ca8f3f52a8966fec182ceffda"}]}
