)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"04b4448f787f4d0e0586ac78ba5212a03d4b1e8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"3PAR driver fails to validate conf share server IPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With 3PAR, share server(VFS) can have upto 4 IP addresses."},{"line_number":10,"context_line":"During bootup, driver querires 3PAR to get list of all IP addresses"},{"line_number":11,"context_line":"and validates it against IP addresses provided in manila.conf. If"},{"line_number":12,"context_line":"there is a mismatch, driver throws exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_b52f64a0","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":42},"updated":"2016-09-14 02:54:02.000000000","message":"up to","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a54b2b303ef9913eebd866ba8efde9d58abf613f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"3PAR driver fails to validate conf share server IPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With 3PAR, share server(VFS) can have upto 4 IP addresses."},{"line_number":10,"context_line":"During bootup, driver querires 3PAR to get list of all IP addresses"},{"line_number":11,"context_line":"and validates it against IP addresses provided in manila.conf. If"},{"line_number":12,"context_line":"there is a mismatch, driver throws exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_408467d3","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":42},"in_reply_to":"7a8ec9b2_b52f64a0","updated":"2016-09-14 18:09:51.000000000","message":"Done","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"04b4448f787f4d0e0586ac78ba5212a03d4b1e8a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"3PAR driver fails to validate conf share server IPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With 3PAR, share server(VFS) can have upto 4 IP addresses."},{"line_number":10,"context_line":"During bootup, driver querires 3PAR to get list of all IP addresses"},{"line_number":11,"context_line":"and validates it against IP addresses provided in manila.conf. If"},{"line_number":12,"context_line":"there is a mismatch, driver throws exception."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_35127463","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":30},"updated":"2016-09-14 02:54:02.000000000","message":"queries","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a54b2b303ef9913eebd866ba8efde9d58abf613f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"3PAR driver fails to validate conf share server IPs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With 3PAR, share server(VFS) can have upto 4 IP addresses."},{"line_number":10,"context_line":"During bootup, driver querires 3PAR to get list of all IP addresses"},{"line_number":11,"context_line":"and validates it against IP addresses provided in manila.conf. If"},{"line_number":12,"context_line":"there is a mismatch, driver throws exception."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_a069ab27","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":30},"in_reply_to":"7a8ec9b2_35127463","updated":"2016-09-14 18:09:51.000000000","message":"Done","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"}],"manila/share/drivers/hpe/hpe_3par_mediator.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"04b4448f787f4d0e0586ac78ba5212a03d4b1e8a","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        value \u003d result[\u0027members\u0027][0]"},{"line_number":1075,"context_line":"        if isinstance(value[\u0027vfsip\u0027], dict):"},{"line_number":1076,"context_line":"            # This is for 3parclient returning only one VFS entry"},{"line_number":1077,"context_line":"            msg \u003d _LW(\"3parclient version upto 4.2.1, is in use, returns only\""},{"line_number":1078,"context_line":"                      \" one VFS entry. This can cause driver to fail while \""},{"line_number":1079,"context_line":"                      \"validating configured share server IP address(es)\")"},{"line_number":1080,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_00a0d4f3","line":1077,"range":{"start_line":1077,"start_character":42,"end_line":1077,"end_character":46},"updated":"2016-09-14 02:54:02.000000000","message":"up to","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a54b2b303ef9913eebd866ba8efde9d58abf613f","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        value \u003d result[\u0027members\u0027][0]"},{"line_number":1075,"context_line":"        if isinstance(value[\u0027vfsip\u0027], dict):"},{"line_number":1076,"context_line":"            # This is for 3parclient returning only one VFS entry"},{"line_number":1077,"context_line":"            msg \u003d _LW(\"3parclient version upto 4.2.1, is in use, returns only\""},{"line_number":1078,"context_line":"                      \" one VFS entry. This can cause driver to fail while \""},{"line_number":1079,"context_line":"                      \"validating configured share server IP address(es)\")"},{"line_number":1080,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_00133fb9","line":1077,"range":{"start_line":1077,"start_character":42,"end_line":1077,"end_character":46},"in_reply_to":"7a8ec9b2_00a0d4f3","updated":"2016-09-14 18:09:51.000000000","message":"Done","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"04b4448f787f4d0e0586ac78ba5212a03d4b1e8a","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            LOG.warning(msg)"},{"line_number":1081,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1082,"context_line":"        else:"},{"line_number":1083,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1084,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1085,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1086,"context_line":"            discovered_vfs_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_c05fcc0c","line":1083,"range":{"start_line":1083,"start_character":37,"end_line":1083,"end_character":45},"updated":"2016-09-14 02:54:02.000000000","message":"returning","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"a54b2b303ef9913eebd866ba8efde9d58abf613f","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"            LOG.warning(msg)"},{"line_number":1081,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1082,"context_line":"        else:"},{"line_number":1083,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1084,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1085,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1086,"context_line":"            discovered_vfs_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_20167ba7","line":1083,"range":{"start_line":1083,"start_character":37,"end_line":1083,"end_character":45},"in_reply_to":"7a8ec9b2_c05fcc0c","updated":"2016-09-14 18:09:51.000000000","message":"Done","commit_id":"cb4cd97d1d445a002d2229ceeab3ffed2f3d55fc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"11ae35ddf7c247eab09593b3e774f5d27726e400","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"                    {\u0027share_ip\u0027: share_ip,"},{"line_number":1042,"context_line":"                     \u0027share_name\u0027: SUPER_SHARE})"},{"line_number":1043,"context_line":"        return path"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"    def get_vfs(self, fpg, vfs\u003dNone):"},{"line_number":1046,"context_line":"        \"\"\"Get the VFS or raise an exception.\"\"\""},{"line_number":1047,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_dc46227a","line":1044,"updated":"2016-09-19 05:41:40.000000000","message":"get_vfs_name() was removed. Trivial, but I don\u0027t think that belongs in this bug fix.","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"                    {\u0027share_ip\u0027: share_ip,"},{"line_number":1042,"context_line":"                     \u0027share_name\u0027: SUPER_SHARE})"},{"line_number":1043,"context_line":"        return path"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"    def get_vfs(self, fpg, vfs\u003dNone):"},{"line_number":1046,"context_line":"        \"\"\"Get the VFS or raise an exception.\"\"\""},{"line_number":1047,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_e9a67052","line":1044,"in_reply_to":"7a8ec9b2_dc46227a","updated":"2016-09-19 19:42:31.000000000","message":"Yes, trivial, and not related to bug. But did not want to put another patch just to remove this. Thanks.","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"11ae35ddf7c247eab09593b3e774f5d27726e400","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        value \u003d result[\u0027members\u0027][0]"},{"line_number":1075,"context_line":"        if isinstance(value[\u0027vfsip\u0027], dict):"},{"line_number":1076,"context_line":"            # This is for 3parclient returning only one VFS entry"},{"line_number":1077,"context_line":"            msg \u003d _LW(\"3parclient version up to 4.2.1, is in use, returning \""},{"line_number":1078,"context_line":"                      \"only one VFS entry. This can cause driver to fail \""},{"line_number":1079,"context_line":"                      \"while validating configured share server IP \""},{"line_number":1080,"context_line":"                      \"address(es)\")"},{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_aa456843","line":1080,"range":{"start_line":1077,"start_character":23,"end_line":1080,"end_character":35},"updated":"2016-09-19 05:41:40.000000000","message":"How about: 3parclient version up to 4.2.1 is in use. Client upgrade may be needed if using a VFS with multiple IP addresses.","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2030ca47bfd7af79d95fcc458b6a1aed42449b7b","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"        if isinstance(value[\u0027vfsip\u0027], dict):"},{"line_number":1076,"context_line":"            # This is for 3parclient returning only one VFS entry"},{"line_number":1077,"context_line":"            msg \u003d _LW(\"3parclient version up to 4.2.1, is in use, returning \""},{"line_number":1078,"context_line":"                      \"only one VFS entry. This can cause driver to fail \""},{"line_number":1079,"context_line":"                      \"while validating configured share server IP \""},{"line_number":1080,"context_line":"                      \"address(es)\")"},{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_c359e136","line":1080,"range":{"start_line":1078,"start_character":43,"end_line":1080,"end_character":36},"updated":"2016-09-17 18:31:48.000000000","message":"I don\u0027t understand... Where will the driver fail? You\u0027re casting the one address into a list on line 1081... So, why warn here?\n\nIf you will be failing elsewhere, why not fail here? What am i missing?","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        value \u003d result[\u0027members\u0027][0]"},{"line_number":1075,"context_line":"        if isinstance(value[\u0027vfsip\u0027], dict):"},{"line_number":1076,"context_line":"            # This is for 3parclient returning only one VFS entry"},{"line_number":1077,"context_line":"            msg \u003d _LW(\"3parclient version up to 4.2.1, is in use, returning \""},{"line_number":1078,"context_line":"                      \"only one VFS entry. This can cause driver to fail \""},{"line_number":1079,"context_line":"                      \"while validating configured share server IP \""},{"line_number":1080,"context_line":"                      \"address(es)\")"},{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_e95e7011","line":1080,"range":{"start_line":1077,"start_character":23,"end_line":1080,"end_character":35},"in_reply_to":"7a8ec9b2_aa456843","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"        if isinstance(value[\u0027vfsip\u0027], dict):"},{"line_number":1076,"context_line":"            # This is for 3parclient returning only one VFS entry"},{"line_number":1077,"context_line":"            msg \u003d _LW(\"3parclient version up to 4.2.1, is in use, returning \""},{"line_number":1078,"context_line":"                      \"only one VFS entry. This can cause driver to fail \""},{"line_number":1079,"context_line":"                      \"while validating configured share server IP \""},{"line_number":1080,"context_line":"                      \"address(es)\")"},{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_4998446b","line":1080,"range":{"start_line":1078,"start_character":43,"end_line":1080,"end_character":36},"in_reply_to":"7a8ec9b2_c359e136","updated":"2016-09-19 19:42:31.000000000","message":"There is a bug with 3parclient up to version 4.2.1 which does not return multiple IP addresses for a share server. The driver uses these IP addresses at boot up to validate against ones provided in manila.conf. The casting is done to uniform the format of one or all IP address(es) returned so driver can use it seamlessly.","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"11ae35ddf7c247eab09593b3e774f5d27726e400","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                      \"only one VFS entry. This can cause driver to fail \""},{"line_number":1079,"context_line":"                      \"while validating configured share server IP \""},{"line_number":1080,"context_line":"                      \"address(es)\")"},{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_97a1d3fa","line":1081,"range":{"start_line":1081,"start_character":16,"end_line":1081,"end_character":23},"updated":"2016-09-19 05:41:40.000000000","message":"If the string localization is blocking this bug fix, then I\u0027d suggest using debug log. The old client would have a documented known fixed bug. LW is overkill here anyway because at this point it might not even be a problem.","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                      \"only one VFS entry. This can cause driver to fail \""},{"line_number":1079,"context_line":"                      \"while validating configured share server IP \""},{"line_number":1080,"context_line":"                      \"address(es)\")"},{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_89716c7a","line":1081,"range":{"start_line":1081,"start_character":16,"end_line":1081,"end_character":23},"in_reply_to":"7a8ec9b2_97a1d3fa","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2030ca47bfd7af79d95fcc458b6a1aed42449b7b","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1085,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1086,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1087,"context_line":"            discovered_vfs_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_092e7ffa","line":1084,"range":{"start_line":1084,"start_character":37,"end_line":1084,"end_character":45},"updated":"2016-09-17 18:31:48.000000000","message":"returning","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"11ae35ddf7c247eab09593b3e774f5d27726e400","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1085,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1086,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1087,"context_line":"            discovered_vfs_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_3c81c68f","line":1084,"range":{"start_line":1084,"start_character":37,"end_line":1084,"end_character":45},"updated":"2016-09-19 05:41:40.000000000","message":"s/retuning/returning/","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1085,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1086,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1087,"context_line":"            discovered_vfs_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_695b402f","line":1084,"range":{"start_line":1084,"start_character":37,"end_line":1084,"end_character":45},"in_reply_to":"7a8ec9b2_092e7ffa","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            LOG.warning(msg)"},{"line_number":1082,"context_line":"            value[\u0027vfsip\u0027][\u0027address\u0027] \u003d [value[\u0027vfsip\u0027][\u0027address\u0027]]"},{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1085,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1086,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1087,"context_line":"            discovered_vfs_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_89408c37","line":1084,"range":{"start_line":1084,"start_character":37,"end_line":1084,"end_character":45},"in_reply_to":"7a8ec9b2_3c81c68f","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"11ae35ddf7c247eab09593b3e774f5d27726e400","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1085,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1086,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1087,"context_line":"            discovered_vfs_ips \u003d []"},{"line_number":1088,"context_line":"            for vfs_entry in value[\u0027vfsip\u0027]:"},{"line_number":1089,"context_line":"                if vfs_entry[\u0027address\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_fc0f5e34","line":1086,"range":{"start_line":1086,"start_character":12,"end_line":1086,"end_character":68},"updated":"2016-09-19 05:41:40.000000000","message":"I think you should delete this comment line.  It\u0027s \u0027if\u0027 that is backward-compat not the \u0027else\u0027.","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        else:"},{"line_number":1084,"context_line":"            # This is for 3parclient retuning list of VFS entries"},{"line_number":1085,"context_line":"            # Format get_vfs ret value to combine all IP addresses"},{"line_number":1086,"context_line":"            # allowing driver to be backwards compatible with client"},{"line_number":1087,"context_line":"            discovered_vfs_ips \u003d []"},{"line_number":1088,"context_line":"            for vfs_entry in value[\u0027vfsip\u0027]:"},{"line_number":1089,"context_line":"                if vfs_entry[\u0027address\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_a96468e5","line":1086,"range":{"start_line":1086,"start_character":12,"end_line":1086,"end_character":68},"in_reply_to":"7a8ec9b2_fc0f5e34","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"}],"manila/tests/share/drivers/hpe/test_hpe_3par_constants.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2030ca47bfd7af79d95fcc458b6a1aed42449b7b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"EXPECTED_CLIENT_GET_VFS_MEMBERS_MULTI \u003d {"},{"line_number":75,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":76,"context_line":"    \u0027vfsip\u0027: [{\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":77,"context_line":"               \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":78,"context_line":"               \u0027address\u0027: EXPECTED_IP_10203040,"},{"line_number":79,"context_line":"               \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":80,"context_line":"               \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":81,"context_line":"               \u0027vlanTag\u0027: EXPECTED_VLAN_TAG, },"},{"line_number":82,"context_line":"              {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":83,"context_line":"               \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":84,"context_line":"               \u0027address\u0027: EXPECTED_IP_10203041,"},{"line_number":85,"context_line":"               \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":86,"context_line":"               \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":87,"context_line":"               \u0027vlanTag\u0027: EXPECTED_VLAN_TAG, },"},{"line_number":88,"context_line":"              ],"},{"line_number":89,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":90,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_490b277d","line":87,"range":{"start_line":76,"start_character":14,"end_line":87,"end_character":46},"updated":"2016-09-17 18:31:48.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"EXPECTED_CLIENT_GET_VFS_MEMBERS_MULTI \u003d {"},{"line_number":75,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":76,"context_line":"    \u0027vfsip\u0027: [{\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":77,"context_line":"               \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":78,"context_line":"               \u0027address\u0027: EXPECTED_IP_10203040,"},{"line_number":79,"context_line":"               \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":80,"context_line":"               \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":81,"context_line":"               \u0027vlanTag\u0027: EXPECTED_VLAN_TAG, },"},{"line_number":82,"context_line":"              {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":83,"context_line":"               \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":84,"context_line":"               \u0027address\u0027: EXPECTED_IP_10203041,"},{"line_number":85,"context_line":"               \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":86,"context_line":"               \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":87,"context_line":"               \u0027vlanTag\u0027: EXPECTED_VLAN_TAG, },"},{"line_number":88,"context_line":"              ],"},{"line_number":89,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":90,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_f68f2fca","line":87,"range":{"start_line":76,"start_character":14,"end_line":87,"end_character":46},"in_reply_to":"7a8ec9b2_490b277d","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2030ca47bfd7af79d95fcc458b6a1aed42449b7b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    }"},{"line_number":91,"context_line":"EXPECTED_MEDIATOR_GET_VFS_RET_VAL_MULTI \u003d {"},{"line_number":92,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":93,"context_line":"    \u0027vfsip\u0027: {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":94,"context_line":"              \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":95,"context_line":"              \u0027address\u0027: [EXPECTED_IP_10203040, EXPECTED_IP_10203041],"},{"line_number":96,"context_line":"              \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":97,"context_line":"              \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":98,"context_line":"              \u0027vlanTag\u0027: EXPECTED_VLAN_TAG},"},{"line_number":99,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_29189bd2","line":98,"range":{"start_line":93,"start_character":13,"end_line":98,"end_character":44},"updated":"2016-09-17 18:31:48.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    }"},{"line_number":91,"context_line":"EXPECTED_MEDIATOR_GET_VFS_RET_VAL_MULTI \u003d {"},{"line_number":92,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":93,"context_line":"    \u0027vfsip\u0027: {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":94,"context_line":"              \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":95,"context_line":"              \u0027address\u0027: [EXPECTED_IP_10203040, EXPECTED_IP_10203041],"},{"line_number":96,"context_line":"              \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":97,"context_line":"              \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":98,"context_line":"              \u0027vlanTag\u0027: EXPECTED_VLAN_TAG},"},{"line_number":99,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_16bbbb76","line":98,"range":{"start_line":93,"start_character":13,"end_line":98,"end_character":44},"in_reply_to":"7a8ec9b2_29189bd2","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2030ca47bfd7af79d95fcc458b6a1aed42449b7b","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"EXPECTED_CLIENT_GET_VFS_MEMBERS \u003d {"},{"line_number":103,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":104,"context_line":"    \u0027vfsip\u0027: {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":105,"context_line":"              \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":106,"context_line":"              \u0027address\u0027: EXPECTED_IP_10203040,"},{"line_number":107,"context_line":"              \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":108,"context_line":"              \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":109,"context_line":"              \u0027vlanTag\u0027: EXPECTED_VLAN_TAG},"},{"line_number":110,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":"EXPECTED_MEDIATOR_GET_VFS_RET_VAL \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_09159f9a","line":109,"range":{"start_line":104,"start_character":13,"end_line":109,"end_character":44},"updated":"2016-09-17 18:31:48.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"EXPECTED_CLIENT_GET_VFS_MEMBERS \u003d {"},{"line_number":103,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":104,"context_line":"    \u0027vfsip\u0027: {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":105,"context_line":"              \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":106,"context_line":"              \u0027address\u0027: EXPECTED_IP_10203040,"},{"line_number":107,"context_line":"              \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":108,"context_line":"              \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":109,"context_line":"              \u0027vlanTag\u0027: EXPECTED_VLAN_TAG},"},{"line_number":110,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":"EXPECTED_MEDIATOR_GET_VFS_RET_VAL \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_56b5437c","line":109,"range":{"start_line":104,"start_character":13,"end_line":109,"end_character":44},"in_reply_to":"7a8ec9b2_09159f9a","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2030ca47bfd7af79d95fcc458b6a1aed42449b7b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":"EXPECTED_MEDIATOR_GET_VFS_RET_VAL \u003d {"},{"line_number":113,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":114,"context_line":"    \u0027vfsip\u0027: {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":115,"context_line":"              \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":116,"context_line":"              \u0027address\u0027: [EXPECTED_IP_10203040],"},{"line_number":117,"context_line":"              \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":118,"context_line":"              \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":119,"context_line":"              \u0027vlanTag\u0027: EXPECTED_VLAN_TAG},"},{"line_number":120,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":121,"context_line":"    }"},{"line_number":122,"context_line":"EXPECTED_CLIENT_GET_VFS_RETURN_VALUE \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_a93d8b2c","line":119,"range":{"start_line":114,"start_character":13,"end_line":119,"end_character":44},"updated":"2016-09-17 18:31:48.000000000","message":"http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"746e0bc15c3ed7ce4658d0894b357d2cd0bf9ac7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":"EXPECTED_MEDIATOR_GET_VFS_RET_VAL \u003d {"},{"line_number":113,"context_line":"    \u0027fspname\u0027: EXPECTED_VFS,"},{"line_number":114,"context_line":"    \u0027vfsip\u0027: {\u0027networkName\u0027: EXPECTED_NET_NAME,"},{"line_number":115,"context_line":"              \u0027fspool\u0027: EXPECTED_VFS,"},{"line_number":116,"context_line":"              \u0027address\u0027: [EXPECTED_IP_10203040],"},{"line_number":117,"context_line":"              \u0027prefixLen\u0027: EXPECTED_SUBNET,"},{"line_number":118,"context_line":"              \u0027vfs\u0027: EXPECTED_VFS,"},{"line_number":119,"context_line":"              \u0027vlanTag\u0027: EXPECTED_VLAN_TAG},"},{"line_number":120,"context_line":"    \u0027vfsname\u0027: EXPECTED_VFS,"},{"line_number":121,"context_line":"    }"},{"line_number":122,"context_line":"EXPECTED_CLIENT_GET_VFS_RETURN_VALUE \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_d6a95326","line":119,"range":{"start_line":114,"start_character":13,"end_line":119,"end_character":44},"in_reply_to":"7a8ec9b2_a93d8b2c","updated":"2016-09-19 19:42:31.000000000","message":"Done","commit_id":"83d1aedff216ff80ec0c634ba6729f394b038c02"}]}