)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fc9ebcfde879044536b91cb3863d95cccd85e786","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t attempt to escalate manila-manage privileges"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove code which allowed manila-manage to attempt to escalate"},{"line_number":10,"context_line":"privileges so that configuration files can be read by users who"},{"line_number":11,"context_line":"normally wouldn\u0027t have access, but do have sudo access."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie3bf9a81ee8d723cd8618643fa9d7382462aae42"},{"line_number":14,"context_line":"Closes-Bug:#1611171"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a8ec9b2_4c09002c","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":54},"updated":"2016-09-20 14:39:52.000000000","message":"Having sudo rights I still can achieve that you are trying to \"fix\" here:\n\"\"\"\n$ sudo -u %owner_name% manila-manage db version\n\"\"\"\nThen, three things about this change:\n1) It does not close any security hole according to statement above.\n2) It introduces, in some deployments, the need to use above described approach.\n3) If config file exists, then we do not reach \"changed code\" at all, because it is reachable only when it is \"NotFound\". See line 437 in https://review.openstack.org/#/c/371920/6/manila/cmd/manage.py","commit_id":"ca65cb4e5685dc4192fdd3b4d5a198a9f423caee"}],"manila/cmd/manage.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"ca90ae9830af33463cabc55b08427c37b9aaa1a4","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        log.setup(CONF, \"manila\")"},{"line_number":437,"context_line":"    except cfg.ConfigFilesNotFoundError as e:"},{"line_number":438,"context_line":"        cfg_files \u003d \", \".join(e.config_files)"},{"line_number":439,"context_line":"        print(_( \"Failed to read  configuration file(s): %s\") % cfg_files)"},{"line_number":440,"context_line":"        sys.exit(2)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    fn \u003d CONF.category.action_fn"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_94e9c3b9","line":439,"range":{"start_line":439,"start_character":33,"end_line":439,"end_character":34},"updated":"2016-09-18 02:54:27.000000000","message":"redundant space.","commit_id":"d301de26c94d2604bfe8ff1a7bb3a009602dd505"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e947b82deabd739986dfde718c8ae3f5566decc","unresolved":false,"context_lines":[{"line_number":435,"context_line":"             version\u003dversion.version_string())"},{"line_number":436,"context_line":"        log.setup(CONF, \"manila\")"},{"line_number":437,"context_line":"    except cfg.ConfigFilesNotFoundError as e:"},{"line_number":438,"context_line":"        cfg_files \u003d \", \".join(e.config_files)"},{"line_number":439,"context_line":"        print(_( \"Failed to read configuration file(s): %s\") % cfg_files)"},{"line_number":440,"context_line":"        sys.exit(2)"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_b6beb1ab","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":45},"updated":"2016-09-19 09:34:38.000000000","message":"TypeError: can only join an iterable\nhttp://logs.openstack.org/20/371920/4/check/gate-manila-python27-db-ubuntu-xenial/2502fa4/console.html#_2016-09-19_05_14_53_330646","commit_id":"ad935bc619a2c6af484c685e57aabbb9350a7a71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8e947b82deabd739986dfde718c8ae3f5566decc","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        log.setup(CONF, \"manila\")"},{"line_number":437,"context_line":"    except cfg.ConfigFilesNotFoundError as e:"},{"line_number":438,"context_line":"        cfg_files \u003d \", \".join(e.config_files)"},{"line_number":439,"context_line":"        print(_( \"Failed to read configuration file(s): %s\") % cfg_files)"},{"line_number":440,"context_line":"        sys.exit(2)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    fn \u003d CONF.category.action_fn"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_7693495b","line":439,"range":{"start_line":439,"start_character":16,"end_line":439,"end_character":17},"updated":"2016-09-19 09:34:38.000000000","message":"remove space\n\nhttp://logs.openstack.org/20/371920/4/check/gate-manila-pep8-ubuntu-xenial/1a126de/console.html#_2016-09-19_05_09_51_369075","commit_id":"ad935bc619a2c6af484c685e57aabbb9350a7a71"}]}