)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_single_svm.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ef2cd1ef59c2186c04226abdfdc7bef963119119","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def _find_matching_aggregates(self):"},{"line_number":115,"context_line":"        \"\"\"Find all aggregates match pattern.\"\"\""},{"line_number":116,"context_line":"        vserver_client \u003d self._get_api_client(vserver\u003dself._vserver)"},{"line_number":117,"context_line":"        aggregate_names \u003d vserver_client.list_vserver_aggregates()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        root_aggregate_names \u003d []"},{"line_number":120,"context_line":"        if self._have_cluster_creds:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c886b412","line":117,"range":{"start_line":117,"start_character":25,"end_line":117,"end_character":66},"updated":"2016-10-12 19:57:17.000000000","message":"Just curious if it would have been reasonable to implement list_vserver_aggregates to use a replacement for get_vserver_aggregate_capacities (which you use only for its keys) that actually collected relevant information about the aggrs in question (do they have root volumes) so that you could avlid having to add the extra filter below, i.e. have code that matches the nice simple style in lib_multi_svm.py.","commit_id":"eb2d9640e2b09553c70a4726c1e3a0e5fa4db025"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"29ba79b3983f25e0637011748f9240307ac175bd","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def _find_matching_aggregates(self):"},{"line_number":115,"context_line":"        \"\"\"Find all aggregates match pattern.\"\"\""},{"line_number":116,"context_line":"        vserver_client \u003d self._get_api_client(vserver\u003dself._vserver)"},{"line_number":117,"context_line":"        aggregate_names \u003d vserver_client.list_vserver_aggregates()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        root_aggregate_names \u003d []"},{"line_number":120,"context_line":"        if self._have_cluster_creds:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_0ce6d543","line":117,"range":{"start_line":117,"start_character":25,"end_line":117,"end_character":66},"in_reply_to":"fa6399be_c886b412","updated":"2016-10-13 15:02:39.000000000","message":"Hi, Tom.  The issue is that in single-SVM mode, I don\u0027t always have cluster-level credentials, which are required to determine the root aggregates, so I have to do the filtering here if sufficient creds are available.","commit_id":"eb2d9640e2b09553c70a4726c1e3a0e5fa4db025"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_single_svm.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"734bb5f0f9de8d81827b94af93ed9d17419c2f82","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            self.assertListEqual([fake.AGGREGATES[0], fake.ROOT_AGGREGATES[0]],"},{"line_number":193,"context_line":"                                 result)"},{"line_number":194,"context_line":"            self.assertFalse(mock_client.list_root_aggregates.called)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def test_get_network_allocations_number(self):"},{"line_number":197,"context_line":"        self.assertEqual(0, self.library.get_network_allocations_number())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8c3f5ed5","line":194,"updated":"2016-10-13 07:41:51.000000000","message":"suggest using mock_client.list_root_aggregates.assert_not_called instead.","commit_id":"eb2d9640e2b09553c70a4726c1e3a0e5fa4db025"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"29ba79b3983f25e0637011748f9240307ac175bd","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            self.assertListEqual([fake.AGGREGATES[0], fake.ROOT_AGGREGATES[0]],"},{"line_number":193,"context_line":"                                 result)"},{"line_number":194,"context_line":"            self.assertFalse(mock_client.list_root_aggregates.called)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def test_get_network_allocations_number(self):"},{"line_number":197,"context_line":"        self.assertEqual(0, self.library.get_network_allocations_number())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c18666da","line":194,"in_reply_to":"fa6399be_8c3f5ed5","updated":"2016-10-13 15:02:39.000000000","message":"Thanks for the suggestion.  assert_not_called was added to unittest.mock in Python 3.5, and the mock library appears to have had it for a while for Python 2, so it should be fine to use.  It\u0027s interesting to note that assert_not_called() appears only 9 times in manila, but I\u0027ll use it going forward.","commit_id":"eb2d9640e2b09553c70a4726c1e3a0e5fa4db025"}]}