)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since change [1] it is impossible to set endpoint_type and region_name"},{"line_number":10,"context_line":"for nova, cinder and neutron clients that are used by manila in some"},{"line_number":11,"context_line":"cases."},{"line_number":12,"context_line":"So, to fix it, add additional options called \u0027endpoint_type\u0027 for each"},{"line_number":13,"context_line":"of config groups related to these clients. These options can be"},{"line_number":14,"context_line":"defined in appropriate config group as of following:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_306caacf","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":60},"updated":"2016-11-02 16:02:38.000000000","message":"\u0027endpoint_type\u0027 and \u0027region_name\u0027","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since change [1] it is impossible to set endpoint_type and region_name"},{"line_number":10,"context_line":"for nova, cinder and neutron clients that are used by manila in some"},{"line_number":11,"context_line":"cases."},{"line_number":12,"context_line":"So, to fix it, add additional options called \u0027endpoint_type\u0027 for each"},{"line_number":13,"context_line":"of config groups related to these clients. These options can be"},{"line_number":14,"context_line":"defined in appropriate config group as of following:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_ab2dafa9","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":60},"in_reply_to":"ba5da102_306caacf","updated":"2016-11-02 16:15:13.000000000","message":"Done","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cases."},{"line_number":12,"context_line":"So, to fix it, add additional options called \u0027endpoint_type\u0027 for each"},{"line_number":13,"context_line":"of config groups related to these clients. These options can be"},{"line_number":14,"context_line":"defined in appropriate config group as of following:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[nova]"},{"line_number":17,"context_line":"endpoint_type \u003d publicURL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_b0b7da38","line":14,"range":{"start_line":14,"start_character":36,"end_line":14,"end_character":51},"updated":"2016-11-02 16:02:38.000000000","message":"nit s/as of following/as following/","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cases."},{"line_number":12,"context_line":"So, to fix it, add additional options called \u0027endpoint_type\u0027 for each"},{"line_number":13,"context_line":"of config groups related to these clients. These options can be"},{"line_number":14,"context_line":"defined in appropriate config group as of following:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[nova]"},{"line_number":17,"context_line":"endpoint_type \u003d publicURL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_4b3ed3da","line":14,"range":{"start_line":14,"start_character":36,"end_line":14,"end_character":51},"in_reply_to":"ba5da102_b0b7da38","updated":"2016-11-02 16:15:13.000000000","message":"Done","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"}],"manila/compute/nova.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":97,"context_line":"               help\u003d\u0027Endpoint type to be used with novaclient calls.\u0027),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"},{"line_number":99,"context_line":"               help\u003d\u0027Region name for connecting to nova\u0027),"},{"line_number":100,"context_line":"    ]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_4aea51ad","line":99,"updated":"2016-11-02 16:02:38.000000000","message":"end in period","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":97,"context_line":"               help\u003d\u0027Endpoint type to be used with novaclient calls.\u0027),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"},{"line_number":99,"context_line":"               help\u003d\u0027Region name for connecting to nova\u0027),"},{"line_number":100,"context_line":"    ]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_7d40ba34","line":99,"in_reply_to":"ba5da102_4aea51ad","updated":"2016-11-02 16:15:13.000000000","message":"Done","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"}],"manila/network/neutron/api.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"             \u0027neutron client requests.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt("},{"line_number":97,"context_line":"        \u0027region_name\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Region name for connecting to neutron in admin context\u0027),"},{"line_number":99,"context_line":"    cfg.StrOpt("},{"line_number":100,"context_line":"        \u0027endpoint_type\u0027,"},{"line_number":101,"context_line":"        default\u003d\u0027publicURL\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_eac88524","line":98,"updated":"2016-11-02 16:02:38.000000000","message":"end in period","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"             \u0027neutron client requests.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt("},{"line_number":97,"context_line":"        \u0027region_name\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Region name for connecting to neutron in admin context\u0027),"},{"line_number":99,"context_line":"    cfg.StrOpt("},{"line_number":100,"context_line":"        \u0027endpoint_type\u0027,"},{"line_number":101,"context_line":"        default\u003d\u0027publicURL\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_1da33e01","line":98,"in_reply_to":"ba5da102_eac88524","updated":"2016-11-02 16:15:13.000000000","message":"Done","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \u0027region_name\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Region name for connecting to neutron in admin context\u0027),"},{"line_number":99,"context_line":"    cfg.StrOpt("},{"line_number":100,"context_line":"        \u0027endpoint_type\u0027,"},{"line_number":101,"context_line":"        default\u003d\u0027publicURL\u0027,"},{"line_number":102,"context_line":"        help\u003d\u0027Endpoint type to be used with neutronclient calls.\u0027),"},{"line_number":103,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_c572d210","line":100,"updated":"2016-11-02 16:02:38.000000000","message":"nit: Would be nice to put this before region_name so that the 3 similar files use the same order.","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \u0027region_name\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Region name for connecting to neutron in admin context\u0027),"},{"line_number":99,"context_line":"    cfg.StrOpt("},{"line_number":100,"context_line":"        \u0027endpoint_type\u0027,"},{"line_number":101,"context_line":"        default\u003d\u0027publicURL\u0027,"},{"line_number":102,"context_line":"        help\u003d\u0027Endpoint type to be used with neutronclient calls.\u0027),"},{"line_number":103,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_9db74e39","line":100,"in_reply_to":"ba5da102_c572d210","updated":"2016-11-02 16:15:13.000000000","message":"Done","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    cfg.StrOpt("},{"line_number":100,"context_line":"        \u0027endpoint_type\u0027,"},{"line_number":101,"context_line":"        default\u003d\u0027publicURL\u0027,"},{"line_number":102,"context_line":"        help\u003d\u0027Endpoint type to be used with neutronclient calls.\u0027),"},{"line_number":103,"context_line":"]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_ea640523","line":102,"range":{"start_line":102,"start_character":44,"end_line":102,"end_character":57},"updated":"2016-11-02 16:02:38.000000000","message":"I think \"neutron client\" would look better in help than \"neutronclient\". IMHO. Same with the other 2 if you agree.","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    cfg.StrOpt("},{"line_number":100,"context_line":"        \u0027endpoint_type\u0027,"},{"line_number":101,"context_line":"        default\u003d\u0027publicURL\u0027,"},{"line_number":102,"context_line":"        help\u003d\u0027Endpoint type to be used with neutronclient calls.\u0027),"},{"line_number":103,"context_line":"]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_5d74d666","line":102,"range":{"start_line":102,"start_character":44,"end_line":102,"end_character":57},"in_reply_to":"ba5da102_ea640523","updated":"2016-11-02 16:15:13.000000000","message":"Done","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"}],"manila/volume/cinder.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":101,"context_line":"               help\u003d\u0027Endpoint type to be used with cinderclient calls.\u0027),"},{"line_number":102,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"},{"line_number":103,"context_line":"               help\u003d\u0027Region name for connecting to cinder\u0027),"},{"line_number":104,"context_line":"    ]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_4a3ed1da","line":103,"updated":"2016-11-02 16:02:38.000000000","message":"end in period","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":101,"context_line":"               help\u003d\u0027Endpoint type to be used with cinderclient calls.\u0027),"},{"line_number":102,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"},{"line_number":103,"context_line":"               help\u003d\u0027Region name for connecting to cinder\u0027),"},{"line_number":104,"context_line":"    ]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_fdd92a58","line":103,"in_reply_to":"ba5da102_4a3ed1da","updated":"2016-11-02 16:15:13.000000000","message":"Done","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d34d34588e6be24d89ed5e2ea7f4e1710464143d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    global AUTH_OBJ"},{"line_number":120,"context_line":"    if not AUTH_OBJ:"},{"line_number":121,"context_line":"        deprecated_opts_for_v2 \u003d {"},{"line_number":122,"context_line":"            \u0027username\u0027: CONF.cinder_admin_username,"},{"line_number":123,"context_line":"            \u0027password\u0027: CONF.cinder_admin_password,"},{"line_number":124,"context_line":"            \u0027tenant_name\u0027: CONF.cinder_admin_tenant_name,"},{"line_number":125,"context_line":"            \u0027auth_url\u0027: CONF.cinder_admin_auth_url,"},{"line_number":126,"context_line":"        }"},{"line_number":127,"context_line":"        AUTH_OBJ \u003d client_auth.AuthClientLoader("},{"line_number":128,"context_line":"            client_class\u003dcinder_client.Client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_c546524e","line":125,"range":{"start_line":122,"start_character":0,"end_line":125,"end_character":51},"updated":"2016-11-02 16:02:38.000000000","message":"Looks like a separate bug fix? Fixing the deprecated settings.","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"675f48913c09114712e0a8dc34bb68c42108581e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    global AUTH_OBJ"},{"line_number":120,"context_line":"    if not AUTH_OBJ:"},{"line_number":121,"context_line":"        deprecated_opts_for_v2 \u003d {"},{"line_number":122,"context_line":"            \u0027username\u0027: CONF.cinder_admin_username,"},{"line_number":123,"context_line":"            \u0027password\u0027: CONF.cinder_admin_password,"},{"line_number":124,"context_line":"            \u0027tenant_name\u0027: CONF.cinder_admin_tenant_name,"},{"line_number":125,"context_line":"            \u0027auth_url\u0027: CONF.cinder_admin_auth_url,"},{"line_number":126,"context_line":"        }"},{"line_number":127,"context_line":"        AUTH_OBJ \u003d client_auth.AuthClientLoader("},{"line_number":128,"context_line":"            client_class\u003dcinder_client.Client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_3dae4298","line":125,"range":{"start_line":122,"start_character":0,"end_line":125,"end_character":51},"in_reply_to":"ba5da102_c546524e","updated":"2016-11-02 16:15:13.000000000","message":"Could be, yes. But I would prefer to keep it here.","commit_id":"fa27d5c5239e2473602f6f595dc790227d963cdb"}]}