)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"20cc568492311a41b112d7d6a26b5ab06b6e82b3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-10-17 08:47:15 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use \u0027insecure\u0027 ssl if configured in tempest.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If20f8b802b1b51e2e027108132d189cdcba2c5f7"},{"line_number":10,"context_line":"Closes-Bug: 1633716"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_7e95b086","line":8,"updated":"2016-10-18 03:55:23.000000000","message":"It\u0027d better have some description about the bug here.","commit_id":"537a0113286a7d4a7fc3ff059d0bafb3ded00253"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c6157effb361a7891533c02718d60dfe39366a5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use \u0027insecure\u0027 ssl if configured in tempest.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When manila is deployed with self-signed SSL certificates, its tempest tests"},{"line_number":10,"context_line":"fail with a certificate verification error. In this deployment scenario,"},{"line_number":11,"context_line":"manila can not be tempest tested."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_2d23f706","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":76},"updated":"2016-10-18 14:45:26.000000000","message":"Lines in commit message should not be longer than 72 symbols.","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"}],"manila_tempest_tests/services/share/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"13c9da9db29a6b8676ed58f9478840e0de34fd2b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003dCONF.identity.disable_ssl_certificate_validation)"},{"line_number":45,"context_line":"        self.share_protocol \u003d None"},{"line_number":46,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":47,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c86b7eef","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":96},"updated":"2016-10-17 13:54:45.000000000","message":"It is too long line, pep rule is to have no more than 79 symbols in a line. Do it as of following:\n\n\"\"\"\nsuper(SharesClient, self).__init__(\n    auth_provider,\n    CONF.share.catalog_type,\n    CONF.share.region or CONF.identity.region,\n    endpoint_type\u003dCONF.share.endpoint_type,\n    disable_ssl_certificate_validation\u003d(\n        CONF.identity.disable_ssl_certificate_validation))\n\"\"\"","commit_id":"151e5a60b891853dc9b3006c95434c96f3edfae4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ce99f9165137d6aa6ce4a61813829dab6867f434","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003dCONF.identity.disable_ssl_certificate_validation)"},{"line_number":45,"context_line":"        self.share_protocol \u003d None"},{"line_number":46,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":47,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_88334613","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":96},"in_reply_to":"fa6399be_c86b7eef","updated":"2016-10-17 13:55:27.000000000","message":"It means, our voting pep8 job will fail and you \"need\" to address its issues.","commit_id":"151e5a60b891853dc9b3006c95434c96f3edfae4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bb506650fd6359055fbb5c55fe41b2910062653a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_cdfd1b70","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"updated":"2016-10-18 14:44:31.000000000","message":"Actually I expect it to be Tempest bug, not ours. It would be ours bug in case we specify here wrong value. Such behavior should be default one.","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b55785a77eb749a7c484a57970232643c02e8bd0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_327ba47c","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_0b3b54ec","updated":"2016-11-03 13:35:58.000000000","message":"Nicolas Bock,\n\nYou are asking whether it is ok to fix bug in its source instead of implementing workaround for it in place of usage. Tempest itself should default to this \"config option\" not all users of tempest workarounding tempest\u0027s default value.\n\nHere is nothing to ask, it should have been done in tempest. Or you want to workaround this bug in each separate tempest plugin as you do it here? Each of dozens of plugins?","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"51c75c9fd87f3023a8517ac2cfaf11a34f67d114","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_8f752dcc","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_0d90a542","updated":"2016-11-03 13:28:29.000000000","message":"I\u0027ll ask you the same as I asked Valeriy then :) Would you prefer me to raise this issue with tempest instead?","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"51c75c9fd87f3023a8517ac2cfaf11a34f67d114","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_0b3b54ec","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_6b90504f","updated":"2016-11-03 13:28:29.000000000","message":"That\u0027s a good point. Would you prefer me to raise this issue with tempest instead?","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"557cb2afb5aeb3f628f186942027a6666e3b4dc0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_0d90a542","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_6b90504f","updated":"2016-10-20 06:25:33.000000000","message":"There is actually code in tempest to set this: https://git.openstack.org/cgit/openstack/tempest/tree/tempest/common/credentials_factory.py?h\u003dmaster#n166 \nThis should be used by get_configured_admin_credentials() which is used in Manila. So looks like a tempest bug","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"fb5cdcabe47a4f12f45eecc4951487e8d9ed6935","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_98f2836e","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_8d5fa374","updated":"2016-10-18 15:08:37.000000000","message":"That\u0027s true. However, the RestClient class uses False as default and the tempest tests in manila call the manila API directly, which is why it\u0027s necessary to disable validation in manila tempest.","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c4c9e7e270a61089981b9522163afc3c886d9c12","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_6b90504f","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_98f2836e","updated":"2016-10-19 11:28:52.000000000","message":"That is what I am talking about. Tempest should have \"such\" default as you are implementing here. It is tempest does \"check of SSL\", not \"manila\". Manila can \"workaround\" bug updating its code, but it is still tempest bug.","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"29c64e1872d3bbd000555c5945f818582bbfc880","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_8d5fa374","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_cdfd1b70","updated":"2016-10-18 14:46:36.000000000","message":"Because validation is performed exactly by tempest code, not this plugin.","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"},{"author":{"_account_id":19298,"name":"Nicolas Bock","email":"nicolas.bock@canonical.com","username":"nicolasbock"},"change_message_id":"fb5cdcabe47a4f12f45eecc4951487e8d9ed6935","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            CONF.share.catalog_type,"},{"line_number":42,"context_line":"            CONF.share.region or CONF.identity.region,"},{"line_number":43,"context_line":"            endpoint_type\u003dCONF.share.endpoint_type,"},{"line_number":44,"context_line":"            disable_ssl_certificate_validation\u003d("},{"line_number":45,"context_line":"                CONF.identity.disable_ssl_certificate_validation))"},{"line_number":46,"context_line":"        self.share_protocol \u003d None"},{"line_number":47,"context_line":"        if CONF.share.enable_protocols:"},{"line_number":48,"context_line":"            self.share_protocol \u003d CONF.share.enable_protocols[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_18791330","line":45,"range":{"start_line":44,"start_character":12,"end_line":45,"end_character":66},"in_reply_to":"fa6399be_cdfd1b70","updated":"2016-10-18 15:08:37.000000000","message":"I figured it\u0027s a manila bug since this code is part of the manila repository. To help me understand, would you consider all of the code underneath \u0027manila_tempest_tests\u0027 to be part of tempest? Why isn\u0027t that code part of tempest?","commit_id":"750320817374bc11ea3b0c54ae4ed1abd1a84214"}]}
