)]}'
{"manila_tempest_tests/tests/api/test_quotas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7fb722c3cf27ec322a50d657436ad267054feeba","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            msg \u003d \"Quota tests are disabled.\""},{"line_number":32,"context_line":"            raise cls.skipException(msg)"},{"line_number":33,"context_line":"        super(SharesQuotasTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.user_id \u003d cls.shares_v2_client.user_id or cls.user_id"},{"line_number":35,"context_line":"        cls.tenant_id \u003d cls.shares_v2_client.tenant_id or cls.tenant_id"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_9bd194d0","line":34,"range":{"start_line":34,"start_character":22,"end_line":34,"end_character":50},"updated":"2016-10-23 09:07:57.000000000","message":"When can this be None?","commit_id":"6ff584dbe5c76e7908cea416f18f22568ac79f5b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0f3f4db3af390dea1ff6db701d1d863296c20249","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            msg \u003d \"Quota tests are disabled.\""},{"line_number":32,"context_line":"            raise cls.skipException(msg)"},{"line_number":33,"context_line":"        super(SharesQuotasTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.user_id \u003d cls.shares_v2_client.user_id or cls.user_id"},{"line_number":35,"context_line":"        cls.tenant_id \u003d cls.shares_v2_client.tenant_id or cls.tenant_id"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_56b6f3dc","line":34,"range":{"start_line":34,"start_character":22,"end_line":34,"end_character":50},"in_reply_to":"da6895a0_9bd194d0","updated":"2016-10-23 12:12:30.000000000","message":"When DHSS equals \"False\".","commit_id":"6ff584dbe5c76e7908cea416f18f22568ac79f5b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7fb722c3cf27ec322a50d657436ad267054feeba","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            raise cls.skipException(msg)"},{"line_number":33,"context_line":"        super(SharesQuotasTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.user_id \u003d cls.shares_v2_client.user_id or cls.user_id"},{"line_number":35,"context_line":"        cls.tenant_id \u003d cls.shares_v2_client.tenant_id or cls.tenant_id"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":38,"context_line":"    @ddt.data(\u0027shares_client\u0027, \u0027shares_v2_client\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_bbd658c3","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":54},"updated":"2016-10-23 09:07:57.000000000","message":"When can this be None?","commit_id":"6ff584dbe5c76e7908cea416f18f22568ac79f5b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0f3f4db3af390dea1ff6db701d1d863296c20249","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            raise cls.skipException(msg)"},{"line_number":33,"context_line":"        super(SharesQuotasTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.user_id \u003d cls.shares_v2_client.user_id or cls.user_id"},{"line_number":35,"context_line":"        cls.tenant_id \u003d cls.shares_v2_client.tenant_id or cls.tenant_id"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":38,"context_line":"    @ddt.data(\u0027shares_client\u0027, \u0027shares_v2_client\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_76bbf7c4","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":54},"in_reply_to":"da6895a0_bbd658c3","updated":"2016-10-23 12:12:30.000000000","message":"ditto","commit_id":"6ff584dbe5c76e7908cea416f18f22568ac79f5b"}],"manila_tempest_tests/tests/api/test_quotas_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f625374946d106e1d2b12be8f2d246b9cf6527fe","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          self.shares_v2_client.tenant_id,"},{"line_number":52,"context_line":"                          shares\u003d9)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @ddt.data("},{"line_number":55,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027show_quotas\u0027),"},{"line_number":56,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027default_quotas\u0027),"},{"line_number":57,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027reset_quotas\u0027),"},{"line_number":58,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027update_quotas\u0027),"},{"line_number":59,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027show_quotas\u0027),"},{"line_number":60,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027default_quotas\u0027),"},{"line_number":61,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027reset_quotas\u0027),"},{"line_number":62,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027update_quotas\u0027),"},{"line_number":63,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027show_quotas\u0027),"},{"line_number":64,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027default_quotas\u0027),"},{"line_number":65,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027reset_quotas\u0027),"},{"line_number":66,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027update_quotas\u0027),"},{"line_number":67,"context_line":"    )"},{"line_number":68,"context_line":"    @ddt.unpack"},{"line_number":69,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":70,"context_line":"    @base.skip_if_microversion_not_supported(\"2.7\")"},{"line_number":71,"context_line":"    def test_show_quotas_with_wrong_versions(self, url, version, method_name):"},{"line_number":72,"context_line":"        self.assertRaises("},{"line_number":73,"context_line":"            lib_exc.NotFound,"},{"line_number":74,"context_line":"            getattr(self.shares_v2_client, method_name),"},{"line_number":75,"context_line":"            self.shares_v2_client.tenant_id,"},{"line_number":76,"context_line":"            version\u003dversion, url\u003durl,"},{"line_number":77,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6895a0_4fe90d1a","line":77,"range":{"start_line":54,"start_character":0,"end_line":77,"end_character":9},"updated":"2016-10-21 15:46:52.000000000","message":"needs to be in the admin version of this test file. Good catch though o.O","commit_id":"c5c29cc6f0ffb56f9d17f58fbdbf9327cd15a453"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7fb722c3cf27ec322a50d657436ad267054feeba","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          self.shares_v2_client.tenant_id,"},{"line_number":52,"context_line":"                          shares\u003d9)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @ddt.data("},{"line_number":55,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027show_quotas\u0027),"},{"line_number":56,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027default_quotas\u0027),"},{"line_number":57,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027reset_quotas\u0027),"},{"line_number":58,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027update_quotas\u0027),"},{"line_number":59,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027show_quotas\u0027),"},{"line_number":60,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027default_quotas\u0027),"},{"line_number":61,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027reset_quotas\u0027),"},{"line_number":62,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027update_quotas\u0027),"},{"line_number":63,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027show_quotas\u0027),"},{"line_number":64,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027default_quotas\u0027),"},{"line_number":65,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027reset_quotas\u0027),"},{"line_number":66,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027update_quotas\u0027),"},{"line_number":67,"context_line":"    )"},{"line_number":68,"context_line":"    @ddt.unpack"},{"line_number":69,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":70,"context_line":"    @base.skip_if_microversion_not_supported(\"2.7\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_dbdb0cec","line":67,"range":{"start_line":54,"start_character":4,"end_line":67,"end_character":5},"updated":"2016-10-23 09:07:57.000000000","message":"If the user can\u0027t call some of these methods, they should not be in this file. We should move these tests to manila_tempest_tests/tests/api/admin/test_quotas_negative.py","commit_id":"6ff584dbe5c76e7908cea416f18f22568ac79f5b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fad9ec8f8aa276f93930cbbad0a6226fb5b5a014","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          self.shares_v2_client.tenant_id,"},{"line_number":52,"context_line":"                          shares\u003d9)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @ddt.data("},{"line_number":55,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027show_quotas\u0027),"},{"line_number":56,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027default_quotas\u0027),"},{"line_number":57,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027reset_quotas\u0027),"},{"line_number":58,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027update_quotas\u0027),"},{"line_number":59,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027show_quotas\u0027),"},{"line_number":60,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027default_quotas\u0027),"},{"line_number":61,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027reset_quotas\u0027),"},{"line_number":62,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027update_quotas\u0027),"},{"line_number":63,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027show_quotas\u0027),"},{"line_number":64,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027default_quotas\u0027),"},{"line_number":65,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027reset_quotas\u0027),"},{"line_number":66,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027update_quotas\u0027),"},{"line_number":67,"context_line":"    )"},{"line_number":68,"context_line":"    @ddt.unpack"},{"line_number":69,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":70,"context_line":"    @base.skip_if_microversion_not_supported(\"2.7\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_e27c81ed","line":67,"range":{"start_line":54,"start_character":4,"end_line":67,"end_character":5},"in_reply_to":"da6895a0_96b08bdf","updated":"2016-10-25 05:41:38.000000000","message":"Hmmm... You and I know that because of our knowledge of the API, i.e, you wrote it. IMHO, tests aren\u0027t supposed to work like that.. The test environment should be conducive enough to test the API, in this case, it isn\u0027t entirely, because you need the tenant administrator privileges to invoke the API.\n\nAlso, In some projects, NotFound is what is raised/returned when lesser privileged users interact with resources requiring higher privileges.","commit_id":"6ff584dbe5c76e7908cea416f18f22568ac79f5b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0f3f4db3af390dea1ff6db701d1d863296c20249","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          self.shares_v2_client.tenant_id,"},{"line_number":52,"context_line":"                          shares\u003d9)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @ddt.data("},{"line_number":55,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027show_quotas\u0027),"},{"line_number":56,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027default_quotas\u0027),"},{"line_number":57,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027reset_quotas\u0027),"},{"line_number":58,"context_line":"        (\u0027quota-sets\u0027, \u00272.0\u0027, \u0027update_quotas\u0027),"},{"line_number":59,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027show_quotas\u0027),"},{"line_number":60,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027default_quotas\u0027),"},{"line_number":61,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027reset_quotas\u0027),"},{"line_number":62,"context_line":"        (\u0027quota-sets\u0027, \u00272.6\u0027, \u0027update_quotas\u0027),"},{"line_number":63,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027show_quotas\u0027),"},{"line_number":64,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027default_quotas\u0027),"},{"line_number":65,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027reset_quotas\u0027),"},{"line_number":66,"context_line":"        (\u0027os-quota-sets\u0027, \u00272.7\u0027, \u0027update_quotas\u0027),"},{"line_number":67,"context_line":"    )"},{"line_number":68,"context_line":"    @ddt.unpack"},{"line_number":69,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API)"},{"line_number":70,"context_line":"    @base.skip_if_microversion_not_supported(\"2.7\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_96b08bdf","line":67,"range":{"start_line":54,"start_character":4,"end_line":67,"end_character":5},"in_reply_to":"da6895a0_dbdb0cec","updated":"2016-10-23 12:12:30.000000000","message":"NotFound error is raised before check of policy. So, it does not matter at all which role is assinged to caller.","commit_id":"6ff584dbe5c76e7908cea416f18f22568ac79f5b"}]}
