)]}'
{"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1f4baae9718a81a3f8cd3bfde9e9681b279d08ed","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        self._client.send_ems_log_message(self._build_base_ems_log_message())"},{"line_number":299,"context_line":"        self._client.send_ems_log_message(self._build_pool_ems_log_message())"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _build_ems_log_message(self):"},{"line_number":302,"context_line":"        \"\"\"Construct EMS Autosupport log message common to all events.\"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        ems_log \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_d76cd39e","line":301,"range":{"start_line":301,"start_character":8,"end_line":301,"end_character":30},"updated":"2016-10-21 18:17:19.000000000","message":"Seems like this is the base that the other 2 are based on.  Should the names be swapped?","commit_id":"cb67e7d69e3ae70a89cb88923109dfde26c828a9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b97332bcc49ad3f7f90eaa16d7118059091b2f4f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        self._client.send_ems_log_message(self._build_base_ems_log_message())"},{"line_number":299,"context_line":"        self._client.send_ems_log_message(self._build_pool_ems_log_message())"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _build_ems_log_message(self):"},{"line_number":302,"context_line":"        \"\"\"Construct EMS Autosupport log message common to all events.\"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        ems_log \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_9de167d3","line":301,"range":{"start_line":301,"start_character":8,"end_line":301,"end_character":30},"in_reply_to":"da6895a0_d76cd39e","updated":"2016-10-25 11:33:49.000000000","message":"Yeah, I second-guessed myself a few times on this one.  I\u0027ve changed the names.  The other method names now match their event IDs.","commit_id":"cb67e7d69e3ae70a89cb88923109dfde26c828a9"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"1e29997d20005a99580ca5a678dc20244fdaf355","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    def _build_pool_ems_log_message(self):"},{"line_number":327,"context_line":"        \"\"\"Construct EMS Autosupport log message with storage pool info.\"\"\""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        message \u003d self._get_ems_pool_info()"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        ems_log \u003d self._build_ems_log_message()"},{"line_number":332,"context_line":"        ems_log.update({"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_2d8cc034","line":329,"updated":"2016-10-24 09:18:35.000000000","message":"the circumstance that _get_ems_pool_info not implemented should be covered by UT.","commit_id":"cb67e7d69e3ae70a89cb88923109dfde26c828a9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b97332bcc49ad3f7f90eaa16d7118059091b2f4f","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    def _build_pool_ems_log_message(self):"},{"line_number":327,"context_line":"        \"\"\"Construct EMS Autosupport log message with storage pool info.\"\"\""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        message \u003d self._get_ems_pool_info()"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        ems_log \u003d self._build_ems_log_message()"},{"line_number":332,"context_line":"        ems_log.update({"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_1dce375a","line":329,"in_reply_to":"da6895a0_2d8cc034","updated":"2016-10-25 11:33:49.000000000","message":"This class is not instantiated by itself at runtime; only its subclasses are instantiated, where the method is always present and implemented, so I\u0027m not certain how much value there is in testing the abstract method.  But it\u0027s trival, so why not?","commit_id":"cb67e7d69e3ae70a89cb88923109dfde26c828a9"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"1e29997d20005a99580ca5a678dc20244fdaf355","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        result \u003d self.library._build_pool_ems_log_message()"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        self.assertDictEqual(fake.EMS_POOL_MESSAGE, result)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_find_matching_aggregates(self):"},{"line_number":455,"context_line":"        self.assertRaises(NotImplementedError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_ad78d02c","line":452,"updated":"2016-10-24 09:18:35.000000000","message":"Failed in PY27 env.","commit_id":"cb67e7d69e3ae70a89cb88923109dfde26c828a9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b97332bcc49ad3f7f90eaa16d7118059091b2f4f","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        result \u003d self.library._build_pool_ems_log_message()"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        self.assertDictEqual(fake.EMS_POOL_MESSAGE, result)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_find_matching_aggregates(self):"},{"line_number":455,"context_line":"        self.assertRaises(NotImplementedError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_3d5a1b50","line":452,"in_reply_to":"da6895a0_ad78d02c","updated":"2016-10-25 11:33:49.000000000","message":"Fixed.","commit_id":"cb67e7d69e3ae70a89cb88923109dfde26c828a9"}]}
