)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1499cf2e2b566f061e86d3cf969d4cba6dc9c360","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yingzhe Zeng \u003czengyingzhe@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-02 02:19:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Resync replication of huawei backend while it\u0027s to recover"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, once the replication of huawei backend is broken,"},{"line_number":10,"context_line":"the replica state will always be error, even if the replication"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a3905b3_00c4543e","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":58},"updated":"2017-01-25 10:10:23.000000000","message":"when in \u0027to recover\u0027","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"04f68a1a3fc8a68b8f1bf6b035b8d5eae46388f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yingzhe Zeng \u003czengyingzhe@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-02 02:19:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Resync replication of huawei backend while it\u0027s to recover"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, once the replication of huawei backend is broken,"},{"line_number":10,"context_line":"the replica state will always be error, even if the replication"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_cf4b64af","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":58},"in_reply_to":"5a3905b3_00c4543e","updated":"2017-01-25 23:38:48.000000000","message":"+1 (I get it now, but at first I thought the subject was messed up)","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1499cf2e2b566f061e86d3cf969d4cba6dc9c360","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the replica state will always be error, even if the replication"},{"line_number":11,"context_line":"connection of huawei backends has recovered."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This\u0027s because huawei replication is asynchronous, when the"},{"line_number":14,"context_line":"replication connection is recovered, we need to launch a resync"},{"line_number":15,"context_line":"process manually, then the replication will recover to a"},{"line_number":16,"context_line":"normal status."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a3905b3_602fd8f6","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"updated":"2017-01-25 10:10:23.000000000","message":"This is","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"04f68a1a3fc8a68b8f1bf6b035b8d5eae46388f7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the replica state will always be error, even if the replication"},{"line_number":11,"context_line":"connection of huawei backends has recovered."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This\u0027s because huawei replication is asynchronous, when the"},{"line_number":14,"context_line":"replication connection is recovered, we need to launch a resync"},{"line_number":15,"context_line":"process manually, then the replication will recover to a"},{"line_number":16,"context_line":"normal status."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_0fcc8c34","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"in_reply_to":"5a3905b3_602fd8f6","updated":"2017-01-25 23:38:48.000000000","message":"nit, but agree","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"}],"manila/share/drivers/huawei/v3/replication.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"70a3cf0a4d0da89b84168194d0f06860641d42ed","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        pair_info \u003d self._get_replication_pair_info(replica_pair_id)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        def _is_to_recover(pair_info):"},{"line_number":135,"context_line":"            if (pair_info[\u0027RUNNINGSTATUS\u0027] \u003d\u003d"},{"line_number":136,"context_line":"                    constants.REPLICA_RUNNING_STATUS_TO_RECOVER):"},{"line_number":137,"context_line":"                return True"},{"line_number":138,"context_line":"            return False"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        health \u003d self._check_replication_health(pair_info)"},{"line_number":141,"context_line":"        if health is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_a88c2e80","line":138,"range":{"start_line":135,"start_character":12,"end_line":138,"end_character":24},"updated":"2016-10-31 10:01:24.000000000","message":"Instead of using an if here, you could just do\n\n  return pair_info[\u0027RUNNINGSTATUS\u0027] \u003d\u003d constants.REPLICA_RUNNING_STATUS_TO_RECOVER","commit_id":"d18a1dd911b4f66ed3890124796353c5a480b8d1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1499cf2e2b566f061e86d3cf969d4cba6dc9c360","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if health is not None:"},{"line_number":140,"context_line":"            if not _is_to_recover(pair_info):"},{"line_number":141,"context_line":"                LOG.warning(_LW(\"Cannot update the replication %s \""},{"line_number":142,"context_line":"                                \"because it\u0027s not in normal status and \""},{"line_number":143,"context_line":"                                \"not to recover.\"),"},{"line_number":144,"context_line":"                            replica_pair_id)"},{"line_number":145,"context_line":"                return"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_2073104f","line":143,"range":{"start_line":142,"start_character":46,"end_line":143,"end_character":47},"updated":"2017-01-25 10:10:23.000000000","message":"neither in normal status or \u0027to recover\u0027.","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"df1dd579fb936dde287e1366d47b90e0a9538524","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                return"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            # replication is in to-recover status, try to resync manually."},{"line_number":148,"context_line":"            LOG.debug(\"Resync replication %s because it is to recover.\","},{"line_number":149,"context_line":"                      replica_pair_id)"},{"line_number":150,"context_line":"            self._sync_replication_pair(replica_pair_id)"},{"line_number":151,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_6f445949","line":148,"range":{"start_line":148,"start_character":16,"end_line":148,"end_character":21},"updated":"2016-11-03 13:13:53.000000000","message":"Don\u0027t you want this to be warning? You\u0027re expecting someone to act on it, manually.","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1499cf2e2b566f061e86d3cf969d4cba6dc9c360","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                return"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            # replication is in to-recover status, try to resync manually."},{"line_number":148,"context_line":"            LOG.debug(\"Resync replication %s because it is to recover.\","},{"line_number":149,"context_line":"                      replica_pair_id)"},{"line_number":150,"context_line":"            self._sync_replication_pair(replica_pair_id)"},{"line_number":151,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_009ff45f","line":148,"range":{"start_line":148,"start_character":53,"end_line":148,"end_character":69},"updated":"2017-01-25 10:10:23.000000000","message":"it is in status \u0027to recover\u0027.","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"04f68a1a3fc8a68b8f1bf6b035b8d5eae46388f7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                return"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            # replication is in to-recover status, try to resync manually."},{"line_number":148,"context_line":"            LOG.debug(\"Resync replication %s because it is to recover.\","},{"line_number":149,"context_line":"                      replica_pair_id)"},{"line_number":150,"context_line":"            self._sync_replication_pair(replica_pair_id)"},{"line_number":151,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_affc583f","line":148,"range":{"start_line":148,"start_character":16,"end_line":148,"end_character":21},"in_reply_to":"5a3905b3_60d7d823","updated":"2017-01-25 23:38:48.000000000","message":"I think the sync is automated below.  Maybe s/Resync/Resyncing/ to show that","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1499cf2e2b566f061e86d3cf969d4cba6dc9c360","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                return"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            # replication is in to-recover status, try to resync manually."},{"line_number":148,"context_line":"            LOG.debug(\"Resync replication %s because it is to recover.\","},{"line_number":149,"context_line":"                      replica_pair_id)"},{"line_number":150,"context_line":"            self._sync_replication_pair(replica_pair_id)"},{"line_number":151,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_60d7d823","line":148,"range":{"start_line":148,"start_character":16,"end_line":148,"end_character":21},"in_reply_to":"ba5da102_6f445949","updated":"2017-01-25 10:10:23.000000000","message":"+1","commit_id":"5f742a4b6912c556c96f1c75ad7a5771819b76e3"}]}
