)]}'
{"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9c195f8c265cc7514078a7f17de82b6b4ee83b96","unresolved":false,"context_lines":[{"line_number":2945,"context_line":"        # Process existing data"},{"line_number":2946,"context_line":"        # NOTE(u_glide): read_deleted\u003d\u0027all\u0027 means here \u0027read all\u0027"},{"line_number":2947,"context_line":"        original_data \u003d _driver_private_data_query("},{"line_number":2948,"context_line":"            session, context, entity_id, read_deleted\u003d\u0027all\u0027).all()"},{"line_number":2949,"context_line":""},{"line_number":2950,"context_line":"        for data_ref in original_data:"},{"line_number":2951,"context_line":"            in_new_details \u003d data_ref[\u0027key\u0027] in new_details"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_254fa793","line":2948,"range":{"start_line":2948,"start_character":11,"end_line":2948,"end_character":66},"updated":"2016-10-27 08:19:16.000000000","message":"Actually u_glide was wrong. read_deleted can be one of two values: yes, no. If read_deleted is None, it is assumed from the context; and no matter who you are, in manila, you can\u0027t read soft deleted rows... why? I\u0027m not entirely sure. I would ask vponomaryov/bswartz because it seems like it\u0027s been so for a while. \n\nSo, your \u0027all\u0027 value is never resolved. What is the behavior you need? Why do you care about soft deleted rows here?\n\nread_deleted should always be \u0027no\u0027 imho. \n\nYou have two values you can send read_deleted: \u0027yes\u0027 or \u0027no\u0027. If you want to read only the deleted rows, you would use read_deleted\u003d\u0027yes\u0027; if you want to read only the existing (non-deleted) rows, send read_deleted\u003d\u0027no\u0027","commit_id":"5c0d42686f773efcf4fd910ef5b12ff50361ecce"}]}
