)]}'
{"manila/scheduler/drivers/filter.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd552d787a139f9a702a8b11a094ad49f745502b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def _filter_backend_spec_for_share_type(self, extra_specs,"},{"line_number":136,"context_line":"                                            request_spec):"},{"line_number":137,"context_line":"        share_type_backend \u003d extra_specs.get(\u0027share_backend_name\u0027)"},{"line_number":138,"context_line":"        if share_type_backend:"},{"line_number":139,"context_line":"            existing_replica_hosts \u003d request_spec.get("},{"line_number":140,"context_line":"                \u0027all_replica_hosts\u0027, \u0027\u0027).split(\u0027,\u0027)"},{"line_number":141,"context_line":"            for host in existing_replica_hosts:"},{"line_number":142,"context_line":"                if share_type_backend \u003d\u003d share_utils.extract_host("},{"line_number":143,"context_line":"                        host, \u0027backend_name\u0027):"},{"line_number":144,"context_line":"                    extra_specs.pop(\u0027share_backend_name\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _format_filter_properties(self, context, filter_properties,"},{"line_number":147,"context_line":"                                  request_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_d084390c","line":144,"range":{"start_line":138,"start_character":0,"end_line":144,"end_character":57},"updated":"2016-11-03 01:58:51.000000000","message":"Why check for the value of the share_backend_name? Why not just pop it? we know we\u0027re creating a replica and we can\u0027t adhere to this extra-spec.","commit_id":"206dbbf75062d3aaf206915d1cb6c2fd24d8a379"}],"manila/tests/scheduler/drivers/test_filter.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47d0d7b04a219b535b710d139e29f30c22892723","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.assertIn(\u0027replication_domain\u0027, retval[0])"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @ddt.data("},{"line_number":64,"context_line":"        (\u0027host1@backend1,host2@backend2\u0027, \u0027assertIn\u0027),"},{"line_number":65,"context_line":"        (\u0027host1@backend1,host2@fake_backend\u0027, \u0027assertNotIn\u0027),"},{"line_number":66,"context_line":"    )"},{"line_number":67,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_70e0cdcd","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":54},"updated":"2016-11-03 02:01:04.000000000","message":"I don\u0027t understand this test case. I think we should always pop the share_backend_id from the extra-specs when creating the replica...","commit_id":"206dbbf75062d3aaf206915d1cb6c2fd24d8a379"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47d0d7b04a219b535b710d139e29f30c22892723","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        (\u0027host1@backend1,host2@fake_backend\u0027, \u0027assertNotIn\u0027),"},{"line_number":66,"context_line":"    )"},{"line_number":67,"context_line":"    @ddt.unpack"},{"line_number":68,"context_line":"    def test___format_filter_properties_backend_specified_for_replica("},{"line_number":69,"context_line":"            self, replica_hosts, assert_method):"},{"line_number":70,"context_line":"        sched \u003d fakes.FakeFilterScheduler()"},{"line_number":71,"context_line":"        fake_context \u003d context.RequestContext(\u0027user\u0027, \u0027project\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_d09b5964","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":15},"updated":"2016-11-03 02:01:04.000000000","message":"s/___/__","commit_id":"206dbbf75062d3aaf206915d1cb6c2fd24d8a379"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47d0d7b04a219b535b710d139e29f30c22892723","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        request_spec \u003d {"},{"line_number":73,"context_line":"            \u0027share_properties\u0027: {\u0027project_id\u0027: 1, \u0027size\u0027: 1},"},{"line_number":74,"context_line":"            \u0027share_instance_properties\u0027: {},"},{"line_number":75,"context_line":"            \u0027share_type\u0027: {\u0027name\u0027: \u0027NFS\u0027,"},{"line_number":76,"context_line":"                           \u0027extra_specs\u0027: {"},{"line_number":77,"context_line":"                               \u0027share_backend_name\u0027: \u0027fake_backend\u0027,"},{"line_number":78,"context_line":"                           },"},{"line_number":79,"context_line":"                           },"},{"line_number":80,"context_line":"            \u0027share_id\u0027: [\u0027fake-id1\u0027],"},{"line_number":81,"context_line":"            \u0027active_replica_host\u0027: \u0027fake_ar_host\u0027,"},{"line_number":82,"context_line":"            \u0027all_replica_hosts\u0027: replica_hosts,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_30ad7588","line":79,"range":{"start_line":75,"start_character":26,"end_line":79,"end_character":29},"updated":"2016-11-03 02:01:04.000000000","message":"wrap properly..","commit_id":"206dbbf75062d3aaf206915d1cb6c2fd24d8a379"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47d0d7b04a219b535b710d139e29f30c22892723","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                               \u0027share_backend_name\u0027: \u0027fake_backend\u0027,"},{"line_number":78,"context_line":"                           },"},{"line_number":79,"context_line":"                           },"},{"line_number":80,"context_line":"            \u0027share_id\u0027: [\u0027fake-id1\u0027],"},{"line_number":81,"context_line":"            \u0027active_replica_host\u0027: \u0027fake_ar_host\u0027,"},{"line_number":82,"context_line":"            \u0027all_replica_hosts\u0027: replica_hosts,"},{"line_number":83,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_50a82977","line":80,"range":{"start_line":80,"start_character":24,"end_line":80,"end_character":36},"updated":"2016-11-03 02:01:04.000000000","message":"why is this a list?","commit_id":"206dbbf75062d3aaf206915d1cb6c2fd24d8a379"}]}