)]}'
{"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5bde6fcdb9b3d8b723a67c75bb4efca2a0040f17","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        self.private_storage.delete(share[\u0027id\u0027])"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def create_share_from_snapshot(self, share, snapshot,"},{"line_number":388,"context_line":"                                   share_server\u003dNone):"},{"line_number":389,"context_line":"        \"\"\"Create a share from snapshot.\"\"\""},{"line_number":390,"context_line":"        share_fs_id \u003d self.helper.get_fsid_by_name(snapshot[\u0027share_name\u0027])"},{"line_number":391,"context_line":"        if not share_fs_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_bb4dcfc5","line":388,"range":{"start_line":387,"start_character":4,"end_line":388,"end_character":54},"updated":"2016-11-03 14:54:18.000000000","message":"Why this one is not changed?","commit_id":"59ea8fead17324a2b88485f8e1b1ab22663d59df"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b8f252f410dcb4220ed417e000e69951a78f8b49","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        self.private_storage.delete(share[\u0027id\u0027])"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def create_share_from_snapshot(self, share, snapshot,"},{"line_number":388,"context_line":"                                   share_server\u003dNone):"},{"line_number":389,"context_line":"        \"\"\"Create a share from snapshot.\"\"\""},{"line_number":390,"context_line":"        share_fs_id \u003d self.helper.get_fsid_by_name(snapshot[\u0027share_name\u0027])"},{"line_number":391,"context_line":"        if not share_fs_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_d93996f3","line":388,"range":{"start_line":387,"start_character":4,"end_line":388,"end_character":54},"in_reply_to":"ba5da102_bb4dcfc5","updated":"2016-11-04 02:12:36.000000000","message":"this method calls create_share to create the share as well, so no need to call private_storage.update again.","commit_id":"59ea8fead17324a2b88485f8e1b1ab22663d59df"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5bde6fcdb9b3d8b723a67c75bb4efca2a0040f17","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"                              \u0027replica\u0027: replica[\u0027id\u0027]})"},{"line_number":1853,"context_line":"        else:"},{"line_number":1854,"context_line":"            self.replica_mgr.delete_replication_pair(replica_pair_id)"},{"line_number":1855,"context_line":"            self.private_storage.update(replica[\u0027id\u0027],"},{"line_number":1856,"context_line":"                                        {\u0027replica_pair_id\u0027: \u0027\u0027})"},{"line_number":1857,"context_line":""},{"line_number":1858,"context_line":"        try:"},{"line_number":1859,"context_line":"            self.delete_share(replica, share_server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_20d6ee4e","line":1856,"range":{"start_line":1855,"start_character":12,"end_line":1856,"end_character":64},"updated":"2016-11-03 14:54:18.000000000","message":"I see that you redefine value of deleted replica. But the one that stays will have \"replica_pair_id\" defined.","commit_id":"59ea8fead17324a2b88485f8e1b1ab22663d59df"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b8f252f410dcb4220ed417e000e69951a78f8b49","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"                              \u0027replica\u0027: replica[\u0027id\u0027]})"},{"line_number":1853,"context_line":"        else:"},{"line_number":1854,"context_line":"            self.replica_mgr.delete_replication_pair(replica_pair_id)"},{"line_number":1855,"context_line":"            self.private_storage.update(replica[\u0027id\u0027],"},{"line_number":1856,"context_line":"                                        {\u0027replica_pair_id\u0027: \u0027\u0027})"},{"line_number":1857,"context_line":""},{"line_number":1858,"context_line":"        try:"},{"line_number":1859,"context_line":"            self.delete_share(replica, share_server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_b42b0781","line":1856,"range":{"start_line":1855,"start_character":12,"end_line":1856,"end_character":64},"in_reply_to":"ba5da102_20d6ee4e","updated":"2016-11-04 02:12:36.000000000","message":"Actually this step is not that imperative, because the following delete_share process will delete it anyway. but I\u0027d rather update it here to the original default value, in case exceptions happen in the share deleting process.","commit_id":"59ea8fead17324a2b88485f8e1b1ab22663d59df"}]}
