)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"00953e5b41dc001268a93078aa0c3b277bb45a3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoyang \u003cxiaoyang.zhang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-04 14:26:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Optimize share expansion function:"},{"line_number":8,"context_line":"If share from shrink 10G to 5G, the volume is still 10G."},{"line_number":9,"context_line":"This share`s size display is 5G, but the share extend newsize must be \u003e 10G."},{"line_number":10,"context_line":"So, I think only need to perform resize_filesystem when the share extend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_e1b21c06","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":34},"updated":"2016-11-04 07:59:05.000000000","message":"Topic should be as little ambiguous as possible. You fix generic driver here. So, it would sound much better using following:\n\n\"\"\"\nFix extend operation of shrinked share in generic driver\n\"\"\"","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoyang \u003cxiaoyang.zhang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-04 14:26:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Optimize share expansion function:"},{"line_number":8,"context_line":"If share from shrink 10G to 5G, the volume is still 10G."},{"line_number":9,"context_line":"This share`s size display is 5G, but the share extend newsize must be \u003e 10G."},{"line_number":10,"context_line":"So, I think only need to perform resize_filesystem when the share extend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_5ba9f723","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":24},"updated":"2016-11-04 07:12:14.000000000","message":"extension","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoyang \u003cxiaoyang.zhang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-04 14:26:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Optimize share expansion function:"},{"line_number":8,"context_line":"If share from shrink 10G to 5G, the volume is still 10G."},{"line_number":9,"context_line":"This share`s size display is 5G, but the share extend newsize must be \u003e 10G."},{"line_number":10,"context_line":"So, I think only need to perform resize_filesystem when the share extend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_fb700bdf","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":34},"updated":"2016-11-04 07:12:14.000000000","message":"remove :, and add a newline between this line and the following paragraph","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-04 14:26:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Optimize share expansion function:"},{"line_number":8,"context_line":"If share from shrink 10G to 5G, the volume is still 10G."},{"line_number":9,"context_line":"This share`s size display is 5G, but the share extend newsize must be \u003e 10G."},{"line_number":10,"context_line":"So, I think only need to perform resize_filesystem when the share extend"},{"line_number":11,"context_line":"newsize \u003c\u003d volume size. The extension is performed only when more than volume size."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_fe12b908","line":8,"range":{"start_line":8,"start_character":3,"end_line":8,"end_character":20},"updated":"2016-11-04 07:12:14.000000000","message":"a share is shrank from","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Optimize share expansion function:"},{"line_number":8,"context_line":"If share from shrink 10G to 5G, the volume is still 10G."},{"line_number":9,"context_line":"This share`s size display is 5G, but the share extend newsize must be \u003e 10G."},{"line_number":10,"context_line":"So, I think only need to perform resize_filesystem when the share extend"},{"line_number":11,"context_line":"newsize \u003c\u003d volume size. The extension is performed only when more than volume size."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_1ecdad86","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":76},"updated":"2016-11-04 07:12:14.000000000","message":"Confusing a little bit, didn\u0027t quite get your point.","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":8,"context_line":"If share from shrink 10G to 5G, the volume is still 10G."},{"line_number":9,"context_line":"This share`s size display is 5G, but the share extend newsize must be \u003e 10G."},{"line_number":10,"context_line":"So, I think only need to perform resize_filesystem when the share extend"},{"line_number":11,"context_line":"newsize \u003c\u003d volume size. The extension is performed only when more than volume size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7e49b446445b8005e2eb23e1d439354eb24915e0"},{"line_number":14,"context_line":"Close-Bug: none"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_5ef005ca","line":11,"range":{"start_line":11,"start_character":61,"end_line":11,"end_character":65},"updated":"2016-11-04 07:12:14.000000000","message":"new size larger","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":8,"context_line":"If share from shrink 10G to 5G, the volume is still 10G."},{"line_number":9,"context_line":"This share`s size display is 5G, but the share extend newsize must be \u003e 10G."},{"line_number":10,"context_line":"So, I think only need to perform resize_filesystem when the share extend"},{"line_number":11,"context_line":"newsize \u003c\u003d volume size. The extension is performed only when more than volume size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7e49b446445b8005e2eb23e1d439354eb24915e0"},{"line_number":14,"context_line":"Close-Bug: none"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_3ee35107","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":28},"updated":"2016-11-04 07:12:14.000000000","message":"volume","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"00953e5b41dc001268a93078aa0c3b277bb45a3b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"newsize \u003c\u003d volume size. The extension is performed only when more than volume size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7e49b446445b8005e2eb23e1d439354eb24915e0"},{"line_number":14,"context_line":"Close-Bug: none"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_e10dbce9","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":15},"updated":"2016-11-04 07:59:05.000000000","message":"Bug should be filed in launchpad and mentioned here.","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e84f68b1dc2af42fa9b620e010a7be0c837a3f7e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoyang Zhang \u003cxiaoyang.zhang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-14 17:10:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix extend operation of shrinked share in generic driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a share is shrank from 10G to 5G, the volume is still 10G."},{"line_number":10,"context_line":"This share`s size display is 5G, but the share extend newsize"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_ef2f57a5","line":7,"range":{"start_line":7,"start_character":56,"end_line":7,"end_character":57},"updated":"2016-11-14 10:09:20.000000000","message":"not needed","commit_id":"207ba19bf5920ea93f5dc8579ae21190330dfea2"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                                        volume,"},{"line_number":676,"context_line":"                                        new_size\u003dnew_size)"},{"line_number":677,"context_line":"            except exception.Invalid:"},{"line_number":678,"context_line":"                raise exception.ShareShrinkingPossibleDataLoss("},{"line_number":679,"context_line":"                    share_id\u003dshare[\u0027id\u0027])"},{"line_number":680,"context_line":"            except Exception as e:"},{"line_number":681,"context_line":"                msg \u003d _(\"Cannot extend share: %s\") % six.text_type(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_bea4c1b9","line":678,"range":{"start_line":678,"start_character":32,"end_line":678,"end_character":62},"updated":"2016-11-04 07:12:14.000000000","message":"this\u0027s extension process, why raise this exception?","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7e57cecf27a4e3582eca9383824ae82bc22dd950","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            except exception.Invalid:"},{"line_number":678,"context_line":"                raise exception.ShareShrinkingPossibleDataLoss("},{"line_number":679,"context_line":"                    share_id\u003dshare[\u0027id\u0027])"},{"line_number":680,"context_line":"            except Exception as e:"},{"line_number":681,"context_line":"                msg \u003d _(\"Cannot extend share: %s\") % six.text_type(e)"},{"line_number":682,"context_line":"                raise exception.Invalid(msg)"},{"line_number":683,"context_line":"        else:"},{"line_number":684,"context_line":"            self._detach_volume(self.admin_context, share, server_details)"},{"line_number":685,"context_line":"            volume \u003d self._extend_volume(self.admin_context, volume, new_size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_3e919153","line":682,"range":{"start_line":680,"start_character":12,"end_line":682,"end_character":44},"updated":"2016-11-04 07:12:14.000000000","message":"actually, I think no need to catch exceptions here, just let upper caller handle exceptions like before.","commit_id":"04c245bc1c5738e2b977af93d1acb4282bb6b271"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e84f68b1dc2af42fa9b620e010a7be0c837a3f7e","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        helper.disable_access_for_maintenance(server_details, share[\u0027name\u0027])"},{"line_number":669,"context_line":"        self._unmount_device(share, server_details)"},{"line_number":670,"context_line":"        volume \u003d self._get_volume(self.admin_context, share[\u0027id\u0027])"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        if int(new_size) \u003e volume[\u0027size\u0027]:"},{"line_number":673,"context_line":"            self._detach_volume(self.admin_context, share, server_details)"},{"line_number":674,"context_line":"            volume \u003d self._extend_volume(self.admin_context, volume, new_size)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"            volume \u003d self._attach_volume("},{"line_number":677,"context_line":"                self.admin_context,"},{"line_number":678,"context_line":"                share,"},{"line_number":679,"context_line":"                server_details[\u0027instance_id\u0027],"},{"line_number":680,"context_line":"                volume)"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"        self._resize_filesystem(server_details, volume)"},{"line_number":683,"context_line":"        self._mount_device(share, server_details, volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_326d34cd","line":680,"range":{"start_line":671,"start_character":0,"end_line":680,"end_character":23},"updated":"2016-11-14 10:09:20.000000000","message":"I agree that this makes sense. On the other side the question is why isn\u0027t this handled already in the API level?","commit_id":"207ba19bf5920ea93f5dc8579ae21190330dfea2"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"e84f68b1dc2af42fa9b620e010a7be0c837a3f7e","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"            assert_called_once_with(srv_details, \u0027test_share\u0027)"},{"line_number":1718,"context_line":"        self._helper_nfs.restore_access_after_maintenance.\\"},{"line_number":1719,"context_line":"            assert_called_once_with(srv_details, \u0027test_share\u0027)"},{"line_number":1720,"context_line":"        self.assertTrue(self._driver._resize_filesystem.called)"},{"line_number":1721,"context_line":""},{"line_number":1722,"context_line":"    def test_extend_volume(self):"},{"line_number":1723,"context_line":"        fake_volume \u003d {\u0027id\u0027: \u0027fake\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_525c68ed","line":1720,"updated":"2016-11-14 10:09:20.000000000","message":"Would be better to check  that _detach_volume isn\u0027t called like: self.assertFalse(self._driver._detach_volume.called)\nand mock it above.","commit_id":"207ba19bf5920ea93f5dc8579ae21190330dfea2"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"5c27af8d7726c8db274ee2cd4d7335ef402663fe","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"            \u0027share_proto\u0027: \u0027NFS\u0027,"},{"line_number":1690,"context_line":"            \u0027name\u0027: \u0027test_share\u0027,"},{"line_number":1691,"context_line":"        }"},{"line_number":1692,"context_line":"        new_size \u003d 123"},{"line_number":1693,"context_line":"        srv_details \u003d self.server[\u0027backend_details\u0027]"},{"line_number":1694,"context_line":"        self.mock_object("},{"line_number":1695,"context_line":"            self._driver.service_instance_manager,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_9ac1b483","line":1692,"range":{"start_line":1692,"start_character":8,"end_line":1692,"end_character":16},"updated":"2016-11-15 09:26:28.000000000","message":"should also cover the situation that new size equals to volume size.","commit_id":"b7f5058a1b40f2b817807fdf4e38f95e97e8c44c"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"46d51a407479426c1caf5fb346c683d382a68b54","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"        self.assertFalse(self._driver._attach_volume.called)"},{"line_number":1726,"context_line":"        self.assertTrue(self._driver._resize_filesystem.called)"},{"line_number":1727,"context_line":""},{"line_number":1728,"context_line":"    def test_extend_share_equ_volume_size(self):"},{"line_number":1729,"context_line":"        fake_volume \u003d {"},{"line_number":1730,"context_line":"            \"name\": \"fake\","},{"line_number":1731,"context_line":"            \"size\": 123,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_324092a5","line":1728,"range":{"start_line":1728,"start_character":8,"end_line":1728,"end_character":41},"updated":"2016-11-16 09:35:21.000000000","message":"you could use @ddt to merge test_extend_share_lss_volume_size and test_extend_share_equ_volume_size to one method, cause these two methods almost the same, just have parameter difference.","commit_id":"5b6808e8811d9ea1f6802cb821c219c992f199a5"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"465a084eafdd6c8f558c8cbe372e2589ed0f2e5c","unresolved":false,"context_lines":[{"line_number":1725,"context_line":"        self.assertFalse(self._driver._attach_volume.called)"},{"line_number":1726,"context_line":"        self.assertTrue(self._driver._resize_filesystem.called)"},{"line_number":1727,"context_line":""},{"line_number":1728,"context_line":"    def test_extend_share_equ_volume_size(self):"},{"line_number":1729,"context_line":"        fake_volume \u003d {"},{"line_number":1730,"context_line":"            \"name\": \"fake\","},{"line_number":1731,"context_line":"            \"size\": 123,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_1fc1bd2e","line":1728,"range":{"start_line":1728,"start_character":8,"end_line":1728,"end_character":41},"in_reply_to":"7a77a97e_324092a5","updated":"2016-11-16 19:49:31.000000000","message":"+1","commit_id":"5b6808e8811d9ea1f6802cb821c219c992f199a5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1b0d3262056f19eb53d8b70ca6a131fe8fee9db","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"        self.assertTrue(self._driver._resize_filesystem.called)"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    @ddt.data(130, 123)"},{"line_number":1683,"context_line":"    def test_extend_share_leq_volume_size(self, volume_size):"},{"line_number":1684,"context_line":"        fake_volume \u003d {"},{"line_number":1685,"context_line":"            \"name\": \"fake\","},{"line_number":1686,"context_line":"            \"size\": volume_size,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_bc707b73","line":1683,"range":{"start_line":1683,"start_character":8,"end_line":1683,"end_character":41},"updated":"2016-11-18 12:47:08.000000000","message":"This test better to combine with above one. Because these two have a lot of overlapping code.","commit_id":"d4771ebbc7645f06e1626eaedbc1e782a10c7b6d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1b0d3262056f19eb53d8b70ca6a131fe8fee9db","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"            fake_share, srv_details)"},{"line_number":1718,"context_line":"        self._driver._get_volume.assert_called_once_with("},{"line_number":1719,"context_line":"            mock.ANY, fake_share[\u0027id\u0027])"},{"line_number":1720,"context_line":"        self._helper_nfs.disable_access_for_maintenance.\\"},{"line_number":1721,"context_line":"            assert_called_once_with(srv_details, \u0027test_share\u0027)"},{"line_number":1722,"context_line":"        self._helper_nfs.restore_access_after_maintenance.\\"},{"line_number":1723,"context_line":"            assert_called_once_with(srv_details, \u0027test_share\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_bc495b33","line":1720,"range":{"start_line":1720,"start_character":55,"end_line":1720,"end_character":57},"updated":"2016-11-18 12:47:08.000000000","message":"To avoid such line breaks just save results of mocking objects to vars. Example:\n\n\"\"\"\nmock__unmount_device \u003d self.mock_object(\n    self._driver, \u0027_unmount_device\u0027)\n...\nmock__unmount_device.assert_called_once_with(...)\n\"\"\"","commit_id":"d4771ebbc7645f06e1626eaedbc1e782a10c7b6d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1b0d3262056f19eb53d8b70ca6a131fe8fee9db","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            mock.ANY, fake_share[\u0027id\u0027])"},{"line_number":1720,"context_line":"        self._helper_nfs.disable_access_for_maintenance.\\"},{"line_number":1721,"context_line":"            assert_called_once_with(srv_details, \u0027test_share\u0027)"},{"line_number":1722,"context_line":"        self._helper_nfs.restore_access_after_maintenance.\\"},{"line_number":1723,"context_line":"            assert_called_once_with(srv_details, \u0027test_share\u0027)"},{"line_number":1724,"context_line":"        self.assertFalse(self._driver._detach_volume.called)"},{"line_number":1725,"context_line":"        self.assertFalse(self._driver._extend_volume.called)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_3c646bb7","line":1722,"range":{"start_line":1722,"start_character":57,"end_line":1722,"end_character":59},"updated":"2016-11-18 12:47:08.000000000","message":"ditto","commit_id":"d4771ebbc7645f06e1626eaedbc1e782a10c7b6d"}],"releasenotes/notes/bug-1639188-fix-extend-operation-of-shrinked-share-in-generic-driver-5c7f82faefaf26ea.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d9a30109f8350ff3c4cb9ef7a24af099e8d28c09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Changed share extend logic in the Generic driver to"},{"line_number":4,"context_line":"    extend of shrinked share to equal or less than volume size."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_1fd084f5","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":63},"updated":"2016-11-18 12:09:29.000000000","message":"I think the following language is much clearer:\n  - In the Generic driver, the backing volume size is\n    greater than the share size when the shar has been\n    shrunk.  So share extend logic in this driver was\n    changed to only extend the backing volume if its\n    size is less than the size of the new, extended share.","commit_id":"d4771ebbc7645f06e1626eaedbc1e782a10c7b6d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1b0d3262056f19eb53d8b70ca6a131fe8fee9db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Changed share extend logic in the Generic driver to"},{"line_number":4,"context_line":"    extend of shrinked share to equal or less than volume size."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_3c32aba7","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":63},"in_reply_to":"7a77a97e_1fd084f5","updated":"2016-11-18 12:47:08.000000000","message":"+1, for case of copy-paste of comment -\u003e\ns/when the shar has been/when the share has been/","commit_id":"d4771ebbc7645f06e1626eaedbc1e782a10c7b6d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"95c9b71255bcb075a8673acd97c014d39cc15bae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Changed share extend logic in the Generic driver to"},{"line_number":4,"context_line":"    extend of shrinked share to equal or less than volume size."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_31a1ecf8","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":63},"in_reply_to":"7a77a97e_3c32aba7","updated":"2016-11-18 15:36:00.000000000","message":"Thanks for the catch on \u0027shar\u0027 :)","commit_id":"d4771ebbc7645f06e1626eaedbc1e782a10c7b6d"}]}