)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"28bc18ecfc93c668d59ca2b963acc43ccbb0e921","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoyang \u003cxiaoyang.zhang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-04 13:19:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix share-service VM restart problem:"},{"line_number":8,"context_line":"The /etc/mtab have nfsd mount information. If copy to /etc/fstab will"},{"line_number":9,"context_line":"cause the VM system to restart stuck."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_fbd48bbe","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":37},"updated":"2016-11-04 06:40:30.000000000","message":"remove :","commit_id":"e9400133ac84ef51d8e971cd5aa602c71e20e759"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"28bc18ecfc93c668d59ca2b963acc43ccbb0e921","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-04 13:19:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix share-service VM restart problem:"},{"line_number":8,"context_line":"The /etc/mtab have nfsd mount information. If copy to /etc/fstab will"},{"line_number":9,"context_line":"cause the VM system to restart stuck."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I67602bae1f928769d768008deca7bd0f2fef1ac2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_9bec6f94","line":8,"updated":"2016-11-04 06:40:30.000000000","message":"add a newline before this line.","commit_id":"e9400133ac84ef51d8e971cd5aa602c71e20e759"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"28bc18ecfc93c668d59ca2b963acc43ccbb0e921","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-04 13:19:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix share-service VM restart problem:"},{"line_number":8,"context_line":"The /etc/mtab have nfsd mount information. If copy to /etc/fstab will"},{"line_number":9,"context_line":"cause the VM system to restart stuck."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I67602bae1f928769d768008deca7bd0f2fef1ac2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_bbf1336d","line":8,"range":{"start_line":8,"start_character":14,"end_line":8,"end_character":18},"updated":"2016-11-04 06:40:30.000000000","message":"has","commit_id":"e9400133ac84ef51d8e971cd5aa602c71e20e759"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"28bc18ecfc93c668d59ca2b963acc43ccbb0e921","unresolved":false,"context_lines":[{"line_number":9,"context_line":"cause the VM system to restart stuck."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I67602bae1f928769d768008deca7bd0f2fef1ac2"},{"line_number":12,"context_line":"Close-Bug: none"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_3b50c35e","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":15},"updated":"2016-11-04 06:40:30.000000000","message":"why this bug info is None?","commit_id":"e9400133ac84ef51d8e971cd5aa602c71e20e759"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix share-service VM restart problem"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The /etc/mtab has nfsd mount information. If copy to /etc/fstab will"},{"line_number":10,"context_line":"cause the VM system to restart stuck."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I67602bae1f928769d768008deca7bd0f2fef1ac2"},{"line_number":13,"context_line":"Close-Bug: #1639662"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a77a97e_e576d204","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":37},"updated":"2016-11-18 14:07:40.000000000","message":"Suggest:\n\nThe /etc/mtab file may have mount information such as \u0027nfsd\u0027\nthat if copied to /etc/fstab will cause the share server to\nhang when rebooted.\n\nUpdate /etc/fstab with exactly the newly mounted or unmounted\nshares rather than simply overwriting /etc/fstab with /etc/mtab.","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"977995492bd37070a1aff38069e0c79191c78250","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            self._ssh_exec("},{"line_number":307,"context_line":"                server_details,"},{"line_number":308,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/nfsd/d\\\u0027 \u0027,"},{"line_number":309,"context_line":"                 const.MOUNT_FILE_TEMP,"},{"line_number":310,"context_line":"                 \u0027\u0026\u0026\u0027,"},{"line_number":311,"context_line":"                 \u0027sudo\u0027, \u0027cp\u0027, const.MOUNT_FILE_TEMP, const.MOUNT_FILE],"},{"line_number":312,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_83084f93","line":309,"range":{"start_line":308,"start_character":18,"end_line":309,"end_character":39},"updated":"2016-11-07 08:08:41.000000000","message":"1) I don\u0027t think you should do \u0027sed -i\u0027 (edit in place) of\n/etc/mtab.  mtab is a system file, not intended for humans\nto edit.  On many types of linux system it is a symlink to\na read-only file under /proc.\n\n2) Is the nfsd line the only one that is causing a problem\nwhen copied to /etc/fstab?  If so, I think that\u0027s just an\naccidental fact about the reference service image.  Lots\nof linux systems have other kinds of lines in /etc/mtab that\nshould not be included in /etc/fstab.\n\n3) I think the correct fix here is to positively\nselect the desired mounts out of /etc/mtab and append them to\n/etc/fstab if they aren\u0027t already there.","commit_id":"36138cc74fe8f11b88de10a29498b29bbbd29148"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"53407d39036164e839b5855db78f129ba1bbb1df","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            self._ssh_exec("},{"line_number":307,"context_line":"                server_details,"},{"line_number":308,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/nfsd/d\\\u0027 \u0027,"},{"line_number":309,"context_line":"                const.MOUNT_FILE_TEMP,"},{"line_number":310,"context_line":"                \u0027\u0026\u0026\u0027,"},{"line_number":311,"context_line":"                \u0027sudo\u0027, \u0027cp\u0027, const.MOUNT_FILE_TEMP, const.MOUNT_FILE],"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_3e5c1bed","line":308,"range":{"start_line":308,"start_character":25,"end_line":308,"end_character":53},"updated":"2016-11-14 11:27:10.000000000","message":"If fix bug this way, then it should be applied to destination file only and after \"copy\" but before \"remount\" operations.\n\nBut as Tom mentioned in previous patch-set. It is better to filter out all mounts that do not satisfy criteria manila uses for its shares.","commit_id":"c9dbf774f9997982a84cc428c45df9bd33b29b0e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45625828beaad8ef144cf412e781864916c8e7cf","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        return False"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _add_mount_permanently(self, share_id, server_details):"},{"line_number":304,"context_line":"        \"\"\"Sync temporary and permanent files for mounted filesystems.\"\"\""},{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            self._ssh_exec("},{"line_number":307,"context_line":"                server_details,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_e1aba287","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":73},"updated":"2016-11-16 10:58:22.000000000","message":"Doc string should be updated.","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45625828beaad8ef144cf412e781864916c8e7cf","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            self._ssh_exec("},{"line_number":307,"context_line":"                server_details,"},{"line_number":308,"context_line":"                [\u0027cat\u0027, const.MOUNT_FILE_TEMP, \u0027|\u0027, \u0027grep\u0027, share_id,"},{"line_number":309,"context_line":"                 \u0027|\u0027, \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027, const.MOUNT_FILE],"},{"line_number":310,"context_line":"            )"},{"line_number":311,"context_line":"        except exception.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_c6023c09","line":308,"range":{"start_line":308,"start_character":16,"end_line":308,"end_character":69},"updated":"2016-11-16 10:58:22.000000000","message":"\u0027grep \u003cshare_id const.MOUNT_FILE_TEMP\u003e\u0027 will do the same thing with one less OS process spawned.","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45625828beaad8ef144cf412e781864916c8e7cf","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                      server_details[\u0027instance_id\u0027])"},{"line_number":314,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            # Remount it to avoid postponed point of failure"},{"line_number":317,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"},{"line_number":318,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":319,"context_line":"            LOG.error(_LE(\"Failed to mount all shares on server \u0027%s\u0027.\"),"},{"line_number":320,"context_line":"                      server_details[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_21cf5a80","line":317,"range":{"start_line":316,"start_character":11,"end_line":317,"end_character":67},"updated":"2016-11-16 10:58:22.000000000","message":"Since you have already mounted the new filesystem, is there a reason to run \u0027mount -a\u0027 ?  Maybe I don\u0027t understand the \u0027postponed point of failure\u0027?","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45625828beaad8ef144cf412e781864916c8e7cf","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _remove_mount_permanently(self, share_id, server_details):"},{"line_number":324,"context_line":"        \"\"\"Sync temporary and permanent files for mounted filesystems.\"\"\""},{"line_number":325,"context_line":"        try:"},{"line_number":326,"context_line":"            self._ssh_exec("},{"line_number":327,"context_line":"                server_details,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_e10f22df","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":73},"updated":"2016-11-16 10:58:22.000000000","message":"Doc string should be updated.","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45625828beaad8ef144cf412e781864916c8e7cf","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                      server_details[\u0027instance_id\u0027])"},{"line_number":335,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":336,"context_line":"        try:"},{"line_number":337,"context_line":"            # Remount it to avoid postponed point of failure"},{"line_number":338,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"},{"line_number":339,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":340,"context_line":"            LOG.error(_LE(\"Failed to mount all shares on server \u0027%s\u0027.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_c1ece62b","line":337,"range":{"start_line":337,"start_character":22,"end_line":337,"end_character":25},"updated":"2016-11-16 10:58:22.000000000","message":"Remount *what*?  You just unmounted ...","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45625828beaad8ef144cf412e781864916c8e7cf","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":336,"context_line":"        try:"},{"line_number":337,"context_line":"            # Remount it to avoid postponed point of failure"},{"line_number":338,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"},{"line_number":339,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":340,"context_line":"            LOG.error(_LE(\"Failed to mount all shares on server \u0027%s\u0027.\"),"},{"line_number":341,"context_line":"                      server_details[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_a1052ac3","line":338,"range":{"start_line":338,"start_character":12,"end_line":338,"end_character":67},"updated":"2016-11-16 10:58:22.000000000","message":"Offhand I don\u0027t understand the point of doing this when removing a mount permanently.  The kernels mount tables\n(and /etc/mtab) should already be up to date since you did\nthe unmount before running this method.","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7b26c2be8c6431829172b06f2653c0867dc0e149","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        try:"},{"line_number":306,"context_line":"            self._ssh_exec("},{"line_number":307,"context_line":"                server_details,"},{"line_number":308,"context_line":"                [\u0027cat\u0027, const.MOUNT_FILE_TEMP, \u0027|\u0027, \u0027grep\u0027, share_id,"},{"line_number":309,"context_line":"                 \u0027|\u0027, \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027, const.MOUNT_FILE],"},{"line_number":310,"context_line":"            )"},{"line_number":311,"context_line":"        except exception.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_deeac4ab","line":308,"range":{"start_line":308,"start_character":16,"end_line":308,"end_character":69},"updated":"2016-11-17 12:52:46.000000000","message":"Just invoke \u0027grep\u0027 on const.MOUNT_FILE_TEMP rather than using \u0027cat\u0027.   See my remark in patch set 4.","commit_id":"5196aaa29dcdceae0cf0d9aff3ae3adbbde46212"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7b26c2be8c6431829172b06f2653c0867dc0e149","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            # Test remount to avoid postponed point of failure"},{"line_number":317,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"},{"line_number":318,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":319,"context_line":"            LOG.error(_LE(\"Failed to mount all shares on server \u0027%s\u0027.\"),"},{"line_number":320,"context_line":"                      server_details[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_fecce06b","line":317,"range":{"start_line":317,"start_character":12,"end_line":317,"end_character":67},"updated":"2016-11-17 12:52:46.000000000","message":"Please address my remark in patch set 4 questioning why the \u0027mount -a\u0027 is needed.","commit_id":"5196aaa29dcdceae0cf0d9aff3ae3adbbde46212"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7b26c2be8c6431829172b06f2653c0867dc0e149","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":336,"context_line":"        try:"},{"line_number":337,"context_line":"            # Test remount to avoid postponed point of failure"},{"line_number":338,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"},{"line_number":339,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":340,"context_line":"            LOG.error(_LE(\"Failed to mount all shares on server \u0027%s\u0027.\"),"},{"line_number":341,"context_line":"                      server_details[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_9ee4cce1","line":338,"range":{"start_line":338,"start_character":12,"end_line":338,"end_character":67},"updated":"2016-11-17 12:52:46.000000000","message":"Please address my remark in patch set 4 questioning why the \u0027mount -a\u0027 is needed.","commit_id":"5196aaa29dcdceae0cf0d9aff3ae3adbbde46212"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                      server_details[\u0027instance_id\u0027])"},{"line_number":314,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            # Test remount to avoid postponed point of failure"},{"line_number":317,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"},{"line_number":318,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":319,"context_line":"            LOG.error(_LE(\"Failed to mount all shares on server \u0027%s\u0027.\"),"},{"line_number":320,"context_line":"                      server_details[\u0027instance_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_3ab9ce2e","line":317,"range":{"start_line":316,"start_character":12,"end_line":317,"end_character":67},"updated":"2016-11-18 14:07:40.000000000","message":"Your change of the comment helps me understand why you\nare doing this \u0027mount -a\u0027.  I\u0027m still not sure it\u0027s\nnecessary or useful.  Is there a failure scenario here\nthat we\u0027re really protecting against?  Either the code\nabove to update /etc/fstab works and the OS/NFS code works\nor we\u0027re in big trouble all the time, so I\u0027m not sure the point of testing it now.\n\nBut maybe I\u0027m missing something ...","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                      server_details[\u0027instance_id\u0027])"},{"line_number":335,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":336,"context_line":"        try:"},{"line_number":337,"context_line":"            # Test remount to avoid postponed point of failure"},{"line_number":338,"context_line":"            self._ssh_exec(server_details, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027])"},{"line_number":339,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":340,"context_line":"            LOG.error(_LE(\"Failed to mount all shares on server \u0027%s\u0027.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_da7e1a69","line":337,"range":{"start_line":337,"start_character":12,"end_line":337,"end_character":62},"updated":"2016-11-18 14:07:40.000000000","message":"ditto","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0af7b1809f04233b569fe12c49b85c8e84bdb729","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def _remove_mount_permanently(self, share_id, server_details):"},{"line_number":317,"context_line":"        \"\"\"Remove mount permanently for mounted filesystems.\"\"\""},{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            self._ssh_exec("},{"line_number":320,"context_line":"                server_details,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_2853efe2","line":317,"range":{"start_line":317,"start_character":36,"end_line":317,"end_character":39},"updated":"2016-11-23 16:31:14.000000000","message":"from?","commit_id":"6d0e42ae85415e27a7a4b9501ecc2004fe6a93a6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0af7b1809f04233b569fe12c49b85c8e84bdb729","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                 const.MOUNT_FILE],"},{"line_number":323,"context_line":"            )"},{"line_number":324,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":325,"context_line":"            LOG.error(_LE(\"Failed to remove mount permanently on \""},{"line_number":326,"context_line":"                          \"server \u0027%s\u0027.\"),"},{"line_number":327,"context_line":"                      server_details[\u0027instance_id\u0027])"},{"line_number":328,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _mount_device(self, share, server_details, volume):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_c8f99bca","line":327,"range":{"start_line":325,"start_character":12,"end_line":327,"end_character":52},"updated":"2016-11-23 16:31:14.000000000","message":"Better to mention \"which\" mount, not only \"where\".","commit_id":"6d0e42ae85415e27a7a4b9501ecc2004fe6a93a6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99578dfa726b06f3336d00565a0c0f6b38a35447","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":312,"context_line":"            LOG.error(_LE(\"Failed to add \u0027Share-%(share_id)s\u0027 mount \""},{"line_number":313,"context_line":"                          \"permanently on server \u0027%(instance_id)s\u0027.\"),"},{"line_number":314,"context_line":"                      {\"share_id\": share_id, "},{"line_number":315,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":316,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_c592344b","line":314,"range":{"start_line":314,"start_character":44,"end_line":314,"end_character":45},"updated":"2016-11-24 13:08:21.000000000","message":"Remove this space, pep8 fails on it.","commit_id":"820f41c11e39696681bee2408a9fbcac787f54f9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99578dfa726b06f3336d00565a0c0f6b38a35447","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                      {\"share_id\": share_id, "},{"line_number":315,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":316,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _remove_mount_permanently(self, share_id, server_details):"},{"line_number":319,"context_line":"        \"\"\"Remove mount permanently from mounted filesystems.\"\"\""},{"line_number":320,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_c5e074cf","line":317,"updated":"2016-11-24 13:08:21.000000000","message":"Also, why \"sudo mount -a\" command was removed?","commit_id":"820f41c11e39696681bee2408a9fbcac787f54f9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df835d6857f250fcbe1750aac74efe8d3de646d3","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                      {\"share_id\": share_id, "},{"line_number":315,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":316,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _remove_mount_permanently(self, share_id, server_details):"},{"line_number":319,"context_line":"        \"\"\"Remove mount permanently from mounted filesystems.\"\"\""},{"line_number":320,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_6a08482e","line":317,"in_reply_to":"5a74a57a_aaffc0a8","updated":"2016-11-24 14:46:26.000000000","message":"I asked question, because I suspect following scenario will fail:\n\n1) create share\n2) allow access\n3) mount share\n4) deny access\n\nExpected: mounted share will lose connection.\nAssumption: mounted share will NOT lose connection until explicit unmount command.","commit_id":"820f41c11e39696681bee2408a9fbcac787f54f9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"53725f683c2620acf492ba420c34ccd720e82440","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                      {\"share_id\": share_id, "},{"line_number":315,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":316,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _remove_mount_permanently(self, share_id, server_details):"},{"line_number":319,"context_line":"        \"\"\"Remove mount permanently from mounted filesystems.\"\"\""},{"line_number":320,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_aaffc0a8","line":317,"in_reply_to":"5a74a57a_c5e074cf","updated":"2016-11-24 14:38:00.000000000","message":"Valeriy, please see my question/remark questioning if this command is needed in PS#7.  Do we need it after all?","commit_id":"820f41c11e39696681bee2408a9fbcac787f54f9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99578dfa726b06f3336d00565a0c0f6b38a35447","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":327,"context_line":"            LOG.error(_LE(\"Failed to remove \u0027Share-%(share_id)s\u0027 mount \""},{"line_number":328,"context_line":"                          \"permanently on server \u0027%(instance_id)s\u0027.\"),"},{"line_number":329,"context_line":"                      {\"share_id\": share_id, "},{"line_number":330,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":331,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_25a4c8a4","line":329,"range":{"start_line":329,"start_character":44,"end_line":329,"end_character":45},"updated":"2016-11-24 13:08:21.000000000","message":"ditto","commit_id":"820f41c11e39696681bee2408a9fbcac787f54f9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"53725f683c2620acf492ba420c34ccd720e82440","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        except exception.ProcessExecutionError as e:"},{"line_number":327,"context_line":"            LOG.error(_LE(\"Failed to remove \u0027Share-%(share_id)s\u0027 mount \""},{"line_number":328,"context_line":"                          \"permanently on server \u0027%(instance_id)s\u0027.\"),"},{"line_number":329,"context_line":"                      {\"share_id\": share_id, "},{"line_number":330,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":331,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_ea2ff83b","line":329,"range":{"start_line":329,"start_character":44,"end_line":329,"end_character":45},"in_reply_to":"5a74a57a_25a4c8a4","updated":"2016-11-24 14:38:00.000000000","message":"ditto","commit_id":"820f41c11e39696681bee2408a9fbcac787f54f9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0071290109ff79e547b47914ce0c1b9c7b4f70ee","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                          \"permanently on server \u0027%(instance_id)s\u0027.\"),"},{"line_number":314,"context_line":"                      {\"share_id\": share_id,"},{"line_number":315,"context_line":"                       \"instance_id\": server_details[\u0027instance_id\u0027]})"},{"line_number":316,"context_line":"            raise exception.ShareBackendException(msg\u003dsix.text_type(e))"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _remove_mount_permanently(self, share_id, server_details):"},{"line_number":319,"context_line":"        \"\"\"Remove mount permanently from mounted filesystems.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_66922c4d","line":316,"updated":"2016-12-09 15:16:52.000000000","message":"Question asked in [1] is still valid.\n\n[1] https://review.openstack.org/#/c/393594/10..11/manila/share/drivers/generic.py","commit_id":"a44892b51719f951487ef14b88cd356a9bb1d392"},{"author":{"_account_id":20160,"name":"haobing1","email":"bing.hao@easystack.cn","username":"haobing"},"change_message_id":"6c3cd291808d984f9f57bbb99c086bae22f59318","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        try:"},{"line_number":291,"context_line":"            self._ssh_exec("},{"line_number":292,"context_line":"                server_details,"},{"line_number":293,"context_line":"                [\u0027grep\u0027, share_id, const.MOUNT_FILE_TEMP,"},{"line_number":294,"context_line":"                 \u0027|\u0027, \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027, const.MOUNT_FILE],"},{"line_number":295,"context_line":"            )"},{"line_number":296,"context_line":"        except exception.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_75715bde","line":293,"range":{"start_line":293,"start_character":18,"end_line":293,"end_character":22},"updated":"2018-05-21 15:18:11.000000000","message":"I think we should add the manila-rootwrap command filter in share.filters file.","commit_id":"73836305f33ba1ffa6f04b2d0e311c9fb88d75cc"},{"author":{"_account_id":20160,"name":"haobing1","email":"bing.hao@easystack.cn","username":"haobing"},"change_message_id":"6c3cd291808d984f9f57bbb99c086bae22f59318","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        try:"},{"line_number":312,"context_line":"            self._ssh_exec("},{"line_number":313,"context_line":"                server_details,"},{"line_number":314,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/%s/d\\\u0027\u0027 % share_id,"},{"line_number":315,"context_line":"                 const.MOUNT_FILE],"},{"line_number":316,"context_line":"            )"},{"line_number":317,"context_line":"        except exception.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_555f7f40","line":314,"range":{"start_line":314,"start_character":26,"end_line":314,"end_character":29},"updated":"2018-05-21 15:18:11.000000000","message":"ditto","commit_id":"73836305f33ba1ffa6f04b2d0e311c9fb88d75cc"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"12ed8d925f302f900a549215700d4721bc8a962e","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    def test_add_mount_permanently(self):"},{"line_number":566,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027)"},{"line_number":567,"context_line":"        self._driver._add_mount_permanently(self.share.id, self.server)"},{"line_number":568,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":569,"context_line":"            mock.call("},{"line_number":570,"context_line":"                self.server,"},{"line_number":571,"context_line":"                [\u0027cat\u0027, const.MOUNT_FILE_TEMP, \u0027|\u0027, \u0027grep\u0027, self.share.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_21f80549","line":568,"range":{"start_line":568,"start_character":31,"end_line":568,"end_character":40},"updated":"2016-11-17 08:27:09.000000000","message":"assert_has_calls","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"12ed8d925f302f900a549215700d4721bc8a962e","unresolved":false,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    def test_add_mount_permanently_raise_error_on_mount(self):"},{"line_number":593,"context_line":"        def raise_error_on_mount(*args, **kwargs):"},{"line_number":594,"context_line":"            if args[1][0] \u003d\u003d \u0027cat\u0027:"},{"line_number":595,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_a1b9757b","line":594,"range":{"start_line":594,"start_character":15,"end_line":594,"end_character":34},"updated":"2016-11-17 08:27:09.000000000","message":"args[1][1] \u003d\u003d \u0027mount\u0027","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"12ed8d925f302f900a549215700d4721bc8a962e","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            self.share.id, "},{"line_number":603,"context_line":"            self.server"},{"line_number":604,"context_line":"        )"},{"line_number":605,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":606,"context_line":"            mock.call("},{"line_number":607,"context_line":"                self.server,"},{"line_number":608,"context_line":"                [\u0027cat\u0027, const.MOUNT_FILE_TEMP, \u0027|\u0027, \u0027grep\u0027, self.share.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_a1a25549","line":605,"range":{"start_line":605,"start_character":31,"end_line":605,"end_character":40},"updated":"2016-11-17 08:27:09.000000000","message":"assert_has_calls","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"12ed8d925f302f900a549215700d4721bc8a962e","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    def test_remove_mount_permanently(self):"},{"line_number":615,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027)"},{"line_number":616,"context_line":"        self._driver._remove_mount_permanently(self.share.id, self.server)"},{"line_number":617,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":618,"context_line":"            mock.call("},{"line_number":619,"context_line":"                self.server,"},{"line_number":620,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/%s/d\\\u0027\u0027 % self.share.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_616afdef","line":617,"range":{"start_line":617,"start_character":31,"end_line":617,"end_character":40},"updated":"2016-11-17 08:27:09.000000000","message":"assert_has_calls","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"12ed8d925f302f900a549215700d4721bc8a962e","unresolved":false,"context_lines":[{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def test_remove_mount_permanently_raise_error_on_mount(self):"},{"line_number":642,"context_line":"        def raise_error_on_mount(*args, **kwargs):"},{"line_number":643,"context_line":"            if args[1][1] \u003d\u003d \u0027sed\u0027:"},{"line_number":644,"context_line":"                raise exception.ProcessExecutionError()"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_81339961","line":643,"range":{"start_line":643,"start_character":30,"end_line":643,"end_character":33},"updated":"2016-11-17 08:27:09.000000000","message":"mount","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"12ed8d925f302f900a549215700d4721bc8a962e","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            self.share.id, "},{"line_number":652,"context_line":"            self.server"},{"line_number":653,"context_line":"        )"},{"line_number":654,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":655,"context_line":"            mock.call("},{"line_number":656,"context_line":"                self.server,"},{"line_number":657,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/%s/d\\\u0027\u0027 % self.share.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_c17911ca","line":654,"range":{"start_line":654,"start_character":31,"end_line":654,"end_character":40},"updated":"2016-11-17 08:27:09.000000000","message":"assert_has_calls","commit_id":"2753ebccc28d6ea616deeff30234712cdff13601"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7b26c2be8c6431829172b06f2653c0867dc0e149","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    def test_add_mount_permanently(self):"},{"line_number":566,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027)"},{"line_number":567,"context_line":"        self._driver._add_mount_permanently(self.share.id, self.server)"},{"line_number":568,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":569,"context_line":"            mock.call("},{"line_number":570,"context_line":"                self.server,"},{"line_number":571,"context_line":"                [\u0027cat\u0027, const.MOUNT_FILE_TEMP, \u0027|\u0027, \u0027grep\u0027, self.share.id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_5e16b4f1","line":568,"range":{"start_line":568,"start_character":31,"end_line":568,"end_character":41},"updated":"2016-11-17 12:52:46.000000000","message":"assert_has_calls ?  Yingzhe\u0027s remark from patch set 4 ...","commit_id":"5196aaa29dcdceae0cf0d9aff3ae3adbbde46212"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7b26c2be8c6431829172b06f2653c0867dc0e149","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            self.share.id,"},{"line_number":603,"context_line":"            self.server"},{"line_number":604,"context_line":"        )"},{"line_number":605,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":606,"context_line":"            mock.call("},{"line_number":607,"context_line":"                self.server,"},{"line_number":608,"context_line":"                [\u0027cat\u0027, const.MOUNT_FILE_TEMP, \u0027|\u0027, \u0027grep\u0027, self.share.id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_5ec4f45d","line":605,"range":{"start_line":605,"start_character":31,"end_line":605,"end_character":41},"updated":"2016-11-17 12:52:46.000000000","message":"assert_has_calls ?","commit_id":"5196aaa29dcdceae0cf0d9aff3ae3adbbde46212"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7b26c2be8c6431829172b06f2653c0867dc0e149","unresolved":false,"context_lines":[{"line_number":613,"context_line":"    def test_remove_mount_permanently(self):"},{"line_number":614,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027)"},{"line_number":615,"context_line":"        self._driver._remove_mount_permanently(self.share.id, self.server)"},{"line_number":616,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":617,"context_line":"            mock.call("},{"line_number":618,"context_line":"                self.server,"},{"line_number":619,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/%s/d\\\u0027\u0027 % self.share.id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_9ea84c8f","line":616,"range":{"start_line":616,"start_character":31,"end_line":616,"end_character":40},"updated":"2016-11-17 12:52:46.000000000","message":"assert_has_calls?","commit_id":"5196aaa29dcdceae0cf0d9aff3ae3adbbde46212"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7b26c2be8c6431829172b06f2653c0867dc0e149","unresolved":false,"context_lines":[{"line_number":650,"context_line":"            self.share.id,"},{"line_number":651,"context_line":"            self.server"},{"line_number":652,"context_line":"        )"},{"line_number":653,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":654,"context_line":"            mock.call("},{"line_number":655,"context_line":"                self.server,"},{"line_number":656,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/%s/d\\\u0027\u0027 % self.share.id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_1ecefc81","line":653,"range":{"start_line":653,"start_character":31,"end_line":653,"end_character":40},"updated":"2016-11-17 12:52:46.000000000","message":"assert_has_calls?","commit_id":"5196aaa29dcdceae0cf0d9aff3ae3adbbde46212"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":569,"context_line":"            mock.call("},{"line_number":570,"context_line":"                self.server,"},{"line_number":571,"context_line":"                [\u0027grep\u0027, share_id, const.MOUNT_FILE_TEMP,"},{"line_number":572,"context_line":"                 \u0027|\u0027, \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027, const.MOUNT_FILE],"},{"line_number":573,"context_line":"            ),"},{"line_number":574,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_ba0b1e7c","line":571,"range":{"start_line":571,"start_character":25,"end_line":571,"end_character":33},"updated":"2016-11-18 14:07:40.000000000","message":"self.share.id ?","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        )"},{"line_number":586,"context_line":"        self._driver._ssh_exec.assert_called_once_with("},{"line_number":587,"context_line":"            self.server,"},{"line_number":588,"context_line":"            [\u0027grep\u0027, share_id, const.MOUNT_FILE_TEMP,"},{"line_number":589,"context_line":"             \u0027|\u0027, \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027, const.MOUNT_FILE],"},{"line_number":590,"context_line":"        )"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_5cc927ab","line":588,"range":{"start_line":588,"start_character":21,"end_line":588,"end_character":29},"updated":"2016-11-18 14:07:40.000000000","message":"self.share.id ?","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":606,"context_line":"            mock.call("},{"line_number":607,"context_line":"                self.server,"},{"line_number":608,"context_line":"                [\u0027grep\u0027, share_id, const.MOUNT_FILE_TEMP,"},{"line_number":609,"context_line":"                 \u0027|\u0027, \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027, const.MOUNT_FILE],"},{"line_number":610,"context_line":"            ),"},{"line_number":611,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027mount\u0027, \u0027-a\u0027]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_1c3a4f99","line":608,"range":{"start_line":608,"start_character":25,"end_line":608,"end_character":33},"updated":"2016-11-18 14:07:40.000000000","message":"self.share.id ?","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":613,"context_line":"    def test_remove_mount_permanently(self):"},{"line_number":614,"context_line":"        self.mock_object(self._driver, \u0027_ssh_exec\u0027)"},{"line_number":615,"context_line":"        self._driver._remove_mount_permanently(self.share.id, self.server)"},{"line_number":616,"context_line":"        self._driver._ssh_exec.has_calls("},{"line_number":617,"context_line":"            mock.call("},{"line_number":618,"context_line":"                self.server,"},{"line_number":619,"context_line":"                [\u0027sudo\u0027, \u0027sed\u0027, \u0027-i\u0027, \u0027\\\u0027/%s/d\\\u0027\u0027 % self.share.id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_c5e55609","line":616,"range":{"start_line":616,"start_character":31,"end_line":616,"end_character":40},"updated":"2016-11-18 14:07:40.000000000","message":"assert_has_calls\n\nmock.Mock() does not have a \u0027has_calls\u0027 method.  Because mock is \"magic\" it manufactures such a method for you which will pass with any \"call\" arguments passed to it.  Try it - change the \u0027mount\u0027 below to \u0027umount\u0027 and it will still pass.\n\nmock.Mock() does have an assert_has_calls method that will\nwork if the proper calls are made and otherwise assert.  Note that it takes a *list* of calls as argument.","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"}],"releasenotes/notes/bug-1639662-fix-share-service-VM-restart-problem-1110f9133cc294e8.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7eac5a8874ae0aa74eb68bb21f8ecd3e85358ea5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Changed sync mount permanently logic in the Generic driver to"},{"line_number":4,"context_line":"    actively selected from the /etc/mtab to copy to the /etc/fstab."},{"line_number":5,"context_line":"    Add remove mount permanently function."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a77a97e_6581e2fa","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":42},"updated":"2016-11-18 14:07:40.000000000","message":"Suggest:\n\n  - Changed sync mount permanently logic in the Generic\n    driver to select the newly mounted share from /etc/mtab\n    and insert it into /etc/fstab.  Added corresponding\n    remove mount permanently functionality.","commit_id":"3cb04dda7d618c5c4219536a5c784e2ffee95c28"}]}
