)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf7e84308215feefe586a5886ce9b52147c5bed8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Mellado \u003cdmellado@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-10 10:10:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Duplicate remote_client into Manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies tempest remote_client into manila code in order to"},{"line_number":10,"context_line":"get rid of the non-core tempest dependency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_c561c2d4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"updated":"2016-11-11 16:14:41.000000000","message":"Would be great to see \"tempest\" word in the commit topic. Right now it is too ambiguous.\nFor example:\n\n\"\"\"\n[Tempest] Port remote_client into plugin\n\"\"\"\n\nAnd description in imperative mood:\n\n\"\"\"\nManila tempest plugin uses tempest\u0027s \"remote_client\",\nwhich is not part of stable interface. And it will not\nbe stable, because %reason%. So, port it to manila\u0027s\ntempest plugin to drop dependency on it.\n\"\"\"","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"a3bd32a23a31adc8c22e55eff854510c08935567","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Mellado \u003cdmellado@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-10 10:10:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Duplicate remote_client into Manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies tempest remote_client into manila code in order to"},{"line_number":10,"context_line":"get rid of the non-core tempest dependency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_81a66e51","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"in_reply_to":"9a629dbe_c561c2d4","updated":"2016-11-16 11:07:35.000000000","message":"Done","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf7e84308215feefe586a5886ce9b52147c5bed8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Duplicate remote_client into Manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies tempest remote_client into manila code in order to"},{"line_number":10,"context_line":"get rid of the non-core tempest dependency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: bp/tempest-no-deps"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_c54aa254","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":43},"updated":"2016-11-11 16:14:41.000000000","message":"Why it cannot be moved to stable interface?","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"060e6b2318d8e4ee5b13649e39b594d1f94deabb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Duplicate remote_client into Manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies tempest remote_client into manila code in order to"},{"line_number":10,"context_line":"get rid of the non-core tempest dependency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: bp/tempest-no-deps"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_822ef7f8","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":23},"updated":"2016-11-11 03:41:32.000000000","message":"how do you define non-core here? And as Tom asked, is there a reason to do this?","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"a3bd32a23a31adc8c22e55eff854510c08935567","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Duplicate remote_client into Manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit copies tempest remote_client into manila code in order to"},{"line_number":10,"context_line":"get rid of the non-core tempest dependency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: bp/tempest-no-deps"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_21783ac4","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":43},"in_reply_to":"9a629dbe_c54aa254","updated":"2016-11-16 11:07:35.000000000","message":"Will be submitting a new patchset with the explanations","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"dcfd72708b650741734527f0bc7f9d684fc5ffe7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Tempest] Port remote_client into Manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila tempest test make use of remote_client, which won\u0027t be making it"},{"line_number":10,"context_line":"to the stable interfaces, as it imports tempest code which would result"},{"line_number":11,"context_line":"in a circular dependency."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_7fbabcc1","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":19},"updated":"2016-11-16 16:35:47.000000000","message":"s/test/tests","commit_id":"f66074982f7422eeef0de6821e31977ae15a2e0c"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"dcfd72708b650741734527f0bc7f9d684fc5ffe7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Tempest] Port remote_client into Manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila tempest test make use of remote_client, which won\u0027t be making it"},{"line_number":10,"context_line":"to the stable interfaces, as it imports tempest code which would result"},{"line_number":11,"context_line":"in a circular dependency."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit ports a reduced version of remote_client into manila code in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_9f84f8d4","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":24},"updated":"2016-11-16 16:35:47.000000000","message":"Perhaps make it clear that it\u0027s the stable Tempest interfaces as this can imply that the stable interfaces are for Manila.","commit_id":"f66074982f7422eeef0de6821e31977ae15a2e0c"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"dcfd72708b650741734527f0bc7f9d684fc5ffe7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in a circular dependency."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit ports a reduced version of remote_client into manila code in"},{"line_number":14,"context_line":"order to have manila\u0027s tempest plugin to drop dependency on it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: bp/tempest-no-deps"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_bf5e1474","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":56},"updated":"2016-11-16 16:35:47.000000000","message":"\"to drop the dependency\"","commit_id":"f66074982f7422eeef0de6821e31977ae15a2e0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0e668afc3b637615af67c65814b7be7ce94a391d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This commit ports a reduced version of remote_client into manila code in"},{"line_number":14,"context_line":"order to have manila\u0027s tempest plugin to drop the dependency on it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/openstack/tempest/blob/master/tempest/common/utils/linux/remote_client.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially-Implements: bp/tempest-no-deps"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a77a97e_a0be6cab","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":96},"updated":"2016-11-19 20:52:04.000000000","message":"https://github.com/openstack/tempest/blob/4217a70/tempest/common/utils/linux/remote_client.py","commit_id":"d03b5699fd934cf6eacddb94a2e8daff8b2bff4a"}],"manila_tempest_tests/common/remote_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"307275e661d3ede7e83404971caa930f741b1cd1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import six"},{"line_number":14,"context_line":"import sys"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib.common import ssh"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_b89aaa61","line":16,"range":{"start_line":16,"start_character":28,"end_line":16,"end_character":35},"updated":"2016-11-16 16:55:49.000000000","message":"No need to rename it.","commit_id":"f66074982f7422eeef0de6821e31977ae15a2e0c"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"dcfd72708b650741734527f0bc7f9d684fc5ffe7","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def debug_ssh(function):"},{"line_number":29,"context_line":"    \"\"\"Decorator to generate extra debug info in case off SSH failure\"\"\""},{"line_number":30,"context_line":"    def wrapper(self, *args, **kwargs):"},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return function(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_3ff9244e","line":29,"range":{"start_line":29,"start_character":54,"end_line":29,"end_character":57},"updated":"2016-11-16 16:35:47.000000000","message":"s/off/of","commit_id":"f66074982f7422eeef0de6821e31977ae15a2e0c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"307275e661d3ede7e83404971caa930f741b1cd1","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, ip_address, username, password\u003dNone, pkey\u003dNone,"},{"line_number":62,"context_line":"                 server\u003dNone, servers_client\u003dNone):"},{"line_number":63,"context_line":"        \"\"\"Executes commands in a VM over ssh"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        :param ip_address: IP address to ssh to"},{"line_number":66,"context_line":"        :param username: ssh username"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_d8868612","line":63,"range":{"start_line":63,"start_character":42,"end_line":63,"end_character":45},"updated":"2016-11-16 16:55:49.000000000","message":"This \"ssh\" is not consistent with \"SSH\" on line 29. Same below.","commit_id":"f66074982f7422eeef0de6821e31977ae15a2e0c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"7f4a897bf747e8b2cde1160217d537a2a6358453","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import six"},{"line_number":14,"context_line":"import sys"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_0d47a977","line":12,"updated":"2016-11-17 15:23:42.000000000","message":"Can you add a comment here with the link to the code this copy comes from? I think that is useful to know before somebody starts to implement features on top of our copy...","commit_id":"6d160de303616ad62e714d97473a69b9e684e76c"}],"manila_tempest_tests/common/utils/linux/remote_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf7e84308215feefe586a5886ce9b52147c5bed8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        self.server \u003d server"},{"line_number":76,"context_line":"        self.servers_client \u003d servers_client"},{"line_number":77,"context_line":"        ssh_timeout \u003d CONF.validation.ssh_timeout"},{"line_number":78,"context_line":"        connect_timeout \u003d CONF.validation.connect_timeout"},{"line_number":79,"context_line":"        self.log_console \u003d CONF.compute_feature_enabled.console_output"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_ba80698c","line":77,"range":{"start_line":77,"start_character":22,"end_line":77,"end_character":37},"updated":"2016-11-11 16:14:41.000000000","message":"Is it correct to use these tempest\u0027s options? Or it won\u0027t be removed for sure?","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"a3bd32a23a31adc8c22e55eff854510c08935567","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        self.server \u003d server"},{"line_number":76,"context_line":"        self.servers_client \u003d servers_client"},{"line_number":77,"context_line":"        ssh_timeout \u003d CONF.validation.ssh_timeout"},{"line_number":78,"context_line":"        connect_timeout \u003d CONF.validation.connect_timeout"},{"line_number":79,"context_line":"        self.log_console \u003d CONF.compute_feature_enabled.console_output"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_c198661e","line":77,"range":{"start_line":77,"start_character":22,"end_line":77,"end_character":37},"in_reply_to":"9a629dbe_ba80698c","updated":"2016-11-16 11:07:35.000000000","message":"Manila\u0027s tempest test doesn\u0027t seem to be using any kind of validation option, so I\u0027ll be dropping that part out.","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bf7e84308215feefe586a5886ce9b52147c5bed8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"           This method raises an Exception when the validation fails."},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        self.ssh_client.test_connection_auth()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_hostname(self):"},{"line_number":102,"context_line":"        # Get host name using command \"hostname\""},{"line_number":103,"context_line":"        actual_hostname \u003d self.exec_command(\"hostname\").rstrip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_3ab5397d","line":100,"updated":"2016-11-11 16:14:41.000000000","message":"All methods starting with line 100 are not used. So, better to remove them.","commit_id":"f631dd6ba18be2f312952e24b932890579198824"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"a3bd32a23a31adc8c22e55eff854510c08935567","unresolved":false,"context_lines":[{"line_number":97,"context_line":"           This method raises an Exception when the validation fails."},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        self.ssh_client.test_connection_auth()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_hostname(self):"},{"line_number":102,"context_line":"        # Get host name using command \"hostname\""},{"line_number":103,"context_line":"        actual_hostname \u003d self.exec_command(\"hostname\").rstrip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_c1bf865e","line":100,"in_reply_to":"9a629dbe_3ab5397d","updated":"2016-11-16 11:07:35.000000000","message":"I do agree, I\u0027m submitting another patchset with a reduced version of the remote_client lib.","commit_id":"f631dd6ba18be2f312952e24b932890579198824"}]}