)]}'
{"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"025f15f78e6fbdfd7d7b5c96e2f83346cf42b328","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        uri \u003d self._create_share_from_snapshot(share, hnas_src_share_id,"},{"line_number":374,"context_line":"                                               snapshot)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        LOG.debug(\"Share %(share)s created successfully on path: %(uri)s.\","},{"line_number":377,"context_line":"                  {\u0027uri\u0027: uri,"},{"line_number":378,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":379,"context_line":"        return uri"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d34d9d73","line":378,"range":{"start_line":376,"start_character":8,"end_line":378,"end_character":41},"updated":"2016-11-16 11:28:12.000000000","message":"Change this msg. uri contains more information like is_admin_only and metadata. Maybe format this to show only paths?","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3600efaa8500a1cd640095a8a43457b4e4bc90f","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        uri \u003d self._create_share_from_snapshot(share, hnas_src_share_id,"},{"line_number":374,"context_line":"                                               snapshot)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        LOG.debug(\"Share %(share)s created successfully on path: %(uri)s.\","},{"line_number":377,"context_line":"                  {\u0027uri\u0027: uri,"},{"line_number":378,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":379,"context_line":"        return uri"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_f6ca8719","line":378,"range":{"start_line":376,"start_character":8,"end_line":378,"end_character":41},"in_reply_to":"7a77a97e_d34d9d73","updated":"2016-11-16 15:39:28.000000000","message":"Yes, thanks for pointing this out!","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"025f15f78e6fbdfd7d7b5c96e2f83346cf42b328","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                LOG.debug(\"CIFS share created to %(shr)s.\","},{"line_number":609,"context_line":"                          {\u0027shr\u0027: share_id})"},{"line_number":610,"context_line":"            export \u003d self._arrange_export_locations(share_proto, share_id)"},{"line_number":611,"context_line":"            return export"},{"line_number":612,"context_line":"        except exception.HNASBackendException as e:"},{"line_number":613,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":614,"context_line":"                self.hnas.vvol_delete(share_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_a6bc606d","line":611,"range":{"start_line":611,"start_character":0,"end_line":611,"end_character":25},"updated":"2016-11-16 11:28:12.000000000","message":"Before this, our return for this function was a string with the path for the new share. Now, we are returning a list of dicts, with other infos. There is no problem in changing it for other layers?","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3600efaa8500a1cd640095a8a43457b4e4bc90f","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                LOG.debug(\"CIFS share created to %(shr)s.\","},{"line_number":609,"context_line":"                          {\u0027shr\u0027: share_id})"},{"line_number":610,"context_line":"            export \u003d self._arrange_export_locations(share_proto, share_id)"},{"line_number":611,"context_line":"            return export"},{"line_number":612,"context_line":"        except exception.HNASBackendException as e:"},{"line_number":613,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":614,"context_line":"                self.hnas.vvol_delete(share_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d6602b38","line":611,"range":{"start_line":611,"start_character":0,"end_line":611,"end_character":25},"in_reply_to":"7a77a97e_a6bc606d","updated":"2016-11-16 15:39:28.000000000","message":"The above layer expects a list of dicts. For backwards compatibility, if it receives a list of strings, it converts it to the list of dicts in the DB layer. See https://github.com/openstack/manila/blob/d2cbb01669a9c7d9e24bc7eb42181da14f1577f6/manila/db/sqlalchemy/api.py#L2407","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"025f15f78e6fbdfd7d7b5c96e2f83346cf42b328","unresolved":false,"context_lines":[{"line_number":720,"context_line":"                   % share[\u0027id\u0027])"},{"line_number":721,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        if share[\u0027share_proto\u0027].lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":724,"context_line":"            path \u003d self.hnas_evs_ip + os.path.join(\u0027:/shares\u0027, hnas_share_id)"},{"line_number":725,"context_line":"        else:"},{"line_number":726,"context_line":"            path \u003d r\u0027\\\\%s\\%s\u0027 % (self.hnas_evs_ip, hnas_share_id)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        return {\u0027size\u0027: share_size, \u0027export_locations\u0027: [path]}"},{"line_number":729,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d3a11dab","line":726,"range":{"start_line":723,"start_character":0,"end_line":726,"end_character":65},"updated":"2016-11-16 11:28:12.000000000","message":"_get_export_path function here","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3600efaa8500a1cd640095a8a43457b4e4bc90f","unresolved":false,"context_lines":[{"line_number":720,"context_line":"                   % share[\u0027id\u0027])"},{"line_number":721,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        if share[\u0027share_proto\u0027].lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":724,"context_line":"            path \u003d self.hnas_evs_ip + os.path.join(\u0027:/shares\u0027, hnas_share_id)"},{"line_number":725,"context_line":"        else:"},{"line_number":726,"context_line":"            path \u003d r\u0027\\\\%s\\%s\u0027 % (self.hnas_evs_ip, hnas_share_id)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        return {\u0027size\u0027: share_size, \u0027export_locations\u0027: [path]}"},{"line_number":729,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_365ebf76","line":726,"range":{"start_line":723,"start_character":0,"end_line":726,"end_character":65},"in_reply_to":"7a77a97e_d3a11dab","updated":"2016-11-16 15:39:28.000000000","message":"nice catch! Thanks!","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"025f15f78e6fbdfd7d7b5c96e2f83346cf42b328","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        else:"},{"line_number":726,"context_line":"            path \u003d r\u0027\\\\%s\\%s\u0027 % (self.hnas_evs_ip, hnas_share_id)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        return {\u0027size\u0027: share_size, \u0027export_locations\u0027: [path]}"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def _create_snapshot(self, hnas_share_id, snapshot):"},{"line_number":731,"context_line":"        \"\"\"Creates a snapshot of share."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_b34ae1aa","line":728,"range":{"start_line":728,"start_character":37,"end_line":728,"end_character":62},"updated":"2016-11-16 11:28:12.000000000","message":"The export location for managed shares should contain the admin network ip","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3600efaa8500a1cd640095a8a43457b4e4bc90f","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        else:"},{"line_number":726,"context_line":"            path \u003d r\u0027\\\\%s\\%s\u0027 % (self.hnas_evs_ip, hnas_share_id)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        return {\u0027size\u0027: share_size, \u0027export_locations\u0027: [path]}"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def _create_snapshot(self, hnas_share_id, snapshot):"},{"line_number":731,"context_line":"        \"\"\"Creates a snapshot of share."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_7650375f","line":728,"range":{"start_line":728,"start_character":37,"end_line":728,"end_character":62},"in_reply_to":"7a77a97e_b34ae1aa","updated":"2016-11-16 15:39:28.000000000","message":"Indeed, thanks!","commit_id":"e852a0da479cd87ffe4eb49d51fccc74b550bdda"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        :param share: Share that will be created."},{"line_number":283,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":284,"context_line":"            Not used by this driver."},{"line_number":285,"context_line":"        :returns: Returns a path of EVS IP concatenate with the path"},{"line_number":286,"context_line":"            of share in the filesystem (e.g. [\u0027172.24.44.10:/shares/id\u0027] for"},{"line_number":287,"context_line":"            NFS and [\u0027\\\\172.24.44.10\\id\u0027] for CIFS)."},{"line_number":288,"context_line":"        \"\"\""},{"line_number":289,"context_line":"        LOG.debug(\"Creating share in HNAS: %(shr)s.\", {\u0027shr\u0027: share[\u0027id\u0027]})"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_eccf087d","line":287,"range":{"start_line":285,"start_character":0,"end_line":287,"end_character":52},"updated":"2016-11-16 16:07:36.000000000","message":"This needs to be updated","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        :param share: Share that will be created."},{"line_number":283,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":284,"context_line":"            Not used by this driver."},{"line_number":285,"context_line":"        :returns: Returns a path of EVS IP concatenate with the path"},{"line_number":286,"context_line":"            of share in the filesystem (e.g. [\u0027172.24.44.10:/shares/id\u0027] for"},{"line_number":287,"context_line":"            NFS and [\u0027\\\\172.24.44.10\\id\u0027] for CIFS)."},{"line_number":288,"context_line":"        \"\"\""},{"line_number":289,"context_line":"        LOG.debug(\"Creating share in HNAS: %(shr)s.\", {\u0027shr\u0027: share[\u0027id\u0027]})"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d35e6775","line":287,"range":{"start_line":285,"start_character":0,"end_line":287,"end_character":52},"in_reply_to":"7a77a97e_eccf087d","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"4c0deae619dc9f8bdecf46d00c0875dd9407dd9c","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        export_list \u003d self._create_share(share[\u0027id\u0027], share[\u0027size\u0027],"},{"line_number":294,"context_line":"                                         share[\u0027share_proto\u0027])"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        LOG.debug(\"Share %(share)s created successfully on paths: %(paths)s.\","},{"line_number":297,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":298,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_739cb3c0","line":296,"range":{"start_line":296,"start_character":59,"end_line":296,"end_character":64},"updated":"2016-11-16 17:10:48.000000000","message":"s/paths/path(s)","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        export_list \u003d self._create_share(share[\u0027id\u0027], share[\u0027size\u0027],"},{"line_number":294,"context_line":"                                         share[\u0027share_proto\u0027])"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        LOG.debug(\"Share %(share)s created successfully on paths: %(paths)s.\","},{"line_number":297,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":298,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d3eca791","line":296,"range":{"start_line":296,"start_character":59,"end_line":296,"end_character":64},"in_reply_to":"7a77a97e_739cb3c0","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            to new share."},{"line_number":364,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":365,"context_line":"            Not used by this driver."},{"line_number":366,"context_line":"        :returns: Returns a path of EVS IP concatenate with the path"},{"line_number":367,"context_line":"            of new share in the filesystem (e.g. [\u0027172.24.44.10:/shares/id\u0027])."},{"line_number":368,"context_line":"        \"\"\""},{"line_number":369,"context_line":"        LOG.debug(\"Creating a new share from snapshot: %(ss_id)s.\","},{"line_number":370,"context_line":"                  {\u0027ss_id\u0027: snapshot[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_2ccae06d","line":367,"range":{"start_line":366,"start_character":0,"end_line":367,"end_character":78},"updated":"2016-11-16 16:07:36.000000000","message":"Same","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            to new share."},{"line_number":364,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":365,"context_line":"            Not used by this driver."},{"line_number":366,"context_line":"        :returns: Returns a path of EVS IP concatenate with the path"},{"line_number":367,"context_line":"            of new share in the filesystem (e.g. [\u0027172.24.44.10:/shares/id\u0027])."},{"line_number":368,"context_line":"        \"\"\""},{"line_number":369,"context_line":"        LOG.debug(\"Creating a new share from snapshot: %(ss_id)s.\","},{"line_number":370,"context_line":"                  {\u0027ss_id\u0027: snapshot[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d3a3c74d","line":367,"range":{"start_line":366,"start_character":0,"end_line":367,"end_character":78},"in_reply_to":"7a77a97e_2ccae06d","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"4c0deae619dc9f8bdecf46d00c0875dd9407dd9c","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        export_list \u003d self._create_share_from_snapshot("},{"line_number":375,"context_line":"            share, hnas_src_share_id, snapshot)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        LOG.debug(\"Share %(share)s created successfully on paths: %(paths)s.\","},{"line_number":378,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":379,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":380,"context_line":"        return export_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_f3b0c345","line":377,"range":{"start_line":377,"start_character":59,"end_line":377,"end_character":64},"updated":"2016-11-16 17:10:48.000000000","message":"s/paths/path(s)","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        export_list \u003d self._create_share_from_snapshot("},{"line_number":375,"context_line":"            share, hnas_src_share_id, snapshot)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        LOG.debug(\"Share %(share)s created successfully on paths: %(paths)s.\","},{"line_number":378,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":379,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":380,"context_line":"        return export_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d3bae76d","line":377,"range":{"start_line":377,"start_character":59,"end_line":377,"end_character":64},"in_reply_to":"7a77a97e_f3b0c345","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        :param share: Share that will be checked."},{"line_number":387,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":388,"context_line":"            Not used by this driver."},{"line_number":389,"context_line":"        :returns: Returns a list of EVS IP concatenated with the path"},{"line_number":390,"context_line":"            of share in the filesystem (e.g. [\u0027172.24.44.10:/shares/id\u0027] for"},{"line_number":391,"context_line":"            NFS and [\u0027\\\\172.24.44.10\\id\u0027] for CIFS)."},{"line_number":392,"context_line":"        \"\"\""},{"line_number":393,"context_line":"        LOG.debug(\"Ensuring share in HNAS: %(shr)s.\", {\u0027shr\u0027: share[\u0027id\u0027]})"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_6ca218b0","line":391,"range":{"start_line":389,"start_character":0,"end_line":391,"end_character":52},"updated":"2016-11-16 16:07:36.000000000","message":"Same","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        :param share: Share that will be checked."},{"line_number":387,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":388,"context_line":"            Not used by this driver."},{"line_number":389,"context_line":"        :returns: Returns a list of EVS IP concatenated with the path"},{"line_number":390,"context_line":"            of share in the filesystem (e.g. [\u0027172.24.44.10:/shares/id\u0027] for"},{"line_number":391,"context_line":"            NFS and [\u0027\\\\172.24.44.10\\id\u0027] for CIFS)."},{"line_number":392,"context_line":"        \"\"\""},{"line_number":393,"context_line":"        LOG.debug(\"Ensuring share in HNAS: %(shr)s.\", {\u0027shr\u0027: share[\u0027id\u0027]})"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_13ad3f31","line":391,"range":{"start_line":389,"start_character":0,"end_line":391,"end_character":52},"in_reply_to":"7a77a97e_6ca218b0","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"4c0deae619dc9f8bdecf46d00c0875dd9407dd9c","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                        \"\\\\\\\\IP\\\\share_id.\")"},{"line_number":506,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        if evs_ip !\u003d self.hnas_evs_ip:"},{"line_number":509,"context_line":"            msg \u003d _(\"The EVS IP %(evs)s is not \""},{"line_number":510,"context_line":"                    \"configured.\") % {\u0027evs\u0027: evs_ip}"},{"line_number":511,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_f3144345","line":508,"range":{"start_line":508,"start_character":8,"end_line":508,"end_character":38},"updated":"2016-11-16 17:10:48.000000000","message":"The IP used in the export location when managing a share can be the \"admin network ip\"?","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                        \"\\\\\\\\IP\\\\share_id.\")"},{"line_number":506,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        if evs_ip !\u003d self.hnas_evs_ip:"},{"line_number":509,"context_line":"            msg \u003d _(\"The EVS IP %(evs)s is not \""},{"line_number":510,"context_line":"                    \"configured.\") % {\u0027evs\u0027: evs_ip}"},{"line_number":511,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_5373374d","line":508,"range":{"start_line":508,"start_character":8,"end_line":508,"end_character":38},"in_reply_to":"7a77a97e_f3144345","updated":"2016-11-16 17:30:19.000000000","message":"no","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        :param share_size: Size limit of share."},{"line_number":586,"context_line":"        :param share_proto: Protocol of share that will be created"},{"line_number":587,"context_line":"            (NFS or CIFS)"},{"line_number":588,"context_line":"        :returns: Returns a path IP:/shares/share_id for NFS or \\\\IP\\share_id"},{"line_number":589,"context_line":"            for CIFS if the export was created successfully."},{"line_number":590,"context_line":"        \"\"\""},{"line_number":591,"context_line":"        self._check_fs_mounted()"},{"line_number":592,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_4c9c7c69","line":589,"range":{"start_line":588,"start_character":0,"end_line":589,"end_character":60},"updated":"2016-11-16 16:07:36.000000000","message":"Same","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        :param share_size: Size limit of share."},{"line_number":586,"context_line":"        :param share_proto: Protocol of share that will be created"},{"line_number":587,"context_line":"            (NFS or CIFS)"},{"line_number":588,"context_line":"        :returns: Returns a path IP:/shares/share_id for NFS or \\\\IP\\share_id"},{"line_number":589,"context_line":"            for CIFS if the export was created successfully."},{"line_number":590,"context_line":"        \"\"\""},{"line_number":591,"context_line":"        self._check_fs_mounted()"},{"line_number":592,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_f35fe33e","line":589,"range":{"start_line":588,"start_character":0,"end_line":589,"end_character":60},"in_reply_to":"7a77a97e_4c9c7c69","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        :param share: Share that will be checked."},{"line_number":630,"context_line":"        :param hnas_share_id: HNAS ID of share that will be checked."},{"line_number":631,"context_line":"        :returns: Returns a path IP:/shares/share_id for NFS or \\\\IP\\share_id"},{"line_number":632,"context_line":"            for CIFS if the export is ok."},{"line_number":633,"context_line":"        \"\"\""},{"line_number":634,"context_line":"        self._check_protocol(share[\u0027id\u0027], share[\u0027share_proto\u0027])"},{"line_number":635,"context_line":"        self._check_fs_mounted()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_cc86cc12","line":632,"range":{"start_line":631,"start_character":0,"end_line":632,"end_character":41},"updated":"2016-11-16 16:07:36.000000000","message":"Same","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        :param share: Share that will be checked."},{"line_number":630,"context_line":"        :param hnas_share_id: HNAS ID of share that will be checked."},{"line_number":631,"context_line":"        :returns: Returns a path IP:/shares/share_id for NFS or \\\\IP\\share_id"},{"line_number":632,"context_line":"            for CIFS if the export is ok."},{"line_number":633,"context_line":"        \"\"\""},{"line_number":634,"context_line":"        self._check_protocol(share[\u0027id\u0027], share[\u0027share_proto\u0027])"},{"line_number":635,"context_line":"        self._check_fs_mounted()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_335a3b50","line":632,"range":{"start_line":631,"start_character":0,"end_line":632,"end_character":41},"in_reply_to":"7a77a97e_cc86cc12","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        :param share: share that will be managed."},{"line_number":712,"context_line":"        :param hnas_share_id: HNAS ID of share that will be managed."},{"line_number":713,"context_line":"        :returns: Returns a dict with size of share managed"},{"line_number":714,"context_line":"            and its export location."},{"line_number":715,"context_line":"        \"\"\""},{"line_number":716,"context_line":"        self._ensure_share(share, hnas_share_id)"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_2c78202a","line":714,"range":{"start_line":714,"start_character":27,"end_line":714,"end_character":35},"updated":"2016-11-16 16:07:36.000000000","message":"locations","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        :param share: share that will be managed."},{"line_number":712,"context_line":"        :param hnas_share_id: HNAS ID of share that will be managed."},{"line_number":713,"context_line":"        :returns: Returns a dict with size of share managed"},{"line_number":714,"context_line":"            and its export location."},{"line_number":715,"context_line":"        \"\"\""},{"line_number":716,"context_line":"        self._ensure_share(share, hnas_share_id)"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_5303370f","line":714,"range":{"start_line":714,"start_character":27,"end_line":714,"end_character":35},"in_reply_to":"7a77a97e_2c78202a","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            taken."},{"line_number":792,"context_line":"        :param snapshot: a dict from snapshot that will be copied to"},{"line_number":793,"context_line":"            new share."},{"line_number":794,"context_line":"        :returns: Returns the path for new share."},{"line_number":795,"context_line":"        \"\"\""},{"line_number":796,"context_line":"        dest_path \u003d os.path.join(\u0027/shares\u0027, share[\u0027id\u0027])"},{"line_number":797,"context_line":"        src_path \u003d os.path.join(\u0027/snapshots\u0027, src_hnas_share_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_4caabc71","line":794,"range":{"start_line":794,"start_character":0,"end_line":794,"end_character":49},"updated":"2016-11-16 16:07:36.000000000","message":"Update this","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            taken."},{"line_number":792,"context_line":"        :param snapshot: a dict from snapshot that will be copied to"},{"line_number":793,"context_line":"            new share."},{"line_number":794,"context_line":"        :returns: Returns the path for new share."},{"line_number":795,"context_line":"        \"\"\""},{"line_number":796,"context_line":"        dest_path \u003d os.path.join(\u0027/shares\u0027, share[\u0027id\u0027])"},{"line_number":797,"context_line":"        src_path \u003d os.path.join(\u0027/snapshots\u0027, src_hnas_share_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_4e31cceb","line":794,"range":{"start_line":794,"start_character":0,"end_line":794,"end_character":49},"in_reply_to":"7a77a97e_4caabc71","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"92f4064cd1f53a906930d860d94bb80c88cbbff7","unresolved":false,"context_lines":[{"line_number":838,"context_line":"                                     \u0027proto\u0027: protocol}"},{"line_number":839,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def _arrange_export_locations(self, share_proto, hnas_share_id):"},{"line_number":842,"context_line":"        export_list \u003d []"},{"line_number":843,"context_line":"        for ip in (self.hnas_evs_ip, self.hnas_admin_network_ip):"},{"line_number":844,"context_line":"            if ip:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_89e126d3","line":841,"range":{"start_line":841,"start_character":8,"end_line":841,"end_character":33},"updated":"2016-11-16 16:07:36.000000000","message":"_get_export_list or _get_export_locations is probably a better name for this method.","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a8ee31895b651ff8b4dbe56b125600121417a03","unresolved":false,"context_lines":[{"line_number":838,"context_line":"                                     \u0027proto\u0027: protocol}"},{"line_number":839,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def _arrange_export_locations(self, share_proto, hnas_share_id):"},{"line_number":842,"context_line":"        export_list \u003d []"},{"line_number":843,"context_line":"        for ip in (self.hnas_evs_ip, self.hnas_admin_network_ip):"},{"line_number":844,"context_line":"            if ip:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_6e4e8870","line":841,"range":{"start_line":841,"start_character":8,"end_line":841,"end_character":33},"in_reply_to":"7a77a97e_89e126d3","updated":"2016-11-16 17:30:19.000000000","message":"Done","commit_id":"dd8abd634e3c7359e1e627510656d5a6b2685e38"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"acaf1c095473b7a8bb0ad1609306a3f04e8a5ff8","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        LOG.debug(\"Share %(share)s created successfully on path(s): \""},{"line_number":327,"context_line":"                  \"%(paths)s.\","},{"line_number":328,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":329,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return export_list"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_aa863714","line":328,"range":{"start_line":328,"start_character":38,"end_line":328,"end_character":39},"updated":"2016-11-21 08:33:24.000000000","message":"this parenthesis is redundant.","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        LOG.debug(\"Share %(share)s created successfully on path(s): \""},{"line_number":327,"context_line":"                  \"%(paths)s.\","},{"line_number":328,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":329,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return export_list"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_1a0924de","line":328,"range":{"start_line":328,"start_character":38,"end_line":328,"end_character":39},"in_reply_to":"7a77a97e_aa863714","updated":"2016-11-21 18:34:43.000000000","message":"Done","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"acaf1c095473b7a8bb0ad1609306a3f04e8a5ff8","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        LOG.debug(\"Share %(share)s created successfully on path(s): \""},{"line_number":440,"context_line":"                  \"%(paths)s.\","},{"line_number":441,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":442,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":443,"context_line":"        return export_list"},{"line_number":444,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_ca92934b","line":441,"range":{"start_line":441,"start_character":38,"end_line":441,"end_character":39},"updated":"2016-11-21 08:33:24.000000000","message":"ditto","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        LOG.debug(\"Share %(share)s created successfully on path(s): \""},{"line_number":440,"context_line":"                  \"%(paths)s.\","},{"line_number":441,"context_line":"                  {\u0027paths\u0027: \u0027, \u0027.join(([x[\u0027path\u0027] for x in export_list])),"},{"line_number":442,"context_line":"                   \u0027share\u0027: share[\u0027id\u0027]})"},{"line_number":443,"context_line":"        return export_list"},{"line_number":444,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_5a2abc2d","line":441,"range":{"start_line":441,"start_character":38,"end_line":441,"end_character":39},"in_reply_to":"7a77a97e_ca92934b","updated":"2016-11-21 18:34:43.000000000","message":"Done","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"acaf1c095473b7a8bb0ad1609306a3f04e8a5ff8","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                self.hnas.cifs_share_add(share_id)"},{"line_number":740,"context_line":"                LOG.debug(\"CIFS share created to %(shr)s.\","},{"line_number":741,"context_line":"                          {\u0027shr\u0027: share_id})"},{"line_number":742,"context_line":"            export_list \u003d self._get_export_locations(share_proto, share_id)"},{"line_number":743,"context_line":"            return export_list"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        except exception.HNASBackendException as e:"},{"line_number":746,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_cabff35e","line":743,"range":{"start_line":742,"start_character":12,"end_line":743,"end_character":30},"updated":"2016-11-21 08:33:24.000000000","message":"maybe this code snippet could be moved out of the try-catch block, cause self._get_export_locations won\u0027t throw HNASBackendException exception.","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                self.hnas.cifs_share_add(share_id)"},{"line_number":740,"context_line":"                LOG.debug(\"CIFS share created to %(shr)s.\","},{"line_number":741,"context_line":"                          {\u0027shr\u0027: share_id})"},{"line_number":742,"context_line":"            export_list \u003d self._get_export_locations(share_proto, share_id)"},{"line_number":743,"context_line":"            return export_list"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        except exception.HNASBackendException as e:"},{"line_number":746,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_dae32904","line":743,"range":{"start_line":742,"start_character":12,"end_line":743,"end_character":30},"in_reply_to":"7a77a97e_cabff35e","updated":"2016-11-21 18:34:43.000000000","message":"Done","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"acaf1c095473b7a8bb0ad1609306a3f04e8a5ff8","unresolved":false,"context_lines":[{"line_number":953,"context_line":""},{"line_number":954,"context_line":"            else:"},{"line_number":955,"context_line":"                self.hnas.cifs_share_add(share[\u0027id\u0027])"},{"line_number":956,"context_line":"            return self._get_export_locations("},{"line_number":957,"context_line":"                share[\u0027share_proto\u0027], share[\u0027id\u0027])"},{"line_number":958,"context_line":"        except exception.HNASBackendException:"},{"line_number":959,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":960,"context_line":"                msg \u003d _LE(\u0027Failed to create share %(share_id)s from snapshot \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_8a8fbbcb","line":957,"range":{"start_line":956,"start_character":12,"end_line":957,"end_character":50},"updated":"2016-11-21 08:33:24.000000000","message":"ditto","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":953,"context_line":""},{"line_number":954,"context_line":"            else:"},{"line_number":955,"context_line":"                self.hnas.cifs_share_add(share[\u0027id\u0027])"},{"line_number":956,"context_line":"            return self._get_export_locations("},{"line_number":957,"context_line":"                share[\u0027share_proto\u0027], share[\u0027id\u0027])"},{"line_number":958,"context_line":"        except exception.HNASBackendException:"},{"line_number":959,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":960,"context_line":"                msg \u003d _LE(\u0027Failed to create share %(share_id)s from snapshot \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_555c4ded","line":957,"range":{"start_line":956,"start_character":12,"end_line":957,"end_character":50},"in_reply_to":"7a77a97e_8a8fbbcb","updated":"2016-11-21 18:34:43.000000000","message":"Done","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"acaf1c095473b7a8bb0ad1609306a3f04e8a5ff8","unresolved":false,"context_lines":[{"line_number":976,"context_line":"        for ip in (self.hnas_evs_ip, self.hnas_admin_network_ip):"},{"line_number":977,"context_line":"            if ip:"},{"line_number":978,"context_line":"                path \u003d self._get_export_path(ip, share_proto, hnas_share_id)"},{"line_number":979,"context_line":"                export_list +\u003d [{"},{"line_number":980,"context_line":"                    \"path\": path,"},{"line_number":981,"context_line":"                    \"is_admin_only\": ip \u003d\u003d self.hnas_admin_network_ip,"},{"line_number":982,"context_line":"                    \"metadata\": {},"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_ca3453fd","line":979,"range":{"start_line":979,"start_character":27,"end_line":979,"end_character":30},"updated":"2016-11-21 08:33:24.000000000","message":"why not use export_list.append({\"path\": path,...})","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":976,"context_line":"        for ip in (self.hnas_evs_ip, self.hnas_admin_network_ip):"},{"line_number":977,"context_line":"            if ip:"},{"line_number":978,"context_line":"                path \u003d self._get_export_path(ip, share_proto, hnas_share_id)"},{"line_number":979,"context_line":"                export_list +\u003d [{"},{"line_number":980,"context_line":"                    \"path\": path,"},{"line_number":981,"context_line":"                    \"is_admin_only\": ip \u003d\u003d self.hnas_admin_network_ip,"},{"line_number":982,"context_line":"                    \"metadata\": {},"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_5ad71923","line":979,"range":{"start_line":979,"start_character":27,"end_line":979,"end_character":30},"in_reply_to":"7a77a97e_ca3453fd","updated":"2016-11-21 18:34:43.000000000","message":"Done","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"}],"manila/tests/share/drivers/hitachi/hnas/test_driver.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"51a84b65fe6ba812bdf904ac98bc8f8017549365","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027share_type_id\u0027: 1,"},{"line_number":36,"context_line":"    \u0027share_network_id\u0027: \u0027bb329e24-3bdb-491d-acfd-dfe70c09b98d\u0027,"},{"line_number":37,"context_line":"    \u0027share_server_id\u0027: \u0027cc345a53-491d-acfd-3bdb-dfe70c09b98d\u0027,"},{"line_number":38,"context_line":"    \u0027export_locations\u0027: [{\u0027path\u0027: \u0027172.24.44.10:/shares/\u0027"},{"line_number":39,"context_line":"                                  \u0027aa4a7710-f326-41fb-ad18-b4ad587fc87a\u0027}],"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"share_cifs \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_7257dc57","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":75},"updated":"2016-11-18 19:15:14.000000000","message":"Should this be removed?","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027share_type_id\u0027: 1,"},{"line_number":36,"context_line":"    \u0027share_network_id\u0027: \u0027bb329e24-3bdb-491d-acfd-dfe70c09b98d\u0027,"},{"line_number":37,"context_line":"    \u0027share_server_id\u0027: \u0027cc345a53-491d-acfd-3bdb-dfe70c09b98d\u0027,"},{"line_number":38,"context_line":"    \u0027export_locations\u0027: [{\u0027path\u0027: \u0027172.24.44.10:/shares/\u0027"},{"line_number":39,"context_line":"                                  \u0027aa4a7710-f326-41fb-ad18-b4ad587fc87a\u0027}],"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"share_cifs \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_7ac3f88a","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":75},"in_reply_to":"7a77a97e_7257dc57","updated":"2016-11-21 18:34:43.000000000","message":"no","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"51a84b65fe6ba812bdf904ac98bc8f8017549365","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \u0027share_type_id\u0027: 1,"},{"line_number":49,"context_line":"    \u0027share_network_id\u0027: \u0027bb329e24-3bdb-491d-acfd-dfe70c09b98d\u0027,"},{"line_number":50,"context_line":"    \u0027share_server_id\u0027: \u0027cc345a53-491d-acfd-3bdb-dfe70c09b98d\u0027,"},{"line_number":51,"context_line":"    \u0027export_locations\u0027: [{\u0027path\u0027: \u0027\\\\\\\\172.24.44.10\\\\\u0027"},{"line_number":52,"context_line":"                                  \u0027f5cadaf2-afbe-4cc4-9021-85491b6b76f7\u0027}],"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"share_invalid_host \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_9252b865","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":75},"updated":"2016-11-18 19:15:14.000000000","message":"same","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \u0027share_type_id\u0027: 1,"},{"line_number":49,"context_line":"    \u0027share_network_id\u0027: \u0027bb329e24-3bdb-491d-acfd-dfe70c09b98d\u0027,"},{"line_number":50,"context_line":"    \u0027share_server_id\u0027: \u0027cc345a53-491d-acfd-3bdb-dfe70c09b98d\u0027,"},{"line_number":51,"context_line":"    \u0027export_locations\u0027: [{\u0027path\u0027: \u0027\\\\\\\\172.24.44.10\\\\\u0027"},{"line_number":52,"context_line":"                                  \u0027f5cadaf2-afbe-4cc4-9021-85491b6b76f7\u0027}],"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"share_invalid_host \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_9ac0d47e","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":75},"in_reply_to":"7a77a97e_9252b865","updated":"2016-11-21 18:34:43.000000000","message":"no","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"51a84b65fe6ba812bdf904ac98bc8f8017549365","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \u0027share_type_id\u0027: 1,"},{"line_number":62,"context_line":"    \u0027share_network_id\u0027: \u0027bb329e24-3bdb-491d-acfd-dfe70c09b98d\u0027,"},{"line_number":63,"context_line":"    \u0027share_server_id\u0027: \u0027cc345a53-491d-acfd-3bdb-dfe70c09b98d\u0027,"},{"line_number":64,"context_line":"    \u0027export_locations\u0027: [{\u0027path\u0027: \u0027172.24.44.10:/shares/\u0027"},{"line_number":65,"context_line":"                                  \u0027aa4a7710-f326-41fb-ad18-b4ad587fc87a\u0027}],"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"access_nfs_rw \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_b24df4c5","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":75},"updated":"2016-11-18 19:15:14.000000000","message":"same","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \u0027share_type_id\u0027: 1,"},{"line_number":62,"context_line":"    \u0027share_network_id\u0027: \u0027bb329e24-3bdb-491d-acfd-dfe70c09b98d\u0027,"},{"line_number":63,"context_line":"    \u0027share_server_id\u0027: \u0027cc345a53-491d-acfd-3bdb-dfe70c09b98d\u0027,"},{"line_number":64,"context_line":"    \u0027export_locations\u0027: [{\u0027path\u0027: \u0027172.24.44.10:/shares/\u0027"},{"line_number":65,"context_line":"                                  \u0027aa4a7710-f326-41fb-ad18-b4ad587fc87a\u0027}],"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"access_nfs_rw \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_fa3548a8","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":75},"in_reply_to":"7a77a97e_b24df4c5","updated":"2016-11-21 18:34:43.000000000","message":"no","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"}],"releasenotes/notes/bp-admin-network-hnas-9b714736e521101e.yaml":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"51a84b65fe6ba812bdf904ac98bc8f8017549365","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added admin network support to Hitachi HNAS Driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a77a97e_f27becf2","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":54},"updated":"2016-11-18 19:15:14.000000000","message":"Since you added some config parameters, shouldn\u0027t you add upgrade section?","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8b17e578e43b39cf540dcf76a5e55bd3fa6475fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added admin network support to Hitachi HNAS Driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a77a97e_3a40a007","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":54},"in_reply_to":"7a77a97e_f27becf2","updated":"2016-11-21 18:34:43.000000000","message":"Done","commit_id":"99b04a77cc9ea461d5b62287e613ff7438c0c77c"}]}
