)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"808f3d68f894b1da5af876db8fbf85799cb6d1d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong data type in migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The`deleted` column in volume_type_extra_specs was as a boolean;"},{"line_number":10,"context_line":"The same column in share_type_extra_specs is an integer. However,"},{"line_number":11,"context_line":"the code migrating from volume_types to share_types"},{"line_number":12,"context_line":"assumes them to be vice-versa. This breaks downgrading from that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_b7af507c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":12},"updated":"2016-11-22 07:03:30.000000000","message":"missing a space between words.","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40a14db90ab646d9d60a67b6e2b7d8601c554a3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong data type in migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The`deleted` column in volume_type_extra_specs was as a boolean;"},{"line_number":10,"context_line":"The same column in share_type_extra_specs is an integer. However,"},{"line_number":11,"context_line":"the code migrating from volume_types to share_types"},{"line_number":12,"context_line":"assumes them to be vice-versa. This breaks downgrading from that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_c085c259","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":12},"in_reply_to":"7a77a97e_b7af507c","updated":"2016-11-24 13:21:57.000000000","message":"Done","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"}],"manila/db/migrations/alembic/versions/38e632621e5a_change_volume_type_to_share_type.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ee5ad5f3a0bd1563e44597176fb9cea132502a06","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            \u0027updated_at\u0027: es.updated_at,"},{"line_number":133,"context_line":"            \u0027deleted_at\u0027: es.deleted_at,"},{"line_number":134,"context_line":"            \u0027deleted\u0027: deleted,"},{"line_number":135,"context_line":"            \u0027id\u0027: es.id,"},{"line_number":136,"context_line":"            data_to[0] + \u0027_type_id\u0027: getattr(es, data_from[0] + \u0027_type_id\u0027),"},{"line_number":137,"context_line":"            data_to[1] + \u0027key\u0027: getattr(es, data_from[1] + \u0027key\u0027),"},{"line_number":138,"context_line":"            data_to[1] + \u0027value\u0027: getattr(es, data_from[1] + \u0027value\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_9a8534af","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":24},"updated":"2016-11-21 17:37:41.000000000","message":"You also need to delete this line if you want PostgreSQL test pass [1].\n\n[1] http://logs.openstack.org/10/400310/2/check/gate-manila-python34-db/564b3af/testr_results.html.gz","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e85dfe00c0354c472b8ab2a4462ef792c76cb11","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            \u0027updated_at\u0027: es.updated_at,"},{"line_number":133,"context_line":"            \u0027deleted_at\u0027: es.deleted_at,"},{"line_number":134,"context_line":"            \u0027deleted\u0027: deleted,"},{"line_number":135,"context_line":"            \u0027id\u0027: es.id,"},{"line_number":136,"context_line":"            data_to[0] + \u0027_type_id\u0027: getattr(es, data_from[0] + \u0027_type_id\u0027),"},{"line_number":137,"context_line":"            data_to[1] + \u0027key\u0027: getattr(es, data_from[1] + \u0027key\u0027),"},{"line_number":138,"context_line":"            data_to[1] + \u0027value\u0027: getattr(es, data_from[1] + \u0027value\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_a51298b2","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":24},"in_reply_to":"7a77a97e_9a8534af","updated":"2016-11-24 13:19:44.000000000","message":"Wow, good catch, no point copying the volume_type_extra_specs id into share_type_extra_specs when an integer PK field; it has  autoincrement\u003dTrue set on it by default","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"808f3d68f894b1da5af876db8fbf85799cb6d1d2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":137,"context_line":"                \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":138,"context_line":"                \u0027name\u0027: \u0027vol-type-B\u0027,"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            },"},{"line_number":141,"context_line":"        ]"},{"line_number":142,"context_line":"        for idx, volume_type in enumerate(volume_types):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_3790a095","line":139,"updated":"2016-11-22 07:03:30.000000000","message":"redundant empty line","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e85dfe00c0354c472b8ab2a4462ef792c76cb11","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":137,"context_line":"                \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":138,"context_line":"                \u0027name\u0027: \u0027vol-type-B\u0027,"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            },"},{"line_number":141,"context_line":"        ]"},{"line_number":142,"context_line":"        for idx, volume_type in enumerate(volume_types):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_4521c4b3","line":139,"in_reply_to":"7a77a97e_3790a095","updated":"2016-11-24 13:19:44.000000000","message":"Done","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"808f3d68f894b1da5af876db8fbf85799cb6d1d2","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            for es in engine.execute(share_types_specs_table.select())"},{"line_number":187,"context_line":"            if es[\u0027share_type_id\u0027] in self.share_type_ids"},{"line_number":188,"context_line":"        ]"},{"line_number":189,"context_line":"        self.test_case.assertEqual(4, len(extra_specs))"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def check_downgrade(self, engine):"},{"line_number":192,"context_line":"        # Verify table transformations"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_3776e03e","line":189,"updated":"2016-11-22 07:03:30.000000000","message":"it better check if the deleted column values as expected after upgrade.","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e85dfe00c0354c472b8ab2a4462ef792c76cb11","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            for es in engine.execute(share_types_specs_table.select())"},{"line_number":187,"context_line":"            if es[\u0027share_type_id\u0027] in self.share_type_ids"},{"line_number":188,"context_line":"        ]"},{"line_number":189,"context_line":"        self.test_case.assertEqual(4, len(extra_specs))"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def check_downgrade(self, engine):"},{"line_number":192,"context_line":"        # Verify table transformations"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_25d20801","line":189,"in_reply_to":"7a77a97e_3776e03e","updated":"2016-11-24 13:19:44.000000000","message":"I am verifying if the share_type_id matches (see Line 187), why bother verifying the internal data? Don\u0027t see value in it, unless we expecting to have UUID collisions in this set of unit tests?","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"808f3d68f894b1da5af876db8fbf85799cb6d1d2","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            for es in engine.execute(volume_types_specs_table.select())"},{"line_number":211,"context_line":"            if es[\u0027volume_type_id\u0027] in self.share_type_ids"},{"line_number":212,"context_line":"        ]"},{"line_number":213,"context_line":"        self.test_case.assertEqual(4, len(extra_specs))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"@map_to_migration(\u00271f0bd302c1a6\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_f7a2a899","line":213,"updated":"2016-11-22 07:03:30.000000000","message":"it better check if the deleted column values as expected after downgrade.","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e85dfe00c0354c472b8ab2a4462ef792c76cb11","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            for es in engine.execute(volume_types_specs_table.select())"},{"line_number":211,"context_line":"            if es[\u0027volume_type_id\u0027] in self.share_type_ids"},{"line_number":212,"context_line":"        ]"},{"line_number":213,"context_line":"        self.test_case.assertEqual(4, len(extra_specs))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"@map_to_migration(\u00271f0bd302c1a6\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_45cd445c","line":213,"in_reply_to":"7a77a97e_f7a2a899","updated":"2016-11-24 13:19:44.000000000","message":"same","commit_id":"4adf98cbd22fc42a1f70dd393d6b1c4203016d89"}]}
