)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"63849d0a5d95245e4750ed40a3f16691bccf557c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     bailinzhang \u003czhang.bailin@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-22 16:57:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace six.iteritems/iterkeys with dict.items()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.As mentioned in [1], we should avoid using six.iteritems"},{"line_number":10,"context_line":"to achieve iterators. We can use dict.items instead, as it will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_639a53c7","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":30},"updated":"2016-11-22 09:22:11.000000000","message":"looks like you only modified six.iteritems, how about six.iterkeys and six.itervalues?","commit_id":"61bad11e6fcc2afa350078f198819e491bcb835d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"63849d0a5d95245e4750ed40a3f16691bccf557c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.As mentioned in [1], we should avoid using six.iteritems"},{"line_number":10,"context_line":"to achieve iterators. We can use dict.items instead, as it will"},{"line_number":11,"context_line":"return iterators in PY3 as well. And dict.items"},{"line_number":12,"context_line":"2.In py2, the performance about list should be negligible,"},{"line_number":13,"context_line":"see the link [2]."},{"line_number":14,"context_line":"[1] https://wiki.openstack.org/wiki/Python3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_28583a56","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":47},"updated":"2016-11-22 09:22:11.000000000","message":"?","commit_id":"61bad11e6fcc2afa350078f198819e491bcb835d"}],"manila/tests/data/test_helper.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7612140ac6a0fd9d0569bec41db70a7b509ed1d8","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        data_copy_helper.CONF.data_node_access_ip \u003d \u0027fake\u0027"},{"line_number":127,"context_line":"        data_copy_helper.CONF.data_node_access_admin_user \u003d \u0027fake\u0027"},{"line_number":128,"context_line":"        expected \u003d [{"},{"line_number":129,"context_line":"            \u0027access_type\u0027: six.next(mapping..items())[0],"},{"line_number":130,"context_line":"            \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":131,"context_line":"            \u0027access_to\u0027: \u0027fake\u0027,"},{"line_number":132,"context_line":"        }]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_8de23500","line":129,"range":{"start_line":129,"start_character":43,"end_line":129,"end_character":45},"updated":"2016-11-22 12:14:52.000000000","message":".","commit_id":"e036d64cb9367438d211bd8ef4912aca42a7bb12"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b74a404c89dbba7462355f11d309a2b14cc25cd7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        data_copy_helper.CONF.data_node_access_ip \u003d \u0027fake\u0027"},{"line_number":127,"context_line":"        data_copy_helper.CONF.data_node_access_admin_user \u003d \u0027fake\u0027"},{"line_number":128,"context_line":"        expected \u003d [{"},{"line_number":129,"context_line":"            \u0027access_type\u0027: six.next(mapping..items())[0],"},{"line_number":130,"context_line":"            \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":131,"context_line":"            \u0027access_to\u0027: \u0027fake\u0027,"},{"line_number":132,"context_line":"        }]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d3468e4e","line":129,"range":{"start_line":129,"start_character":27,"end_line":129,"end_character":35},"updated":"2016-11-22 12:43:39.000000000","message":"six.next cannot be used here anymore, cause mapping.items() does not return an iterator.","commit_id":"e036d64cb9367438d211bd8ef4912aca42a7bb12"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c2d7058f4a6f63a417fb10b27a6b95235d759fa2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        data_copy_helper.CONF.data_node_access_ip \u003d \u0027fake\u0027"},{"line_number":127,"context_line":"        data_copy_helper.CONF.data_node_access_admin_user \u003d \u0027fake\u0027"},{"line_number":128,"context_line":"        expected \u003d [{"},{"line_number":129,"context_line":"            \u0027access_type\u0027: six.next(mapping.items())[0],"},{"line_number":130,"context_line":"            \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":131,"context_line":"            \u0027access_to\u0027: \u0027fake\u0027,"},{"line_number":132,"context_line":"        }]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_d74eb795","line":129,"range":{"start_line":129,"start_character":27,"end_line":129,"end_character":35},"updated":"2016-11-23 06:32:45.000000000","message":"please check the UT error, what mapping.items() returns is not an iterator, cannot use six.next.","commit_id":"f9c0408ea77acb0a6f8d479c2cd83673158bb23b"}]}
