)]}'
{"contrib/ci/common.sh":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"be718f7729f3e526aae495a33a08be2db3a8c82b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        GENERIC_DRIVER\u003d\u0027manila.share.drivers.generic.GenericShareDriver\u0027"},{"line_number":43,"context_line":"        DHSS\u003d$(iniget $MANILA_CONF $driver_group driver_handles_share_servers)"},{"line_number":44,"context_line":"        if [[ $SHARE_DRIVER \u003d\u003d $GENERIC_DRIVER \u0026\u0026 $(trueorfalse False DHSS) \u003d\u003d False ]]; then"},{"line_number":45,"context_line":"            # Wait for service VM availability"},{"line_number":46,"context_line":"            source /opt/stack/new/devstack/openrc admin demo"},{"line_number":47,"context_line":"            vm_ip\u003d$(iniget $MANILA_CONF $driver_group service_net_name_or_ip)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            # Check availability"},{"line_number":50,"context_line":"            manila_check_service_vm_availability $vm_ip"},{"line_number":51,"context_line":"        fi"},{"line_number":52,"context_line":"    done"},{"line_number":53,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a74a57a_d96361af","line":50,"range":{"start_line":45,"start_character":1,"end_line":50,"end_character":55},"updated":"2016-11-29 13:11:53.000000000","message":"I like this cleanup!","commit_id":"3d18cbdee32993f666d319c1824af09158b0bf4b"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a453569f91a4f37583ff96789119a273162f66b","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                \"export_location_metadata_example\": \"example\","},{"line_number":243,"context_line":"            },"},{"line_number":244,"context_line":"        }]"},{"line_number":245,"context_line":"        private_address \u003d server_details.get("},{"line_number":246,"context_line":"            \"admin_ip\", server_details.get(\"ip\"))"},{"line_number":247,"context_line":"        if private_address:"},{"line_number":248,"context_line":"            admin_location \u003d location.replace("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_aded518d","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":23},"updated":"2016-12-01 19:21:05.000000000","message":"I don\u0027t agree with this variable name. \"Private\" makes me think of private network, which is exactly what you are not using here in all cases, such as the DHSS\u003dTrue mode. You are either using the admin_net, or the VM \"ip\", which I assume is a private IP. \n\nAlso, this logic looks weird from DHSS\u003dTrue perspective, where if admin_net is not configured, it will use the VM IP from private network and say admin_only\u003dTrue, which is not True. It will not break CI because it has admin_net configured, but it would be confusing to debug as why the Data Service would be trying to mount a share with private IP saying it is admin_only.\n\nAlso, please add some comments here. As I said, logic looks confusing now, and variable name should be changed.","commit_id":"5c5eab8859c6088d4bc85132809887587168b120"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"804f615496994f1c64e72357ead369b7deba45bc","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                \"export_location_metadata_example\": \"example\","},{"line_number":243,"context_line":"            },"},{"line_number":244,"context_line":"        }]"},{"line_number":245,"context_line":"        private_address \u003d server_details.get("},{"line_number":246,"context_line":"            \"admin_ip\", server_details.get(\"ip\"))"},{"line_number":247,"context_line":"        if private_address:"},{"line_number":248,"context_line":"            admin_location \u003d location.replace("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_ed472249","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":23},"in_reply_to":"3a71b18c_2d2dc1a7","updated":"2016-12-02 11:40:00.000000000","message":"Done","commit_id":"5c5eab8859c6088d4bc85132809887587168b120"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a519b3fbd752fbcddf82007a7d7d8033107dcde2","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                \"export_location_metadata_example\": \"example\","},{"line_number":243,"context_line":"            },"},{"line_number":244,"context_line":"        }]"},{"line_number":245,"context_line":"        private_address \u003d server_details.get("},{"line_number":246,"context_line":"            \"admin_ip\", server_details.get(\"ip\"))"},{"line_number":247,"context_line":"        if private_address:"},{"line_number":248,"context_line":"            admin_location \u003d location.replace("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_2d2dc1a7","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":23},"in_reply_to":"3a71b18c_aded518d","updated":"2016-12-01 19:28:08.000000000","message":"I agree that as written this is hard to figure out.","commit_id":"5c5eab8859c6088d4bc85132809887587168b120"}]}
