)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0405d9ade1c6a70d13f79901f24fe4004b501048","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        # Use the same name for broadcast domain as for the IPspace since they"},{"line_number":615,"context_line":"        # need to be 1-1 and the default for both is the same name, \u0027Default\u0027."},{"line_number":616,"context_line":"        domain \u003d ipspace"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        port_info \u003d self._get_broadcast_domain_for_port(node, port)"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_d2632540","line":616,"range":{"start_line":616,"start_character":17,"end_line":616,"end_character":24},"updated":"2016-12-18 19:36:51.000000000","message":"something that confused me when going through the controller\u0027s domains after playing with this change is the naming. I agree it was bad when we had hardcoded the name, but could we use a better name for the domain. I suggest\n\n domain \u003d re.sub(r\u0027ipspace\u0027, \u0027domain\u0027, ipspace)\n\nThis will apply in the non-default cases.","commit_id":"43a9e93074d584442d9b5f19d7ad7c88ea89e515"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"13d0ed154ff12a5de04a48d23c176caa8f9f20af","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        # Use the same name for broadcast domain as for the IPspace since they"},{"line_number":615,"context_line":"        # need to be 1-1 and the default for both is the same name, \u0027Default\u0027."},{"line_number":616,"context_line":"        domain \u003d ipspace"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        port_info \u003d self._get_broadcast_domain_for_port(node, port)"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_c07b3828","line":616,"range":{"start_line":616,"start_character":17,"end_line":616,"end_character":24},"in_reply_to":"1a6eadb0_d2632540","updated":"2016-12-19 12:39:07.000000000","message":"Good suggestion.","commit_id":"43a9e93074d584442d9b5f19d7ad7c88ea89e515"}],"releasenotes/notes/bug-1646603-netapp-broadcast-domains-411a626d38835177.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0405d9ade1c6a70d13f79901f24fe4004b501048","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - Changed NetApp cDOT driver when running with DHSS\u003dTrue to maintain"},{"line_number":3,"context_line":"    a 1-1 relation between IPSpaces and broadcast domains."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_125e7d76","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":6},"updated":"2016-12-18 19:36:51.000000000","message":"nit: missing separator on top\n\n---\nfixes:","commit_id":"43a9e93074d584442d9b5f19d7ad7c88ea89e515"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"13d0ed154ff12a5de04a48d23c176caa8f9f20af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - Changed NetApp cDOT driver when running with DHSS\u003dTrue to maintain"},{"line_number":3,"context_line":"    a 1-1 relation between IPSpaces and broadcast domains."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_20730c4f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":6},"in_reply_to":"1a6eadb0_125e7d76","updated":"2016-12-19 12:39:07.000000000","message":"Thanks. will fix.","commit_id":"43a9e93074d584442d9b5f19d7ad7c88ea89e515"}]}
