)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cf164efd24ca225855cc795cab0bd21730821b4b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    4. Support in manilaclient(328932)"},{"line_number":17,"context_line":"    5. Seneraio tests"},{"line_number":18,"context_line":"    6. Documentation"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I96d3389262e9829b8b4344870cdf5c76abd22828"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_5f2eb543","line":19,"updated":"2016-12-05 11:40:40.000000000","message":"Add:\n\nPartial-Implements: blueprint support-ipv6-access","commit_id":"c4fca0ba20a99fa841f9945e740b505a3fb1f691"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    2. Report IPv4 capability in current drivers(this)"},{"line_number":15,"context_line":"    3. Support IPv6 in huawei driver"},{"line_number":16,"context_line":"    4. Support in manilaclient(328932)"},{"line_number":17,"context_line":"    5. Seneraio tests"},{"line_number":18,"context_line":"    6. Documentation"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partial-Implements: blueprint support-ipv6-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a6eadb0_6855ab1b","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":21},"updated":"2016-12-14 11:02:46.000000000","message":"Scenario tests","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    2. Report IPv4 capability in current drivers(this)"},{"line_number":15,"context_line":"    3. Support IPv6 in huawei driver"},{"line_number":16,"context_line":"    4. Support in manilaclient(328932)"},{"line_number":17,"context_line":"    5. Seneraio tests"},{"line_number":18,"context_line":"    6. Documentation"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partial-Implements: blueprint support-ipv6-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a6eadb0_dc48388a","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":21},"in_reply_to":"1a6eadb0_6855ab1b","updated":"2016-12-14 13:13:43.000000000","message":"Done","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b6e0212375d4920f93d65c9cbee6315f18954bf2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Report IPv4 capabilities for IP drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Please read spec for design detail:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/362786/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The patch list:"},{"line_number":13,"context_line":"    1. Support IPv6 in allow_access\u0026dummy,generic driver(312321)"},{"line_number":14,"context_line":"    2. Support enable IPv4/6 in network plugins and report"},{"line_number":15,"context_line":"       IP version capabilities for IP drivers(this)"},{"line_number":16,"context_line":"    3. Support IPv6 in huawei driver"},{"line_number":17,"context_line":"    4. Support in manilaclient(328932)"},{"line_number":18,"context_line":"    5. Scenario tests"},{"line_number":19,"context_line":"    6. Documentation"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a6eadb0_4734a749","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":38},"updated":"2016-12-19 11:15:06.000000000","message":"nit if you upload another patch: add links to all those patches, instead of only gerrit IDs, see example: https://review.openstack.org/#/c/406305/","commit_id":"e5d82a6339849c4225c5c8c5c7a438fc7a7e9d92"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e441f0fbed293402f5b19b774cf91fd8e1160730","unresolved":false,"context_lines":[{"line_number":14,"context_line":"       include dummy and generic (this)."},{"line_number":15,"context_line":"    3. Support IPv6 in huawei driver"},{"line_number":16,"context_line":"    4. Support in manilaclient [3]."},{"line_number":17,"context_line":"    5. Seneraio tests"},{"line_number":18,"context_line":"    6. Documentation"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] f7202a6cfe32a057f752a4e393f848f8a0211c36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"da4df55a_5890c843","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":15},"updated":"2016-12-24 22:52:21.000000000","message":"Scenario","commit_id":"3ddcd2c913b513db9876cb8a6c23cae5d6893230"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable IPv6 in manila(network plugins and drivers)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Please read spec for design detail [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The patch list:"},{"line_number":12,"context_line":"    1. Support IPv6 in allow_access [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"5a3905b3_f907e77e","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":38},"updated":"2017-01-20 03:57:11.000000000","message":"this is where you want to link to:\nhttp://specs.openstack.org/openstack/manila-specs/specs/ocata/manila-ipv6.html","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"       implement IPv6 in lvm, dummy driver(this)."},{"line_number":15,"context_line":"    3. Support IPv6 in generic driver"},{"line_number":16,"context_line":"    4. Support in manilaclient [3]."},{"line_number":17,"context_line":"    5. Scenario tests"},{"line_number":18,"context_line":"    6. Documentation"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] f7202a6cfe32a057f752a4e393f848f8a0211c36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"5a3905b3_39024f70","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":21},"updated":"2017-01-20 03:57:11.000000000","message":"where is this?","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    5. Scenario tests"},{"line_number":18,"context_line":"    6. Documentation"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] f7202a6cfe32a057f752a4e393f848f8a0211c36"},{"line_number":21,"context_line":"[2] b8e20971cf74fded7ad49816f8aa8a56da59c874"},{"line_number":22,"context_line":"[3] 1cde7dd972921008f604bdd536dd55862839b3bf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partial-Implements: blueprint support-ipv6-access"},{"line_number":25,"context_line":"Change-Id: I96d3389262e9829b8b4344870cdf5c76abd22828"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"5a3905b3_f9e0c7ce","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":44},"updated":"2017-01-20 03:57:11.000000000","message":"None of these lead anywhere helpful.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cfab44a354057ef4b23103cd28501446ce79981d","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: TommyLikeHu(tommylikehu@gmail.com)"},{"line_number":15,"context_line":"Co-Authored-By: Ben Swartzlander \u003cben@swartzlander.org\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] f7202a6cfe32a057f752a4e393f848f8a0211c36"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partial-Implements: blueprint support-ipv6-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":69,"id":"ff346bd7_c23de7dd","line":16,"updated":"2017-07-26 18:35:07.000000000","message":"DocImpact ?","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: TommyLikeHu(tommylikehu@gmail.com)"},{"line_number":15,"context_line":"Co-Authored-By: Ben Swartzlander \u003cben@swartzlander.org\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] f7202a6cfe32a057f752a4e393f848f8a0211c36"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partial-Implements: blueprint support-ipv6-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":69,"id":"ff346bd7_a1d3ec5f","line":16,"in_reply_to":"ff346bd7_73028c0d","updated":"2017-07-27 07:39:05.000000000","message":"Done","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c1b0cdf149d6d61c710c76d0f535c5b3eee809e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: TommyLikeHu(tommylikehu@gmail.com)"},{"line_number":15,"context_line":"Co-Authored-By: Ben Swartzlander \u003cben@swartzlander.org\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] f7202a6cfe32a057f752a4e393f848f8a0211c36"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partial-Implements: blueprint support-ipv6-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":69,"id":"ff346bd7_73028c0d","line":16,"in_reply_to":"ff346bd7_c23de7dd","updated":"2017-07-26 21:57:37.000000000","message":"+1","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: TommyLikeHu(tommylikehu@gmail.com)"},{"line_number":15,"context_line":"Co-Authored-By: Ben Swartzlander \u003cben@swartzlander.org\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] f7202a6cfe32a057f752a4e393f848f8a0211c36"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partial-Implements: blueprint support-ipv6-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":69,"id":"ff346bd7_c1e03029","line":16,"in_reply_to":"ff346bd7_c23de7dd","updated":"2017-07-27 07:39:05.000000000","message":"Done","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"}],"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    save_configuration \"MANILA_OPTGROUP_membernet_standalone_network_plugin_network_type\" \"vlan\""},{"line_number":136,"context_line":"    save_configuration \"MANILA_OPTGROUP_membernet_standalone_network_plugin_segmentation_id\" \"1010\""},{"line_number":137,"context_line":"    save_configuration \"MANILA_OPTGROUP_membernet_standalone_network_plugin_allowed_ip_ranges\" \"10.0.0.10-10.0.0.209\""},{"line_number":138,"context_line":"    save_configuration \"MANILA_OPTGROUP_membernet_standalone_network_plugin_ip_version\" \"4\""},{"line_number":139,"context_line":"    save_configuration \"MANILA_OPTGROUP_membernet_network_plugin_ipv4_enabled\" \"True\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    save_configuration \"MANILA_OPTGROUP_adminnet_network_api_class\" \"manila.network.standalone_network_plugin.StandaloneNetworkPlugin\""}],"source_content_type":"text/x-sh","patch_set":22,"id":"5a3905b3_59f9db7f","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":91},"updated":"2017-01-20 03:57:11.000000000","message":"don\u0027t specify the deprecated option.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"}],"manila/common/constants.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ff9c710853b087985db6de59f9ecec04da77635","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        CREATE_SHARE_FROM_SNAPSHOT_SUPPORT,"},{"line_number":196,"context_line":"        REVERT_TO_SNAPSHOT_SUPPORT,"},{"line_number":197,"context_line":"        REPLICATION_TYPE_SPEC,"},{"line_number":198,"context_line":"        IPV4_SUPPORT,"},{"line_number":199,"context_line":"        IPV6_SUPPORT,"},{"line_number":200,"context_line":"    )"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    # NOTE(cknight): Some extra specs are necessary parts of the Manila API and"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_a33eb389","line":199,"range":{"start_line":198,"start_character":0,"end_line":199,"end_character":21},"updated":"2017-01-23 04:01:10.000000000","message":"are these really meant to be tenant visible?","commit_id":"6048fb8299e5134c57e4c61f9a5127547b0ef58b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ee9489dccc7b6e10d243a91c8eb48026b43e5e1e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        CREATE_SHARE_FROM_SNAPSHOT_SUPPORT,"},{"line_number":196,"context_line":"        REVERT_TO_SNAPSHOT_SUPPORT,"},{"line_number":197,"context_line":"        REPLICATION_TYPE_SPEC,"},{"line_number":198,"context_line":"        IPV4_SUPPORT,"},{"line_number":199,"context_line":"        IPV6_SUPPORT,"},{"line_number":200,"context_line":"    )"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    # NOTE(cknight): Some extra specs are necessary parts of the Manila API and"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_c105767a","line":199,"range":{"start_line":198,"start_character":0,"end_line":199,"end_character":21},"in_reply_to":"5a3905b3_a33eb389","updated":"2017-01-23 06:40:52.000000000","message":"Hmm, I think I don\u0027t know the rules of which extra specs could/couldn\u0027t be there well, from my view, these two can be here. Am I breaking some rule?","commit_id":"6048fb8299e5134c57e4c61f9a5127547b0ef58b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"797a3cea474a0bfcb24baff12b1fe137e440e8f1","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        CREATE_SHARE_FROM_SNAPSHOT_SUPPORT,"},{"line_number":196,"context_line":"        REVERT_TO_SNAPSHOT_SUPPORT,"},{"line_number":197,"context_line":"        REPLICATION_TYPE_SPEC,"},{"line_number":198,"context_line":"        IPV4_SUPPORT,"},{"line_number":199,"context_line":"        IPV6_SUPPORT,"},{"line_number":200,"context_line":"    )"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    # NOTE(cknight): Some extra specs are necessary parts of the Manila API and"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_243e328c","line":199,"range":{"start_line":198,"start_character":0,"end_line":199,"end_character":21},"in_reply_to":"5a3905b3_c105767a","updated":"2017-01-23 14:20:40.000000000","message":"Might need to loop bswartz, tbarron in on this. I wish this was discussed on the spec. Unless an extra-spec affects an API, i.e., without the extra-spec, you don\u0027t get a capability and hence understandably, an API will fail:\n\nex: create_share_from_snapshot_support: The create API will fail if you\u0027re creating from snapshot if this extra-spec is missing from the share type of the parent share.\n\nI do not see any API restrictions with ipv4_support and ipv6_support. Am I missing context from a prior discussion between you guys?","commit_id":"6048fb8299e5134c57e4c61f9a5127547b0ef58b"}],"manila/network/__init__.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.BoolOpt("},{"line_number":55,"context_line":"        \u0027network_plugin_ipv4_enabled\u0027,"},{"line_number":56,"context_line":"        default\u003dTrue,"},{"line_number":57,"context_line":"        help\u003d\"Whether to support IPv4 network resource, Default\u003dTrue. \"),"},{"line_number":58,"context_line":"    cfg.BoolOpt("},{"line_number":59,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":60,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_b32ad47c","line":57,"range":{"start_line":57,"start_character":69,"end_line":57,"end_character":70},"updated":"2016-12-14 11:02:46.000000000","message":"no need to have extra space here","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.BoolOpt("},{"line_number":55,"context_line":"        \u0027network_plugin_ipv4_enabled\u0027,"},{"line_number":56,"context_line":"        default\u003dTrue,"},{"line_number":57,"context_line":"        help\u003d\"Whether to support IPv4 network resource, Default\u003dTrue. \"),"},{"line_number":58,"context_line":"    cfg.BoolOpt("},{"line_number":59,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":60,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_5cbb480e","line":57,"range":{"start_line":57,"start_character":69,"end_line":57,"end_character":70},"in_reply_to":"1a6eadb0_b32ad47c","updated":"2016-12-14 13:13:43.000000000","message":"Done","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.BoolOpt("},{"line_number":59,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":60,"context_line":"        default\u003dFalse,"},{"line_number":61,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \"),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_5336e0e6","line":61,"range":{"start_line":61,"start_character":70,"end_line":61,"end_character":71},"updated":"2016-12-14 11:02:46.000000000","message":"same as above","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.BoolOpt("},{"line_number":59,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":60,"context_line":"        default\u003dFalse,"},{"line_number":61,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \"),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_3cc04c7b","line":61,"range":{"start_line":61,"start_character":70,"end_line":61,"end_character":71},"in_reply_to":"1a6eadb0_5336e0e6","updated":"2016-12-14 13:13:43.000000000","message":"Done","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            return \u00276\u0027"},{"line_number":114,"context_line":"        if ipv4_enabled:"},{"line_number":115,"context_line":"            return \u00274\u0027"},{"line_number":116,"context_line":"        return \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_141ac96e","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":17},"updated":"2016-12-19 16:05:50.000000000","message":"I guess it should always have a version or else raise an exception?","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c059550b564ac6b8269c76e73e1ebc52b1c6be87","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            return \u00276\u0027"},{"line_number":114,"context_line":"        if ipv4_enabled:"},{"line_number":115,"context_line":"            return \u00274\u0027"},{"line_number":116,"context_line":"        msg \u003d _(\"At lease one of the ip versions should be \""},{"line_number":117,"context_line":"                \"configured \u0027True\u0027 for network plugin.\")"},{"line_number":118,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_676248da","line":116,"range":{"start_line":116,"start_character":20,"end_line":116,"end_character":25},"updated":"2016-12-20 10:15:50.000000000","message":"least","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            return \u00276\u0027"},{"line_number":114,"context_line":"        if ipv4_enabled:"},{"line_number":115,"context_line":"            return \u00274\u0027"},{"line_number":116,"context_line":"        msg \u003d _(\"At lease one of the ip versions should be \""},{"line_number":117,"context_line":"                \"configured \u0027True\u0027 for network plugin.\")"},{"line_number":118,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_e9083094","line":116,"range":{"start_line":116,"start_character":20,"end_line":116,"end_character":25},"in_reply_to":"1a6eadb0_676248da","updated":"2016-12-22 03:09:58.000000000","message":"Done","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e90ef757f7e6af2e0d2df5a8b54f347d511fe9cd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cls \u003d importutils.import_class(network_api_class)"},{"line_number":51,"context_line":"    return cls(config_group_name\u003dconfig_group_name, label\u003dlabel)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"network_base_opts \u003d ["},{"line_number":54,"context_line":"    cfg.BoolOpt("},{"line_number":55,"context_line":"        \u0027network_plugin_ipv4_enabled\u0027,"},{"line_number":56,"context_line":"        default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_cf8b1e1d","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":17},"updated":"2016-12-23 16:39:17.000000000","message":"Why separate set of opts and not part of above one?","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e90ef757f7e6af2e0d2df5a8b54f347d511fe9cd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            ipv6_enabled \u003d getattr("},{"line_number":108,"context_line":"                CONF, self.config_group_name).network_plugin_ipv6_enabled"},{"line_number":109,"context_line":"        else:"},{"line_number":110,"context_line":"            ipv4_enabled \u003d CONF.network_plugin_ipv4_enabled"},{"line_number":111,"context_line":"            ipv6_enabled \u003d CONF.network_plugin_ipv6_enabled"},{"line_number":112,"context_line":"        if ipv6_enabled:"},{"line_number":113,"context_line":"            return \u00276\u0027"},{"line_number":114,"context_line":"        if ipv4_enabled:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_4fe3ae05","line":111,"range":{"start_line":110,"start_character":12,"end_line":111,"end_character":59},"updated":"2016-12-23 16:39:17.000000000","message":"It will fail because you do not register these opts in DEFAULT config group.","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"104487b26aa2c8079fc3458cb4bca9b0497dd74b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            ipv6_enabled \u003d getattr("},{"line_number":108,"context_line":"                CONF, self.config_group_name).network_plugin_ipv6_enabled"},{"line_number":109,"context_line":"        else:"},{"line_number":110,"context_line":"            ipv4_enabled \u003d CONF.network_plugin_ipv4_enabled"},{"line_number":111,"context_line":"            ipv6_enabled \u003d CONF.network_plugin_ipv6_enabled"},{"line_number":112,"context_line":"        if ipv6_enabled:"},{"line_number":113,"context_line":"            return \u00276\u0027"},{"line_number":114,"context_line":"        if ipv4_enabled:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_2e48225b","line":111,"range":{"start_line":110,"start_character":12,"end_line":111,"end_character":59},"in_reply_to":"da4df55a_4fe3ae05","updated":"2016-12-24 06:59:51.000000000","message":"thanks","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":42,"context_line":"        default\u003dFalse,"},{"line_number":43,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \""},{"line_number":44,"context_line":"             \"If this is True, \u0027network_plugin_ipv4_enabled\u003dTrue\u0027 will \""},{"line_number":45,"context_line":"             \"be ignored.\"),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_792137b4","line":44,"range":{"start_line":44,"start_character":31,"end_line":44,"end_character":65},"updated":"2017-01-20 03:57:11.000000000","message":"the value of \u0027network_plugin_ipv4_enabled\u0027 will be ignored.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":42,"context_line":"        default\u003dFalse,"},{"line_number":43,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \""},{"line_number":44,"context_line":"             \"If this is True, \u0027network_plugin_ipv4_enabled\u003dTrue\u0027 will \""},{"line_number":45,"context_line":"             \"be ignored.\"),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_9959835d","line":44,"range":{"start_line":44,"start_character":17,"end_line":44,"end_character":29},"updated":"2017-01-20 03:57:11.000000000","message":"this option is set to True","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":42,"context_line":"        default\u003dFalse,"},{"line_number":43,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \""},{"line_number":44,"context_line":"             \"If this is True, \u0027network_plugin_ipv4_enabled\u003dTrue\u0027 will \""},{"line_number":45,"context_line":"             \"be ignored.\"),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_62eb37b1","line":44,"range":{"start_line":44,"start_character":31,"end_line":44,"end_character":65},"in_reply_to":"5a3905b3_792137b4","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":42,"context_line":"        default\u003dFalse,"},{"line_number":43,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \""},{"line_number":44,"context_line":"             \"If this is True, \u0027network_plugin_ipv4_enabled\u003dTrue\u0027 will \""},{"line_number":45,"context_line":"             \"be ignored.\"),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_a2cd1f5f","line":44,"range":{"start_line":44,"start_character":17,"end_line":44,"end_character":29},"in_reply_to":"5a3905b3_9959835d","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            return \u00276\u0027"},{"line_number":118,"context_line":"        if ipv4_enabled:"},{"line_number":119,"context_line":"            return \u00274\u0027"},{"line_number":120,"context_line":"        msg \u003d _(\"At least one of the ip versions should be \""},{"line_number":121,"context_line":"                \"configured \u0027True\u0027 for network plugin.\")"},{"line_number":122,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_543b62d1","line":120,"range":{"start_line":120,"start_character":37,"end_line":120,"end_character":39},"updated":"2017-01-20 03:57:11.000000000","message":"IP","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if ipv4_enabled:"},{"line_number":119,"context_line":"            return \u00274\u0027"},{"line_number":120,"context_line":"        msg \u003d _(\"At least one of the ip versions should be \""},{"line_number":121,"context_line":"                \"configured \u0027True\u0027 for network plugin.\")"},{"line_number":122,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_9435cadb","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":35},"updated":"2017-01-20 03:57:11.000000000","message":"can remove","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if ipv4_enabled:"},{"line_number":119,"context_line":"            return \u00274\u0027"},{"line_number":120,"context_line":"        msg \u003d _(\"At least one of the ip versions should be \""},{"line_number":121,"context_line":"                \"configured \u0027True\u0027 for network plugin.\")"},{"line_number":122,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_146f1ac6","line":121,"range":{"start_line":121,"start_character":39,"end_line":121,"end_character":53},"updated":"2017-01-20 03:57:11.000000000","message":"specify the configuration options here..","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if ipv4_enabled:"},{"line_number":119,"context_line":"            return \u00274\u0027"},{"line_number":120,"context_line":"        msg \u003d _(\"At least one of the ip versions should be \""},{"line_number":121,"context_line":"                \"configured \u0027True\u0027 for network plugin.\")"},{"line_number":122,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_82274311","line":121,"range":{"start_line":121,"start_character":39,"end_line":121,"end_character":53},"in_reply_to":"5a3905b3_146f1ac6","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if ipv4_enabled:"},{"line_number":119,"context_line":"            return \u00274\u0027"},{"line_number":120,"context_line":"        msg \u003d _(\"At least one of the ip versions should be \""},{"line_number":121,"context_line":"                \"configured \u0027True\u0027 for network plugin.\")"},{"line_number":122,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_c2214bfd","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":35},"in_reply_to":"5a3905b3_9435cadb","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"18d590a193e59aa309dd3fe355d969a2b1536b94","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            CONF.register_opts(network_base_opts)"},{"line_number":78,"context_line":"        super(NetworkBaseAPI, self).__init__(db_driver\u003ddb_driver)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _verify_share_network(self, share_server_id, share_network):"},{"line_number":81,"context_line":"        if share_network is None:"},{"line_number":82,"context_line":"            msg \u003d _(\"\u0027Share network\u0027 is not provided for setting up \""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_6fbb6d0f","line":79,"updated":"2017-01-25 13:18:20.000000000","message":"Add here following:\n\"\"\"\nself.configuration \u003d getattr(CONF, self.config_group_name, CONF)\n\"\"\"\nand then reuse it in new method:\n\n\"\"\"\n...\nipv4_enabled \u003d self.configuration.network_plugin_ipv4_enabled\nipv6_enabled \u003d self.configuration.network_plugin_ipv6_enabled\n...\n\n\"\"\"","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            CONF.register_opts(network_base_opts)"},{"line_number":78,"context_line":"        super(NetworkBaseAPI, self).__init__(db_driver\u003ddb_driver)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _verify_share_network(self, share_server_id, share_network):"},{"line_number":81,"context_line":"        if share_network is None:"},{"line_number":82,"context_line":"            msg \u003d _(\"\u0027Share network\u0027 is not provided for setting up \""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_73e8967d","line":79,"in_reply_to":"3a461143_6fbb6d0f","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab52a3158b583668b8881b9cff76c95ba5fad649","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def deallocate_network(self, context, share_server_id):"},{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def enabled_ip_versions(self):"},{"line_number":108,"context_line":"        if self.config_group_name:"},{"line_number":109,"context_line":"            ipv4_enabled \u003d getattr("},{"line_number":110,"context_line":"                CONF, self.config_group_name).network_plugin_ipv4_enabled"}],"source_content_type":"text/x-python","patch_set":28,"id":"5a3905b3_dd4872cf","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":27},"updated":"2017-01-25 13:13:48.000000000","message":"Name of method assumes we can return more than one value, but it is not according to current method logic.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def deallocate_network(self, context, share_server_id):"},{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def enabled_ip_versions(self):"},{"line_number":108,"context_line":"        if self.config_group_name:"},{"line_number":109,"context_line":"            ipv4_enabled \u003d getattr("},{"line_number":110,"context_line":"                CONF, self.config_group_name).network_plugin_ipv4_enabled"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_f3ad6689","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":27},"in_reply_to":"5a3905b3_dd4872cf","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab52a3158b583668b8881b9cff76c95ba5fad649","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def enabled_ip_versions(self):"},{"line_number":108,"context_line":"        if self.config_group_name:"},{"line_number":109,"context_line":"            ipv4_enabled \u003d getattr("},{"line_number":110,"context_line":"                CONF, self.config_group_name).network_plugin_ipv4_enabled"},{"line_number":111,"context_line":"            ipv6_enabled \u003d getattr("},{"line_number":112,"context_line":"                CONF, self.config_group_name).network_plugin_ipv6_enabled"},{"line_number":113,"context_line":"        else:"},{"line_number":114,"context_line":"            ipv4_enabled \u003d CONF.network_plugin_ipv4_enabled"},{"line_number":115,"context_line":"            ipv6_enabled \u003d CONF.network_plugin_ipv6_enabled"},{"line_number":116,"context_line":"        if ipv6_enabled:"},{"line_number":117,"context_line":"            return \u00276\u0027"},{"line_number":118,"context_line":"        if ipv4_enabled:"},{"line_number":119,"context_line":"            return \u00274\u0027"},{"line_number":120,"context_line":"        msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":121,"context_line":"                \"\u0027network_plugin_ipv6_enabled\u0027 should configured \u0027True\u0027.\")"},{"line_number":122,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":28,"id":"5a3905b3_1d5f5a76","line":122,"range":{"start_line":108,"start_character":8,"end_line":122,"end_character":68},"updated":"2017-01-25 13:13:48.000000000","message":"You should not calculate it each time, remember it and then return. Example:\nhttps://github.com/openstack/manila/blob/8d71932c/manila/share/driver.py#L1029-L1038","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def enabled_ip_versions(self):"},{"line_number":108,"context_line":"        if self.config_group_name:"},{"line_number":109,"context_line":"            ipv4_enabled \u003d getattr("},{"line_number":110,"context_line":"                CONF, self.config_group_name).network_plugin_ipv4_enabled"},{"line_number":111,"context_line":"            ipv6_enabled \u003d getattr("},{"line_number":112,"context_line":"                CONF, self.config_group_name).network_plugin_ipv6_enabled"},{"line_number":113,"context_line":"        else:"},{"line_number":114,"context_line":"            ipv4_enabled \u003d CONF.network_plugin_ipv4_enabled"},{"line_number":115,"context_line":"            ipv6_enabled \u003d CONF.network_plugin_ipv6_enabled"},{"line_number":116,"context_line":"        if ipv6_enabled:"},{"line_number":117,"context_line":"            return \u00276\u0027"},{"line_number":118,"context_line":"        if ipv4_enabled:"},{"line_number":119,"context_line":"            return \u00274\u0027"},{"line_number":120,"context_line":"        msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":121,"context_line":"                \"\u0027network_plugin_ipv6_enabled\u0027 should configured \u0027True\u0027.\")"},{"line_number":122,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_b3b03e8d","line":122,"range":{"start_line":108,"start_character":8,"end_line":122,"end_character":68},"in_reply_to":"5a3905b3_1d5f5a76","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b88553b01ff126feb93f4e3b7ea048ebaf8d5290","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":117,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":118,"context_line":"                        \"should configured \u0027True\u0027.\")"},{"line_number":119,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":120,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a461143_1d939ba4","line":118,"updated":"2017-01-27 11:27:05.000000000","message":"...should BE configured TO \u0027True\u0027.","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"6aa8a777a83cc85b77cc0783a4e1cb1f16c4bee0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":117,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":118,"context_line":"                        \"should configured \u0027True\u0027.\")"},{"line_number":119,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":120,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a430d35_d92a5e7e","line":118,"in_reply_to":"3a461143_1d939ba4","updated":"2017-02-04 06:27:34.000000000","message":"Done","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":118,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":119,"context_line":"                        \"should configured to \u0027True\u0027.\")"},{"line_number":120,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":121,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_7d021d71","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":32},"updated":"2017-06-27 04:30:53.000000000","message":"should be","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":118,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":119,"context_line":"                        \"should configured to \u0027True\u0027.\")"},{"line_number":120,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":121,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_765477fe","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":32},"in_reply_to":"5f201791_7d021d71","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":42,"context_line":"        default\u003dFalse,"},{"line_number":43,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \""},{"line_number":44,"context_line":"             \"If this option is True, the value of \""},{"line_number":45,"context_line":"             \"\u0027network_plugin_ipv4_enabled\u0027 will be ignored.\"),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_2fad87e8","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":63},"updated":"2017-07-05 20:33:17.000000000","message":"Does this help message need to be updated to reflect the fact that we decided to allow both IPv4 and IPv6 to be enabled at the same time in the same driver?  Your code at lines 109ff allows this.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027network_plugin_ipv6_enabled\u0027,"},{"line_number":42,"context_line":"        default\u003dFalse,"},{"line_number":43,"context_line":"        help\u003d\"Whether to support IPv6 network resource, Default\u003dFalse. \""},{"line_number":44,"context_line":"             \"If this option is True, the value of \""},{"line_number":45,"context_line":"             \"\u0027network_plugin_ipv4_enabled\u0027 will be ignored.\"),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_c795c588","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":63},"in_reply_to":"3f1d235d_2fad87e8","updated":"2017-07-06 11:47:20.000000000","message":"Roll-back to pre-version code.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        pass"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @property"},{"line_number":109,"context_line":"    def enabled_ip_version(self):"},{"line_number":110,"context_line":"        if not hasattr(self, \u0027_enabled_ip_version\u0027):"},{"line_number":111,"context_line":"            self._enabled_ip_version \u003d []"},{"line_number":112,"context_line":"            if self.configuration.network_plugin_ipv6_enabled:"},{"line_number":113,"context_line":"                self._enabled_ip_version.append(6)"},{"line_number":114,"context_line":"            elif self.configuration.network_plugin_ipv4_enabled:"},{"line_number":115,"context_line":"                self._enabled_ip_version.append(4)"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":118,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":119,"context_line":"                        \"should be configured to \u0027True\u0027.\")"},{"line_number":120,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":121,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_0fe40b3b","line":121,"range":{"start_line":109,"start_character":0,"end_line":121,"end_character":39},"updated":"2017-07-05 20:33:17.000000000","message":"Looks like we lack unit test coverage for this method: http://logs.openstack.org/76/406776/51/check/manila-coverage-ubuntu-xenial-nv/47e5a67/cover/manila_network___init___py.html#n109","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        pass"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @property"},{"line_number":109,"context_line":"    def enabled_ip_version(self):"},{"line_number":110,"context_line":"        if not hasattr(self, \u0027_enabled_ip_version\u0027):"},{"line_number":111,"context_line":"            self._enabled_ip_version \u003d []"},{"line_number":112,"context_line":"            if self.configuration.network_plugin_ipv6_enabled:"},{"line_number":113,"context_line":"                self._enabled_ip_version.append(6)"},{"line_number":114,"context_line":"            elif self.configuration.network_plugin_ipv4_enabled:"},{"line_number":115,"context_line":"                self._enabled_ip_version.append(4)"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":118,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":119,"context_line":"                        \"should be configured to \u0027True\u0027.\")"},{"line_number":120,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":121,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_a7de423b","line":121,"range":{"start_line":109,"start_character":0,"end_line":121,"end_character":39},"in_reply_to":"3f1d235d_0fe40b3b","updated":"2017-07-06 11:47:20.000000000","message":"Done","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9486cc0ec6a97996c693fc824eacb94bfd8d5e69","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                self._enabled_ip_version \u003d 6"},{"line_number":113,"context_line":"            elif self.configuration.network_plugin_ipv4_enabled:"},{"line_number":114,"context_line":"                self._enabled_ip_version \u003d 4"},{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":117,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":118,"context_line":"                        \"should configured to \u0027True\u0027.\")"}],"source_content_type":"text/x-python","patch_set":56,"id":"3f1d235d_d092cf4b","line":115,"updated":"2017-07-08 17:32:43.000000000","message":"It would be nice to have unit test coverage for the \u0027else\u0027 path:\nhttp://logs.openstack.org/76/406776/56/check/manila-coverage-ubuntu-xenial-nv/19e888a/cover/manila_network___init___py.html#n116","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c30caaec3b353119d22fbe3a041df457dd39ea41","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                self._enabled_ip_version \u003d 6"},{"line_number":113,"context_line":"            elif self.configuration.network_plugin_ipv4_enabled:"},{"line_number":114,"context_line":"                self._enabled_ip_version \u003d 4"},{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":117,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":118,"context_line":"                        \"should configured to \u0027True\u0027.\")"}],"source_content_type":"text/x-python","patch_set":56,"id":"3f1d235d_32945ce8","line":115,"in_reply_to":"3f1d235d_d092cf4b","updated":"2017-07-10 06:44:37.000000000","message":"Done","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fc44ad31069e6c6beb7083171b556d2fb21deb0f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            CONF.register_opts(network_base_opts)"},{"line_number":77,"context_line":"        self.configuration \u003d getattr(CONF,"},{"line_number":78,"context_line":"                                     six.text_type(config_group_name), CONF)"},{"line_number":79,"context_line":"        super(NetworkBaseAPI, self).__init__(db_driver\u003ddb_driver)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _verify_share_network(self, share_server_id, share_network):"}],"source_content_type":"text/x-python","patch_set":67,"id":"ff346bd7_66c256ec","line":78,"range":{"start_line":78,"start_character":37,"end_line":78,"end_character":50},"updated":"2017-07-21 20:37:35.000000000","message":"Is this needed?  Could \"config_group_name\" be a non-string?","commit_id":"260094dfb331039d7c735d0abd3bcb9309027809"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d3aff1cd7243c425f045c42ad41d28896711f92f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            CONF.register_opts(network_base_opts)"},{"line_number":77,"context_line":"        self.configuration \u003d getattr(CONF,"},{"line_number":78,"context_line":"                                     six.text_type(config_group_name), CONF)"},{"line_number":79,"context_line":"        super(NetworkBaseAPI, self).__init__(db_driver\u003ddb_driver)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _verify_share_network(self, share_server_id, share_network):"}],"source_content_type":"text/x-python","patch_set":67,"id":"ff346bd7_a98d58d4","line":78,"range":{"start_line":78,"start_character":37,"end_line":78,"end_character":50},"in_reply_to":"ff346bd7_66c256ec","updated":"2017-07-25 16:57:25.000000000","message":"Yes, if config_group_name has been set to None, we can get the default value from getattr(CONF,                                six.text_type(config_group_name), CONF)\nIf we doesn\u0027t add six.text_type, we will get type error:\n\"TypeError: getattr(): attribute name must be string\"","commit_id":"260094dfb331039d7c735d0abd3bcb9309027809"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fc44ad31069e6c6beb7083171b556d2fb21deb0f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":117,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":118,"context_line":"                        \"should configured to \u0027True\u0027.\")"},{"line_number":119,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":120,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":67,"id":"ff346bd7_46451270","line":118,"range":{"start_line":118,"start_character":25,"end_line":118,"end_character":42},"updated":"2017-07-21 20:37:35.000000000","message":"should be configured to \u0027True\u0027.","commit_id":"260094dfb331039d7c735d0abd3bcb9309027809"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cfab44a354057ef4b23103cd28501446ce79981d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":117,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":118,"context_line":"                        \"should configured to \u0027True\u0027.\")"},{"line_number":119,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":120,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_bd144845","line":118,"range":{"start_line":118,"start_character":25,"end_line":118,"end_character":42},"updated":"2017-07-26 18:35:07.000000000","message":"should be configured","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                msg \u003d _(\"Either \u0027network_plugin_ipv4_enabled\u0027 or \""},{"line_number":117,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 \""},{"line_number":118,"context_line":"                        \"should configured to \u0027True\u0027.\")"},{"line_number":119,"context_line":"                raise exception.NetworkBadConfigurationException(reason\u003dmsg)"},{"line_number":120,"context_line":"        return self._enabled_ip_version"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_3aa9708f","line":118,"range":{"start_line":118,"start_character":25,"end_line":118,"end_character":42},"in_reply_to":"ff346bd7_bd144845","updated":"2017-07-27 07:39:05.000000000","message":"Done","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"}],"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5742d8bed6294ed4463994f0483446b3728e2198","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                LOG.warning(_LW(\"%(address)s isn\u0027t a valid ip \""},{"line_number":174,"context_line":"                                \"address, omitted.\"), {\u0027address\u0027:"},{"line_number":175,"context_line":"                                                       ip[\u0027ip_address\u0027]})"},{"line_number":176,"context_line":"        msg \u003d _(\"Can not find any ip address with  configured ip \""},{"line_number":177,"context_line":"                \"version %(version)s in share-network.\") % {\u0027version\u0027:"},{"line_number":178,"context_line":"                                                            ip_version}"},{"line_number":179,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_f2177442","line":176,"range":{"start_line":176,"start_character":49,"end_line":176,"end_character":50},"updated":"2016-12-16 10:33:18.000000000","message":"extra space","commit_id":"b712309b3e267fa883d0b2df4e5921c9b06dca6a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return ports"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_matched_ip_address(self, fix_ips, ip_version):"},{"line_number":165,"context_line":"        \"\"\"Get first ip address which match the specified ip_version\"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        for ip in fix_ips:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_d478512e","line":164,"range":{"start_line":164,"start_character":38,"end_line":164,"end_character":45},"updated":"2016-12-19 16:05:50.000000000","message":"fixed_ips","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return ports"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_matched_ip_address(self, fix_ips, ip_version):"},{"line_number":165,"context_line":"        \"\"\"Get first ip address which match the specified ip_version\"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        for ip in fix_ips:"},{"line_number":168,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_947259ac","line":165,"range":{"start_line":165,"start_character":67,"end_line":165,"end_character":69},"updated":"2016-12-19 16:05:50.000000000","message":"period","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def _get_matched_ip_address(self, fix_ips, ip_version):"},{"line_number":165,"context_line":"        \"\"\"Get first ip address which match the specified ip_version\"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        for ip in fix_ips:"},{"line_number":168,"context_line":"            try:"},{"line_number":169,"context_line":"                address \u003d ipaddress.ip_address(six.text_type(ip[\u0027ip_address\u0027]))"},{"line_number":170,"context_line":"                if address.version \u003d\u003d ip_version:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_1473a94e","line":167,"range":{"start_line":167,"start_character":18,"end_line":167,"end_character":25},"updated":"2016-12-19 16:05:50.000000000","message":"fixed_ips","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a26f2339a43cfcdc4e7b4a362683d79ba125fd37","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":103,"context_line":"        db_driver \u003d kwargs.pop(\u0027db_driver\u0027, None)"},{"line_number":104,"context_line":"        config_group_name \u003d kwargs.get(\u0027config_group_name\u0027, None)"},{"line_number":105,"context_line":"        super(NeutronNetworkPlugin,"},{"line_number":106,"context_line":"              self).__init__(config_group_name\u003dconfig_group_name,"},{"line_number":107,"context_line":"                             db_driver\u003ddb_driver)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_a93a7c32","line":104,"range":{"start_line":104,"start_character":60,"end_line":104,"end_character":64},"updated":"2016-12-20 12:41:30.000000000","message":"other plugins all use \u0027DEFAULT\u0027 as default value, why here use None?","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":103,"context_line":"        db_driver \u003d kwargs.pop(\u0027db_driver\u0027, None)"},{"line_number":104,"context_line":"        config_group_name \u003d kwargs.get(\u0027config_group_name\u0027, None)"},{"line_number":105,"context_line":"        super(NeutronNetworkPlugin,"},{"line_number":106,"context_line":"              self).__init__(config_group_name\u003dconfig_group_name,"},{"line_number":107,"context_line":"                             db_driver\u003ddb_driver)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_04571b03","line":104,"range":{"start_line":104,"start_character":60,"end_line":104,"end_character":64},"in_reply_to":"1a6eadb0_a93a7c32","updated":"2016-12-22 03:09:58.000000000","message":"done","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return ports"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_matched_ip_address(self, fixed_ips, ip_version):"},{"line_number":165,"context_line":"        \"\"\"Get first ip address which match the specified ip_version.\"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        for ip in fixed_ips:"},{"line_number":168,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_14cb9aa6","line":165,"range":{"start_line":165,"start_character":38,"end_line":165,"end_character":43},"updated":"2017-01-20 03:57:11.000000000","message":"nit: matches","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return ports"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_matched_ip_address(self, fixed_ips, ip_version):"},{"line_number":165,"context_line":"        \"\"\"Get first ip address which match the specified ip_version.\"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        for ip in fixed_ips:"},{"line_number":168,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_826e632d","line":165,"range":{"start_line":165,"start_character":38,"end_line":165,"end_character":43},"in_reply_to":"5a3905b3_14cb9aa6","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if address.version \u003d\u003d ip_version:"},{"line_number":171,"context_line":"                    return ip[\u0027ip_address\u0027]"},{"line_number":172,"context_line":"            except ValueError:"},{"line_number":173,"context_line":"                LOG.warning(_LW(\"%(address)s isn\u0027t a valid ip \""},{"line_number":174,"context_line":"                                \"address, omitted.\"), {\u0027address\u0027:"},{"line_number":175,"context_line":"                                                       ip[\u0027ip_address\u0027]})"},{"line_number":176,"context_line":"        msg \u003d _(\"Can not find any ip address with configured ip \""},{"line_number":177,"context_line":"                \"version %(version)s in share-network.\") % {\u0027version\u0027:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_d4bcb26e","line":174,"range":{"start_line":173,"start_character":33,"end_line":174,"end_character":51},"updated":"2017-01-20 03:57:11.000000000","message":"Print the value error content here. It\u0027s pretty cautious of us to distrust neutron\u0027s API to give us a valid IP address, but we should probably log what the error is..","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                if address.version \u003d\u003d ip_version:"},{"line_number":171,"context_line":"                    return ip[\u0027ip_address\u0027]"},{"line_number":172,"context_line":"            except ValueError:"},{"line_number":173,"context_line":"                LOG.warning(_LW(\"%(address)s isn\u0027t a valid ip \""},{"line_number":174,"context_line":"                                \"address, omitted.\"), {\u0027address\u0027:"},{"line_number":175,"context_line":"                                                       ip[\u0027ip_address\u0027]})"},{"line_number":176,"context_line":"        msg \u003d _(\"Can not find any ip address with configured ip \""},{"line_number":177,"context_line":"                \"version %(version)s in share-network.\") % {\u0027version\u0027:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_62ba5770","line":174,"range":{"start_line":173,"start_character":33,"end_line":174,"end_character":51},"in_reply_to":"5a3905b3_d4bcb26e","updated":"2017-01-20 09:36:15.000000000","message":"The only reason here is that the address is not a valid ip.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                LOG.warning(_LW(\"%(address)s isn\u0027t a valid ip \""},{"line_number":174,"context_line":"                                \"address, omitted.\"), {\u0027address\u0027:"},{"line_number":175,"context_line":"                                                       ip[\u0027ip_address\u0027]})"},{"line_number":176,"context_line":"        msg \u003d _(\"Can not find any ip address with configured ip \""},{"line_number":177,"context_line":"                \"version %(version)s in share-network.\") % {\u0027version\u0027:"},{"line_number":178,"context_line":"                                                            ip_version}"},{"line_number":179,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_d43752ae","line":176,"range":{"start_line":176,"start_character":34,"end_line":176,"end_character":36},"updated":"2017-01-20 03:57:11.000000000","message":"IP","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                LOG.warning(_LW(\"%(address)s isn\u0027t a valid ip \""},{"line_number":174,"context_line":"                                \"address, omitted.\"), {\u0027address\u0027:"},{"line_number":175,"context_line":"                                                       ip[\u0027ip_address\u0027]})"},{"line_number":176,"context_line":"        msg \u003d _(\"Can not find any ip address with configured ip \""},{"line_number":177,"context_line":"                \"version %(version)s in share-network.\") % {\u0027version\u0027:"},{"line_number":178,"context_line":"                                                            ip_version}"},{"line_number":179,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_f43a8e97","line":176,"range":{"start_line":176,"start_character":61,"end_line":176,"end_character":63},"updated":"2017-01-20 03:57:11.000000000","message":"IP","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                LOG.warning(_LW(\"%(address)s isn\u0027t a valid ip \""},{"line_number":174,"context_line":"                                \"address, omitted.\"), {\u0027address\u0027:"},{"line_number":175,"context_line":"                                                       ip[\u0027ip_address\u0027]})"},{"line_number":176,"context_line":"        msg \u003d _(\"Can not find any ip address with configured ip \""},{"line_number":177,"context_line":"                \"version %(version)s in share-network.\") % {\u0027version\u0027:"},{"line_number":178,"context_line":"                                                            ip_version}"},{"line_number":179,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_425b9b87","line":176,"range":{"start_line":176,"start_character":34,"end_line":176,"end_character":36},"in_reply_to":"5a3905b3_d43752ae","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                LOG.warning(_LW(\"%(address)s isn\u0027t a valid ip \""},{"line_number":174,"context_line":"                                \"address, omitted.\"), {\u0027address\u0027:"},{"line_number":175,"context_line":"                                                       ip[\u0027ip_address\u0027]})"},{"line_number":176,"context_line":"        msg \u003d _(\"Can not find any ip address with configured ip \""},{"line_number":177,"context_line":"                \"version %(version)s in share-network.\") % {\u0027version\u0027:"},{"line_number":178,"context_line":"                                                            ip_version}"},{"line_number":179,"context_line":"        raise exception.NetworkBadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_625ed777","line":176,"range":{"start_line":176,"start_character":61,"end_line":176,"end_character":63},"in_reply_to":"5a3905b3_f43a8e97","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            \u0027id\u0027: port[\u0027id\u0027],"},{"line_number":215,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":216,"context_line":"            \u0027ip_address\u0027:"},{"line_number":217,"context_line":"                self._get_matched_ip_address(port[\u0027fixed_ips\u0027],"},{"line_number":218,"context_line":"                                             share_network[\u0027ip_version\u0027]),"},{"line_number":219,"context_line":"            \u0027gateway\u0027: share_network[\u0027gateway\u0027],"},{"line_number":220,"context_line":"            \u0027mac_address\u0027: port[\u0027mac_address\u0027],"},{"line_number":221,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_d47912fe","line":218,"range":{"start_line":217,"start_character":16,"end_line":218,"end_character":73},"updated":"2017-01-20 03:57:11.000000000","message":"do this outside above dictionary instantiation.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            \u0027id\u0027: port[\u0027id\u0027],"},{"line_number":215,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":216,"context_line":"            \u0027ip_address\u0027:"},{"line_number":217,"context_line":"                self._get_matched_ip_address(port[\u0027fixed_ips\u0027],"},{"line_number":218,"context_line":"                                             share_network[\u0027ip_version\u0027]),"},{"line_number":219,"context_line":"            \u0027gateway\u0027: share_network[\u0027gateway\u0027],"},{"line_number":220,"context_line":"            \u0027mac_address\u0027: port[\u0027mac_address\u0027],"},{"line_number":221,"context_line":"            \u0027status\u0027: constants.STATUS_ACTIVE,"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_2235aff6","line":218,"range":{"start_line":217,"start_character":16,"end_line":218,"end_character":73},"in_reply_to":"5a3905b3_d47912fe","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"}],"manila/network/nova_network_plugin.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __init__(self, config_group_name\u003dNone, db_driver\u003dNone, label\u003dNone):"},{"line_number":48,"context_line":"        super(NovaNetworkPlugin,"},{"line_number":49,"context_line":"              self).__init__(config_group_name\u003dconfig_group_name or \u0027DEFAULT\u0027,"},{"line_number":50,"context_line":"                             db_driver\u003ddb_driver)"},{"line_number":51,"context_line":"        self.config_group_name \u003d config_group_name or \u0027DEFAULT\u0027"},{"line_number":52,"context_line":"        self._label \u003d label or \u0027user\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_b39f34b3","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":77},"updated":"2016-12-14 11:02:46.000000000","message":"isn\u0027t this redundant with the below statement? (LN 51)","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"}],"manila/network/standalone_network_plugin.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def __init__(self, config_group_name\u003dNone, db_driver\u003dNone, label\u003d\u0027user\u0027):"},{"line_number":96,"context_line":"        super(StandaloneNetworkPlugin,"},{"line_number":97,"context_line":"              self).__init__(config_group_name\u003dconfig_group_name or \u0027DEFAULT\u0027,"},{"line_number":98,"context_line":"                             db_driver\u003ddb_driver)"},{"line_number":99,"context_line":"        self.config_group_name \u003d config_group_name or \u0027DEFAULT\u0027"},{"line_number":100,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_93ea380e","line":97,"range":{"start_line":97,"start_character":29,"end_line":97,"end_character":77},"updated":"2016-12-14 11:02:46.000000000","message":"isn\u0027t this redudant with LN 99 statement?","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def __init__(self, config_group_name\u003dNone, db_driver\u003dNone, label\u003d\u0027user\u0027):"},{"line_number":96,"context_line":"        super(StandaloneNetworkPlugin,"},{"line_number":97,"context_line":"              self).__init__(config_group_name\u003dconfig_group_name or \u0027DEFAULT\u0027,"},{"line_number":98,"context_line":"                             db_driver\u003ddb_driver)"},{"line_number":99,"context_line":"        self.config_group_name \u003d config_group_name or \u0027DEFAULT\u0027"},{"line_number":100,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_bcac5ca1","line":97,"range":{"start_line":97,"start_character":29,"end_line":97,"end_character":77},"in_reply_to":"1a6eadb0_93ea380e","updated":"2016-12-14 13:13:43.000000000","message":"No, we just pass this value to base class here","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        ip_version \u003d self.configuration.standalone_network_plugin_ip_version"},{"line_number":135,"context_line":"        # NOTE(tommylikehu): if both network_plugin_ipv4_enabled"},{"line_number":136,"context_line":"        # and network_plugin_ipv6_enabled are configured True"},{"line_number":137,"context_line":"        # we would only support ipv4"},{"line_number":138,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv6_enabled\u0027, None):"},{"line_number":139,"context_line":"            ip_version \u003d \u00276\u0027"},{"line_number":140,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv4_enabled\u0027, None):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_eea3834d","line":137,"range":{"start_line":137,"start_character":10,"end_line":137,"end_character":36},"updated":"2016-12-14 11:02:46.000000000","message":"I saw in the spec that we would not support both enabled at the same time, but I do not remember seeing that we would only support ipv4 in that case. I know ipv4 is what we currently do, but if ipv6 is set to True, and we would like to move forward, I would have ipv6 supported in case both are enabled.","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        ip_version \u003d self.configuration.standalone_network_plugin_ip_version"},{"line_number":135,"context_line":"        # NOTE(tommylikehu): if both network_plugin_ipv4_enabled"},{"line_number":136,"context_line":"        # and network_plugin_ipv6_enabled are configured True"},{"line_number":137,"context_line":"        # we would only support ipv4"},{"line_number":138,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv6_enabled\u0027, None):"},{"line_number":139,"context_line":"            ip_version \u003d \u00276\u0027"},{"line_number":140,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv4_enabled\u0027, None):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_bc9a9c61","line":137,"range":{"start_line":137,"start_character":10,"end_line":137,"end_character":36},"in_reply_to":"1a6eadb0_eea3834d","updated":"2016-12-14 13:13:43.000000000","message":"Standalone network plugin could not support IPv4 and IPv6 at the same time.","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e8e435352abd56807fead2522ef550e07dffa9ec","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def _set_persistent_network_data(self):"},{"line_number":133,"context_line":"        \"\"\"Sets persistent data for whole plugin.\"\"\""},{"line_number":134,"context_line":"        ip_version \u003d self.configuration.standalone_network_plugin_ip_version"},{"line_number":135,"context_line":"        # NOTE(tommylikehu): Standalone plugin could only support"},{"line_number":136,"context_line":"        # either IPv4 or IPv6, so if both network_plugin_ipv4_enabled"},{"line_number":137,"context_line":"        # and network_plugin_ipv6_enabled are configured True"},{"line_number":138,"context_line":"        # we would only support ipv4."},{"line_number":139,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv6_enabled\u0027, None):"},{"line_number":140,"context_line":"            ip_version \u003d \u00276\u0027"},{"line_number":141,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv4_enabled\u0027, None):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_66eb0079","line":138,"range":{"start_line":135,"start_character":8,"end_line":138,"end_character":37},"updated":"2016-12-14 19:21:47.000000000","message":"based on our discussion in the spec, I suppose you will change to support ipv6 in case both are True, correct?","commit_id":"b87f33a2ceecda71bae8afa8f358370514dbf677"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a11011867e47ce6b33ee78bb0b28d044e1218878","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv4_enabled\u0027, None):"},{"line_number":140,"context_line":"            ip_version \u003d \u00274\u0027"},{"line_number":141,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv6_enabled\u0027, None):"},{"line_number":142,"context_line":"            ip_version \u003d \u00276\u0027"},{"line_number":143,"context_line":"        self.network_type \u003d ("},{"line_number":144,"context_line":"            self.configuration.standalone_network_plugin_network_type)"},{"line_number":145,"context_line":"        self.segmentation_id \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_94edaff1","line":142,"updated":"2016-12-23 16:04:35.000000000","message":"Please log an info message if both are configured but only ipv6 is supported.","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"104487b26aa2c8079fc3458cb4bca9b0497dd74b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv4_enabled\u0027, None):"},{"line_number":140,"context_line":"            ip_version \u003d \u00274\u0027"},{"line_number":141,"context_line":"        if getattr(self.configuration, \u0027network_plugin_ipv6_enabled\u0027, None):"},{"line_number":142,"context_line":"            ip_version \u003d \u00276\u0027"},{"line_number":143,"context_line":"        self.network_type \u003d ("},{"line_number":144,"context_line":"            self.configuration.standalone_network_plugin_network_type)"},{"line_number":145,"context_line":"        self.segmentation_id \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_fa5fb93e","line":142,"in_reply_to":"da4df55a_94edaff1","updated":"2016-12-24 06:59:51.000000000","message":"Done","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e441f0fbed293402f5b19b774cf91fd8e1160730","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if ipv6_enabled:"},{"line_number":146,"context_line":"            ip_version \u003d \u00276\u0027"},{"line_number":147,"context_line":"        if ipv4_enabled and ipv6_enabled:"},{"line_number":148,"context_line":"            LOG.info(_LI(\"Only IPv6 is enabled, although both \""},{"line_number":149,"context_line":"                         \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":150,"context_line":"                         \"\u0027network_plugin_ipv6_enabled\u0027 are configured True.\"))"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_1878002a","line":148,"range":{"start_line":148,"start_character":16,"end_line":148,"end_character":20},"updated":"2016-12-24 22:52:21.000000000","message":"I believe this should be a warning, as it is an undesirable situation, the admin should configure one of both, not both.","commit_id":"3ddcd2c913b513db9876cb8a6c23cae5d6893230"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":68,"context_line":"        deprecated_reason\u003d\"This option isn\u0027t used any longer. Please \""},{"line_number":69,"context_line":"                          \"use \u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv6_enabled\u0027 instead.\","},{"line_number":71,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_5f429b3f","line":68,"range":{"start_line":68,"start_character":27,"end_line":68,"end_character":68},"updated":"2017-01-20 03:57:11.000000000","message":"This option has been replaced by \u0027network_plugin_ipv4_enabled\u0027 and \u0027network_plugin_ipv6_enabled\u0027","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":68,"context_line":"        deprecated_reason\u003d\"This option isn\u0027t used any longer. Please \""},{"line_number":69,"context_line":"                          \"use \u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv6_enabled\u0027 instead.\","},{"line_number":71,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_a208bf2e","line":68,"range":{"start_line":68,"start_character":27,"end_line":68,"end_character":68},"in_reply_to":"5a3905b3_5f429b3f","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab52a3158b583668b8881b9cff76c95ba5fad649","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":68,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":69,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv6_enabled\u0027 options.\","},{"line_number":71,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":72,"context_line":"    cfg.IntOpt("},{"line_number":73,"context_line":"        \u0027standalone_network_plugin_mtu\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_4fb9512e","line":70,"range":{"start_line":67,"start_character":8,"end_line":70,"end_character":67},"updated":"2017-01-25 13:13:48.000000000","message":"It was not, because you use this opt on line 134.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":68,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":69,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv6_enabled\u0027 options.\","},{"line_number":71,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":72,"context_line":"    cfg.IntOpt("},{"line_number":73,"context_line":"        \u0027standalone_network_plugin_mtu\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_96cfb0af","line":70,"range":{"start_line":67,"start_character":8,"end_line":70,"end_character":67},"in_reply_to":"3a461143_4fb9512e","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c8d80386c977f47e6ab4ca221a2974b06833181d","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def __init__(self, config_group_name\u003dNone, db_driver\u003dNone, label\u003d\u0027user\u0027):"},{"line_number":96,"context_line":"        super(StandaloneNetworkPlugin,"},{"line_number":97,"context_line":"              self).__init__(config_group_name\u003dconfig_group_name or \u0027DEFAULT\u0027,"},{"line_number":98,"context_line":"                             db_driver\u003ddb_driver)"},{"line_number":99,"context_line":"        self.config_group_name \u003d config_group_name or \u0027DEFAULT\u0027"},{"line_number":100,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_eff75df3","line":97,"range":{"start_line":97,"start_character":29,"end_line":97,"end_character":78},"updated":"2017-01-25 13:15:05.000000000","message":"It is duplication of line 99. Switch them and reuse that line results here.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def __init__(self, config_group_name\u003dNone, db_driver\u003dNone, label\u003d\u0027user\u0027):"},{"line_number":96,"context_line":"        super(StandaloneNetworkPlugin,"},{"line_number":97,"context_line":"              self).__init__(config_group_name\u003dconfig_group_name or \u0027DEFAULT\u0027,"},{"line_number":98,"context_line":"                             db_driver\u003ddb_driver)"},{"line_number":99,"context_line":"        self.config_group_name \u003d config_group_name or \u0027DEFAULT\u0027"},{"line_number":100,"context_line":"        CONF.register_opts("}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_566388b1","line":97,"range":{"start_line":97,"start_character":29,"end_line":97,"end_character":78},"in_reply_to":"3a461143_eff75df3","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b88553b01ff126feb93f4e3b7ea048ebaf8d5290","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # either IPv4 or IPv6, so if both network_plugin_ipv4_enabled"},{"line_number":136,"context_line":"        # and network_plugin_ipv6_enabled are configured True"},{"line_number":137,"context_line":"        # we would only support ipv6."},{"line_number":138,"context_line":"        ipv4_enabled \u003d getattr(self.configuration,"},{"line_number":139,"context_line":"                               \u0027network_plugin_ipv4_enabled\u0027, None)"},{"line_number":140,"context_line":"        ipv6_enabled \u003d getattr(self.configuration,"},{"line_number":141,"context_line":"                               \u0027network_plugin_ipv6_enabled\u0027, None)"},{"line_number":142,"context_line":"        if ipv4_enabled:"},{"line_number":143,"context_line":"            ip_version \u003d 4"},{"line_number":144,"context_line":"        if ipv6_enabled:"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a461143_bdb1a7e3","line":141,"range":{"start_line":138,"start_character":8,"end_line":141,"end_character":67},"updated":"2017-01-27 11:27:05.000000000","message":"ipv4_enabled \u003d self.configuration.network_plugin_ipv4_enabled\nipv6_enabled \u003d self.configuration.network_plugin_ipv6_enabled","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"6aa8a777a83cc85b77cc0783a4e1cb1f16c4bee0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # either IPv4 or IPv6, so if both network_plugin_ipv4_enabled"},{"line_number":136,"context_line":"        # and network_plugin_ipv6_enabled are configured True"},{"line_number":137,"context_line":"        # we would only support ipv6."},{"line_number":138,"context_line":"        ipv4_enabled \u003d getattr(self.configuration,"},{"line_number":139,"context_line":"                               \u0027network_plugin_ipv4_enabled\u0027, None)"},{"line_number":140,"context_line":"        ipv6_enabled \u003d getattr(self.configuration,"},{"line_number":141,"context_line":"                               \u0027network_plugin_ipv6_enabled\u0027, None)"},{"line_number":142,"context_line":"        if ipv4_enabled:"},{"line_number":143,"context_line":"            ip_version \u003d 4"},{"line_number":144,"context_line":"        if ipv6_enabled:"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a430d35_d9789e92","line":141,"range":{"start_line":138,"start_character":8,"end_line":141,"end_character":67},"in_reply_to":"3a461143_bdb1a7e3","updated":"2017-02-04 06:27:34.000000000","message":"Done","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"standalone_network_plugin_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027standalone_network_plugin_gateway\u0027,"},{"line_number":30,"context_line":"        help\u003d\"Gateway IPv4 address that should be used. Required.\","},{"line_number":31,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027standalone_network_plugin_mask\u0027,"},{"line_number":34,"context_line":"        help\u003d\"Network mask that will be used. Can be either decimal \""}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_cf9613f1","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":36},"updated":"2017-07-05 20:33:17.000000000","message":"Current codebase only allows for a single gateway and assumes that it is IPv4.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"standalone_network_plugin_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027standalone_network_plugin_gateway\u0027,"},{"line_number":30,"context_line":"        help\u003d\"Gateway IPv4 address that should be used. Required.\","},{"line_number":31,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027standalone_network_plugin_mask\u0027,"},{"line_number":34,"context_line":"        help\u003d\"Network mask that will be used. Can be either decimal \""}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_494f8e92","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":36},"in_reply_to":"3f1d235d_cf9613f1","updated":"2017-07-06 11:47:20.000000000","message":"Remove IPv4, As we agreement in IRC meeting, we can only support either IPv4 or IPv6 with DHSS\u003dTrue. Fix this code now","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u0027standalone_network_plugin_gateway\u0027,"},{"line_number":30,"context_line":"        help\u003d\"Gateway IPv4 address that should be used. Required.\","},{"line_number":31,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027standalone_network_plugin_mask\u0027,"},{"line_number":34,"context_line":"        help\u003d\"Network mask that will be used. Can be either decimal \""},{"line_number":35,"context_line":"             \"like \u002724\u0027 or binary like \u0027255.255.255.0\u0027. Required.\","},{"line_number":36,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt("},{"line_number":38,"context_line":"        \u0027standalone_network_plugin_network_type\u0027,"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_6fa13f46","line":35,"range":{"start_line":32,"start_character":4,"end_line":35,"end_character":67},"updated":"2017-07-05 20:33:17.000000000","message":"Current codebase only allows for a single netmask and assumes that it is IPv4.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u0027standalone_network_plugin_gateway\u0027,"},{"line_number":30,"context_line":"        help\u003d\"Gateway IPv4 address that should be used. Required.\","},{"line_number":31,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027standalone_network_plugin_mask\u0027,"},{"line_number":34,"context_line":"        help\u003d\"Network mask that will be used. Can be either decimal \""},{"line_number":35,"context_line":"             \"like \u002724\u0027 or binary like \u0027255.255.255.0\u0027. Required.\","},{"line_number":36,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt("},{"line_number":38,"context_line":"        \u0027standalone_network_plugin_network_type\u0027,"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_0913d667","line":35,"range":{"start_line":32,"start_character":4,"end_line":35,"end_character":67},"in_reply_to":"3f1d235d_6fa13f46","updated":"2017-07-06 11:47:20.000000000","message":"above","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"             \"share servers. Optional. Example: 1001\","},{"line_number":52,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":53,"context_line":"    cfg.ListOpt("},{"line_number":54,"context_line":"        \u0027standalone_network_plugin_allowed_ip_ranges\u0027,"},{"line_number":55,"context_line":"        help\u003d\"Can be IP address, range of IP addresses or list of addresses \""},{"line_number":56,"context_line":"             \"or ranges. Contains addresses from IP network that are allowed \""},{"line_number":57,"context_line":"             \"to be used. If empty, then will be assumed that all host \""}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_2f5ea743","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":54},"updated":"2017-07-05 20:33:17.000000000","message":"Even if a list of ip ranges is supplied, the current codebase assumes that all of these ranges are on a single network.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"             \"share servers. Optional. Example: 1001\","},{"line_number":52,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":53,"context_line":"    cfg.ListOpt("},{"line_number":54,"context_line":"        \u0027standalone_network_plugin_allowed_ip_ranges\u0027,"},{"line_number":55,"context_line":"        help\u003d\"Can be IP address, range of IP addresses or list of addresses \""},{"line_number":56,"context_line":"             \"or ranges. Contains addresses from IP network that are allowed \""},{"line_number":57,"context_line":"             \"to be used. If empty, then will be assumed that all host \""}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_8ce5b43a","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":54},"in_reply_to":"3f1d235d_2f5ea743","updated":"2017-07-06 11:47:20.000000000","message":"Yes, We can only support a single network.\nhttp://eavesdrop.openstack.org/meetings/manila/2017/manila.2017-06-15-15.00.log.html#l-28","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    cfg.IntOpt("},{"line_number":63,"context_line":"        \u0027standalone_network_plugin_ip_version\u0027,"},{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":68,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":69,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_6fe93fb5","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":67},"updated":"2017-07-05 20:33:17.000000000","message":"I think the help message should say that this option is no longer used and has no effect.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    cfg.IntOpt("},{"line_number":63,"context_line":"        \u0027standalone_network_plugin_ip_version\u0027,"},{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027.\","},{"line_number":67,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":68,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":69,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_4c3afc98","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":67},"in_reply_to":"3f1d235d_6fe93fb5","updated":"2017-07-06 11:47:20.000000000","message":"Done","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.mask \u003d self.configuration.standalone_network_plugin_mask"},{"line_number":148,"context_line":"        self.allowed_ip_ranges \u003d ("},{"line_number":149,"context_line":"            self.configuration.standalone_network_plugin_allowed_ip_ranges)"},{"line_number":150,"context_line":"        self.ip_version \u003d ip_versions"},{"line_number":151,"context_line":"        self.net \u003d self._get_network()"},{"line_number":152,"context_line":"        self.allowed_cidrs \u003d self._get_list_of_allowed_addresses()"},{"line_number":153,"context_line":"        self.reserved_addresses \u003d ("}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_8f325b5d","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":23},"updated":"2017-07-05 20:33:17.000000000","message":"The above code allows both ipv4_enabled and ipv6_enabled to be True, which implies that self.ip_version may be [4, 6].  Shouldn\u0027t we rename it to self.ip_versions ?","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.mask \u003d self.configuration.standalone_network_plugin_mask"},{"line_number":148,"context_line":"        self.allowed_ip_ranges \u003d ("},{"line_number":149,"context_line":"            self.configuration.standalone_network_plugin_allowed_ip_ranges)"},{"line_number":150,"context_line":"        self.ip_version \u003d ip_versions"},{"line_number":151,"context_line":"        self.net \u003d self._get_network()"},{"line_number":152,"context_line":"        self.allowed_cidrs \u003d self._get_list_of_allowed_addresses()"},{"line_number":153,"context_line":"        self.reserved_addresses \u003d ("}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_c7102551","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":23},"in_reply_to":"3f1d235d_8f325b5d","updated":"2017-07-06 11:47:20.000000000","message":"Roll-back to pre-version code.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \u0027segmentation_id\u0027: self.segmentation_id,"},{"line_number":271,"context_line":"            \u0027cidr\u0027: six.text_type(self.net.cidr),"},{"line_number":272,"context_line":"            \u0027gateway\u0027: six.text_type(self.gateway),"},{"line_number":273,"context_line":"            \u0027ip_version\u0027: self.net.version,"},{"line_number":274,"context_line":"            \u0027mtu\u0027: self.mtu,"},{"line_number":275,"context_line":"        }"},{"line_number":276,"context_line":"        share_network.update(data)"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_a1052b13","line":273,"range":{"start_line":273,"start_character":0,"end_line":273,"end_character":43},"updated":"2017-07-05 20:33:17.000000000","message":"After setting things up so that [4, 6] is a valid value for self.ip_version (which I think should be named self.ip_versions) you then ignore that list value and use self.net.version which was set by the old code path using old config values like standalone_network_plugin_gateway and standalone_network_plugin_mask, which only work for a single address family.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \u0027segmentation_id\u0027: self.segmentation_id,"},{"line_number":271,"context_line":"            \u0027cidr\u0027: six.text_type(self.net.cidr),"},{"line_number":272,"context_line":"            \u0027gateway\u0027: six.text_type(self.gateway),"},{"line_number":273,"context_line":"            \u0027ip_version\u0027: self.net.version,"},{"line_number":274,"context_line":"            \u0027mtu\u0027: self.mtu,"},{"line_number":275,"context_line":"        }"},{"line_number":276,"context_line":"        share_network.update(data)"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_276fd9c5","line":273,"range":{"start_line":273,"start_character":0,"end_line":273,"end_character":43},"in_reply_to":"3f1d235d_a1052b13","updated":"2017-07-06 11:47:20.000000000","message":"Roll-back to pre-version code.","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8189fd77e56ebbd25c897c55096485851fcffd47","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # NOTE(tommylikehu): Standalone plugin could only support"},{"line_number":136,"context_line":"        # either IPv4 or IPv6, so if both network_plugin_ipv4_enabled"},{"line_number":137,"context_line":"        # and network_plugin_ipv6_enabled are configured True"},{"line_number":138,"context_line":"        # we would only support ipv6."},{"line_number":139,"context_line":"        ipv4_enabled \u003d getattr(self.configuration,"},{"line_number":140,"context_line":"                               \u0027network_plugin_ipv4_enabled\u0027, None)"},{"line_number":141,"context_line":"        ipv6_enabled \u003d getattr(self.configuration,"}],"source_content_type":"text/x-python","patch_set":56,"id":"3f1d235d_32c10382","line":138,"range":{"start_line":138,"start_character":32,"end_line":138,"end_character":34},"updated":"2017-07-09 15:04:36.000000000","message":"IP","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c30caaec3b353119d22fbe3a041df457dd39ea41","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        # NOTE(tommylikehu): Standalone plugin could only support"},{"line_number":136,"context_line":"        # either IPv4 or IPv6, so if both network_plugin_ipv4_enabled"},{"line_number":137,"context_line":"        # and network_plugin_ipv6_enabled are configured True"},{"line_number":138,"context_line":"        # we would only support ipv6."},{"line_number":139,"context_line":"        ipv4_enabled \u003d getattr(self.configuration,"},{"line_number":140,"context_line":"                               \u0027network_plugin_ipv4_enabled\u0027, None)"},{"line_number":141,"context_line":"        ipv6_enabled \u003d getattr(self.configuration,"}],"source_content_type":"text/x-python","patch_set":56,"id":"3f1d235d_e19df80a","line":138,"range":{"start_line":138,"start_character":32,"end_line":138,"end_character":34},"in_reply_to":"3f1d235d_32c10382","updated":"2017-07-10 06:44:37.000000000","message":"Done","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fc44ad31069e6c6beb7083171b556d2fb21deb0f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            LOG.warning(\"Only IPv6 is enabled, although both \""},{"line_number":150,"context_line":"                        \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":151,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 are \""},{"line_number":152,"context_line":"                        \"configured True.\")"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.network_type \u003d ("},{"line_number":155,"context_line":"            self.configuration.standalone_network_plugin_network_type)"}],"source_content_type":"text/x-python","patch_set":67,"id":"ff346bd7_6635b6f7","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":40},"updated":"2017-07-21 20:37:35.000000000","message":"configured to be True.","commit_id":"260094dfb331039d7c735d0abd3bcb9309027809"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c1b0cdf149d6d61c710c76d0f535c5b3eee809e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027. \""},{"line_number":67,"context_line":"             \"Note: This option is no longer used and has no effect\","},{"line_number":68,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_167c4e70","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":69},"updated":"2017-07-26 21:57:37.000000000","message":"Why break deployers on upgrade when you can easily match what this opt should map to when the new opts aren\u0027t provided","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027. \""},{"line_number":67,"context_line":"             \"Note: This option is no longer used and has no effect\","},{"line_number":68,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_810c68a5","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":69},"in_reply_to":"ff346bd7_167c4e70","updated":"2017-07-27 07:39:05.000000000","message":"Done","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cfab44a354057ef4b23103cd28501446ce79981d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"             \"10.0.0.10-10.0.0.20,10.0.0.30-10.0.0.40,10.0.0.50\","},{"line_number":61,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":62,"context_line":"    cfg.IntOpt("},{"line_number":63,"context_line":"        \u0027standalone_network_plugin_ip_version\u0027,"},{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027. \""},{"line_number":67,"context_line":"             \"Note: This option is no longer used and has no effect\","},{"line_number":68,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":71,"context_line":"                          \"\u0027network_plugin_ipv6_enabled\u0027 options.\","},{"line_number":72,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt("},{"line_number":74,"context_line":"        \u0027standalone_network_plugin_mtu\u0027,"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_5d5e7c12","line":71,"range":{"start_line":63,"start_character":0,"end_line":71,"end_character":67},"updated":"2017-07-26 18:35:07.000000000","message":"deprecated_since\u003d\u00275.0.0\u0027","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":60,"context_line":"             \"10.0.0.10-10.0.0.20,10.0.0.30-10.0.0.40,10.0.0.50\","},{"line_number":61,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":62,"context_line":"    cfg.IntOpt("},{"line_number":63,"context_line":"        \u0027standalone_network_plugin_ip_version\u0027,"},{"line_number":64,"context_line":"        default\u003d4,"},{"line_number":65,"context_line":"        help\u003d\"IP version of network. Optional.\""},{"line_number":66,"context_line":"             \"Allowed values are \u00274\u0027 and \u00276\u0027. Default value is \u00274\u0027. \""},{"line_number":67,"context_line":"             \"Note: This option is no longer used and has no effect\","},{"line_number":68,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"        deprecated_reason\u003d\"This option has been replaced by \""},{"line_number":70,"context_line":"                          \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":71,"context_line":"                          \"\u0027network_plugin_ipv6_enabled\u0027 options.\","},{"line_number":72,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt("},{"line_number":74,"context_line":"        \u0027standalone_network_plugin_mtu\u0027,"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_5e80a1bf","line":71,"range":{"start_line":63,"start_character":0,"end_line":71,"end_character":67},"in_reply_to":"ff346bd7_5d5e7c12","updated":"2017-07-27 07:39:05.000000000","message":"What is 5.0.0?","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c1b0cdf149d6d61c710c76d0f535c5b3eee809e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            ip_version \u003d 4"},{"line_number":146,"context_line":"        if ipv6_enabled:"},{"line_number":147,"context_line":"            ip_version \u003d 6"},{"line_number":148,"context_line":"        if ipv4_enabled and ipv6_enabled:"},{"line_number":149,"context_line":"            LOG.warning(\"Only IPv6 is enabled, although both \""},{"line_number":150,"context_line":"                        \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":151,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 are \""},{"line_number":152,"context_line":"                        \"configured True.\")"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.network_type \u003d ("},{"line_number":155,"context_line":"            self.configuration.standalone_network_plugin_network_type)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_b668e2b8","line":152,"range":{"start_line":148,"start_character":8,"end_line":152,"end_character":43},"updated":"2017-07-26 21:57:37.000000000","message":"What happens if neither is configured?\n\n\nif not (ipv4_enabled or ipv6_enabled):\n   ip_version \u003d int(\n            self.configuration.standalone_network_plugin_ip_version)\n   LOG.warning(\"You\u0027re using a deprecated option that may\"\n                    \" be removed and silently ignored in the future.. \"\n                    \" use opt1/opt2 instead..yada yada\")\n\nThis is how this should be deprecated... Add a #TODO saying this has to be removed when the option isn\u0027t supported any longer.","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            ip_version \u003d 4"},{"line_number":146,"context_line":"        if ipv6_enabled:"},{"line_number":147,"context_line":"            ip_version \u003d 6"},{"line_number":148,"context_line":"        if ipv4_enabled and ipv6_enabled:"},{"line_number":149,"context_line":"            LOG.warning(\"Only IPv6 is enabled, although both \""},{"line_number":150,"context_line":"                        \"\u0027network_plugin_ipv4_enabled\u0027 and \""},{"line_number":151,"context_line":"                        \"\u0027network_plugin_ipv6_enabled\u0027 are \""},{"line_number":152,"context_line":"                        \"configured True.\")"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.network_type \u003d ("},{"line_number":155,"context_line":"            self.configuration.standalone_network_plugin_network_type)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_fad1a824","line":152,"range":{"start_line":148,"start_character":8,"end_line":152,"end_character":43},"in_reply_to":"ff346bd7_b668e2b8","updated":"2017-07-27 07:39:05.000000000","message":"Done","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"}],"manila/scheduler/host_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if not pool_cap.get(\u0027replication_domain\u0027):"},{"line_number":323,"context_line":"            pool_cap[\u0027replication_domain\u0027] \u003d self.replication_domain"},{"line_number":324,"context_line":"        if self.ipv4_support is not None:"},{"line_number":325,"context_line":"            pool_cap[\u0027ipv4_support\u0027] \u003d self.ipv4_support"},{"line_number":326,"context_line":"        if self.ipv6_support is not None:"},{"line_number":327,"context_line":"            pool_cap[\u0027ipv6_support\u0027] \u003d self.ipv6_support"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def update_backend(self, capability):"},{"line_number":330,"context_line":"        self.share_backend_name \u003d capability.get(\u0027share_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_bfd7ffeb","line":327,"range":{"start_line":324,"start_character":0,"end_line":327,"end_character":56},"updated":"2017-01-20 03:57:11.000000000","message":"so these cannot be reported at the pool level?","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"35e92ea8f0e1f861905b7d9eb5f37e14d79de4d4","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if not pool_cap.get(\u0027replication_domain\u0027):"},{"line_number":323,"context_line":"            pool_cap[\u0027replication_domain\u0027] \u003d self.replication_domain"},{"line_number":324,"context_line":"        if self.ipv4_support is not None:"},{"line_number":325,"context_line":"            pool_cap[\u0027ipv4_support\u0027] \u003d self.ipv4_support"},{"line_number":326,"context_line":"        if self.ipv6_support is not None:"},{"line_number":327,"context_line":"            pool_cap[\u0027ipv6_support\u0027] \u003d self.ipv6_support"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def update_backend(self, capability):"},{"line_number":330,"context_line":"        self.share_backend_name \u003d capability.get(\u0027share_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_23f9e3c7","line":327,"range":{"start_line":324,"start_character":0,"end_line":327,"end_character":56},"in_reply_to":"5a3905b3_1d51f60e","updated":"2017-01-23 03:55:44.000000000","message":"No they can\u0027t according to the implementation. I think that\u0027s fine. I was only asking if this was intentional. \n\nIt probably does not make sense that pools within a given back end would differ in their IP version support.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b40f7dae85d5d9d73f0e5ce4e37b79de5c5fc1f3","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if not pool_cap.get(\u0027replication_domain\u0027):"},{"line_number":323,"context_line":"            pool_cap[\u0027replication_domain\u0027] \u003d self.replication_domain"},{"line_number":324,"context_line":"        if self.ipv4_support is not None:"},{"line_number":325,"context_line":"            pool_cap[\u0027ipv4_support\u0027] \u003d self.ipv4_support"},{"line_number":326,"context_line":"        if self.ipv6_support is not None:"},{"line_number":327,"context_line":"            pool_cap[\u0027ipv6_support\u0027] \u003d self.ipv6_support"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def update_backend(self, capability):"},{"line_number":330,"context_line":"        self.share_backend_name \u003d capability.get(\u0027share_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_e488c073","line":327,"range":{"start_line":324,"start_character":0,"end_line":327,"end_character":56},"in_reply_to":"5a3905b3_23f9e3c7","updated":"2017-01-23 06:40:21.000000000","message":"I get your point now, yes this could override the capabilities reported at pool levels, but as you said, we won\u0027t have the case that the capabilities are differs from backend to pools","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if not pool_cap.get(\u0027replication_domain\u0027):"},{"line_number":323,"context_line":"            pool_cap[\u0027replication_domain\u0027] \u003d self.replication_domain"},{"line_number":324,"context_line":"        if self.ipv4_support is not None:"},{"line_number":325,"context_line":"            pool_cap[\u0027ipv4_support\u0027] \u003d self.ipv4_support"},{"line_number":326,"context_line":"        if self.ipv6_support is not None:"},{"line_number":327,"context_line":"            pool_cap[\u0027ipv6_support\u0027] \u003d self.ipv6_support"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def update_backend(self, capability):"},{"line_number":330,"context_line":"        self.share_backend_name \u003d capability.get(\u0027share_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_1d51f60e","line":327,"range":{"start_line":324,"start_character":0,"end_line":327,"end_character":56},"in_reply_to":"5a3905b3_bfd7ffeb","updated":"2017-01-20 09:36:15.000000000","message":"yes, they can, these lines are added to copy the capabilities from backend to pools.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        self.replication_type \u003d capability.get(\u0027replication_type\u0027)"},{"line_number":345,"context_line":"        self.replication_domain \u003d capability.get(\u0027replication_domain\u0027)"},{"line_number":346,"context_line":"        if capability.get(\u0027ipv4_support\u0027) is not None:"},{"line_number":347,"context_line":"            self.ipv4_support \u003d capability.get(\u0027ipv4_support\u0027)"},{"line_number":348,"context_line":"        if capability.get(\u0027ipv6_support\u0027) is not None:"},{"line_number":349,"context_line":"            self.ipv6_support \u003d capability.get(\u0027ipv6_support\u0027)"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_dfddab15","line":347,"range":{"start_line":347,"start_character":42,"end_line":347,"end_character":47},"updated":"2017-01-20 03:57:11.000000000","message":"[]","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        self.replication_type \u003d capability.get(\u0027replication_type\u0027)"},{"line_number":345,"context_line":"        self.replication_domain \u003d capability.get(\u0027replication_domain\u0027)"},{"line_number":346,"context_line":"        if capability.get(\u0027ipv4_support\u0027) is not None:"},{"line_number":347,"context_line":"            self.ipv4_support \u003d capability.get(\u0027ipv4_support\u0027)"},{"line_number":348,"context_line":"        if capability.get(\u0027ipv6_support\u0027) is not None:"},{"line_number":349,"context_line":"            self.ipv6_support \u003d capability.get(\u0027ipv6_support\u0027)"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_3d7dd26e","line":347,"range":{"start_line":347,"start_character":42,"end_line":347,"end_character":47},"in_reply_to":"5a3905b3_dfddab15","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        if capability.get(\u0027ipv4_support\u0027) is not None:"},{"line_number":347,"context_line":"            self.ipv4_support \u003d capability.get(\u0027ipv4_support\u0027)"},{"line_number":348,"context_line":"        if capability.get(\u0027ipv6_support\u0027) is not None:"},{"line_number":349,"context_line":"            self.ipv6_support \u003d capability.get(\u0027ipv6_support\u0027)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def consume_from_share(self, share):"},{"line_number":352,"context_line":"        \"\"\"Incrementally update host state from an share.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_ffe0a7ce","line":349,"range":{"start_line":349,"start_character":42,"end_line":349,"end_character":47},"updated":"2017-01-20 03:57:11.000000000","message":"[]","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        if capability.get(\u0027ipv4_support\u0027) is not None:"},{"line_number":347,"context_line":"            self.ipv4_support \u003d capability.get(\u0027ipv4_support\u0027)"},{"line_number":348,"context_line":"        if capability.get(\u0027ipv6_support\u0027) is not None:"},{"line_number":349,"context_line":"            self.ipv6_support \u003d capability.get(\u0027ipv6_support\u0027)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def consume_from_share(self, share):"},{"line_number":352,"context_line":"        \"\"\"Incrementally update host state from an share.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_7d975a90","line":349,"range":{"start_line":349,"start_character":42,"end_line":349,"end_character":47},"in_reply_to":"5a3905b3_ffe0a7ce","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"}],"manila/scheduler/utils.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"83c74ec24540563eca7e210892381fa89a0cfa29","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            host_state.max_over_subscription_ratio,"},{"line_number":56,"context_line":"        \u0027ipv4_support\u0027: host_state.ipv4_support,"},{"line_number":57,"context_line":"        \u0027ipv6_support\u0027: host_state.ipv6_support"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    host_caps \u003d host_state.capabilities"}],"source_content_type":"text/x-python","patch_set":35,"id":"ff0f0b1f_b703d4be","line":58,"updated":"2017-05-26 04:15:53.000000000","message":"extra newline","commit_id":"0d1910246023ad7d3bdb2c83b2ae722c4faffcee"}],"manila/share/access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ceb6e73cd4e6b27144834fc4778d7ef83bca81c3","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            if rule[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027:"},{"line_number":470,"context_line":"                ip_version \u003d ipaddress.ip_network("},{"line_number":471,"context_line":"                    six.text_type(rule[\u0027access_to\u0027])).version"},{"line_number":472,"context_line":"                if 6 \u003d\u003d ip_version:"},{"line_number":473,"context_line":"                    continue"},{"line_number":474,"context_line":"            filtered.append(rule)"},{"line_number":475,"context_line":"        return filtered"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_19336164","line":473,"range":{"start_line":472,"start_character":35,"end_line":473,"end_character":20},"updated":"2017-07-26 22:18:13.000000000","message":"If you incorporate the message suggestion, you will then:\n\n  if emit_message_if_ipv6_rules_exist:\n      self.message_api.create(\n                context,\n                message_field.Action.ADD_RULE,\n                share[\u0027project_id\u0027],\n                resource_type\u003dmessage_field.Resource.ACCESS_RULE,\n                resource_id\u003drule[\u0027access_id\u0027],\n                detail\u003dmessage_field.Detail.IPv6_NOT_CONFIGURED)\n\n\nIn manila/message/message_field.py#Detail\n\n IPv6_NOT_CONFIGURED \u003d (\n    \u0027007\u0027, _(\"IPv6 capabilities are either not supported or configured \"\n                 \"on the back end. Access rule is ignored. Contact your \"\n                 \"administrator to enable IPv6 support.\")\n )","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            if rule[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027:"},{"line_number":470,"context_line":"                ip_version \u003d ipaddress.ip_network("},{"line_number":471,"context_line":"                    six.text_type(rule[\u0027access_to\u0027])).version"},{"line_number":472,"context_line":"                if 6 \u003d\u003d ip_version:"},{"line_number":473,"context_line":"                    continue"},{"line_number":474,"context_line":"            filtered.append(rule)"},{"line_number":475,"context_line":"        return filtered"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_fa7f6812","line":473,"range":{"start_line":472,"start_character":35,"end_line":473,"end_character":20},"in_reply_to":"ff346bd7_19336164","updated":"2017-07-27 07:39:05.000000000","message":"The meessage suggestion is pretty good. I will add the message in another patch.","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ceb6e73cd4e6b27144834fc4778d7ef83bca81c3","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            r for r in existing_rules_in_db if r[\u0027id\u0027] not in delete_rule_ids"},{"line_number":498,"context_line":"        ]"},{"line_number":499,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":500,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules)"},{"line_number":501,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules)"},{"line_number":502,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":503,"context_line":"                access_rules_to_be_on_share)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_b972157a","line":500,"range":{"start_line":500,"start_character":24,"end_line":500,"end_character":58},"updated":"2017-07-26 22:18:13.000000000","message":"You should special case this and emit a user message.. that would be really helpful\n\n   add_rules \u003d self._filter_ipv6_rules(\n               add_rules, share\u003dshare,\n               emit_message_if_ipv6_rules_exist\u003dTrue)","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            r for r in existing_rules_in_db if r[\u0027id\u0027] not in delete_rule_ids"},{"line_number":498,"context_line":"        ]"},{"line_number":499,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":500,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules)"},{"line_number":501,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules)"},{"line_number":502,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":503,"context_line":"                access_rules_to_be_on_share)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_ba756034","line":500,"range":{"start_line":500,"start_character":24,"end_line":500,"end_character":58},"in_reply_to":"ff346bd7_b972157a","updated":"2017-07-27 07:39:05.000000000","message":"above","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cfab44a354057ef4b23103cd28501446ce79981d","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        access_rules_to_be_on_share \u003d ["},{"line_number":497,"context_line":"            r for r in existing_rules_in_db if r[\u0027id\u0027] not in delete_rule_ids"},{"line_number":498,"context_line":"        ]"},{"line_number":499,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":500,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules)"},{"line_number":501,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules)"},{"line_number":502,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":503,"context_line":"                access_rules_to_be_on_share)"},{"line_number":504,"context_line":"        return access_rules_to_be_on_share, add_rules, delete_rules"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def _check_needs_refresh(self, context, share_instance_id):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_bd57a858","line":503,"range":{"start_line":499,"start_character":0,"end_line":503,"end_character":44},"updated":"2017-07-26 18:35:07.000000000","message":"Would be good to get unit test coverage of this branch.","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        access_rules_to_be_on_share \u003d ["},{"line_number":497,"context_line":"            r for r in existing_rules_in_db if r[\u0027id\u0027] not in delete_rule_ids"},{"line_number":498,"context_line":"        ]"},{"line_number":499,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":500,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules)"},{"line_number":501,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules)"},{"line_number":502,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":503,"context_line":"                access_rules_to_be_on_share)"},{"line_number":504,"context_line":"        return access_rules_to_be_on_share, add_rules, delete_rules"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def _check_needs_refresh(self, context, share_instance_id):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_5e0b017c","line":503,"range":{"start_line":499,"start_character":0,"end_line":503,"end_character":44},"in_reply_to":"ff346bd7_bd57a858","updated":"2017-07-27 07:39:05.000000000","message":"Done","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"}],"manila/share/driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"                                  ipv6_support\u003dFalse):"},{"line_number":2052,"context_line":"        \"\"\"Add ip version support capabilities"},{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"        When DHSS is true, the capabilities is determined by driver and"},{"line_number":2055,"context_line":"        configured network plugin."},{"line_number":2056,"context_line":"        WHen DHSS is false, the capabilities is determined by driver and self"},{"line_number":2057,"context_line":"        configuration."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_8e320f0f","line":2054,"range":{"start_line":2054,"start_character":44,"end_line":2054,"end_character":46},"updated":"2016-12-14 11:02:46.000000000","message":"are","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"                                  ipv6_support\u003dFalse):"},{"line_number":2052,"context_line":"        \"\"\"Add ip version support capabilities"},{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"        When DHSS is true, the capabilities is determined by driver and"},{"line_number":2055,"context_line":"        configured network plugin."},{"line_number":2056,"context_line":"        WHen DHSS is false, the capabilities is determined by driver and self"},{"line_number":2057,"context_line":"        configuration."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_bc361c50","line":2054,"range":{"start_line":2054,"start_character":44,"end_line":2054,"end_character":46},"in_reply_to":"1a6eadb0_8e320f0f","updated":"2016-12-14 13:13:43.000000000","message":"Done","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"        When DHSS is true, the capabilities is determined by driver and"},{"line_number":2055,"context_line":"        configured network plugin."},{"line_number":2056,"context_line":"        WHen DHSS is false, the capabilities is determined by driver and self"},{"line_number":2057,"context_line":"        configuration."},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"        :param data: the capability dictionary"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_ce3c07e5","line":2056,"range":{"start_line":2056,"start_character":45,"end_line":2056,"end_character":47},"updated":"2016-12-14 11:02:46.000000000","message":"are","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"        When DHSS is true, the capabilities is determined by driver and"},{"line_number":2055,"context_line":"        configured network plugin."},{"line_number":2056,"context_line":"        WHen DHSS is false, the capabilities is determined by driver and self"},{"line_number":2057,"context_line":"        configuration."},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"        :param data: the capability dictionary"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_dc391843","line":2056,"range":{"start_line":2056,"start_character":45,"end_line":2056,"end_character":47},"in_reply_to":"1a6eadb0_ce3c07e5","updated":"2016-12-14 13:13:43.000000000","message":"Done","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"        return None"},{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2039,"context_line":""},{"line_number":2040,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        the supported versions are returned in tuple, possible"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_6f408808","line":2039,"updated":"2016-12-19 16:05:50.000000000","message":"remove this extra line","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2039,"context_line":""},{"line_number":2040,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        the supported versions are returned in tuple, possible"},{"line_number":2043,"context_line":"        values are: 4, 6"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_6f0ec8e6","line":2040,"range":{"start_line":2040,"start_character":56,"end_line":2040,"end_character":57},"updated":"2016-12-19 16:05:50.000000000","message":"period","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":2039,"context_line":""},{"line_number":2040,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        the supported versions are returned in tuple, possible"},{"line_number":2043,"context_line":"        values are: 4, 6"},{"line_number":2044,"context_line":""},{"line_number":2045,"context_line":"        Each driver could overwrite the method to return the ip versions set"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_8f5c04ef","line":2042,"range":{"start_line":2042,"start_character":8,"end_line":2042,"end_character":9},"updated":"2016-12-19 16:05:50.000000000","message":"uppercase","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2051,"context_line":"                                  ipv6_support\u003dFalse):"},{"line_number":2052,"context_line":"        \"\"\"Add ip version support capabilities"},{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"        When DHSS is true, the capabilities are determined by driver and"},{"line_number":2055,"context_line":"        configured network plugin."}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_0f00f4a9","line":2052,"range":{"start_line":2052,"start_character":45,"end_line":2052,"end_character":46},"updated":"2016-12-19 16:05:50.000000000","message":"period","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"        When DHSS is true, the capabilities are determined by driver and"},{"line_number":2055,"context_line":"        configured network plugin."},{"line_number":2056,"context_line":"        WHen DHSS is false, the capabilities are determined by driver and self"},{"line_number":2057,"context_line":"        configuration."},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"        :param data: the capability dictionary"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_8fe16401","line":2056,"range":{"start_line":2056,"start_character":9,"end_line":2056,"end_character":10},"updated":"2016-12-19 16:05:50.000000000","message":"lowercase","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":2067,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":2068,"context_line":"            usr_network_version \u003d self.network_api.network_plugin_ip_versions()"},{"line_number":2069,"context_line":"            if self.admin_network_api:"},{"line_number":2070,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2071,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2072,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2073,"context_line":"            else:"},{"line_number":2074,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2075,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_2fc69016","line":2072,"range":{"start_line":2070,"start_character":16,"end_line":2072,"end_character":30},"updated":"2016-12-19 16:05:50.000000000","message":"there is the possibility of ip_version \u003d None if usr_network_version is different than admin_network_version, is this expected?","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        ip_version \u003d None"},{"line_number":2067,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":2068,"context_line":"            usr_network_version \u003d self.network_api.network_plugin_ip_versions()"},{"line_number":2069,"context_line":"            if self.admin_network_api:"},{"line_number":2070,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2071,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2072,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2073,"context_line":"            else:"},{"line_number":2074,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2075,"context_line":"        else:"},{"line_number":2076,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2077,"context_line":"        if ipv4_support:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_6f8248ca","line":2074,"range":{"start_line":2069,"start_character":12,"end_line":2074,"end_character":48},"updated":"2016-12-19 16:05:50.000000000","message":"I am a bit confused by this logic. You are always reading the \"usr_network_version\" no matter what, so why the condition of \"if (usr_network_version \u003d\u003d admin_network_version):\"? Are you missing an else statement here?","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a26f2339a43cfcdc4e7b4a362683d79ba125fd37","unresolved":false,"context_lines":[{"line_number":2035,"context_line":"        \"\"\""},{"line_number":2036,"context_line":"        return None"},{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2039,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2040,"context_line":""},{"line_number":2041,"context_line":"        the supported versions are returned in tuple, possible"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_40e7ed11","line":2038,"range":{"start_line":2038,"start_character":8,"end_line":2038,"end_character":37},"updated":"2016-12-20 12:41:30.000000000","message":"seems like this interface is only used in driver itself, changing it to protection name format may be better, _get_configuration_ip_versions","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":2035,"context_line":"        \"\"\""},{"line_number":2036,"context_line":"        return None"},{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2039,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2040,"context_line":""},{"line_number":2041,"context_line":"        the supported versions are returned in tuple, possible"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_e92f50f4","line":2038,"range":{"start_line":2038,"start_character":8,"end_line":2038,"end_character":37},"in_reply_to":"1a6eadb0_40e7ed11","updated":"2016-12-22 03:09:58.000000000","message":"This method could be override by descendent nodes. So I thinks the public method should be ok here.","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c059550b564ac6b8269c76e73e1ebc52b1c6be87","unresolved":false,"context_lines":[{"line_number":2038,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2039,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2040,"context_line":""},{"line_number":2041,"context_line":"        the supported versions are returned in tuple, possible"},{"line_number":2042,"context_line":"        values are: 4, 6"},{"line_number":2043,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2044,"context_line":"        which represents its self configuration."}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_a781c04f","line":2041,"range":{"start_line":2041,"start_character":8,"end_line":2041,"end_character":9},"updated":"2016-12-20 10:15:50.000000000","message":"uppercase","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":2038,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2039,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2040,"context_line":""},{"line_number":2041,"context_line":"        the supported versions are returned in tuple, possible"},{"line_number":2042,"context_line":"        values are: 4, 6"},{"line_number":2043,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2044,"context_line":"        which represents its self configuration."}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_09357445","line":2041,"range":{"start_line":2041,"start_character":8,"end_line":2041,"end_character":9},"in_reply_to":"1a6eadb0_a781c04f","updated":"2016-12-22 03:09:58.000000000","message":"Done","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a26f2339a43cfcdc4e7b4a362683d79ba125fd37","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"        \"\"\""},{"line_number":2046,"context_line":"        return 4"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2049,"context_line":"                                  ipv6_support\u003dFalse):"},{"line_number":2050,"context_line":"        \"\"\"Add ip version support capabilities."},{"line_number":2051,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_c0b93dee","line":2048,"range":{"start_line":2048,"start_character":8,"end_line":2048,"end_character":33},"updated":"2016-12-20 12:41:30.000000000","message":"ditto","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"        \"\"\""},{"line_number":2046,"context_line":"        return 4"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2049,"context_line":"                                  ipv6_support\u003dFalse):"},{"line_number":2050,"context_line":"        \"\"\"Add ip version support capabilities."},{"line_number":2051,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_090c9493","line":2048,"range":{"start_line":2048,"start_character":8,"end_line":2048,"end_character":33},"in_reply_to":"1a6eadb0_c0b93dee","updated":"2016-12-22 03:09:58.000000000","message":"I\u0027d prefer this could be a public method as it\u0027s widely used in different places","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c059550b564ac6b8269c76e73e1ebc52b1c6be87","unresolved":false,"context_lines":[{"line_number":2061,"context_line":"        if not ipv4_support and not ipv6_support:"},{"line_number":2062,"context_line":"            return data"},{"line_number":2063,"context_line":"        ip_version \u003d None"},{"line_number":2064,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":2065,"context_line":"            usr_network_version \u003d self.network_api.network_plugin_ip_versions()"},{"line_number":2066,"context_line":"            if self.admin_network_api:"},{"line_number":2067,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2068,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2069,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_a72b8032","line":2071,"range":{"start_line":2064,"start_character":8,"end_line":2071,"end_character":48},"updated":"2016-12-20 10:15:50.000000000","message":"please clarify previous comment about this","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":2061,"context_line":"        if not ipv4_support and not ipv6_support:"},{"line_number":2062,"context_line":"            return data"},{"line_number":2063,"context_line":"        ip_version \u003d None"},{"line_number":2064,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":2065,"context_line":"            usr_network_version \u003d self.network_api.network_plugin_ip_versions()"},{"line_number":2066,"context_line":"            if self.admin_network_api:"},{"line_number":2067,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2068,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2069,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_09449472","line":2071,"range":{"start_line":2064,"start_character":8,"end_line":2071,"end_character":48},"in_reply_to":"1a6eadb0_a72b8032","updated":"2016-12-22 03:09:58.000000000","message":"The two cases are different. the former one is that both we have the admin_network_api configured and the ip version is matched.","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"a26f2339a43cfcdc4e7b4a362683d79ba125fd37","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"},{"line_number":2077,"context_line":"            data[\u0027ipv6_support\u0027] \u003d True if \u00276\u0027 \u003d\u003d ip_version else False"},{"line_number":2078,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_806ca59d","line":2077,"range":{"start_line":2074,"start_character":7,"end_line":2077,"end_character":71},"updated":"2016-12-20 12:41:30.000000000","message":"As this logic, if a driver reports supporting ipv4, but the network plugin is configured supporting ipv6, then the ipv4_support and ipv6_support both are False, will this cause this backend never get picked by scheduler?\nAnd the network is optional while creating share, so even if driver_handles_share_servers is True for a driver, the share creation process may still not create share server for the new share. At this situation, I think we should allow users to create share, though the network plugin ip version is not consistent with that drivers want to report.\nwhat you think?","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"},{"line_number":2077,"context_line":"            data[\u0027ipv6_support\u0027] \u003d True if \u00276\u0027 \u003d\u003d ip_version else False"},{"line_number":2078,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_899324fa","line":2077,"range":{"start_line":2074,"start_character":7,"end_line":2077,"end_character":71},"in_reply_to":"1a6eadb0_806ca59d","updated":"2016-12-22 03:09:58.000000000","message":"As we discussed offline, the network plugin should be used if dhss\u003dfalse","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a11011867e47ce6b33ee78bb0b28d044e1218878","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"            if self.admin_network_api:"},{"line_number":2067,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2068,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2069,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_b404737e","line":2069,"updated":"2016-12-23 16:04:35.000000000","message":"else?","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"104487b26aa2c8079fc3458cb4bca9b0497dd74b","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"            if self.admin_network_api:"},{"line_number":2067,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2068,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2069,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_6ec06ae1","line":2069,"in_reply_to":"da4df55a_b404737e","updated":"2016-12-24 06:59:51.000000000","message":"My point is that when user and admin network is different the \u0027ip_version\u0027 could be none and as a result data[\u0027ipv4_support\u0027]\nand data[\u0027ipv6_support\u0027] could both be false here","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"994970864144218d374014d4d780765c808ec0de","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"            return data"},{"line_number":2063,"context_line":"        ip_version \u003d None"},{"line_number":2064,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":2065,"context_line":"            usr_network_version \u003d self.network_api.network_plugin_ip_versions()"},{"line_number":2066,"context_line":"            if self.admin_network_api:"},{"line_number":2067,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2068,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2069,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_9ce4360e","line":2071,"range":{"start_line":2065,"start_character":12,"end_line":2071,"end_character":48},"updated":"2016-12-22 10:35:14.000000000","message":"indeed, I see that the former case is user + admin, and the latter is only user network configured. But why does it matter to have the admin configured if you are going to read the user\u0027s? also consider the following:\n\n1) only user configured, result: it goes into the else and ip_version \u003d usr_network_version \u003d\u003d\u003e ok\n\n2) user and admin configured and are equal, result: it goes into the inner condition and ip_version \u003d usr_network_version \u003d\u003d\u003e ok\n\n3) user and admin configured and are different, result: it passes the first condition, but not the second, so ip_version is not set.\n\nDepending on how you address #3, for example, if you address #3 by reading the usr_network_version, then #2 is redundant, as you could always set the ip_version to the usr_network_version regardless.\n\nPlease clarify","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"104487b26aa2c8079fc3458cb4bca9b0497dd74b","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"            return data"},{"line_number":2063,"context_line":"        ip_version \u003d None"},{"line_number":2064,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":2065,"context_line":"            usr_network_version \u003d self.network_api.network_plugin_ip_versions()"},{"line_number":2066,"context_line":"            if self.admin_network_api:"},{"line_number":2067,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2068,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2069,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_0e951edd","line":2071,"range":{"start_line":2065,"start_character":12,"end_line":2071,"end_character":48},"in_reply_to":"da4df55a_9ce4360e","updated":"2016-12-24 06:59:51.000000000","message":"My point is that when user and admin network is different the \u0027ip_version\u0027 could be none and as a result data[\u0027ipv4_support\u0027]\nand data[\u0027ipv6_support\u0027] could both be false here","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a11011867e47ce6b33ee78bb0b28d044e1218878","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_34f96381","line":2073,"updated":"2016-12-23 16:04:35.000000000","message":"str() -\u003e six.text_type()","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"104487b26aa2c8079fc3458cb4bca9b0497dd74b","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"            else:"},{"line_number":2071,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_bab7f184","line":2073,"in_reply_to":"da4df55a_34f96381","updated":"2016-12-24 06:59:51.000000000","message":"Done","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e90ef757f7e6af2e0d2df5a8b54f347d511fe9cd","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"},{"line_number":2077,"context_line":"            data[\u0027ipv6_support\u0027] \u003d True if \u00276\u0027 \u003d\u003d ip_version else False"},{"line_number":2078,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_2fd2ea00","line":2075,"range":{"start_line":2075,"start_character":12,"end_line":2075,"end_character":71},"updated":"2016-12-23 16:39:17.000000000","message":"data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d ip_version","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"104487b26aa2c8079fc3458cb4bca9b0497dd74b","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"        else:"},{"line_number":2073,"context_line":"            ip_version \u003d str(self.get_configuration_ip_versions())"},{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"},{"line_number":2077,"context_line":"            data[\u0027ipv6_support\u0027] \u003d True if \u00276\u0027 \u003d\u003d ip_version else False"},{"line_number":2078,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_fab17990","line":2075,"range":{"start_line":2075,"start_character":12,"end_line":2075,"end_character":71},"in_reply_to":"da4df55a_2fd2ea00","updated":"2016-12-24 06:59:51.000000000","message":"Done","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e90ef757f7e6af2e0d2df5a8b54f347d511fe9cd","unresolved":false,"context_lines":[{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"},{"line_number":2077,"context_line":"            data[\u0027ipv6_support\u0027] \u003d True if \u00276\u0027 \u003d\u003d ip_version else False"},{"line_number":2078,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_6ff3129f","line":2077,"range":{"start_line":2077,"start_character":12,"end_line":2077,"end_character":71},"updated":"2016-12-23 16:39:17.000000000","message":"ditto","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"104487b26aa2c8079fc3458cb4bca9b0497dd74b","unresolved":false,"context_lines":[{"line_number":2074,"context_line":"        if ipv4_support:"},{"line_number":2075,"context_line":"            data[\u0027ipv4_support\u0027] \u003d True if \u00274\u0027 \u003d\u003d ip_version else False"},{"line_number":2076,"context_line":"        if ipv6_support:"},{"line_number":2077,"context_line":"            data[\u0027ipv6_support\u0027] \u003d True if \u00276\u0027 \u003d\u003d ip_version else False"},{"line_number":2078,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":11,"id":"da4df55a_1aad5d31","line":2077,"range":{"start_line":2077,"start_character":12,"end_line":2077,"end_character":71},"in_reply_to":"da4df55a_6ff3129f","updated":"2016-12-24 06:59:51.000000000","message":"Done","commit_id":"3bc8bb061d8ac3dc7bc40fa3705a4378439fc4ac"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e441f0fbed293402f5b19b774cf91fd8e1160730","unresolved":false,"context_lines":[{"line_number":2067,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2068,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2069,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2070,"context_line":"                else:"},{"line_number":2071,"context_line":"                    LOG.warning(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2072,"context_line":"                                    \"version is different from user network \""},{"line_number":2073,"context_line":"                                    \"plugin, this could lead the backend \""}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_b8b454d1","line":2070,"range":{"start_line":2070,"start_character":16,"end_line":2070,"end_character":20},"updated":"2016-12-24 22:52:21.000000000","message":"ok I understand now. It is better to error out than having to choose the IPv6 over IPv4 or vice-versa if both are enabled and not have connectivity working for one of them.","commit_id":"3ddcd2c913b513db9876cb8a6c23cae5d6893230"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e441f0fbed293402f5b19b774cf91fd8e1160730","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"                else:"},{"line_number":2071,"context_line":"                    LOG.warning(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2072,"context_line":"                                    \"version is different from user network \""},{"line_number":2073,"context_line":"                                    \"plugin, this could lead the backend \""},{"line_number":2074,"context_line":"                                    \"never chosen by scheduler when ip \""},{"line_number":2075,"context_line":"                                    \"version is specified in share type.\"))"},{"line_number":2076,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_b89d345b","line":2073,"range":{"start_line":2073,"start_character":56,"end_line":2073,"end_character":64},"updated":"2016-12-24 22:52:21.000000000","message":"lead to the","commit_id":"3ddcd2c913b513db9876cb8a6c23cae5d6893230"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e441f0fbed293402f5b19b774cf91fd8e1160730","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"                    LOG.warning(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2072,"context_line":"                                    \"version is different from user network \""},{"line_number":2073,"context_line":"                                    \"plugin, this could lead the backend \""},{"line_number":2074,"context_line":"                                    \"never chosen by scheduler when ip \""},{"line_number":2075,"context_line":"                                    \"version is specified in share type.\"))"},{"line_number":2076,"context_line":"            else:"},{"line_number":2077,"context_line":"                ip_version \u003d usr_network_version"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_f89fbc4d","line":2074,"range":{"start_line":2074,"start_character":50,"end_line":2074,"end_character":62},"updated":"2016-12-24 22:52:21.000000000","message":"by the scheduler","commit_id":"3ddcd2c913b513db9876cb8a6c23cae5d6893230"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e441f0fbed293402f5b19b774cf91fd8e1160730","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"                    LOG.warning(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2072,"context_line":"                                    \"version is different from user network \""},{"line_number":2073,"context_line":"                                    \"plugin, this could lead the backend \""},{"line_number":2074,"context_line":"                                    \"never chosen by scheduler when ip \""},{"line_number":2075,"context_line":"                                    \"version is specified in share type.\"))"},{"line_number":2076,"context_line":"            else:"},{"line_number":2077,"context_line":"                ip_version \u003d usr_network_version"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_d8a4b8a7","line":2074,"range":{"start_line":2074,"start_character":37,"end_line":2074,"end_character":49},"updated":"2016-12-24 22:52:21.000000000","message":"never being chosen","commit_id":"3ddcd2c913b513db9876cb8a6c23cae5d6893230"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e441f0fbed293402f5b19b774cf91fd8e1160730","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"                                    \"version is different from user network \""},{"line_number":2073,"context_line":"                                    \"plugin, this could lead the backend \""},{"line_number":2074,"context_line":"                                    \"never chosen by scheduler when ip \""},{"line_number":2075,"context_line":"                                    \"version is specified in share type.\"))"},{"line_number":2076,"context_line":"            else:"},{"line_number":2077,"context_line":"                ip_version \u003d usr_network_version"},{"line_number":2078,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_18af2082","line":2075,"range":{"start_line":2075,"start_character":58,"end_line":2075,"end_character":71},"updated":"2016-12-24 22:52:21.000000000","message":"in the share type","commit_id":"3ddcd2c913b513db9876cb8a6c23cae5d6893230"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d7a743c7af1be25c8a62313229eaa260c9825e1d","unresolved":false,"context_lines":[{"line_number":2080,"context_line":"                if (usr_network_version \u003d\u003d"},{"line_number":2081,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2082,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2083,"context_line":"                else:"},{"line_number":2084,"context_line":"                    LOG.error(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2085,"context_line":"                                  \"version is different from user network \""},{"line_number":2086,"context_line":"                                  \"plugin, this could lead to the backend \""},{"line_number":2087,"context_line":"                                  \"never been chosen by the scheduler when \""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_bb957741","line":2084,"range":{"start_line":2083,"start_character":16,"end_line":2084,"end_character":29},"updated":"2016-12-31 20:24:37.000000000","message":"What I meant by error\u0027ing out is that this scenario will cause an error later (I presume) because ipv4_support will be False and ipv6_support will be False. So is it better to just let this method continue and later raise the error or raise an exception here?","commit_id":"723b9629cfc6189198aaabac22da52d99a81bd51"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"        \"\"\""},{"line_number":2100,"context_line":"        return None"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2103,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_da31390d","line":2102,"range":{"start_line":2102,"start_character":8,"end_line":2102,"end_character":37},"updated":"2017-01-20 03:57:11.000000000","message":"I\u0027m confused about the need for this method. Why would we need this method when you have added \u0027ipv4_support\u0027 to all the drivers via  add_ip_version_capability?","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"        \"\"\""},{"line_number":2100,"context_line":"        return None"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2103,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_1d3bb69d","line":2102,"range":{"start_line":2102,"start_character":8,"end_line":2102,"end_character":37},"in_reply_to":"5a3905b3_da31390d","updated":"2017-01-20 09:36:15.000000000","message":"I add this method is because that the final reported capabilities(regarding IPv4 and IPv6)is based on the driver\u0027s capabilities and the backend configurations(dhss\u003dfalse).","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2106,"context_line":"        values are: 4, 6"},{"line_number":2107,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2108,"context_line":"        which represents its self configuration."},{"line_number":2109,"context_line":"        \"\"\""},{"line_number":2110,"context_line":"        return 4"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_ff2ee7f8","line":2107,"range":{"start_line":2107,"start_character":61,"end_line":2107,"end_character":63},"updated":"2017-01-20 03:57:11.000000000","message":"IP","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2106,"context_line":"        values are: 4, 6"},{"line_number":2107,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2108,"context_line":"        which represents its self configuration."},{"line_number":2109,"context_line":"        \"\"\""},{"line_number":2110,"context_line":"        return 4"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_9ff3239e","line":2107,"range":{"start_line":2107,"start_character":26,"end_line":2107,"end_character":35},"updated":"2017-01-20 03:57:11.000000000","message":"override","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2106,"context_line":"        values are: 4, 6"},{"line_number":2107,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2108,"context_line":"        which represents its self configuration."},{"line_number":2109,"context_line":"        \"\"\""},{"line_number":2110,"context_line":"        return 4"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_3d5952ff","line":2107,"range":{"start_line":2107,"start_character":26,"end_line":2107,"end_character":35},"in_reply_to":"5a3905b3_9ff3239e","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2106,"context_line":"        values are: 4, 6"},{"line_number":2107,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2108,"context_line":"        which represents its self configuration."},{"line_number":2109,"context_line":"        \"\"\""},{"line_number":2110,"context_line":"        return 4"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_5d5c5eed","line":2107,"range":{"start_line":2107,"start_character":61,"end_line":2107,"end_character":63},"in_reply_to":"5a3905b3_ff2ee7f8","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2106,"context_line":"        values are: 4, 6"},{"line_number":2107,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2108,"context_line":"        which represents its self configuration."},{"line_number":2109,"context_line":"        \"\"\""},{"line_number":2110,"context_line":"        return 4"},{"line_number":2111,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_7f3bd738","line":2108,"range":{"start_line":2107,"start_character":72,"end_line":2108,"end_character":47},"updated":"2017-01-20 03:57:11.000000000","message":"it supports","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2106,"context_line":"        values are: 4, 6"},{"line_number":2107,"context_line":"        Each driver could overwrite the method to return the ip versions set"},{"line_number":2108,"context_line":"        which represents its self configuration."},{"line_number":2109,"context_line":"        \"\"\""},{"line_number":2110,"context_line":"        return 4"},{"line_number":2111,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_bd6d429a","line":2108,"range":{"start_line":2107,"start_character":72,"end_line":2108,"end_character":47},"in_reply_to":"5a3905b3_7f3bd738","updated":"2017-01-20 09:36:15.000000000","message":"should be the configured IP version here.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2111,"context_line":""},{"line_number":2112,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2113,"context_line":"                                  ipv6_support\u003dFalse):"},{"line_number":2114,"context_line":"        \"\"\"Add ip version support capabilities."},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        When DHSS is true, the capabilities are determined by driver and"},{"line_number":2117,"context_line":"        configured network plugin."}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_3f5eaf76","line":2114,"range":{"start_line":2114,"start_character":15,"end_line":2114,"end_character":17},"updated":"2017-01-20 03:57:11.000000000","message":"please use IP consistently in all docstrings, comments and exceptions","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2111,"context_line":""},{"line_number":2112,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2113,"context_line":"                                  ipv6_support\u003dFalse):"},{"line_number":2114,"context_line":"        \"\"\"Add ip version support capabilities."},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        When DHSS is true, the capabilities are determined by driver and"},{"line_number":2117,"context_line":"        configured network plugin."}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_9df5e6cc","line":2114,"range":{"start_line":2114,"start_character":15,"end_line":2114,"end_character":17},"in_reply_to":"5a3905b3_3f5eaf76","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2122,"context_line":"        :param ipv6_support: the capability of ipv6_support, default\u003dFalse"},{"line_number":2123,"context_line":"        :return: capability data"},{"line_number":2124,"context_line":"        \"\"\""},{"line_number":2125,"context_line":"        if not ipv4_support and not ipv6_support:"},{"line_number":2126,"context_line":"            return data"},{"line_number":2127,"context_line":"        ip_version \u003d None"},{"line_number":2128,"context_line":"        if self.driver_handles_share_servers:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_3ad5ddb8","line":2125,"range":{"start_line":2125,"start_character":15,"end_line":2125,"end_character":48},"updated":"2017-01-20 03:57:11.000000000","message":"(ipv4_support or ipv6_support)","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2122,"context_line":"        :param ipv6_support: the capability of ipv6_support, default\u003dFalse"},{"line_number":2123,"context_line":"        :return: capability data"},{"line_number":2124,"context_line":"        \"\"\""},{"line_number":2125,"context_line":"        if not ipv4_support and not ipv6_support:"},{"line_number":2126,"context_line":"            return data"},{"line_number":2127,"context_line":"        ip_version \u003d None"},{"line_number":2128,"context_line":"        if self.driver_handles_share_servers:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_9d1c0615","line":2125,"range":{"start_line":2125,"start_character":15,"end_line":2125,"end_character":48},"in_reply_to":"5a3905b3_3ad5ddb8","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2132,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2133,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2134,"context_line":"                else:"},{"line_number":2135,"context_line":"                    LOG.error(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2136,"context_line":"                                  \"version is different from user network \""},{"line_number":2137,"context_line":"                                  \"plugin, this could lead to the backend \""},{"line_number":2138,"context_line":"                                  \"never been chosen by the scheduler when \""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_df95abe4","line":2135,"range":{"start_line":2135,"start_character":35,"end_line":2135,"end_character":68},"updated":"2017-01-20 03:57:11.000000000","message":"The enabled IP version for the admin network plugin is...","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2132,"context_line":"                   self.admin_network_api.network_plugin_ip_versions()):"},{"line_number":2133,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2134,"context_line":"                else:"},{"line_number":2135,"context_line":"                    LOG.error(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2136,"context_line":"                                  \"version is different from user network \""},{"line_number":2137,"context_line":"                                  \"plugin, this could lead to the backend \""},{"line_number":2138,"context_line":"                                  \"never been chosen by the scheduler when \""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_fdb6eada","line":2135,"range":{"start_line":2135,"start_character":35,"end_line":2135,"end_character":68},"in_reply_to":"5a3905b3_df95abe4","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":2133,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2134,"context_line":"                else:"},{"line_number":2135,"context_line":"                    LOG.error(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2136,"context_line":"                                  \"version is different from user network \""},{"line_number":2137,"context_line":"                                  \"plugin, this could lead to the backend \""},{"line_number":2138,"context_line":"                                  \"never been chosen by the scheduler when \""},{"line_number":2139,"context_line":"                                  \"ip version is specified in the \""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_7f8597ab","line":2136,"range":{"start_line":2136,"start_character":60,"end_line":2136,"end_character":61},"updated":"2017-01-20 03:57:11.000000000","message":"that of the","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":2133,"context_line":"                    ip_version \u003d usr_network_version"},{"line_number":2134,"context_line":"                else:"},{"line_number":2135,"context_line":"                    LOG.error(_LW(\"Admin network plugin\u0027s enabled ip \""},{"line_number":2136,"context_line":"                                  \"version is different from user network \""},{"line_number":2137,"context_line":"                                  \"plugin, this could lead to the backend \""},{"line_number":2138,"context_line":"                                  \"never been chosen by the scheduler when \""},{"line_number":2139,"context_line":"                                  \"ip version is specified in the \""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_9d9fa64f","line":2136,"range":{"start_line":2136,"start_character":60,"end_line":2136,"end_character":61},"in_reply_to":"5a3905b3_7f8597ab","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a927ec65c4f34c8cb09a806e675773eb4b6d923f","unresolved":false,"context_lines":[{"line_number":2136,"context_line":"                        LOG.error(_LW(\"The enabled IP version for the admin \""},{"line_number":2137,"context_line":"                                      \"network plugin is different from that \""},{"line_number":2138,"context_line":"                                      \"of user network plugin, this may lead \""},{"line_number":2139,"context_line":"                                      \"to the backend never been chosen by \""},{"line_number":2140,"context_line":"                                      \"the scheduler when ip version is \""},{"line_number":2141,"context_line":"                                      \"specified in the share type.\"))"},{"line_number":2142,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_b1b0e644","line":2139,"range":{"start_line":2139,"start_character":54,"end_line":2139,"end_character":71},"updated":"2017-01-20 21:29:07.000000000","message":"s/never been chosen/never being chosen/","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f794fb14fe4d1c230b235706737931511b1a8a21","unresolved":false,"context_lines":[{"line_number":2136,"context_line":"                        LOG.error(_LW(\"The enabled IP version for the admin \""},{"line_number":2137,"context_line":"                                      \"network plugin is different from that \""},{"line_number":2138,"context_line":"                                      \"of user network plugin, this may lead \""},{"line_number":2139,"context_line":"                                      \"to the backend never been chosen by \""},{"line_number":2140,"context_line":"                                      \"the scheduler when ip version is \""},{"line_number":2141,"context_line":"                                      \"specified in the share type.\"))"},{"line_number":2142,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_b547db75","line":2139,"range":{"start_line":2139,"start_character":54,"end_line":2139,"end_character":71},"in_reply_to":"5a3905b3_b1b0e644","updated":"2017-01-22 07:27:33.000000000","message":"Done","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ff9c710853b087985db6de59f9ecec04da77635","unresolved":false,"context_lines":[{"line_number":2198,"context_line":"        \"\"\""},{"line_number":2199,"context_line":"        return None"},{"line_number":2200,"context_line":""},{"line_number":2201,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2202,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2203,"context_line":""},{"line_number":2204,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2205,"context_line":"        values are: 4 or 6"},{"line_number":2206,"context_line":"        Each driver could override the method to return the IP version"},{"line_number":2207,"context_line":"        which represents its self configuration."},{"line_number":2208,"context_line":"        \"\"\""},{"line_number":2209,"context_line":"        return 4"},{"line_number":2210,"context_line":""},{"line_number":2211,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2212,"context_line":"                                  ipv6_support\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_03ea27db","line":2209,"range":{"start_line":2201,"start_character":0,"end_line":2209,"end_character":16},"updated":"2017-01-23 04:01:10.000000000","message":"From your answer on PS 22:\n\n\u003e I add this method is because that the final reported capabilities(regarding IPv4 and IPv6)is based on the driver\u0027s capabilities and the backend configurations(dhss\u003dfalse).\n\n\nWhy do you need this method if you can figure out in your driver and report the appropriate version support in the method below?\n\nI don\u0027t understand why the driver can\u0027t read its own configuration. What am i not getting in your design?\n\nIf the driver can read its configuration and give the base driver (this class) its configured IP version (get_configuration_ip_versions), it can also use the same configuration value to decide what to send to the method below.","commit_id":"6048fb8299e5134c57e4c61f9a5127547b0ef58b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ee9489dccc7b6e10d243a91c8eb48026b43e5e1e","unresolved":false,"context_lines":[{"line_number":2198,"context_line":"        \"\"\""},{"line_number":2199,"context_line":"        return None"},{"line_number":2200,"context_line":""},{"line_number":2201,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2202,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2203,"context_line":""},{"line_number":2204,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2205,"context_line":"        values are: 4 or 6"},{"line_number":2206,"context_line":"        Each driver could override the method to return the IP version"},{"line_number":2207,"context_line":"        which represents its self configuration."},{"line_number":2208,"context_line":"        \"\"\""},{"line_number":2209,"context_line":"        return 4"},{"line_number":2210,"context_line":""},{"line_number":2211,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2212,"context_line":"                                  ipv6_support\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_e4052011","line":2209,"range":{"start_line":2201,"start_character":0,"end_line":2209,"end_character":16},"in_reply_to":"5a3905b3_03ea27db","updated":"2017-01-23 06:40:52.000000000","message":"Thanks goutham, from my view, if driver detect their configuration and then report the version by this method, they can re-use the add_ip_version_capability method to update the pool stats about IP versions, of course, they can do this on their own, in that case the \u0027get_configuration_ip_versions\u0027 and \u0027add_ip_version_capability\u0027 are not needed anymore for them.","commit_id":"6048fb8299e5134c57e4c61f9a5127547b0ef58b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"797a3cea474a0bfcb24baff12b1fe137e440e8f1","unresolved":false,"context_lines":[{"line_number":2198,"context_line":"        \"\"\""},{"line_number":2199,"context_line":"        return None"},{"line_number":2200,"context_line":""},{"line_number":2201,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2202,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2203,"context_line":""},{"line_number":2204,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2205,"context_line":"        values are: 4 or 6"},{"line_number":2206,"context_line":"        Each driver could override the method to return the IP version"},{"line_number":2207,"context_line":"        which represents its self configuration."},{"line_number":2208,"context_line":"        \"\"\""},{"line_number":2209,"context_line":"        return 4"},{"line_number":2210,"context_line":""},{"line_number":2211,"context_line":"    def add_ip_version_capability(self, data, ipv4_support\u003dFalse,"},{"line_number":2212,"context_line":"                                  ipv6_support\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_a4af8228","line":2209,"range":{"start_line":2201,"start_character":0,"end_line":2209,"end_character":16},"in_reply_to":"5a3905b3_e4052011","updated":"2017-01-23 14:20:40.000000000","message":"From your notes below:\n\n - When DHSS is true, the capabilities are determined by driver\n  and configured network plugin.\n        \nassume that a driver can support ipv4 and ipv6, how can it get\nthe network configuration? How about intercepting the driver\u0027s\nupdate_share_stats and forcing the ipv4_support and ipv6_support\nas per your logic below. \n\n\n \n - When DHSS is false, the capabilities are determined\n by driver and its configuration.\n\n\n\nThis seems straightforward.. you don\u0027t need to intercept anything,\n just let drivers report the correct ip version.","commit_id":"6048fb8299e5134c57e4c61f9a5127547b0ef58b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"24f9af704f9ac7eea00dc61eb162a0940e17b78a","unresolved":false,"context_lines":[{"line_number":2364,"context_line":"        \"\"\""},{"line_number":2365,"context_line":"        raise NotImplementedError()"},{"line_number":2366,"context_line":""},{"line_number":2367,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2368,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2369,"context_line":""},{"line_number":2370,"context_line":"        The supported versions are returned in tuple, possible"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_af4e3594","line":2367,"range":{"start_line":2367,"start_character":8,"end_line":2367,"end_character":37},"updated":"2017-01-25 13:34:21.000000000","message":"I guess it should be named \"get_configurED_ip_versions\"","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":2364,"context_line":"        \"\"\""},{"line_number":2365,"context_line":"        raise NotImplementedError()"},{"line_number":2366,"context_line":""},{"line_number":2367,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2368,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2369,"context_line":""},{"line_number":2370,"context_line":"        The supported versions are returned in tuple, possible"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_7626c469","line":2367,"range":{"start_line":2367,"start_character":8,"end_line":2367,"end_character":37},"in_reply_to":"3a461143_af4e3594","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"edc8fee5ce129e11d8e9463119e251d5bbf3dd23","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2368,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2369,"context_line":""},{"line_number":2370,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2371,"context_line":"        values are: 4 or 6"},{"line_number":2372,"context_line":"        Each driver could override the method to return the IP version"},{"line_number":2373,"context_line":"        which represents its self configuration."}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_2f1de50f","line":2370,"range":{"start_line":2370,"start_character":8,"end_line":2370,"end_character":52},"updated":"2017-01-25 13:20:07.000000000","message":"You return just integer here.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"    def get_configuration_ip_versions(self):"},{"line_number":2368,"context_line":"        \"\"\"\"Get Configured IP versions when DHSS is false."},{"line_number":2369,"context_line":""},{"line_number":2370,"context_line":"        The supported versions are returned in tuple, possible"},{"line_number":2371,"context_line":"        values are: 4 or 6"},{"line_number":2372,"context_line":"        Each driver could override the method to return the IP version"},{"line_number":2373,"context_line":"        which represents its self configuration."}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_96e25002","line":2370,"range":{"start_line":2370,"start_character":8,"end_line":2370,"end_character":52},"in_reply_to":"3a461143_2f1de50f","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"19e3ce039900f61ed9bc835ec56f537c83cfac41","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"                            self.admin_network_api.enabled_ip_versions()):"},{"line_number":2398,"context_line":"                        self.ip_version \u003d user_network_version"},{"line_number":2399,"context_line":"                    else:"},{"line_number":2400,"context_line":"                        LOG.error(_LW(\"The enabled IP version for the admin \""},{"line_number":2401,"context_line":"                                      \"network plugin is different from that \""},{"line_number":2402,"context_line":"                                      \"of user network plugin, this may lead \""},{"line_number":2403,"context_line":"                                      \"to the backend never being chosen by \""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_0fa3c99f","line":2400,"range":{"start_line":2400,"start_character":28,"end_line":2400,"end_character":33},"updated":"2017-01-25 13:24:11.000000000","message":"s/error/warning/","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"                            self.admin_network_api.enabled_ip_versions()):"},{"line_number":2398,"context_line":"                        self.ip_version \u003d user_network_version"},{"line_number":2399,"context_line":"                    else:"},{"line_number":2400,"context_line":"                        LOG.error(_LW(\"The enabled IP version for the admin \""},{"line_number":2401,"context_line":"                                      \"network plugin is different from that \""},{"line_number":2402,"context_line":"                                      \"of user network plugin, this may lead \""},{"line_number":2403,"context_line":"                                      \"to the backend never being chosen by \""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_56bf08d0","line":2400,"range":{"start_line":2400,"start_character":28,"end_line":2400,"end_character":33},"in_reply_to":"3a461143_0fa3c99f","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0af850bfcae94e581e9619c55238bafd648ab7ef","unresolved":false,"context_lines":[{"line_number":2409,"context_line":"                self.ip_version \u003d six.text_type("},{"line_number":2410,"context_line":"                    self.get_configuration_ip_versions())"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":"        if ipv4_support:"},{"line_number":2413,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2414,"context_line":"        if ipv6_support:"},{"line_number":2415,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2416,"context_line":"        if (getattr(data, \u0027ipv4_support\u0027, None) is False"},{"line_number":2417,"context_line":"                and getattr(data, \u0027ipv6_support\u0027, None) is False):"},{"line_number":2418,"context_line":"            LOG.error(_LE(\"Backend %s capabilities \u0027ipv4_support\u0027 \""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_721a7070","line":2415,"range":{"start_line":2412,"start_character":8,"end_line":2415,"end_character":57},"updated":"2017-01-25 13:40:49.000000000","message":"data[\u0027ipv4_support\u0027] \u003d (\u00274\u0027 \u003d\u003d self.ip_version) and ipv4_support\ndata[\u0027ipv6_support\u0027] \u003d (\u00276\u0027 \u003d\u003d self.ip_version) and ipv6_support","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f15ccda1b4a0fe14a617774864eaae23c5983ed9","unresolved":false,"context_lines":[{"line_number":2409,"context_line":"                self.ip_version \u003d six.text_type("},{"line_number":2410,"context_line":"                    self.get_configuration_ip_versions())"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":"        if ipv4_support:"},{"line_number":2413,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2414,"context_line":"        if ipv6_support:"},{"line_number":2415,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2416,"context_line":"        if (getattr(data, \u0027ipv4_support\u0027, None) is False"},{"line_number":2417,"context_line":"                and getattr(data, \u0027ipv6_support\u0027, None) is False):"},{"line_number":2418,"context_line":"            LOG.error(_LE(\"Backend %s capabilities \u0027ipv4_support\u0027 \""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_ef3b7636","line":2415,"range":{"start_line":2412,"start_character":8,"end_line":2415,"end_character":57},"in_reply_to":"3a461143_568d4830","updated":"2017-01-27 11:26:54.000000000","message":"Why are you trying to report only \"True\" capabilities? When it is completely ok to report \"False\" capabilities. So, my original comment still valid.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":2409,"context_line":"                self.ip_version \u003d six.text_type("},{"line_number":2410,"context_line":"                    self.get_configuration_ip_versions())"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":"        if ipv4_support:"},{"line_number":2413,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2414,"context_line":"        if ipv6_support:"},{"line_number":2415,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2416,"context_line":"        if (getattr(data, \u0027ipv4_support\u0027, None) is False"},{"line_number":2417,"context_line":"                and getattr(data, \u0027ipv6_support\u0027, None) is False):"},{"line_number":2418,"context_line":"            LOG.error(_LE(\"Backend %s capabilities \u0027ipv4_support\u0027 \""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_568d4830","line":2415,"range":{"start_line":2412,"start_character":8,"end_line":2415,"end_character":57},"in_reply_to":"3a461143_721a7070","updated":"2017-01-26 03:27:23.000000000","message":"These can not be merged cause the \u0027ipv4/6_support\u0027 is used for whether report the capabilities","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0af850bfcae94e581e9619c55238bafd648ab7ef","unresolved":false,"context_lines":[{"line_number":2413,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2414,"context_line":"        if ipv6_support:"},{"line_number":2415,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2416,"context_line":"        if (getattr(data, \u0027ipv4_support\u0027, None) is False"},{"line_number":2417,"context_line":"                and getattr(data, \u0027ipv6_support\u0027, None) is False):"},{"line_number":2418,"context_line":"            LOG.error(_LE(\"Backend %s capabilities \u0027ipv4_support\u0027 \""},{"line_number":2419,"context_line":"                          \"and \u0027ipv6_support\u0027 are both False.\"),"},{"line_number":2420,"context_line":"                      data[\u0027share_backend_name\u0027])"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_725fd00e","line":2417,"range":{"start_line":2416,"start_character":8,"end_line":2417,"end_character":66},"updated":"2017-01-25 13:40:49.000000000","message":"if not (data[\u0027ipv4_support\u0027] or data[\u0027ipv6_support\u0027]):","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":2413,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2414,"context_line":"        if ipv6_support:"},{"line_number":2415,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2416,"context_line":"        if (getattr(data, \u0027ipv4_support\u0027, None) is False"},{"line_number":2417,"context_line":"                and getattr(data, \u0027ipv6_support\u0027, None) is False):"},{"line_number":2418,"context_line":"            LOG.error(_LE(\"Backend %s capabilities \u0027ipv4_support\u0027 \""},{"line_number":2419,"context_line":"                          \"and \u0027ipv6_support\u0027 are both False.\"),"},{"line_number":2420,"context_line":"                      data[\u0027share_backend_name\u0027])"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_f6e554a8","line":2417,"range":{"start_line":2416,"start_character":8,"end_line":2417,"end_character":66},"in_reply_to":"3a461143_725fd00e","updated":"2017-01-26 03:27:23.000000000","message":"the data[\u0027ipv4_support\u0027] sentence could raise error if the key does not exist","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b88553b01ff126feb93f4e3b7ea048ebaf8d5290","unresolved":false,"context_lines":[{"line_number":2410,"context_line":"                self.ip_version \u003d six.text_type("},{"line_number":2411,"context_line":"                    self.get_configured_ip_version())"},{"line_number":2412,"context_line":""},{"line_number":2413,"context_line":"        if ipv4_support:"},{"line_number":2414,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2415,"context_line":"        if ipv6_support:"},{"line_number":2416,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2417,"context_line":"        if (\u0027ipv4\u0027 in data and not"},{"line_number":2418,"context_line":"                data[\u0027ipv4_support\u0027]) and (\u0027ipv6\u0027 in data"},{"line_number":2419,"context_line":"                                           and not data[\u0027ipv6_support\u0027]):"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a461143_fd26cfcc","line":2416,"range":{"start_line":2413,"start_character":8,"end_line":2416,"end_character":57},"updated":"2017-01-27 11:27:05.000000000","message":"According to your answer in [1], I have question: Why are you trying to report only \"True\" capabilities? When it is completely ok to report \"False\" capabilities. So, my original comment still valid.\n\n[1] https://review.openstack.org/#/c/406776/28/manila/share/driver.py","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b88553b01ff126feb93f4e3b7ea048ebaf8d5290","unresolved":false,"context_lines":[{"line_number":2414,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2415,"context_line":"        if ipv6_support:"},{"line_number":2416,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2417,"context_line":"        if (\u0027ipv4\u0027 in data and not"},{"line_number":2418,"context_line":"                data[\u0027ipv4_support\u0027]) and (\u0027ipv6\u0027 in data"},{"line_number":2419,"context_line":"                                           and not data[\u0027ipv6_support\u0027]):"},{"line_number":2420,"context_line":"            LOG.error(_LE(\"Backend %s capabilities \u0027ipv4_support\u0027 \""},{"line_number":2421,"context_line":"                          \"and \u0027ipv6_support\u0027 are both False.\"),"},{"line_number":2422,"context_line":"                      data[\u0027share_backend_name\u0027])"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a461143_1d51db62","line":2419,"range":{"start_line":2417,"start_character":8,"end_line":2419,"end_character":73},"updated":"2017-01-27 11:27:05.000000000","message":"It will always be False. You search for keys that are always absent - \"ipv4\" and \"ipv6\".\n\nIt should be as of following in case you expect key to be absent:\n\n\"\"\"\nif not (data.get(\u0027ipv4_support\u0027) or data.get(\u0027ipv6_support\u0027)):\n\"\"\"","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"6aa8a777a83cc85b77cc0783a4e1cb1f16c4bee0","unresolved":false,"context_lines":[{"line_number":2414,"context_line":"            data[\u0027ipv4_support\u0027] \u003d \u00274\u0027 \u003d\u003d self.ip_version"},{"line_number":2415,"context_line":"        if ipv6_support:"},{"line_number":2416,"context_line":"            data[\u0027ipv6_support\u0027] \u003d \u00276\u0027 \u003d\u003d self.ip_version"},{"line_number":2417,"context_line":"        if (\u0027ipv4\u0027 in data and not"},{"line_number":2418,"context_line":"                data[\u0027ipv4_support\u0027]) and (\u0027ipv6\u0027 in data"},{"line_number":2419,"context_line":"                                           and not data[\u0027ipv6_support\u0027]):"},{"line_number":2420,"context_line":"            LOG.error(_LE(\"Backend %s capabilities \u0027ipv4_support\u0027 \""},{"line_number":2421,"context_line":"                          \"and \u0027ipv6_support\u0027 are both False.\"),"},{"line_number":2422,"context_line":"                      data[\u0027share_backend_name\u0027])"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a430d35_59482e2e","line":2419,"range":{"start_line":2417,"start_character":8,"end_line":2419,"end_character":73},"in_reply_to":"3a461143_1d51db62","updated":"2017-02-04 06:27:34.000000000","message":"Thanks, this is simple and clean","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8189fd77e56ebbd25c897c55096485851fcffd47","unresolved":false,"context_lines":[{"line_number":2444,"context_line":"        When DHSS is false, the capabilities are determined by driver and its"},{"line_number":2445,"context_line":"        configuration."},{"line_number":2446,"context_line":"        :param data: the capability dictionary"},{"line_number":2447,"context_line":"        :return: capability data"},{"line_number":2448,"context_line":"        \"\"\""},{"line_number":2449,"context_line":"        ipv4_support \u003d data.get(\u0027ipv4_support\u0027, False)"},{"line_number":2450,"context_line":"        ipv6_support \u003d data.get(\u0027ipv6_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":56,"id":"3f1d235d_3246a323","line":2447,"range":{"start_line":2447,"start_character":8,"end_line":2447,"end_character":17},"updated":"2017-07-09 15:04:36.000000000","message":"Missing \"s\"\n\n:returns:","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c30caaec3b353119d22fbe3a041df457dd39ea41","unresolved":false,"context_lines":[{"line_number":2444,"context_line":"        When DHSS is false, the capabilities are determined by driver and its"},{"line_number":2445,"context_line":"        configuration."},{"line_number":2446,"context_line":"        :param data: the capability dictionary"},{"line_number":2447,"context_line":"        :return: capability data"},{"line_number":2448,"context_line":"        \"\"\""},{"line_number":2449,"context_line":"        ipv4_support \u003d data.get(\u0027ipv4_support\u0027, False)"},{"line_number":2450,"context_line":"        ipv6_support \u003d data.get(\u0027ipv6_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":56,"id":"3f1d235d_818404b3","line":2447,"range":{"start_line":2447,"start_character":8,"end_line":2447,"end_character":17},"in_reply_to":"3f1d235d_3246a323","updated":"2017-07-10 06:44:37.000000000","message":"Done","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c1b0cdf149d6d61c710c76d0f535c5b3eee809e","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"            replication_domain\u003dself.replication_domain,"},{"line_number":1119,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":1120,"context_line":"            goodness_function\u003dself.get_goodness_function(),"},{"line_number":1121,"context_line":"            ipv4_support\u003dTrue,"},{"line_number":1122,"context_line":"        )"},{"line_number":1123,"context_line":"        if isinstance(data, dict):"},{"line_number":1124,"context_line":"            common.update(data)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_369cf20d","line":1121,"range":{"start_line":1121,"start_character":12,"end_line":1121,"end_character":30},"updated":"2017-07-26 21:57:37.000000000","message":"remove, this will get added below.","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"            replication_domain\u003dself.replication_domain,"},{"line_number":1119,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":1120,"context_line":"            goodness_function\u003dself.get_goodness_function(),"},{"line_number":1121,"context_line":"            ipv4_support\u003dTrue,"},{"line_number":1122,"context_line":"        )"},{"line_number":1123,"context_line":"        if isinstance(data, dict):"},{"line_number":1124,"context_line":"            common.update(data)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_7765d11d","line":1121,"range":{"start_line":1121,"start_character":12,"end_line":1121,"end_character":30},"in_reply_to":"ff346bd7_369cf20d","updated":"2017-07-27 07:39:05.000000000","message":"No, we shouldn\u0027t remove this, because we will get the ipv4_support in code line 2479. If we remove this, we will always get value of ipv4_support equal to \"False\" when the driver doesn\u0027t set ipv4_support value.\nWe should set the default ipv4_support value for drivers that doesn\u0027t set in driver itself.","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c1b0cdf149d6d61c710c76d0f535c5b3eee809e","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                \u0027consistent_snapshot_support\u0027),"},{"line_number":1130,"context_line":"        }"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"        self.add_ip_version_capability(common)"},{"line_number":1133,"context_line":"        self._stats \u003d common"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"    def get_share_server_pools(self, share_server):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_767b9abd","line":1132,"range":{"start_line":1132,"start_character":8,"end_line":1132,"end_character":46},"updated":"2017-07-26 21:57:37.000000000","message":"Instead of calling this periodically as part of _update_share_stats, why not call it at driver start time? What advantage is there in running through lines 2481 - 2506 periodically?","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                \u0027consistent_snapshot_support\u0027),"},{"line_number":1130,"context_line":"        }"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"        self.add_ip_version_capability(common)"},{"line_number":1133,"context_line":"        self._stats \u003d common"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"    def get_share_server_pools(self, share_server):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_9eea890c","line":1132,"range":{"start_line":1132,"start_character":8,"end_line":1132,"end_character":46},"in_reply_to":"ff346bd7_767b9abd","updated":"2017-07-27 07:39:05.000000000","message":"Please see code line 2481, if the self.ip_version  has a value, then it will not running the whole logic again.","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"}],"manila/share/drivers/container/driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            \u0027driver_name\u0027: \u0027ContainerShareDriver\u0027,"},{"line_number":114,"context_line":"            \u0027pools\u0027: self.storage.get_share_server_pools(),"},{"line_number":115,"context_line":"        }"},{"line_number":116,"context_line":"        data \u003d self.add_ip_version_capability(data, True)"},{"line_number":117,"context_line":"        super(ContainerShareDriver, self)._update_share_stats(data)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_b951d310","line":116,"range":{"start_line":116,"start_character":52,"end_line":116,"end_character":56},"updated":"2016-12-14 11:02:46.000000000","message":"it would be good to have the format \"ipv4_support\u003dTrue\" for better readability","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            \u0027driver_name\u0027: \u0027ContainerShareDriver\u0027,"},{"line_number":115,"context_line":"            \u0027pools\u0027: self.storage.get_share_server_pools(),"},{"line_number":116,"context_line":"        }"},{"line_number":117,"context_line":"        data \u003d self.add_ip_version_capability(data, True)"},{"line_number":118,"context_line":"        super(ContainerShareDriver, self)._update_share_stats(data)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_5a0d493d","line":117,"range":{"start_line":117,"start_character":52,"end_line":117,"end_character":56},"updated":"2017-01-20 03:57:11.000000000","message":"always pass kwargs as kwargs. Here and in all other drivers..","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            \u0027driver_name\u0027: \u0027ContainerShareDriver\u0027,"},{"line_number":115,"context_line":"            \u0027pools\u0027: self.storage.get_share_server_pools(),"},{"line_number":116,"context_line":"        }"},{"line_number":117,"context_line":"        data \u003d self.add_ip_version_capability(data, True)"},{"line_number":118,"context_line":"        super(ContainerShareDriver, self)._update_share_stats(data)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_fd2b4ae9","line":117,"range":{"start_line":117,"start_character":52,"end_line":117,"end_character":56},"in_reply_to":"5a3905b3_5a0d493d","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"}],"manila/share/drivers/dell_emc/driver.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"2de815d648eeacc09b4791a8feba0a0bbd8621a0","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            share_backend_name\u003dbackend_name,"},{"line_number":142,"context_line":"            vendor_name\u003d\u0027Dell EMC\u0027,"},{"line_number":143,"context_line":"            storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":144,"context_line":"            ipv4_support\u003dTrue,)"},{"line_number":145,"context_line":"        self.plugin.update_share_stats(data)"},{"line_number":146,"context_line":"        super(EMCShareDriver, self)._update_share_stats(data)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_097b0b8d","line":144,"range":{"start_line":144,"start_character":30,"end_line":144,"end_character":31},"updated":"2016-12-06 01:12:06.000000000","message":"better make this parenthesis to a new line.","commit_id":"6f5780f52fd739b656326389a4a11fb4dd6d87c5"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            share_backend_name\u003dbackend_name,"},{"line_number":142,"context_line":"            vendor_name\u003d\u0027Dell EMC\u0027,"},{"line_number":143,"context_line":"            storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":144,"context_line":"            ipv4_support\u003dTrue,"},{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":"        data \u003d self.add_ip_version_capability(data, True)"},{"line_number":147,"context_line":"        self.plugin.update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_594d1f6b","line":144,"range":{"start_line":144,"start_character":12,"end_line":144,"end_character":30},"updated":"2016-12-14 11:02:46.000000000","message":"isn\u0027t this redundant with the statement below?","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ddca91e4901bb2ccccd76bae460d64329926f470","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            share_backend_name\u003dbackend_name,"},{"line_number":142,"context_line":"            vendor_name\u003d\u0027Dell EMC\u0027,"},{"line_number":143,"context_line":"            storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":144,"context_line":"            ipv4_support\u003dTrue,"},{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":"        data \u003d self.add_ip_version_capability(data, True)"},{"line_number":147,"context_line":"        self.plugin.update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_dc1038ab","line":144,"range":{"start_line":144,"start_character":12,"end_line":144,"end_character":30},"in_reply_to":"1a6eadb0_594d1f6b","updated":"2016-12-14 13:13:43.000000000","message":"Thanks, you are right","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            reserved_percentage\u003dself.configuration.reserved_share_percentage,"},{"line_number":628,"context_line":"            consistency_group_support\u003dNone,"},{"line_number":629,"context_line":"        )"},{"line_number":630,"context_line":"        data \u003d self.add_ip_version_capability(data, True)"},{"line_number":631,"context_line":"        super(GenericShareDriver, self)._update_share_stats(data)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    @ensure_server"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_f9726bac","line":630,"range":{"start_line":630,"start_character":52,"end_line":630,"end_character":56},"updated":"2016-12-14 11:02:46.000000000","message":"ipv4_support\u003dTrue. Same for all other drivers","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":620,"context_line":"            reserved_percentage\u003dself.configuration.reserved_share_percentage,"},{"line_number":621,"context_line":"            consistency_group_support\u003dNone,"},{"line_number":622,"context_line":"        )"},{"line_number":623,"context_line":"        data \u003d self.add_ip_version_capability(data, True, True)"},{"line_number":624,"context_line":"        super(GenericShareDriver, self)._update_share_stats(data)"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    @ensure_server"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_4f358cf5","line":623,"range":{"start_line":623,"start_character":52,"end_line":623,"end_character":63},"updated":"2016-12-19 16:05:50.000000000","message":"it seems to me this may not always be true. Please clarify.\n\nI believe it should read whatever the service instance has configured.\n\nIf this depends on another patch, then it should be updated within the patch that implements IPv6 in generic driver.","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"}],"manila/share/drivers/helpers.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"edbd18fabb4766c9936716d92610ee5b351425db","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        except netaddr.AddrFormatError:"},{"line_number":281,"context_line":"            raise exception.InvalidInput(_(\"Invalid cidr supplied \""},{"line_number":282,"context_line":"                                           \"%s.\") % access_to)"},{"line_number":283,"context_line":"        mask_length \u003d network.netmask.netmask_bits()"},{"line_number":284,"context_line":"        version \u003d network.version"},{"line_number":285,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":286,"context_line":"        if (mask_length \u003d\u003d 32 and version \u003d\u003d 4) or ("},{"line_number":287,"context_line":"                mask_length \u003d\u003d 128 and version \u003d\u003d 6):"},{"line_number":288,"context_line":"            return address if network.version \u003d\u003d 4 else \"[%s]\" % address"},{"line_number":289,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":290,"context_line":"            return \u0027%s/%s\u0027 % (address, mask_length)"},{"line_number":291,"context_line":"        else:"},{"line_number":292,"context_line":"            return \"[%s]/%s\" % (address, mask_length)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @staticmethod"},{"line_number":295,"context_line":"    def get_host_list(output, local_path):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_b2be98d2","line":292,"range":{"start_line":283,"start_character":8,"end_line":292,"end_character":53},"updated":"2017-01-25 13:49:07.000000000","message":"Too many code lines for such simple logic.\n\n\"\"\"\naddress \u003d access_to.split(\u0027/\u0027)[0]\ntemplate \u003d \u0027%s\u0027 if network.version \u003d\u003d 4 else \u0027[%s]\u0027\nreturn template % address\n\"\"\"","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        except netaddr.AddrFormatError:"},{"line_number":281,"context_line":"            raise exception.InvalidInput(_(\"Invalid cidr supplied \""},{"line_number":282,"context_line":"                                           \"%s.\") % access_to)"},{"line_number":283,"context_line":"        mask_length \u003d network.netmask.netmask_bits()"},{"line_number":284,"context_line":"        version \u003d network.version"},{"line_number":285,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":286,"context_line":"        if (mask_length \u003d\u003d 32 and version \u003d\u003d 4) or ("},{"line_number":287,"context_line":"                mask_length \u003d\u003d 128 and version \u003d\u003d 6):"},{"line_number":288,"context_line":"            return address if network.version \u003d\u003d 4 else \"[%s]\" % address"},{"line_number":289,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":290,"context_line":"            return \u0027%s/%s\u0027 % (address, mask_length)"},{"line_number":291,"context_line":"        else:"},{"line_number":292,"context_line":"            return \"[%s]/%s\" % (address, mask_length)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @staticmethod"},{"line_number":295,"context_line":"    def get_host_list(output, local_path):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_f606341f","line":292,"range":{"start_line":283,"start_character":8,"end_line":292,"end_character":53},"in_reply_to":"3a461143_b2be98d2","updated":"2017-01-26 03:27:23.000000000","message":"1001::1000/128 \u003d\u003e [1001::1000]\n1001::1000/124 \u003d\u003e [1001::1000]/124\n the cases are not satisfied.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ac8f69de7ed3ea442f821808c0345dc7b13e0b92","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        except netaddr.AddrFormatError:"},{"line_number":281,"context_line":"            raise exception.InvalidInput(_(\"Invalid cidr supplied \""},{"line_number":282,"context_line":"                                           \"%s.\") % access_to)"},{"line_number":283,"context_line":"        mask_length \u003d network.netmask.netmask_bits()"},{"line_number":284,"context_line":"        version \u003d network.version"},{"line_number":285,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":286,"context_line":"        if (mask_length \u003d\u003d 32 and version \u003d\u003d 4) or ("},{"line_number":287,"context_line":"                mask_length \u003d\u003d 128 and version \u003d\u003d 6):"},{"line_number":288,"context_line":"            return address if network.version \u003d\u003d 4 else \"[%s]\" % address"},{"line_number":289,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":290,"context_line":"            return \u0027%s/%s\u0027 % (address, mask_length)"},{"line_number":291,"context_line":"        else:"},{"line_number":292,"context_line":"            return \"[%s]/%s\" % (address, mask_length)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @staticmethod"},{"line_number":295,"context_line":"    def get_host_list(output, local_path):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_2f2c9eaa","line":292,"range":{"start_line":283,"start_character":8,"end_line":292,"end_character":53},"in_reply_to":"3a461143_f606341f","updated":"2017-01-27 11:35:19.000000000","message":"Ok:\n\n\"\"\"\naddress \u003d access_to.split(\u0027/\u0027)[0]\nmask_length \u003d network.netmask.netmask_bits()\n\nif network.version \u003d\u003d 4:\n    if mask_length \u003d\u003d 32:\n        return address\n    return \"%s/%s\" % (address, mask_length)\nif mask_length \u003d\u003d 128:\n    return \"[%s]\" % address\nreturn \"[%s]/%s\" % (address, mask_length)\n\"\"\"","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b88553b01ff126feb93f4e3b7ea048ebaf8d5290","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def create_exports(self, server, share_name, recreate\u003dFalse):"},{"line_number":176,"context_line":"        path \u003d os.path.join(self.configuration.share_mount_path, share_name)"},{"line_number":177,"context_line":"        server_copy \u003d copy.deepcopy(server)"},{"line_number":178,"context_line":"        for type in [\u0027public_address\u0027, \u0027admin_ip\u0027, \u0027ip\u0027]:"},{"line_number":179,"context_line":"            address \u003d server_copy.get(type, None)"},{"line_number":180,"context_line":"            if address is not None:"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a461143_ef92969e","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":43},"updated":"2017-01-27 11:27:05.000000000","message":"Why do you need deep copy?","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"6aa8a777a83cc85b77cc0783a4e1cb1f16c4bee0","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def create_exports(self, server, share_name, recreate\u003dFalse):"},{"line_number":176,"context_line":"        path \u003d os.path.join(self.configuration.share_mount_path, share_name)"},{"line_number":177,"context_line":"        server_copy \u003d copy.deepcopy(server)"},{"line_number":178,"context_line":"        for type in [\u0027public_address\u0027, \u0027admin_ip\u0027, \u0027ip\u0027]:"},{"line_number":179,"context_line":"            address \u003d server_copy.get(type, None)"},{"line_number":180,"context_line":"            if address is not None:"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a430d35_39d1a2fc","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":43},"in_reply_to":"3a461143_ef92969e","updated":"2017-02-04 06:27:34.000000000","message":"Done","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b88553b01ff126feb93f4e3b7ea048ebaf8d5290","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def create_exports(self, server, share_name, recreate\u003dFalse):"},{"line_number":176,"context_line":"        path \u003d os.path.join(self.configuration.share_mount_path, share_name)"},{"line_number":177,"context_line":"        server_copy \u003d copy.deepcopy(server)"},{"line_number":178,"context_line":"        for type in [\u0027public_address\u0027, \u0027admin_ip\u0027, \u0027ip\u0027]:"},{"line_number":179,"context_line":"            address \u003d server_copy.get(type, None)"},{"line_number":180,"context_line":"            if address is not None:"},{"line_number":181,"context_line":"                server_copy[type] \u003d self._get_parsed_address_or_cidr(address)"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a461143_2f1ade6e","line":178,"range":{"start_line":178,"start_character":12,"end_line":178,"end_character":16},"updated":"2017-01-27 11:27:05.000000000","message":"Do not redefine built-ins without real need.\n\nList of built-ins for py27:\n\nhttps://docs.python.org/2/library/functions.html\n\nList of built-ins for py35:\n\nhttps://docs.python.org/3.5/library/functions.html","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"6aa8a777a83cc85b77cc0783a4e1cb1f16c4bee0","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def create_exports(self, server, share_name, recreate\u003dFalse):"},{"line_number":176,"context_line":"        path \u003d os.path.join(self.configuration.share_mount_path, share_name)"},{"line_number":177,"context_line":"        server_copy \u003d copy.deepcopy(server)"},{"line_number":178,"context_line":"        for type in [\u0027public_address\u0027, \u0027admin_ip\u0027, \u0027ip\u0027]:"},{"line_number":179,"context_line":"            address \u003d server_copy.get(type, None)"},{"line_number":180,"context_line":"            if address is not None:"},{"line_number":181,"context_line":"                server_copy[type] \u003d self._get_parsed_address_or_cidr(address)"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a430d35_19b946ea","line":178,"range":{"start_line":178,"start_character":12,"end_line":178,"end_character":16},"in_reply_to":"3a461143_2f1ade6e","updated":"2017-02-04 06:27:34.000000000","message":"Done","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b88553b01ff126feb93f4e3b7ea048ebaf8d5290","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        path \u003d os.path.join(self.configuration.share_mount_path, share_name)"},{"line_number":177,"context_line":"        server_copy \u003d copy.deepcopy(server)"},{"line_number":178,"context_line":"        for type in [\u0027public_address\u0027, \u0027admin_ip\u0027, \u0027ip\u0027]:"},{"line_number":179,"context_line":"            address \u003d server_copy.get(type, None)"},{"line_number":180,"context_line":"            if address is not None:"},{"line_number":181,"context_line":"                server_copy[type] \u003d self._get_parsed_address_or_cidr(address)"},{"line_number":182,"context_line":"        return self.get_exports_for_share(server_copy, path)"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a461143_4f83aa56","line":179,"range":{"start_line":179,"start_character":44,"end_line":179,"end_character":48},"updated":"2017-01-27 11:27:05.000000000","message":"\"None\" is already default value for \"get\" method.","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"6aa8a777a83cc85b77cc0783a4e1cb1f16c4bee0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        path \u003d os.path.join(self.configuration.share_mount_path, share_name)"},{"line_number":177,"context_line":"        server_copy \u003d copy.deepcopy(server)"},{"line_number":178,"context_line":"        for type in [\u0027public_address\u0027, \u0027admin_ip\u0027, \u0027ip\u0027]:"},{"line_number":179,"context_line":"            address \u003d server_copy.get(type, None)"},{"line_number":180,"context_line":"            if address is not None:"},{"line_number":181,"context_line":"                server_copy[type] \u003d self._get_parsed_address_or_cidr(address)"},{"line_number":182,"context_line":"        return self.get_exports_for_share(server_copy, path)"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a430d35_f9b39a08","line":179,"range":{"start_line":179,"start_character":44,"end_line":179,"end_character":48},"in_reply_to":"3a461143_4f83aa56","updated":"2017-02-04 06:27:34.000000000","message":"Done","commit_id":"63080ee95d43d7e169e18034d6aadbb80a9aad10"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            network \u003d netaddr.IPNetwork(access_to)"},{"line_number":287,"context_line":"        except netaddr.AddrFormatError:"},{"line_number":288,"context_line":"            raise exception.InvalidInput(_(\"Invalid address or cidr supplied \""},{"line_number":289,"context_line":"                                           \"%s.\") % access_to)"},{"line_number":290,"context_line":"        mask_length \u003d network.netmask.netmask_bits()"},{"line_number":291,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":292,"context_line":"        if network.version \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_5d29a1e3","line":289,"updated":"2017-06-27 04:30:53.000000000","message":"exception.InvalidInput(reason\u003d_(\"Invalid …..\")","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            network \u003d netaddr.IPNetwork(access_to)"},{"line_number":287,"context_line":"        except netaddr.AddrFormatError:"},{"line_number":288,"context_line":"            raise exception.InvalidInput(_(\"Invalid address or cidr supplied \""},{"line_number":289,"context_line":"                                           \"%s.\") % access_to)"},{"line_number":290,"context_line":"        mask_length \u003d network.netmask.netmask_bits()"},{"line_number":291,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":292,"context_line":"        if network.version \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_d65d8b15","line":289,"in_reply_to":"5f201791_5d29a1e3","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    def _get_parsed_address_or_cidr(self, access_to):"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            network \u003d netaddr.IPNetwork(access_to)"},{"line_number":287,"context_line":"        except netaddr.AddrFormatError:"},{"line_number":288,"context_line":"            raise exception.InvalidInput("},{"line_number":289,"context_line":"                reason\u003d_(\"Invalid address or cidr supplied %s.\") % access_to)"},{"line_number":290,"context_line":"        mask_length \u003d network.netmask.netmask_bits()"},{"line_number":291,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":292,"context_line":"        if network.version \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_e1a56348","line":289,"range":{"start_line":287,"start_character":1,"end_line":289,"end_character":77},"updated":"2017-07-05 20:33:17.000000000","message":"It would be nice to get unit test coverage for this path.\n\nhttp://logs.openstack.org/76/406776/51/check/manila-coverage-ubuntu-xenial-nv/47e5a67/cover/manila_share_drivers_helpers_py.html#n287","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    def _get_parsed_address_or_cidr(self, access_to):"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            network \u003d netaddr.IPNetwork(access_to)"},{"line_number":287,"context_line":"        except netaddr.AddrFormatError:"},{"line_number":288,"context_line":"            raise exception.InvalidInput("},{"line_number":289,"context_line":"                reason\u003d_(\"Invalid address or cidr supplied %s.\") % access_to)"},{"line_number":290,"context_line":"        mask_length \u003d network.netmask.netmask_bits()"},{"line_number":291,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":292,"context_line":"        if network.version \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_7d67a0b8","line":289,"range":{"start_line":287,"start_character":1,"end_line":289,"end_character":77},"in_reply_to":"3f1d235d_e1a56348","updated":"2017-07-06 11:47:20.000000000","message":"Done","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                        self.configuration.lvm_share_export_ip)).version)"},{"line_number":428,"context_line":"            except Exception:"},{"line_number":429,"context_line":"                LOG.exception(\"The \u0027lvm_share_export_ip\u0027 option empty or \""},{"line_number":430,"context_line":"                              \"invalid.\")"},{"line_number":431,"context_line":"                raise"},{"line_number":432,"context_line":"        return self.configurated_ip_version"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_9d59798f","line":430,"updated":"2017-06-27 04:30:53.000000000","message":"Can you catch a more specific exception for this error message?","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                        self.configuration.lvm_share_export_ip)).version)"},{"line_number":428,"context_line":"            except Exception:"},{"line_number":429,"context_line":"                LOG.exception(\"The \u0027lvm_share_export_ip\u0027 option empty or \""},{"line_number":430,"context_line":"                              \"invalid.\")"},{"line_number":431,"context_line":"                raise"},{"line_number":432,"context_line":"        return self.configurated_ip_version"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_3626ffcf","line":430,"in_reply_to":"5f201791_9d59798f","updated":"2017-06-27 09:15:28.000000000","message":"The self.configuration.lvm_share_export_ip will be checked by check_for_setup_error function. so There is only \"invalid\" error. so remove the \"empty\" in description.","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.configuration.share_mount_path \u003d ("},{"line_number":143,"context_line":"            self.configuration.lvm_share_export_root)"},{"line_number":144,"context_line":"        self._helpers \u003d None"},{"line_number":145,"context_line":"        self.configurated_ip_version \u003d None"},{"line_number":146,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":147,"context_line":"            \u0027share_backend_name\u0027) or \u0027LVM\u0027"},{"line_number":148,"context_line":"        # Set of parameters used for compatibility with"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_215ebb43","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":36},"updated":"2017-07-05 20:33:17.000000000","message":"s/configurated_ip_version/configured_ip_version/","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.configuration.share_mount_path \u003d ("},{"line_number":143,"context_line":"            self.configuration.lvm_share_export_root)"},{"line_number":144,"context_line":"        self._helpers \u003d None"},{"line_number":145,"context_line":"        self.configurated_ip_version \u003d None"},{"line_number":146,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":147,"context_line":"            \u0027share_backend_name\u0027) or \u0027LVM\u0027"},{"line_number":148,"context_line":"        # Set of parameters used for compatibility with"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_87fc6db5","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":36},"in_reply_to":"3f1d235d_215ebb43","updated":"2017-07-06 11:47:20.000000000","message":"Done","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"865699102abcfccaddd9bed3dd5acfaf35a567f2","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                self.configurated_ip_version.append(ipaddress.ip_address("},{"line_number":426,"context_line":"                    six.text_type("},{"line_number":427,"context_line":"                        self.configuration.lvm_share_export_ip)).version)"},{"line_number":428,"context_line":"            except Exception:"},{"line_number":429,"context_line":"                LOG.exception(\"The \u0027lvm_share_export_ip\u0027 option invalid.\")"},{"line_number":430,"context_line":"                raise"},{"line_number":431,"context_line":"        return self.configurated_ip_version"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def check_ip_version_matched(self, add_rules):"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_c44ef56d","line":430,"range":{"start_line":428,"start_character":0,"end_line":430,"end_character":21},"updated":"2017-07-05 20:33:17.000000000","message":"Would be nice to get unit test coverage of the exception path.\n\nhttp://logs.openstack.org/76/406776/51/check/manila-coverage-ubuntu-xenial-nv/47e5a67/cover/manila_share_drivers_lvm_py.html#n428","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee87bf00367c868df2d761ead653ad53a6a263d9","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                self.configurated_ip_version.append(ipaddress.ip_address("},{"line_number":426,"context_line":"                    six.text_type("},{"line_number":427,"context_line":"                        self.configuration.lvm_share_export_ip)).version)"},{"line_number":428,"context_line":"            except Exception:"},{"line_number":429,"context_line":"                LOG.exception(\"The \u0027lvm_share_export_ip\u0027 option invalid.\")"},{"line_number":430,"context_line":"                raise"},{"line_number":431,"context_line":"        return self.configurated_ip_version"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def check_ip_version_matched(self, add_rules):"}],"source_content_type":"text/x-python","patch_set":51,"id":"3f1d235d_fdebb074","line":430,"range":{"start_line":428,"start_character":0,"end_line":430,"end_character":21},"in_reply_to":"3f1d235d_c44ef56d","updated":"2017-07-06 11:47:20.000000000","message":"Done","commit_id":"349f6489607a5c66b54b8f39d11dec1c1995eca1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c1b0cdf149d6d61c710c76d0f535c5b3eee809e","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                        six.text_type("},{"line_number":446,"context_line":"                            self.configuration.lvm_share_export_ip)).version)"},{"line_number":447,"context_line":"                else:"},{"line_number":448,"context_line":"                    for ip in self.configuration.lvm_share_export_ips:"},{"line_number":449,"context_line":"                        self.configured_ip_version.append("},{"line_number":450,"context_line":"                            ipaddress.ip_address(six.text_type(ip)).version)"},{"line_number":451,"context_line":"            except Exception:"},{"line_number":452,"context_line":"                if self.configuration.lvm_share_export_ip:"},{"line_number":453,"context_line":"                    message \u003d (_(\"Invalid \u0027lvm_share_export_ip\u0027 option \""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_96a95e25","line":450,"range":{"start_line":448,"start_character":20,"end_line":450,"end_character":76},"updated":"2017-07-26 21:57:37.000000000","message":"What if two ipv4 or two ipv6 lvm_share_export_ips are configured?","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3c5fc7596081b6f707bc143b2647c6d29693e949","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                        six.text_type("},{"line_number":446,"context_line":"                            self.configuration.lvm_share_export_ip)).version)"},{"line_number":447,"context_line":"                else:"},{"line_number":448,"context_line":"                    for ip in self.configuration.lvm_share_export_ips:"},{"line_number":449,"context_line":"                        self.configured_ip_version.append("},{"line_number":450,"context_line":"                            ipaddress.ip_address(six.text_type(ip)).version)"},{"line_number":451,"context_line":"            except Exception:"},{"line_number":452,"context_line":"                if self.configuration.lvm_share_export_ip:"},{"line_number":453,"context_line":"                    message \u003d (_(\"Invalid \u0027lvm_share_export_ip\u0027 option \""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff346bd7_3afe106b","line":450,"range":{"start_line":448,"start_character":20,"end_line":450,"end_character":76},"in_reply_to":"ff346bd7_96a95e25","updated":"2017-07-27 07:39:05.000000000","message":"If two ipv4 or two ipv6 lvm_share_export_ips are configured, the \u0027self.configured_ip_version\u0027 will be equal to [4, 4, 6, 6]. Then we will return to driver.py. and check whether the network ip version in \u0027self.configured_ip_version\u0027(such as: if 4 in [4, 4, 6, 6])","commit_id":"dca88f1c8ad8cd720b04831d2dab0070477836db"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_multi_svm.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"679c5fb3f2c98974245beeef810a6a01231c3e55","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":110,"context_line":"        data \u003d self.library.get_share_stats()"},{"line_number":111,"context_line":"        data \u003d self.add_ip_version_capability(data, True, False)"},{"line_number":112,"context_line":"        super(NetAppCmodeMultiSvmShareDriver, self)._update_share_stats("},{"line_number":113,"context_line":"            data\u003ddata)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_39ace3ec","line":111,"range":{"start_line":111,"start_character":51,"end_line":111,"end_character":63},"updated":"2016-12-14 11:02:46.000000000","message":"ipv4_support\u003dTrue, ipv6_support\u003dFalse","commit_id":"56670d0c8dd6b7f22786d5f42997665fdd12353b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":110,"context_line":"        data \u003d self.library.get_share_stats()"},{"line_number":111,"context_line":"        data \u003d self.add_ip_version_capability(data, True, False)"},{"line_number":112,"context_line":"        super(NetAppCmodeMultiSvmShareDriver, self)._update_share_stats("},{"line_number":113,"context_line":"            data\u003ddata)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_0a5f020f","line":111,"range":{"start_line":111,"start_character":56,"end_line":111,"end_character":63},"updated":"2016-12-19 16:05:50.000000000","message":"nit: not required","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_single_svm.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":110,"context_line":"        data \u003d self.library.get_share_stats()"},{"line_number":111,"context_line":"        data \u003d self.add_ip_version_capability(data, True, False)"},{"line_number":112,"context_line":"        super(NetAppCmodeSingleSvmShareDriver, self)._update_share_stats("},{"line_number":113,"context_line":"            data\u003ddata)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_4a9f3ab4","line":111,"range":{"start_line":111,"start_character":56,"end_line":111,"end_character":63},"updated":"2016-12-19 16:05:50.000000000","message":"nit: not required","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2fae557afb3bc779d8cf7b72cb140ae83f3c00da","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        data \u003d self.library.get_share_stats("},{"line_number":114,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":115,"context_line":"            goodness_function\u003dself.get_goodness_function())"},{"line_number":116,"context_line":"        data \u003d self.add_ip_version_capability(data, ipv4_support\u003dTrue)"},{"line_number":117,"context_line":"        super(NetAppCmodeSingleSvmShareDriver, self)._update_share_stats("},{"line_number":118,"context_line":"            data\u003ddata)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_af08f592","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":70},"updated":"2017-01-25 13:26:40.000000000","message":"The fact that you add the same command in lots of drivers means that you are updating stats in wrong way. You should have done it in base class.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f15ccda1b4a0fe14a617774864eaae23c5983ed9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        data \u003d self.library.get_share_stats("},{"line_number":114,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":115,"context_line":"            goodness_function\u003dself.get_goodness_function())"},{"line_number":116,"context_line":"        data \u003d self.add_ip_version_capability(data, ipv4_support\u003dTrue)"},{"line_number":117,"context_line":"        super(NetAppCmodeSingleSvmShareDriver, self)._update_share_stats("},{"line_number":118,"context_line":"            data\u003ddata)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_6fba26c2","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":70},"in_reply_to":"3a461143_96a41058","updated":"2017-01-27 11:26:54.000000000","message":"Again, you implement THE SAME LOGIC in LOTS OF DRIVERS. So, you could just define it in base driver and result will be the same. Redefinition in each specific driver is required ONLY when it starts supporting IPv6.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        data \u003d self.library.get_share_stats("},{"line_number":114,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":115,"context_line":"            goodness_function\u003dself.get_goodness_function())"},{"line_number":116,"context_line":"        data \u003d self.add_ip_version_capability(data, ipv4_support\u003dTrue)"},{"line_number":117,"context_line":"        super(NetAppCmodeSingleSvmShareDriver, self)._update_share_stats("},{"line_number":118,"context_line":"            data\u003ddata)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_96a41058","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":70},"in_reply_to":"3a461143_af08f592","updated":"2017-01-26 03:27:23.000000000","message":"I think I don\u0027t understand your point well,\nthis method \u0027add_ip_version_capability\u0027 is used to calculate the final IP version capabilities when driver report their capabilities. so if this could be moved into the base driver. this could be something like below:\n```\nclass ChildDriver:\n\n  def _update_share_stats():\n    \n    data \u003d dic(\n     ipv4_support \u003d True\n     )     \n    super(GenericShareDriver, self)._update_share_stats(data)\n```\n\nclass ParentDriver:\n\n  def _update_share_stats():    \n     data \u003d self.add_ip_version_capability(data, ipv4_support\u003ddata[\u0027ipv4_support\u0027], ipv6...)\n\nThen we have to guarentee the parent\u0027s method is invoked after they report this ip version abilities, also the driver could confused if they don\u0027t know the existence of the \u0027add_ip_version_capability\u0027 method.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            \u0027consistency_group_support\u0027: \u0027host\u0027,"},{"line_number":230,"context_line":"            \u0027pools\u0027: self._get_pools(),"},{"line_number":231,"context_line":"        }"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if (self.configuration.replication_domain and"},{"line_number":234,"context_line":"                not self.configuration.driver_handles_share_servers):"},{"line_number":235,"context_line":"            data[\u0027replication_type\u0027] \u003d \u0027dr\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_caab4ad5","side":"PARENT","line":232,"updated":"2016-12-19 16:05:50.000000000","message":"do not remove this line","commit_id":"cc19d7b4a792b3c33f082b2312de3ab8b010765f"}],"manila/share/share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if key in constants.ExtraSpecs.BOOLEAN:"},{"line_number":266,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":267,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REVERT_TO_SNAPSHOT_SUPPORT:"},{"line_number":268,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":269,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"},{"line_number":270,"context_line":"        return value in constants.ExtraSpecs.REPLICATION_TYPES"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_ee4d5673","line":267,"range":{"start_line":267,"start_character":0,"end_line":267,"end_character":64},"updated":"2017-01-20 03:57:11.000000000","message":"this is also a BOOLEAN extra spec","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if key in constants.ExtraSpecs.BOOLEAN:"},{"line_number":266,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":267,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REVERT_TO_SNAPSHOT_SUPPORT:"},{"line_number":268,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":269,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"},{"line_number":270,"context_line":"        return value in constants.ExtraSpecs.REPLICATION_TYPES"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_dde12e9c","line":267,"range":{"start_line":267,"start_character":0,"end_line":267,"end_character":64},"in_reply_to":"5a3905b3_ee4d5673","updated":"2017-01-20 09:36:15.000000000","message":"Thanks","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9d53baf50c56f77aec2b3bdfe26b699c4b9fbdd5","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    if key not in get_optional_extra_specs():"},{"line_number":263,"context_line":"        return"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if key in constants.ExtraSpecs.BOOLEAN:"},{"line_number":266,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":267,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"},{"line_number":268,"context_line":"        return value in constants.ExtraSpecs.REPLICATION_TYPES"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_0f6d8932","line":265,"range":{"start_line":265,"start_character":3,"end_line":265,"end_character":43},"updated":"2017-01-25 13:28:47.000000000","message":"Out of scope for this commit.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    if key not in get_optional_extra_specs():"},{"line_number":263,"context_line":"        return"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if key in constants.ExtraSpecs.BOOLEAN:"},{"line_number":266,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":267,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.REPLICATION_TYPE_SPEC:"},{"line_number":268,"context_line":"        return value in constants.ExtraSpecs.REPLICATION_TYPES"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_76b6c48b","line":265,"range":{"start_line":265,"start_character":3,"end_line":265,"end_character":43},"in_reply_to":"3a461143_0f6d8932","updated":"2017-01-26 03:27:23.000000000","message":"Done","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"}],"manila/tests/network/neutron/test_neutron_plugin.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a927ec65c4f34c8cb09a806e675773eb4b6d923f","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"        result \u003d self.bind_plugin._get_matched_ip_address(fix_ips, ip_version)"},{"line_number":1606,"context_line":"        self.assertEqual(fix_ips[1][\u0027ip_address\u0027], result)"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"    @ddt.data({\u0027fix_ips\u0027: [{\u0027ip_address\u0027: \u0027test_ip_1\u0027},"},{"line_number":1609,"context_line":"                           {\u0027ip_address\u0027: \u0027test_ip_2\u0027}],"},{"line_number":1610,"context_line":"               \u0027ip_version\u0027: 4},"},{"line_number":1611,"context_line":"              {\u0027fix_ips\u0027: [{\u0027ip_address\u0027: \u0027test_ip\u0027},"},{"line_number":1612,"context_line":"                           {\u0027ip_address\u0027: \u0027ad80::abaa:0:c2:2\u0027}],"},{"line_number":1613,"context_line":"               \u0027ip_version\u0027: 4},"},{"line_number":1614,"context_line":"              {\u0027fix_ips\u0027: [{\u0027ip_address\u0027: \u0027ad80::abaa:0:c2:1\u0027},"},{"line_number":1615,"context_line":"                           {\u0027ip_address\u0027: \u0027ad80::abaa:0:c2:2\u0027}],"},{"line_number":1616,"context_line":"               \u0027ip_version\u0027: 4},"},{"line_number":1617,"context_line":"              )"},{"line_number":1618,"context_line":"    @ddt.unpack"},{"line_number":1619,"context_line":"    def test__get_matched_ip_address_illegal(self, fix_ips, ip_version):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_205f420f","line":1616,"range":{"start_line":1608,"start_character":0,"end_line":1616,"end_character":32},"updated":"2017-01-20 21:29:07.000000000","message":"Is there a reason you\u0027re not testing illegal ipv6 addresses here?","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f794fb14fe4d1c230b235706737931511b1a8a21","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"        result \u003d self.bind_plugin._get_matched_ip_address(fix_ips, ip_version)"},{"line_number":1606,"context_line":"        self.assertEqual(fix_ips[1][\u0027ip_address\u0027], result)"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"    @ddt.data({\u0027fix_ips\u0027: [{\u0027ip_address\u0027: \u0027test_ip_1\u0027},"},{"line_number":1609,"context_line":"                           {\u0027ip_address\u0027: \u0027test_ip_2\u0027}],"},{"line_number":1610,"context_line":"               \u0027ip_version\u0027: 4},"},{"line_number":1611,"context_line":"              {\u0027fix_ips\u0027: [{\u0027ip_address\u0027: \u0027test_ip\u0027},"},{"line_number":1612,"context_line":"                           {\u0027ip_address\u0027: \u0027ad80::abaa:0:c2:2\u0027}],"},{"line_number":1613,"context_line":"               \u0027ip_version\u0027: 4},"},{"line_number":1614,"context_line":"              {\u0027fix_ips\u0027: [{\u0027ip_address\u0027: \u0027ad80::abaa:0:c2:1\u0027},"},{"line_number":1615,"context_line":"                           {\u0027ip_address\u0027: \u0027ad80::abaa:0:c2:2\u0027}],"},{"line_number":1616,"context_line":"               \u0027ip_version\u0027: 4},"},{"line_number":1617,"context_line":"              )"},{"line_number":1618,"context_line":"    @ddt.unpack"},{"line_number":1619,"context_line":"    def test__get_matched_ip_address_illegal(self, fix_ips, ip_version):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_7006611e","line":1616,"range":{"start_line":1608,"start_character":0,"end_line":1616,"end_character":32},"in_reply_to":"5a3905b3_205f420f","updated":"2017-01-22 07:27:33.000000000","message":"Done","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"}],"manila/tests/scheduler/test_host_manager.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        self.assertEqual(0, fake_host.total_capacity_gb)"},{"line_number":650,"context_line":"        self.assertIsNone(fake_host.free_capacity_gb)"},{"line_number":651,"context_line":"        self.assertTrue(fake_host.ipv4_support)"},{"line_number":652,"context_line":"        self.assertEqual(False, fake_host.ipv6_support)"},{"line_number":653,"context_line":"        # Pool stats has been updated"},{"line_number":654,"context_line":"        self.assertEqual(0, fake_host.pools[\u0027_pool0\u0027].total_capacity_gb)"},{"line_number":655,"context_line":"        self.assertEqual(100, fake_host.pools[\u0027_pool0\u0027].free_capacity_gb)"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_9dce192b","line":652,"updated":"2017-06-27 04:30:53.000000000","message":"Please use assertFalse.","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        self.assertEqual(0, fake_host.total_capacity_gb)"},{"line_number":650,"context_line":"        self.assertIsNone(fake_host.free_capacity_gb)"},{"line_number":651,"context_line":"        self.assertTrue(fake_host.ipv4_support)"},{"line_number":652,"context_line":"        self.assertEqual(False, fake_host.ipv6_support)"},{"line_number":653,"context_line":"        # Pool stats has been updated"},{"line_number":654,"context_line":"        self.assertEqual(0, fake_host.pools[\u0027_pool0\u0027].total_capacity_gb)"},{"line_number":655,"context_line":"        self.assertEqual(100, fake_host.pools[\u0027_pool0\u0027].free_capacity_gb)"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_5643bb13","line":652,"in_reply_to":"5f201791_9dce192b","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        self.assertEqual(0, fake_host.pools[\u0027_pool0\u0027].total_capacity_gb)"},{"line_number":655,"context_line":"        self.assertEqual(100, fake_host.pools[\u0027_pool0\u0027].free_capacity_gb)"},{"line_number":656,"context_line":"        self.assertTrue(fake_host.pools[\u0027_pool0\u0027].ipv4_support)"},{"line_number":657,"context_line":"        self.assertEqual(False, fake_host.pools[\u0027_pool0\u0027].ipv6_support)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        # Test update for existing host state"},{"line_number":660,"context_line":"        share_capability.update(dict(total_capacity_gb\u003d1000))"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_5ddc01e3","line":657,"updated":"2017-06-27 04:30:53.000000000","message":"assertFalse","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        self.assertEqual(0, fake_host.pools[\u0027_pool0\u0027].total_capacity_gb)"},{"line_number":655,"context_line":"        self.assertEqual(100, fake_host.pools[\u0027_pool0\u0027].free_capacity_gb)"},{"line_number":656,"context_line":"        self.assertTrue(fake_host.pools[\u0027_pool0\u0027].ipv4_support)"},{"line_number":657,"context_line":"        self.assertEqual(False, fake_host.pools[\u0027_pool0\u0027].ipv6_support)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        # Test update for existing host state"},{"line_number":660,"context_line":"        share_capability.update(dict(total_capacity_gb\u003d1000))"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_364cbf40","line":657,"in_reply_to":"5f201791_5ddc01e3","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        self.assertEqual(\u0027OpenStack\u0027, fake_host.vendor_name)"},{"line_number":717,"context_line":"        self.assertEqual(\u00271.1\u0027, fake_host.driver_version)"},{"line_number":718,"context_line":"        self.assertTrue(fake_host.ipv4_support)"},{"line_number":719,"context_line":"        self.assertEqual(False, fake_host.ipv6_support)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        # Backend level stats remain uninitialized"},{"line_number":722,"context_line":"        self.assertEqual(0, fake_host.total_capacity_gb)"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_3dd945f2","line":719,"updated":"2017-06-27 04:30:53.000000000","message":"assertFalse","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        self.assertEqual(\u0027OpenStack\u0027, fake_host.vendor_name)"},{"line_number":717,"context_line":"        self.assertEqual(\u00271.1\u0027, fake_host.driver_version)"},{"line_number":718,"context_line":"        self.assertTrue(fake_host.ipv4_support)"},{"line_number":719,"context_line":"        self.assertEqual(False, fake_host.ipv6_support)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        # Backend level stats remain uninitialized"},{"line_number":722,"context_line":"        self.assertEqual(0, fake_host.total_capacity_gb)"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_9666f3c0","line":719,"in_reply_to":"5f201791_3dd945f2","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        self.assertEqual(500, fake_host.pools[\u0027pool1\u0027].total_capacity_gb)"},{"line_number":728,"context_line":"        self.assertEqual(230, fake_host.pools[\u0027pool1\u0027].free_capacity_gb)"},{"line_number":729,"context_line":"        self.assertTrue(fake_host.pools[\u0027pool1\u0027].ipv4_support)"},{"line_number":730,"context_line":"        self.assertEqual(False, fake_host.pools[\u0027pool1\u0027].ipv6_support)"},{"line_number":731,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].total_capacity_gb)"},{"line_number":732,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].free_capacity_gb)"},{"line_number":733,"context_line":"        self.assertTrue(fake_host.pools[\u0027pool2\u0027].ipv4_support)"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_fdde2dd8","line":730,"updated":"2017-06-27 04:30:53.000000000","message":"Same","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        self.assertEqual(500, fake_host.pools[\u0027pool1\u0027].total_capacity_gb)"},{"line_number":728,"context_line":"        self.assertEqual(230, fake_host.pools[\u0027pool1\u0027].free_capacity_gb)"},{"line_number":729,"context_line":"        self.assertTrue(fake_host.pools[\u0027pool1\u0027].ipv4_support)"},{"line_number":730,"context_line":"        self.assertEqual(False, fake_host.pools[\u0027pool1\u0027].ipv6_support)"},{"line_number":731,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].total_capacity_gb)"},{"line_number":732,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].free_capacity_gb)"},{"line_number":733,"context_line":"        self.assertTrue(fake_host.pools[\u0027pool2\u0027].ipv4_support)"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_565cdbeb","line":730,"in_reply_to":"5f201791_fdde2dd8","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].total_capacity_gb)"},{"line_number":732,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].free_capacity_gb)"},{"line_number":733,"context_line":"        self.assertTrue(fake_host.pools[\u0027pool2\u0027].ipv4_support)"},{"line_number":734,"context_line":"        self.assertEqual(False, fake_host.pools[\u0027pool2\u0027].ipv6_support)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"        capability \u003d {"},{"line_number":737,"context_line":"            \u0027share_backend_name\u0027: \u0027Backend1\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_ddf1316d","line":734,"updated":"2017-06-27 04:30:53.000000000","message":"Same","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].total_capacity_gb)"},{"line_number":732,"context_line":"        self.assertEqual(1024, fake_host.pools[\u0027pool2\u0027].free_capacity_gb)"},{"line_number":733,"context_line":"        self.assertTrue(fake_host.pools[\u0027pool2\u0027].ipv4_support)"},{"line_number":734,"context_line":"        self.assertEqual(False, fake_host.pools[\u0027pool2\u0027].ipv6_support)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"        capability \u003d {"},{"line_number":737,"context_line":"            \u0027share_backend_name\u0027: \u0027Backend1\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_760c77eb","line":734,"in_reply_to":"5f201791_ddf1316d","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"}],"manila/tests/share/drivers/dummy.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":117,"context_line":"            \"share_backend_name\") or \"DummyDriver\""},{"line_number":118,"context_line":"        self.migration_progress \u003d {}"},{"line_number":119,"context_line":"        self.dhss_false_ip_version \u003d 4"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _verify_configuration(self):"},{"line_number":122,"context_line":"        allowed_driver_methods \u003d [m for m in dir(self) if m[0] !\u003d \u0027_\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_aa944e44","line":119,"range":{"start_line":119,"start_character":37,"end_line":119,"end_character":38},"updated":"2016-12-19 16:05:50.000000000","message":"make this configurable","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            details \u003d {\"primary_public_ip\": \"10.0.0.10\","},{"line_number":168,"context_line":"                       \"secondary_public_ip\": \"10.0.0.20\","},{"line_number":169,"context_line":"                       \"service_ip\": \"11.0.0.11\"}"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            details \u003d {\"primary_public_ip\": \"1000::0010\","},{"line_number":172,"context_line":"                       \"secondary_public_ip\": \"1000::0020\","},{"line_number":173,"context_line":"                       \"service_ip\": \"1000::0011\"}"},{"line_number":174,"context_line":"        return ["},{"line_number":175,"context_line":"            {"},{"line_number":176,"context_line":"                \"path\": \"%(ip)s:%(mp)s\" % {\"ip\": ip, \"mp\": mountpoint},"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_8ab872e7","line":173,"range":{"start_line":170,"start_character":8,"end_line":173,"end_character":50},"updated":"2016-12-19 16:05:50.000000000","message":"how is this ever going to reach this code if self.dhss_false_ip_version is hardcoded to 4?","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c059550b564ac6b8269c76e73e1ebc52b1c6be87","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    ),"},{"line_number":86,"context_line":"    cfg.IntOpt("},{"line_number":87,"context_line":"        \"dhss_false_ip_version\","},{"line_number":88,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this take effect \""},{"line_number":89,"context_line":"             \"only when driver_handles_share_server is false\","},{"line_number":90,"context_line":"        default\u003d4,"},{"line_number":91,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_875044d6","line":88,"range":{"start_line":88,"start_character":64,"end_line":88,"end_character":68},"updated":"2016-12-20 10:15:50.000000000","message":"takes","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    ),"},{"line_number":86,"context_line":"    cfg.IntOpt("},{"line_number":87,"context_line":"        \"dhss_false_ip_version\","},{"line_number":88,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this take effect \""},{"line_number":89,"context_line":"             \"only when driver_handles_share_server is false\","},{"line_number":90,"context_line":"        default\u003d4,"},{"line_number":91,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_89588458","line":88,"range":{"start_line":88,"start_character":64,"end_line":88,"end_character":68},"in_reply_to":"1a6eadb0_875044d6","updated":"2016-12-22 03:09:58.000000000","message":"Done","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c059550b564ac6b8269c76e73e1ebc52b1c6be87","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.IntOpt("},{"line_number":87,"context_line":"        \"dhss_false_ip_version\","},{"line_number":88,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this take effect \""},{"line_number":89,"context_line":"             \"only when driver_handles_share_server is false\","},{"line_number":90,"context_line":"        default\u003d4,"},{"line_number":91,"context_line":"    )"},{"line_number":92,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_676c089d","line":89,"range":{"start_line":89,"start_character":24,"end_line":89,"end_character":51},"updated":"2016-12-20 10:15:50.000000000","message":"driver_handles_share_servers \u003c\u003d\u003d plural","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4b3080b53d66d01b7a65bb5c07371d69e58fc0c9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.IntOpt("},{"line_number":87,"context_line":"        \"dhss_false_ip_version\","},{"line_number":88,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this take effect \""},{"line_number":89,"context_line":"             \"only when driver_handles_share_server is false\","},{"line_number":90,"context_line":"        default\u003d4,"},{"line_number":91,"context_line":"    )"},{"line_number":92,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_a955481e","line":89,"range":{"start_line":89,"start_character":24,"end_line":89,"end_character":51},"in_reply_to":"1a6eadb0_676c089d","updated":"2016-12-22 03:09:58.000000000","message":"Done","commit_id":"d626c24efcca210055cc96b98b948719e250f6bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.IntOpt("},{"line_number":87,"context_line":"        \"dhss_false_ip_version\","},{"line_number":88,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this takes effect \""},{"line_number":89,"context_line":"             \"only when driver_handles_share_servers is false\","},{"line_number":90,"context_line":"        default\u003d4,"},{"line_number":91,"context_line":"    )"},{"line_number":92,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_8e3db2bd","line":89,"range":{"start_line":89,"start_character":56,"end_line":89,"end_character":61},"updated":"2017-01-20 03:57:11.000000000","message":"False.","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.IntOpt("},{"line_number":87,"context_line":"        \"dhss_false_ip_version\","},{"line_number":88,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this takes effect \""},{"line_number":89,"context_line":"             \"only when driver_handles_share_servers is false\","},{"line_number":90,"context_line":"        default\u003d4,"},{"line_number":91,"context_line":"    )"},{"line_number":92,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_7d03da42","line":89,"range":{"start_line":89,"start_character":56,"end_line":89,"end_character":61},"in_reply_to":"5a3905b3_8e3db2bd","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                       \"secondary_public_ip\": \"10.0.0.20\","},{"line_number":176,"context_line":"                       \"service_ip\": \"11.0.0.11\"}"},{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            details \u003d {\"primary_public_ip\": \"1000::0010\","},{"line_number":179,"context_line":"                       \"secondary_public_ip\": \"1000::0020\","},{"line_number":180,"context_line":"                       \"service_ip\": \"1000::0011\"}"},{"line_number":181,"context_line":"        return ["},{"line_number":182,"context_line":"            {"},{"line_number":183,"context_line":"                \"path\": \"%(ip)s:%(mp)s\" % {\"ip\": ip, \"mp\": mountpoint},"},{"line_number":184,"context_line":"                \"metadata\": {"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_8eabf2d5","line":181,"range":{"start_line":178,"start_character":45,"end_line":181,"end_character":16},"updated":"2017-01-20 03:57:11.000000000","message":"these aren\u0027t valid ipv6 IPs","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                       \"secondary_public_ip\": \"10.0.0.20\","},{"line_number":176,"context_line":"                       \"service_ip\": \"11.0.0.11\"}"},{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            details \u003d {\"primary_public_ip\": \"1000::0010\","},{"line_number":179,"context_line":"                       \"secondary_public_ip\": \"1000::0020\","},{"line_number":180,"context_line":"                       \"service_ip\": \"1000::0011\"}"},{"line_number":181,"context_line":"        return ["},{"line_number":182,"context_line":"            {"},{"line_number":183,"context_line":"                \"path\": \"%(ip)s:%(mp)s\" % {\"ip\": ip, \"mp\": mountpoint},"},{"line_number":184,"context_line":"                \"metadata\": {"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_dda68e52","line":181,"range":{"start_line":178,"start_character":45,"end_line":181,"end_character":16},"in_reply_to":"5a3905b3_8eabf2d5","updated":"2017-01-20 09:36:15.000000000","message":"Why these are not valid IP addresses?","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d40b73f60ea4f0390f96a121be9638ad2f40d62f","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            \"driver_name\": \"Dummy\","},{"line_number":360,"context_line":"            \"pools\": self._get_pools_info(),"},{"line_number":361,"context_line":"        }"},{"line_number":362,"context_line":"        data \u003d self.add_ip_version_capability(data, True, True)"},{"line_number":363,"context_line":"        if self.configuration.replication_domain:"},{"line_number":364,"context_line":"            data[\"replication_type\"] \u003d \"readable\""},{"line_number":365,"context_line":"        super(self.__class__, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_ee82b651","line":362,"range":{"start_line":362,"start_character":52,"end_line":362,"end_character":63},"updated":"2017-01-20 03:57:11.000000000","message":"kwargs as kwargs please","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1122befac63481c46fa17d5ed7004dce7d0df7ce","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            \"driver_name\": \"Dummy\","},{"line_number":360,"context_line":"            \"pools\": self._get_pools_info(),"},{"line_number":361,"context_line":"        }"},{"line_number":362,"context_line":"        data \u003d self.add_ip_version_capability(data, True, True)"},{"line_number":363,"context_line":"        if self.configuration.replication_domain:"},{"line_number":364,"context_line":"            data[\"replication_type\"] \u003d \"readable\""},{"line_number":365,"context_line":"        super(self.__class__, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a3905b3_9dfec636","line":362,"range":{"start_line":362,"start_character":52,"end_line":362,"end_character":63},"in_reply_to":"5a3905b3_ee82b651","updated":"2017-01-20 09:36:15.000000000","message":"Done","commit_id":"c2886d7a6dbfba7eeeb8350605aebd537d418d99"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e5c28167c97e91e890819f86998f912a475c0450","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        },"},{"line_number":87,"context_line":"    ),"},{"line_number":88,"context_line":"    cfg.IntOpt("},{"line_number":89,"context_line":"        \"dhss_false_ip_version\","},{"line_number":90,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this takes effect \""},{"line_number":91,"context_line":"             \"only when driver_handles_share_servers is False\","},{"line_number":92,"context_line":"        default\u003d4,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_d29ec406","line":89,"updated":"2017-01-25 13:55:21.000000000","message":"Need to follow existing options naming template:\n\n\"dummy_driver_\"...\n\nAlso, it is DUMMY driver, why it makes sense only for DHSS\u003dFalse mode? It should be set for both modes.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f15ccda1b4a0fe14a617774864eaae23c5983ed9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        },"},{"line_number":87,"context_line":"    ),"},{"line_number":88,"context_line":"    cfg.IntOpt("},{"line_number":89,"context_line":"        \"dhss_false_ip_version\","},{"line_number":90,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this takes effect \""},{"line_number":91,"context_line":"             \"only when driver_handles_share_servers is False\","},{"line_number":92,"context_line":"        default\u003d4,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_0ff362d7","line":89,"in_reply_to":"3a461143_79b4f7f1","updated":"2017-01-27 11:26:54.000000000","message":"Again, it is DUMMY driver. It is created exactly for such kind of needs. This option could define that DHSS\u003dTrue mode of DUMMY driver supports only value that is set in this opt and it will work. Driver will require configuration of specific version for network plugins.","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3307d0b8d03126d2e1b185322e3ec7a1d50bb5a3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        },"},{"line_number":87,"context_line":"    ),"},{"line_number":88,"context_line":"    cfg.IntOpt("},{"line_number":89,"context_line":"        \"dhss_false_ip_version\","},{"line_number":90,"context_line":"        help\u003d\"Set the enabled ip version for dummy driver, this takes effect \""},{"line_number":91,"context_line":"             \"only when driver_handles_share_servers is False\","},{"line_number":92,"context_line":"        default\u003d4,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a461143_79b4f7f1","line":89,"in_reply_to":"3a461143_d29ec406","updated":"2017-01-26 03:27:23.000000000","message":"done, but this option is only used when dhss_false. when dhss_true the version is decided by networks and driver\u0027s capabilities","commit_id":"cd34be557437d567436e6960cd3d5afe2ae5ee6c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \"pools\": self._get_pools_info(),"},{"line_number":389,"context_line":"            \"share_group_stats\": {"},{"line_number":390,"context_line":"                \"consistent_snapshot_support\": \"pool\","},{"line_number":391,"context_line":"            },"},{"line_number":392,"context_line":"        }"},{"line_number":393,"context_line":"        if self.configuration.replication_domain:"},{"line_number":394,"context_line":"            data[\"replication_type\"] \u003d \"readable\""}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_3d02653e","line":391,"range":{"start_line":391,"start_character":13,"end_line":391,"end_character":14},"updated":"2017-06-27 04:30:53.000000000","message":"Not a related change.","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \"pools\": self._get_pools_info(),"},{"line_number":389,"context_line":"            \"share_group_stats\": {"},{"line_number":390,"context_line":"                \"consistent_snapshot_support\": \"pool\","},{"line_number":391,"context_line":"            },"},{"line_number":392,"context_line":"        }"},{"line_number":393,"context_line":"        if self.configuration.replication_domain:"},{"line_number":394,"context_line":"            data[\"replication_type\"] \u003d \"readable\""}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_3696ff4d","line":391,"range":{"start_line":391,"start_character":13,"end_line":391,"end_character":14},"in_reply_to":"5f201791_3d02653e","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"}],"manila/tests/share/drivers/hitachi/hnas/test_driver.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c9f14681325aa2f3ed7dcc261c35168dae5bd619","unresolved":false,"context_lines":[{"line_number":833,"context_line":"            \u0027reserved_percentage\u0027: driver.CONF.reserved_share_percentage,"},{"line_number":834,"context_line":"            \u0027qos\u0027: False,"},{"line_number":835,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":836,"context_line":"            \u0027dedupe\u0027: True,"},{"line_number":837,"context_line":"            \u0027ipv4_support\u0027: True,"},{"line_number":838,"context_line":"        }"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \u0027get_stats\u0027, mock.Mock("}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_637bb87b","line":837,"range":{"start_line":836,"start_character":1,"end_line":837,"end_character":33},"updated":"2017-01-23 22:42:39.000000000","message":"Probably obvious, but to resolve the merge conflict just add\n\n   \u0027revert_to_snapshot_support\u0027: True,\n\nbetween these two lines.","commit_id":"6048fb8299e5134c57e4c61f9a5127547b0ef58b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8d40b431722d0b99477ef0bb61013d477c6b0dd9","unresolved":false,"context_lines":[{"line_number":837,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":838,"context_line":"            \u0027dedupe\u0027: True,"},{"line_number":839,"context_line":"            \u0027revert_to_snapshot_support\u0027: True,"},{"line_number":840,"context_line":"\t\t\t\u0027ipv4_support\u0027: True,"},{"line_number":841,"context_line":"        }"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \u0027get_stats\u0027, mock.Mock("}],"source_content_type":"text/x-python","patch_set":26,"id":"5a3905b3_98de4bdb","line":840,"range":{"start_line":840,"start_character":0,"end_line":840,"end_character":24},"updated":"2017-01-24 02:45:54.000000000","message":"Remove leading whitespace.","commit_id":"918569a2e600693b91a22393875c0a95931afe18"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":1887,"context_line":"        self.mock_object("},{"line_number":1888,"context_line":"            self._driver.service_instance_manager,"},{"line_number":1889,"context_line":"            \u0027get_common_server\u0027, mock.Mock(return_value\u003dfake_server))"},{"line_number":1890,"context_line":"        self._driver._update_share_stats()"},{"line_number":1891,"context_line":"        self.assertEqual(\u0027Cinder_Volumes\u0027,"},{"line_number":1892,"context_line":"                         self._driver._stats[\u0027share_backend_name\u0027])"},{"line_number":1893,"context_line":"        self.assertEqual(\u0027NFS_CIFS\u0027, self._driver._stats[\u0027storage_protocol\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_eaac868e","line":1890,"range":{"start_line":1890,"start_character":8,"end_line":1890,"end_character":42},"updated":"2016-12-19 16:05:50.000000000","message":"break line above to separate mocks, run and below for asserts","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":1888,"context_line":"            self._driver.service_instance_manager,"},{"line_number":1889,"context_line":"            \u0027get_common_server\u0027, mock.Mock(return_value\u003dfake_server))"},{"line_number":1890,"context_line":"        self._driver._update_share_stats()"},{"line_number":1891,"context_line":"        self.assertEqual(\u0027Cinder_Volumes\u0027,"},{"line_number":1892,"context_line":"                         self._driver._stats[\u0027share_backend_name\u0027])"},{"line_number":1893,"context_line":"        self.assertEqual(\u0027NFS_CIFS\u0027, self._driver._stats[\u0027storage_protocol\u0027])"},{"line_number":1894,"context_line":"        self.assertIsNone(self._driver._stats[\u0027consistency_group_support\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_6a98766b","line":1891,"range":{"start_line":1891,"start_character":8,"end_line":1891,"end_character":42},"updated":"2016-12-19 16:05:50.000000000","message":"break line above","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"}],"manila/tests/share/test_driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":625,"context_line":"    def test_add_capability_if_dhss_true(self, capability,"},{"line_number":626,"context_line":"                                         user_admin_networks, expected):"},{"line_number":627,"context_line":"        share_driver \u003d self._instantiate_share_driver(None, True)"},{"line_number":628,"context_line":"        self.mock_object(share_driver.network_api,"},{"line_number":629,"context_line":"                         \u0027network_plugin_ip_versions\u0027,"},{"line_number":630,"context_line":"                         mock.Mock(side_effect\u003duser_admin_networks))"},{"line_number":631,"context_line":"        result \u003d share_driver.add_ip_version_capability({}, *capability)"},{"line_number":632,"context_line":"        if expected[\u0027ipv4\u0027] is not None:"},{"line_number":633,"context_line":"            self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":634,"context_line":"            self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":635,"context_line":"        if expected[\u0027ipv6\u0027] is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_cacd0a5f","line":632,"range":{"start_line":628,"start_character":8,"end_line":632,"end_character":40},"updated":"2016-12-19 16:05:50.000000000","message":"break lines here:\n\nmocks\n\u003cbreak_line\u003e\nrun\n\u003cbreak_line\u003e\nasserts","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        self.mock_object(share_driver, \u0027get_configuration_ip_versions\u0027,"},{"line_number":660,"context_line":"                         mock.Mock(return_value\u003dconf))"},{"line_number":661,"context_line":"        result \u003d share_driver.add_ip_version_capability({}, *capability)"},{"line_number":662,"context_line":"        print(result)"},{"line_number":663,"context_line":"        if expected[\u0027ipv4\u0027] is not None:"},{"line_number":664,"context_line":"            self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":665,"context_line":"            self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_4a081a92","line":662,"range":{"start_line":662,"start_character":7,"end_line":662,"end_character":21},"updated":"2016-12-19 16:05:50.000000000","message":"remove this print","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"36e3531fb1e37ae5cbd1345b4e1146735fda1569","unresolved":false,"context_lines":[{"line_number":656,"context_line":"    def test_add_capability_if_dhss_false(self, capability,"},{"line_number":657,"context_line":"                                          conf, expected):"},{"line_number":658,"context_line":"        share_driver \u003d self._instantiate_share_driver(None, False)"},{"line_number":659,"context_line":"        self.mock_object(share_driver, \u0027get_configuration_ip_versions\u0027,"},{"line_number":660,"context_line":"                         mock.Mock(return_value\u003dconf))"},{"line_number":661,"context_line":"        result \u003d share_driver.add_ip_version_capability({}, *capability)"},{"line_number":662,"context_line":"        print(result)"},{"line_number":663,"context_line":"        if expected[\u0027ipv4\u0027] is not None:"},{"line_number":664,"context_line":"            self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":665,"context_line":"            self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":666,"context_line":"        if expected[\u0027ipv6\u0027] is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_aaf7ee8a","line":663,"range":{"start_line":659,"start_character":8,"end_line":663,"end_character":40},"updated":"2016-12-19 16:05:50.000000000","message":"break lines here:\n\nmocks\n\u003cbreak_line\u003e\nrun\n\u003cbreak_line\u003e\nasserts","commit_id":"af463669b7b32f1aa0faa15215f5e5d5d7f9aa4b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a927ec65c4f34c8cb09a806e675773eb4b6d923f","unresolved":false,"context_lines":[{"line_number":693,"context_line":"               \u0027expected\u0027: {\u0027ipv4\u0027: None, \u0027ipv6\u0027: None}},"},{"line_number":694,"context_line":"              )"},{"line_number":695,"context_line":"    @ddt.unpack"},{"line_number":696,"context_line":"    def test_add_capability_if_dhss_true(self, capability,"},{"line_number":697,"context_line":"                                         user_admin_networks, expected):"},{"line_number":698,"context_line":"        share_driver \u003d self._instantiate_share_driver(None, True)"},{"line_number":699,"context_line":"        self.mock_object(share_driver.network_api,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_91876ad6","line":696,"range":{"start_line":696,"start_character":8,"end_line":696,"end_character":40},"updated":"2017-01-20 21:29:07.000000000","message":"this should be named \u0027test_add_ip_version_capability_if_dhss_true\u0027 since there are other kinds of capabilities that are not relevant to this test.","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f794fb14fe4d1c230b235706737931511b1a8a21","unresolved":false,"context_lines":[{"line_number":693,"context_line":"               \u0027expected\u0027: {\u0027ipv4\u0027: None, \u0027ipv6\u0027: None}},"},{"line_number":694,"context_line":"              )"},{"line_number":695,"context_line":"    @ddt.unpack"},{"line_number":696,"context_line":"    def test_add_capability_if_dhss_true(self, capability,"},{"line_number":697,"context_line":"                                         user_admin_networks, expected):"},{"line_number":698,"context_line":"        share_driver \u003d self._instantiate_share_driver(None, True)"},{"line_number":699,"context_line":"        self.mock_object(share_driver.network_api,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_d0155540","line":696,"range":{"start_line":696,"start_character":8,"end_line":696,"end_character":40},"in_reply_to":"5a3905b3_91876ad6","updated":"2017-01-22 07:27:33.000000000","message":"Done","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a927ec65c4f34c8cb09a806e675773eb4b6d923f","unresolved":false,"context_lines":[{"line_number":728,"context_line":"               \u0027expected\u0027: {\u0027ipv4\u0027: None, \u0027ipv6\u0027: True}},"},{"line_number":729,"context_line":"              )"},{"line_number":730,"context_line":"    @ddt.unpack"},{"line_number":731,"context_line":"    def test_add_capability_if_dhss_false(self, capability,"},{"line_number":732,"context_line":"                                          conf, expected):"},{"line_number":733,"context_line":"        share_driver \u003d self._instantiate_share_driver(None, False)"},{"line_number":734,"context_line":"        self.mock_object(share_driver, \u0027get_configuration_ip_versions\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_d1d732bd","line":731,"range":{"start_line":731,"start_character":8,"end_line":731,"end_character":42},"updated":"2017-01-20 21:29:07.000000000","message":"this should be named \u0027test_add_ip_version_capability_if_dhss_false\u0027 since there are other kinds of capabilities that are not relevant to this test.","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f794fb14fe4d1c230b235706737931511b1a8a21","unresolved":false,"context_lines":[{"line_number":728,"context_line":"               \u0027expected\u0027: {\u0027ipv4\u0027: None, \u0027ipv6\u0027: True}},"},{"line_number":729,"context_line":"              )"},{"line_number":730,"context_line":"    @ddt.unpack"},{"line_number":731,"context_line":"    def test_add_capability_if_dhss_false(self, capability,"},{"line_number":732,"context_line":"                                          conf, expected):"},{"line_number":733,"context_line":"        share_driver \u003d self._instantiate_share_driver(None, False)"},{"line_number":734,"context_line":"        self.mock_object(share_driver, \u0027get_configuration_ip_versions\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_f0125156","line":731,"range":{"start_line":731,"start_character":8,"end_line":731,"end_character":42},"in_reply_to":"5a3905b3_d1d732bd","updated":"2017-01-22 07:27:33.000000000","message":"Done","commit_id":"5a265094b2b808dfe933421ab7bc3c41b5571126"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        result \u003d share_driver.add_ip_version_capability(data)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1117,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1118,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1119,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"},{"line_number":1120,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_3d8705b8","line":1117,"range":{"start_line":1117,"start_character":25,"end_line":1117,"end_character":66},"updated":"2017-06-27 04:30:53.000000000","message":"reversed.","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        result \u003d share_driver.add_ip_version_capability(data)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1117,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1118,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1119,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"},{"line_number":1120,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_b6b9efcc","line":1117,"range":{"start_line":1117,"start_character":25,"end_line":1117,"end_character":66},"in_reply_to":"5f201791_3d8705b8","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1117,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1118,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1119,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"    @ddt.data({\u0027capability\u0027: (True, False),"},{"line_number":1122,"context_line":"               \u0027conf\u0027: [4],"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_fd8cedd7","line":1119,"range":{"start_line":1119,"start_character":25,"end_line":1119,"end_character":65},"updated":"2017-06-27 04:30:53.000000000","message":"reversed","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1117,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1118,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1119,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"    @ddt.data({\u0027capability\u0027: (True, False),"},{"line_number":1122,"context_line":"               \u0027conf\u0027: [4],"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_96bef3b1","line":1119,"range":{"start_line":1119,"start_character":25,"end_line":1119,"end_character":65},"in_reply_to":"5f201791_fd8cedd7","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"        result \u003d share_driver.add_ip_version_capability(data)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1152,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1153,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1154,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_5db3e198","line":1152,"updated":"2017-06-27 04:30:53.000000000","message":"reversed.","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"        result \u003d share_driver.add_ip_version_capability(data)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1152,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1153,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1154,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_16cf8356","line":1152,"in_reply_to":"5f201791_5db3e198","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2028757fcb6ca4c38f26ab254ea0f7f777618eff","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1152,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1153,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1154,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_1da9e922","line":1154,"updated":"2017-06-27 04:30:53.000000000","message":"reversed.","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3cdd5b1f24053012d48a51059a5ab9ebfb4e387","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"        self.assertIsNotNone(result[\u0027ipv4_support\u0027])"},{"line_number":1152,"context_line":"        self.assertEqual(result[\u0027ipv4_support\u0027], expected[\u0027ipv4\u0027])"},{"line_number":1153,"context_line":"        self.assertIsNotNone(result[\u0027ipv6_support\u0027])"},{"line_number":1154,"context_line":"        self.assertEqual(result[\u0027ipv6_support\u0027], expected[\u0027ipv6\u0027])"}],"source_content_type":"text/x-python","patch_set":48,"id":"5f201791_f6d767ed","line":1154,"in_reply_to":"5f201791_1da9e922","updated":"2017-06-27 09:15:28.000000000","message":"Done","commit_id":"691f6ec4b5eeb71ecc131131a4795610dffffc7f"}],"releasenotes/notes/support-ipv6-in-drivers-and-network-plugins-1833121513edb13d.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8189fd77e56ebbd25c897c55096485851fcffd47","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    type."},{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_52db5f7c","line":7,"range":{"start_line":7,"start_character":59,"end_line":7,"end_character":61},"updated":"2017-07-09 15:04:36.000000000","message":"IP","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c30caaec3b353119d22fbe3a041df457dd39ea41","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    type."},{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_2162d017","line":7,"range":{"start_line":7,"start_character":59,"end_line":7,"end_character":61},"in_reply_to":"3f1d235d_52db5f7c","updated":"2017-07-10 06:44:37.000000000","message":"Done","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8189fd77e56ebbd25c897c55096485851fcffd47","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_12e5e738","line":8,"range":{"start_line":8,"start_character":61,"end_line":8,"end_character":63},"updated":"2017-07-09 15:04:36.000000000","message":"IP","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8189fd77e56ebbd25c897c55096485851fcffd47","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_32d8e37d","line":8,"range":{"start_line":8,"start_character":52,"end_line":8,"end_character":54},"updated":"2017-07-09 15:04:36.000000000","message":"IP","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8189fd77e56ebbd25c897c55096485851fcffd47","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_b2d51346","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":29},"updated":"2017-07-09 15:04:36.000000000","message":"in the lvm driver","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c30caaec3b353119d22fbe3a041df457dd39ea41","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_a175c0ce","line":8,"range":{"start_line":8,"start_character":61,"end_line":8,"end_character":63},"in_reply_to":"3f1d235d_12e5e738","updated":"2017-07-10 06:44:37.000000000","message":"Done","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c30caaec3b353119d22fbe3a041df457dd39ea41","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_c170bcdf","line":8,"range":{"start_line":8,"start_character":52,"end_line":8,"end_character":54},"in_reply_to":"3f1d235d_32d8e37d","updated":"2017-07-10 06:44:37.000000000","message":"Done","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c30caaec3b353119d22fbe3a041df457dd39ea41","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - Added new capabilities \u0027ipv4_support\u0027 and \u0027ipv6_support\u0027 for IP based"},{"line_number":6,"context_line":"    drivers."},{"line_number":7,"context_line":"  - Added IPv6 support in network plugins. (support either ipv6 or IPv4)"},{"line_number":8,"context_line":"  - Added IPv6 support in lvm driver. (support both ipv6 and ipv4)"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"3f1d235d_e16bb8ee","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":29},"in_reply_to":"3f1d235d_b2d51346","updated":"2017-07-10 06:44:37.000000000","message":"Done","commit_id":"d2b4988415004014f2c6cc4a33282dc10932b4b4"}]}
