)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f0a931504f34788ea9bc887d9ba91c53092e7ae0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[LVM,Generic drivers] Fix relationships between parent and child shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"kernel-nfs-server has bug \u00271071733\u0027 where we have overlap of filesystem"},{"line_number":10,"context_line":"identifiers using LVM volumes and their snapshots."},{"line_number":11,"context_line":"We face this bug in manila LVM driver and Generic driver when we use"},{"line_number":12,"context_line":"cinder LVM driver. So, fix it generating unique UUID for all snapshots"},{"line_number":13,"context_line":"and child volumes that will be exported as child shares."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_fad62f26","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":50},"updated":"2016-12-07 18:32:40.000000000","message":"That is a launchpad ubuntu bug report, not an kernel-nfs-server bug report.  Please cite a link in a footnote (as you usually do), preferably to the kernel bug, as that would tell us which kernels and kernel modules are actually affected.\n  The ubuntu LP bug report doesn\u0027t contain this link, so far\nas I can see, so if it\u0027s not reasonable to get an actual kernel bug report, then I won\u0027t downvote if you do:\n\"Reportedly [1], the kernel-nfs-server has a bug where ...\n [1]  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733","commit_id":"0f6070bf596ed474a07bee3e34c72f1e93c74276"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f46a6367a1ed46e4490630173b2e1be09eceff9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[LVM,Generic drivers] Fix relationships between parent and child shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"kernel-nfs-server has bug \u00271071733\u0027 where we have overlap of filesystem"},{"line_number":10,"context_line":"identifiers using LVM volumes and their snapshots."},{"line_number":11,"context_line":"We face this bug in manila LVM driver and Generic driver when we use"},{"line_number":12,"context_line":"cinder LVM driver. So, fix it generating unique UUID for all snapshots"},{"line_number":13,"context_line":"and child volumes that will be exported as child shares."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_c7a3374e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":50},"in_reply_to":"3a71b18c_fad62f26","updated":"2016-12-08 13:19:39.000000000","message":"Done","commit_id":"0f6070bf596ed474a07bee3e34c72f1e93c74276"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f0a931504f34788ea9bc887d9ba91c53092e7ae0","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                               volume):"},{"line_number":347,"context_line":"                    LOG.debug(\"Mounting \u0027%(dev)s\u0027 to path \u0027%(path)s\u0027 on \""},{"line_number":348,"context_line":"                              \"server \u0027%(server)s\u0027.\", log_data)"},{"line_number":349,"context_line":"                    mount_cmd \u003d ("},{"line_number":350,"context_line":"                        \u0027sudo\u0027, \u0027mkdir\u0027, \u0027-p\u0027, mount_path,"},{"line_number":351,"context_line":"                        \u0027\u0026\u0026\u0027, \u0027sudo\u0027, \u0027tune2fs\u0027, \u0027-U\u0027, \u0027random\u0027, device_path,"},{"line_number":352,"context_line":"                        \u0027\u0026\u0026\u0027, \u0027sudo\u0027, \u0027mount\u0027, device_path, mount_path,"},{"line_number":353,"context_line":"                        \u0027\u0026\u0026\u0027, \u0027sudo\u0027, \u0027chmod\u0027, \u0027777\u0027, mount_path,"},{"line_number":354,"context_line":"                    )"},{"line_number":355,"context_line":"                    self._ssh_exec(server_details, mount_cmd)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"                    # Add mount permanently"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_35a998e0","line":354,"range":{"start_line":349,"start_character":13,"end_line":354,"end_character":21},"updated":"2016-12-07 18:32:40.000000000","message":"Thanks for cleaning this up while you made the uuid change\nfor device_path.","commit_id":"0f6070bf596ed474a07bee3e34c72f1e93c74276"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8dc457c7f9cc8b0fe65a26a02bb7b1c26790a496","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        self._allocate_container(share)"},{"line_number":222,"context_line":"        snapshot_device_name \u003d self._get_local_path(snapshot)"},{"line_number":223,"context_line":"        share_device_name \u003d self._get_local_path(share)"},{"line_number":224,"context_line":"        self._execute("},{"line_number":225,"context_line":"            \u0027tune2fs\u0027, \u0027-U\u0027, \u0027random\u0027, share_device_name, run_as_root\u003dTrue,"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        self._copy_volume("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_7ccab8a2","line":224,"range":{"start_line":224,"start_character":8,"end_line":224,"end_character":21},"updated":"2016-12-09 16:59:11.000000000","message":"why not self._try_execute","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"953bf603e52c0a1fa1e5e81c6757921075c256df","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        self._allocate_container(share)"},{"line_number":222,"context_line":"        snapshot_device_name \u003d self._get_local_path(snapshot)"},{"line_number":223,"context_line":"        share_device_name \u003d self._get_local_path(share)"},{"line_number":224,"context_line":"        self._execute("},{"line_number":225,"context_line":"            \u0027tune2fs\u0027, \u0027-U\u0027, \u0027random\u0027, share_device_name, run_as_root\u003dTrue,"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        self._copy_volume("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_2f0564c1","line":224,"range":{"start_line":224,"start_character":8,"end_line":224,"end_character":21},"in_reply_to":"3a71b18c_7ccab8a2","updated":"2016-12-09 17:23:48.000000000","message":"We do not need retry.","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"}],"manila/tests/share/drivers/test_lvm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8dc457c7f9cc8b0fe65a26a02bb7b1c26790a496","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        mount_share \u003d \u0027/dev/mapper/fakevg-fakename\u0027"},{"line_number":191,"context_line":"        mount_snapshot \u003d \u0027/dev/mapper/fakevg-fakename\u0027"},{"line_number":192,"context_line":"        self._helper_nfs.create_export.return_value \u003d \u0027fakelocation\u0027"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        self._driver.create_share_from_snapshot(self._context,"},{"line_number":195,"context_line":"                                                self.share,"},{"line_number":196,"context_line":"                                                snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_9c5b14f6","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":0},"updated":"2016-12-09 16:59:11.000000000","message":"redundant whitespace change.","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"953bf603e52c0a1fa1e5e81c6757921075c256df","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        mount_share \u003d \u0027/dev/mapper/fakevg-fakename\u0027"},{"line_number":191,"context_line":"        mount_snapshot \u003d \u0027/dev/mapper/fakevg-fakename\u0027"},{"line_number":192,"context_line":"        self._helper_nfs.create_export.return_value \u003d \u0027fakelocation\u0027"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        self._driver.create_share_from_snapshot(self._context,"},{"line_number":195,"context_line":"                                                self.share,"},{"line_number":196,"context_line":"                                                snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_6f411c0b","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":0},"in_reply_to":"3a71b18c_9c5b14f6","updated":"2016-12-09 17:23:48.000000000","message":"Done","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"}],"releasenotes/notes/bug-1645751-fixed-shares-created-from-snapshots-for-lvm-and-generic-drivers-94a1161a9e0b5a85.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f0a931504f34788ea9bc887d9ba91c53092e7ae0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fixed LVM and Generic driver shares created from snapshots."},{"line_number":4,"context_line":"    Now, parent and child shares do not mess with each other in"},{"line_number":5,"context_line":"    these driver. The cause was the same as described in this"},{"line_number":6,"context_line":"    Ubuntu launchpad bug \u00271071733\u0027."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_da77b306","line":6,"updated":"2016-12-07 18:32:40.000000000","message":"Please provide the link.","commit_id":"0f6070bf596ed474a07bee3e34c72f1e93c74276"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1f46a6367a1ed46e4490630173b2e1be09eceff9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fixed LVM and Generic driver shares created from snapshots."},{"line_number":4,"context_line":"    Now, parent and child shares do not mess with each other in"},{"line_number":5,"context_line":"    these driver. The cause was the same as described in this"},{"line_number":6,"context_line":"    Ubuntu launchpad bug \u00271071733\u0027."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_6a25caac","line":6,"in_reply_to":"3a71b18c_da77b306","updated":"2016-12-08 13:19:39.000000000","message":"Done","commit_id":"0f6070bf596ed474a07bee3e34c72f1e93c74276"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"cb3e5ea384db07c6e1266f09cd9df3196953dc29","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed LVM and Generic driver shares created from snapshots."},{"line_number":4,"context_line":"    Now, parent and child shares do not mess with each other in"},{"line_number":5,"context_line":"    these driver. The cause was the same as described in Ubuntu launchpad bug"},{"line_number":6,"context_line":"    https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a71b18c_dc210cfe","line":5,"range":{"start_line":5,"start_character":10,"end_line":5,"end_character":16},"updated":"2016-12-09 16:59:09.000000000","message":"s/driver/drivers/","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8dc457c7f9cc8b0fe65a26a02bb7b1c26790a496","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed LVM and Generic driver shares created from snapshots."},{"line_number":4,"context_line":"    Now, parent and child shares do not mess with each other in"},{"line_number":5,"context_line":"    these driver. The cause was the same as described in Ubuntu launchpad bug"},{"line_number":6,"context_line":"    https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a71b18c_dc84acb2","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":17},"updated":"2016-12-09 16:59:11.000000000","message":"would make sense to explain what was fixed at a high level. Perhaps something like:\n\n  Fixed shares created from snapshots on the LVM and Generic driver to \n  no longer share the same filesystem handle as the source shares. Modifying\n  the source share no longer affects any shares created from a snapshot of\n  that share.","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a1326e09484e5e2c640e910b3ebdd3e03df7388","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed LVM and Generic driver shares created from snapshots."},{"line_number":4,"context_line":"    Now, parent and child shares do not mess with each other in"},{"line_number":5,"context_line":"    these driver. The cause was the same as described in Ubuntu launchpad bug"},{"line_number":6,"context_line":"    https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a71b18c_b2af17e2","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":17},"in_reply_to":"3a71b18c_cfc5d03d","updated":"2016-12-09 17:27:22.000000000","message":"Oh. I misunderstood that from the earlier statement then. I recall this was around access rules..Thanks!","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"953bf603e52c0a1fa1e5e81c6757921075c256df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed LVM and Generic driver shares created from snapshots."},{"line_number":4,"context_line":"    Now, parent and child shares do not mess with each other in"},{"line_number":5,"context_line":"    these driver. The cause was the same as described in Ubuntu launchpad bug"},{"line_number":6,"context_line":"    https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1071733"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a71b18c_cfc5d03d","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":17},"in_reply_to":"3a71b18c_dc84acb2","updated":"2016-12-09 17:23:48.000000000","message":"Second sentence is misunderstanding of the problem. Child share was exported using both exports - parent\u0027s and child\u0027s. Data was not corrupted. Parent mount was refering to child volume after mounting child share. Updated.","commit_id":"87aa4e93c14f002b493e905497ed71cf5f759535"}]}
