)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"48fd2660032ce0fbe255c42256eca8705fa89ca1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-11-23 13:32:08 +0800"},{"line_number":4,"context_line":"Commit:     Tina \u003ctina.tang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-08 07:21:31 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 BG share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_d4af6392","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":25},"updated":"2016-12-08 12:43:00.000000000","message":"Commit topic should be as specific as possible. For the moment it is very ambiguous. Use name of the driver in it. For example:\n\n\"\"\"\n[DELL_EMC Unity driver] Support 1Gb share creation\n\nThe minimum filesystem on Unity is 3 GB. This patch changes driver to create 3 GB underlying filsystem for 1 BG share.\n\nChange-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f\n\nCloses-Bug: 1648316\n\"\"\"","commit_id":"9e60c4973c6fad6206115fb15dc1dbfce423b27e"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"578d75235b72ca294793ab96be9a48997ddc8710","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-11-23 13:32:08 +0800"},{"line_number":4,"context_line":"Commit:     Tina \u003ctina.tang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-08 07:21:31 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 BG share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_6babf01e","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":25},"in_reply_to":"3a71b18c_d4af6392","updated":"2016-12-09 03:14:18.000000000","message":"Thanks. I will change it.","commit_id":"9e60c4973c6fad6206115fb15dc1dbfce423b27e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d43cf4e6f004983a9d89857ca6c7f24f70e53083","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 BG share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_b29e6552","line":10,"range":{"start_line":10,"start_character":42,"end_line":10,"end_character":44},"updated":"2016-12-08 19:27:12.000000000","message":"GB","commit_id":"9e60c4973c6fad6206115fb15dc1dbfce423b27e"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"578d75235b72ca294793ab96be9a48997ddc8710","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 BG share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_8baa0c18","line":10,"range":{"start_line":10,"start_character":42,"end_line":10,"end_character":44},"in_reply_to":"3a71b18c_b29e6552","updated":"2016-12-09 03:14:18.000000000","message":"Done","commit_id":"9e60c4973c6fad6206115fb15dc1dbfce423b27e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"713445dacb12a9fff93e1e758abfe30162da2a6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tina \u003ctina.tang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 09:38:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Dell EMC Unity] Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 GB share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_e73f2523","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":37},"updated":"2016-12-09 10:44:54.000000000","message":"\u003c 3GB","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c7ac636728d566ae936e8c13db4a3361471bcc6f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tina \u003ctina.tang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-09 09:38:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Dell EMC Unity] Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 GB share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_e226fdcc","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":37},"in_reply_to":"3a71b18c_e73f2523","updated":"2016-12-12 02:44:14.000000000","message":"Done","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"713445dacb12a9fff93e1e758abfe30162da2a6d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Dell EMC Unity] Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 GB share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_e7f8057f","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":50},"updated":"2016-12-09 10:44:54.000000000","message":"or 2GB share, right?","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c7ac636728d566ae936e8c13db4a3361471bcc6f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Dell EMC Unity] Support create 1 GB share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for 1 GB share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_0224d9c2","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":50},"in_reply_to":"3a71b18c_e7f8057f","updated":"2016-12-12 02:44:14.000000000","message":"Done","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82193f74eccff08407c169be9d504b6e198f25bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Dell EMC Unity] Support create share smaller than 3 GB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for shares smaller than 3 GB."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_60785290","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":35},"updated":"2016-12-14 15:45:58.000000000","message":"file system","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0613b6ce210eca0d312188c6fecedfb960ac17c8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Dell EMC Unity] Support create share smaller than 3 GB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for shares smaller than 3 GB."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_15bd0202","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":35},"in_reply_to":"1a6eadb0_60785290","updated":"2016-12-15 02:27:28.000000000","message":"Done","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82193f74eccff08407c169be9d504b6e198f25bf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for shares smaller than 3 GB."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_40bb56e5","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-12-14 15:45:58.000000000","message":"DocImpact\n\nDo you need to update your configuration reference?","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0613b6ce210eca0d312188c6fecedfb960ac17c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The minimum filesystem on Unity is 3 GB. This patch changes driver"},{"line_number":10,"context_line":"to create 3 GB underlying filsystem for shares smaller than 3 GB."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ida6ad9ad7e752c25b53390f0fee327c594e03f9f"},{"line_number":13,"context_line":"Closes-Bug: 1648316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_35bafe0a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"1a6eadb0_40bb56e5","updated":"2016-12-15 02:27:28.000000000","message":"Done","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"}],"manila/share/drivers/dell_emc/plugins/unity/client.py":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"134a930fb597616bc03eb13b57cd19d8bb26970e","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @staticmethod"},{"line_number":279,"context_line":"    def get_valid_fs_size_in_byte(size_gb):"},{"line_number":280,"context_line":"        if size_gb \u003c 3:"},{"line_number":281,"context_line":"            size_gb \u003d 3"},{"line_number":282,"context_line":"        return size_gb * units.Gi"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_c9e8857f","line":280,"range":{"start_line":280,"start_character":21,"end_line":280,"end_character":22},"updated":"2016-12-09 08:57:40.000000000","message":"I think it would be better to have a constant min_fs_size (or something like this) here. It would make it clearer why we do this check and set size to 3 if is is smaller than that.\n\nAlternatively, a short comment pointing out that 3GB is the smallest supported filesystem size on unity would also be ok.","commit_id":"3448fbb9c6b9eef09a41b7cf65b39139a335a018"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"81406502d08e766db862bc4e6353534810f3074e","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @staticmethod"},{"line_number":279,"context_line":"    def get_valid_fs_size_in_byte(size_gb):"},{"line_number":280,"context_line":"        if size_gb \u003c 3:"},{"line_number":281,"context_line":"            size_gb \u003d 3"},{"line_number":282,"context_line":"        return size_gb * units.Gi"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_cfb405f4","line":280,"range":{"start_line":280,"start_character":21,"end_line":280,"end_character":22},"in_reply_to":"3a71b18c_c9e8857f","updated":"2016-12-09 09:33:23.000000000","message":"Good suggestion. I have changed it. Thanks.","commit_id":"3448fbb9c6b9eef09a41b7cf65b39139a335a018"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"32ec46deb0754e95bddfdd365425a65b4ed72214","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_7b0805da","line":292,"range":{"start_line":292,"start_character":23,"end_line":292,"end_character":58},"updated":"2016-12-09 14:56:16.000000000","message":"Need to add identifier.","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c7ac636728d566ae936e8c13db4a3361471bcc6f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_48ad13e8","line":292,"range":{"start_line":292,"start_character":23,"end_line":292,"end_character":58},"in_reply_to":"3a71b18c_7b0805da","updated":"2016-12-12 02:44:14.000000000","message":"Done","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"713445dacb12a9fff93e1e758abfe30162da2a6d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":285,"context_line":"        return size_gb * units.Gi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def extend_filesystem(self, fs, new_size_gb):"},{"line_number":288,"context_line":"        size \u003d self.get_valid_fs_size_in_byte(new_size_gb)"},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_e7b0058e","line":293,"range":{"start_line":287,"start_character":0,"end_line":293,"end_character":19},"updated":"2016-12-09 10:44:54.000000000","message":"Suppose the user created a 1GB filesystem.  On the backend\nit will be 3GB, but in the manila DB it still shows as\n1GB.  So the user says to extend it to 2GB.  DB gets\nupdated to 2GB, driver throws exception saying it\u0027s already\n2GB.\n\nThis is a bad user experience.","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f122801586ab9cf43499d8a9f902074f5c32d023","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":285,"context_line":"        return size_gb * units.Gi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def extend_filesystem(self, fs, new_size_gb):"},{"line_number":288,"context_line":"        size \u003d self.get_valid_fs_size_in_byte(new_size_gb)"},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_464d3071","line":293,"range":{"start_line":287,"start_character":0,"end_line":293,"end_character":19},"in_reply_to":"3a71b18c_1b0471be","updated":"2016-12-09 15:04:57.000000000","message":"Only in my head :)\n\nStill, the discrepancy between the size reported in the DB\nand the behavior in the backend is going to be confusing to\nthe end user.","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c7ac636728d566ae936e8c13db4a3361471bcc6f","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":285,"context_line":"        return size_gb * units.Gi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def extend_filesystem(self, fs, new_size_gb):"},{"line_number":288,"context_line":"        size \u003d self.get_valid_fs_size_in_byte(new_size_gb)"},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_e55c524d","line":293,"range":{"start_line":287,"start_character":0,"end_line":293,"end_character":19},"in_reply_to":"3a71b18c_2d880c22","updated":"2016-12-12 02:44:14.000000000","message":"Hi Tom, \n\nFor your concerns about the user experience. There will be no error raised at all. I have catched the ERROR and added a debug log only for trouble shooting (L291). The end user will not aware of it.\n\nThanks,\nTina","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4cf9f75df4823401d9ed3f0caf067d2a87589a2c","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":285,"context_line":"        return size_gb * units.Gi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def extend_filesystem(self, fs, new_size_gb):"},{"line_number":288,"context_line":"        size \u003d self.get_valid_fs_size_in_byte(new_size_gb)"},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_669eacb9","line":293,"range":{"start_line":287,"start_character":0,"end_line":293,"end_character":19},"in_reply_to":"3a71b18c_464d3071","updated":"2016-12-09 15:08:10.000000000","message":"It will not be confusing for user at all. User is not informed with size of underlying volume. It is storage-ovner problem only where he is interested in creating shares with size that is bigger than 2Gb.","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8b8398071ed1ff1f4042733da4cee117b77a313e","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":285,"context_line":"        return size_gb * units.Gi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def extend_filesystem(self, fs, new_size_gb):"},{"line_number":288,"context_line":"        size \u003d self.get_valid_fs_size_in_byte(new_size_gb)"},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_2d880c22","line":293,"range":{"start_line":287,"start_character":0,"end_line":293,"end_character":19},"in_reply_to":"3a71b18c_669eacb9","updated":"2016-12-09 17:50:27.000000000","message":"User sees in DB size is 1GB, tries to extend to 2GB, is informed it\u0027s already \"this size\".  You as user wouldn\u0027t be puzzled?","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"32ec46deb0754e95bddfdd365425a65b4ed72214","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":285,"context_line":"        return size_gb * units.Gi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def extend_filesystem(self, fs, new_size_gb):"},{"line_number":288,"context_line":"        size \u003d self.get_valid_fs_size_in_byte(new_size_gb)"},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem is already in this size.\u0027)"},{"line_number":293,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_1b0471be","line":293,"range":{"start_line":287,"start_character":0,"end_line":293,"end_character":19},"in_reply_to":"3a71b18c_e7b0058e","updated":"2016-12-09 14:56:16.000000000","message":"Where do you see \"raise\" of an error?","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82193f74eccff08407c169be9d504b6e198f25bf","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem %s is already in this size.\u0027,"},{"line_number":293,"context_line":"                      fs.get_id())"},{"line_number":294,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_c0b04646","line":292,"range":{"start_line":292,"start_character":48,"end_line":292,"end_character":60},"updated":"2016-12-14 15:45:58.000000000","message":"of size %s \n\n\nplease log the size..","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0613b6ce210eca0d312188c6fecedfb960ac17c8","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027Filesystem %s is already in this size.\u0027,"},{"line_number":293,"context_line":"                      fs.get_id())"},{"line_number":294,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_f1609bd1","line":292,"range":{"start_line":292,"start_character":48,"end_line":292,"end_character":60},"in_reply_to":"1a6eadb0_c0b04646","updated":"2016-12-15 02:27:28.000000000","message":"Done","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"00076f1e97aced1dcb1b3b83b6e3dab61cc8dc03","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    @staticmethod"},{"line_number":282,"context_line":"    def get_valid_fs_size_in_byte(size_gb):"},{"line_number":283,"context_line":"        if size_gb \u003c MIN_FS_SIZE_IN_GB:"},{"line_number":284,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":285,"context_line":"        return size_gb * units.Gi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def extend_filesystem(self, fs, new_size_gb):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_248f2ecd","line":284,"updated":"2016-12-15 06:10:30.000000000","message":"suggest adding a log here that the creating fs will be 3GB at backend.","commit_id":"ebe5c2ade4aa2050ddc23ae4d9e3e7f93ecf58fc"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"00076f1e97aced1dcb1b3b83b6e3dab61cc8dc03","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027The size of the filesystem %(id)s is %(size)s\u0027"},{"line_number":293,"context_line":"                      \u0027byte.\u0027,"},{"line_number":294,"context_line":"                      {\u0027id\u0027: fs.get_id(),"},{"line_number":295,"context_line":"                       \u0027size\u0027: size})"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_049eb262","line":292,"range":{"start_line":292,"start_character":60,"end_line":292,"end_character":68},"updated":"2016-12-15 06:10:30.000000000","message":"add a space behind","commit_id":"ebe5c2ade4aa2050ddc23ae4d9e3e7f93ecf58fc"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"00076f1e97aced1dcb1b3b83b6e3dab61cc8dc03","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            fs.extend(size)"},{"line_number":291,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":292,"context_line":"            LOG.debug(\u0027The size of the filesystem %(id)s is %(size)s\u0027"},{"line_number":293,"context_line":"                      \u0027byte.\u0027,"},{"line_number":294,"context_line":"                      {\u0027id\u0027: fs.get_id(),"},{"line_number":295,"context_line":"                       \u0027size\u0027: size})"},{"line_number":296,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_8481e2c5","line":293,"range":{"start_line":293,"start_character":23,"end_line":293,"end_character":27},"updated":"2016-12-15 06:10:30.000000000","message":"bytes","commit_id":"ebe5c2ade4aa2050ddc23ae4d9e3e7f93ecf58fc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f2ebcb058ff22b57e7c7f7e45ac73ea21a7fbac5","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    @staticmethod"},{"line_number":282,"context_line":"    def get_valid_fs_size_in_byte(size_gb):"},{"line_number":283,"context_line":"        if size_gb \u003c MIN_FS_SIZE_IN_GB:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Uses %(min_size)s GB file system for shares less then \u0027"},{"line_number":285,"context_line":"                      \u0027%(min_size)s GB.\u0027,"},{"line_number":286,"context_line":"                      {\u0027min_size\u0027: MIN_FS_SIZE_IN_GB})"},{"line_number":287,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_e8cc206c","line":284,"range":{"start_line":284,"start_character":23,"end_line":284,"end_character":27},"updated":"2016-12-15 10:17:12.000000000","message":"Using","commit_id":"c3163e2cdf7cad2902ccaaae6df8d908fab8a7c4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f2ebcb058ff22b57e7c7f7e45ac73ea21a7fbac5","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    @staticmethod"},{"line_number":282,"context_line":"    def get_valid_fs_size_in_byte(size_gb):"},{"line_number":283,"context_line":"        if size_gb \u003c MIN_FS_SIZE_IN_GB:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Uses %(min_size)s GB file system for shares less then \u0027"},{"line_number":285,"context_line":"                      \u0027%(min_size)s GB.\u0027,"},{"line_number":286,"context_line":"                      {\u0027min_size\u0027: MIN_FS_SIZE_IN_GB})"},{"line_number":287,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_a8aea87e","line":284,"range":{"start_line":284,"start_character":72,"end_line":284,"end_character":76},"updated":"2016-12-15 10:17:12.000000000","message":"than","commit_id":"c3163e2cdf7cad2902ccaaae6df8d908fab8a7c4"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"9518c5f087684229dd846f91e23a8ef030ffb710","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    @staticmethod"},{"line_number":282,"context_line":"    def get_valid_fs_size_in_byte(size_gb):"},{"line_number":283,"context_line":"        if size_gb \u003c MIN_FS_SIZE_IN_GB:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Uses %(min_size)s GB file system for shares less then \u0027"},{"line_number":285,"context_line":"                      \u0027%(min_size)s GB.\u0027,"},{"line_number":286,"context_line":"                      {\u0027min_size\u0027: MIN_FS_SIZE_IN_GB})"},{"line_number":287,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_48a6f453","line":284,"range":{"start_line":284,"start_character":72,"end_line":284,"end_character":76},"in_reply_to":"1a6eadb0_a8aea87e","updated":"2016-12-15 10:21:51.000000000","message":"Done","commit_id":"c3163e2cdf7cad2902ccaaae6df8d908fab8a7c4"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"9518c5f087684229dd846f91e23a8ef030ffb710","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    @staticmethod"},{"line_number":282,"context_line":"    def get_valid_fs_size_in_byte(size_gb):"},{"line_number":283,"context_line":"        if size_gb \u003c MIN_FS_SIZE_IN_GB:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Uses %(min_size)s GB file system for shares less then \u0027"},{"line_number":285,"context_line":"                      \u0027%(min_size)s GB.\u0027,"},{"line_number":286,"context_line":"                      {\u0027min_size\u0027: MIN_FS_SIZE_IN_GB})"},{"line_number":287,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_28a9b824","line":284,"range":{"start_line":284,"start_character":23,"end_line":284,"end_character":27},"in_reply_to":"1a6eadb0_e8cc206c","updated":"2016-12-15 10:21:51.000000000","message":"Done","commit_id":"c3163e2cdf7cad2902ccaaae6df8d908fab8a7c4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f2ebcb058ff22b57e7c7f7e45ac73ea21a7fbac5","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        try:"},{"line_number":293,"context_line":"            fs.extend(size)"},{"line_number":294,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":295,"context_line":"            LOG.debug(\u0027The size of the filesystem %(id)s is %(size)s \u0027"},{"line_number":296,"context_line":"                      \u0027bytes.\u0027,"},{"line_number":297,"context_line":"                      {\u0027id\u0027: fs.get_id(),"},{"line_number":298,"context_line":"                       \u0027size\u0027: size})"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_a88148c5","line":295,"range":{"start_line":295,"start_character":39,"end_line":295,"end_character":49},"updated":"2016-12-15 10:17:12.000000000","message":"file system","commit_id":"c3163e2cdf7cad2902ccaaae6df8d908fab8a7c4"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"9518c5f087684229dd846f91e23a8ef030ffb710","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        try:"},{"line_number":293,"context_line":"            fs.extend(size)"},{"line_number":294,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":295,"context_line":"            LOG.debug(\u0027The size of the filesystem %(id)s is %(size)s \u0027"},{"line_number":296,"context_line":"                      \u0027bytes.\u0027,"},{"line_number":297,"context_line":"                      {\u0027id\u0027: fs.get_id(),"},{"line_number":298,"context_line":"                       \u0027size\u0027: size})"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_6865701c","line":295,"range":{"start_line":295,"start_character":39,"end_line":295,"end_character":49},"in_reply_to":"1a6eadb0_a88148c5","updated":"2016-12-15 10:21:51.000000000","message":"Done","commit_id":"c3163e2cdf7cad2902ccaaae6df8d908fab8a7c4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"468de3891364577110c270eba3899ed3c093c105","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        if size_gb \u003c MIN_FS_SIZE_IN_GB:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Using %(min_size)s GB file system for shares less than \u0027"},{"line_number":285,"context_line":"                      \u0027%(min_size)s GB.\u0027,"},{"line_number":286,"context_line":"                      {\u0027min_size\u0027: MIN_FS_SIZE_IN_GB})"},{"line_number":287,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":288,"context_line":"        return size_gb * units.Gi"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_ff14c64d","line":286,"range":{"start_line":286,"start_character":22,"end_line":286,"end_character":54},"updated":"2016-12-18 13:35:28.000000000","message":"can go in the previous line.","commit_id":"61013218e63d2acab3d68110dab96aacdeb10e5e"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"208193c88487a74d1e9a8b80a58d88a6b5bd28a3","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        if size_gb \u003c MIN_FS_SIZE_IN_GB:"},{"line_number":284,"context_line":"            LOG.debug(\u0027Using %(min_size)s GB file system for shares less than \u0027"},{"line_number":285,"context_line":"                      \u0027%(min_size)s GB.\u0027,"},{"line_number":286,"context_line":"                      {\u0027min_size\u0027: MIN_FS_SIZE_IN_GB})"},{"line_number":287,"context_line":"            size_gb \u003d MIN_FS_SIZE_IN_GB"},{"line_number":288,"context_line":"        return size_gb * units.Gi"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_c148b18d","line":286,"range":{"start_line":286,"start_character":22,"end_line":286,"end_character":54},"in_reply_to":"1a6eadb0_ff14c64d","updated":"2016-12-19 03:52:36.000000000","message":"Done","commit_id":"61013218e63d2acab3d68110dab96aacdeb10e5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"468de3891364577110c270eba3899ed3c093c105","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":295,"context_line":"            LOG.debug(\u0027The size of the file system %(id)s is %(size)s \u0027"},{"line_number":296,"context_line":"                      \u0027bytes.\u0027,"},{"line_number":297,"context_line":"                      {\u0027id\u0027: fs.get_id(),"},{"line_number":298,"context_line":"                       \u0027size\u0027: size})"},{"line_number":299,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_5f75baf7","line":298,"range":{"start_line":297,"start_character":22,"end_line":298,"end_character":36},"updated":"2016-12-18 13:35:28.000000000","message":"you don\u0027t need to wrap this in a separate line. \n\nLOG.debug(\u0027The size of the file system %(id)s is %(size)s \u0027\n          \u0027bytes.\u0027, {\u0027id\u0027: fs.get_id(), \u0027size\u0027: size})","commit_id":"61013218e63d2acab3d68110dab96aacdeb10e5e"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"208193c88487a74d1e9a8b80a58d88a6b5bd28a3","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        except storops_ex.UnityNothingToModifyError:"},{"line_number":295,"context_line":"            LOG.debug(\u0027The size of the file system %(id)s is %(size)s \u0027"},{"line_number":296,"context_line":"                      \u0027bytes.\u0027,"},{"line_number":297,"context_line":"                      {\u0027id\u0027: fs.get_id(),"},{"line_number":298,"context_line":"                       \u0027size\u0027: size})"},{"line_number":299,"context_line":"        return size"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_a17d75b3","line":298,"range":{"start_line":297,"start_character":22,"end_line":298,"end_character":36},"in_reply_to":"1a6eadb0_5f75baf7","updated":"2016-12-19 03:52:36.000000000","message":"Done","commit_id":"61013218e63d2acab3d68110dab96aacdeb10e5e"}],"manila/tests/share/drivers/dell_emc/plugins/unity/mocked_unity.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"26881ef316f93dc3f48283e0e5ae5fa9ff49edc9","unresolved":false,"context_lines":[{"line_number":979,"context_line":"      get_id: \u0027svc_12\u0027"},{"line_number":980,"context_line":"      extend:"},{"line_number":981,"context_line":"        _raise:"},{"line_number":982,"context_line":"          UnityNothingToModifyError: "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_eb37b9fb","line":982,"updated":"2016-12-12 03:44:27.000000000","message":"Remove trailing space","commit_id":"5c44b10c73f0fd7a873673b14bc9118c870d16fc"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"1d41676c586a1cad17d3108cc6baf3aefe5a2371","unresolved":false,"context_lines":[{"line_number":979,"context_line":"      get_id: \u0027svc_12\u0027"},{"line_number":980,"context_line":"      extend:"},{"line_number":981,"context_line":"        _raise:"},{"line_number":982,"context_line":"          UnityNothingToModifyError: "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_aea14fab","line":982,"in_reply_to":"3a71b18c_eb37b9fb","updated":"2016-12-12 03:51:08.000000000","message":"Done","commit_id":"5c44b10c73f0fd7a873673b14bc9118c870d16fc"}],"manila/tests/share/drivers/dell_emc/plugins/unity/test_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"48fd2660032ce0fbe255c42256eca8705fa89ca1","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.assertEqual(\u0027SPA\u0027, sp.name)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @res_mock.patch_client"},{"line_number":173,"context_line":"    def test_get_valid_fs_size_in_byte_less_then_3gig(self, client):"},{"line_number":174,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(1)"},{"line_number":175,"context_line":"        self.assertEqual(3 * units.Gi, size)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @res_mock.patch_client"},{"line_number":178,"context_line":"    def test_get_valid_fs_size_in_byte(self, client):"},{"line_number":179,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(10)"},{"line_number":180,"context_line":"        self.assertEqual(10 * units.Gi, size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_f4d0dff9","line":180,"range":{"start_line":172,"start_character":0,"end_line":180,"end_character":45},"updated":"2016-12-08 12:43:00.000000000","message":"It is better to code using \"ddt\" module. And, also, add all border cases such as \"2\" and \"4\".","commit_id":"9e60c4973c6fad6206115fb15dc1dbfce423b27e"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"578d75235b72ca294793ab96be9a48997ddc8710","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        self.assertEqual(\u0027SPA\u0027, sp.name)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @res_mock.patch_client"},{"line_number":173,"context_line":"    def test_get_valid_fs_size_in_byte_less_then_3gig(self, client):"},{"line_number":174,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(1)"},{"line_number":175,"context_line":"        self.assertEqual(3 * units.Gi, size)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @res_mock.patch_client"},{"line_number":178,"context_line":"    def test_get_valid_fs_size_in_byte(self, client):"},{"line_number":179,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(10)"},{"line_number":180,"context_line":"        self.assertEqual(10 * units.Gi, size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_aba50848","line":180,"range":{"start_line":172,"start_character":0,"end_line":180,"end_character":45},"in_reply_to":"3a71b18c_f4d0dff9","updated":"2016-12-09 03:14:18.000000000","message":"Done","commit_id":"9e60c4973c6fad6206115fb15dc1dbfce423b27e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"32ec46deb0754e95bddfdd365425a65b4ed72214","unresolved":false,"context_lines":[{"line_number":177,"context_line":"              {\u0027size_gb\u0027: 4, \u0027result\u0027: 4 * units.Gi},"},{"line_number":178,"context_line":"              {\u0027size_gb\u0027: 10, \u0027result\u0027: 10 * units.Gi})"},{"line_number":179,"context_line":"    @ddt.unpack"},{"line_number":180,"context_line":"    @res_mock.patch_client"},{"line_number":181,"context_line":"    def test_get_valid_fs_size(self, client, size_gb, result):"},{"line_number":182,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(size_gb)"},{"line_number":183,"context_line":"        self.assertEqual(result, size)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_db7cb922","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":26},"updated":"2016-12-09 14:56:16.000000000","message":"Client patcher should have been added to \"setUp\" method instead of explicit call on each test.","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c7ac636728d566ae936e8c13db4a3361471bcc6f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"              {\u0027size_gb\u0027: 4, \u0027result\u0027: 4 * units.Gi},"},{"line_number":178,"context_line":"              {\u0027size_gb\u0027: 10, \u0027result\u0027: 10 * units.Gi})"},{"line_number":179,"context_line":"    @ddt.unpack"},{"line_number":180,"context_line":"    @res_mock.patch_client"},{"line_number":181,"context_line":"    def test_get_valid_fs_size(self, client, size_gb, result):"},{"line_number":182,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(size_gb)"},{"line_number":183,"context_line":"        self.assertEqual(result, size)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_a53dfade","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":26},"in_reply_to":"3a71b18c_db7cb922","updated":"2016-12-12 02:44:14.000000000","message":"Thanks for your suggestion. The @patch_client generates a new client object and pass it to the test case as a parameter. Only the test cases need the client object need this decorator. Move it to the setUp method is doable but need to change the whole UT framework. I\u0027d suggest not to change it in this patch.","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"32ec46deb0754e95bddfdd365425a65b4ed72214","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.assertEqual(\u0027SPA\u0027, sp.name)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @ddt.data({\u0027size_gb\u0027: 1, \u0027result\u0027: 3 * units.Gi},"},{"line_number":175,"context_line":"              {\u0027size_gb\u0027: 2, \u0027result\u0027: 3 * units.Gi},"},{"line_number":176,"context_line":"              {\u0027size_gb\u0027: 3, \u0027result\u0027: 3 * units.Gi},"},{"line_number":177,"context_line":"              {\u0027size_gb\u0027: 4, \u0027result\u0027: 4 * units.Gi},"},{"line_number":178,"context_line":"              {\u0027size_gb\u0027: 10, \u0027result\u0027: 10 * units.Gi})"},{"line_number":179,"context_line":"    @ddt.unpack"},{"line_number":180,"context_line":"    @res_mock.patch_client"},{"line_number":181,"context_line":"    def test_get_valid_fs_size(self, client, size_gb, result):"},{"line_number":182,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(size_gb)"},{"line_number":183,"context_line":"        self.assertEqual(result, size)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @res_mock.mock_client_input"},{"line_number":186,"context_line":"    @res_mock.patch_client"},{"line_number":187,"context_line":"    def test_extend_filesystem(self, client, mocked_input):"},{"line_number":188,"context_line":"        fs \u003d mocked_input[\u0027fs\u0027]"},{"line_number":189,"context_line":"        size \u003d client.extend_filesystem(fs, 5)"},{"line_number":190,"context_line":"        self.assertEqual(size, 5 * units.Gi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_bb0ffd86","line":190,"range":{"start_line":174,"start_character":4,"end_line":190,"end_character":44},"updated":"2016-12-09 14:56:16.000000000","message":"@ddt.data((1, 3), (2, 3), (3, 3), (4, 4), (10, 10))\n\n@ddt.unpack\n\n@res_mock.mock_client_input\n\n@res_mock.patch_client\n\ndef test_get_valid_fs_size(self, mock_client, mocked_input,\n\n                           share_size_gb, volume_size_gb):\n\n    fs \u003d mocked_input[\u0027fs\u0027]\n\n    volume_size \u003d mock_client.extend_filesystem(fs, share_size_gb)\n\n    self.assertEqual(volume_size, volume_size_gb * units.Gi)","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c7ac636728d566ae936e8c13db4a3361471bcc6f","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.assertEqual(\u0027SPA\u0027, sp.name)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @ddt.data({\u0027size_gb\u0027: 1, \u0027result\u0027: 3 * units.Gi},"},{"line_number":175,"context_line":"              {\u0027size_gb\u0027: 2, \u0027result\u0027: 3 * units.Gi},"},{"line_number":176,"context_line":"              {\u0027size_gb\u0027: 3, \u0027result\u0027: 3 * units.Gi},"},{"line_number":177,"context_line":"              {\u0027size_gb\u0027: 4, \u0027result\u0027: 4 * units.Gi},"},{"line_number":178,"context_line":"              {\u0027size_gb\u0027: 10, \u0027result\u0027: 10 * units.Gi})"},{"line_number":179,"context_line":"    @ddt.unpack"},{"line_number":180,"context_line":"    @res_mock.patch_client"},{"line_number":181,"context_line":"    def test_get_valid_fs_size(self, client, size_gb, result):"},{"line_number":182,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(size_gb)"},{"line_number":183,"context_line":"        self.assertEqual(result, size)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @res_mock.mock_client_input"},{"line_number":186,"context_line":"    @res_mock.patch_client"},{"line_number":187,"context_line":"    def test_extend_filesystem(self, client, mocked_input):"},{"line_number":188,"context_line":"        fs \u003d mocked_input[\u0027fs\u0027]"},{"line_number":189,"context_line":"        size \u003d client.extend_filesystem(fs, 5)"},{"line_number":190,"context_line":"        self.assertEqual(size, 5 * units.Gi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_c8c123e6","line":190,"range":{"start_line":174,"start_character":4,"end_line":190,"end_character":44},"in_reply_to":"3a71b18c_bb0ffd86","updated":"2016-12-12 02:44:14.000000000","message":"Done, thanks.","commit_id":"d8a10682ec3d64440f9035f91552aab423b784d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82193f74eccff08407c169be9d504b6e198f25bf","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    @ddt.unpack"},{"line_number":176,"context_line":"    @res_mock.patch_client"},{"line_number":177,"context_line":"    def test_get_valid_fs_size(self, client, share_size_gb, fs_size_gb):"},{"line_number":178,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(share_size_gb)"},{"line_number":179,"context_line":"        self.assertEqual(fs_size_gb * units.Gi, size)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @res_mock.mock_client_input"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_006ebe94","line":178,"range":{"start_line":178,"start_character":0,"end_line":178,"end_character":62},"updated":"2016-12-14 15:45:58.000000000","message":"add a blank line after this line","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0613b6ce210eca0d312188c6fecedfb960ac17c8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    @ddt.unpack"},{"line_number":176,"context_line":"    @res_mock.patch_client"},{"line_number":177,"context_line":"    def test_get_valid_fs_size(self, client, share_size_gb, fs_size_gb):"},{"line_number":178,"context_line":"        size \u003d client.get_valid_fs_size_in_byte(share_size_gb)"},{"line_number":179,"context_line":"        self.assertEqual(fs_size_gb * units.Gi, size)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @res_mock.mock_client_input"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_11e35734","line":178,"range":{"start_line":178,"start_character":0,"end_line":178,"end_character":62},"in_reply_to":"1a6eadb0_006ebe94","updated":"2016-12-15 02:27:28.000000000","message":"Done","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82193f74eccff08407c169be9d504b6e198f25bf","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @res_mock.patch_client"},{"line_number":183,"context_line":"    def test_extend_filesystem(self, client, mocked_input):"},{"line_number":184,"context_line":"        fs \u003d mocked_input[\u0027fs\u0027]"},{"line_number":185,"context_line":"        size \u003d client.extend_filesystem(fs, 5)"},{"line_number":186,"context_line":"        self.assertEqual(5 * units.Gi, size)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_c0fa06bd","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":46},"updated":"2016-12-14 15:45:58.000000000","message":"add a blank line before and after this line","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0613b6ce210eca0d312188c6fecedfb960ac17c8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @res_mock.patch_client"},{"line_number":183,"context_line":"    def test_extend_filesystem(self, client, mocked_input):"},{"line_number":184,"context_line":"        fs \u003d mocked_input[\u0027fs\u0027]"},{"line_number":185,"context_line":"        size \u003d client.extend_filesystem(fs, 5)"},{"line_number":186,"context_line":"        self.assertEqual(5 * units.Gi, size)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_31d2135d","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":46},"in_reply_to":"1a6eadb0_c0fa06bd","updated":"2016-12-15 02:27:28.000000000","message":"Done","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"}],"releasenotes/notes/unity-drvier-support-1gb-share-48f032dff8a6a789.yaml":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"48b8023a803139c08670da78c3ed19f63f501fc1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can create shares smaller than 3 GB with"},{"line_number":4,"context_line":"    Dell EMC Unity driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a6eadb0_56128963","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":25},"updated":"2016-12-13 10:39:03.000000000","message":"suggestion:\n\n1) Start with uppercase \"User...\"\n\n2) Given the solution and its consequences, I would prefer if it is stated here that 3GB shares are being created in the storage instead of 1GB... similar to the commit message. The way it is stated here implies that you fixed the bug in the backend, but you introduced a new drawback. It is in the commit message, but since we have renos, it could be briefly stated in the reno as well","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"82193f74eccff08407c169be9d504b6e198f25bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can create shares smaller than 3 GB with"},{"line_number":4,"context_line":"    Dell EMC Unity driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a6eadb0_80de4e3d","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":25},"in_reply_to":"1a6eadb0_56128963","updated":"2016-12-14 15:45:58.000000000","message":"+1\n\nI think it\u0027s best you state that:\n\n* Shares under 3GB cannot be created on the EMC Unity back end. So,\n* if users create shares smaller than 3GB, they will be allocated 3GB on the back end.","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0613b6ce210eca0d312188c6fecedfb960ac17c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can create shares smaller than 3 GB with"},{"line_number":4,"context_line":"    Dell EMC Unity driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a6eadb0_917047de","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":25},"in_reply_to":"1a6eadb0_56128963","updated":"2016-12-15 02:27:28.000000000","message":"That make sense. I will change it.","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0613b6ce210eca0d312188c6fecedfb960ac17c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - users can create shares smaller than 3 GB with"},{"line_number":4,"context_line":"    Dell EMC Unity driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a6eadb0_b179c3ca","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":25},"in_reply_to":"1a6eadb0_80de4e3d","updated":"2016-12-15 02:27:28.000000000","message":"Done","commit_id":"871c73bef7222f29f2efe6d2f969cd2f1b92bbba"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"00076f1e97aced1dcb1b3b83b6e3dab61cc8dc03","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Shares under 3GB cannot be created on the Dell EMC Unity back end. If users"},{"line_number":4,"context_line":"    create shares smaller than 3GB, they will be allocated a 3GB file system on"},{"line_number":5,"context_line":"    the Unity system instead of 1GB."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a6eadb0_44beea65","line":5,"range":{"start_line":5,"start_character":21,"end_line":5,"end_character":35},"updated":"2016-12-15 06:10:30.000000000","message":"why here must be 1GB?","commit_id":"ebe5c2ade4aa2050ddc23ae4d9e3e7f93ecf58fc"}]}
