)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13a631e5ba03b3c7b5f945279f64edb8a0924a57","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, fix the validation if API returns empty list and the py3"},{"line_number":15,"context_line":"compatibility issue."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] Ifd64bb84d03a02aa0a118cc42e1d1b373c439884"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I62a7bf7fcffcab990b19812cd677a0d51088ae0e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_c12b5132","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":0},"updated":"2016-12-12 20:38:50.000000000","message":"IMHO, this isn\u0027t a bug, please add a \"TrivialFix\" flag here.","commit_id":"e07816f550055e6594b7119a42662ae017039ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f0b61935f0eedf99a74f16b8a09299b85022b00","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun2 \u003cjun.zhongjun2@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-16 11:36:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[TrivalFIx] Move share type filter tempest to test_scheduler_stats.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit [1] does not cover last comments."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_b019417c","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":10},"updated":"2016-12-18 23:34:46.000000000","message":"TrivialFix","commit_id":"97bb34c000f8884f3d660ff66d89020efb41092c"}],"manila_tempest_tests/tests/api/admin/test_scheduler_stats.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13a631e5ba03b3c7b5f945279f64edb8a0924a57","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def resource_setup(cls):"},{"line_number":47,"context_line":"        super(SchedulerStatsAdminTest, cls).resource_setup()"},{"line_number":48,"context_line":"        cls.admin_client \u003d cls.shares_v2_client"},{"line_number":49,"context_line":"        cls.st \u003d cls._create_share_type()"},{"line_number":50,"context_line":"        cls.st_negative \u003d cls._create_share_type(negative\u003dTrue)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":53,"context_line":"    def test_pool_list(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_41f901c8","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":63},"updated":"2016-12-12 20:38:50.000000000","message":"Please move this within the test where each is used.. We don\u0027t need these for the other tests in the class","commit_id":"e07816f550055e6594b7119a42662ae017039ed7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a375f69d1dd260e6cb00a9ff3e6904d0376107c4","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        if negative:"},{"line_number":35,"context_line":"            extra_specs \u003d {"},{"line_number":36,"context_line":"                \u0027share_backend_name\u0027: uuidutils.generate_uuid(),"},{"line_number":37,"context_line":"            }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        extra_specs \u003d cls.add_required_extra_specs_to_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_6d7662a5","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":63},"updated":"2016-12-15 09:56:12.000000000","message":"Why do you need UUID here? You could just use \"data_utils.rand_name(..)\" as you do it above.","commit_id":"31be1ffed2b1f73528342b027b64164c78aebb20"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a375f69d1dd260e6cb00a9ff3e6904d0376107c4","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    @ddt.data(True, False)"},{"line_number":193,"context_line":"    def test_pool_list_with_share_type_filter_with_detail_negative("},{"line_number":194,"context_line":"            self, detail):"},{"line_number":195,"context_line":"        st_negative \u003d self._create_share_type(negative\u003dTrue)"},{"line_number":196,"context_line":"        share_type \u003d st_negative[\"share_type\"][\"name\"]"},{"line_number":197,"context_line":"        search_opts \u003d {\"share_type\": share_type}"},{"line_number":198,"context_line":"        pools \u003d self.admin_client.list_pools("},{"line_number":199,"context_line":"            detail\u003ddetail, search_opts\u003dsearch_opts)[\u0027pools\u0027]"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        self.assertEmpty(pools)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _wrap_regex_for_exact_match(self, regex):"},{"line_number":204,"context_line":"        return \u0027^%s$\u0027 % regex"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_edd0b221","line":201,"range":{"start_line":195,"start_character":8,"end_line":201,"end_character":31},"updated":"2016-12-15 09:56:12.000000000","message":"This test changes 2 things:\n- searches by share type NAME instead of ID as above\n- uses fake backend_name\n\nSo, we do not know which of these causes pool list to be empty. So, it is possible one of these changes will cover bug in another.\n\nI propose to separate search by share type ID and Name to different test case.","commit_id":"31be1ffed2b1f73528342b027b64164c78aebb20"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a8c4ac878ab29edd797d7cbb6e680d00184394f6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    @ddt.data((True, True), (True, False), (False, True), (False, False))"},{"line_number":168,"context_line":"    @ddt.unpack"},{"line_number":169,"context_line":"    def test_pool_list_with_share_type_filter_with_detail("},{"line_number":170,"context_line":"            self, detail, use_share_id):"},{"line_number":171,"context_line":"        st \u003d self._create_share_type()"},{"line_number":172,"context_line":"        if use_share_id:"},{"line_number":173,"context_line":"            share_type \u003d st[\"share_type\"][\"id\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_fcf059ff","line":170,"range":{"start_line":170,"start_character":26,"end_line":170,"end_character":38},"updated":"2016-12-15 12:57:44.000000000","message":"share_type_id?\n\nBut it will be easier to use key of dict:\n\n\"\"\"\n@ddt.data((True, \"id\"), (True, \"name\"), (False, \"name\"), (False, \"id\"))\n@ddt.unpack\ntest_name(self, detail, share_type_key):\n    st \u003d self._create_share_type()\n    search_opts \u003d {\"share_type\": st[\"share_type\"][key]}\n    ...\n\"\"\"\n\nSame below.","commit_id":"3573135eb3c8f6a69c158d15b1db60a1b60f147c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2cef0bc8576394869a739b93e58307ad62fa6219","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    @ddt.data((True, True), (True, False), (False, True), (False, False))"},{"line_number":168,"context_line":"    @ddt.unpack"},{"line_number":169,"context_line":"    def test_pool_list_with_share_type_filter_with_detail("},{"line_number":170,"context_line":"            self, detail, use_share_id):"},{"line_number":171,"context_line":"        st \u003d self._create_share_type()"},{"line_number":172,"context_line":"        if use_share_id:"},{"line_number":173,"context_line":"            share_type \u003d st[\"share_type\"][\"id\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_bcbb41e4","line":170,"range":{"start_line":170,"start_character":26,"end_line":170,"end_character":38},"in_reply_to":"1a6eadb0_fcf059ff","updated":"2016-12-15 13:00:02.000000000","message":"s/key/share_type_key/\n\nAlso, it will show more info looking at test name, where we will see \"name\" and \"id\".","commit_id":"3573135eb3c8f6a69c158d15b1db60a1b60f147c"}]}