)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The enhancement includes:"},{"line_number":10,"context_line":"1. Creates tenant for each vlan on the unity system. So that the nas"},{"line_number":11,"context_line":"server in different vlan will have isolated ip address space."},{"line_number":12,"context_line":"2. Select the approprite port on the system to create interface based"},{"line_number":13,"context_line":"on MTU."},{"line_number":14,"context_line":"3. Remove the option unity_server_container to enable the storage"},{"line_number":15,"context_line":"processors load balance and the auto-selection of ports (by mtu)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a3c09a3_4c7937fc","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":24},"updated":"2017-01-13 14:55:07.000000000","message":"appropriate","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The enhancement includes:"},{"line_number":10,"context_line":"1. Creates tenant for each vlan on the unity system. So that the nas"},{"line_number":11,"context_line":"server in different vlan will have isolated ip address space."},{"line_number":12,"context_line":"2. Select the approprite port on the system to create interface based"},{"line_number":13,"context_line":"on MTU."},{"line_number":14,"context_line":"3. Remove the option unity_server_container to enable the storage"},{"line_number":15,"context_line":"processors load balance and the auto-selection of ports (by mtu)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a3c09a3_5ee36c05","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":24},"in_reply_to":"7a3c09a3_4c7937fc","updated":"2017-01-16 06:37:20.000000000","message":"Done","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3787ebbe3a802364685bb12ffb3512dc0fcb543f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"server in different vlan will have isolated IP address space."},{"line_number":12,"context_line":"2. Select the appropriate port on the system to create interface based"},{"line_number":13,"context_line":"on MTU."},{"line_number":14,"context_line":"3. Remove the option unity_server_container (old emc_nas_server_container)"},{"line_number":15,"context_line":"to enable the storage processors load balance and the auto-selection of"},{"line_number":16,"context_line":"ports (by mtu)."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a3c09a3_70863edc","line":14,"range":{"start_line":14,"start_character":45,"end_line":14,"end_character":74},"updated":"2017-01-17 16:22:32.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d56822e1906a0aaa27c5e157ccee3e0d68e38bce","unresolved":false,"context_lines":[{"line_number":11,"context_line":"server in different vlan will have isolated IP address space."},{"line_number":12,"context_line":"2. Select the appropriate port on the system to create interface based"},{"line_number":13,"context_line":"on MTU."},{"line_number":14,"context_line":"3. Remove the option unity_server_container (old emc_nas_server_container)"},{"line_number":15,"context_line":"to enable the storage processors load balance and the auto-selection of"},{"line_number":16,"context_line":"ports (by mtu)."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a3c09a3_b63ede25","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":43},"updated":"2017-01-17 16:24:59.000000000","message":"oh I see now that you want to wipe this var from existence.","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"202a60b11859163d9b45ec8a54ece01ce66e136d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"server in different vlan will have isolated IP address space."},{"line_number":12,"context_line":"2. Select the appropriate port on the system to create interface based"},{"line_number":13,"context_line":"on MTU."},{"line_number":14,"context_line":"3. Remove the option unity_server_container (old emc_nas_server_container)"},{"line_number":15,"context_line":"to enable the storage processors load balance and the auto-selection of"},{"line_number":16,"context_line":"ports (by mtu)."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a3c09a3_e7e975b8","line":14,"range":{"start_line":14,"start_character":45,"end_line":14,"end_character":74},"in_reply_to":"7a3c09a3_70863edc","updated":"2017-01-18 02:17:41.000000000","message":"Done","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"}],"manila/share/drivers/dell_emc/plugins/unity/client.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    @staticmethod"},{"line_number":152,"context_line":"    def _delete_tenant(tenant):"},{"line_number":153,"context_line":"        if tenant.nas_servers:"},{"line_number":154,"context_line":"            LOG.debug(\u0027There are NAS servers belongs to the tenant %s. \u0027,"},{"line_number":155,"context_line":"                      \u0027Do not delete it.\u0027,"},{"line_number":156,"context_line":"                      tenant.get_id())"},{"line_number":157,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_0678eef1","line":154,"range":{"start_line":154,"start_character":45,"end_line":154,"end_character":52},"updated":"2017-01-13 14:55:07.000000000","message":"belonging","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    @staticmethod"},{"line_number":152,"context_line":"    def _delete_tenant(tenant):"},{"line_number":153,"context_line":"        if tenant.nas_servers:"},{"line_number":154,"context_line":"            LOG.debug(\u0027There are NAS servers belongs to the tenant %s. \u0027,"},{"line_number":155,"context_line":"                      \u0027Do not delete it.\u0027,"},{"line_number":156,"context_line":"                      tenant.get_id())"},{"line_number":157,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_5eca8c6f","line":154,"range":{"start_line":154,"start_character":45,"end_line":154,"end_character":52},"in_reply_to":"7a3c09a3_0678eef1","updated":"2017-01-16 06:37:20.000000000","message":"Done","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"}],"manila/share/drivers/dell_emc/plugins/unity/connection.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"c05fe4f1d64b0acb29345d412dc6581db880cdef","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        vlan_id \u003d network[\u0027segmentation_id\u0027]"},{"line_number":434,"context_line":"        mtu \u003d network[\u0027mtu\u0027]"},{"line_number":435,"context_line":"        port \u003d self._choose_a_port_randomly()"},{"line_number":436,"context_line":"        self.client.set_port_mtu(port, mtu)"},{"line_number":437,"context_line":"        # Create the interfaces on NAS server"},{"line_number":438,"context_line":"        self.client.create_interface(nas_server,"},{"line_number":439,"context_line":"                                     ip_addr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_11e660b4","line":436,"range":{"start_line":436,"start_character":8,"end_line":436,"end_character":43},"updated":"2016-12-13 09:23:06.000000000","message":"This will set MTU value of the physical port, right?\nFor environments with multiple MTUs this will cause reconfiguration and failure in cases the MTU setting is shrinked, e.g from 9000 to 1500.","commit_id":"05f654304c07d7fbbba84af074177506bc39dcdc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"12545347a261e0aa9f71ae66c3c94dad0c7e4a22","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        if not sp_ports_map:"},{"line_number":117,"context_line":"            msg \u003d (_(\"All the specified storage ports to be managed \""},{"line_number":118,"context_line":"                     \"do not exist. Please check your configuration \""},{"line_number":119,"context_line":"                     \"emc_interface_ports in manila.conf. \""},{"line_number":120,"context_line":"                     \"The available ports in the backend are %s\") %"},{"line_number":121,"context_line":"                   \",\".join([port.get_id() for port in ports]))"},{"line_number":122,"context_line":"            raise exception.BadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_79582dfb","line":119,"range":{"start_line":119,"start_character":22,"end_line":119,"end_character":41},"updated":"2017-01-11 10:24:35.000000000","message":"shouldn\u0027t be changed to unity_ethernet_ports ?","commit_id":"aa0676882ed61e58294e2418cb670b23a941e674"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0634d76730ed2acbc95be1238d636780de0b2591","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        if not sp_ports_map:"},{"line_number":117,"context_line":"            msg \u003d (_(\"All the specified storage ports to be managed \""},{"line_number":118,"context_line":"                     \"do not exist. Please check your configuration \""},{"line_number":119,"context_line":"                     \"emc_interface_ports in manila.conf. \""},{"line_number":120,"context_line":"                     \"The available ports in the backend are %s\") %"},{"line_number":121,"context_line":"                   \",\".join([port.get_id() for port in ports]))"},{"line_number":122,"context_line":"            raise exception.BadConfigurationException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_852c54ad","line":119,"range":{"start_line":119,"start_character":22,"end_line":119,"end_character":41},"in_reply_to":"ba5201f7_79582dfb","updated":"2017-01-12 06:17:58.000000000","message":"Good catch! Thanks very much. I am changing it.","commit_id":"aa0676882ed61e58294e2418cb670b23a941e674"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"87ec5e018f19c72705d45282933b0e72adeeeda6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027unity_server_meta_pool\u0027,"},{"line_number":45,"context_line":"               deprecated_name\u003d\u0027emc_nas_server_pool\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Pool to persist the meta-data of NAS server.\u0027),"},{"line_number":47,"context_line":"    cfg.ListOpt(\u0027unity_share_data_pools\u0027,"},{"line_number":48,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_names\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Comma separated list of pools that can be used to \u0027"},{"line_number":50,"context_line":"                     \u0027persist share data.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a57fde8_f1dc9b48","line":47,"updated":"2017-01-12 11:55:09.000000000","message":"All removed options should follow \"deprecation\" approach.","commit_id":"3900d1f12b651554bfe50fe3cf5d2cfa01d351d6"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"57fe78a9cdd8c55a2c5a559d09ce32a322508e65","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027unity_server_meta_pool\u0027,"},{"line_number":45,"context_line":"               deprecated_name\u003d\u0027emc_nas_server_pool\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Pool to persist the meta-data of NAS server.\u0027),"},{"line_number":47,"context_line":"    cfg.ListOpt(\u0027unity_share_data_pools\u0027,"},{"line_number":48,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_names\u0027,"},{"line_number":49,"context_line":"                help\u003d\u0027Comma separated list of pools that can be used to \u0027"},{"line_number":50,"context_line":"                     \u0027persist share data.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_29179652","line":47,"in_reply_to":"9a57fde8_f1dc9b48","updated":"2017-01-13 03:22:44.000000000","message":"This is a long history, we deprecated the original option \u0027emc_nas_server_container\u0027 and moved this option to each plugins and renamed it to unity_server_container for unity and vnx_server_container for vnx. And then in this change, we removed the option unity_server_container in Unity. But the \u0027emc_nas_server_container\u0027 is still used by VNX as \u0027vnx_server_container\u0027. Consider that the option \u0027unity_server_container\u0027 is not released yet, so I feel it not needed to mark it as deprecated.\n\nDoes it make sense?","commit_id":"3900d1f12b651554bfe50fe3cf5d2cfa01d351d6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"87ec5e018f19c72705d45282933b0e72adeeeda6","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def check_for_setup_error(self):"},{"line_number":143,"context_line":"        \"\"\"Check for setup error.\"\"\""},{"line_number":144,"context_line":"        pass"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":147,"context_line":"        \"\"\"Create a share and export it based on protocol used.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a57fde8_d1beb7d3","line":144,"range":{"start_line":144,"start_character":8,"end_line":144,"end_character":12},"updated":"2017-01-12 11:55:09.000000000","message":"redundant","commit_id":"3900d1f12b651554bfe50fe3cf5d2cfa01d351d6"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"57fe78a9cdd8c55a2c5a559d09ce32a322508e65","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def check_for_setup_error(self):"},{"line_number":143,"context_line":"        \"\"\"Check for setup error.\"\"\""},{"line_number":144,"context_line":"        pass"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":147,"context_line":"        \"\"\"Create a share and export it based on protocol used.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_69099e31","line":144,"range":{"start_line":144,"start_character":8,"end_line":144,"end_character":12},"in_reply_to":"9a57fde8_d1beb7d3","updated":"2017-01-13 03:22:44.000000000","message":"Done","commit_id":"3900d1f12b651554bfe50fe3cf5d2cfa01d351d6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027Pool to persist the meta-data of NAS server.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027unity_server_container\u0027,"},{"line_number":47,"context_line":"               deprecated_name\u003d\u0027emc_nas_server_container\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027Storage processor to host the NAS server.\u0027),"},{"line_number":49,"context_line":"    cfg.ListOpt(\u0027unity_share_data_pools\u0027,"},{"line_number":50,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_names\u0027,"},{"line_number":51,"context_line":"                help\u003d\u0027Comma separated list of pools that can be used to \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_4c74d79b","side":"PARENT","line":48,"updated":"2017-01-13 14:55:07.000000000","message":"I agree with Valeriy.  You can\u0027t just remove this option like this.  It has to go through the deprecation process.  Looking at the code again, I think this previous change to use \"unity_server_container\" to replace \"emc_nas_server_container\" was not done right.  \"emc_nas_server_container\" should still be valid in Ocata.  You can remove it in Pike but it should still work in Ocata (meaning both unity_server_container and emc_nas_server_container should work in Ocata if you are replacing one option with the other).\n\nhttps://review.openstack.org/#/c/410037/7/manila/share/drivers/dell_emc/plugins/unity/connection.py\n\nI\u0027m suggesting to change this to the following:\n\n    cfg.StrOpt(\u0027emc_nas_server_container\u0027\u0027,\n               deprecated_for_removal\u003dTrue,\n               deprecated_reason\u003d\"xxxxxxxx\",\n               help\u003d\u0027Storage processor to host the NAS server.\u0027),\n\nThis means \"emc_nas_server_container\" will still work for the Unity driver in Ocata but it will be removed in Pike.\n\nAlso remove the line \"emc_nas_server_container with unity_server_container.\" from the following release notes:\n\nhttps://github.com/openstack/manila/blob/master/releasenotes/notes/unity-vnx-rename-options-1656168dd4bdba70.yaml#L7","commit_id":"75e685d40d4e02d38e5dfa1700b4fa6734291073"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027Pool to persist the meta-data of NAS server.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027unity_server_container\u0027,"},{"line_number":47,"context_line":"               deprecated_name\u003d\u0027emc_nas_server_container\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027Storage processor to host the NAS server.\u0027),"},{"line_number":49,"context_line":"    cfg.ListOpt(\u0027unity_share_data_pools\u0027,"},{"line_number":50,"context_line":"                deprecated_name\u003d\u0027emc_nas_pool_names\u0027,"},{"line_number":51,"context_line":"                help\u003d\u0027Comma separated list of pools that can be used to \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_bea1b0ab","side":"PARENT","line":48,"in_reply_to":"7a3c09a3_4c74d79b","updated":"2017-01-16 06:37:20.000000000","message":"Done","commit_id":"75e685d40d4e02d38e5dfa1700b4fa6734291073"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3787ebbe3a802364685bb12ffb3512dc0fcb543f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                help\u003d\u0027Comma separated list of ports that can be used for \u0027"},{"line_number":54,"context_line":"                     \u0027share server interfaces. Members of the list \u0027"},{"line_number":55,"context_line":"                     \u0027can be Unix-style glob expressions.\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027emc_nas_server_container\u0027,"},{"line_number":57,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":58,"context_line":"               deprecated_reason\u003d\u0027Unity driver supports nas server auto load \u0027"},{"line_number":59,"context_line":"                                 \u0027balance.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_56a3faff","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":40},"updated":"2017-01-17 16:22:32.000000000","message":"please correct me if I am wrong, but this variable still needs to be read. I couldn\u0027t find in this patch anywhere that it is being read. The most common way to deprecate is to have the \"deprecated_name\" property set in another config var in order to still have this functionality through another config var, but it seems this is not the case. There is no point in having this property here if it is not being read anywhere\n\nI read the previous comments and I got very confused as how this ended up like it is now. For me, it makes sense to have \"unity_server_container\" declared with \"deprecated_name\u003demc_nas_server_container\", and NOT remove anything else.","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d56822e1906a0aaa27c5e157ccee3e0d68e38bce","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                help\u003d\u0027Comma separated list of ports that can be used for \u0027"},{"line_number":54,"context_line":"                     \u0027share server interfaces. Members of the list \u0027"},{"line_number":55,"context_line":"                     \u0027can be Unix-style glob expressions.\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027emc_nas_server_container\u0027,"},{"line_number":57,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":58,"context_line":"               deprecated_reason\u003d\u0027Unity driver supports nas server auto load \u0027"},{"line_number":59,"context_line":"                                 \u0027balance.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_d61e0aba","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":40},"in_reply_to":"7a3c09a3_56a3faff","updated":"2017-01-17 16:24:59.000000000","message":"Disregard this comment.","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"202a60b11859163d9b45ec8a54ece01ce66e136d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                help\u003d\u0027Comma separated list of ports that can be used for \u0027"},{"line_number":54,"context_line":"                     \u0027share server interfaces. Members of the list \u0027"},{"line_number":55,"context_line":"                     \u0027can be Unix-style glob expressions.\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027emc_nas_server_container\u0027,"},{"line_number":57,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":58,"context_line":"               deprecated_reason\u003d\u0027Unity driver supports nas server auto load \u0027"},{"line_number":59,"context_line":"                                 \u0027balance.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_c759d98f","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":40},"in_reply_to":"7a3c09a3_d61e0aba","updated":"2017-01-18 02:17:41.000000000","message":"Hmm, the history is complicated. Sorry for the confusion.","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3787ebbe3a802364685bb12ffb3512dc0fcb543f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":58,"context_line":"               deprecated_reason\u003d\u0027Unity driver supports nas server auto load \u0027"},{"line_number":59,"context_line":"                                 \u0027balance.\u0027,"},{"line_number":60,"context_line":"               help\u003d\u0027Storage processor to host the NAS server.\u0027),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_f0e06e98","line":60,"range":{"start_line":60,"start_character":61,"end_line":60,"end_character":63},"updated":"2017-01-17 16:22:32.000000000","message":"\u0027Storage processor to host the NAS server. Deprecated.\u0027","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"202a60b11859163d9b45ec8a54ece01ce66e136d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":58,"context_line":"               deprecated_reason\u003d\u0027Unity driver supports nas server auto load \u0027"},{"line_number":59,"context_line":"                                 \u0027balance.\u0027,"},{"line_number":60,"context_line":"               help\u003d\u0027Storage processor to host the NAS server.\u0027),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_e70ed58a","line":60,"range":{"start_line":60,"start_character":61,"end_line":60,"end_character":63},"in_reply_to":"7a3c09a3_56813ac2","updated":"2017-01-18 02:17:41.000000000","message":"Done","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d56822e1906a0aaa27c5e157ccee3e0d68e38bce","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":58,"context_line":"               deprecated_reason\u003d\u0027Unity driver supports nas server auto load \u0027"},{"line_number":59,"context_line":"                                 \u0027balance.\u0027,"},{"line_number":60,"context_line":"               help\u003d\u0027Storage processor to host the NAS server.\u0027),"},{"line_number":61,"context_line":"]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_56813ac2","line":60,"range":{"start_line":60,"start_character":61,"end_line":60,"end_character":63},"in_reply_to":"7a3c09a3_f0e06e98","updated":"2017-01-17 16:24:59.000000000","message":"\u0027Storage processor to host the NAS server. Obsolete.\u0027","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"}],"manila/share/drivers/dell_emc/plugins/unity/utils.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86fd353138f97ad2dbc24c9ab9748748443a47d5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    managed_port_map, _ \u003d match_ports("},{"line_number":70,"context_line":"        valid_ports, port_ids_conf)"},{"line_number":71,"context_line":"    if not managed_port_map:"},{"line_number":72,"context_line":"        msg \u003d (_(\u0027None of the configured port %(conf)s matches the mtu \u0027"},{"line_number":73,"context_line":"                 \u0027%{mtu}s.\u0027) % {\u0027conf\u0027: port_ids_conf, \u0027mtu\u0027: mtu})"},{"line_number":74,"context_line":"        raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":75,"context_line":"    return managed_port_map"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a3c09a3_270c8f40","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":16},"updated":"2017-01-17 10:09:09.000000000","message":"this is not using the i18n import, this is improperly using the \"managed_port_map, _\" above. Pylint is complaining about this, please fix.","commit_id":"6c68efbaf7f2daba52de1413ab6e5229e27287be"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"010daf34f58b969c63ab46fda51c120f8a5b4291","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    managed_port_map, _ \u003d match_ports("},{"line_number":70,"context_line":"        valid_ports, port_ids_conf)"},{"line_number":71,"context_line":"    if not managed_port_map:"},{"line_number":72,"context_line":"        msg \u003d (_(\u0027None of the configured port %(conf)s matches the mtu \u0027"},{"line_number":73,"context_line":"                 \u0027%{mtu}s.\u0027) % {\u0027conf\u0027: port_ids_conf, \u0027mtu\u0027: mtu})"},{"line_number":74,"context_line":"        raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":75,"context_line":"    return managed_port_map"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a3c09a3_62684588","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":16},"in_reply_to":"7a3c09a3_270c8f40","updated":"2017-01-17 10:21:12.000000000","message":"Done","commit_id":"6c68efbaf7f2daba52de1413ab6e5229e27287be"}],"manila/tests/share/drivers/dell_emc/plugins/unity/res_mock.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3787ebbe3a802364685bb12ffb3512dc0fcb543f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def __init__(self):"},{"line_number":88,"context_line":"        self.configuration \u003d conf.Configuration(None)"},{"line_number":89,"context_line":"        self.configuration.emc_share_backend \u003d \u0027unity\u0027"},{"line_number":90,"context_line":"        self.configuration.unity_server_container \u003d \u0027SPA\u0027"},{"line_number":91,"context_line":"        self.configuration.emc_nas_server \u003d \u0027192.168.1.1\u0027"},{"line_number":92,"context_line":"        self.configuration.emc_nas_login \u003d \u0027fake_user\u0027"},{"line_number":93,"context_line":"        self.configuration.emc_nas_password \u003d \u0027fake_password\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_b6c33e88","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":49},"updated":"2017-01-17 16:22:32.000000000","message":"this is reading the variable you removed. is this correct?","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"202a60b11859163d9b45ec8a54ece01ce66e136d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def __init__(self):"},{"line_number":88,"context_line":"        self.configuration \u003d conf.Configuration(None)"},{"line_number":89,"context_line":"        self.configuration.emc_share_backend \u003d \u0027unity\u0027"},{"line_number":90,"context_line":"        self.configuration.unity_server_container \u003d \u0027SPA\u0027"},{"line_number":91,"context_line":"        self.configuration.emc_nas_server \u003d \u0027192.168.1.1\u0027"},{"line_number":92,"context_line":"        self.configuration.emc_nas_login \u003d \u0027fake_user\u0027"},{"line_number":93,"context_line":"        self.configuration.emc_nas_password \u003d \u0027fake_password\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_0743e1b2","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":49},"in_reply_to":"7a3c09a3_b6c33e88","updated":"2017-01-18 02:17:41.000000000","message":"This is not needed for the fake driver anymore, I will remove it.","commit_id":"02765f67499b5b31757625c43800405feac2b1e4"}],"manila/tests/share/drivers/dell_emc/plugins/unity/test_connection.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    def test_validate_port_configuration(self, connection):"},{"line_number":408,"context_line":"        sp_ports_map \u003d connection.validate_port_configuration([\u0027sp*\u0027])"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        self.assertEqual(sp_ports_map[\u0027SPA\u0027],"},{"line_number":411,"context_line":"                         {\u0027spa_eth1\u0027, \u0027spa_eth2\u0027, \u0027spa_la_4\u0027})"},{"line_number":412,"context_line":"        self.assertEqual(sp_ports_map[\u0027SPB\u0027], {\u0027spb_eth1\u0027})"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @res_mock.patch_connection"},{"line_number":415,"context_line":"    def test_validate_port_configuration_exception(self, connection):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_61043c15","line":412,"range":{"start_line":410,"start_character":1,"end_line":412,"end_character":57},"updated":"2017-01-13 14:55:07.000000000","message":"Reversed.  Should be expected, actual.","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    def test_validate_port_configuration(self, connection):"},{"line_number":408,"context_line":"        sp_ports_map \u003d connection.validate_port_configuration([\u0027sp*\u0027])"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        self.assertEqual(sp_ports_map[\u0027SPA\u0027],"},{"line_number":411,"context_line":"                         {\u0027spa_eth1\u0027, \u0027spa_eth2\u0027, \u0027spa_la_4\u0027})"},{"line_number":412,"context_line":"        self.assertEqual(sp_ports_map[\u0027SPB\u0027], {\u0027spb_eth1\u0027})"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @res_mock.patch_connection"},{"line_number":415,"context_line":"    def test_validate_port_configuration_exception(self, connection):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_5e9fec4f","line":412,"range":{"start_line":410,"start_character":1,"end_line":412,"end_character":57},"in_reply_to":"7a3c09a3_61043c15","updated":"2017-01-16 06:37:20.000000000","message":"Done","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"}],"releasenotes/notes/vlan-enhancement-in-unity-driver-0f1d972f2f6d00d9.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC Unity driver obsoleted the option `emc_server_container`. The"},{"line_number":4,"context_line":"    driver will choose storage processor automatically to load balance the"},{"line_number":5,"context_line":"    nas servers."},{"line_number":6,"context_line":"bugfixes:"},{"line_number":7,"context_line":"  - Dell EMC Unity driver is enhanced to use different tenant in Unity for"},{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_0191b899","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":16},"updated":"2017-01-13 14:55:07.000000000","message":"s/emc_server_container/emc_nas_server_container\n\ns/obsoleted/deprecated","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC Unity driver obsoleted the option `emc_server_container`. The"},{"line_number":4,"context_line":"    driver will choose storage processor automatically to load balance the"},{"line_number":5,"context_line":"    nas servers."},{"line_number":6,"context_line":"bugfixes:"},{"line_number":7,"context_line":"  - Dell EMC Unity driver is enhanced to use different tenant in Unity for"},{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_de159c9b","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":16},"in_reply_to":"7a3c09a3_0191b899","updated":"2017-01-16 06:37:20.000000000","message":"Done","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Dell EMC Unity driver obsoleted the option `emc_server_container`. The"},{"line_number":4,"context_line":"    driver will choose storage processor automatically to load balance the"},{"line_number":5,"context_line":"    nas servers."},{"line_number":6,"context_line":"bugfixes:"},{"line_number":7,"context_line":"  - Dell EMC Unity driver is enhanced to use different tenant in Unity for"},{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"},{"line_number":9,"context_line":"    address space."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_015618d2","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":8},"updated":"2017-01-13 14:55:07.000000000","message":"I think the two items below are \"features\" (enhancements).","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Dell EMC Unity driver obsoleted the option `emc_server_container`. The"},{"line_number":4,"context_line":"    driver will choose storage processor automatically to load balance the"},{"line_number":5,"context_line":"    nas servers."},{"line_number":6,"context_line":"bugfixes:"},{"line_number":7,"context_line":"  - Dell EMC Unity driver is enhanced to use different tenant in Unity for"},{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"},{"line_number":9,"context_line":"    address space."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_fe0c1896","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":8},"in_reply_to":"7a3c09a3_015618d2","updated":"2017-01-16 06:37:20.000000000","message":"Done","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - Dell EMC Unity driver is enhanced to use different tenant in Unity for"},{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"},{"line_number":9,"context_line":"    address space."},{"line_number":10,"context_line":"  - Dell EMC Unity driver is enhanced to select the approperite port on the"},{"line_number":11,"context_line":"    system to create interfaces based on the networkauto MTU."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_c141703b","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":63},"updated":"2017-01-13 14:55:07.000000000","message":"appropriate","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - Dell EMC Unity driver is enhanced to use different tenant in Unity for"},{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"},{"line_number":9,"context_line":"    address space."},{"line_number":10,"context_line":"  - Dell EMC Unity driver is enhanced to select the approperite port on the"},{"line_number":11,"context_line":"    system to create interfaces based on the networkauto MTU."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_1e1004a8","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":63},"in_reply_to":"7a3c09a3_c141703b","updated":"2017-01-16 06:37:20.000000000","message":"Done","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"87c37a3b45edd0c82eee2b63c15e7bc4dd7d69bf","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"},{"line_number":9,"context_line":"    address space."},{"line_number":10,"context_line":"  - Dell EMC Unity driver is enhanced to select the approperite port on the"},{"line_number":11,"context_line":"    system to create interfaces based on the networkauto MTU."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_c16890bd","line":11,"range":{"start_line":11,"start_character":45,"end_line":11,"end_character":56},"updated":"2017-01-13 14:55:07.000000000","message":"space between \"network\" and \"auto\"?","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"4efe7bdc31079ae2486c0972c0dc85d1d186be69","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    each vlan. Thus the nas server in different vlan could have isolated IP"},{"line_number":9,"context_line":"    address space."},{"line_number":10,"context_line":"  - Dell EMC Unity driver is enhanced to select the approperite port on the"},{"line_number":11,"context_line":"    system to create interfaces based on the networkauto MTU."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a3c09a3_5e228c02","line":11,"range":{"start_line":11,"start_character":45,"end_line":11,"end_character":56},"in_reply_to":"7a3c09a3_c16890bd","updated":"2017-01-16 06:37:20.000000000","message":"changed it to network.","commit_id":"bd75e53ee3c271c7926a7c6777e60c6b2aff5395"}]}
