)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9b616ddd313e9e31e01a009b52d09a952fa55145","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trivial fix translate issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix some translate issues according to solo.i18n guideline [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] http://docs.openstack.org/developer/oslo.i18n/guidelines.html"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_e0503461","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":43},"updated":"2016-12-19 13:05:54.000000000","message":"oslo","commit_id":"02d69643f966cac072fc19f05bc5a077cb21a011"}],"manila/scheduler/manager.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9b616ddd313e9e31e01a009b52d09a952fa55145","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    def _set_share_state_and_notify(self, method, state, context, ex,"},{"line_number":188,"context_line":"                                    request_spec):"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        LOG.error(_LE(\"Failed to schedule %(method)s: %(ex)s\"),"},{"line_number":191,"context_line":"                  {\"method\": method, \"ex\": ex})"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        properties \u003d request_spec.get(\u0027share_properties\u0027, {})"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_0b76313e","line":191,"range":{"start_line":190,"start_character":2,"end_line":191,"end_character":47},"updated":"2016-12-19 13:05:54.000000000","message":"We could change this to LOG.exception and drop the \u0027e\u0027 argument since LOG.exception *is* a LOG.error with the exception msg added automatically, but I\u0027m OK with not doing this in this patch.","commit_id":"02d69643f966cac072fc19f05bc5a077cb21a011"}],"manila/share/api.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"efdb648f932b070a47bc57f6d26b4d9852d0926b","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        except Exception as e:"},{"line_number":722,"context_line":"            reservations \u003d None"},{"line_number":723,"context_line":"            LOG.exception("},{"line_number":724,"context_line":"                _LE(\"Failed to update quota for deleting share: %s\"), e)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        for share_instance in share.instances:"},{"line_number":727,"context_line":"            if share_instance[\u0027host\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2075f562","line":724,"range":{"start_line":724,"start_character":69,"end_line":724,"end_character":72},"updated":"2016-12-17 06:17:07.000000000","message":"I think no need to print the exception explicitly if you already use LOG.exception.","commit_id":"d569c7f3e054a4b44b607d4b0a422f447980d4b6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9b616ddd313e9e31e01a009b52d09a952fa55145","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        except Exception as e:"},{"line_number":722,"context_line":"            reservations \u003d None"},{"line_number":723,"context_line":"            LOG.exception("},{"line_number":724,"context_line":"                _LE(\"Failed to update quota for deleting share: %s\"), e)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        for share_instance in share.instances:"},{"line_number":727,"context_line":"            if share_instance[\u0027host\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_cbf8b9c7","line":724,"range":{"start_line":724,"start_character":69,"end_line":724,"end_character":72},"updated":"2016-12-19 13:05:54.000000000","message":"LOG.exception already includes the exception info so we should drop this argument but I\u0027m OK with not doing it in this patch.","commit_id":"02d69643f966cac072fc19f05bc5a077cb21a011"}],"manila/share/drivers/dell_emc/plugins/vnx/object_manager.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"efdb648f932b070a47bc57f6d26b4d9852d0926b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from manila.common import constants as const"},{"line_number":26,"context_line":"from manila import exception"},{"line_number":27,"context_line":"from manila.i18n import _, _LI, _LW, _LE"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import connector"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import constants"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import utils as vnx_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_a06025a6","line":27,"range":{"start_line":27,"start_character":37,"end_line":27,"end_character":40},"updated":"2016-12-17 06:17:07.000000000","message":"keep it alphabetical","commit_id":"d569c7f3e054a4b44b607d4b0a422f447980d4b6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9b616ddd313e9e31e01a009b52d09a952fa55145","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        try:"},{"line_number":441,"context_line":"            self._execute_cmd(copy_ckpt_cmd, check_exit_code\u003dTrue)"},{"line_number":442,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":443,"context_line":"            LOG.error(_LE(\"Failed to copy content from snapshot %(snap)s to \""},{"line_number":444,"context_line":"                          \"file system %(filesystem)s. Reason: %(err)s.\"),"},{"line_number":445,"context_line":"                      {\u0027snap\u0027: snap_name,"},{"line_number":446,"context_line":"                       \u0027filesystem\u0027: name,"},{"line_number":447,"context_line":"                       \u0027err\u0027: e})"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        # When an error happens during nas_copy, we need to continue"},{"line_number":450,"context_line":"        # deleting the checkpoint of the target file system if it exists."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ab861d11","line":447,"range":{"start_line":443,"start_character":0,"end_line":447,"end_character":33},"updated":"2016-12-19 13:05:54.000000000","message":"We could change this to LOG.exception and drop the \u0027e\u0027 argument since LOG.exception *is* a LOG.error with the exception msg added automatically, but I\u0027m OK with not doing this in this patch.","commit_id":"02d69643f966cac072fc19f05bc5a077cb21a011"}],"manila/share/share_types.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"efdb648f932b070a47bc57f6d26b4d9852d0926b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            LOG.exception(_LE(\u0027Share type %(share_type)s has invalid required\u0027"},{"line_number":92,"context_line":"                              \u0027 extra specs: %(error)s\u0027),"},{"line_number":93,"context_line":"                          {\u0027share_type\u0027: type_name,"},{"line_number":94,"context_line":"                           \u0027error\u0027: e})"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        type_args[\u0027required_extra_specs\u0027] \u003d required_extra_specs"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_20c7b596","line":94,"range":{"start_line":94,"start_character":27,"end_line":94,"end_character":37},"updated":"2016-12-17 06:17:07.000000000","message":"ditto","commit_id":"d569c7f3e054a4b44b607d4b0a422f447980d4b6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9b616ddd313e9e31e01a009b52d09a952fa55145","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            LOG.exception(_LE(\u0027Share type %(share_type)s has invalid required\u0027"},{"line_number":92,"context_line":"                              \u0027 extra specs: %(error)s\u0027),"},{"line_number":93,"context_line":"                          {\u0027share_type\u0027: type_name,"},{"line_number":94,"context_line":"                           \u0027error\u0027: e})"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        type_args[\u0027required_extra_specs\u0027] \u003d required_extra_specs"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_4b4ca976","line":94,"range":{"start_line":94,"start_character":27,"end_line":94,"end_character":39},"updated":"2016-12-19 13:05:54.000000000","message":"LOG.exception already includes the exception info so we should drop this argument but I\u0027m OK with not doing it in this patch.","commit_id":"02d69643f966cac072fc19f05bc5a077cb21a011"}]}
