)]}'
{"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"c5d6a76c855e942567eedc940a209bb787347e15","unresolved":false,"context_lines":[{"line_number":283,"context_line":"iniset $TEMPEST_CONFIG validation ip_version_for_ssh 4"},{"line_number":284,"context_line":"iniset $TEMPEST_CONFIG validation network_for_ssh ${PRIVATE_NETWORK_NAME:-\"private\"}"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"iniset $TEMPEST_CONFIG share default_share_type_name ${MANILA_DEFAULT_SHARE_TYPE:-default}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"# check if tempest plugin was installed correctly"},{"line_number":289,"context_line":"echo \u0027import pkg_resources; print list(pkg_resources.iter_entry_points(\"tempest.test_plugins\"))\u0027 | python"}],"source_content_type":"text/x-sh","patch_set":24,"id":"3a461143_6ce7f040","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":90},"updated":"2017-01-25 16:32:14.000000000","message":"why is this part of this patch?","commit_id":"0549f016aac4763858130c4889ac8c48a75dd424"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"93b60f6c6fcf93d02922677c5f2e534793ac55d5","unresolved":false,"context_lines":[{"line_number":283,"context_line":"iniset $TEMPEST_CONFIG validation ip_version_for_ssh 4"},{"line_number":284,"context_line":"iniset $TEMPEST_CONFIG validation network_for_ssh ${PRIVATE_NETWORK_NAME:-\"private\"}"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"iniset $TEMPEST_CONFIG share default_share_type_name ${MANILA_DEFAULT_SHARE_TYPE:-default}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"# check if tempest plugin was installed correctly"},{"line_number":289,"context_line":"echo \u0027import pkg_resources; print list(pkg_resources.iter_entry_points(\"tempest.test_plugins\"))\u0027 | python"}],"source_content_type":"text/x-sh","patch_set":24,"id":"3a461143_b8782efa","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":90},"in_reply_to":"3a461143_6ce7f040","updated":"2017-01-25 17:59:05.000000000","message":"There is a problem that affects all scenario jobs since create_share_from_snapshots merged, but it did not cause any tests to fail or prevent the job from passing because the default value of create_share_from_snapshot extra-spec was True, but the same problem prevents mountable_snapshots tests from running. This change allows the mountable tests to run correctly and fixes that existing problem.\n\nThe problem is that we usually configure the default share type with the extra specs we want tempest to run, but if this variable is not defined, tempest will create a share type to run the tests (only scenario tests), but it has been doing so incorrectly since create_share_from_snapshot merged.","commit_id":"0549f016aac4763858130c4889ac8c48a75dd424"}],"manila_tempest_tests/tests/scenario/manager_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4040af191cd3094c99c859e5dc13dd08d7e3b957","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        return access"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def _allow_access_snapshot(self, snapshot_id, access_type\u003d\"ip\","},{"line_number":170,"context_line":"                               access_to\u003d\"0.0.0.0\", cleanup\u003dTrue):"},{"line_number":171,"context_line":"        \"\"\"Allow snapshot access"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :param snapshot_id: id of the snapshot"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a3905b3_abebf876","line":170,"range":{"start_line":170,"start_character":42,"end_line":170,"end_character":49},"updated":"2017-01-22 05:27:33.000000000","message":"0.0.0.0/0","commit_id":"1693fe33918b850db8709d6eb572c12f1a3ac9a7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"77a90ccb96ec2b04f25b4add9efcb72f5c8efcb1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        return access"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def _allow_access_snapshot(self, snapshot_id, access_type\u003d\"ip\","},{"line_number":170,"context_line":"                               access_to\u003d\"0.0.0.0\", cleanup\u003dTrue):"},{"line_number":171,"context_line":"        \"\"\"Allow snapshot access"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :param snapshot_id: id of the snapshot"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a3905b3_d47a9f76","line":170,"range":{"start_line":170,"start_character":42,"end_line":170,"end_character":49},"in_reply_to":"5a3905b3_abebf876","updated":"2017-01-22 18:17:54.000000000","message":"Done","commit_id":"1693fe33918b850db8709d6eb572c12f1a3ac9a7"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"33a1e9157e1fba1c01ce88bbcf5c48b925cf036f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.shares_v2_client.wait_for_snapshot_access_rule_status("},{"line_number":182,"context_line":"            snapshot_id, access[\u0027id\u0027])"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if cleanup:"},{"line_number":185,"context_line":"            self.addCleanup(self.shares_v2_client.delete_snapshot_access_rule,"},{"line_number":186,"context_line":"                            snapshot_id, access[\u0027id\u0027])"},{"line_number":187,"context_line":"        return access"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _create_router_interface(self, subnet_id, client\u003dNone, router_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_3beb59b2","line":186,"range":{"start_line":184,"start_character":9,"end_line":186,"end_character":54},"updated":"2017-01-24 23:12:44.000000000","message":"better to addCleanup before the wait","commit_id":"b3daeeaceeec57bd3f481c7645247620356b3c12"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e10a5d70556cb9d08c6193b3ea2c7c6c68ee1892","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.shares_v2_client.wait_for_snapshot_access_rule_status("},{"line_number":182,"context_line":"            snapshot_id, access[\u0027id\u0027])"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if cleanup:"},{"line_number":185,"context_line":"            self.addCleanup(self.shares_v2_client.delete_snapshot_access_rule,"},{"line_number":186,"context_line":"                            snapshot_id, access[\u0027id\u0027])"},{"line_number":187,"context_line":"        return access"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _create_router_interface(self, subnet_id, client\u003dNone, router_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_a55c72ee","line":186,"range":{"start_line":184,"start_character":9,"end_line":186,"end_character":54},"in_reply_to":"5a3905b3_3beb59b2","updated":"2017-01-25 09:50:12.000000000","message":"Done","commit_id":"b3daeeaceeec57bd3f481c7645247620356b3c12"}],"manila_tempest_tests/tests/scenario/test_share_basic_ops.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4040af191cd3094c99c859e5dc13dd08d7e3b957","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        self.assertIn(\u0027file3\u0027, output)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":500,"context_line":"    @base.skip_if_microversion_not_supported(\"2.26\")"},{"line_number":501,"context_line":"    @testtools.skipUnless(CONF.share.run_mount_snapshot_tests,"},{"line_number":502,"context_line":"                          \u0027Mountable snapshots tests are disabled.\u0027)"},{"line_number":503,"context_line":"    def test_read_mountable_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a3905b3_4b97f4eb","line":500,"range":{"start_line":500,"start_character":46,"end_line":500,"end_character":50},"updated":"2017-01-22 05:27:33.000000000","message":"2.31","commit_id":"1693fe33918b850db8709d6eb572c12f1a3ac9a7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"77a90ccb96ec2b04f25b4add9efcb72f5c8efcb1","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        self.assertIn(\u0027file3\u0027, output)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":500,"context_line":"    @base.skip_if_microversion_not_supported(\"2.26\")"},{"line_number":501,"context_line":"    @testtools.skipUnless(CONF.share.run_mount_snapshot_tests,"},{"line_number":502,"context_line":"                          \u0027Mountable snapshots tests are disabled.\u0027)"},{"line_number":503,"context_line":"    def test_read_mountable_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a3905b3_f47f9b63","line":500,"range":{"start_line":500,"start_character":46,"end_line":500,"end_character":50},"in_reply_to":"5a3905b3_4b97f4eb","updated":"2017-01-22 18:17:54.000000000","message":"Done","commit_id":"1693fe33918b850db8709d6eb572c12f1a3ac9a7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"306e9fedcdee3238dec760e253e50ff00f411e64","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.share \u003d self._create_share(**kwargs)"},{"line_number":182,"context_line":"        return self.share"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def allow_access_ip(self, id, ip\u003dNone, instance\u003dNone, cleanup\u003dTrue,"},{"line_number":185,"context_line":"                        snapshot\u003dFalse):"},{"line_number":186,"context_line":"        if instance and not ip:"},{"line_number":187,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_bd21e6b6","line":184,"range":{"start_line":184,"start_character":30,"end_line":184,"end_character":32},"updated":"2017-01-25 11:56:26.000000000","message":"\"id\" is built-in, do not redefine it without real need.","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ca37a7c8e53452fe69ae7ff7f24c911278001b72","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.share \u003d self._create_share(**kwargs)"},{"line_number":182,"context_line":"        return self.share"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def allow_access_ip(self, id, ip\u003dNone, instance\u003dNone, cleanup\u003dTrue,"},{"line_number":185,"context_line":"                        snapshot\u003dFalse):"},{"line_number":186,"context_line":"        if instance and not ip:"},{"line_number":187,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_13d2eb34","line":184,"range":{"start_line":184,"start_character":30,"end_line":184,"end_character":32},"in_reply_to":"5a3905b3_bd21e6b6","updated":"2017-01-25 12:41:49.000000000","message":"Done","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"306e9fedcdee3238dec760e253e50ff00f411e64","unresolved":false,"context_lines":[{"line_number":500,"context_line":"    @base.skip_if_microversion_lt(\"2.32\")"},{"line_number":501,"context_line":"    @testtools.skipUnless(CONF.share.run_mount_snapshot_tests,"},{"line_number":502,"context_line":"                          \u0027Mountable snapshots tests are disabled.\u0027)"},{"line_number":503,"context_line":"    def test_read_mountable_snapshot(self):"},{"line_number":504,"context_line":"        if self.protocol.upper() \u003d\u003d \u0027CIFS\u0027:"},{"line_number":505,"context_line":"            msg \u003d \"Skipped for CIFS protocol because of bug/1649573\""},{"line_number":506,"context_line":"            raise self.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_103661b4","line":503,"updated":"2017-01-25 11:56:26.000000000","message":"+\n\"\"\"\n@testtools.skipUnless(\n    CONF.share.run_snapshot_tests, \"Snapshot tests are disabled.\")\n\"\"\"","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ca37a7c8e53452fe69ae7ff7f24c911278001b72","unresolved":false,"context_lines":[{"line_number":500,"context_line":"    @base.skip_if_microversion_lt(\"2.32\")"},{"line_number":501,"context_line":"    @testtools.skipUnless(CONF.share.run_mount_snapshot_tests,"},{"line_number":502,"context_line":"                          \u0027Mountable snapshots tests are disabled.\u0027)"},{"line_number":503,"context_line":"    def test_read_mountable_snapshot(self):"},{"line_number":504,"context_line":"        if self.protocol.upper() \u003d\u003d \u0027CIFS\u0027:"},{"line_number":505,"context_line":"            msg \u003d \"Skipped for CIFS protocol because of bug/1649573\""},{"line_number":506,"context_line":"            raise self.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_33a527b5","line":503,"in_reply_to":"5a3905b3_103661b4","updated":"2017-01-25 12:41:49.000000000","message":"Done","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2539a71ab745224523bbcab40deb333280620f8f","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.addCleanup(self.umount_share, ssh_client, snapshot_dir)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        # 11 - List files on SS1, only \"file1\" exists"},{"line_number":551,"context_line":"        # NOTE(lseki): using ls without recursion to avoid permission denied"},{"line_number":552,"context_line":"        #              error while listing lost+found directory on LVM volumes"},{"line_number":553,"context_line":"        output \u003d ssh_client.exec_command(\"sudo ls -lA %s\" % snapshot_dir)"},{"line_number":554,"context_line":"        self.assertIn(\u0027file1\u0027, output)"},{"line_number":555,"context_line":"        self.assertNotIn(\u0027file2\u0027, output)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_50d0e9c9","line":552,"range":{"start_line":551,"start_character":8,"end_line":552,"end_character":78},"updated":"2017-01-25 11:59:52.000000000","message":"This comment sounds redundant because \"sudo\" is used in command below anyway.","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ca37a7c8e53452fe69ae7ff7f24c911278001b72","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.addCleanup(self.umount_share, ssh_client, snapshot_dir)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        # 11 - List files on SS1, only \"file1\" exists"},{"line_number":551,"context_line":"        # NOTE(lseki): using ls without recursion to avoid permission denied"},{"line_number":552,"context_line":"        #              error while listing lost+found directory on LVM volumes"},{"line_number":553,"context_line":"        output \u003d ssh_client.exec_command(\"sudo ls -lA %s\" % snapshot_dir)"},{"line_number":554,"context_line":"        self.assertIn(\u0027file1\u0027, output)"},{"line_number":555,"context_line":"        self.assertNotIn(\u0027file2\u0027, output)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_d39ea362","line":552,"range":{"start_line":551,"start_character":8,"end_line":552,"end_character":78},"in_reply_to":"5a3905b3_50d0e9c9","updated":"2017-01-25 12:41:49.000000000","message":"but it is true, even with sudo we get permission denied on lost+found folder on LVM, it is a known problem","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7f65c98f4c9c2c9fc4d1152716033a54bb7fbfa8","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        output \u003d ssh_client.exec_command(\"sudo ls -lA %s\" % snapshot_dir)"},{"line_number":554,"context_line":"        self.assertIn(\u0027file1\u0027, output)"},{"line_number":555,"context_line":"        self.assertNotIn(\u0027file2\u0027, output)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"class TestShareBasicOpsNFS(ShareBasicOpsBase):"},{"line_number":559,"context_line":"    protocol \u003d \"nfs\""}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_f0ee35b3","line":556,"updated":"2017-01-25 11:57:49.000000000","message":"Also, need to try write something, to verify we cannot do it.","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ca37a7c8e53452fe69ae7ff7f24c911278001b72","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        output \u003d ssh_client.exec_command(\"sudo ls -lA %s\" % snapshot_dir)"},{"line_number":554,"context_line":"        self.assertIn(\u0027file1\u0027, output)"},{"line_number":555,"context_line":"        self.assertNotIn(\u0027file2\u0027, output)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"class TestShareBasicOpsNFS(ShareBasicOpsBase):"},{"line_number":559,"context_line":"    protocol \u003d \"nfs\""}],"source_content_type":"text/x-python","patch_set":21,"id":"5a3905b3_ae4a8a25","line":556,"in_reply_to":"5a3905b3_f0ee35b3","updated":"2017-01-25 12:41:49.000000000","message":"Done","commit_id":"8aabad3ef04cc4df39793d77f40812d9523228ba"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bfda7f896cba7936a84595bf1585806a974e0d27","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        self.assertNotIn(\u0027file2\u0027, output)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        # 12 - Try to create a file on SS1, should fail"},{"line_number":560,"context_line":"        read_only \u003d False"},{"line_number":561,"context_line":"        try:"},{"line_number":562,"context_line":"            ssh_client.exec_command(\"sudo touch %s/file3\" % snapshot_dir)"},{"line_number":563,"context_line":"        except Exception:"},{"line_number":564,"context_line":"            read_only \u003d True"},{"line_number":565,"context_line":"        self.assertTrue(read_only)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"class TestShareBasicOpsNFS(ShareBasicOpsBase):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a461143_4c031fb9","line":565,"range":{"start_line":560,"start_character":8,"end_line":565,"end_character":34},"updated":"2017-01-25 12:56:48.000000000","message":"self.assertRaises(\n    exceptions.SSHExecCommandFailed,\n    ssh_client.exec_command,\n    \"sudo touch %s/file3\" % snapshot_dir,\n)","commit_id":"e47928ff9e3dfb4c496fbb8c2d457231fb8a5f81"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cdbdd67c214444f57ee4bda6ab7777c8cecaf76b","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        self.assertNotIn(\u0027file2\u0027, output)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        # 12 - Try to create a file on SS1, should fail"},{"line_number":560,"context_line":"        read_only \u003d False"},{"line_number":561,"context_line":"        try:"},{"line_number":562,"context_line":"            ssh_client.exec_command(\"sudo touch %s/file3\" % snapshot_dir)"},{"line_number":563,"context_line":"        except Exception:"},{"line_number":564,"context_line":"            read_only \u003d True"},{"line_number":565,"context_line":"        self.assertTrue(read_only)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"class TestShareBasicOpsNFS(ShareBasicOpsBase):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a461143_5bbe6f00","line":565,"range":{"start_line":560,"start_character":8,"end_line":565,"end_character":34},"in_reply_to":"3a461143_4c031fb9","updated":"2017-01-25 14:38:07.000000000","message":"Done","commit_id":"e47928ff9e3dfb4c496fbb8c2d457231fb8a5f81"}]}
