)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb37f739f4a6c1e8b93660faabab0784cffea2de","unresolved":false,"context_lines":[{"line_number":12,"context_line":"functionality on migrated share."},{"line_number":13,"context_line":"- Added tests to cover the preserve snapshot"},{"line_number":14,"context_line":"functionality on migrated share."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: bp ocata-migration-improvements"},{"line_number":17,"context_line":"Change-Id: Ia7c7eb7b48b464aa670073e8c0795369bd972678"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1a430d35_e117444f","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"updated":"2017-02-04 00:51:05.000000000","message":"Please note the change to the dummy driver\u0027s migration_continue method here..","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"57cb1a0fae47bd9c96bb5cb8bafb583d560405d2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"functionality on migrated share."},{"line_number":13,"context_line":"- Added tests to cover the preserve snapshot"},{"line_number":14,"context_line":"functionality on migrated share."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-Implements: bp ocata-migration-improvements"},{"line_number":17,"context_line":"Change-Id: Ia7c7eb7b48b464aa670073e8c0795369bd972678"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1a430d35_35ab421f","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"1a430d35_e117444f","updated":"2017-02-04 04:28:46.000000000","message":"Done","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe2bd1d43fe4044b9365015cfe2972fb706f6c19","unresolved":false,"context_lines":[{"line_number":12,"context_line":"functionality on migrated share."},{"line_number":13,"context_line":"- Added tests to cover the preserve snapshot"},{"line_number":14,"context_line":"functionality on migrated share."},{"line_number":15,"context_line":"- Current waiter logic in migration_progress"},{"line_number":16,"context_line":"method of dummy driver causes every migration"},{"line_number":17,"context_line":"test to take over 4 minutes to complete."},{"line_number":18,"context_line":"Therefore, updated the method to cut the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"1a430d35_d572fee4","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":44},"updated":"2017-02-04 04:29:53.000000000","message":"nit: continue","commit_id":"301abe6257718765dbd2ddc9e1f2bd3509880823"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"86a46eda6f73f106619a561b26bd911b623e9bbb","unresolved":false,"context_lines":[{"line_number":77,"context_line":"RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS\u003d${RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS:-False}"},{"line_number":78,"context_line":"RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS\u003d${RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS:-False}"},{"line_number":79,"context_line":"RUN_MANILA_MOUNT_SNAPSHOT_TESTS\u003d${RUN_MANILA_MOUNT_SNAPSHOT_TESTS:-False}"},{"line_number":80,"context_line":"RUN_MANILA_MIGRATION_TESTS_WITH_PRESERVE_SNAPSHOTS\u003d${RUN_MANILA_MIGRATION_TESTS_WITH_PRESERVE_SNAPSHOTS:-False}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"MANILA_CONF\u003d${MANILA_CONF:-/etc/manila/manila.conf}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3a461143_6513770e","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":50},"updated":"2017-02-01 22:41:20.000000000","message":"To preserve the MANILA_.*_TESTS pattern. How about RUN_MANILA_MIGRATION_WITH_PRESERVE_SNAPSHOTS_TESTS?  O something similar but shorter.","commit_id":"9e220824406cbbbec553ad3a84d33432b97e0bf6"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"1f6bb781e5a250c1aeac4d8745d4a7db577823cd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS\u003d${RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS:-False}"},{"line_number":78,"context_line":"RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS\u003d${RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS:-False}"},{"line_number":79,"context_line":"RUN_MANILA_MOUNT_SNAPSHOT_TESTS\u003d${RUN_MANILA_MOUNT_SNAPSHOT_TESTS:-False}"},{"line_number":80,"context_line":"RUN_MANILA_MIGRATION_TESTS_WITH_PRESERVE_SNAPSHOTS\u003d${RUN_MANILA_MIGRATION_TESTS_WITH_PRESERVE_SNAPSHOTS:-False}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"MANILA_CONF\u003d${MANILA_CONF:-/etc/manila/manila.conf}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3a461143_07e8d07b","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":50},"in_reply_to":"3a461143_6513770e","updated":"2017-02-02 19:41:53.000000000","message":"Done","commit_id":"9e220824406cbbbec553ad3a84d33432b97e0bf6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"86a46eda6f73f106619a561b26bd911b623e9bbb","unresolved":false,"context_lines":[{"line_number":271,"context_line":"# Enable migration tests"},{"line_number":272,"context_line":"iniset $TEMPEST_CONFIG share run_host_assisted_migration_tests $RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS"},{"line_number":273,"context_line":"iniset $TEMPEST_CONFIG share run_driver_assisted_migration_tests $RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS"},{"line_number":274,"context_line":"iniset $TEMPEST_CONFIG share run_migration_tests_with_preserve_snapshots $RUN_MANILA_MIGRATION_TESTS_WITH_PRESERVE_SNAPSHOTS"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Enable mountable snapshots tests"},{"line_number":277,"context_line":"iniset $TEMPEST_CONFIG share run_mount_snapshot_tests $RUN_MANILA_MOUNT_SNAPSHOT_TESTS"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3a461143_652a972e","line":274,"range":{"start_line":274,"start_character":43,"end_line":274,"end_character":48},"updated":"2017-02-01 22:41:20.000000000","message":"same here","commit_id":"9e220824406cbbbec553ad3a84d33432b97e0bf6"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"1f6bb781e5a250c1aeac4d8745d4a7db577823cd","unresolved":false,"context_lines":[{"line_number":271,"context_line":"# Enable migration tests"},{"line_number":272,"context_line":"iniset $TEMPEST_CONFIG share run_host_assisted_migration_tests $RUN_MANILA_HOST_ASSISTED_MIGRATION_TESTS"},{"line_number":273,"context_line":"iniset $TEMPEST_CONFIG share run_driver_assisted_migration_tests $RUN_MANILA_DRIVER_ASSISTED_MIGRATION_TESTS"},{"line_number":274,"context_line":"iniset $TEMPEST_CONFIG share run_migration_tests_with_preserve_snapshots $RUN_MANILA_MIGRATION_TESTS_WITH_PRESERVE_SNAPSHOTS"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Enable mountable snapshots tests"},{"line_number":277,"context_line":"iniset $TEMPEST_CONFIG share run_mount_snapshot_tests $RUN_MANILA_MOUNT_SNAPSHOT_TESTS"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3a461143_4702d83f","line":274,"range":{"start_line":274,"start_character":43,"end_line":274,"end_character":48},"in_reply_to":"3a461143_652a972e","updated":"2017-02-02 19:41:53.000000000","message":"Done","commit_id":"9e220824406cbbbec553ad3a84d33432b97e0bf6"}],"manila/share/manager.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"02e23696369e13805696d8c3246388665c1e0b90","unresolved":false,"context_lines":[{"line_number":1216,"context_line":"            self.db.share_snapshot_instance_update("},{"line_number":1217,"context_line":"                context, dest_snap_ins[\u0027id\u0027], model_update)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"            for el in export_locations:"},{"line_number":1220,"context_line":"                values \u003d {"},{"line_number":1221,"context_line":"                    \u0027share_snapshot_instance_id\u0027: dest_snap_ins[\u0027id\u0027],"},{"line_number":1222,"context_line":"                    \u0027path\u0027: el[\u0027path\u0027],"},{"line_number":1223,"context_line":"                    \u0027is_admin_only\u0027: el[\u0027is_admin_only\u0027],"},{"line_number":1224,"context_line":"                }"},{"line_number":1225,"context_line":"                self.db.share_snapshot_instance_export_location_create("},{"line_number":1226,"context_line":"                    context, values)"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        helper \u003d migration.ShareMigrationHelper("},{"line_number":1229,"context_line":"            context, self.db, share_ref, self.access_helper)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_d32a06e7","line":1226,"range":{"start_line":1219,"start_character":7,"end_line":1226,"end_character":36},"updated":"2017-02-02 21:20:15.000000000","message":"this doesn\u0027t look like it belongs in this patch. Is it just a rebase or dependency issue?","commit_id":"d7c8430527e79b440acb7f8513e2da8f3d293446"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f3fc63af685d1172eec0920f493a8f8a3cf35df","unresolved":false,"context_lines":[{"line_number":1216,"context_line":"            self.db.share_snapshot_instance_update("},{"line_number":1217,"context_line":"                context, dest_snap_ins[\u0027id\u0027], model_update)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"            for el in export_locations:"},{"line_number":1220,"context_line":"                values \u003d {"},{"line_number":1221,"context_line":"                    \u0027share_snapshot_instance_id\u0027: dest_snap_ins[\u0027id\u0027],"},{"line_number":1222,"context_line":"                    \u0027path\u0027: el[\u0027path\u0027],"},{"line_number":1223,"context_line":"                    \u0027is_admin_only\u0027: el[\u0027is_admin_only\u0027],"},{"line_number":1224,"context_line":"                }"},{"line_number":1225,"context_line":"                self.db.share_snapshot_instance_export_location_create("},{"line_number":1226,"context_line":"                    context, values)"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        helper \u003d migration.ShareMigrationHelper("},{"line_number":1229,"context_line":"            context, self.db, share_ref, self.access_helper)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_7e6d9998","line":1226,"range":{"start_line":1219,"start_character":7,"end_line":1226,"end_character":36},"in_reply_to":"3a461143_d32a06e7","updated":"2017-02-02 21:40:55.000000000","message":"https://bugs.launchpad.net/manila/+bug/1661381\n\nTesting a fix for this bug ^","commit_id":"d7c8430527e79b440acb7f8513e2da8f3d293446"}],"manila/tests/share/drivers/dummy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb37f739f4a6c1e8b93660faabab0784cffea2de","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        if source_share[\"id\"] not in self.migration_progress:"},{"line_number":549,"context_line":"            self.migration_progress[source_share[\"id\"]] \u003d 0"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        # Note: setting value to \u002725\u0027 cause this loop to go through 4 times,"},{"line_number":552,"context_line":"        # while waiting for 1 minute each iteration. That makes the"},{"line_number":553,"context_line":"        # migration test very slow and takes 4 minutes to complete."},{"line_number":554,"context_line":"        # Therefore, changing this value to \u002750\u0027 to cut the overall time in"},{"line_number":555,"context_line":"        # half and avoid the possible timeout."},{"line_number":556,"context_line":"        self.migration_progress[source_share[\"id\"]] +\u003d 50"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        LOG.debug("}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_81184086","line":555,"range":{"start_line":551,"start_character":0,"end_line":555,"end_character":46},"updated":"2017-02-04 00:51:05.000000000","message":"This note isn\u0027t necessary here. Because once merged, it will lose context..","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"57cb1a0fae47bd9c96bb5cb8bafb583d560405d2","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        if source_share[\"id\"] not in self.migration_progress:"},{"line_number":549,"context_line":"            self.migration_progress[source_share[\"id\"]] \u003d 0"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        # Note: setting value to \u002725\u0027 cause this loop to go through 4 times,"},{"line_number":552,"context_line":"        # while waiting for 1 minute each iteration. That makes the"},{"line_number":553,"context_line":"        # migration test very slow and takes 4 minutes to complete."},{"line_number":554,"context_line":"        # Therefore, changing this value to \u002750\u0027 to cut the overall time in"},{"line_number":555,"context_line":"        # half and avoid the possible timeout."},{"line_number":556,"context_line":"        self.migration_progress[source_share[\"id\"]] +\u003d 50"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        LOG.debug("}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_55a8ce1f","line":555,"range":{"start_line":551,"start_character":0,"end_line":555,"end_character":46},"in_reply_to":"1a430d35_81184086","updated":"2017-02-04 04:28:46.000000000","message":"Done","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                default\u003dFalse,"},{"line_number":195,"context_line":"                help\u003d\"Enable or disable driver-assisted migration tests.\"),"},{"line_number":196,"context_line":"    cfg.BoolOpt(\"run_migration_tests_with_preserve_snapshots\","},{"line_number":197,"context_line":"                deprecated_name\u003d\"run_migration_tests_with_preserve_snapshots\","},{"line_number":198,"context_line":"                default\u003dFalse,"},{"line_number":199,"context_line":"                help\u003d\"Enable or disable migration tests with preserve \""},{"line_number":200,"context_line":"                     \"snapshots.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_572b6deb","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":78},"updated":"2017-01-19 23:24:00.000000000","message":"?\n\nremove.","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                default\u003dFalse,"},{"line_number":195,"context_line":"                help\u003d\"Enable or disable driver-assisted migration tests.\"),"},{"line_number":196,"context_line":"    cfg.BoolOpt(\"run_migration_tests_with_preserve_snapshots\","},{"line_number":197,"context_line":"                deprecated_name\u003d\"run_migration_tests_with_preserve_snapshots\","},{"line_number":198,"context_line":"                default\u003dFalse,"},{"line_number":199,"context_line":"                help\u003d\"Enable or disable migration tests with preserve \""},{"line_number":200,"context_line":"                     \"snapshots.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_4fa72d4f","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":78},"in_reply_to":"5a3905b3_572b6deb","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    cfg.BoolOpt(\"run_migration_tests_with_preserve_snapshots\","},{"line_number":197,"context_line":"                deprecated_name\u003d\"run_migration_tests_with_preserve_snapshots\","},{"line_number":198,"context_line":"                default\u003dFalse,"},{"line_number":199,"context_line":"                help\u003d\"Enable or disable migration tests with preserve \""},{"line_number":200,"context_line":"                     \"snapshots.\"),"},{"line_number":201,"context_line":"    cfg.BoolOpt(\"run_manage_unmanage_tests\","},{"line_number":202,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_d73f5d23","line":199,"range":{"start_line":199,"start_character":61,"end_line":199,"end_character":69},"updated":"2017-01-19 23:24:00.000000000","message":"the \"preserve_snapshots\" parameter set to True","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    cfg.BoolOpt(\"run_migration_tests_with_preserve_snapshots\","},{"line_number":197,"context_line":"                deprecated_name\u003d\"run_migration_tests_with_preserve_snapshots\","},{"line_number":198,"context_line":"                default\u003dFalse,"},{"line_number":199,"context_line":"                help\u003d\"Enable or disable migration tests with preserve \""},{"line_number":200,"context_line":"                     \"snapshots.\"),"},{"line_number":201,"context_line":"    cfg.BoolOpt(\"run_manage_unmanage_tests\","},{"line_number":202,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_6f64e921","line":199,"range":{"start_line":199,"start_character":61,"end_line":199,"end_character":69},"in_reply_to":"5a3905b3_d73f5d23","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"86a46eda6f73f106619a561b26bd911b623e9bbb","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                deprecated_name\u003d\"run_migration_tests\","},{"line_number":193,"context_line":"                default\u003dFalse,"},{"line_number":194,"context_line":"                help\u003d\"Enable or disable driver-assisted migration tests.\"),"},{"line_number":195,"context_line":"    cfg.BoolOpt(\"run_migration_tests_with_preserve_snapshots\","},{"line_number":196,"context_line":"                default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\"Enable or disable migration tests with \""},{"line_number":198,"context_line":"                     \"preserve_snapshots set to True.\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a461143_25d7af24","line":195,"range":{"start_line":195,"start_character":31,"end_line":195,"end_character":36},"updated":"2017-02-01 22:41:20.000000000","message":"same here","commit_id":"9e220824406cbbbec553ad3a84d33432b97e0bf6"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"1f6bb781e5a250c1aeac4d8745d4a7db577823cd","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                deprecated_name\u003d\"run_migration_tests\","},{"line_number":193,"context_line":"                default\u003dFalse,"},{"line_number":194,"context_line":"                help\u003d\"Enable or disable driver-assisted migration tests.\"),"},{"line_number":195,"context_line":"    cfg.BoolOpt(\"run_migration_tests_with_preserve_snapshots\","},{"line_number":196,"context_line":"                default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\"Enable or disable migration tests with \""},{"line_number":198,"context_line":"                     \"preserve_snapshots set to True.\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a461143_87fcc03f","line":195,"range":{"start_line":195,"start_character":31,"end_line":195,"end_character":36},"in_reply_to":"3a461143_25d7af24","updated":"2017-02-02 19:41:53.000000000","message":"Done","commit_id":"9e220824406cbbbec553ad3a84d33432b97e0bf6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7f3d8c9457b96907017d416fe2b9556d7f1ec660","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                help\u003d\"Enable or disable driver-assisted migration tests.\"),"},{"line_number":195,"context_line":"    cfg.BoolOpt(\"run_migration_with_preserve_snapshots_tests\","},{"line_number":196,"context_line":"                default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\"Enable or disable migration with\""},{"line_number":198,"context_line":"                     \"preserve_snapshots tests set to True.\"),"},{"line_number":199,"context_line":"    cfg.BoolOpt(\"run_manage_unmanage_tests\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"Defines whether to run manage/unmanage tests or not. \""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_8df22199","line":198,"range":{"start_line":197,"start_character":22,"end_line":198,"end_character":58},"updated":"2017-02-02 20:39:52.000000000","message":"Remove the \"set to True\" part.  Otherwise the enable/disable and set to true are confusing. Or look for other message to emulate. There are a few different patterns here.","commit_id":"e270d38d539979d8824dfadd05510f8890af8f74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb37f739f4a6c1e8b93660faabab0784cffea2de","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                help\u003d\"Enable or disable driver-assisted migration tests.\"),"},{"line_number":195,"context_line":"    cfg.BoolOpt(\"run_migration_with_preserve_snapshots_tests\","},{"line_number":196,"context_line":"                default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\"Enable or disable migration with\""},{"line_number":198,"context_line":"                     \"preserve_snapshots tests set to True.\"),"},{"line_number":199,"context_line":"    cfg.BoolOpt(\"run_manage_unmanage_tests\","},{"line_number":200,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_010d303e","line":197,"range":{"start_line":197,"start_character":54,"end_line":197,"end_character":55},"updated":"2017-02-04 00:51:05.000000000","message":"missing space","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"57cb1a0fae47bd9c96bb5cb8bafb583d560405d2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                help\u003d\"Enable or disable driver-assisted migration tests.\"),"},{"line_number":195,"context_line":"    cfg.BoolOpt(\"run_migration_with_preserve_snapshots_tests\","},{"line_number":196,"context_line":"                default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\"Enable or disable migration with\""},{"line_number":198,"context_line":"                     \"preserve_snapshots tests set to True.\"),"},{"line_number":199,"context_line":"    cfg.BoolOpt(\"run_manage_unmanage_tests\","},{"line_number":200,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_f53ffa22","line":197,"range":{"start_line":197,"start_character":54,"end_line":197,"end_character":55},"in_reply_to":"1a430d35_010d303e","updated":"2017-02-04 04:28:46.000000000","message":"Done","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"cc324676b1b1e130cbd93b4c4debb57a8216f118","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    cfg.BoolOpt(\"run_migration_with_preserve_snapshots_tests\","},{"line_number":196,"context_line":"                default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\"Enable or disable migration with \""},{"line_number":198,"context_line":"                     \"preserve_snapshots tests set to True.\"),"},{"line_number":199,"context_line":"    cfg.BoolOpt(\"run_manage_unmanage_tests\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"Defines whether to run manage/unmanage tests or not. \""}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_e5d01556","line":198,"range":{"start_line":198,"start_character":47,"end_line":198,"end_character":58},"updated":"2017-02-06 05:30:49.000000000","message":"please delete the \"set to True\" part of this. It doesn\u0027t make sense when used with \"Enable or disable\".","commit_id":"301abe6257718765dbd2ddc9e1f2bd3509880823"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c196a4463eab27d93771795f6f426b5ae413820","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    cfg.BoolOpt(\"run_migration_with_preserve_snapshots_tests\","},{"line_number":196,"context_line":"                default\u003dFalse,"},{"line_number":197,"context_line":"                help\u003d\"Enable or disable migration with \""},{"line_number":198,"context_line":"                     \"preserve_snapshots tests set to True.\"),"},{"line_number":199,"context_line":"    cfg.BoolOpt(\"run_manage_unmanage_tests\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"Defines whether to run manage/unmanage tests or not. \""}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_a7e8beb5","line":198,"range":{"start_line":198,"start_character":47,"end_line":198,"end_character":58},"in_reply_to":"1a430d35_e5d01556","updated":"2017-02-06 14:06:21.000000000","message":"\"set to True\" seems correct here, however the language is kinda confusing.. \n\n\"Enable or disable migration tests with preserve_snapshots\n  parameter set to True.\"\n\nor\n\n\"Defines whether to run migration tests that test for snapshots\n to be preserved. Use this in conjunction with the\n run_driver_assisted_migration_tests if used driver supports\n migrating shares that have snapshots.\"","commit_id":"301abe6257718765dbd2ddc9e1f2bd3509880823"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    def list_snapshots_for_share(self, share_id, detailed\u003dFalse,"},{"line_number":484,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":485,"context_line":"        \"\"\"Get list of snapshots for given share.\"\"\""},{"line_number":486,"context_line":"        uri \u003d \u0027snapshots/detail?share_id\u003d%s\u0027 % share_id if detailed else \\"},{"line_number":487,"context_line":"            \u0027snapshots?share_id\u003d%s\u0027 % share_id"},{"line_number":488,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":489,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":490,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_48bc60dc","line":487,"range":{"start_line":486,"start_character":8,"end_line":487,"end_character":46},"updated":"2017-01-16 23:09:20.000000000","message":"uri \u003d (\u0027snapshots/detail?share_id\u003d%s\u0027 % share_id\n       if detailed\n       else \u0027snapshots?share_id\u003d%s\u0027 % share_id)","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    def list_snapshots_for_share(self, share_id, detailed\u003dFalse,"},{"line_number":484,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":485,"context_line":"        \"\"\"Get list of snapshots for given share.\"\"\""},{"line_number":486,"context_line":"        uri \u003d \u0027snapshots/detail?share_id\u003d%s\u0027 % share_id \\"},{"line_number":487,"context_line":"            if detailed \\"},{"line_number":488,"context_line":"            else \u0027snapshots?share_id\u003d%s\u0027 % share_id"},{"line_number":489,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":490,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":491,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_57128db5","line":488,"range":{"start_line":486,"start_character":14,"end_line":488,"end_character":51},"updated":"2017-01-19 23:24:00.000000000","message":"use ()","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    def list_snapshots_for_share(self, share_id, detailed\u003dFalse,"},{"line_number":484,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":485,"context_line":"        \"\"\"Get list of snapshots for given share.\"\"\""},{"line_number":486,"context_line":"        uri \u003d \u0027snapshots/detail?share_id\u003d%s\u0027 % share_id \\"},{"line_number":487,"context_line":"            if detailed \\"},{"line_number":488,"context_line":"            else \u0027snapshots?share_id\u003d%s\u0027 % share_id"},{"line_number":489,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":490,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":491,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_ef78d9c6","line":488,"range":{"start_line":486,"start_character":14,"end_line":488,"end_character":51},"in_reply_to":"5a3905b3_57128db5","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    def list_snapshots_for_share(self, share_id, detailed\u003dFalse,"},{"line_number":484,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":485,"context_line":"        \"\"\"Get list of snapshots for given share.\"\"\""},{"line_number":486,"context_line":"        uri \u003d \u0027snapshots/detail?share_id\u003d%s\u0027 % share_id \\"},{"line_number":487,"context_line":"            if detailed \\"},{"line_number":488,"context_line":"            else \u0027snapshots?share_id\u003d%s\u0027 % share_id"},{"line_number":489,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":490,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":491,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_0821a94d","line":488,"range":{"start_line":486,"start_character":8,"end_line":488,"end_character":51},"updated":"2017-01-20 10:50:31.000000000","message":"see Goutham\u0027s previous comment, do not use backlashes","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    def list_snapshots_for_share(self, share_id, detailed\u003dFalse,"},{"line_number":484,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":485,"context_line":"        \"\"\"Get list of snapshots for given share.\"\"\""},{"line_number":486,"context_line":"        uri \u003d \u0027snapshots/detail?share_id\u003d%s\u0027 % share_id \\"},{"line_number":487,"context_line":"            if detailed \\"},{"line_number":488,"context_line":"            else \u0027snapshots?share_id\u003d%s\u0027 % share_id"},{"line_number":489,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":490,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":491,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_b2363a50","line":488,"range":{"start_line":486,"start_character":8,"end_line":488,"end_character":51},"in_reply_to":"5a3905b3_0821a94d","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"25683ae285483aa2cf1e5a1e99cc35ccb764d506","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":494,"context_line":"        return self._parse_resp(body)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def list_snapshots_for_share(self, share_id, detailed\u003dFalse,"},{"line_number":497,"context_line":"                                 version\u003dLATEST_MICROVERSION):"},{"line_number":498,"context_line":"        \"\"\"Get list of snapshots for given share.\"\"\""},{"line_number":499,"context_line":"        uri \u003d (\u0027snapshots/detail?share_id\u003d%s\u0027 % share_id"},{"line_number":500,"context_line":"               if detailed else \u0027snapshots?share_id\u003d%s\u0027 % share_id)"},{"line_number":501,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":502,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":503,"context_line":"        return self._parse_resp(body)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def list_snapshots_with_detail(self, params\u003dNone,"},{"line_number":506,"context_line":"                                   version\u003dLATEST_MICROVERSION):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_44746bfc","line":503,"range":{"start_line":496,"start_character":3,"end_line":503,"end_character":37},"updated":"2017-02-06 17:43:10.000000000","message":"It is redundant. You should have used above one providing \"params\" argument.","commit_id":"301abe6257718765dbd2ddc9e1f2bd3509880823"}],"manila_tempest_tests/tests/api/admin/test_migration.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6d33871edd58e63acfbb6b5b3e925ea3f369d19d","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            share_type_id\u003dnew_share_type_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":229,"context_line":"    @base.skip_if_microversion_lt(\"2.22\")"},{"line_number":230,"context_line":"    @testtools.skipUnless(CONF.share.run_extend_tests,"},{"line_number":231,"context_line":"                          \u0027Extend share tests are disabled.\u0027)"},{"line_number":232,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_d0d80682","line":229,"range":{"start_line":229,"start_character":37,"end_line":229,"end_character":39},"updated":"2017-01-11 11:54:09.000000000","message":"this has to be bumped to 2.26 because of migration-start supports only 2.26 and above","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6d33871edd58e63acfbb6b5b3e925ea3f369d19d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027extend\u0027)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":237,"context_line":"    @base.skip_if_microversion_lt(\"2.22\")"},{"line_number":238,"context_line":"    @testtools.skipUnless(CONF.share.run_shrink_tests,"},{"line_number":239,"context_line":"                          \u0027Shrink share tests are disabled.\u0027)"},{"line_number":240,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_50d3365f","line":237,"range":{"start_line":237,"start_character":37,"end_line":237,"end_character":39},"updated":"2017-01-11 11:54:09.000000000","message":"same","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6d33871edd58e63acfbb6b5b3e925ea3f369d19d","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            new_share_network_id\u003dnew_share_network_id)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        share \u003d self.migration_complete(share[\u0027id\u0027], dest_pool)"},{"line_number":401,"context_line":"        if resize \u003d\u003d \u0027extend\u0027:"},{"line_number":402,"context_line":"            new_size \u003d CONF.share.share_size + 2"},{"line_number":403,"context_line":"            self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":404,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":405,"context_line":"                share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":406,"context_line":"            share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":407,"context_line":"            self.assertEqual(new_size, int(share[\"size\"]))"},{"line_number":408,"context_line":"        else:"},{"line_number":409,"context_line":"            new_size \u003d CONF.share.share_size"},{"line_number":410,"context_line":"            self.shares_v2_client.shrink_share(share[\u0027id\u0027], new_size)"},{"line_number":411,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":412,"context_line":"                share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":413,"context_line":"            share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":414,"context_line":"            self.assertEqual(new_size, int(share[\"size\"]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_f0550ac6","line":414,"range":{"start_line":401,"start_character":8,"end_line":414,"end_character":58},"updated":"2017-01-11 11:54:09.000000000","message":"teardown is failing, I believe you should delete the share after this check succeeds.","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ba46a45543224e09f281ddebafb1c011976bcc52","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            new_share_network_id\u003dnew_share_network_id)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        share \u003d self.migration_complete(share[\u0027id\u0027], dest_pool)"},{"line_number":401,"context_line":"        if resize \u003d\u003d \u0027extend\u0027:"},{"line_number":402,"context_line":"            new_size \u003d CONF.share.share_size + 2"},{"line_number":403,"context_line":"            self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":404,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":405,"context_line":"                share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":406,"context_line":"            share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":407,"context_line":"            self.assertEqual(new_size, int(share[\"size\"]))"},{"line_number":408,"context_line":"        else:"},{"line_number":409,"context_line":"            new_size \u003d CONF.share.share_size"},{"line_number":410,"context_line":"            self.shares_v2_client.shrink_share(share[\u0027id\u0027], new_size)"},{"line_number":411,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":412,"context_line":"                share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":413,"context_line":"            share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":414,"context_line":"            self.assertEqual(new_size, int(share[\"size\"]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_93514211","line":414,"range":{"start_line":401,"start_character":8,"end_line":414,"end_character":58},"in_reply_to":"7a3c09a3_48bbdcc4","updated":"2017-01-16 10:29:15.000000000","message":"make sure \"suppress_errors_in_cleanup\" is disabled in your tempest.conf","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"bd0244104d20c5e02df7055046aff6bb7b5cd962","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            new_share_network_id\u003dnew_share_network_id)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        share \u003d self.migration_complete(share[\u0027id\u0027], dest_pool)"},{"line_number":401,"context_line":"        if resize \u003d\u003d \u0027extend\u0027:"},{"line_number":402,"context_line":"            new_size \u003d CONF.share.share_size + 2"},{"line_number":403,"context_line":"            self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":404,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":405,"context_line":"                share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":406,"context_line":"            share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":407,"context_line":"            self.assertEqual(new_size, int(share[\"size\"]))"},{"line_number":408,"context_line":"        else:"},{"line_number":409,"context_line":"            new_size \u003d CONF.share.share_size"},{"line_number":410,"context_line":"            self.shares_v2_client.shrink_share(share[\u0027id\u0027], new_size)"},{"line_number":411,"context_line":"            self.shares_v2_client.wait_for_share_status("},{"line_number":412,"context_line":"                share[\u0027id\u0027], constants.STATUS_AVAILABLE)"},{"line_number":413,"context_line":"            share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":414,"context_line":"            self.assertEqual(new_size, int(share[\"size\"]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_48bbdcc4","line":414,"range":{"start_line":401,"start_character":8,"end_line":414,"end_character":58},"in_reply_to":"ba5201f7_f0550ac6","updated":"2017-01-13 16:50:54.000000000","message":"Don\u0027t see any reason why teardown should fail. It\u0027s not failing locally. I will wait to see what happens with the next patch, if it fail again then I will add the share cleanup logic.","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        old_share_network_id \u003d share[\u0027share_network_id\u0027]"},{"line_number":126,"context_line":"        old_share_type_id \u003d share[\u0027share_type\u0027]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        task_state, new_share_network_id, new_share_type_id \u003d \\"},{"line_number":129,"context_line":"            self._set_migration_data(force_host_assisted, share,"},{"line_number":130,"context_line":"                                     opposite_type\u003dTrue)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        share \u003d self.migrate_share("},{"line_number":133,"context_line":"            share[\u0027id\u0027], dest_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_089ed862","line":130,"range":{"start_line":128,"start_character":62,"end_line":130,"end_character":56},"updated":"2017-01-16 23:09:20.000000000","message":"avoid \\, use ()","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        old_share_network_id \u003d share[\u0027share_network_id\u0027]"},{"line_number":171,"context_line":"        old_share_type_id \u003d share[\u0027share_type\u0027]"},{"line_number":172,"context_line":"        task_state, new_share_network_id, new_share_type_id \u003d \\"},{"line_number":173,"context_line":"            self._set_migration_data(force_host_assisted, share)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        share \u003d self.migrate_share("},{"line_number":176,"context_line":"            share[\u0027id\u0027], dest_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_e8242cc6","line":173,"range":{"start_line":172,"start_character":0,"end_line":173,"end_character":64},"updated":"2017-01-16 23:09:20.000000000","message":"same","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            share_type_id\u003dnew_share_type_id)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":205,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":206,"context_line":"    @testtools.skipUnless(CONF.share.run_extend_tests,"},{"line_number":207,"context_line":"                          \u0027Extend share tests are disabled.\u0027)"},{"line_number":208,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_681f5c6c","line":205,"range":{"start_line":205,"start_character":35,"end_line":205,"end_character":39},"updated":"2017-01-16 23:09:20.000000000","message":"microversion has changed","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027extend\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":213,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":214,"context_line":"    @testtools.skipUnless(CONF.share.run_shrink_tests,"},{"line_number":215,"context_line":"                          \u0027Shrink share tests are disabled.\u0027)"},{"line_number":216,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_a815c449","line":213,"range":{"start_line":213,"start_character":0,"end_line":213,"end_character":41},"updated":"2017-01-16 23:09:20.000000000","message":"same","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027shrink\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":221,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":222,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":223,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":224,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_c80e903a","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":41},"updated":"2017-01-16 23:09:20.000000000","message":"same","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70dffdb8e410178a9de0e3d8dff06e760c9ccb60","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":223,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":224,"context_line":"    @ddt.data(True, False)"},{"line_number":225,"context_line":"    def test_migrating_share_with_snapshot(self, force_host_assisted):"},{"line_number":226,"context_line":"        self._check_migration_enabled(force_host_assisted)"},{"line_number":227,"context_line":"        share, dest_pool \u003d self._setup_migration()"},{"line_number":228,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_93c3b756","line":225,"range":{"start_line":225,"start_character":49,"end_line":225,"end_character":68},"updated":"2017-01-17 15:39:41.000000000","message":"there is no force_host_assisted possibility, only driver-assisted. So if driver-assisted configuration option is not enabled, test should be skipped","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":229,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        task_state, new_share_network_id, new_share_type_id \u003d \\"},{"line_number":232,"context_line":"            self._set_migration_data(force_host_assisted, share)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        share \u003d self.migrate_share("},{"line_number":235,"context_line":"            share[\u0027id\u0027], dest_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_2802b40b","line":232,"range":{"start_line":231,"start_character":8,"end_line":232,"end_character":64},"updated":"2017-01-16 23:09:20.000000000","message":"use () instead","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70dffdb8e410178a9de0e3d8dff06e760c9ccb60","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            share[\u0027id\u0027], dest_pool,"},{"line_number":236,"context_line":"            force_host_assisted_migration\u003dforce_host_assisted,"},{"line_number":237,"context_line":"            wait_for_status\u003dtask_state, new_share_type_id\u003dnew_share_type_id,"},{"line_number":238,"context_line":"            new_share_network_id\u003dnew_share_network_id, preserve_snapshots\u003dTrue)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        share \u003d self.migration_complete(share[\u0027id\u0027], dest_pool)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_b396f3ed","line":238,"range":{"start_line":238,"start_character":55,"end_line":238,"end_character":78},"updated":"2017-01-17 15:39:41.000000000","message":"also, would need to define a new config option for this, as other drivers could implement driver-assisted migration without being capable of preserving snapshots (as is the case with ZFSonLinux right now). This test, as currently is, will run on those drivers and fail.","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":245,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":246,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":247,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":248,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_bb151041","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":41},"updated":"2017-01-16 23:09:20.000000000","message":"same","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":253,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        task_state, new_share_network_id, new_share_type_id \u003d \\"},{"line_number":256,"context_line":"            self._set_migration_data(force_host_assisted, share)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        share \u003d self.migrate_share("},{"line_number":259,"context_line":"            share[\u0027id\u0027], dest_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_5b2d0c94","line":256,"range":{"start_line":255,"start_character":0,"end_line":256,"end_character":64},"updated":"2017-01-16 23:09:20.000000000","message":"use ()","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        self._check_migration_enabled(force_host_assisted)"},{"line_number":401,"context_line":"        share, dest_pool \u003d self._setup_migration()"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        task_state, new_share_network_id, new_share_type_id \u003d \\"},{"line_number":404,"context_line":"            self._set_migration_data(force_host_assisted, share)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        share \u003d self.migrate_share("},{"line_number":407,"context_line":"            share[\u0027id\u0027], dest_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_9b23f4a6","line":404,"range":{"start_line":403,"start_character":0,"end_line":404,"end_character":64},"updated":"2017-01-16 23:09:20.000000000","message":"use ()","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70dffdb8e410178a9de0e3d8dff06e760c9ccb60","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            share \u003d self.shares_v2_client.get_share(share[\"id\"])"},{"line_number":426,"context_line":"            self.assertEqual(new_size, int(share[\"size\"]))"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def _set_migration_data(self, force_host_assisted, share,"},{"line_number":429,"context_line":"                            opposite_type\u003dFalse):"},{"line_number":430,"context_line":"        task_state \u003d (constants.TASK_STATE_DATA_COPYING_COMPLETED"},{"line_number":431,"context_line":"                      if force_host_assisted"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_d331bf5b","line":428,"range":{"start_line":428,"start_character":8,"end_line":428,"end_character":27},"updated":"2017-01-17 15:39:41.000000000","message":"this method name is inappropriate for what this method actually does. One would believe that a parameter that is being passed is being changed within this method. I would change to _get_migration_data, as what it returns is what you are really looking for","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        snapshot_list \u003d self.shares_v2_client.list_snapshots_for_share("},{"line_number":455,"context_line":"            share[\u0027id\u0027])"},{"line_number":456,"context_line":"        snapshot_id_list \u003d [snap[\u0027id\u0027] for snap in snapshot_list]"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        # verify that after migration an original snapshots are retained"},{"line_number":459,"context_line":"        self.assertIn(snapshot1[\u0027id\u0027], snapshot_id_list)"},{"line_number":460,"context_line":"        self.assertIn(snapshot2[\u0027id\u0027], snapshot_id_list)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_fb5318e0","line":457,"range":{"start_line":457,"start_character":0,"end_line":457,"end_character":0},"updated":"2017-01-16 23:09:20.000000000","message":"verify that the list is not empty","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70dffdb8e410178a9de0e3d8dff06e760c9ccb60","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            share[\u0027id\u0027])"},{"line_number":456,"context_line":"        snapshot_id_list \u003d [snap[\u0027id\u0027] for snap in snapshot_list]"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        # verify that after migration an original snapshots are retained"},{"line_number":459,"context_line":"        self.assertIn(snapshot1[\u0027id\u0027], snapshot_id_list)"},{"line_number":460,"context_line":"        self.assertIn(snapshot2[\u0027id\u0027], snapshot_id_list)"},{"line_number":461,"context_line":"        # Verify that a share can be created from a snapshot after migration"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_73756bf8","line":458,"range":{"start_line":458,"start_character":38,"end_line":458,"end_character":72},"updated":"2017-01-17 15:39:41.000000000","message":"is it \"an original snapshot is retained\" or \"original snapshots are retained\"?","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            share_type_id\u003dnew_share_type_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":210,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":211,"context_line":"    @testtools.skipUnless(CONF.share.run_extend_tests,"},{"line_number":212,"context_line":"                          \u0027Extend share tests are disabled.\u0027)"},{"line_number":213,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_371ee1ba","line":210,"range":{"start_line":210,"start_character":35,"end_line":210,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            share_type_id\u003dnew_share_type_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":210,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":211,"context_line":"    @testtools.skipUnless(CONF.share.run_extend_tests,"},{"line_number":212,"context_line":"                          \u0027Extend share tests are disabled.\u0027)"},{"line_number":213,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e0229a00","line":210,"range":{"start_line":210,"start_character":35,"end_line":210,"end_character":39},"in_reply_to":"5a3905b3_371ee1ba","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027extend\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":218,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":219,"context_line":"    @testtools.skipUnless(CONF.share.run_shrink_tests,"},{"line_number":220,"context_line":"                          \u0027Shrink share tests are disabled.\u0027)"},{"line_number":221,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_b78811e9","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027extend\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":218,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":219,"context_line":"    @testtools.skipUnless(CONF.share.run_shrink_tests,"},{"line_number":220,"context_line":"                          \u0027Shrink share tests are disabled.\u0027)"},{"line_number":221,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_00224600","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":39},"in_reply_to":"5a3905b3_b78811e9","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027shrink\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_f76a9919","line":226,"range":{"start_line":226,"start_character":35,"end_line":226,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027shrink\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_407a8ef2","line":226,"range":{"start_line":226,"start_character":35,"end_line":226,"end_character":39},"in_reply_to":"5a3905b3_f76a9919","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"},{"line_number":230,"context_line":"                          \u0027Host-assisted migration tests are disabled.\u0027)"},{"line_number":231,"context_line":"    @testtools.skipUnless("},{"line_number":232,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":233,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_b75f3171","line":230,"range":{"start_line":229,"start_character":0,"end_line":230,"end_character":72},"updated":"2017-01-19 23:24:00.000000000","message":"?\n\nThis shouldn\u0027t be used here.","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"},{"line_number":230,"context_line":"                          \u0027Host-assisted migration tests are disabled.\u0027)"},{"line_number":231,"context_line":"    @testtools.skipUnless("},{"line_number":232,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":233,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_d2f746f3","line":230,"range":{"start_line":229,"start_character":0,"end_line":230,"end_character":72},"in_reply_to":"5a3905b3_b75f3171","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":252,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":253,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":254,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":255,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_174f25be","line":252,"range":{"start_line":252,"start_character":35,"end_line":252,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":252,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":253,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":254,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":255,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_a087b2d5","line":252,"range":{"start_line":252,"start_character":35,"end_line":252,"end_character":39},"in_reply_to":"5a3905b3_174f25be","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":277,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":278,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":279,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":280,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_b7ed718d","line":277,"range":{"start_line":277,"start_character":35,"end_line":277,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":277,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":278,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":279,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":280,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e069ba26","line":277,"range":{"start_line":277,"start_character":35,"end_line":277,"end_character":39},"in_reply_to":"5a3905b3_b7ed718d","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            force_host_assisted, True)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":289,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":290,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":291,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":292,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_d702fd3d","line":289,"range":{"start_line":289,"start_character":35,"end_line":289,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            force_host_assisted, True)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":289,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":290,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":291,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":292,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_007966f6","line":289,"range":{"start_line":289,"start_character":35,"end_line":289,"end_character":39},"in_reply_to":"5a3905b3_d702fd3d","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            share_type_id\u003dnew_share_type_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":210,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":211,"context_line":"    @testtools.skipUnless(CONF.share.run_extend_tests,"},{"line_number":212,"context_line":"                          \u0027Extend share tests are disabled.\u0027)"},{"line_number":213,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_c8e7a1e2","line":210,"range":{"start_line":210,"start_character":37,"end_line":210,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            share_type_id\u003dnew_share_type_id)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":210,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":211,"context_line":"    @testtools.skipUnless(CONF.share.run_extend_tests,"},{"line_number":212,"context_line":"                          \u0027Extend share tests are disabled.\u0027)"},{"line_number":213,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_4089ae25","line":210,"range":{"start_line":210,"start_character":37,"end_line":210,"end_character":39},"in_reply_to":"5a3905b3_c8e7a1e2","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027extend\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":218,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":219,"context_line":"    @testtools.skipUnless(CONF.share.run_shrink_tests,"},{"line_number":220,"context_line":"                          \u0027Shrink share tests are disabled.\u0027)"},{"line_number":221,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_08cb6954","line":218,"range":{"start_line":218,"start_character":37,"end_line":218,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027extend\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":218,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":219,"context_line":"    @testtools.skipUnless(CONF.share.run_shrink_tests,"},{"line_number":220,"context_line":"                          \u0027Shrink share tests are disabled.\u0027)"},{"line_number":221,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_e078da2d","line":218,"range":{"start_line":218,"start_character":37,"end_line":218,"end_character":39},"in_reply_to":"5a3905b3_08cb6954","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027shrink\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_c8996170","line":226,"range":{"start_line":226,"start_character":37,"end_line":226,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self._test_resize_post_migration(force_host_assisted, resize\u003d\u0027shrink\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_2073c24e","line":226,"range":{"start_line":226,"start_character":37,"end_line":226,"end_character":39},"in_reply_to":"5a3905b3_c8996170","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"},{"line_number":230,"context_line":"                          \u0027Host-assisted migration tests are disabled.\u0027)"},{"line_number":231,"context_line":"    @testtools.skipUnless("},{"line_number":232,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":233,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_e8b7fdf2","line":230,"range":{"start_line":229,"start_character":26,"end_line":230,"end_character":72},"updated":"2017-01-20 10:50:31.000000000","message":"this condition should be inverted:\n\n@testtools.skipUnless(not CONF.share.run_host_assisted_migration_tests,\n                          \u0027Host-assisted migration tests are disabled.\u0027","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":227,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":228,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":229,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"},{"line_number":230,"context_line":"                          \u0027Host-assisted migration tests are disabled.\u0027)"},{"line_number":231,"context_line":"    @testtools.skipUnless("},{"line_number":232,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":233,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_80e8f6b5","line":230,"range":{"start_line":229,"start_character":26,"end_line":230,"end_character":72},"in_reply_to":"5a3905b3_e8b7fdf2","updated":"2017-01-20 19:39:04.000000000","message":"Removed the condition.","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    @testtools.skipUnless("},{"line_number":232,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":233,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"},{"line_number":234,"context_line":"    def test_migrating_share_with_snapshot(self):"},{"line_number":235,"context_line":"        share, dest_pool \u003d self._setup_migration()"},{"line_number":236,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":237,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_88a119ac","line":234,"updated":"2017-01-20 10:50:31.000000000","message":"also, driver assisted migration should be enabled for this to run.","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    @testtools.skipUnless("},{"line_number":232,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":233,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"},{"line_number":234,"context_line":"    def test_migrating_share_with_snapshot(self):"},{"line_number":235,"context_line":"        share, dest_pool \u003d self._setup_migration()"},{"line_number":236,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":237,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_bd844bd4","line":234,"in_reply_to":"5a3905b3_88a119ac","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":252,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":253,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":254,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":255,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_2878252b","line":252,"range":{"start_line":252,"start_character":37,"end_line":252,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":252,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":253,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":254,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":255,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_60086a92","line":252,"range":{"start_line":252,"start_character":37,"end_line":252,"end_character":39},"in_reply_to":"5a3905b3_2878252b","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":252,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":253,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":254,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":255,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"},{"line_number":256,"context_line":"                          \u0027Host-assisted migration tests are disabled.\u0027)"},{"line_number":257,"context_line":"    @testtools.skipUnless("},{"line_number":258,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":259,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"},{"line_number":260,"context_line":"    def test_migration_cancel_share_with_snapshot(self):"},{"line_number":261,"context_line":"        share, dest_pool \u003d self._setup_migration()"},{"line_number":262,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":263,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_0896094c","line":260,"range":{"start_line":254,"start_character":5,"end_line":260,"end_character":56},"updated":"2017-01-20 10:50:31.000000000","message":"same as above","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":252,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":253,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":254,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":255,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests,"},{"line_number":256,"context_line":"                          \u0027Host-assisted migration tests are disabled.\u0027)"},{"line_number":257,"context_line":"    @testtools.skipUnless("},{"line_number":258,"context_line":"        CONF.share.run_migration_tests_with_preserve_snapshots,"},{"line_number":259,"context_line":"        \u0027Migration tests with preserve snapshots are disabled.\u0027)"},{"line_number":260,"context_line":"    def test_migration_cancel_share_with_snapshot(self):"},{"line_number":261,"context_line":"        share, dest_pool \u003d self._setup_migration()"},{"line_number":262,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":263,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_1d6abf1a","line":260,"range":{"start_line":254,"start_character":5,"end_line":260,"end_character":56},"in_reply_to":"5a3905b3_0896094c","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":277,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":278,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":279,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":280,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_c8824100","line":277,"range":{"start_line":277,"start_character":37,"end_line":277,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        self._validate_snapshot(share, snapshot1, snapshot2)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":277,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":278,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":279,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":280,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_80ff1666","line":277,"range":{"start_line":277,"start_character":37,"end_line":277,"end_character":39},"in_reply_to":"5a3905b3_c8824100","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            force_host_assisted, True)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":289,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":290,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":291,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":292,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_28f4a585","line":289,"range":{"start_line":289,"start_character":37,"end_line":289,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            force_host_assisted, True)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":289,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":290,"context_line":"    @testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":291,"context_line":"                          \u0027Snapshot tests are disabled.\u0027)"},{"line_number":292,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_a002526d","line":289,"range":{"start_line":289,"start_character":37,"end_line":289,"end_character":39},"in_reply_to":"5a3905b3_28f4a585","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    def _validate_snapshot(self, share, snapshot1, snapshot2):"},{"line_number":481,"context_line":"        snapshot_list \u003d self.shares_v2_client.list_snapshots_for_share("},{"line_number":482,"context_line":"            share[\u0027id\u0027])"},{"line_number":483,"context_line":"        msg \u003d \"Share %s has no snapshot\" % share[\u0027id\u0027]"},{"line_number":484,"context_line":"        # Verify that snapshot list is not empty"},{"line_number":485,"context_line":"        self.assertNotEmpty(snapshot_list, msg)"},{"line_number":486,"context_line":"        snapshot_id_list \u003d [snap[\u0027id\u0027] for snap in snapshot_list]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_0827e912","line":483,"range":{"start_line":483,"start_character":38,"end_line":483,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"period","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    def _validate_snapshot(self, share, snapshot1, snapshot2):"},{"line_number":481,"context_line":"        snapshot_list \u003d self.shares_v2_client.list_snapshots_for_share("},{"line_number":482,"context_line":"            share[\u0027id\u0027])"},{"line_number":483,"context_line":"        msg \u003d \"Share %s has no snapshot\" % share[\u0027id\u0027]"},{"line_number":484,"context_line":"        # Verify that snapshot list is not empty"},{"line_number":485,"context_line":"        self.assertNotEmpty(snapshot_list, msg)"},{"line_number":486,"context_line":"        snapshot_id_list \u003d [snap[\u0027id\u0027] for snap in snapshot_list]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_78003102","line":483,"range":{"start_line":483,"start_character":38,"end_line":483,"end_character":39},"in_reply_to":"5a3905b3_0827e912","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aed14a050a1f4a3d866503f9b109b9e56418976a","unresolved":false,"context_lines":[{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # If currently configured is DHSS\u003dFalse,"},{"line_number":465,"context_line":"        # then we need it for DHSS\u003dTrue"},{"line_number":466,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":467,"context_line":"            new_share_network_id \u003d self._create_secondary_share_network("},{"line_number":468,"context_line":"                old_share_network_id)"},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a3905b3_6a459c15","line":466,"range":{"start_line":466,"start_character":0,"end_line":466,"end_character":43},"updated":"2017-01-21 01:09:13.000000000","message":"if not","commit_id":"7b16877e17089786d2677e8b683ad7accc966732"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1959219afc0ef67574a95075889fac2f5b66e1a4","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    def test_migrating_share_with_snapshot(self):"},{"line_number":259,"context_line":"        ss_type, __ \u003d self._create_share_type_for_snapshot_capability()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        share \u003d self.create_share(self.protocol)"},{"line_number":262,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        share, dest_pool \u003d self._setup_migration(share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_e75cb427","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":48},"updated":"2017-02-04 01:46:49.000000000","message":"don\u0027t you want: cleanup_in_class\u003dFalse?\n\nSo that we cleanup right after this test..","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"57cb1a0fae47bd9c96bb5cb8bafb583d560405d2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    def test_migrating_share_with_snapshot(self):"},{"line_number":259,"context_line":"        ss_type, __ \u003d self._create_share_type_for_snapshot_capability()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        share \u003d self.create_share(self.protocol)"},{"line_number":262,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        share, dest_pool \u003d self._setup_migration(share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_5547eeba","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":48},"in_reply_to":"1a430d35_e75cb427","updated":"2017-02-04 04:28:46.000000000","message":"Done","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1959219afc0ef67574a95075889fac2f5b66e1a4","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        share, dest_pool \u003d self._setup_migration(share)"},{"line_number":265,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":266,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        task_state, new_share_network_id, __ \u003d self._get_migration_data(share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_27387cd3","line":265,"range":{"start_line":265,"start_character":25,"end_line":265,"end_character":56},"updated":"2017-02-04 01:46:49.000000000","message":"cleanup_in_class\u003dFalse","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"57cb1a0fae47bd9c96bb5cb8bafb583d560405d2","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        share \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        share, dest_pool \u003d self._setup_migration(share)"},{"line_number":265,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":266,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        task_state, new_share_network_id, __ \u003d self._get_migration_data(share)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_b50c9295","line":265,"range":{"start_line":265,"start_character":25,"end_line":265,"end_character":56},"in_reply_to":"1a430d35_27387cd3","updated":"2017-02-04 04:28:46.000000000","message":"Done","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1959219afc0ef67574a95075889fac2f5b66e1a4","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        share, dest_pool \u003d self._setup_migration(share)"},{"line_number":265,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":266,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        task_state, new_share_network_id, __ \u003d self._get_migration_data(share)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_473588d8","line":266,"range":{"start_line":266,"start_character":25,"end_line":266,"end_character":56},"updated":"2017-02-04 01:46:49.000000000","message":"cleanup_in_class\u003dFalse","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"57cb1a0fae47bd9c96bb5cb8bafb583d560405d2","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        share, dest_pool \u003d self._setup_migration(share)"},{"line_number":265,"context_line":"        snapshot1 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":266,"context_line":"        snapshot2 \u003d self.create_snapshot_wait_for_active(share[\u0027id\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        task_state, new_share_network_id, __ \u003d self._get_migration_data(share)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_d5111eae","line":266,"range":{"start_line":266,"start_character":25,"end_line":266,"end_character":56},"in_reply_to":"1a430d35_473588d8","updated":"2017-02-04 04:28:46.000000000","message":"Done","commit_id":"be2d91c8fb03c3a26f63ca7d1d9993b9bcf9c46e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6b0bca76ef9d27ce89a0cda8360b211ab6dc7dc8","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        new_share_type_id \u003d self.new_type[\u0027share_type\u0027][\u0027id\u0027]"},{"line_number":503,"context_line":"        return task_state, new_share_network_id, new_share_type_id"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    def _validate_snapshot(self, share, snapshot1, snapshot2):"},{"line_number":506,"context_line":"        snapshot_list \u003d self.shares_v2_client.list_snapshots_for_share("},{"line_number":507,"context_line":"            share[\u0027id\u0027])"},{"line_number":508,"context_line":"        msg \u003d \"Share %s has no snapshot.\" % share[\u0027id\u0027]"},{"line_number":509,"context_line":"        # Verify that snapshot list is not empty"},{"line_number":510,"context_line":"        self.assertNotEmpty(snapshot_list, msg)"},{"line_number":511,"context_line":"        snapshot_id_list \u003d [snap[\u0027id\u0027] for snap in snapshot_list]"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        # verify that after migration original snapshots are retained"},{"line_number":514,"context_line":"        self.assertIn(snapshot1[\u0027id\u0027], snapshot_id_list)"},{"line_number":515,"context_line":"        self.assertIn(snapshot2[\u0027id\u0027], snapshot_id_list)"},{"line_number":516,"context_line":"        # Verify that a share can be created from a snapshot after migration"},{"line_number":517,"context_line":"        snapshot1_share \u003d self.create_share("},{"line_number":518,"context_line":"            self.protocol, size\u003dshare[\u0027size\u0027], snapshot_id\u003dsnapshot1[\u0027id\u0027],"},{"line_number":519,"context_line":"            share_network_id\u003dshare[\u0027share_network_id\u0027])"},{"line_number":520,"context_line":"        self.assertEqual(snapshot1[\u0027id\u0027], snapshot1_share[\u0027snapshot_id\u0027])"},{"line_number":521,"context_line":"        self._cleanup_share(share)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    def _validate_share_migration_with_different_snapshot_capability_type("},{"line_number":524,"context_line":"            self, force_host_assisted, snapshot_capable):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_84dd8a16","line":521,"range":{"start_line":505,"start_character":3,"end_line":521,"end_character":34},"updated":"2017-02-06 10:16:39.000000000","message":"Ideally, this method should have a parameter cancel\u003dFalse, validate whether the snapshot instance IDs are different if cancel\u003dFalse, and the same if cancel\u003dTrue. Either the snapshot instance ID or any other property that determines source/destination needs to be checked, such as provider location, but I am aware not all drivers fill that field, although fortunately we have very few drivers that support driver-assisted migration with snapshots, so this should be doable.","commit_id":"301abe6257718765dbd2ddc9e1f2bd3509880823"}],"manila_tempest_tests/tests/api/admin/test_migration_negative.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6d33871edd58e63acfbb6b5b3e925ea3f369d19d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    @testtools.skipUnless(CONF.share.run_driver_assisted_migration_tests,"},{"line_number":243,"context_line":"                          \"Driver-assisted migration tests are disabled.\")"},{"line_number":244,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":245,"context_line":"    @base.skip_if_microversion_lt(\"2.22\")"},{"line_number":246,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":247,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]),"},{"line_number":248,"context_line":"              (\u0027create_snapshot\u0027, []),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b072a27a","line":245,"range":{"start_line":245,"start_character":37,"end_line":245,"end_character":39},"updated":"2017-01-11 11:54:09.000000000","message":"2.26","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6d33871edd58e63acfbb6b5b3e925ea3f369d19d","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":247,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]),"},{"line_number":248,"context_line":"              (\u0027create_snapshot\u0027, []),"},{"line_number":249,"context_line":"              (\u0027create_access_rule\u0027, []))"},{"line_number":250,"context_line":"    @ddt.unpack"},{"line_number":251,"context_line":"    def test_share_actions_during_share_migration(self, method_name, *args):"},{"line_number":252,"context_line":"        self.skip_if_tests_are_disabled(method_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_10d7eeed","line":249,"range":{"start_line":249,"start_character":15,"end_line":249,"end_character":39},"updated":"2017-01-11 11:54:09.000000000","message":"this will change on Goutham\u0027s Access rules refactor patch, so whichever merges first will break the other.","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6d33871edd58e63acfbb6b5b3e925ea3f369d19d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    def test_share_actions_during_share_migration(self, method_name, *args):"},{"line_number":252,"context_line":"        self.skip_if_tests_are_disabled(method_name)"},{"line_number":253,"context_line":"        # Verify various share operations during share migration"},{"line_number":254,"context_line":"        self.migrate_share(self.share[\u0027id\u0027], self.dest_pool,"},{"line_number":255,"context_line":"                           constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE)"},{"line_number":256,"context_line":"        self.assertRaises("},{"line_number":257,"context_line":"            lib_exc.BadRequest, getattr(self.shares_v2_client, method_name),"},{"line_number":258,"context_line":"            self.share[\u0027id\u0027], *args"},{"line_number":259,"context_line":"        )"},{"line_number":260,"context_line":"        # Revert the migration state by cancelling the migration"},{"line_number":261,"context_line":"        self.migration_cancel(self.share[\u0027id\u0027], self.dest_pool)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def skip_if_tests_are_disabled(self, method_name):"},{"line_number":264,"context_line":"        property_to_evaluate \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_308f9224","line":261,"range":{"start_line":254,"start_character":8,"end_line":261,"end_character":63},"updated":"2017-01-11 11:54:09.000000000","message":"this is going to be very stressful for CI, are you sure you cannot optimize it? how about creating this share and migrating it before. You could do it in another class to not hold up the thread for the other migration negative tests","commit_id":"061126e14c6129e6018be2a048db05549ccf01e7"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"70dffdb8e410178a9de0e3d8dff06e760c9ccb60","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            new_share_type_id\u003dnew_type_opposite[\u0027share_type\u0027][\u0027id\u0027],"},{"line_number":262,"context_line":"            new_share_network_id\u003dnew_share_network_id)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @testtools.skipUnless(CONF.share.run_driver_assisted_migration_tests,"},{"line_number":265,"context_line":"                          \"Driver-assisted migration tests are disabled.\")"},{"line_number":266,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":267,"context_line":"    @base.skip_if_microversion_lt(\"2.22\")"},{"line_number":268,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_332763cb","line":265,"range":{"start_line":264,"start_character":5,"end_line":265,"end_character":74},"updated":"2017-01-17 15:39:41.000000000","message":"please separate this into 2 tests, one for extend and shrink and other for driver-assisted with snapshots, as extend and shrink work perfectly with host-assisted.","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    @testtools.skipUnless(CONF.share.run_driver_assisted_migration_tests,"},{"line_number":265,"context_line":"                          \"Driver-assisted migration tests are disabled.\")"},{"line_number":266,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":267,"context_line":"    @base.skip_if_microversion_lt(\"2.22\")"},{"line_number":268,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":269,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]),"},{"line_number":270,"context_line":"              (\u0027create_snapshot\u0027, []))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_3b4f606c","line":267,"range":{"start_line":267,"start_character":36,"end_line":267,"end_character":37},"updated":"2017-01-16 23:09:20.000000000","message":"microversion has changed","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        self.shares_v2_client.reset_task_state("},{"line_number":278,"context_line":"            self.share[\u0027id\u0027],"},{"line_number":279,"context_line":"            constants.TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE)"},{"line_number":280,"context_line":"        self.assertRaises("},{"line_number":281,"context_line":"            lib_exc.BadRequest, getattr(self.shares_v2_client, method_name),"},{"line_number":282,"context_line":"            self.share[\u0027id\u0027], *args"},{"line_number":283,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_3bd2005d","line":280,"range":{"start_line":280,"start_character":0,"end_line":280,"end_character":26},"updated":"2017-01-16 23:09:20.000000000","message":"insert blank line above","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        self.assertRaises("},{"line_number":281,"context_line":"            lib_exc.BadRequest, getattr(self.shares_v2_client, method_name),"},{"line_number":282,"context_line":"            self.share[\u0027id\u0027], *args"},{"line_number":283,"context_line":"        )"},{"line_number":284,"context_line":"        # Revert the migration state by cancelling the migration"},{"line_number":285,"context_line":"        self.shares_v2_client.reset_state(self.share[\u0027id\u0027],"},{"line_number":286,"context_line":"                                          constants.STATUS_AVAILABLE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_7bc808a9","line":283,"range":{"start_line":283,"start_character":0,"end_line":283,"end_character":9},"updated":"2017-01-16 23:09:20.000000000","message":"pull to previous line","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            \u0027extend_share\u0027: CONF.share.run_extend_tests,"},{"line_number":294,"context_line":"            \u0027shrink_share\u0027: CONF.share.run_shrink_tests,"},{"line_number":295,"context_line":"            \u0027create_snapshot\u0027: CONF.share.run_snapshot_tests,"},{"line_number":296,"context_line":"            \u0027create_access_rule\u0027: True,"},{"line_number":297,"context_line":"        }"},{"line_number":298,"context_line":"        if not property_to_evaluate[method_name]:"},{"line_number":299,"context_line":"            raise self.skipException(method_name + \u0027tests are disabled.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_1bbaa40a","line":296,"range":{"start_line":296,"start_character":0,"end_line":296,"end_character":39},"updated":"2017-01-16 23:09:20.000000000","message":"remove","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    @testtools.skipUnless(CONF.share.run_driver_assisted_migration_tests,"},{"line_number":265,"context_line":"                          \"Driver-assisted migration tests are disabled.\")"},{"line_number":266,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":267,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":268,"context_line":"    def test_create_snapshot_during_share_migration(self):"},{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_b749f18d","line":267,"range":{"start_line":267,"start_character":35,"end_line":267,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    @testtools.skipUnless(CONF.share.run_driver_assisted_migration_tests,"},{"line_number":265,"context_line":"                          \"Driver-assisted migration tests are disabled.\")"},{"line_number":266,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":267,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":268,"context_line":"    def test_create_snapshot_during_share_migration(self):"},{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_60cb0a1f","line":267,"range":{"start_line":267,"start_character":35,"end_line":267,"end_character":39},"in_reply_to":"5a3905b3_b749f18d","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":272,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":273,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":274,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]))"},{"line_number":275,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_f75b7952","line":272,"range":{"start_line":272,"start_character":35,"end_line":272,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":272,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":273,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":274,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]))"},{"line_number":275,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_40c8ce22","line":272,"range":{"start_line":272,"start_character":35,"end_line":272,"end_character":39},"in_reply_to":"5a3905b3_f75b7952","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"049e18d6ee71735bea06cae141c8f047186fb68e","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    @testtools.skipUnless(CONF.share.run_driver_assisted_migration_tests,"},{"line_number":265,"context_line":"                          \"Driver-assisted migration tests are disabled.\")"},{"line_number":266,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":267,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":268,"context_line":"    def test_create_snapshot_during_share_migration(self):"},{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_1c72cead","line":267,"range":{"start_line":267,"start_character":37,"end_line":267,"end_character":39},"updated":"2017-01-20 10:51:17.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    @testtools.skipUnless(CONF.share.run_driver_assisted_migration_tests,"},{"line_number":265,"context_line":"                          \"Driver-assisted migration tests are disabled.\")"},{"line_number":266,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":267,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":268,"context_line":"    def test_create_snapshot_during_share_migration(self):"},{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_602f8af6","line":267,"range":{"start_line":267,"start_character":37,"end_line":267,"end_character":39},"in_reply_to":"5a3905b3_1c72cead","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":272,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":273,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":274,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]))"},{"line_number":275,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_285ae550","line":272,"range":{"start_line":272,"start_character":37,"end_line":272,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self._test_share_actions_during_share_migration(\u0027create_snapshot\u0027, [])"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":272,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":273,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":274,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]))"},{"line_number":275,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_80363650","line":272,"range":{"start_line":272,"start_character":37,"end_line":272,"end_character":39},"in_reply_to":"5a3905b3_285ae550","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":274,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]))"},{"line_number":275,"context_line":"    @ddt.unpack"},{"line_number":276,"context_line":"    def test_share_resize_during_share_migration(self, method_name, *args):"},{"line_number":277,"context_line":"        self._test_share_actions_during_share_migration(method_name, *args)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def skip_if_tests_are_disabled(self, method_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_48301102","line":276,"updated":"2017-01-20 10:50:31.000000000","message":"@base.skip_if_microversion_lt(\"2.28\")","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    @ddt.data((\u0027extend_share\u0027, [CONF.share.share_size + 2]),"},{"line_number":274,"context_line":"              (\u0027shrink_share\u0027, [CONF.share.share_size]))"},{"line_number":275,"context_line":"    @ddt.unpack"},{"line_number":276,"context_line":"    def test_share_resize_during_share_migration(self, method_name, *args):"},{"line_number":277,"context_line":"        self._test_share_actions_during_share_migration(method_name, *args)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def skip_if_tests_are_disabled(self, method_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_a0397243","line":276,"in_reply_to":"5a3905b3_48301102","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a3c09a3_5bf0acfe","updated":"2017-01-16 23:09:20.000000000","message":"almost all changes in this file seem unrelated. Did you have any tox issues while running this file?","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"}],"manila_tempest_tests/tests/api/test_replication_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    @testtools.skipUnless(CONF.share.run_host_assisted_migration_tests or"},{"line_number":163,"context_line":"                          CONF.share.run_driver_assisted_migration_tests,"},{"line_number":164,"context_line":"                          \"Share migration tests are disabled.\")"},{"line_number":165,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":166,"context_line":"    def test_migration_of_replicated_share(self):"},{"line_number":167,"context_line":"        pools \u003d self.admin_client.list_pools(detail\u003dTrue)[\u0027pools\u0027]"},{"line_number":168,"context_line":"        hosts \u003d [p[\u0027name\u0027] for p in pools]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_3b7680a4","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":58},"updated":"2017-01-16 23:09:20.000000000","message":"microversion skip?","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a99c59bce445f6c5a6a39e04e2736a07b1096850","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.assertRaises("},{"line_number":179,"context_line":"            lib_exc.Conflict, self.admin_client.migrate_share,"},{"line_number":180,"context_line":"            self.share1[\u0027id\u0027], dest_host"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_bb6a70b1","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":9},"updated":"2017-01-16 23:09:20.000000000","message":"pull up to previous line","commit_id":"fab6a3cc60b21da04fb28806c64703fabdf3ac34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7efc436a1b16a89339867175210212445d18cf79","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                          CONF.share.run_driver_assisted_migration_tests,"},{"line_number":164,"context_line":"                          \"Share migration tests are disabled.\")"},{"line_number":165,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":166,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":167,"context_line":"    def test_migration_of_replicated_share(self):"},{"line_number":168,"context_line":"        pools \u003d self.admin_client.list_pools(detail\u003dTrue)[\u0027pools\u0027]"},{"line_number":169,"context_line":"        hosts \u003d [p[\u0027name\u0027] for p in pools]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_5718cd84","line":166,"range":{"start_line":166,"start_character":35,"end_line":166,"end_character":39},"updated":"2017-01-19 23:24:00.000000000","message":"2.28","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"234645f74808c9417ad4f5886cf9b1f7a8fe31ae","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                          CONF.share.run_driver_assisted_migration_tests,"},{"line_number":164,"context_line":"                          \"Share migration tests are disabled.\")"},{"line_number":165,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":166,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":167,"context_line":"    def test_migration_of_replicated_share(self):"},{"line_number":168,"context_line":"        pools \u003d self.admin_client.list_pools(detail\u003dTrue)[\u0027pools\u0027]"},{"line_number":169,"context_line":"        hosts \u003d [p[\u0027name\u0027] for p in pools]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_a0d5f2b9","line":166,"range":{"start_line":166,"start_character":35,"end_line":166,"end_character":39},"in_reply_to":"5a3905b3_5718cd84","updated":"2017-01-20 19:38:53.000000000","message":"Done","commit_id":"3c298bc180d8627293f16421e8072b9a12211b0e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f7cbef91a8324c89ed325e89ce1b8acd423205be","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                          CONF.share.run_driver_assisted_migration_tests,"},{"line_number":164,"context_line":"                          \"Share migration tests are disabled.\")"},{"line_number":165,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":166,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":167,"context_line":"    def test_migration_of_replicated_share(self):"},{"line_number":168,"context_line":"        pools \u003d self.admin_client.list_pools(detail\u003dTrue)[\u0027pools\u0027]"},{"line_number":169,"context_line":"        hosts \u003d [p[\u0027name\u0027] for p in pools]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_5c3616e8","line":166,"range":{"start_line":166,"start_character":37,"end_line":166,"end_character":39},"updated":"2017-01-20 10:50:31.000000000","message":"28","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"d48f810b4422185a11f33e2fb675ca62d7fa4e19","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                          CONF.share.run_driver_assisted_migration_tests,"},{"line_number":164,"context_line":"                          \"Share migration tests are disabled.\")"},{"line_number":165,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":166,"context_line":"    @base.skip_if_microversion_lt(\"2.26\")"},{"line_number":167,"context_line":"    def test_migration_of_replicated_share(self):"},{"line_number":168,"context_line":"        pools \u003d self.admin_client.list_pools(detail\u003dTrue)[\u0027pools\u0027]"},{"line_number":169,"context_line":"        hosts \u003d [p[\u0027name\u0027] for p in pools]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_004b26ca","line":166,"range":{"start_line":166,"start_character":37,"end_line":166,"end_character":39},"in_reply_to":"5a3905b3_5c3616e8","updated":"2017-01-20 19:39:04.000000000","message":"Done","commit_id":"dc90257314a7ac9160219e960a800d15fbb12288"}]}
