)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  to migrating shares, or if using host assisted migration."},{"line_number":15,"context_line":"  Unset if migration fails, or is canceled."},{"line_number":16,"context_line":"- Expose the field via share-instances and share-replicas"},{"line_number":17,"context_line":"   APIs to administrators."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Supporting read only access rules part of the minimum"},{"line_number":20,"context_line":"driver requirements in manila"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a57fde8_a9b9d1ee","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":3},"updated":"2017-01-12 10:39:31.000000000","message":"extra space","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- Expose the field via share-instances and share-replicas"},{"line_number":17,"context_line":"   APIs to administrators."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Supporting read only access rules part of the minimum"},{"line_number":20,"context_line":"driver requirements in manila"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a57fde8_09b9fde9","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":16},"updated":"2017-01-12 10:39:31.000000000","message":"-","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- Expose the field via share-instances and share-replicas"},{"line_number":17,"context_line":"   APIs to administrators."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Supporting read only access rules part of the minimum"},{"line_number":20,"context_line":"driver requirements in manila"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a57fde8_69c8c975","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":38},"updated":"2017-01-12 10:39:31.000000000","message":"is part","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   APIs to administrators."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Supporting read only access rules part of the minimum"},{"line_number":20,"context_line":"driver requirements in manila"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"APIImpact"},{"line_number":23,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a57fde8_899c0d6b","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":29},"updated":"2017-01-12 10:39:31.000000000","message":"period","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"78c227c87be69b7f2e191a65ba52216c997e1fe8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Supporting read only access rules part of the minimum"},{"line_number":20,"context_line":"driver requirements in manila"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"APIImpact"},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a57fde8_2402683f","line":21,"updated":"2017-01-12 10:46:26.000000000","message":"partially implements blueprint refactor access rules","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"}],"manila/db/migrations/alembic/versions/e9f79621d83f_add_cast_rules_to_readonly_to_share_instances.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def upgrade():"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    LOG.info(_LI(\"Adding cast_rules_to_readonly column has to share \""},{"line_number":39,"context_line":"                 \"instances.\"))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    op.add_column(\u0027share_instances\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_e9e759aa","line":38,"range":{"start_line":38,"start_character":55,"end_line":38,"end_character":58},"updated":"2017-01-12 10:39:31.000000000","message":"remove","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"78c227c87be69b7f2e191a65ba52216c997e1fe8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               \u003d\u003d constants.REPLICATION_TYPE_READABLE)"},{"line_number":56,"context_line":"    )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    for replicated_share in connection.execute(replicated_shares_query):"},{"line_number":59,"context_line":"        # NOTE (gouthamr): Only secondary replicas that are not undergoing a"},{"line_number":60,"context_line":"        # \u0027replication_change\u0027 (promotion to active) are considered. When the"},{"line_number":61,"context_line":"        # replication change is complete, the share manager will take care"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_a49498e8","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":24},"updated":"2017-01-12 10:46:26.000000000","message":"not being used","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        secondary_replicas_query \u003d ("},{"line_number":65,"context_line":"            share_instances_table.select().where("},{"line_number":66,"context_line":"                share_instances_table.c.deleted \u003d\u003d \u0027False\u0027).where("},{"line_number":67,"context_line":"                share_instances_table.c.replication_type"},{"line_number":68,"context_line":"                    !\u003d constants.REPLICA_STATE_ACTIVE).where("},{"line_number":69,"context_line":"                share_instances_table.c.status"},{"line_number":70,"context_line":"                    !\u003d constants.STATUS_REPLICATION_CHANGE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_e93af9e6","line":67,"range":{"start_line":67,"start_character":40,"end_line":67,"end_character":56},"updated":"2017-01-12 10:39:31.000000000","message":"shouldn\u0027t this be replica_state ?","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"78c227c87be69b7f2e191a65ba52216c997e1fe8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                share_instances_table.c.replication_type"},{"line_number":68,"context_line":"                    !\u003d constants.REPLICA_STATE_ACTIVE).where("},{"line_number":69,"context_line":"                share_instances_table.c.status"},{"line_number":70,"context_line":"                    !\u003d constants.STATUS_REPLICATION_CHANGE)"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        for replica in connection.execute(secondary_replicas_query):"},{"line_number":73,"context_line":"            op.execute("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_649390fb","line":70,"range":{"start_line":70,"start_character":58,"end_line":70,"end_character":59},"updated":"2017-01-12 10:46:26.000000000","message":"should include that the replicated_share[\u0027id\u0027] is the same as the share instance share_id","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"78d51e43d53bdf55c6288f17640fe94666c4d093","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    LOG.info(_LI(\"Adding cast_rules_to_readonly column to share instances.\"))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    op.add_column(\u0027share_instances\u0027,"},{"line_number":41,"context_line":"                  sa.Column(\u0027cast_rules_to_readonly\u0027, sa.Boolean,"},{"line_number":42,"context_line":"                            default\u003dFalse))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    connection \u003d op.get_bind()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_8176efd4","line":41,"range":{"start_line":41,"start_character":29,"end_line":41,"end_character":51},"updated":"2017-01-17 19:09:29.000000000","message":"Would be better to define it in separate var and call this var to reduce probability of typos sneaking in.","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80a26dacffdb17b9b7e427280269a02a82572df1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    LOG.info(_LI(\"Adding cast_rules_to_readonly column to share instances.\"))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    op.add_column(\u0027share_instances\u0027,"},{"line_number":41,"context_line":"                  sa.Column(\u0027cast_rules_to_readonly\u0027, sa.Boolean,"},{"line_number":42,"context_line":"                            default\u003dFalse))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    connection \u003d op.get_bind()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_a9756dcb","line":41,"range":{"start_line":41,"start_character":29,"end_line":41,"end_character":51},"in_reply_to":"7a3c09a3_8176efd4","updated":"2017-01-18 15:21:11.000000000","message":"wouldn\u0027t be able to use the constants everywhere, and still there are kwargs that need to be typed in.","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4f8c8c204563cbfb681f6cb046e7bcb72c584266","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    \u0027cast_rules_to_readonly\u0027: True,"},{"line_number":88,"context_line":"                })"},{"line_number":89,"context_line":"            )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def downgrade():"},{"line_number":93,"context_line":"    LOG.info(_LI(\"Removing cast_rules_to_readonly column from share \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a3905b3_3d313b06","line":90,"updated":"2017-01-20 15:00:42.000000000","message":"Model has \"nullable\u003dFalse\" attr. So, it should be added right after you updated existing records.","commit_id":"a14f5534d7c96adb3c78578d3cf7be4ec184bd99"}],"manila/share/manager.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":771,"context_line":"            # database. It is assumed that driver cleans up leftovers in"},{"line_number":772,"context_line":"            # backend when migration fails."},{"line_number":773,"context_line":"            self._migration_delete_instance(context, dest_share_instance[\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"            # NOTE(ganso): For now source share instance should remain in"},{"line_number":776,"context_line":"            # migrating status for host-assisted migration."},{"line_number":777,"context_line":"            msg \u003d _(\"Driver-assisted migration of share %s \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_04e2c403","line":774,"updated":"2017-01-12 10:39:31.000000000","message":"found a bug: need to revert access_rules here back to RW if they are not","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2bd4700ef5eaa62b9b6300a9f5953bcd40200975","unresolved":false,"context_lines":[{"line_number":771,"context_line":"            # database. It is assumed that driver cleans up leftovers in"},{"line_number":772,"context_line":"            # backend when migration fails."},{"line_number":773,"context_line":"            self._migration_delete_instance(context, dest_share_instance[\u0027id\u0027])"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"            # NOTE(ganso): For now source share instance should remain in"},{"line_number":776,"context_line":"            # migrating status for host-assisted migration."},{"line_number":777,"context_line":"            msg \u003d _(\"Driver-assisted migration of share %s \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_db67b623","line":774,"in_reply_to":"9a57fde8_04e2c403","updated":"2017-01-12 11:24:44.000000000","message":"actually, this needs to be done outside of this method","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9b23a159f12099796e042b3867535f9ea787deff","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                    self._migration_delete_instance("},{"line_number":849,"context_line":"                        context, dest_share_instance[\u0027id\u0027])"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"                    self.db.share_instance_update("},{"line_number":852,"context_line":"                        context, src_share_instance[\u0027id\u0027],"},{"line_number":853,"context_line":"                        {\u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":854,"context_line":"                         \u0027cast_rules_to_readonly\u0027: False})"},{"line_number":855,"context_line":"                    self.db.share_update("},{"line_number":856,"context_line":"                        context, instance[\u0027share_id\u0027],"},{"line_number":857,"context_line":"                        {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_ERROR})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_2e3fa226","line":854,"range":{"start_line":851,"start_character":20,"end_line":854,"end_character":58},"updated":"2017-01-12 23:06:16.000000000","message":"need to revert the rules here as well","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                {\u0027task_state\u0027: constants.TASK_STATE_MIGRATION_ERROR})"},{"line_number":926,"context_line":"            self.db.share_instance_update("},{"line_number":927,"context_line":"                context, share_instance[\u0027id\u0027],"},{"line_number":928,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":929,"context_line":"            raise exception.ShareMigrationFailed(reason\u003dmsg)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"    def _migration_start_host_assisted("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_0481e44a","line":928,"range":{"start_line":928,"start_character":16,"end_line":928,"end_character":55},"updated":"2017-01-12 10:39:31.000000000","message":"need to revert cast_to_read_only here, but check if it is True first","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"            helper.cleanup_new_instance(dest_share_instance)"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"            helper.cleanup_access_rules(src_share_instance, share_server,"},{"line_number":1216,"context_line":"                                        self.driver)"},{"line_number":1217,"context_line":"        else:"},{"line_number":1218,"context_line":"            self.driver.migration_cancel("},{"line_number":1219,"context_line":"                context, src_share_instance, dest_share_instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_a40498c6","line":1216,"range":{"start_line":1215,"start_character":11,"end_line":1216,"end_character":52},"updated":"2017-01-12 10:39:31.000000000","message":"I believe this is a bug, this should be moved to outside the condition. If performing a driver-assisted migration and share is not writable (they have been changed to read-only), they need to be revert back","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"        self.db.share_instance_update("},{"line_number":1229,"context_line":"            context, src_share_instance[\u0027id\u0027],"},{"line_number":1230,"context_line":"            {\u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":1231,"context_line":"             \u0027cast_rules_to_readonly\u0027: False})"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"        LOG.info(_LI(\"Share Migration for share %s\""},{"line_number":1234,"context_line":"                     \" was cancelled.\"), share_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_64be3001","line":1231,"range":{"start_line":1231,"start_character":14,"end_line":1231,"end_character":46},"updated":"2017-01-12 10:39:31.000000000","message":"this needs to be done before cleanup_access_rules","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13a10d1a35f1a353bea26c9ac0f1c6517a4b0eed","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            {\u0027cast_rules_to_readonly\u0027: True})"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        # Set all \u0027applying\u0027 or \u0027active\u0027 rules to \u0027queued_to_apply\u0027. Since the"},{"line_number":793,"context_line":"        # share has a status set to \u0027migrating\u0027, this will render rules"},{"line_number":794,"context_line":"        # read/only."},{"line_number":795,"context_line":"        acceptable_past_states \u003d (constants.ACCESS_STATE_APPLYING,"},{"line_number":796,"context_line":"                                  constants.ACCESS_STATE_ACTIVE)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_cc507561","line":793,"range":{"start_line":793,"start_character":16,"end_line":793,"end_character":47},"updated":"2017-01-20 21:25:23.000000000","message":"has it\u0027s cast_rules_to_readonly attribute set to True","commit_id":"9c257b71dfb2bd8b8dbd732b14afc71ef1e96482"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3361aeb700d04c88b32eb3674f6db398b15b6b76","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            {\u0027cast_rules_to_readonly\u0027: True})"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        # Set all \u0027applying\u0027 or \u0027active\u0027 rules to \u0027queued_to_apply\u0027. Since the"},{"line_number":793,"context_line":"        # share has a status set to \u0027migrating\u0027, this will render rules"},{"line_number":794,"context_line":"        # read/only."},{"line_number":795,"context_line":"        acceptable_past_states \u003d (constants.ACCESS_STATE_APPLYING,"},{"line_number":796,"context_line":"                                  constants.ACCESS_STATE_ACTIVE)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_03bb2b0f","line":793,"range":{"start_line":793,"start_character":16,"end_line":793,"end_character":47},"in_reply_to":"5a3905b3_cc507561","updated":"2017-01-20 21:57:12.000000000","message":"fix it on the next rebase","commit_id":"9c257b71dfb2bd8b8dbd732b14afc71ef1e96482"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bdd9dfae35b9f193af2e2e3c97775350f61a5d5c","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"@map_to_migration(\u0027e9f79621d83f\u0027)"},{"line_number":1337,"context_line":"class AddCastRulesToReadonlyToInstances(BaseMigrationChecks):"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":"    def setup_upgrade_data(self, engine):"},{"line_number":1340,"context_line":"        pass"},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"    def check_upgrade(self, engine, data):"},{"line_number":1343,"context_line":"        pass"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def check_downgrade(self, engine):"},{"line_number":1346,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_c4935c4e","line":1346,"range":{"start_line":1339,"start_character":4,"end_line":1346,"end_character":12},"updated":"2017-01-12 10:39:31.000000000","message":"TODO","commit_id":"3a204d1457729499eaf16534d1030249f3664b25"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7ab6c12322f54b73e44b913920abd4c927578d90","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"                share_instances_table.c.id in self.instance_ids)):"},{"line_number":1471,"context_line":"            share \u003d engine.execute(shares_table.select().where("},{"line_number":1472,"context_line":"                instance[\u0027share_id\u0027] \u003d\u003d shares_table.c.id)).first()"},{"line_number":1473,"context_line":"            self.test_case.assertIn(\u0027cast_rules_to_readonly\u0027, instance)"},{"line_number":1474,"context_line":"            if (instance[\u0027replica_state\u0027] !\u003d constants.REPLICA_STATE_ACTIVE and"},{"line_number":1475,"context_line":"                    share[\u0027replication_type\u0027] \u003d\u003d"},{"line_number":1476,"context_line":"                    constants.REPLICATION_TYPE_READABLE and"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_2158db89","line":1473,"range":{"start_line":1473,"start_character":11,"end_line":1473,"end_character":71},"updated":"2017-01-17 19:07:47.000000000","message":"Would be better to place this line before above one to reduce amount of actions in case this one fails.","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80a26dacffdb17b9b7e427280269a02a82572df1","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"                share_instances_table.c.id in self.instance_ids)):"},{"line_number":1471,"context_line":"            share \u003d engine.execute(shares_table.select().where("},{"line_number":1472,"context_line":"                instance[\u0027share_id\u0027] \u003d\u003d shares_table.c.id)).first()"},{"line_number":1473,"context_line":"            self.test_case.assertIn(\u0027cast_rules_to_readonly\u0027, instance)"},{"line_number":1474,"context_line":"            if (instance[\u0027replica_state\u0027] !\u003d constants.REPLICA_STATE_ACTIVE and"},{"line_number":1475,"context_line":"                    share[\u0027replication_type\u0027] \u003d\u003d"},{"line_number":1476,"context_line":"                    constants.REPLICATION_TYPE_READABLE and"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_a949ed32","line":1473,"range":{"start_line":1473,"start_character":11,"end_line":1473,"end_character":71},"in_reply_to":"7a3c09a3_2158db89","updated":"2017-01-18 15:21:11.000000000","message":"Done","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7ab6c12322f54b73e44b913920abd4c927578d90","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"                    constants.REPLICATION_TYPE_READABLE and"},{"line_number":1477,"context_line":"                    instance[\u0027status\u0027] !\u003d constants.STATUS_REPLICATION_CHANGE):"},{"line_number":1478,"context_line":"                self.test_case.assertTrue(instance[\u0027cast_rules_to_readonly\u0027])"},{"line_number":1479,"context_line":"                self.test_case.assertTrue("},{"line_number":1480,"context_line":"                    instance[\u0027id\u0027] \u003d\u003d self.correct_instance[\u0027id\u0027])"},{"line_number":1481,"context_line":"            else:"},{"line_number":1482,"context_line":"                self.test_case.assertEqual("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_a1e3eba2","line":1479,"range":{"start_line":1479,"start_character":31,"end_line":1479,"end_character":41},"updated":"2017-01-17 19:07:47.000000000","message":"assertEqual","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80a26dacffdb17b9b7e427280269a02a82572df1","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"                    constants.REPLICATION_TYPE_READABLE and"},{"line_number":1477,"context_line":"                    instance[\u0027status\u0027] !\u003d constants.STATUS_REPLICATION_CHANGE):"},{"line_number":1478,"context_line":"                self.test_case.assertTrue(instance[\u0027cast_rules_to_readonly\u0027])"},{"line_number":1479,"context_line":"                self.test_case.assertTrue("},{"line_number":1480,"context_line":"                    instance[\u0027id\u0027] \u003d\u003d self.correct_instance[\u0027id\u0027])"},{"line_number":1481,"context_line":"            else:"},{"line_number":1482,"context_line":"                self.test_case.assertEqual("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_a9700d73","line":1479,"range":{"start_line":1479,"start_character":31,"end_line":1479,"end_character":41},"in_reply_to":"7a3c09a3_a1e3eba2","updated":"2017-01-18 15:21:11.000000000","message":"Done","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7ab6c12322f54b73e44b913920abd4c927578d90","unresolved":false,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"        share_instances_table \u003d utils.load_table(\u0027share_instances\u0027, engine)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"        for instance in engine.execute(share_instances_table.select().where("},{"line_number":1490,"context_line":"                share_instances_table.c.id in self.instance_ids)):"},{"line_number":1491,"context_line":"            self.test_case.assertNotIn(\u0027cast_rules_to_readonly\u0027, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_a11e8bb8","line":1490,"range":{"start_line":1489,"start_character":8,"end_line":1490,"end_character":66},"updated":"2017-01-17 19:07:47.000000000","message":"It is the case when we should pick exactly all records we have. None of records should have this attr.","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80a26dacffdb17b9b7e427280269a02a82572df1","unresolved":false,"context_lines":[{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"        share_instances_table \u003d utils.load_table(\u0027share_instances\u0027, engine)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"        for instance in engine.execute(share_instances_table.select().where("},{"line_number":1490,"context_line":"                share_instances_table.c.id in self.instance_ids)):"},{"line_number":1491,"context_line":"            self.test_case.assertNotIn(\u0027cast_rules_to_readonly\u0027, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_090841d9","line":1490,"range":{"start_line":1489,"start_character":8,"end_line":1490,"end_character":66},"in_reply_to":"7a3c09a3_a11e8bb8","updated":"2017-01-18 15:21:11.000000000","message":"Done","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"}],"manila_tempest_tests/tests/api/admin/test_share_instances.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7ab6c12322f54b73e44b913920abd4c927578d90","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            expected_keys.extend([\"export_location\", \"export_locations\"])"},{"line_number":77,"context_line":"        if utils.is_microversion_ge(version, \u00272.10\u0027):"},{"line_number":78,"context_line":"            expected_keys.append(\"access_rules_status\")"},{"line_number":79,"context_line":"        if utils.is_microversion_ge(version, \u00272.11\u0027):"},{"line_number":80,"context_line":"            expected_keys.append(\"replica_state\")"},{"line_number":81,"context_line":"        if utils.is_microversion_ge(version, \u00272.22\u0027):"},{"line_number":82,"context_line":"            expected_keys.append(\"share_type_id\")"},{"line_number":83,"context_line":"        if utils.is_microversion_ge(version, \u00272.27\u0027):"},{"line_number":84,"context_line":"            expected_keys.append(\"cast_rules_to_readonly\")"},{"line_number":85,"context_line":"        expected_keys \u003d sorted(expected_keys)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_61a583a0","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":49},"updated":"2017-01-17 19:07:47.000000000","message":"These","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80a26dacffdb17b9b7e427280269a02a82572df1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            expected_keys.extend([\"export_location\", \"export_locations\"])"},{"line_number":77,"context_line":"        if utils.is_microversion_ge(version, \u00272.10\u0027):"},{"line_number":78,"context_line":"            expected_keys.append(\"access_rules_status\")"},{"line_number":79,"context_line":"        if utils.is_microversion_ge(version, \u00272.11\u0027):"},{"line_number":80,"context_line":"            expected_keys.append(\"replica_state\")"},{"line_number":81,"context_line":"        if utils.is_microversion_ge(version, \u00272.22\u0027):"},{"line_number":82,"context_line":"            expected_keys.append(\"share_type_id\")"},{"line_number":83,"context_line":"        if utils.is_microversion_ge(version, \u00272.27\u0027):"},{"line_number":84,"context_line":"            expected_keys.append(\"cast_rules_to_readonly\")"},{"line_number":85,"context_line":"        expected_keys \u003d sorted(expected_keys)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_ab763a03","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":49},"in_reply_to":"7a3c09a3_61a583a0","updated":"2017-01-18 15:21:11.000000000","message":"Done","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7ab6c12322f54b73e44b913920abd4c927578d90","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":101,"context_line":"    def test_get_share_instance_v2_10(self):"},{"line_number":102,"context_line":"        self._get_share_instance(\u00272.10\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":105,"context_line":"    def test_get_share_instance_v2_11(self):"},{"line_number":106,"context_line":"        self._get_share_instance(\u00272.11\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":109,"context_line":"    def test_get_share_instance_v2_22(self):"},{"line_number":110,"context_line":"        self._get_share_instance(\u00272.22\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":113,"context_line":"    def test_get_share_instance_v2_27(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_e1b7b3d5","line":110,"range":{"start_line":103,"start_character":0,"end_line":110,"end_character":40},"updated":"2017-01-17 19:07:47.000000000","message":"and these look as redundant changes.","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80a26dacffdb17b9b7e427280269a02a82572df1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":101,"context_line":"    def test_get_share_instance_v2_10(self):"},{"line_number":102,"context_line":"        self._get_share_instance(\u00272.10\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":105,"context_line":"    def test_get_share_instance_v2_11(self):"},{"line_number":106,"context_line":"        self._get_share_instance(\u00272.11\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":109,"context_line":"    def test_get_share_instance_v2_22(self):"},{"line_number":110,"context_line":"        self._get_share_instance(\u00272.22\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":113,"context_line":"    def test_get_share_instance_v2_27(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_8b6b3e1d","line":110,"range":{"start_line":103,"start_character":0,"end_line":110,"end_character":40},"in_reply_to":"7a3c09a3_e1b7b3d5","updated":"2017-01-18 15:21:11.000000000","message":"Done","commit_id":"df2199016f6d1188f31b5cb76c760e388c592745"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ab9f2744a985efde87da5aaa5347313832927d0a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self._get_share_instance(\u00272.10\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":105,"context_line":"    def test_get_share_instance_v2_27(self):"},{"line_number":106,"context_line":"        self._get_share_instance(\u00272.29\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a3905b3_77083792","line":105,"range":{"start_line":105,"start_character":32,"end_line":105,"end_character":37},"updated":"2017-01-20 18:12:49.000000000","message":"v2_29","commit_id":"41a28e5cf93803dc373e3d9b082beeec6bd7d685"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"84f6d49ab512b7fbd69bbc25bf0735c50f03d3ba","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self._get_share_instance(\u00272.10\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":105,"context_line":"    def test_get_share_instance_v2_27(self):"},{"line_number":106,"context_line":"        self._get_share_instance(\u00272.29\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a3905b3_773597f5","line":105,"range":{"start_line":105,"start_character":32,"end_line":105,"end_character":37},"in_reply_to":"5a3905b3_77083792","updated":"2017-01-20 18:22:27.000000000","message":"Done","commit_id":"41a28e5cf93803dc373e3d9b082beeec6bd7d685"}]}
