)]}'
{"manila/tests/share/drivers/dell_emc/plugins/unity/utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eab6844a68034e3cfb02a27f341b045569a2e037","unresolved":false,"context_lines":[{"line_number":24,"context_line":"patch_system \u003d mock.patch(\u0027storops.UnitySystem\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_yaml(file_name):"},{"line_number":28,"context_line":"    yaml_file \u003d \u0027{}/{}\u0027.format(path.dirname(path.abspath(__file__)), file_name)"},{"line_number":29,"context_line":"    with open(yaml_file) as f:"},{"line_number":30,"context_line":"        res \u003d yaml.safe_load(f)"},{"line_number":31,"context_line":"        LOG.debug(\u0027Loaded yaml mock objects from %s.\u0027, yaml_file)"},{"line_number":32,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_62b5c9ec","line":32,"range":{"start_line":27,"start_character":0,"end_line":32,"end_character":14},"updated":"2017-01-16 16:49:32.000000000","message":"As far as it is bugfix, with clear statement what is fixed. It is expected to have appropriate unit test for it. Proof, that it is not dangerous anymore.","commit_id":"1d0478a8e592a37765647e8d2fc5f77be26bdc9e"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"2b575d3e2629307919a30d96e5bd38b8aee97e90","unresolved":false,"context_lines":[{"line_number":24,"context_line":"patch_system \u003d mock.patch(\u0027storops.UnitySystem\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_yaml(file_name):"},{"line_number":28,"context_line":"    yaml_file \u003d \u0027{}/{}\u0027.format(path.dirname(path.abspath(__file__)), file_name)"},{"line_number":29,"context_line":"    with open(yaml_file) as f:"},{"line_number":30,"context_line":"        res \u003d yaml.safe_load(f)"},{"line_number":31,"context_line":"        LOG.debug(\u0027Loaded yaml mock objects from %s.\u0027, yaml_file)"},{"line_number":32,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_edbdd302","line":32,"range":{"start_line":27,"start_character":0,"end_line":32,"end_character":14},"in_reply_to":"7a3c09a3_62b5c9ec","updated":"2017-01-18 04:55:36.000000000","message":"Valeriy Ponomaryov,  It is not safe to call yaml.load with any data received from an untrusted source! yaml.load is as powerful as pickle.load and so may call any Python function. Check the yaml.safe_load function though. The function yaml.load converts a YAML document to a Python object.","commit_id":"1d0478a8e592a37765647e8d2fc5f77be26bdc9e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83916bd83178090c18fce70420ba3e7c77b7a8ba","unresolved":false,"context_lines":[{"line_number":24,"context_line":"patch_system \u003d mock.patch(\u0027storops.UnitySystem\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_yaml(file_name):"},{"line_number":28,"context_line":"    yaml_file \u003d \u0027{}/{}\u0027.format(path.dirname(path.abspath(__file__)), file_name)"},{"line_number":29,"context_line":"    with open(yaml_file) as f:"},{"line_number":30,"context_line":"        res \u003d yaml.safe_load(f)"},{"line_number":31,"context_line":"        LOG.debug(\u0027Loaded yaml mock objects from %s.\u0027, yaml_file)"},{"line_number":32,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_b3745a68","line":32,"range":{"start_line":27,"start_character":0,"end_line":32,"end_character":14},"in_reply_to":"7a3c09a3_62b5c9ec","updated":"2017-01-16 21:42:16.000000000","message":"i wouldn\u0027t add the proof right here in this project, i would trust the library and it\u0027s documentation for appropriate testing. \n\nhttp://pyyaml.org/wiki/PyYAMLDocumentation#LoadingYAML\n\nHowever, We should have had unit tests failing if this was well covered. maybe EMC driver maintainers can help identify if we can complete any missing unit test coverage.","commit_id":"1d0478a8e592a37765647e8d2fc5f77be26bdc9e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a665f7c7ade18a6035008773f0da250958f39e23","unresolved":false,"context_lines":[{"line_number":24,"context_line":"patch_system \u003d mock.patch(\u0027storops.UnitySystem\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_yaml(file_name):"},{"line_number":28,"context_line":"    yaml_file \u003d \u0027{}/{}\u0027.format(path.dirname(path.abspath(__file__)), file_name)"},{"line_number":29,"context_line":"    with open(yaml_file) as f:"},{"line_number":30,"context_line":"        res \u003d yaml.safe_load(f)"},{"line_number":31,"context_line":"        LOG.debug(\u0027Loaded yaml mock objects from %s.\u0027, yaml_file)"},{"line_number":32,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_0b7aee87","line":32,"range":{"start_line":27,"start_character":0,"end_line":32,"end_character":14},"in_reply_to":"7a3c09a3_edbdd302","updated":"2017-01-18 14:11:58.000000000","message":"Tuan Luong-Anh,\n\nMy comment was about covering your change with unit tests, no more, no less. Your comment does not touch \"unit test\" field at all.","commit_id":"1d0478a8e592a37765647e8d2fc5f77be26bdc9e"}]}
