)]}'
{"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"401ce5a9739ddd149d6e75d1bb9400cc0c457627","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        return all_export_locations"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def __getattr__(self, item):"},{"line_number":229,"context_line":"        deprecated_properties \u003d (\u0027host\u0027, \u0027share_server_id\u0027, \u0027share_network_id\u0027)"},{"line_number":230,"context_line":"        proxified_properties \u003d (\u0027status\u0027,) + deprecated_properties"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if item in deprecated_properties:"},{"line_number":233,"context_line":"            msg \u003d (\"Property \u0027%s\u0027 is deprecated. Please use appropriate \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_4942b011","line":230,"range":{"start_line":229,"start_character":3,"end_line":230,"end_character":66},"updated":"2017-01-16 18:09:45.000000000","message":"We should just create @property elements for these","commit_id":"4ceb4d35334a83180eed463a36f12af3465bc21b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10bb8d734e71994c80517aa7230053d8f540b3af","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        return all_export_locations"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def __getattr__(self, item):"},{"line_number":229,"context_line":"        deprecated_properties \u003d (\u0027host\u0027, \u0027share_server_id\u0027, \u0027share_network_id\u0027)"},{"line_number":230,"context_line":"        proxified_properties \u003d (\u0027status\u0027,) + deprecated_properties"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if item in deprecated_properties:"},{"line_number":233,"context_line":"            msg \u003d (\"Property \u0027%s\u0027 is deprecated. Please use appropriate \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_7eeba178","line":230,"range":{"start_line":229,"start_character":3,"end_line":230,"end_character":66},"in_reply_to":"7a3c09a3_04132db9","updated":"2017-01-16 19:13:53.000000000","message":"I agree we need to have a discussion around this. I was still new to the project when this was originally designed, so i don\u0027t know the exact intent of this deprecation warning. However, having worked with share instances over the past few releases, i have an opinion:\n\nA share has a few properties to lend to a share instance:\n* share_id, user_id, project_id, size, name, snapshot_id, share_proto, is_public\n* Capability fields:  snapshot_support, create_share_from_snapshot_support, replication_type, consistency_group_id\n\nI think we should force the use of share instances in code and limit the use of the share model only within the API:\n\nOff the top of my head, i don\u0027t know how many LoC this could be or how much effort, but it\u0027s definitely a code cleanup we will all benefit from and reduce the complexity to other developers, especially new developers.\n\n\nI vote for dropping this useless deprecation warning at the moment and making the changes we need.","commit_id":"4ceb4d35334a83180eed463a36f12af3465bc21b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8d82ac4cc8ef47bb492e6ebc0134c4ee3963117d","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        return all_export_locations"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def __getattr__(self, item):"},{"line_number":229,"context_line":"        deprecated_properties \u003d (\u0027host\u0027, \u0027share_server_id\u0027, \u0027share_network_id\u0027)"},{"line_number":230,"context_line":"        proxified_properties \u003d (\u0027status\u0027,) + deprecated_properties"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if item in deprecated_properties:"},{"line_number":233,"context_line":"            msg \u003d (\"Property \u0027%s\u0027 is deprecated. Please use appropriate \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_04132db9","line":230,"range":{"start_line":229,"start_character":3,"end_line":230,"end_character":66},"in_reply_to":"7a3c09a3_4942b011","updated":"2017-01-16 18:38:35.000000000","message":"Well, we should have an explicit design discussion of whether we really want to deprecate these share properties, as clearly was intended originally, or whether we want to keep them as proxified properties and just get rid of the annoying deprecation messages.\n\nI began this patch set just wanting to get rid of the messages but over time became persuaded that removing the proxification forces cleaner code and a better sense at higher levels of the true data model.  I may be wrong and the proxification really provides a useful and/or necessary abstraction for developers.  Here \"for developers\" is essential: I\u0027m not talking about the abstraction that we provide end users.","commit_id":"4ceb4d35334a83180eed463a36f12af3465bc21b"}]}
