)]}'
{"manila/share/snapshot_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ef624408eed98b4069299e061f6149e72cf000b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                    constants.ACCESS_STATE_DENYING,"},{"line_number":89,"context_line":"                    # NOTE(ganso): We do not re-send error-ed access rules to"},{"line_number":90,"context_line":"                    # drivers."},{"line_number":91,"context_line":"                    constants.ACCESS_STATE_ERROR"},{"line_number":92,"context_line":"                )"},{"line_number":93,"context_line":"            ]"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_2c7a6f88","line":91,"range":{"start_line":91,"start_character":43,"end_line":91,"end_character":48},"updated":"2017-01-31 19:18:25.000000000","message":"trailing comma","commit_id":"4f330330d59739ec6549a1d83096e8334e8bbe0c"}],"manila/tests/share/test_snapshot_access.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bf9bfd7b743236c2a0d248b73317d8a22df8d620","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if state \u003d\u003d constants.ACCESS_STATE_QUEUED_TO_APPLY:"},{"line_number":88,"context_line":"            self.driver.snapshot_update_access.assert_called_once_with("},{"line_number":89,"context_line":"                utils.IsAMatcher(context.RequestContext),"},{"line_number":90,"context_line":"                self.snapshot_instance, rules_to_be_on_driver, add_rules\u003drules,"},{"line_number":91,"context_line":"                delete_rules\u003d[], share_server\u003dNone)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            self.driver.snapshot_update_access.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_cdfe70ad","line":90,"range":{"start_line":90,"start_character":73,"end_line":90,"end_character":78},"updated":"2017-01-30 22:04:55.000000000","message":"s/rules/rules_to_be_on_driver/  -- I think you\u0027ve done this for clarity and you should do it here too.","commit_id":"f40a3f0dd22727c2d7368794d9887f49847b14c9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6627559dc830093c3f918ce95a740f8523ad38ff","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if state \u003d\u003d constants.ACCESS_STATE_QUEUED_TO_APPLY:"},{"line_number":88,"context_line":"            self.driver.snapshot_update_access.assert_called_once_with("},{"line_number":89,"context_line":"                utils.IsAMatcher(context.RequestContext),"},{"line_number":90,"context_line":"                self.snapshot_instance, rules_to_be_on_driver, add_rules\u003drules,"},{"line_number":91,"context_line":"                delete_rules\u003d[], share_server\u003dNone)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            self.driver.snapshot_update_access.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_d46fc9f9","line":90,"range":{"start_line":90,"start_character":73,"end_line":90,"end_character":78},"in_reply_to":"3a461143_cdfe70ad","updated":"2017-01-31 10:28:41.000000000","message":"Done","commit_id":"f40a3f0dd22727c2d7368794d9887f49847b14c9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ef624408eed98b4069299e061f6149e72cf000b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        all_rules.append({"},{"line_number":58,"context_line":"            \u0027id\u0027: \u0027id-3\u0027,"},{"line_number":59,"context_line":"            \u0027state\u0027: constants.ACCESS_STATE_ERROR,"},{"line_number":60,"context_line":"            \u0027access_id\u0027: \u0027rule_id3\u0027"},{"line_number":61,"context_line":"        })"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        snapshot_instance_get \u003d self.mock_object("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_ac3f3fb2","line":60,"range":{"start_line":60,"start_character":34,"end_line":60,"end_character":35},"updated":"2017-01-31 19:18:25.000000000","message":"trailing comma","commit_id":"4f330330d59739ec6549a1d83096e8334e8bbe0c"}],"releasenotes/notes/bug-1660425-snapshot-access-in-error-bce279ee310060f5.yaml":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"af951c3789ce17e6aedf54583bdf2004a308958b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed error\u0027ed snapshot access rules being sent to drivers"},{"line_number":4,"context_line":"    resulting in error state for new rules whenever there was"},{"line_number":5,"context_line":"    an existing access rule in error state. "},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_d95d5616","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":44},"updated":"2017-01-30 20:01:01.000000000","message":"? extra space at end?","commit_id":"13f77d530a23c917b2b4113122a04f6a83bc60ba"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2c52c67378992ed4ccaaff91ffee06d7e068b288","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed error\u0027ed snapshot access rules being sent to drivers"},{"line_number":4,"context_line":"    resulting in error state for new rules whenever there was"},{"line_number":5,"context_line":"    an existing access rule in error state. "},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_523e9bda","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":44},"in_reply_to":"3a461143_d95d5616","updated":"2017-01-30 21:53:13.000000000","message":"Done","commit_id":"13f77d530a23c917b2b4113122a04f6a83bc60ba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"747663ec7f83507473b743336ba429632c7aa36d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed error\u0027ed snapshot access rules being sent to drivers"},{"line_number":4,"context_line":"    resulting in error state for new rules whenever there was"},{"line_number":5,"context_line":"    an existing access rule in error state."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_4134ebfa","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":43},"updated":"2017-01-31 16:29:11.000000000","message":"similar comment as in the HNAS patch.. the sentence is too long to comprehend what is being fixed. \n\n  - Snapshot access rules in error state are not re-applied at the driver. \n  Users can deny these rules to purge them.","commit_id":"2e7d1b2ae5242e9624aade33055ce9b5e861201a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1ef7e8a2e2f56ee2617b1bbb4035cf9dd6b5c8e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed error\u0027ed snapshot access rules being sent to drivers"},{"line_number":4,"context_line":"    resulting in error state for new rules whenever there was"},{"line_number":5,"context_line":"    an existing access rule in error state."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_fbd57f1b","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":43},"in_reply_to":"3a461143_4134ebfa","updated":"2017-01-31 18:06:28.000000000","message":"but they are reapplied, and users could already deny them to purge them.","commit_id":"2e7d1b2ae5242e9624aade33055ce9b5e861201a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7971c229c7dbb8160c690f39196881a8b1df22eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed error\u0027ed snapshot access rules being sent to drivers"},{"line_number":4,"context_line":"    resulting in error state for new rules whenever there was"},{"line_number":5,"context_line":"    an existing access rule in error state."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_2c534f18","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":43},"in_reply_to":"3a461143_bbacd78c","updated":"2017-01-31 19:17:26.000000000","message":"how about now?","commit_id":"2e7d1b2ae5242e9624aade33055ce9b5e861201a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"775a266e9a375e7df9cb1e6896cad9af4edce60a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed error\u0027ed snapshot access rules being sent to drivers"},{"line_number":4,"context_line":"    resulting in error state for new rules whenever there was"},{"line_number":5,"context_line":"    an existing access rule in error state."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_bbacd78c","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":43},"in_reply_to":"3a461143_fbd57f1b","updated":"2017-01-31 18:10:49.000000000","message":"i meant \u0027automatically reapplied\u0027\n\nUsers may expect, depending on how they perceive our switch to bulk access updates that something going to error will be reattempted at the driver with each access rules transaction. We\u0027re saying that assumption does not hold for rules in error state.","commit_id":"2e7d1b2ae5242e9624aade33055ce9b5e861201a"}]}
