)]}'
{"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0aebbf684dcae8babbcabbf4ab89949b71d40792","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        create_from_snapshot_support \u003d six.text_type("},{"line_number":765,"context_line":"            CONF.share.capability_create_share_from_snapshot_support)"},{"line_number":766,"context_line":"        revert_to_snapshot_support \u003d six.text_type("},{"line_number":767,"context_line":"            CONF.share.capability_revert_to_snapshot_support)"},{"line_number":768,"context_line":"        mount_snapshot_support \u003d six.text_type("},{"line_number":769,"context_line":"            CONF.share.capability_mount_snapshot_support)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        extra_specs_dict \u003d {"},{"line_number":772,"context_line":"            \"driver_handles_share_servers\": dhss,"},{"line_number":773,"context_line":"        }"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        optional \u003d {"},{"line_number":776,"context_line":"            \"snapshot_support\": snapshot_support,"},{"line_number":777,"context_line":"            \"create_share_from_snapshot_support\": create_from_snapshot_support,"},{"line_number":778,"context_line":"            \"revert_to_snapshot_support\": revert_to_snapshot_support,"},{"line_number":779,"context_line":"            \"mount_snapshot_support\": mount_snapshot_support,"},{"line_number":780,"context_line":"        }"},{"line_number":781,"context_line":"        # NOTE(gouthamr): In micro-versions \u003c 2.24, snapshot_support is a"},{"line_number":782,"context_line":"        # required extra-spec"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_8a2ed9a2","line":779,"range":{"start_line":767,"start_character":0,"end_line":779,"end_character":61},"updated":"2017-02-01 01:53:18.000000000","message":"revert_to_snapshot_support should not have been added here. Same holds with mount_snapshot_support.\n\nYou do not need every share type that\u0027s created to add these options. They only need to be added when testing the functionality. See the note below. The only reason snapshot_support and create_share_from_snapshot_support were added was to maintain backwards compatibility.","commit_id":"f9be80ee19970a98d464e4dcc92e4e76c39b07a3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a09c09b4129b4e8df437a2e9cd2b73efc05b1cd1","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        create_from_snapshot_support \u003d six.text_type("},{"line_number":765,"context_line":"            CONF.share.capability_create_share_from_snapshot_support)"},{"line_number":766,"context_line":"        revert_to_snapshot_support \u003d six.text_type("},{"line_number":767,"context_line":"            CONF.share.capability_revert_to_snapshot_support)"},{"line_number":768,"context_line":"        mount_snapshot_support \u003d six.text_type("},{"line_number":769,"context_line":"            CONF.share.capability_mount_snapshot_support)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        extra_specs_dict \u003d {"},{"line_number":772,"context_line":"            \"driver_handles_share_servers\": dhss,"},{"line_number":773,"context_line":"        }"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        optional \u003d {"},{"line_number":776,"context_line":"            \"snapshot_support\": snapshot_support,"},{"line_number":777,"context_line":"            \"create_share_from_snapshot_support\": create_from_snapshot_support,"},{"line_number":778,"context_line":"            \"revert_to_snapshot_support\": revert_to_snapshot_support,"},{"line_number":779,"context_line":"            \"mount_snapshot_support\": mount_snapshot_support,"},{"line_number":780,"context_line":"        }"},{"line_number":781,"context_line":"        # NOTE(gouthamr): In micro-versions \u003c 2.24, snapshot_support is a"},{"line_number":782,"context_line":"        # required extra-spec"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_878de7d4","line":779,"range":{"start_line":767,"start_character":0,"end_line":779,"end_character":61},"in_reply_to":"3a461143_871a47c4","updated":"2017-02-01 10:11:40.000000000","message":"I noticed that an alternative solution is to remove revert_to_snapshot_support from here so it becomes a \"don\u0027t care\" when creating this type. I just checked where it is used, and I believe the config option can be removed. I will post an alternative fix.","commit_id":"f9be80ee19970a98d464e4dcc92e4e76c39b07a3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cfbdf10cad3943ba208777837bcb9383026c13be","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        create_from_snapshot_support \u003d six.text_type("},{"line_number":765,"context_line":"            CONF.share.capability_create_share_from_snapshot_support)"},{"line_number":766,"context_line":"        revert_to_snapshot_support \u003d six.text_type("},{"line_number":767,"context_line":"            CONF.share.capability_revert_to_snapshot_support)"},{"line_number":768,"context_line":"        mount_snapshot_support \u003d six.text_type("},{"line_number":769,"context_line":"            CONF.share.capability_mount_snapshot_support)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        extra_specs_dict \u003d {"},{"line_number":772,"context_line":"            \"driver_handles_share_servers\": dhss,"},{"line_number":773,"context_line":"        }"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        optional \u003d {"},{"line_number":776,"context_line":"            \"snapshot_support\": snapshot_support,"},{"line_number":777,"context_line":"            \"create_share_from_snapshot_support\": create_from_snapshot_support,"},{"line_number":778,"context_line":"            \"revert_to_snapshot_support\": revert_to_snapshot_support,"},{"line_number":779,"context_line":"            \"mount_snapshot_support\": mount_snapshot_support,"},{"line_number":780,"context_line":"        }"},{"line_number":781,"context_line":"        # NOTE(gouthamr): In micro-versions \u003c 2.24, snapshot_support is a"},{"line_number":782,"context_line":"        # required extra-spec"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_871a47c4","line":779,"range":{"start_line":767,"start_character":0,"end_line":779,"end_character":61},"in_reply_to":"3a461143_8a2ed9a2","updated":"2017-02-01 10:04:29.000000000","message":"Goutham, see the 2 HNAS-CI runs here: https://review.openstack.org/#/c/426762/ \n\nSeveral tests use this function and if these options are not used, it results in \"No valid host found\" when creating a share.","commit_id":"f9be80ee19970a98d464e4dcc92e4e76c39b07a3"}]}
