)]}'
{"manila/tests/share/test_manager.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"1e534a4d9b05fee184dc6ed822a35361708cfa0f","unresolved":false,"context_lines":[{"line_number":5087,"context_line":"            utils.IsAMatcher(context.RequestContext), snapshot_id)"},{"line_number":5088,"context_line":"        if export_locations:"},{"line_number":5089,"context_line":"            for i in range(0, 2):"},{"line_number":5090,"context_line":"                export_locations[i]["},{"line_number":5091,"context_line":"                    \u0027share_snapshot_instance_id\u0027] \u003d snapshot.instance[\u0027id\u0027]"},{"line_number":5092,"context_line":"            mock_export_update.assert_has_calls(["},{"line_number":5093,"context_line":"                mock.call(utils.IsAMatcher(context.RequestContext),"},{"line_number":5094,"context_line":"                          export_locations[0]),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_5bdf7339","line":5091,"range":{"start_line":5090,"start_character":16,"end_line":5091,"end_character":75},"updated":"2017-01-31 18:08:16.000000000","message":"declare a variable to \u0027snapshot.instance[\u0027id\u0027], so you dont need to break this line","commit_id":"341d3451ba9761f81c75a9bee826cd7243bec9bf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"89ea49ac37c930495fdf37b3ff61cc3b97f6f32a","unresolved":false,"context_lines":[{"line_number":5087,"context_line":"            utils.IsAMatcher(context.RequestContext), snapshot_id)"},{"line_number":5088,"context_line":"        if export_locations:"},{"line_number":5089,"context_line":"            for i in range(0, 2):"},{"line_number":5090,"context_line":"                export_locations[i]["},{"line_number":5091,"context_line":"                    \u0027share_snapshot_instance_id\u0027] \u003d snapshot.instance[\u0027id\u0027]"},{"line_number":5092,"context_line":"            mock_export_update.assert_has_calls(["},{"line_number":5093,"context_line":"                mock.call(utils.IsAMatcher(context.RequestContext),"},{"line_number":5094,"context_line":"                          export_locations[0]),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_8cfb6378","line":5091,"range":{"start_line":5090,"start_character":16,"end_line":5091,"end_character":75},"in_reply_to":"3a461143_5bdf7339","updated":"2017-01-31 19:31:34.000000000","message":"Done","commit_id":"341d3451ba9761f81c75a9bee826cd7243bec9bf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a3aec635c4ca5862bd25a98ff2e846493c76a123","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"        self.share_manager.driver.create_snapshot.assert_called_once_with("},{"line_number":1461,"context_line":"            self.context, expected_snapshot_instance_dict, share_server\u003dNone)"},{"line_number":1462,"context_line":""},{"line_number":1463,"context_line":"    @ddt.data({}, {\u0027export_locations\u0027: ["},{"line_number":1464,"context_line":"        {\u0027path\u0027: \u0027/path1\u0027, \u0027is_admin_only\u0027: True},"},{"line_number":1465,"context_line":"        {\u0027path\u0027: \u0027/path2\u0027, \u0027is_admin_only\u0027: False}"},{"line_number":1466,"context_line":"    ]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_ce4f1832","line":1463,"range":{"start_line":1463,"start_character":14,"end_line":1463,"end_character":17},"updated":"2017-01-31 23:41:59.000000000","message":"It might be better to split this into 2 tests. You probably saved some lines of code though.","commit_id":"fa3fa5c0d8b60028486631ba8c78fa13d7833869"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8f763205e96ceba9be580ea26430794a18fc2b98","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"        self.share_manager.driver.create_snapshot.assert_called_once_with("},{"line_number":1461,"context_line":"            self.context, expected_snapshot_instance_dict, share_server\u003dNone)"},{"line_number":1462,"context_line":""},{"line_number":1463,"context_line":"    @ddt.data({}, {\u0027export_locations\u0027: ["},{"line_number":1464,"context_line":"        {\u0027path\u0027: \u0027/path1\u0027, \u0027is_admin_only\u0027: True},"},{"line_number":1465,"context_line":"        {\u0027path\u0027: \u0027/path2\u0027, \u0027is_admin_only\u0027: False}"},{"line_number":1466,"context_line":"    ]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_2c2173b5","line":1463,"range":{"start_line":1463,"start_character":14,"end_line":1463,"end_character":17},"in_reply_to":"3a461143_ce4f1832","updated":"2017-02-01 12:57:00.000000000","message":"oh I think I get what you mean, need to validate the case where driver returns export locations either way, the test is assuming only the case where both are True or both are False.","commit_id":"fa3fa5c0d8b60028486631ba8c78fa13d7833869"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9e3091303d392b3516cc87d5ea8931f0a96b83a5","unresolved":false,"context_lines":[{"line_number":1517,"context_line":"                mock.call(utils.IsAMatcher(context.RequestContext),"},{"line_number":1518,"context_line":"                          export_locations[1]),"},{"line_number":1519,"context_line":"            ])"},{"line_number":1520,"context_line":"        else:"},{"line_number":1521,"context_line":"            mock_export_update.assert_not_called()"},{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"    @ddt.data(exception.ShareSnapshotIsBusy(snapshot_name\u003d\u0027fake_name\u0027),"},{"line_number":1524,"context_line":"              exception.NotFound())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_ea24b260","line":1521,"range":{"start_line":1520,"start_character":8,"end_line":1521,"end_character":50},"updated":"2017-02-01 10:21:29.000000000","message":"here it confirms it is being ignored","commit_id":"fa3fa5c0d8b60028486631ba8c78fa13d7833869"}],"releasenotes/notes/bug-1660686-snapshot-export-locations-mount-not-supported-cdc2f5a3b57a9319.yaml":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"1e534a4d9b05fee184dc6ed822a35361708cfa0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed snapshot export locations being created for "},{"line_number":4,"context_line":"    shares with property mount_snapshot_support\u003dFalse."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_7b442f49","line":3,"updated":"2017-01-31 18:08:16.000000000","message":"trailing","commit_id":"341d3451ba9761f81c75a9bee826cd7243bec9bf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"89ea49ac37c930495fdf37b3ff61cc3b97f6f32a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed snapshot export locations being created for "},{"line_number":4,"context_line":"    shares with property mount_snapshot_support\u003dFalse."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_4cdc1b46","line":3,"in_reply_to":"3a461143_7b442f49","updated":"2017-01-31 19:31:34.000000000","message":"Done","commit_id":"341d3451ba9761f81c75a9bee826cd7243bec9bf"}]}