)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2aa304bab4bb7adf382c189e917e8d84979966","unresolved":false,"context_lines":[{"line_number":10,"context_line":"was being shown, thus the user could get confused as to which"},{"line_number":11,"context_line":"export location to choose when mounting his share, since only"},{"line_number":12,"context_line":"the source could be mounted."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch addresses this by filtering the destination"},{"line_number":15,"context_line":"export location out."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_2a46c57a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2017-02-01 01:49:49.000000000","message":"I understand that you\u0027re trying to fix an API bug. Please add an APIImpact\n\nFor situations like this, we have bumped the API version, however, because it is related to an experimental API, we can bend rules i guess.","commit_id":"f8a5609be3df6fad15f7253b1c8bf853051ad58d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"de71fe3e264f00a6a026f51178e51282fee1cabc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"was being shown, thus the user could get confused as to which"},{"line_number":11,"context_line":"export location to choose when mounting his share, since only"},{"line_number":12,"context_line":"the source could be mounted."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch addresses this by filtering the destination"},{"line_number":15,"context_line":"export location out."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_e958328d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"in_reply_to":"3a461143_2a46c57a","updated":"2017-02-01 16:27:34.000000000","message":"Done","commit_id":"f8a5609be3df6fad15f7253b1c8bf853051ad58d"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"69a44f29c19f77c42c8baa4c727d01d6bf54ec10","unresolved":false,"context_lines":[{"line_number":2645,"context_line":"def share_export_locations_get_by_share_id(context, share_id,"},{"line_number":2646,"context_line":"                                           include_admin_only\u003dTrue):"},{"line_number":2647,"context_line":"    share \u003d share_get(context, share_id)"},{"line_number":2648,"context_line":"    ids \u003d [instance.id for instance in share.instances"},{"line_number":2649,"context_line":"           if instance[\u0027status\u0027] !\u003d constants.STATUS_MIGRATING_TO]"},{"line_number":2650,"context_line":"    rows \u003d _share_export_locations_get("},{"line_number":2651,"context_line":"        context, ids, include_admin_only\u003dinclude_admin_only)"},{"line_number":2652,"context_line":"    return rows"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_6a752dc9","line":2649,"range":{"start_line":2648,"start_character":10,"end_line":2649,"end_character":66},"updated":"2017-02-01 01:48:45.000000000","message":"hiding something like this in the database layer is a bad idea. I suggest performing this outside, i.e, manila/api/v2/share_export_locations.py\n\nor:\n\nset this kwarg:\n\n disallow_migrating\u003dFalse\n\n if disallow_migration_destination:\n    remove the migrating-to-instance from the query","commit_id":"f8a5609be3df6fad15f7253b1c8bf853051ad58d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"de71fe3e264f00a6a026f51178e51282fee1cabc","unresolved":false,"context_lines":[{"line_number":2645,"context_line":"def share_export_locations_get_by_share_id(context, share_id,"},{"line_number":2646,"context_line":"                                           include_admin_only\u003dTrue):"},{"line_number":2647,"context_line":"    share \u003d share_get(context, share_id)"},{"line_number":2648,"context_line":"    ids \u003d [instance.id for instance in share.instances"},{"line_number":2649,"context_line":"           if instance[\u0027status\u0027] !\u003d constants.STATUS_MIGRATING_TO]"},{"line_number":2650,"context_line":"    rows \u003d _share_export_locations_get("},{"line_number":2651,"context_line":"        context, ids, include_admin_only\u003dinclude_admin_only)"},{"line_number":2652,"context_line":"    return rows"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_69760208","line":2649,"range":{"start_line":2648,"start_character":10,"end_line":2649,"end_character":66},"in_reply_to":"3a461143_6a752dc9","updated":"2017-02-01 16:27:34.000000000","message":"Done","commit_id":"f8a5609be3df6fad15f7253b1c8bf853051ad58d"}],"releasenotes/notes/bug-1660726-migration-export-locations-5670734670435015.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98abeeda1bc29ce171d20919d59f6e77a610cfc1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed unusable destination share instance export location"},{"line_number":4,"context_line":"    being shown during migration of a share."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_ca338112","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":44},"updated":"2017-02-01 01:50:51.000000000","message":"perhaps:\n\n Export locations pertaining to migration destinations are no longer shown until migration is complete.\n\n?","commit_id":"f8a5609be3df6fad15f7253b1c8bf853051ad58d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"de71fe3e264f00a6a026f51178e51282fee1cabc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed unusable destination share instance export location"},{"line_number":4,"context_line":"    being shown during migration of a share."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_49694625","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":44},"in_reply_to":"3a461143_ca338112","updated":"2017-02-01 16:27:34.000000000","message":"Done","commit_id":"f8a5609be3df6fad15f7253b1c8bf853051ad58d"}]}