)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"eec213f7aea093f32fe4a1b771f8902fdea16602","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Miriam Yumi \u003cmiriamyume@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-01 07:54:08 -0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HNAS: Fix managed snapshots not being mount"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When managing snapshots, the driver is not checking if the export"},{"line_number":10,"context_line":"exists on backend."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_8a432eae","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":43},"updated":"2017-02-01 10:36:56.000000000","message":"mounted","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"d0621a433be3d463fbc0e14415f09758605dec89","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Miriam Yumi \u003cmiriamyume@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-01 07:54:08 -0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HNAS: Fix managed snapshots not being mount"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When managing snapshots, the driver is not checking if the export"},{"line_number":10,"context_line":"exists on backend."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_337627d9","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":43},"in_reply_to":"3a461143_8a432eae","updated":"2017-02-01 16:22:50.000000000","message":"Done","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"}],"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"0fe5b9367fb5547220817373bd63973e45fba104","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"        \"\"\"Ensure that snapshot is exported."},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"        :param snapshot: Snapshot that will be checked."},{"line_number":1124,"context_line":"        :param hnas_snapshot_id: HNAS ID of snapshot that will be checked."},{"line_number":1125,"context_line":"        :returns: Returns a list of dicts containing the snapshot\u0027s export"},{"line_number":1126,"context_line":"            locations."},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        \"\"\""},{"line_number":1129,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_4185a0ab","line":1126,"range":{"start_line":1124,"start_character":9,"end_line":1126,"end_character":22},"updated":"2017-02-01 15:52:18.000000000","message":"following other functions docstring pattern: \n- add an empty line before returns:\n- delete empty line before \"\"\"","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"d0621a433be3d463fbc0e14415f09758605dec89","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"        \"\"\"Ensure that snapshot is exported."},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"        :param snapshot: Snapshot that will be checked."},{"line_number":1124,"context_line":"        :param hnas_snapshot_id: HNAS ID of snapshot that will be checked."},{"line_number":1125,"context_line":"        :returns: Returns a list of dicts containing the snapshot\u0027s export"},{"line_number":1126,"context_line":"            locations."},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        \"\"\""},{"line_number":1129,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_76617dd3","line":1126,"range":{"start_line":1124,"start_character":9,"end_line":1126,"end_character":22},"in_reply_to":"3a461143_4185a0ab","updated":"2017-02-01 16:22:50.000000000","message":"Done","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"0fe5b9367fb5547220817373bd63973e45fba104","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        try:"},{"line_number":1203,"context_line":"            self._ensure_snapshot(snapshot, hnas_snapshot_id)"},{"line_number":1204,"context_line":"        except exception.HNASItemNotFoundException:"},{"line_number":1205,"context_line":"            LOG.warning(_LW(\"Export does not exist, creating a new one.\"))"},{"line_number":1206,"context_line":"            self._create_export(hnas_share_id,"},{"line_number":1207,"context_line":"                                snapshot[\u0027share\u0027][\u0027share_proto\u0027],"},{"line_number":1208,"context_line":"                                snapshot_id\u003dhnas_snapshot_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_1345ab16","line":1205,"range":{"start_line":1205,"start_character":28,"end_line":1205,"end_character":72},"updated":"2017-02-01 15:52:18.000000000","message":"Add the snapshot id in this LOG","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"d0621a433be3d463fbc0e14415f09758605dec89","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        try:"},{"line_number":1203,"context_line":"            self._ensure_snapshot(snapshot, hnas_snapshot_id)"},{"line_number":1204,"context_line":"        except exception.HNASItemNotFoundException:"},{"line_number":1205,"context_line":"            LOG.warning(_LW(\"Export does not exist, creating a new one.\"))"},{"line_number":1206,"context_line":"            self._create_export(hnas_share_id,"},{"line_number":1207,"context_line":"                                snapshot[\u0027share\u0027][\u0027share_proto\u0027],"},{"line_number":1208,"context_line":"                                snapshot_id\u003dhnas_snapshot_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_f6f1ed02","line":1205,"range":{"start_line":1205,"start_character":28,"end_line":1205,"end_character":72},"in_reply_to":"3a461143_1345ab16","updated":"2017-02-01 16:22:50.000000000","message":"Done","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"eec213f7aea093f32fe4a1b771f8902fdea16602","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"                                snapshot_id\u003dhnas_snapshot_id)"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1211,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1212,"context_line":"            export_locations \u003d self._get_export_locations("},{"line_number":1213,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1214,"context_line":"                is_snapshot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_4a75c6c8","line":1211,"range":{"start_line":1211,"start_character":8,"end_line":1211,"end_character":59},"updated":"2017-02-01 10:36:56.000000000","message":"this should be the top statement, _ensure_snapshot and creating an export location should be done only if this condition is met.","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"d0621a433be3d463fbc0e14415f09758605dec89","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"                                snapshot_id\u003dhnas_snapshot_id)"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1211,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1212,"context_line":"            export_locations \u003d self._get_export_locations("},{"line_number":1213,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1214,"context_line":"                is_snapshot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_d34de39a","line":1211,"range":{"start_line":1211,"start_character":8,"end_line":1211,"end_character":59},"in_reply_to":"3a461143_4a75c6c8","updated":"2017-02-01 16:22:50.000000000","message":"Done","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"0fe5b9367fb5547220817373bd63973e45fba104","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"                                snapshot_id\u003dhnas_snapshot_id)"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1211,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1212,"context_line":"            export_locations \u003d self._get_export_locations("},{"line_number":1213,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1214,"context_line":"                is_snapshot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_b393f7ff","line":1211,"range":{"start_line":1211,"start_character":8,"end_line":1211,"end_character":59},"in_reply_to":"3a461143_4a75c6c8","updated":"2017-02-01 15:52:18.000000000","message":"_ensure_snapshot should run only when mount_snapshot_supp\u003dTrue?  Ensure still checks protocol and fs status, and the export case is handled.","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"d0621a433be3d463fbc0e14415f09758605dec89","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"                                snapshot_id\u003dhnas_snapshot_id)"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1211,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1212,"context_line":"            export_locations \u003d self._get_export_locations("},{"line_number":1213,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1214,"context_line":"                is_snapshot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_a9d1ca31","line":1211,"range":{"start_line":1211,"start_character":8,"end_line":1211,"end_character":59},"in_reply_to":"3a461143_b393f7ff","updated":"2017-02-01 16:22:50.000000000","message":"Yes, _ensure_snapshot checks more than just the export, that\u0027s why I was calling it before checking the mount_snapshot_support and handling mount support inside the _ensure too.\nAnyway, I\u0027ve changed it in patch set #2...","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"38329cbd655f9abb770df36e742952228cd64882","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"                                snapshot_id\u003dhnas_snapshot_id)"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1211,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1212,"context_line":"            export_locations \u003d self._get_export_locations("},{"line_number":1213,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1214,"context_line":"                is_snapshot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_8ce33c33","line":1211,"range":{"start_line":1211,"start_character":8,"end_line":1211,"end_character":59},"in_reply_to":"3a461143_d34de39a","updated":"2017-02-01 16:38:22.000000000","message":"Oh right, we discussed about this offline, that we would always invoke _check_protocol and check_fs_mounted regardless of mount_snapshot_support, and then, within _ensure_snapshot, check mount_snapshot_support and check the export locations. Sorry I had forgotten about that.","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"689f759cbdb53f0f67b2e56b0926491dcc368ca7","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        :param snapshot: Snapshot that will be checked."},{"line_number":1124,"context_line":"        :param hnas_snapshot_id: HNAS ID of snapshot that will be checked."},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        :returns: Returns a list of dicts containing the snapshot\u0027s export"},{"line_number":1127,"context_line":"            locations."},{"line_number":1128,"context_line":"        \"\"\""},{"line_number":1129,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027],"},{"line_number":1130,"context_line":"                             snapshot[\u0027share\u0027][\u0027share_proto\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_2c124859","line":1127,"range":{"start_line":1126,"start_character":68,"end_line":1127,"end_character":21},"updated":"2017-02-01 16:38:42.000000000","message":"\"...or None if mount_snapshot_support is False.\" (see response to PS #1)","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"01fd432a2bd0b06faf8de38461a10242d883122f","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        :param snapshot: Snapshot that will be checked."},{"line_number":1124,"context_line":"        :param hnas_snapshot_id: HNAS ID of snapshot that will be checked."},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        :returns: Returns a list of dicts containing the snapshot\u0027s export"},{"line_number":1127,"context_line":"            locations."},{"line_number":1128,"context_line":"        \"\"\""},{"line_number":1129,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027],"},{"line_number":1130,"context_line":"                             snapshot[\u0027share\u0027][\u0027share_proto\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_02e713ad","line":1127,"range":{"start_line":1126,"start_character":68,"end_line":1127,"end_character":21},"in_reply_to":"3a461143_2c124859","updated":"2017-02-01 17:56:41.000000000","message":"Done","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"689f759cbdb53f0f67b2e56b0926491dcc368ca7","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027],"},{"line_number":1130,"context_line":"                             snapshot[\u0027share\u0027][\u0027share_proto\u0027])"},{"line_number":1131,"context_line":"        self._check_fs_mounted()"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"        if snapshot[\u0027share\u0027][\u0027share_proto\u0027].lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":1134,"context_line":"            self.hnas.check_export(hnas_snapshot_id, is_snapshot\u003dTrue)"},{"line_number":1135,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_ac72b8ae","line":1132,"updated":"2017-02-01 16:38:42.000000000","message":"add condition here","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"01fd432a2bd0b06faf8de38461a10242d883122f","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027],"},{"line_number":1130,"context_line":"                             snapshot[\u0027share\u0027][\u0027share_proto\u0027])"},{"line_number":1131,"context_line":"        self._check_fs_mounted()"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"        if snapshot[\u0027share\u0027][\u0027share_proto\u0027].lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":1134,"context_line":"            self.hnas.check_export(hnas_snapshot_id, is_snapshot\u003dTrue)"},{"line_number":1135,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_22ec0f8f","line":1132,"in_reply_to":"3a461143_ac72b8ae","updated":"2017-02-01 17:56:41.000000000","message":"Done","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"689f759cbdb53f0f67b2e56b0926491dcc368ca7","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    def ensure_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":1145,"context_line":"        \"\"\"Ensure that share is exported."},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        :param context: The `context.RequestContext` object for the request"},{"line_number":1148,"context_line":"        :param snapshot: Snapshot that will be checked."},{"line_number":1149,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":1150,"context_line":"            Not used by this driver."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_2c3968d9","line":1147,"range":{"start_line":1147,"start_character":74,"end_line":1147,"end_character":75},"updated":"2017-02-01 16:38:42.000000000","message":"period","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"01fd432a2bd0b06faf8de38461a10242d883122f","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    def ensure_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":1145,"context_line":"        \"\"\"Ensure that share is exported."},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        :param context: The `context.RequestContext` object for the request"},{"line_number":1148,"context_line":"        :param snapshot: Snapshot that will be checked."},{"line_number":1149,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":1150,"context_line":"            Not used by this driver."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_42011b39","line":1147,"range":{"start_line":1147,"start_character":74,"end_line":1147,"end_character":75},"in_reply_to":"3a461143_2c3968d9","updated":"2017-02-01 17:56:41.000000000","message":"Done","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"689f759cbdb53f0f67b2e56b0926491dcc368ca7","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmsg)"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1255,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1256,"context_line":"            try:"},{"line_number":1257,"context_line":"                self._ensure_snapshot(snapshot, hnas_snapshot_id)"},{"line_number":1258,"context_line":"            except exception.HNASItemNotFoundException:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_c93456fd","line":1255,"range":{"start_line":1255,"start_character":8,"end_line":1255,"end_character":59},"updated":"2017-02-01 16:38:42.000000000","message":"see response to PS #1","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"01fd432a2bd0b06faf8de38461a10242d883122f","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmsg)"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1255,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1256,"context_line":"            try:"},{"line_number":1257,"context_line":"                self._ensure_snapshot(snapshot, hnas_snapshot_id)"},{"line_number":1258,"context_line":"            except exception.HNASItemNotFoundException:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_82fb0347","line":1255,"range":{"start_line":1255,"start_character":8,"end_line":1255,"end_character":59},"in_reply_to":"3a461143_c93456fd","updated":"2017-02-01 17:56:41.000000000","message":"Done","commit_id":"e164ad70fea55c77bf9c3322542577b4cdc45d81"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"59dca6a889c9d78f7cb996c4af2f67147eb7a492","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        return export_list"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"    def ensure_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":1147,"context_line":"        \"\"\"Ensure that share is exported."},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        :param context: The `context.RequestContext` object for the request."},{"line_number":1150,"context_line":"        :param snapshot: Snapshot that will be checked."}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_3d719078","line":1147,"range":{"start_line":1147,"start_character":23,"end_line":1147,"end_character":28},"updated":"2017-02-01 18:06:35.000000000","message":"snapshot","commit_id":"13030422ae3626c29ca6af058d927d483a2c7720"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"8d77b8e10f25d97688e5ed5fa8604d875f9513ea","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        return export_list"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"    def ensure_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":1147,"context_line":"        \"\"\"Ensure that share is exported."},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        :param context: The `context.RequestContext` object for the request."},{"line_number":1150,"context_line":"        :param snapshot: Snapshot that will be checked."}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_dda40cbb","line":1147,"range":{"start_line":1147,"start_character":23,"end_line":1147,"end_character":28},"in_reply_to":"3a461143_3d719078","updated":"2017-02-01 18:09:27.000000000","message":"Done","commit_id":"13030422ae3626c29ca6af058d927d483a2c7720"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"38c9858d7d1330f256ac9d36a7adff5eda45961e","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                self.hnas.check_cifs(hnas_snapshot_id)"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"            export_list \u003d self._get_export_locations("},{"line_number":1141,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1142,"context_line":"                is_snapshot\u003dTrue)"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        return export_list"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_9ef43088","line":1141,"range":{"start_line":1141,"start_character":50,"end_line":1141,"end_character":66},"updated":"2017-02-02 00:45:37.000000000","message":"should be separate line when they don\u0027t fit on one line","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"95f36d1593a6a9df70eb4eb90885d2c84db488df","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                self.hnas.check_cifs(hnas_snapshot_id)"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"            export_list \u003d self._get_export_locations("},{"line_number":1141,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1142,"context_line":"                is_snapshot\u003dTrue)"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        return export_list"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_2a55af1c","line":1141,"range":{"start_line":1141,"start_character":50,"end_line":1141,"end_character":66},"in_reply_to":"3a461143_9ef43088","updated":"2017-02-02 10:59:19.000000000","message":"Done","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"38c9858d7d1330f256ac9d36a7adff5eda45961e","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1267,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1268,"context_line":"            export_locations \u003d self._get_export_locations("},{"line_number":1269,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1270,"context_line":"                is_snapshot\u003dTrue)"},{"line_number":1271,"context_line":"            output[\u0027export_locations\u0027] \u003d export_locations"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_5eeba8b0","line":1269,"range":{"start_line":1269,"start_character":50,"end_line":1269,"end_character":66},"updated":"2017-02-02 00:45:37.000000000","message":"param should be on separate line when they don\u0027t all fit on one line","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"95f36d1593a6a9df70eb4eb90885d2c84db488df","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        output \u003d {\u0027size\u0027: snapshot_size}"},{"line_number":1267,"context_line":"        if snapshot[\u0027share\u0027].get(\u0027mount_snapshot_support\u0027):"},{"line_number":1268,"context_line":"            export_locations \u003d self._get_export_locations("},{"line_number":1269,"context_line":"                snapshot[\u0027share\u0027][\u0027share_proto\u0027], hnas_snapshot_id,"},{"line_number":1270,"context_line":"                is_snapshot\u003dTrue)"},{"line_number":1271,"context_line":"            output[\u0027export_locations\u0027] \u003d export_locations"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_aa3fdfd4","line":1269,"range":{"start_line":1269,"start_character":50,"end_line":1269,"end_character":66},"in_reply_to":"3a461143_5eeba8b0","updated":"2017-02-02 10:59:19.000000000","message":"Done","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c221abcd7983c0a0a617f4fdfeaa559c960a10c6","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"            Not used by this driver."},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        :returns: Returns a list of dicts containing the EVS IP concatenated"},{"line_number":1156,"context_line":"            with the path of share in the filesystem or None if"},{"line_number":1157,"context_line":"            mount_snapshot_support is False."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"            Example for NFS::"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_3a641a48","line":1156,"range":{"start_line":1156,"start_character":29,"end_line":1156,"end_character":34},"updated":"2017-02-02 11:21:43.000000000","message":"snapshot","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"36fc06c4e7a7021e1c3b4506ba1a585cb927b972","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"            Not used by this driver."},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        :returns: Returns a list of dicts containing the EVS IP concatenated"},{"line_number":1156,"context_line":"            with the path of share in the filesystem or None if"},{"line_number":1157,"context_line":"            mount_snapshot_support is False."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"            Example for NFS::"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_c525f25c","line":1156,"range":{"start_line":1156,"start_character":29,"end_line":1156,"end_character":34},"in_reply_to":"3a461143_3a641a48","updated":"2017-02-02 14:25:47.000000000","message":"+1","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"1ccff15c7167f7682b459b2b98b7dfc3a663317a","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"            Not used by this driver."},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        :returns: Returns a list of dicts containing the EVS IP concatenated"},{"line_number":1156,"context_line":"            with the path of share in the filesystem or None if"},{"line_number":1157,"context_line":"            mount_snapshot_support is False."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"            Example for NFS::"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_eb1c866c","line":1156,"range":{"start_line":1156,"start_character":29,"end_line":1156,"end_character":34},"in_reply_to":"3a461143_3a641a48","updated":"2017-02-02 15:48:55.000000000","message":"Done","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"1ccff15c7167f7682b459b2b98b7dfc3a663317a","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"            Not used by this driver."},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        :returns: Returns a list of dicts containing the EVS IP concatenated"},{"line_number":1156,"context_line":"            with the path of share in the filesystem or None if"},{"line_number":1157,"context_line":"            mount_snapshot_support is False."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"            Example for NFS::"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_f6c38288","line":1156,"range":{"start_line":1156,"start_character":29,"end_line":1156,"end_character":34},"in_reply_to":"3a461143_c525f25c","updated":"2017-02-02 15:48:55.000000000","message":"Done","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"36fc06c4e7a7021e1c3b4506ba1a585cb927b972","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        hnas_snapshot_id \u003d self._get_hnas_snapshot_id(snapshot)"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"        export_list \u003d self._ensure_snapshot(snapshot, hnas_snapshot_id)"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"        LOG.debug(\"Snapshot ensured in HNAS: %(snap)s, protocol %(proto)s.\","},{"line_number":1197,"context_line":"                  {\u0027snap\u0027: snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_25f6b6d7","line":1194,"range":{"start_line":1194,"start_character":27,"end_line":1194,"end_character":43},"updated":"2017-02-02 14:25:47.000000000","message":"\"_ensure_snapshot\" does not mean \"return me list of export locations\" at all. So, I guess it should be renamed to something like following: \"_get_snapshot_export_locations\" and you can keep existing validation checks there.","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e8d9c6c8f6b6a3046b8c440b9a9ee3df568b555a","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        hnas_snapshot_id \u003d self._get_hnas_snapshot_id(snapshot)"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"        export_list \u003d self._ensure_snapshot(snapshot, hnas_snapshot_id)"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"        LOG.debug(\"Snapshot ensured in HNAS: %(snap)s, protocol %(proto)s.\","},{"line_number":1197,"context_line":"                  {\u0027snap\u0027: snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_8bc69b14","line":1194,"range":{"start_line":1194,"start_character":27,"end_line":1194,"end_character":43},"in_reply_to":"3a461143_25f6b6d7","updated":"2017-02-02 15:13:54.000000000","message":"Valeriy, right now main purpose of ensure_snapshot is ensuring the snapshot checking if the snapshot is accessible, while raising any exceptions if it is not, so it checks if the filesystem is mounted and if export exists (if mount_snapshot_support). I\u0027d say the major problem is the Docstring and the return value, not the method name... but we left it this way for consistency with ensure_share, which may be renamed/split in Pike, and if so, we will follow with ensure_snapshot as much as it makes sense.","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"}],"manila/share/drivers/hitachi/hnas/ssh.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"0fe5b9367fb5547220817373bd63973e45fba104","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                                                   quota.usage_unit)"},{"line_number":476,"context_line":"            return bytes_usage / units.Gi"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def _get_share_export(self, share_id, is_snapshot\u003dFalse):"},{"line_number":479,"context_line":"        if is_snapshot:"},{"line_number":480,"context_line":"            share_id \u003d \u0027/snapshots/\u0027 + share_id"},{"line_number":481,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_d3a403bb","line":478,"range":{"start_line":478,"start_character":8,"end_line":478,"end_character":25},"updated":"2017-02-01 15:52:18.000000000","message":"we can rename this function :)","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"d0621a433be3d463fbc0e14415f09758605dec89","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                                                   quota.usage_unit)"},{"line_number":476,"context_line":"            return bytes_usage / units.Gi"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def _get_share_export(self, share_id, is_snapshot\u003dFalse):"},{"line_number":479,"context_line":"        if is_snapshot:"},{"line_number":480,"context_line":"            share_id \u003d \u0027/snapshots/\u0027 + share_id"},{"line_number":481,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_36a2959b","line":478,"range":{"start_line":478,"start_character":8,"end_line":478,"end_character":25},"in_reply_to":"3a461143_d3a403bb","updated":"2017-02-01 16:22:50.000000000","message":"Done","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"0fe5b9367fb5547220817373bd63973e45fba104","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def _get_share_export(self, share_id, is_snapshot\u003dFalse):"},{"line_number":479,"context_line":"        if is_snapshot:"},{"line_number":480,"context_line":"            share_id \u003d \u0027/snapshots/\u0027 + share_id"},{"line_number":481,"context_line":"        else:"},{"line_number":482,"context_line":"            share_id \u003d \u0027/shares/\u0027 + share_id"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_33a2a79b","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":20},"updated":"2017-02-01 15:52:18.000000000","message":"s/share_id/name","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"d0621a433be3d463fbc0e14415f09758605dec89","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def _get_share_export(self, share_id, is_snapshot\u003dFalse):"},{"line_number":479,"context_line":"        if is_snapshot:"},{"line_number":480,"context_line":"            share_id \u003d \u0027/snapshots/\u0027 + share_id"},{"line_number":481,"context_line":"        else:"},{"line_number":482,"context_line":"            share_id \u003d \u0027/shares/\u0027 + share_id"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_d6b951cd","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":20},"in_reply_to":"3a461143_33a2a79b","updated":"2017-02-01 16:22:50.000000000","message":"Done","commit_id":"ae190f5f965a4927cf4fe3fabc08c0fcf304273d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"38c9858d7d1330f256ac9d36a7adff5eda45961e","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":489,"context_line":"            if \u0027does not exist\u0027 in e.stderr:"},{"line_number":490,"context_line":"                msg \u003d _(\"Export %(share)s was not found in EVS \""},{"line_number":491,"context_line":"                        \"%(evs_id)s.\") % {\u0027share\u0027: name,"},{"line_number":492,"context_line":"                                          \u0027evs_id\u0027: self.evs_id}"},{"line_number":493,"context_line":"                raise exception.HNASItemNotFoundException(msg\u003dmsg)"},{"line_number":494,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_3e341c49","line":491,"range":{"start_line":491,"start_character":43,"end_line":491,"end_character":48},"updated":"2017-02-02 00:45:37.000000000","message":"probably should change \u0027share\u0027.  Perhaps \u0027name\u0027","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"95f36d1593a6a9df70eb4eb90885d2c84db488df","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":489,"context_line":"            if \u0027does not exist\u0027 in e.stderr:"},{"line_number":490,"context_line":"                msg \u003d _(\"Export %(share)s was not found in EVS \""},{"line_number":491,"context_line":"                        \"%(evs_id)s.\") % {\u0027share\u0027: name,"},{"line_number":492,"context_line":"                                          \u0027evs_id\u0027: self.evs_id}"},{"line_number":493,"context_line":"                raise exception.HNASItemNotFoundException(msg\u003dmsg)"},{"line_number":494,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_8a114360","line":491,"range":{"start_line":491,"start_character":43,"end_line":491,"end_character":48},"in_reply_to":"3a461143_3e341c49","updated":"2017-02-02 10:59:19.000000000","message":"Done","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"}],"manila/tests/share/drivers/hitachi/hnas/test_driver.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"38c9858d7d1330f256ac9d36a7adff5eda45961e","unresolved":false,"context_lines":[{"line_number":979,"context_line":"        ssh.HNASSSHBackend.check_snapshot.assert_called_with("},{"line_number":980,"context_line":"            \u0027/snapshots/aa4a7710-f326-41fb-ad18-b4ad587fc87a\u0027"},{"line_number":981,"context_line":"            \u0027/snapshot18-05-2106\u0027)"},{"line_number":982,"context_line":"        self.assertEqual(20, out[\u0027size\u0027])"},{"line_number":983,"context_line":"        self.assertTrue(self.mock_log.debug.called)"},{"line_number":984,"context_line":"        self.assertTrue(self.mock_log.info.called)"},{"line_number":985,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_be1f2cb6","line":982,"updated":"2017-02-02 00:45:37.000000000","message":"missing assert to see if _ensure_snapshot was called as expected","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"95f36d1593a6a9df70eb4eb90885d2c84db488df","unresolved":false,"context_lines":[{"line_number":979,"context_line":"        ssh.HNASSSHBackend.check_snapshot.assert_called_with("},{"line_number":980,"context_line":"            \u0027/snapshots/aa4a7710-f326-41fb-ad18-b4ad587fc87a\u0027"},{"line_number":981,"context_line":"            \u0027/snapshot18-05-2106\u0027)"},{"line_number":982,"context_line":"        self.assertEqual(20, out[\u0027size\u0027])"},{"line_number":983,"context_line":"        self.assertTrue(self.mock_log.debug.called)"},{"line_number":984,"context_line":"        self.assertTrue(self.mock_log.info.called)"},{"line_number":985,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_c5717c79","line":982,"in_reply_to":"3a461143_be1f2cb6","updated":"2017-02-02 10:59:19.000000000","message":"Done","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"38c9858d7d1330f256ac9d36a7adff5eda45961e","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"        self.assertEqual(20, out[\u0027size\u0027])"},{"line_number":1009,"context_line":"        self.assertEqual(export_locations, out[\u0027export_locations\u0027])"},{"line_number":1010,"context_line":"        self.assertTrue(self.mock_log.debug.called)"},{"line_number":1011,"context_line":"        self.assertTrue(self.mock_log.info.called)"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    @ddt.data(\u0027fake_size\u0027, \u0027128GB\u0027, \u0027512 GB\u0027, {\u0027size\u0027: 128})"},{"line_number":1014,"context_line":"    def test_manage_snapshot_invalid_size_exception(self, size):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_fe5e1478","line":1011,"updated":"2017-02-02 00:45:37.000000000","message":"same here. should validate that the mocks were used","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"95f36d1593a6a9df70eb4eb90885d2c84db488df","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"        self.assertEqual(20, out[\u0027size\u0027])"},{"line_number":1009,"context_line":"        self.assertEqual(export_locations, out[\u0027export_locations\u0027])"},{"line_number":1010,"context_line":"        self.assertTrue(self.mock_log.debug.called)"},{"line_number":1011,"context_line":"        self.assertTrue(self.mock_log.info.called)"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    @ddt.data(\u0027fake_size\u0027, \u0027128GB\u0027, \u0027512 GB\u0027, {\u0027size\u0027: 128})"},{"line_number":1014,"context_line":"    def test_manage_snapshot_invalid_size_exception(self, size):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_a55c70ee","line":1011,"in_reply_to":"3a461143_fe5e1478","updated":"2017-02-02 10:59:19.000000000","message":"Done","commit_id":"26be24c43e1270eb91559e0539c5e5b5665f5f7a"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c221abcd7983c0a0a617f4fdfeaa559c960a10c6","unresolved":false,"context_lines":[{"line_number":939,"context_line":"         assert_called_once_with(fake_data))"},{"line_number":940,"context_line":"        self.assertTrue(self.mock_log.info.called)"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    @ddt.data(snapshot_nfs, snapshot_mount_support_nfs,"},{"line_number":943,"context_line":"              snapshot_mount_support_cifs)"},{"line_number":944,"context_line":"    def test_ensure_snapshot(self, snapshot):"},{"line_number":945,"context_line":"        result \u003d self._driver.ensure_snapshot(\u0027context\u0027, snapshot)"},{"line_number":946,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_fa7d32b2","line":943,"range":{"start_line":942,"start_character":14,"end_line":943,"end_character":41},"updated":"2017-02-02 11:21:43.000000000","message":"you could add \u0027snapshot_cifs\u0027 here, to test a snapshot without mountable snapshot support and in CIFS protocol..","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"1ccff15c7167f7682b459b2b98b7dfc3a663317a","unresolved":false,"context_lines":[{"line_number":939,"context_line":"         assert_called_once_with(fake_data))"},{"line_number":940,"context_line":"        self.assertTrue(self.mock_log.info.called)"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    @ddt.data(snapshot_nfs, snapshot_mount_support_nfs,"},{"line_number":943,"context_line":"              snapshot_mount_support_cifs)"},{"line_number":944,"context_line":"    def test_ensure_snapshot(self, snapshot):"},{"line_number":945,"context_line":"        result \u003d self._driver.ensure_snapshot(\u0027context\u0027, snapshot)"},{"line_number":946,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_6b57b6ca","line":943,"range":{"start_line":942,"start_character":14,"end_line":943,"end_character":41},"in_reply_to":"3a461143_fa7d32b2","updated":"2017-02-02 15:48:55.000000000","message":"Done","commit_id":"6a6e100f65b350b3090978d3047b7cce2b0404f8"}]}
