)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_3708b391","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":78},"updated":"2017-02-02 10:58:08.000000000","message":"I suggest rewriting this because \"shares\" is plural.\n\n\"HNAS driver always handles snapshots as if mount_snaphot_support is always True.","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_d7da0f17","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":25},"updated":"2017-02-02 10:58:08.000000000","message":"handles","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_17a017a5","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":32},"updated":"2017-02-02 10:58:08.000000000","message":"snapshots","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c20348055e9509deddd9a2075de65cb5195ae241","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_9a942e45","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":32},"in_reply_to":"3a461143_17a017a5","updated":"2017-02-02 11:14:23.000000000","message":"Done","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c20348055e9509deddd9a2075de65cb5195ae241","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_da9eb662","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":78},"in_reply_to":"3a461143_3708b391","updated":"2017-02-02 11:14:23.000000000","message":"Done","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c20348055e9509deddd9a2075de65cb5195ae241","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_fa9b7270","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":25},"in_reply_to":"3a461143_d7da0f17","updated":"2017-02-02 11:14:23.000000000","message":"Done","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_57e61fe9","line":10,"range":{"start_line":10,"start_character":63,"end_line":10,"end_character":75},"updated":"2017-02-02 10:58:08.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_372fd3f7","line":10,"range":{"start_line":10,"start_character":56,"end_line":10,"end_character":59},"updated":"2017-02-02 10:58:08.000000000","message":"tries","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c20348055e9509deddd9a2075de65cb5195ae241","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_3a8c1a35","line":10,"range":{"start_line":10,"start_character":56,"end_line":10,"end_character":59},"in_reply_to":"3a461143_372fd3f7","updated":"2017-02-02 11:14:23.000000000","message":"Done","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c20348055e9509deddd9a2075de65cb5195ae241","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix HNAS driver always handling mountable snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver always handle shares as if it has mountable_snapshot_support\u003dTrue."},{"line_number":10,"context_line":"The driver always create exports in snapshot_create and try to delete it in"},{"line_number":11,"context_line":"snapshot_delete. Also, the driver tries to add rules for exports in"},{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_1a8e7e27","line":10,"range":{"start_line":10,"start_character":63,"end_line":10,"end_character":75},"in_reply_to":"3a461143_57e61fe9","updated":"2017-02-02 11:14:23.000000000","message":"don\u0027t go beyond 72 chars*","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixing it by checking the key \u0027mount_snapshot_support\u0027 in shares and"},{"line_number":15,"context_line":"checking if the share has a export before adding or removing rules."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If25d68d04400f0e9015f6ad6aff845f9c5d47f94"},{"line_number":18,"context_line":"Closes-bug: #1660420"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_570b7f7d","line":15,"range":{"start_line":15,"start_character":26,"end_line":15,"end_character":27},"updated":"2017-02-02 10:58:08.000000000","message":"an","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"snapshot_update_access without checking if the export exists."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixing it by checking the key \u0027mount_snapshot_support\u0027 in shares and"},{"line_number":15,"context_line":"checking if the share has a export before adding or removing rules."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If25d68d04400f0e9015f6ad6aff845f9c5d47f94"},{"line_number":18,"context_line":"Closes-bug: #1660420"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_3716f3a7","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":21},"updated":"2017-02-02 10:58:08.000000000","message":"snapshot","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"}],"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bd4ec5c90ce5727c87e8d4d24da59c44091b08f6","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        LOG.info(_LI(\"Snapshot %(id)s successfully created.\"),"},{"line_number":396,"context_line":"                 {\u0027id\u0027: snapshot[\u0027id\u0027]})"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        output \u003d {\u0027provider_location\u0027: os.path.join("},{"line_number":399,"context_line":"            \u0027/snapshots\u0027, hnas_share_id, snapshot[\u0027id\u0027])}"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        if export_locations:"},{"line_number":402,"context_line":"            output[\u0027export_locations\u0027] \u003d export_locations"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_77879bd7","line":399,"range":{"start_line":398,"start_character":8,"end_line":399,"end_character":57},"updated":"2017-02-02 10:58:08.000000000","message":"improve wrapping please:\n\noutput \u003d {\n    \u0027provider_location\u0027: os.path.join(\n        \u0027/snapshots\u0027, hnas_share_id, snapshot[\u0027id\u0027])\n}","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c20348055e9509deddd9a2075de65cb5195ae241","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        LOG.info(_LI(\"Snapshot %(id)s successfully created.\"),"},{"line_number":396,"context_line":"                 {\u0027id\u0027: snapshot[\u0027id\u0027]})"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        output \u003d {\u0027provider_location\u0027: os.path.join("},{"line_number":399,"context_line":"            \u0027/snapshots\u0027, hnas_share_id, snapshot[\u0027id\u0027])}"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        if export_locations:"},{"line_number":402,"context_line":"            output[\u0027export_locations\u0027] \u003d export_locations"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_3abedad4","line":399,"range":{"start_line":398,"start_character":8,"end_line":399,"end_character":57},"in_reply_to":"3a461143_77879bd7","updated":"2017-02-02 11:14:23.000000000","message":"Done","commit_id":"3ec4d3bc105425470316c721058c726de56f4a45"}]}
