)]}'
{"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"b206e20b1db2747487151bd48801c5ee93b1fcb7","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027], share_proto)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        if share_proto.lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":969,"context_line":"            rw_list \u003d [\u0027read_write\u0027, \u0027readwrite\u0027, \u0027rw\u0027]"},{"line_number":970,"context_line":"            saved_list \u003d self.hnas.get_nfs_host_list(hnas_share_id)"},{"line_number":971,"context_line":"            new_list \u003d []"},{"line_number":972,"context_line":"            for access in saved_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_c25b1d2d","line":969,"updated":"2017-02-02 17:42:12.000000000","message":"do you need to check for the old \u0027(rw)\u0027 too or was that completely wrong","commit_id":"ee6c3935cf74ef7c5125b84cb98fa0a1280fc239"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"5d2447fad03cbb6a00a0ffaf3f25e1bb0f06554f","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027], share_proto)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        if share_proto.lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":969,"context_line":"            rw_list \u003d [\u0027read_write\u0027, \u0027readwrite\u0027, \u0027rw\u0027]"},{"line_number":970,"context_line":"            saved_list \u003d self.hnas.get_nfs_host_list(hnas_share_id)"},{"line_number":971,"context_line":"            new_list \u003d []"},{"line_number":972,"context_line":"            for access in saved_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_7d8cca35","line":969,"in_reply_to":"3a461143_c25b1d2d","updated":"2017-02-02 18:15:05.000000000","message":"\u0027(rw)\u0027 is already checked by \u0027rw\u0027 case.","commit_id":"ee6c3935cf74ef7c5125b84cb98fa0a1280fc239"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2d0a3db32deb9e52f2c93f83cc89cc5364ec9751","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027], share_proto)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        if share_proto.lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":969,"context_line":"            rw_list \u003d [\u0027read_write\u0027, \u0027readwrite\u0027, \u0027rw\u0027]"},{"line_number":970,"context_line":"            saved_list \u003d self.hnas.get_nfs_host_list(hnas_share_id)"},{"line_number":971,"context_line":"            new_list \u003d []"},{"line_number":972,"context_line":"            for access in saved_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_7d084a92","line":969,"in_reply_to":"3a461143_c25b1d2d","updated":"2017-02-02 18:10:08.000000000","message":"no need to check for the old (rw) as it is already covered in new approach","commit_id":"ee6c3935cf74ef7c5125b84cb98fa0a1280fc239"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8589589763ff10082d581991eb9cdb28860a5cd7","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        self._check_protocol(snapshot[\u0027share_id\u0027], share_proto)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        if share_proto.lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":969,"context_line":"            rw_list \u003d [\u0027read_write\u0027, \u0027readwrite\u0027, \u0027rw\u0027]"},{"line_number":970,"context_line":"            saved_list \u003d self.hnas.get_nfs_host_list(hnas_share_id)"},{"line_number":971,"context_line":"            new_list \u003d []"},{"line_number":972,"context_line":"            for access in saved_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_eeaba2d4","line":969,"range":{"start_line":969,"start_character":12,"end_line":969,"end_character":55},"updated":"2017-02-02 19:00:21.000000000","message":"Why do you need definition of separate \"list\" that you use only once and that could be defined in-place?","commit_id":"79e6690162a5654f82f940882315542c77ed0c36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8589589763ff10082d581991eb9cdb28860a5cd7","unresolved":false,"context_lines":[{"line_number":970,"context_line":"            saved_list \u003d self.hnas.get_nfs_host_list(hnas_share_id)"},{"line_number":971,"context_line":"            new_list \u003d []"},{"line_number":972,"context_line":"            for access in saved_list:"},{"line_number":973,"context_line":"                for rw in rw_list:"},{"line_number":974,"context_line":"                    access \u003d access.replace(rw, \u0027ro\u0027)"},{"line_number":975,"context_line":"                new_list.append(access)"},{"line_number":976,"context_line":"            self.hnas.update_nfs_access_rule(new_list, share_id\u003dhnas_share_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_ce950689","line":973,"range":{"start_line":973,"start_character":16,"end_line":973,"end_character":34},"updated":"2017-02-02 19:00:21.000000000","message":"it could be just following:\n\n\"\"\"\nfor rw in (\u0027read_write\u0027, \u0027readwrite\u0027, \u0027rw\u0027):\n\"\"\"","commit_id":"79e6690162a5654f82f940882315542c77ed0c36"}],"manila/tests/share/drivers/hitachi/hnas/test_driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"eeb4421fc33d9ac20c67fe9169bd9ca469f32bd8","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    @ddt.data(snapshot_nfs, snapshot_cifs)"},{"line_number":454,"context_line":"    def test_create_snapshot(self, snapshot):"},{"line_number":455,"context_line":"        hnas_id \u003d snapshot[\u0027share_id\u0027]"},{"line_number":456,"context_line":"        access_list \u003d [\u0027172.24.44.200(rw,norootsquash)\u0027,"},{"line_number":457,"context_line":"                       \u0027172.24.49.180(all_squash,read_write,secure)\u0027,"},{"line_number":458,"context_line":"                       \u0027172.24.49.110(ro, secure)\u0027,"},{"line_number":459,"context_line":"                       \u0027172.24.49.112(secure,readwrite,norootsquash)\u0027,"},{"line_number":460,"context_line":"                       \u0027172.24.49.142(read_only, secure)\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        ro_list \u003d [\u0027172.24.44.200(ro,norootsquash)\u0027,"},{"line_number":463,"context_line":"                   \u0027172.24.49.180(all_squash,ro,secure)\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_1f773e03","line":460,"range":{"start_line":456,"start_character":8,"end_line":460,"end_character":57},"updated":"2017-02-02 17:35:19.000000000","message":"please add \"(ro,ro,ro)\" case as we discussed","commit_id":"ee6c3935cf74ef7c5125b84cb98fa0a1280fc239"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"5d2447fad03cbb6a00a0ffaf3f25e1bb0f06554f","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    @ddt.data(snapshot_nfs, snapshot_cifs)"},{"line_number":454,"context_line":"    def test_create_snapshot(self, snapshot):"},{"line_number":455,"context_line":"        hnas_id \u003d snapshot[\u0027share_id\u0027]"},{"line_number":456,"context_line":"        access_list \u003d [\u0027172.24.44.200(rw,norootsquash)\u0027,"},{"line_number":457,"context_line":"                       \u0027172.24.49.180(all_squash,read_write,secure)\u0027,"},{"line_number":458,"context_line":"                       \u0027172.24.49.110(ro, secure)\u0027,"},{"line_number":459,"context_line":"                       \u0027172.24.49.112(secure,readwrite,norootsquash)\u0027,"},{"line_number":460,"context_line":"                       \u0027172.24.49.142(read_only, secure)\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        ro_list \u003d [\u0027172.24.44.200(ro,norootsquash)\u0027,"},{"line_number":463,"context_line":"                   \u0027172.24.49.180(all_squash,ro,secure)\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_3d1de2bd","line":460,"range":{"start_line":456,"start_character":8,"end_line":460,"end_character":57},"in_reply_to":"3a461143_1f773e03","updated":"2017-02-02 18:15:05.000000000","message":"Done","commit_id":"ee6c3935cf74ef7c5125b84cb98fa0a1280fc239"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2d0a3db32deb9e52f2c93f83cc89cc5364ec9751","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    @ddt.data(snapshot_nfs, snapshot_cifs)"},{"line_number":454,"context_line":"    def test_create_snapshot(self, snapshot):"},{"line_number":455,"context_line":"        hnas_id \u003d snapshot[\u0027share_id\u0027]"},{"line_number":456,"context_line":"        access_list \u003d [\u0027172.24.44.200(rw,norootsquash)\u0027,"},{"line_number":457,"context_line":"                       \u0027172.24.49.180(all_squash,read_write,secure)\u0027,"},{"line_number":458,"context_line":"                       \u0027172.24.49.110(ro, secure)\u0027,"},{"line_number":459,"context_line":"                       \u0027172.24.49.112(secure,readwrite,norootsquash)\u0027,"},{"line_number":460,"context_line":"                       \u0027172.24.49.142(read_only, secure)\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        ro_list \u003d [\u0027172.24.44.200(ro,norootsquash)\u0027,"},{"line_number":463,"context_line":"                   \u0027172.24.49.180(all_squash,ro,secure)\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_7d2f6af6","line":460,"range":{"start_line":456,"start_character":8,"end_line":460,"end_character":57},"in_reply_to":"3a461143_1f773e03","updated":"2017-02-02 18:10:08.000000000","message":"please add a case of only \"(rw)\" as well please","commit_id":"ee6c3935cf74ef7c5125b84cb98fa0a1280fc239"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"5d2447fad03cbb6a00a0ffaf3f25e1bb0f06554f","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    @ddt.data(snapshot_nfs, snapshot_cifs)"},{"line_number":454,"context_line":"    def test_create_snapshot(self, snapshot):"},{"line_number":455,"context_line":"        hnas_id \u003d snapshot[\u0027share_id\u0027]"},{"line_number":456,"context_line":"        access_list \u003d [\u0027172.24.44.200(rw,norootsquash)\u0027,"},{"line_number":457,"context_line":"                       \u0027172.24.49.180(all_squash,read_write,secure)\u0027,"},{"line_number":458,"context_line":"                       \u0027172.24.49.110(ro, secure)\u0027,"},{"line_number":459,"context_line":"                       \u0027172.24.49.112(secure,readwrite,norootsquash)\u0027,"},{"line_number":460,"context_line":"                       \u0027172.24.49.142(read_only, secure)\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        ro_list \u003d [\u0027172.24.44.200(ro,norootsquash)\u0027,"},{"line_number":463,"context_line":"                   \u0027172.24.49.180(all_squash,ro,secure)\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_fdfefa36","line":460,"range":{"start_line":456,"start_character":8,"end_line":460,"end_character":57},"in_reply_to":"3a461143_7d2f6af6","updated":"2017-02-02 18:15:05.000000000","message":"done please please","commit_id":"ee6c3935cf74ef7c5125b84cb98fa0a1280fc239"}],"releasenotes/notes/bug-1661271-hnas-snapshot-readonly-4e50183100ed2b19.yaml":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"109e9a77c3d773fa571680a67b8c740c3f8614df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed HNAS driver creating snapshots of NFS shares"},{"line_number":4,"context_line":"    without first changing it to read-only."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a461143_e73904a5","line":4,"updated":"2017-02-02 19:34:51.000000000","message":"I think it probably worked in the (rw) case but most likely customers will appreciate the shorter release note instead of trying to explain if it ever could have worked.","commit_id":"e824e8ba8d6a1352df44e393e3eef44b431086b0"}]}
