)]}'
{"devstack/upgrade/resources.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1a53a492161a66b62fb3ab74298b405cf4cb6ac","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    eval $share_network_cmd"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # Create share-type"},{"line_number":82,"context_line":"    manila type-create $MANILA_GRENADE_SHARE_TYPE_NAME $driver_handles_share_servers"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # Create share"},{"line_number":85,"context_line":"    eval $create_share_cmd"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a430d35_bd8f6b73","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":84},"updated":"2017-02-08 22:37:39.000000000","message":"Doesn\u0027t have \"snapshot_support\"... \nI know we\u0027re still testing mitaka-newton upgrades, however, in both these releases, we had the key \"snapshot_support\" \u003d\u003e maybe we should use it so that we don\u0027t have to change it when we start testing ocata-pike upgrades","commit_id":"d8d1c040795ba647742ee05774318bc4bdf1138e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e5ee1472a766a11cb04de2bc7f9933f88ea8b9b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    eval $share_network_cmd"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # Create share-type"},{"line_number":82,"context_line":"    manila type-create $MANILA_GRENADE_SHARE_TYPE_NAME $driver_handles_share_servers"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # Create share"},{"line_number":85,"context_line":"    eval $create_share_cmd"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a430d35_a87b94f3","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":84},"in_reply_to":"1a430d35_bd8f6b73","updated":"2017-02-09 12:24:35.000000000","message":"We always test migration TO branch that is changed. In current case - master. Added support of 4 special extra specs.","commit_id":"d8d1c040795ba647742ee05774318bc4bdf1138e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"609bcb8720d6bfdd5f5fcb4f58dd0103480398e7","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        if [[ $? !\u003d 0 ]]; then"},{"line_number":369,"context_line":"            die $LINENO \"\u0027$snapshot_column\u0027 column was not found in output \u0027$snapshot_output\u0027\""},{"line_number":370,"context_line":"        fi"},{"line_number":371,"context_line":"    done"},{"line_number":372,"context_line":"}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"function scenario_5_destroy_share_snapshot {"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a430d35_1d05df0f","line":371,"range":{"start_line":371,"start_character":4,"end_line":371,"end_character":8},"updated":"2017-02-08 22:31:29.000000000","message":"I might be misunderstanding the intent of these tests. Can you explain what the point of these checks is?\n\nWhen I\u0027m on release A and I have a snapshot \"XYZZY\" and i upgrade to release B, why would I care what exact fields were there? What if in some microversion, these fields are removed?\n\nWill we change these tests? that sounds wrong to me. I feel we should verify some important fields: \"share_id\": that makes sense, \"status\": that makes sense.. why \"provider_location\"?","commit_id":"d8d1c040795ba647742ee05774318bc4bdf1138e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1a53a492161a66b62fb3ab74298b405cf4cb6ac","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        if [[ $? !\u003d 0 ]]; then"},{"line_number":369,"context_line":"            die $LINENO \"\u0027$snapshot_column\u0027 column was not found in output \u0027$snapshot_output\u0027\""},{"line_number":370,"context_line":"        fi"},{"line_number":371,"context_line":"    done"},{"line_number":372,"context_line":"}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"function scenario_5_destroy_share_snapshot {"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a430d35_dd2ef78a","line":371,"range":{"start_line":371,"start_character":4,"end_line":371,"end_character":8},"in_reply_to":"1a430d35_1d05df0f","updated":"2017-02-08 22:37:39.000000000","message":"Sorry I forgot to add this:\n\nThe main point of an upgrade test should be:\n\n* I still have my resource\n* I can still use my resource (in this case, can I create a share from a snapshot)","commit_id":"d8d1c040795ba647742ee05774318bc4bdf1138e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e5ee1472a766a11cb04de2bc7f9933f88ea8b9b","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        if [[ $? !\u003d 0 ]]; then"},{"line_number":369,"context_line":"            die $LINENO \"\u0027$snapshot_column\u0027 column was not found in output \u0027$snapshot_output\u0027\""},{"line_number":370,"context_line":"        fi"},{"line_number":371,"context_line":"    done"},{"line_number":372,"context_line":"}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"function scenario_5_destroy_share_snapshot {"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a430d35_75f0a5c9","line":371,"range":{"start_line":371,"start_character":4,"end_line":371,"end_character":8},"in_reply_to":"1a430d35_dd2ef78a","updated":"2017-02-09 12:24:35.000000000","message":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\"What if in some microversion, these fields are removed?\"\n\nonly single version of manila client is used - version that is used as \"base\". So, it is always one known concrete microversion - latest in that release. No \"if\"s here, a t all.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n\"Can you explain what the point of these checks is?\"\n\nThese fields are expected to exist. They are user-related in some way. Why we should skip their check?\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d","commit_id":"d8d1c040795ba647742ee05774318bc4bdf1138e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1a53a492161a66b62fb3ab74298b405cf4cb6ac","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    scenario_2_do_attach_ss_to_sn"},{"line_number":406,"context_line":"    scenario_3_do_quotas"},{"line_number":407,"context_line":"    scenario_4_do_private_share_types"},{"line_number":408,"context_line":"    scenario_5_do_share_snapshot"},{"line_number":409,"context_line":"    echo \"Manila \u0027create\u0027: SUCCESS\""},{"line_number":410,"context_line":"}"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a430d35_3d561b06","line":408,"range":{"start_line":408,"start_character":4,"end_line":408,"end_character":32},"updated":"2017-02-08 22:37:39.000000000","message":"Since this is the first \"optional\" feature you\u0027re testing, can we use a test flag?","commit_id":"d8d1c040795ba647742ee05774318bc4bdf1138e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e5ee1472a766a11cb04de2bc7f9933f88ea8b9b","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    scenario_2_do_attach_ss_to_sn"},{"line_number":406,"context_line":"    scenario_3_do_quotas"},{"line_number":407,"context_line":"    scenario_4_do_private_share_types"},{"line_number":408,"context_line":"    scenario_5_do_share_snapshot"},{"line_number":409,"context_line":"    echo \"Manila \u0027create\u0027: SUCCESS\""},{"line_number":410,"context_line":"}"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a430d35_2870840a","line":408,"range":{"start_line":408,"start_character":4,"end_line":408,"end_character":32},"in_reply_to":"1a430d35_3d561b06","updated":"2017-02-09 12:24:35.000000000","message":"Done","commit_id":"d8d1c040795ba647742ee05774318bc4bdf1138e"}]}