)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: [LVM] Can\u0027t extend share with snapshots exist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Lvm can\u0027t extend share when snapshot mounted and activated."},{"line_number":10,"context_line":"Fix this bug by using command sequence when extending share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1. umount snapshot(s)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_63c2b486","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"updated":"2017-02-09 11:00:10.000000000","message":"LVM","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: [LVM] Can\u0027t extend share with snapshots exist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Lvm can\u0027t extend share when snapshot mounted and activated."},{"line_number":10,"context_line":"Fix this bug by using command sequence when extending share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1. umount snapshot(s)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_c3d2885b","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":58},"updated":"2017-02-09 11:00:10.000000000","message":"when it has a snapshot that is mounted and activated","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix: [LVM] Can\u0027t extend share with snapshots exist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Lvm can\u0027t extend share when snapshot mounted and activated."},{"line_number":10,"context_line":"Fix this bug by using command sequence when extending share."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1. umount snapshot(s)."},{"line_number":13,"context_line":"2. umount share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_43c77895","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":43},"updated":"2017-02-09 11:00:10.000000000","message":"sequence below when","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"}],"manila/share/driver.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":998,"context_line":"        \"\"\""},{"line_number":999,"context_line":"        raise NotImplementedError()"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone, snapshots\u003dNone):"},{"line_number":1002,"context_line":"        \"\"\"Extends size of existing share."},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"        :param share: Share model"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_6349d430","line":1001,"range":{"start_line":1001,"start_character":63,"end_line":1001,"end_character":78},"updated":"2017-02-09 11:00:10.000000000","message":"I do not agree with this driver interface change. The LVM driver should employ mechanisms to find its snapshots.","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        return attr and attr.strip()[4] \u003d\u003d \u0027a\u0027"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def lv_has_snapshot(self, name):"},{"line_number":107,"context_line":"        attr \u003d self._lv_display_attr(name)"},{"line_number":108,"context_line":"        return attr and attr.strip()[0] in [\u0027o\u0027, \u0027O\u0027]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _extend_container(self, share, device_name, size):"},{"line_number":111,"context_line":"        share_lv_name \u003d \"%s/%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_a329fc9c","line":108,"range":{"start_line":107,"start_character":8,"end_line":108,"end_character":53},"updated":"2017-02-09 11:00:10.000000000","message":"see comment below on usage of lvdisplay to find the snapshots of a share.","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return attr and attr.strip()[0] in [\u0027o\u0027, \u0027O\u0027]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _extend_container(self, share, device_name, size):"},{"line_number":111,"context_line":"        share_lv_name \u003d \"%s/%s\" % ("},{"line_number":112,"context_line":"            self.configuration.lvm_share_volume_group, share[\u0027name\u0027])"},{"line_number":113,"context_line":"        if self.lv_has_snapshot(share_lv_name):"},{"line_number":114,"context_line":"            self._unmount_device(share)"},{"line_number":115,"context_line":"            self._try_execute(\u0027lvchange\u0027, \u0027-an\u0027, share_lv_name,"},{"line_number":116,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":117,"context_line":"            self._wait_for_activation(share_lv_name, active\u003dFalse)"},{"line_number":118,"context_line":"            self._try_execute(\u0027lvextend\u0027, \u0027-L\u0027, \u0027%sG\u0027 % size, \u0027-n\u0027,"},{"line_number":119,"context_line":"                              device_name, run_as_root\u003dTrue)"},{"line_number":120,"context_line":"            self._try_execute(\u0027lvchange\u0027, \u0027-ay\u0027, share_lv_name,"},{"line_number":121,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":122,"context_line":"            self._wait_for_activation(share_lv_name, active\u003dTrue)"},{"line_number":123,"context_line":"            self._mount_device(share, device_name)"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            self._try_execute(\u0027lvextend\u0027, \u0027-L\u0027, \u0027%sG\u0027 % size, \u0027-n\u0027,"},{"line_number":126,"context_line":"                              device_name, run_as_root\u003dTrue)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @m_utils.retry(exception.ShareNotDeactivated, retries\u003d3,"},{"line_number":129,"context_line":"                   backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_a352dc32","line":126,"range":{"start_line":111,"start_character":8,"end_line":126,"end_character":60},"updated":"2017-02-09 11:00:10.000000000","message":"I believe you shouldn\u0027t implement the snapshot handling logic inside the extend method.","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"e871c677f218e61761868037a0d1a8a87722ab6a","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @m_utils.retry(exception.ShareNotDeactivated, retries\u003d3,"},{"line_number":129,"context_line":"                   backoff_rate\u003d1)"},{"line_number":130,"context_line":"    def _wait_for_activation(self, name, active\u003dTrue):"},{"line_number":131,"context_line":"        LOG.debug(\"Checking to see if share %s has been deactivated.\","},{"line_number":132,"context_line":"                  name)"},{"line_number":133,"context_line":"        if active ^ self._lv_is_active(name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_23d34cd6","line":130,"updated":"2017-02-09 10:53:37.000000000","message":"a nit: _wait_for_activation might be misleading name as it waits both for activation and deactivation, maybe _wait_for_active_state_change would be more accurate. But I can live with _wait_for_activation if you prefer :)","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone, snapshots\u003dNone):"},{"line_number":400,"context_line":"        device_name \u003d self._get_local_path(share)"},{"line_number":401,"context_line":"        if snapshots is not None:"},{"line_number":402,"context_line":"            for snapshot in snapshots:"},{"line_number":403,"context_line":"                self._remove_export(None, snapshot)"},{"line_number":404,"context_line":"        self._extend_container(share, device_name, new_size)"},{"line_number":405,"context_line":"        self._execute(\u0027resize2fs\u0027, device_name, run_as_root\u003dTrue)"},{"line_number":406,"context_line":"        if snapshots is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_63ae342f","line":403,"range":{"start_line":401,"start_character":8,"end_line":403,"end_character":51},"updated":"2017-02-09 11:00:10.000000000","message":"instead of snapshot parameter, you can use lvdisplay, as it shows the snapshots of a share:\n\n --- Logical volume ---\n  LV Path                /dev/lvm-shares/share-7378018b-a143-4057-aeea-bffbb5d44a76\n  LV Name                share-7378018b-a143-4057-aeea-bffbb5d44a76\n  VG Name                lvm-shares\n  LV UUID                1nywNy-pfVM-aRft-uMr6-FoKg-7g09-HlJqus\n  LV Write Access        read/write\n  LV Creation host, time ubuntu, 2017-02-09 08:37:44 -0200\n  LV snapshot status     source of\n                         share-snapshot-c9304110-9773-42c6-9809-67bee9e746e0 [active]\n                         share-snapshot-80b843e6-154c-43e4-95e4-ac1615479c66 [active]\n  LV Status              available\n  # open                 1\n  LV Size                1.00 GiB\n  Current LE             256\n  Segments               1\n  Allocation             inherit\n  Read ahead sectors     auto\n  - currently set to     256\n  Block device           252:15","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f9936a195fe70be3055703f6dc5b9f5eaedf99bc","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def _wait_for_active_state_change(self, name, active\u003dTrue):"},{"line_number":157,"context_line":"        LOG.debug(\"Checking to see if share %s has been deactivated.\","},{"line_number":158,"context_line":"                  name)"},{"line_number":159,"context_line":"        if active ^ self._lv_is_active(name):"},{"line_number":160,"context_line":"            LOG.debug(\"Share %s is still active.\", name)"},{"line_number":161,"context_line":"            raise exception.ShareNotDeactivated(name\u003dname)"},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            LOG.debug(\"Share %s has been deactivated.\", name)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _deallocate_container(self, share_name):"},{"line_number":166,"context_line":"        \"\"\"Deletes a logical volume for share.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_d9856607","line":163,"range":{"start_line":159,"start_character":8,"end_line":163,"end_character":61},"updated":"2017-02-14 11:46:24.000000000","message":"Messages here can be wrong, because you allow to expect opposite variants.","commit_id":"b32b706b09f6c556c84e60de2158262bef377fa2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"177c916cdc210931d5aabc3201d9dfc55b19cfdd","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            LOG.debug(\"Share %(name)s is still %(state)s.\","},{"line_number":161,"context_line":"                      {\u0027name\u0027: name,"},{"line_number":162,"context_line":"                       \u0027state\u0027: \u0027inactive\u0027 if active else \u0027active\u0027})"},{"line_number":163,"context_line":"            raise exception.ShareNotDeactivated(name\u003dname)"},{"line_number":164,"context_line":"        else:"},{"line_number":165,"context_line":"            LOG.debug(\"Share %(name)s has been %(state)s.\","},{"line_number":166,"context_line":"                      {\u0027name\u0027: name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_33d3cc61","line":163,"range":{"start_line":163,"start_character":28,"end_line":163,"end_character":47},"updated":"2017-02-15 10:46:22.000000000","message":"Since this is related only to LVM, I recommend changing this exception to LVNotDeactivated.\nAlso, this exception \"...NotDeactivated\" wouldn\u0027t make sense when active is False and self._lv_is_active is True. Needs a better name to solve this.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1c636015dba222de78d4bc7689494072e10acb5f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            LOG.debug(\"Share %(name)s is still %(state)s.\","},{"line_number":161,"context_line":"                      {\u0027name\u0027: name,"},{"line_number":162,"context_line":"                       \u0027state\u0027: \u0027inactive\u0027 if active else \u0027active\u0027})"},{"line_number":163,"context_line":"            raise exception.ShareNotDeactivated(name\u003dname)"},{"line_number":164,"context_line":"        else:"},{"line_number":165,"context_line":"            LOG.debug(\"Share %(name)s has been %(state)s.\","},{"line_number":166,"context_line":"                      {\u0027name\u0027: name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_15e76cac","line":163,"range":{"start_line":163,"start_character":28,"end_line":163,"end_character":47},"in_reply_to":"fa31d9ce_33d3cc61","updated":"2017-02-16 00:55:22.000000000","message":"Done","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"c6de77b521c37e3687863450b421aee32e008254","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if out is None:"},{"line_number":124,"context_line":"            return []"},{"line_number":125,"context_line":"        for name in [n.strip() for n in out.splitlines() if n]:"},{"line_number":126,"context_line":"            if not name.startswith(\u0027share-snapshot\u0027):"},{"line_number":127,"context_line":"                continue"},{"line_number":128,"context_line":"            if self._is_snapshot_of_lv(name, share_name):"},{"line_number":129,"context_line":"                snapshots.append({\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_1e1f7d0a","line":126,"updated":"2017-02-16 10:24:22.000000000","message":"Share snapshot name format is configurable by \"share_snapshot_name_template\" config option so it doesn\u0027t have to start with \"share-snapshot\" prefix necessarily. You might either remove this optimization check or filter names by regexp built from template string (but \"%s\" would have to be replaced with \".*\" I guess).","commit_id":"fb6ffe797edf88ebdf26fe630d32ea3574b527ac"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"24c008ee5172d4807c022a8d80a0ee56d0f73d33","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if out is None:"},{"line_number":124,"context_line":"            return []"},{"line_number":125,"context_line":"        for name in [n.strip() for n in out.splitlines() if n]:"},{"line_number":126,"context_line":"            if not name.startswith(\u0027share-snapshot\u0027):"},{"line_number":127,"context_line":"                continue"},{"line_number":128,"context_line":"            if self._is_snapshot_of_lv(name, share_name):"},{"line_number":129,"context_line":"                snapshots.append({\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_9fc5270c","line":126,"in_reply_to":"fa31d9ce_1e1f7d0a","updated":"2017-02-16 11:31:45.000000000","message":"Thanks~, I think it\u0027s better to remove this optimization check","commit_id":"fb6ffe797edf88ebdf26fe630d32ea3574b527ac"}],"manila/share/manager.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"163be4a49a169a3f6c9a28962f6eb12d20e147fb","unresolved":false,"context_lines":[{"line_number":3324,"context_line":"        context \u003d context.elevated()"},{"line_number":3325,"context_line":"        share \u003d self.db.share_get(context, share_id)"},{"line_number":3326,"context_line":"        share_instance \u003d self._get_share_instance(context, share)"},{"line_number":3327,"context_line":"        filters \u003d {"},{"line_number":3328,"context_line":"            \u0027share_instance_ids\u0027: share_instance[\u0027id\u0027]"},{"line_number":3329,"context_line":"        }"},{"line_number":3330,"context_line":"        s_instances \u003d self.db.share_snapshot_instance_get_all_with_filters("},{"line_number":3331,"context_line":"            context, filters, with_share_data\u003dTrue)"},{"line_number":3332,"context_line":"        snapshots \u003d [self._get_snapshot_instance_dict(context, s_instance)"},{"line_number":3333,"context_line":"                     for s_instance in s_instances]"},{"line_number":3334,"context_line":"        share_server \u003d self._get_share_server(context, share_instance)"},{"line_number":3335,"context_line":"        project_id \u003d share[\u0027project_id\u0027]"},{"line_number":3336,"context_line":"        user_id \u003d share[\u0027user_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_630ab427","line":3333,"range":{"start_line":3327,"start_character":8,"end_line":3333,"end_character":51},"updated":"2017-02-09 11:00:10.000000000","message":"no need to do this if we don\u0027t change the driver interface.","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"e871c677f218e61761868037a0d1a8a87722ab6a","unresolved":false,"context_lines":[{"line_number":3338,"context_line":"        try:"},{"line_number":3339,"context_line":"            self.driver.extend_share("},{"line_number":3340,"context_line":"                share_instance, new_size, share_server\u003dshare_server,"},{"line_number":3341,"context_line":"                snapshots\u003dsnapshots)"},{"line_number":3342,"context_line":"        except Exception as e:"},{"line_number":3343,"context_line":"            LOG.exception(_LE(\"Extend share failed.\"), resource\u003dshare)"},{"line_number":3344,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_03dc9044","line":3341,"updated":"2017-02-09 10:53:37.000000000","message":"the \"snaphosts\" param would have to be added to all \"extend_share\" method definitions (in all drivers) otherwise it fails with (like in the EMC_ISILON test):\nShareExtendingError: Share c9065370-dd20-44a5-95df-e5307fbbdbea could not be extended due to error in the driver: extend_share() got an unexpected keyword argument \u0027snapshots\u0027","commit_id":"3f7fc34a56d4399e8fca9e8ad3aa89de857f35ef"}],"manila/tests/share/drivers/test_lvm.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9e01ac32eaf574847439b5276341d70991fe3924","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                                           raise_error):"},{"line_number":535,"context_line":"        self.mock_object(self._driver, \u0027_lv_is_active\u0027,"},{"line_number":536,"context_line":"                         mock.Mock(side_effect\u003dis_active))"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        if raise_error:"},{"line_number":539,"context_line":"            self.assertRaises(exception.ShareNotDeactivated,"},{"line_number":540,"context_line":"                              self._driver._wait_for_active_state_change,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_0ee2d2d5","line":537,"updated":"2017-02-10 11:16:47.000000000","message":"try mocking time.sleep here, to see if your test runs faster.","commit_id":"0ec5e8fe9bef1a2f4fa1c2f6c8c098b0a4cdfff3"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d89773ffed25f70bfa25e2734582a815c1e30f3","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                           (instance_id, status, self.build_timeout))"},{"line_number":347,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def wait_for_share_status(self, share_id, status_to_wait,"},{"line_number":350,"context_line":"                              status_attr\u003d\u0027status\u0027,"},{"line_number":351,"context_line":"                              version\u003dLATEST_MICROVERSION):"},{"line_number":352,"context_line":"        \"\"\"Waits for a share to reach a given status.\"\"\""},{"line_number":353,"context_line":"        statuses \u003d ((status_to_wait,)"},{"line_number":354,"context_line":"                    if not isinstance(status_to_wait, (tuple, list, set))"},{"line_number":355,"context_line":"                    else status_to_wait)"},{"line_number":356,"context_line":"        body \u003d self.get_share(share_id, version\u003dversion)"},{"line_number":357,"context_line":"        share_status \u003d body[status_attr]"},{"line_number":358,"context_line":"        start \u003d int(time.time())"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        while share_status not in statuses:"},{"line_number":361,"context_line":"            time.sleep(self.build_interval)"},{"line_number":362,"context_line":"            body \u003d self.get_share(share_id, version\u003dversion)"},{"line_number":363,"context_line":"            share_status \u003d body[status_attr]"},{"line_number":364,"context_line":"            if share_status in statuses:"},{"line_number":365,"context_line":"                return"},{"line_number":366,"context_line":"            elif \u0027error\u0027 in share_status.lower():"},{"line_number":367,"context_line":"                raise share_exceptions.ShareBuildErrorException("},{"line_number":368,"context_line":"                    share_id\u003dshare_id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"            if int(time.time()) - start \u003e\u003d self.build_timeout:"},{"line_number":371,"context_line":"                message \u003d (\"Share\u0027s %(status_attr)s failed to transition to \""},{"line_number":372,"context_line":"                           \"%(status)s within the required time %(seconds)s.\" %"},{"line_number":373,"context_line":"                           {\"status_attr\": status_attr, \"status\": statuses,"},{"line_number":374,"context_line":"                            \"seconds\": self.build_timeout})"},{"line_number":375,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a30ddce_db4b1caf","line":373,"range":{"start_line":349,"start_character":4,"end_line":373,"end_character":75},"updated":"2017-03-07 12:14:38.000000000","message":"These changes are redundant.","commit_id":"3b33a2e2a9c2319ed609c1794b674e3cd57291e3"}],"manila_tempest_tests/tests/api/test_shares_actions.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"177c916cdc210931d5aabc3201d9dfc55b19cfdd","unresolved":false,"context_lines":[{"line_number":580,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":581,"context_line":"    @testtools.skipUnless("},{"line_number":582,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":583,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"},{"line_number":584,"context_line":"    @testtools.skipUnless("},{"line_number":585,"context_line":"        CONF.share.run_snapshot_tests,"},{"line_number":586,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_53d92056","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":63},"updated":"2017-02-15 10:46:22.000000000","message":"message should be related to option that is being checked. In this case, should say that Share extend tests are disabled.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1c636015dba222de78d4bc7689494072e10acb5f","unresolved":false,"context_lines":[{"line_number":580,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":581,"context_line":"    @testtools.skipUnless("},{"line_number":582,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":583,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"},{"line_number":584,"context_line":"    @testtools.skipUnless("},{"line_number":585,"context_line":"        CONF.share.run_snapshot_tests,"},{"line_number":586,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_35a1d046","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":63},"in_reply_to":"fa31d9ce_53d92056","updated":"2017-02-16 00:55:22.000000000","message":"Done","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"177c916cdc210931d5aabc3201d9dfc55b19cfdd","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"},{"line_number":584,"context_line":"    @testtools.skipUnless("},{"line_number":585,"context_line":"        CONF.share.run_snapshot_tests,"},{"line_number":586,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"},{"line_number":587,"context_line":"    def test_extend_share_with_snapshots_exist(self):"},{"line_number":588,"context_line":"        share \u003d self.create_share(cleanup_in_class\u003dFalse)"},{"line_number":589,"context_line":"        self.create_snapshot_wait_for_active(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_d3e51009","line":586,"range":{"start_line":586,"start_character":9,"end_line":586,"end_character":62},"updated":"2017-02-15 10:46:22.000000000","message":"Snapshot tests are disabled.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1c636015dba222de78d4bc7689494072e10acb5f","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"},{"line_number":584,"context_line":"    @testtools.skipUnless("},{"line_number":585,"context_line":"        CONF.share.run_snapshot_tests,"},{"line_number":586,"context_line":"        \"Share extend with snapshots exist tests are disabled.\")"},{"line_number":587,"context_line":"    def test_extend_share_with_snapshots_exist(self):"},{"line_number":588,"context_line":"        share \u003d self.create_share(cleanup_in_class\u003dFalse)"},{"line_number":589,"context_line":"        self.create_snapshot_wait_for_active(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_558c84d9","line":586,"range":{"start_line":586,"start_character":9,"end_line":586,"end_character":62},"in_reply_to":"fa31d9ce_d3e51009","updated":"2017-02-16 00:55:22.000000000","message":"Done","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"177c916cdc210931d5aabc3201d9dfc55b19cfdd","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":591,"context_line":"        # extend share and wait for active status"},{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # check state and new size"},{"line_number":596,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_5395a030","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":74},"updated":"2017-02-15 10:46:22.000000000","message":"this will timeout waiting for active status if it goes into \"extending_error\". So below code with size check will never be reached.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"92efd3fa3679bcd8f1455858bb2ca195eb483ed9","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":591,"context_line":"        # extend share and wait for active status"},{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # check state and new size"},{"line_number":596,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_bb93c8f9","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":74},"in_reply_to":"fa31d9ce_5395a030","updated":"2017-03-07 12:16:44.000000000","message":"It will not timeout. It will fail immediately as expected.\nFailure on first observed problem is ok.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"177c916cdc210931d5aabc3201d9dfc55b19cfdd","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # check state and new size"},{"line_number":596,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":597,"context_line":"        msg \u003d ("},{"line_number":598,"context_line":"            \"Share could not be extended when snapshots exist. \""},{"line_number":599,"context_line":"            \"Expected %(expected)s, got %(actual)s.\" % {"},{"line_number":600,"context_line":"                \"expected\": new_size,"},{"line_number":601,"context_line":"                \"actual\": share_get[\u0027size\u0027],"},{"line_number":602,"context_line":"            }"},{"line_number":603,"context_line":"        )"},{"line_number":604,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027], msg)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":607,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_73fd446d","line":604,"range":{"start_line":595,"start_character":7,"end_line":604,"end_character":58},"updated":"2017-02-15 10:46:22.000000000","message":"If you invoke extend_share, and it transitions back to active, the API will guarantee that the DB contains the new size.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1c636015dba222de78d4bc7689494072e10acb5f","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # check state and new size"},{"line_number":596,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":597,"context_line":"        msg \u003d ("},{"line_number":598,"context_line":"            \"Share could not be extended when snapshots exist. \""},{"line_number":599,"context_line":"            \"Expected %(expected)s, got %(actual)s.\" % {"},{"line_number":600,"context_line":"                \"expected\": new_size,"},{"line_number":601,"context_line":"                \"actual\": share_get[\u0027size\u0027],"},{"line_number":602,"context_line":"            }"},{"line_number":603,"context_line":"        )"},{"line_number":604,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027], msg)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":607,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_d565d41d","line":604,"range":{"start_line":595,"start_character":7,"end_line":604,"end_character":58},"in_reply_to":"fa31d9ce_73fd446d","updated":"2017-02-16 00:55:22.000000000","message":"Yes, but add this check will ensure everything should be ok after extending share finished","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"92efd3fa3679bcd8f1455858bb2ca195eb483ed9","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # check state and new size"},{"line_number":596,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":597,"context_line":"        msg \u003d ("},{"line_number":598,"context_line":"            \"Share could not be extended when snapshots exist. \""},{"line_number":599,"context_line":"            \"Expected %(expected)s, got %(actual)s.\" % {"},{"line_number":600,"context_line":"                \"expected\": new_size,"},{"line_number":601,"context_line":"                \"actual\": share_get[\u0027size\u0027],"},{"line_number":602,"context_line":"            }"},{"line_number":603,"context_line":"        )"},{"line_number":604,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027], msg)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":607,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_1b6854f5","line":604,"range":{"start_line":595,"start_character":7,"end_line":604,"end_character":58},"in_reply_to":"fa31d9ce_992aa72e","updated":"2017-03-07 12:16:44.000000000","message":"This comment is false too. We should check size anyway. We guarantee anything by THIS test. Also, there will not be timeout.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1253b229fec139d43f15b86e1298af46bf94984e","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_client.wait_for_share_status(share[\u0027id\u0027], \u0027available\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # check state and new size"},{"line_number":596,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":597,"context_line":"        msg \u003d ("},{"line_number":598,"context_line":"            \"Share could not be extended when snapshots exist. \""},{"line_number":599,"context_line":"            \"Expected %(expected)s, got %(actual)s.\" % {"},{"line_number":600,"context_line":"                \"expected\": new_size,"},{"line_number":601,"context_line":"                \"actual\": share_get[\u0027size\u0027],"},{"line_number":602,"context_line":"            }"},{"line_number":603,"context_line":"        )"},{"line_number":604,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027], msg)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":607,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_992aa72e","line":604,"range":{"start_line":595,"start_character":7,"end_line":604,"end_character":58},"in_reply_to":"fa31d9ce_d565d41d","updated":"2017-02-16 12:25:50.000000000","message":"if it is not okay, it will timeout and never reach this code. See above comment.","commit_id":"6d04e37619d673f800523160a520fa72f1400540"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7360062a57676990727f185f08bd9acce9689d99","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        new_size \u003d int(share[\u0027size\u0027]) + 1"},{"line_number":591,"context_line":"        # extend share and wait for active status"},{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_client.wait_for_share_status(share[\u0027id\u0027], [\u0027available\u0027,"},{"line_number":594,"context_line":"                                                               \u0027extend_error\u0027])"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        # check state and new size"},{"line_number":597,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_63a0aea6","line":594,"range":{"start_line":593,"start_character":63,"end_line":594,"end_character":77},"updated":"2017-02-17 10:14:55.000000000","message":"please use constants, and it is \"extending_error\"","commit_id":"931d8eca8f9e40f8861ae5c4cff63e5242fb63ce"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7360062a57676990727f185f08bd9acce9689d99","unresolved":false,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        # check state and new size"},{"line_number":597,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"},{"line_number":598,"context_line":"        msg \u003d \"Share could not be extended when snapshots exist. \" \\"},{"line_number":599,"context_line":"              \"Expected %(expected)s, got %(actual)s.\""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        self.assertEqual(\u0027available\u0027, share_get[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_03cb7273","line":598,"range":{"start_line":598,"start_character":67,"end_line":598,"end_character":68},"updated":"2017-02-17 10:14:55.000000000","message":"please don\u0027t use backlashes, wrap in parenthesis instead","commit_id":"931d8eca8f9e40f8861ae5c4cff63e5242fb63ce"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7360062a57676990727f185f08bd9acce9689d99","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        msg \u003d \"Share could not be extended when snapshots exist. \" \\"},{"line_number":599,"context_line":"              \"Expected %(expected)s, got %(actual)s.\""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        self.assertEqual(\u0027available\u0027, share_get[\u0027status\u0027],"},{"line_number":602,"context_line":"                         msg % {\"expected\": \u0027available\u0027,"},{"line_number":603,"context_line":"                                \"actual\": share_get[\u0027status\u0027]})"},{"line_number":604,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_a3aaa683","line":601,"range":{"start_line":601,"start_character":26,"end_line":601,"end_character":35},"updated":"2017-02-17 10:14:55.000000000","message":"constants","commit_id":"931d8eca8f9e40f8861ae5c4cff63e5242fb63ce"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7360062a57676990727f185f08bd9acce9689d99","unresolved":false,"context_lines":[{"line_number":599,"context_line":"              \"Expected %(expected)s, got %(actual)s.\""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        self.assertEqual(\u0027available\u0027, share_get[\u0027status\u0027],"},{"line_number":602,"context_line":"                         msg % {\"expected\": \u0027available\u0027,"},{"line_number":603,"context_line":"                                \"actual\": share_get[\u0027status\u0027]})"},{"line_number":604,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027],"},{"line_number":605,"context_line":"                         msg % {\"expected\": new_size,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_c3af9a92","line":602,"range":{"start_line":602,"start_character":46,"end_line":602,"end_character":53},"updated":"2017-02-17 10:14:55.000000000","message":"constants","commit_id":"931d8eca8f9e40f8861ae5c4cff63e5242fb63ce"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d89773ffed25f70bfa25e2734582a815c1e30f3","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        self.shares_v2_client.extend_share(share[\u0027id\u0027], new_size)"},{"line_number":593,"context_line":"        self.shares_v2_client.wait_for_share_status("},{"line_number":594,"context_line":"            share[\u0027id\u0027], [constants.STATUS_AVAILABLE,"},{"line_number":595,"context_line":"                          constants.STATUS_EXTENDING_ERROR])"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        # check state and new size"},{"line_number":598,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a30ddce_3bd198ce","line":595,"range":{"start_line":595,"start_character":26,"end_line":595,"end_character":58},"updated":"2017-03-07 12:14:38.000000000","message":"this is redundant","commit_id":"3b33a2e2a9c2319ed609c1794b674e3cd57291e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d89773ffed25f70bfa25e2734582a815c1e30f3","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        msg \u003d (\"Share could not be extended when snapshots exist. \""},{"line_number":600,"context_line":"               \"Expected %(expected)s, got %(actual)s.\")"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        self.assertEqual(constants.STATUS_AVAILABLE, share_get[\u0027status\u0027],"},{"line_number":603,"context_line":"                         msg % {\"expected\": constants.STATUS_AVAILABLE,"},{"line_number":604,"context_line":"                                \"actual\": share_get[\u0027status\u0027]})"},{"line_number":605,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027],"},{"line_number":606,"context_line":"                         msg % {\"expected\": new_size,"},{"line_number":607,"context_line":"                                \"actual\": share_get[\u0027size\u0027]})"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a30ddce_5bd64cc6","line":604,"range":{"start_line":602,"start_character":8,"end_line":604,"end_character":63},"updated":"2017-03-07 12:14:38.000000000","message":"This is redundant. Waiter will verify it.","commit_id":"3b33a2e2a9c2319ed609c1794b674e3cd57291e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2d89773ffed25f70bfa25e2734582a815c1e30f3","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        self.assertEqual(new_size, share_get[\u0027size\u0027],"},{"line_number":606,"context_line":"                         msg % {\"expected\": new_size,"},{"line_number":607,"context_line":"                                \"actual\": share_get[\u0027size\u0027]})"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)"},{"line_number":610,"context_line":"    @testtools.skipUnless("},{"line_number":611,"context_line":"        CONF.share.run_extend_tests,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a30ddce_9bffe433","line":608,"updated":"2017-03-07 12:14:38.000000000","message":"Also, need to add test with mounted snapshot, because you fix bug caused by mounted snapshot.","commit_id":"3b33a2e2a9c2319ed609c1794b674e3cd57291e3"}]}
