)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"73134d0476df8921a3ec50aeb2e13420147060eb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add shrink share in LVM driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now LVM driver support shrink share which doesn\u0027t have snapshot."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id0b588b693136b48b405d380c501da77cc43dfc2"},{"line_number":12,"context_line":"Depends-On: b32b706b09f6c556c84e60de2158262bef377fa2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa31d9ce_32a3ff9e","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":22},"updated":"2017-02-14 10:13:24.000000000","message":"supports","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"98ffbeec21bb7f7bef516f79338a422c63b5a37b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now LVM driver support shrink share which doesn\u0027t have snapshot."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id0b588b693136b48b405d380c501da77cc43dfc2"},{"line_number":12,"context_line":"Depends-On: b32b706b09f6c556c84e60de2158262bef377fa2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa31d9ce_7e062087","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":52},"updated":"2017-02-14 11:24:45.000000000","message":"It should be \"Change-ID\" of other change.","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"58201a7d53007db0b508130a0a59ddee259be528","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add shrink share in LVM driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now LVM driver support shrink share which doesn\u0027t have snapshot."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id0b588b693136b48b405d380c501da77cc43dfc2"},{"line_number":12,"context_line":"Depends-On: I7ffc0a5b2256a978e58722a0bc9fd699a5d1b5a4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_965bed86","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":22},"updated":"2017-03-02 11:11:00.000000000","message":"supports","commit_id":"fd3d9a1869c105db1532448bad20ad12d76118a0"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"73134d0476df8921a3ec50aeb2e13420147060eb","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            raise exception.ShareShrinkingError("},{"line_number":323,"context_line":"                share_id\u003dshare[\u0027id\u0027], reason\u003d\"Failed to collect share\u0027s \""},{"line_number":324,"context_line":"                                             \"used space.\")"},{"line_number":325,"context_line":"        return used \u003e\u003d new_size * 1024.0 * 1024.0"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _remove_export(self, ctx, share):"},{"line_number":328,"context_line":"        \"\"\"Removes an access rules for a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_b2f52f58","line":325,"range":{"start_line":325,"start_character":34,"end_line":325,"end_character":49},"updated":"2017-02-14 10:13:24.000000000","message":"units.Gi","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"73134d0476df8921a3ec50aeb2e13420147060eb","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":443,"context_line":"        \"\"\"Shrinks size of existing share.\"\"\""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        share_lv_name \u003d \"%s/%s\" % ("},{"line_number":446,"context_line":"            self.configuration.lvm_share_volume_group, share[\u0027name\u0027])"},{"line_number":447,"context_line":"        if self._lv_has_snapshot(share_lv_name):"},{"line_number":448,"context_line":"            raise exception.ShareShrinkingError("},{"line_number":449,"context_line":"                share_id\u003dshare[\u0027id\u0027], reason\u003d\"LVM driver doesn\u0027t support \""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_d2fc6374","line":446,"range":{"start_line":445,"start_character":7,"end_line":446,"end_character":69},"updated":"2017-02-14 10:13:24.000000000","message":"don\u0027t format strings like this. Use::\n\nshare_lv_name \u003d \"%(vg)s/%(name)s\" % {\n    \u0027vg\u0027: self.configuration.lvm_share_volume_group,\n    \u0027name\u0027: share[\u0027name\u0027],\n}","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ba64360575aeca17f46fb02f5b31da6acb38841a","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":443,"context_line":"        \"\"\"Shrinks size of existing share.\"\"\""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        share_lv_name \u003d \"%s/%s\" % ("},{"line_number":446,"context_line":"            self.configuration.lvm_share_volume_group, share[\u0027name\u0027])"},{"line_number":447,"context_line":"        if self._lv_has_snapshot(share_lv_name):"},{"line_number":448,"context_line":"            raise exception.ShareShrinkingError("},{"line_number":449,"context_line":"                share_id\u003dshare[\u0027id\u0027], reason\u003d\"LVM driver doesn\u0027t support \""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_9e67544c","line":446,"range":{"start_line":445,"start_character":7,"end_line":446,"end_character":69},"in_reply_to":"fa31d9ce_d2fc6374","updated":"2017-02-14 11:33:36.000000000","message":"Don\u0027t say \"don\u0027t do something\" without description \"why\", because your \"why\" can be contested.","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"73134d0476df8921a3ec50aeb2e13420147060eb","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        if self._lv_has_snapshot(share_lv_name):"},{"line_number":448,"context_line":"            raise exception.ShareShrinkingError("},{"line_number":449,"context_line":"                share_id\u003dshare[\u0027id\u0027], reason\u003d\"LVM driver doesn\u0027t support \""},{"line_number":450,"context_line":"                                             \"shrink share when it has \""},{"line_number":451,"context_line":"                                             \"snapshot.\")"},{"line_number":452,"context_line":"        if self._share_used_size_exceed(share, new_size):"},{"line_number":453,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_b2328f5d","line":450,"range":{"start_line":450,"start_character":46,"end_line":450,"end_character":52},"updated":"2017-02-14 10:13:24.000000000","message":"shrinking","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"73134d0476df8921a3ec50aeb2e13420147060eb","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            raise exception.ShareShrinkingError("},{"line_number":449,"context_line":"                share_id\u003dshare[\u0027id\u0027], reason\u003d\"LVM driver doesn\u0027t support \""},{"line_number":450,"context_line":"                                             \"shrink share when it has \""},{"line_number":451,"context_line":"                                             \"snapshot.\")"},{"line_number":452,"context_line":"        if self._share_used_size_exceed(share, new_size):"},{"line_number":453,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss("},{"line_number":454,"context_line":"                share_id\u003dshare[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_f238873f","line":451,"range":{"start_line":451,"start_character":46,"end_line":451,"end_character":54},"updated":"2017-02-14 10:13:24.000000000","message":"snapshot(s).","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ba64360575aeca17f46fb02f5b31da6acb38841a","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        device_name \u003d self._get_local_path(share)"},{"line_number":456,"context_line":"        # NOTE(tommylikehu): We can easily shrink shares"},{"line_number":457,"context_line":"        # with command \u0027lvresize\u0027 \u0027-r\u0027, cause shares don\u0027t have any snapshot,"},{"line_number":458,"context_line":"        # we don\u0027t need to shrink container and filesystem separately"},{"line_number":459,"context_line":"        self._unmount_device(share)"},{"line_number":460,"context_line":"        self._try_execute(\u0027lvresize\u0027, \u0027-f\u0027, \u0027-r\u0027, \u0027-L\u0027, \u0027%sG\u0027 % new_size, \u0027-n\u0027,"},{"line_number":461,"context_line":"                          device_name, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_be425866","line":458,"range":{"start_line":458,"start_character":8,"end_line":458,"end_character":69},"updated":"2017-02-14 11:33:36.000000000","message":"Why is that?","commit_id":"d5d451f25fb36d0c973830e89091f1bdcbcd0bd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0743e7d56705a2111fc46b30b00650028183e6b2","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":447,"context_line":"        \"\"\"Shrinks size of existing share.\"\"\""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        share_lv_name \u003d \"%(group)s/%(name)s\" % \\"},{"line_number":450,"context_line":"                        {\u0027group\u0027: self.configuration.lvm_share_volume_group,"},{"line_number":451,"context_line":"                         \u0027name\u0027: share[\u0027name\u0027]}"},{"line_number":452,"context_line":"        if self._lv_has_snapshot(share_lv_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_d07506cb","line":449,"range":{"start_line":449,"start_character":47,"end_line":449,"end_character":48},"updated":"2017-02-17 17:01:57.000000000","message":"please don\u0027t use backlashes, wrap in parenthesis instead","commit_id":"fd3d9a1869c105db1532448bad20ad12d76118a0"}]}
