)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4a40c1f03462248db39be09cd2af50736c24caf","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The 2 options are ported from cinder/driver.py, these can be used by any"},{"line_number":14,"context_line":"vendor driver which need to handle ssl verification."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ia9a488cab9d4d2d25c5ab534dbf4d61e930cfd7f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_b480bbc1","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"updated":"2017-03-03 02:44:30.000000000","message":"Needs a blueprint\n\nAnd a release note calling out the configuration options you are adding.","commit_id":"55e526c57ab805976048b8a4de5cf607a49829f1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a247f0b257c59788f9a3c6c48889c987706ce68","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ssl verification."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The 2 options are ported from cinder/driver.py, these can be used by any"},{"line_number":14,"context_line":"vendor driver which need to handle ssl verification."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ia9a488cab9d4d2d25c5ab534dbf4d61e930cfd7f"},{"line_number":17,"context_line":"Implements: blueprint add-ssl-verification-options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba2be162_71119c51","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":24},"updated":"2017-03-06 11:10:32.000000000","message":"needs","commit_id":"adf08225de545436d0787ca79b60c7a3edbe75e1"}],"manila/share/driver.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"038762b4bc114820c22d0ac91caa8b6b1b3048c5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":141,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":142,"context_line":"               \u0027trusted CAs, which will be used to validate the backend\u0027),"},{"line_number":143,"context_line":"]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"ssh_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_b85b7a2d","line":142,"range":{"start_line":142,"start_character":70,"end_line":142,"end_character":72},"updated":"2017-03-02 12:31:32.000000000","message":"Please put a period at the end.","commit_id":"09c0cf4f1f30713b9983893dd1462007326afdc3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eec7146e7a1d059808949b7caf65a1c6cc9dea8d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"               help\u003d\u0027String representation for an equation that will be \u0027"},{"line_number":134,"context_line":"                    \u0027used to determine the goodness of a host.\u0027),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027driver_ssl_cert_verify\u0027,"},{"line_number":136,"context_line":"                default\u003dFalse,"},{"line_number":137,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_749ba372","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":30},"updated":"2017-03-03 02:39:46.000000000","message":"Why is the default False?","commit_id":"55e526c57ab805976048b8a4de5cf607a49829f1"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"73512ef4e9dfb9daa517adc0185a01705188fe94","unresolved":false,"context_lines":[{"line_number":133,"context_line":"               help\u003d\u0027String representation for an equation that will be \u0027"},{"line_number":134,"context_line":"                    \u0027used to determine the goodness of a host.\u0027),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027driver_ssl_cert_verify\u0027,"},{"line_number":136,"context_line":"                default\u003dFalse,"},{"line_number":137,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_604afdad","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":30},"in_reply_to":"ba2be162_749ba372","updated":"2017-03-03 05:54:34.000000000","message":"Setting to True probably breaks many vendor drivers who only provide self-signed certificates. \n\nThanks\nPeter","commit_id":"55e526c57ab805976048b8a4de5cf607a49829f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eec7146e7a1d059808949b7caf65a1c6cc9dea8d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":141,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":142,"context_line":"               \u0027trusted CAs, which will be used to validate the backend.\u0027),"},{"line_number":143,"context_line":"]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"ssh_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_d480cff9","line":142,"range":{"start_line":141,"start_character":15,"end_line":142,"end_character":19},"updated":"2017-03-03 02:39:46.000000000","message":"wrapping","commit_id":"55e526c57ab805976048b8a4de5cf607a49829f1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"188450581ee0f22330cb6a7fa95cf2b2e2928628","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    cfg.StrOpt(\u0027goodness_function\u0027,"},{"line_number":133,"context_line":"               help\u003d\u0027String representation for an equation that will be \u0027"},{"line_number":134,"context_line":"                    \u0027used to determine the goodness of a host.\u0027),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027driver_ssl_cert_verify\u0027,"},{"line_number":136,"context_line":"                default\u003dFalse,"},{"line_number":137,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":141,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":142,"context_line":"               \u0027trusted CAs, which will be used to validate the backend.\u0027),"},{"line_number":143,"context_line":"]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"ssh_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_4a0b482a","line":142,"range":{"start_line":135,"start_character":4,"end_line":142,"end_character":75},"updated":"2017-03-03 13:28:07.000000000","message":"These opts are unused without specific code in each specific driver. So, not sure it is correct to add it here. Here should be options that are used by default driver logic.","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"a7cd7da89f28bd07953a6a0ffd1f2da0f97fd053","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    cfg.StrOpt(\u0027goodness_function\u0027,"},{"line_number":133,"context_line":"               help\u003d\u0027String representation for an equation that will be \u0027"},{"line_number":134,"context_line":"                    \u0027used to determine the goodness of a host.\u0027),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027driver_ssl_cert_verify\u0027,"},{"line_number":136,"context_line":"                default\u003dFalse,"},{"line_number":137,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":141,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":142,"context_line":"               \u0027trusted CAs, which will be used to validate the backend.\u0027),"},{"line_number":143,"context_line":"]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"ssh_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_4556a406","line":142,"range":{"start_line":135,"start_character":4,"end_line":142,"end_character":75},"in_reply_to":"ba2be162_4a0b482a","updated":"2017-03-06 02:47:46.000000000","message":"Yes, emc driver is the first consumer of above 2 options,\nI thought it\u0027s not a long way for other vendor to adopt them.\nYou can refer to cinder, they are using by more and more drivers after adding them. ssl verification is now default starting python2.7.9, any vendor shall use common options to handle them instead of defining theirs.","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a247f0b257c59788f9a3c6c48889c987706ce68","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \u0027used to determine the goodness of a host.\u0027),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027driver_ssl_cert_verify\u0027,"},{"line_number":136,"context_line":"                default\u003dFalse,"},{"line_number":137,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_d1eb2811","line":137,"range":{"start_line":137,"start_character":41,"end_line":137,"end_character":45},"updated":"2017-03-06 11:10:32.000000000","message":"shouldn\u0027t it be \u0027https\u0027?","commit_id":"adf08225de545436d0787ca79b60c7a3edbe75e1"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e0eff9e46295706897f383b2075c63f38b5ca64d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \u0027used to determine the goodness of a host.\u0027),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027driver_ssl_cert_verify\u0027,"},{"line_number":136,"context_line":"                default\u003dFalse,"},{"line_number":137,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_c14ee695","line":137,"range":{"start_line":137,"start_character":41,"end_line":137,"end_character":45},"in_reply_to":"ba2be162_d1eb2811","updated":"2017-03-07 01:11:39.000000000","message":"nice finding, fixed","commit_id":"adf08225de545436d0787ca79b60c7a3edbe75e1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a247f0b257c59788f9a3c6c48889c987706ce68","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":141,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":142,"context_line":"               \u0027trusted CAs, which will be used to validate the backend.\u0027),"},{"line_number":143,"context_line":"]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"ssh_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_b145d443","line":142,"range":{"start_line":141,"start_character":15,"end_line":142,"end_character":73},"updated":"2017-03-06 11:10:32.000000000","message":"the padding here seems off, ideally it should align with the above line","commit_id":"adf08225de545436d0787ca79b60c7a3edbe75e1"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e0eff9e46295706897f383b2075c63f38b5ca64d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":139,"context_line":"    cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,"},{"line_number":140,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":141,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":142,"context_line":"               \u0027trusted CAs, which will be used to validate the backend.\u0027),"},{"line_number":143,"context_line":"]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"ssh_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_e143ea6a","line":142,"range":{"start_line":141,"start_character":15,"end_line":142,"end_character":73},"in_reply_to":"ba2be162_b145d443","updated":"2017-03-07 01:11:39.000000000","message":"Done","commit_id":"adf08225de545436d0787ca79b60c7a3edbe75e1"}],"manila/share/drivers/dell_emc/plugins/vnx/connector.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"188450581ee0f22330cb6a7fa95cf2b2e2928628","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                                   cookie_handler)"},{"line_number":57,"context_line":"        self._do_setup()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _create_ssl_context(self):"},{"line_number":60,"context_line":"        \"\"\"Create context for ssl verification."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        .. note:: starting from python 2.7.9 ssl adds create_default_context."},{"line_number":63,"context_line":"                  We need to keep compatibility with previous python as well."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            if self.ssl_cert_verify:"},{"line_number":67,"context_line":"                context \u003d ssl.create_default_context(capath\u003dself.ssl_cert_path)"},{"line_number":68,"context_line":"            else:"},{"line_number":69,"context_line":"                context \u003d ssl.create_default_context()"},{"line_number":70,"context_line":"                context.check_hostname \u003d False"},{"line_number":71,"context_line":"                context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":72,"context_line":"        except AttributeError:"},{"line_number":73,"context_line":"            context \u003d None"},{"line_number":74,"context_line":"        return context"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_setup(self):"},{"line_number":77,"context_line":"        credential \u003d \u0027user\u003d{}\u0026password\u003d{}\u0026Login\u003dLogin\u0027.format("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_2543a543","line":74,"range":{"start_line":59,"start_character":4,"end_line":74,"end_character":22},"updated":"2017-03-03 13:28:07.000000000","message":"Not specific to DELL_EMC. Since you add options in common driver module, you can add this logic there too. So, it will be very easy to reuse it for other drivers.","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"a7cd7da89f28bd07953a6a0ffd1f2da0f97fd053","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                                   cookie_handler)"},{"line_number":57,"context_line":"        self._do_setup()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _create_ssl_context(self):"},{"line_number":60,"context_line":"        \"\"\"Create context for ssl verification."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        .. note:: starting from python 2.7.9 ssl adds create_default_context."},{"line_number":63,"context_line":"                  We need to keep compatibility with previous python as well."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            if self.ssl_cert_verify:"},{"line_number":67,"context_line":"                context \u003d ssl.create_default_context(capath\u003dself.ssl_cert_path)"},{"line_number":68,"context_line":"            else:"},{"line_number":69,"context_line":"                context \u003d ssl.create_default_context()"},{"line_number":70,"context_line":"                context.check_hostname \u003d False"},{"line_number":71,"context_line":"                context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":72,"context_line":"        except AttributeError:"},{"line_number":73,"context_line":"            context \u003d None"},{"line_number":74,"context_line":"        return context"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_setup(self):"},{"line_number":77,"context_line":"        credential \u003d \u0027user\u003d{}\u0026password\u003d{}\u0026Login\u003dLogin\u0027.format("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_052f4c3f","line":74,"range":{"start_line":59,"start_character":4,"end_line":74,"end_character":22},"in_reply_to":"ba2be162_2543a543","updated":"2017-03-06 02:47:46.000000000","message":"If vendors use the url_request/urllib2, they probably need this, As I found, most of them are using third party libs which do not need to interact with ssl module directly.\n\nI Will move it to manila/utils.py","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"188450581ee0f22330cb6a7fa95cf2b2e2928628","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return context"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_setup(self):"},{"line_number":77,"context_line":"        credential \u003d \u0027user\u003d{}\u0026password\u003d{}\u0026Login\u003dLogin\u0027.format("},{"line_number":78,"context_line":"            self.username, self.password)"},{"line_number":79,"context_line":"        req \u003d url_request.Request(self.auth_url, credential,"},{"line_number":80,"context_line":"                                  constants.CONTENT_TYPE_URLENCODE)"},{"line_number":81,"context_line":"        resp \u003d self.url_opener.open(req)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_c52c899b","line":78,"range":{"start_line":77,"start_character":8,"end_line":78,"end_character":41},"updated":"2017-03-03 13:28:07.000000000","message":"This change is unrelated to the scope of this commit.","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"a7cd7da89f28bd07953a6a0ffd1f2da0f97fd053","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return context"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _do_setup(self):"},{"line_number":77,"context_line":"        credential \u003d \u0027user\u003d{}\u0026password\u003d{}\u0026Login\u003dLogin\u0027.format("},{"line_number":78,"context_line":"            self.username, self.password)"},{"line_number":79,"context_line":"        req \u003d url_request.Request(self.auth_url, credential,"},{"line_number":80,"context_line":"                                  constants.CONTENT_TYPE_URLENCODE)"},{"line_number":81,"context_line":"        resp \u003d self.url_opener.open(req)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_456dc4ca","line":78,"range":{"start_line":77,"start_character":8,"end_line":78,"end_character":41},"in_reply_to":"ba2be162_c52c899b","updated":"2017-03-06 02:47:46.000000000","message":"Sure, will revert.","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"}],"manila/utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e0c37ac3872bc61faeb604fd806d54778bfffd1b","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            context \u003d ssl.create_default_context()"},{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        context \u003d None"},{"line_number":612,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_378068c0","line":611,"range":{"start_line":610,"start_character":4,"end_line":611,"end_character":22},"updated":"2017-03-09 11:48:34.000000000","message":"1) Why do you mock AttributeError?\n2) Why no logging of observed error? It is very-very tricky. If I get such error because of some bug, I can think I have SSL enabled when it is not so indeed.","commit_id":"e4e17ef8844f492b7cf86003b0f1d94978f1f4f2"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"250f0a109a6cdd8d9ad4a49b7db19e7fa71feecb","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            context \u003d ssl.create_default_context()"},{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        context \u003d None"},{"line_number":612,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_997cc7b6","line":611,"range":{"start_line":610,"start_character":4,"end_line":611,"end_character":22},"in_reply_to":"9a30ddce_378068c0","updated":"2017-03-10 01:33:37.000000000","message":"Hi Valeriy\nSorry for the confusion.\nssl doesn\u0027t have create_default_context before python 2.7.9.\n\nSo ssl.create_default_context is to keep comparability with early version python\n\nI shall log information and comment here to mitigate your concern.","commit_id":"e4e17ef8844f492b7cf86003b0f1d94978f1f4f2"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e4a06eb8e2445ca0abc5d4748c7134693462e87c","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            context \u003d ssl.create_default_context()"},{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        context \u003d None"},{"line_number":612,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_4b1fcc07","line":611,"range":{"start_line":610,"start_character":4,"end_line":611,"end_character":22},"in_reply_to":"9a30ddce_997cc7b6","updated":"2017-03-10 08:45:44.000000000","message":"Here is the trace.\n\nPython 2.7.6 (default, Oct 26 2016, 20:30:19)\n\nIn [1]: import ssl\n\nIn [2]: ssl.create_default_context()\n---------------------------------------------------------------------------\nAttributeError: \u0027module\u0027 object has no attribute \u0027create_default_context\u0027","commit_id":"e4e17ef8844f492b7cf86003b0f1d94978f1f4f2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9a88068317f11e9cb83d7f83cad86be27e57cc67","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            context \u003d ssl.create_default_context()"},{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        LOG.info(_LI(\u0027Creating ssl context is not supported on this version \u0027"},{"line_number":612,"context_line":"                     \u0027of Python, ssl verification is disabled.\u0027))"},{"line_number":613,"context_line":"        context \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_195d1347","line":610,"range":{"start_line":610,"start_character":3,"end_line":610,"end_character":26},"updated":"2017-03-10 18:02:14.000000000","message":"Why you chose usage of \"try-except\" block instead of following version check?:\n\n\"\"\"\nimport sys\n\nif sys.version_info \u003e (2, 7, 8):\n    %do your SSL stuff here%\n\n\"\"\"","commit_id":"f1c4a9bd2dc5770e16160e81daafaa354951d7f8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5625ceab3348f40e2a1bcf1ec29d562b823934d8","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            context \u003d ssl.create_default_context()"},{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        LOG.info(_LI(\u0027Creating ssl context is not supported on this version \u0027"},{"line_number":612,"context_line":"                     \u0027of Python, ssl verification is disabled.\u0027))"},{"line_number":613,"context_line":"        context \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_b41fae59","line":610,"range":{"start_line":610,"start_character":3,"end_line":610,"end_character":26},"in_reply_to":"9a30ddce_195d1347","updated":"2017-03-10 18:05:52.000000000","message":"because it\u0027s pythonic.\n\nEAFP\nEasier to ask for forgiveness than permission. This common Python coding style assumes the existence of valid keys or attributes and catches exceptions if the assumption proves false. This clean and fast style is characterized by the presence of many try and except statements. The technique contrasts with the LBYL style common to many other languages such as C\n\nhttps://docs.python.org/3/glossary.html","commit_id":"f1c4a9bd2dc5770e16160e81daafaa354951d7f8"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"ca54cb6a5ad589152cf22c53638af690d382bf7d","unresolved":false,"context_lines":[{"line_number":607,"context_line":"            context \u003d ssl.create_default_context()"},{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        LOG.info(_LI(\u0027Creating ssl context is not supported on this version \u0027"},{"line_number":612,"context_line":"                     \u0027of Python, ssl verification is disabled.\u0027))"},{"line_number":613,"context_line":"        context \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_fb39fba4","line":610,"range":{"start_line":610,"start_character":3,"end_line":610,"end_character":26},"in_reply_to":"9a30ddce_b41fae59","updated":"2017-03-13 02:47:52.000000000","message":"Yes, I do not want to leave too many version detections in functional code.","commit_id":"f1c4a9bd2dc5770e16160e81daafaa354951d7f8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c892af90f3bcb28a5aef55060a8bdb6efe96778e","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        LOG.info(_LI(\u0027Creating ssl context is not supported on this version \u0027"},{"line_number":612,"context_line":"                     \u0027of Python, ssl verification is disabled.\u0027))"},{"line_number":613,"context_line":"        context \u003d None"},{"line_number":614,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_ce490562","line":611,"range":{"start_line":611,"start_character":12,"end_line":611,"end_character":16},"updated":"2017-03-10 10:59:05.000000000","message":"my personal feeling is that a warning would be more appropriate, so the admin can see and take the action of updating the python version in order to support SSL.","commit_id":"f1c4a9bd2dc5770e16160e81daafaa354951d7f8"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"ca54cb6a5ad589152cf22c53638af690d382bf7d","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            context.check_hostname \u003d False"},{"line_number":609,"context_line":"            context.verify_mode \u003d ssl.CERT_NONE"},{"line_number":610,"context_line":"    except AttributeError:"},{"line_number":611,"context_line":"        LOG.info(_LI(\u0027Creating ssl context is not supported on this version \u0027"},{"line_number":612,"context_line":"                     \u0027of Python, ssl verification is disabled.\u0027))"},{"line_number":613,"context_line":"        context \u003d None"},{"line_number":614,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a30ddce_1bd6cf4e","line":611,"range":{"start_line":611,"start_character":12,"end_line":611,"end_character":16},"in_reply_to":"9a30ddce_ce490562","updated":"2017-03-13 02:47:52.000000000","message":"Done","commit_id":"f1c4a9bd2dc5770e16160e81daafaa354951d7f8"}],"releasenotes/notes/add-ssl-verify-options-2287ae7b40e3ae83.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2a8f552b3b1567a8f8e42513983b67c5a2712f00","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba2be162_7e9a926f","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":58},"updated":"2017-03-03 13:00:36.000000000","message":"Link?","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"a7cd7da89f28bd07953a6a0ffd1f2da0f97fd053","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba2be162_65ad689a","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":58},"in_reply_to":"ba2be162_7e9a926f","updated":"2017-03-06 02:47:46.000000000","message":"Sure, will add","commit_id":"d607f4703471cd7e630411c3fbe5771a5d06605a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6a247f0b257c59788f9a3c6c48889c987706ce68","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation(https://docs.openstack.org/ocata/config-reference/shared-file-systems/config-options.html)."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba2be162_51fc98b7","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":58},"updated":"2017-03-06 11:10:32.000000000","message":"add a space between \u0027n\u0027 and \u0027(\u0027","commit_id":"adf08225de545436d0787ca79b60c7a3edbe75e1"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e0eff9e46295706897f383b2075c63f38b5ca64d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation(https://docs.openstack.org/ocata/config-reference/shared-file-systems/config-options.html)."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a30ddce_0140fe55","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":58},"in_reply_to":"ba2be162_51fc98b7","updated":"2017-03-07 01:11:39.000000000","message":"Done","commit_id":"adf08225de545436d0787ca79b60c7a3edbe75e1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"71e89576cf0b9507e5bd4f82af8cc473f616f241","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation (https://docs.openstack.org/ocata/config-reference/shared-file-systems/config-options.html)."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a30ddce_816b2084","line":6,"updated":"2017-03-13 14:00:57.000000000","message":"This patch will be merged into Pike.  Why are you reference the doc for Ocata?","commit_id":"f1539ceff50a0c174bde4dfd82ecf03014b06ee8"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"60c0e42c9a269aae280a65df021c56ec0096e26c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation (https://docs.openstack.org/ocata/config-reference/shared-file-systems/config-options.html)."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3a1ff146_cddc6149","line":6,"in_reply_to":"3a1ff146_aa162ba5","updated":"2017-03-14 14:56:48.000000000","message":"link removed.","commit_id":"f1539ceff50a0c174bde4dfd82ecf03014b06ee8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"25912c418710e7d363a59b30af24ba002cecea37","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation (https://docs.openstack.org/ocata/config-reference/shared-file-systems/config-options.html)."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3a1ff146_aa162ba5","line":6,"in_reply_to":"7a25e98e_544b8e2b","updated":"2017-03-14 14:40:55.000000000","message":"That is fine with me.  Thanks.","commit_id":"f1539ceff50a0c174bde4dfd82ecf03014b06ee8"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"46a1353ea8164a2de3660c81dab44476b7c20ac9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation (https://docs.openstack.org/ocata/config-reference/shared-file-systems/config-options.html)."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a25e98e_544b8e2b","line":6,"in_reply_to":"9a30ddce_816b2084","updated":"2017-03-14 01:32:01.000000000","message":"How about just remove the link here? any suggestion?\n\nThanks\nPeter","commit_id":"f1539ceff50a0c174bde4dfd82ecf03014b06ee8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6304f14dfb20a19f003bdcafdad1243fe4f72352","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a1ff146_93bb6675","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":57},"updated":"2017-03-14 15:46:32.000000000","message":"documentation","commit_id":"dd8fc3ab0d5aa177443088c0a8b3bcfab47e3291"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"422adc9ba19c1af5706afa25a30de78ec35305bf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added following 2 options for SSL verification"},{"line_number":4,"context_line":"    ``driver_ssl_cert_verify``"},{"line_number":5,"context_line":"    ``driver_ssl_cert_path``"},{"line_number":6,"context_line":"    For more details, see OpenStack official documetation."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a1ff146_fdcff6b0","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":57},"in_reply_to":"3a1ff146_93bb6675","updated":"2017-03-15 01:02:22.000000000","message":"Done","commit_id":"dd8fc3ab0d5aa177443088c0a8b3bcfab47e3291"}]}
