)]}'
{"manila/tests/share/drivers/maprfs/test_maprfs.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"9e72da25a786e22120777e42efba3656f6fa1b79","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        self.assertRaises(exception.ProcessExecutionError,"},{"line_number":638,"context_line":"                          self._driver._maprfs_util._execute, \"fake\", \"cmd\")"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def test__execute_local(self):"},{"line_number":641,"context_line":"        self.mock_object(utils, \u0027execute\u0027, mock.Mock(return_value\u003d(\"fake\", 0)))"},{"line_number":642,"context_line":"        self._driver._maprfs_util.local_hosts \u003d ("},{"line_number":643,"context_line":"            self._driver.configuration.maprfs_clinode_ip)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        self._driver._maprfs_util._execute(\"fake\", \"cmd\")"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_b98532ae","line":643,"range":{"start_line":640,"start_character":2,"end_line":643,"end_character":57},"updated":"2017-03-02 15:37:09.000000000","message":"I prefered to change the sequence of initialization code in setUp method([1] and [2]), The author wants to initializa the driver with mocked value, but the sequence is incorrect.\n\n[1] https://github.com/openstack/manila/blob/master/manila/tests/share/drivers/maprfs/test_maprfs.py#L85 \n\n[2] https://github.com/openstack/manila/blob/master/manila/tests/share/drivers/maprfs/test_maprfs.py#L53","commit_id":"156c93fdf1c53d00057ae035d1db8b2a2af192cc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c6c3f0b01b0391375180598b17d3b9430c768374","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        self.assertRaises(exception.ProcessExecutionError,"},{"line_number":638,"context_line":"                          self._driver._maprfs_util._execute, \"fake\", \"cmd\")"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def test__execute_local(self):"},{"line_number":641,"context_line":"        self.mock_object(utils, \u0027execute\u0027, mock.Mock(return_value\u003d(\"fake\", 0)))"},{"line_number":642,"context_line":"        self._driver._maprfs_util.local_hosts \u003d ("},{"line_number":643,"context_line":"            self._driver.configuration.maprfs_clinode_ip)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        self._driver._maprfs_util._execute(\"fake\", \"cmd\")"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_18bc75db","line":643,"range":{"start_line":640,"start_character":2,"end_line":643,"end_character":57},"in_reply_to":"ba2be162_b98532ae","updated":"2017-03-02 16:23:06.000000000","message":"Ok, done.","commit_id":"156c93fdf1c53d00057ae035d1db8b2a2af192cc"}]}
